On 2/13/19 5:23 PM, John Snow wrote:
> Simply move the big status enum comment block to above the status
> function, and document it as being deprecated. The whole confusing
> block can get deleted in three releases time.
>
> Signed-off-by: John Snow
> ---
> block/dirty-bitmap.c | 36 +++
On 2/13/19 5:23 PM, John Snow wrote:
> "Frozen" was a good description a long time ago, but it isn't adequate now.
> Rename the frozen predicate to has_successor to make the semantics of the
> predicate more clear to outside callers.
>
> In the process, remove some calls to frozen() that no longer
On 2/13/19 5:23 PM, John Snow wrote:
> The current API allows us to report a single status, which we've defined as:
>
> Frozen: has a successor, treated as qmp_locked, may or may not be enabled.
> Locked: no successor, qmp_locked. may or may not be enabled.
> Disabled: Not frozen or locked, disabl
Simply move the big status enum comment block to above the status
function, and document it as being deprecated. The whole confusing
block can get deleted in three releases time.
Signed-off-by: John Snow
---
block/dirty-bitmap.c | 36 +++-
1 file changed, 19 inser
These mean the same thing now. Unify them and rename the merged call
bdrv_dirty_bitmap_busy to indicate semantically what we are describing,
as well as help disambiguate from the various _locked and _unlocked
versions of bitmap helpers that refer to mutex locks.
Signed-off-by: John Snow
Reviewed-
Instead of implying a locked status, make it explicit.
Now, bitmaps in use by migration, NBD or backup operations
are all treated the same way with the same code paths.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
---
block/dirty-bitmap.c | 9 +
1 file changed, 5 insertions(+), 4 de
Currently, enabled means something like "the status of the bitmap
is ACTIVE." After this patch, it should mean exclusively: "This
bitmap is recording guest writes, and is allowed to do so."
In many places, this is how this predicate was already used.
We'll allow users to call user_locked if they'r
"Frozen" was a good description a long time ago, but it isn't adequate now.
Rename the frozen predicate to has_successor to make the semantics of the
predicate more clear to outside callers.
In the process, remove some calls to frozen() that no longer semantically
make sense. For enabled and disab
The current API allows us to report a single status, which we've defined as:
Frozen: has a successor, treated as qmp_locked, may or may not be enabled.
Locked: no successor, qmp_locked. may or may not be enabled.
Disabled: Not frozen or locked, disabled.
Active: Not frozen, locked, or disabled.
T
The current internal meanings of "locked", "user_locked",
"qmp_locked", "frozen", "enabled", and "disabled" are all
a little muddled.
Deprecate the @status field in favor of two new booleans
that carry very specific meanings. Then, rename and rework
some of the internal semantics to help make the
Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use
of @flags as a subset of virDomainXMLFlags, documenting that 2 of the
3 flags defined at the time would never be valid. Later, commit
28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but
did not adjust the save
Commit f609cb85 (0.9.5) introduced virDomainSnapshotGetXMLDesc()'s use
of @flags as a subset of virDomainXMLFlags, documenting that 2 of the
3 flags defined at the time would never be valid. Later, commit
28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but
did not adjust the sna
Nir has asked that my upcoming checkpoint APIs have a way to do
bulk operations: grab the XML for ALL checkpoints in one call,
and in turn redefine checkpoints on a new host using the dumped
XML from an old host in one call. But since checkpoints borrow
heavily from the APIs used for snapshots, it
Commit 28f8dfdc (1.0.0) added a flag to virDomainGetXMLDesc, but
failed to document its effects.
Signed-off-by: Eric Blake
---
src/libvirt-domain.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 54ca18f249..6158382d07
On 2/13/19 3:58 PM, John Ferlan wrote:
>
>
> On 2/12/19 11:33 PM, Eric Blake wrote:
>> The code for creating external snapshots for an offline domain
>> called out to qemu-img without escaping commas in the manner
>> that qemu-img expects. This also fixes a typo in the comment.
>>
>> Signed-off-b
On 2/12/19 11:33 PM, Eric Blake wrote:
> The code for creating external snapshots for an offline domain
> called out to qemu-img without escaping commas in the manner
> that qemu-img expects. This also fixes a typo in the comment.
>
> Signed-off-by: Eric Blake
> ---
>
> Noticed by code inspec
On 2/8/19 10:08 AM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> tools/virsh-domain.c | 19 +++
> tools/virsh.pod | 7 +++
> 2 files changed, 26 insertions(+)
>
Should supplying parallel-connections imply parallel since the previous
patch would fail:
On 2/8/19 10:08 AM, Jiri Denemark wrote:
> The VIR_MIGRATE_PARALLEL flag is implemented using QEMU's multifd
> migration capability and the corresponding multifd-channels migration
> parameter.
>
> Signed-off-by: Jiri Denemark
> ---
>
> Notes:
> QEMU still uses the x- prefix for multifd c
On 2/8/19 10:08 AM, Jiri Denemark wrote:
> This patch adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which
> will ask the hypervisor to use multiple parallel connections for
> migrating a domain. The number of parallel connections can be set using
> VIR_MIGRATE_PARAM_PARALLEL_CONNECTION
We know exactly which packages we need and don't want apt
picking extra "recommended" ones for us.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool
index a7bcae3
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index 1271954..0978c40 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -529,15 +529,18 @@ class Application:
if
Every statement in a dockerfile results in a new layer in the
image. There is no need for an env var to store the package list
when it can be included inline. This avoids the env variable being
later exposed to the container at runtime.
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 18 +
The root cause exception contains the useful information about what
really failed during loading of some resource, or running of a
command.
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 54 +-
1 file changed, 27 insertions(+), 27 deletions
Debian's filesystem layout has a nice advantage over Fedora which is
that it can install non-native RPMs in the main root filesystem. It is
thus possible to prepare an x86_64 filesystem containing -dev packages
for a foreign architecture, along with a GCC cross compiler.
QEMU has used this techniq
Changed in v3:
- Remove sheepdog more generally
- Use .format() style printf
- Split config to cross-build.yml
- Make glusterfs name per-distro customized
- Misc code style changes
- Rename fields in cross-build.yml
- Don't use crossbuild-essential packages
Changed in v2:
- Fix multiple
The libpcap-dev package is a temporary backcompat package until
everything switches to the new libpcap0.8-dev pacakge name.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
guests/vars/mappings.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guests/var
We want the development headers not the client binary
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
guests/vars/mappings.yml | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index e10e3da..0945e36
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool
index bd32d1f..a7bcae3 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -541,7 +541,8 @@ class Application:
if package_format ==
Signed-off-by: Daniel P. Berrangé
---
guests/vars/mappings.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 0945e36..f31b460 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -774,6 +774,7 @@ mappings:
def
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
guests/vars/mappings.yml | 4
guests/vars/projects/libvirt.yml | 1 +
2 files changed, 5 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index f211169..e10e3da 100644
--- a/guests/var
On Thu, Feb 07, 2019 at 04:21:34PM +0100, Andrea Bolognani wrote:
> On Tue, 2019-02-05 at 17:53 +, Daniel P. Berrangé wrote:
> [...]
> > With the Debian 9 distro, this supports arm64, armel, armhf, mips,
> > mipsel, mips64el, ppc64el, s390x, which are all the official archs
> > that Debian main
On Wed, Feb 06, 2019 at 05:21:36PM +0100, Andrea Bolognani wrote:
> On Tue, 2019-02-05 at 17:53 +, Daniel P. Berrangé wrote:
> [...]
> > if package_format == "deb":
> > sys.stdout.write(textwrap.dedent("""
> > -RUN apt-get update && \\
> > -
On 12/11/18 7:26 AM, luzhip...@uniudc.com wrote:
> From: ZhiPeng Lu
>
> This patch adds functionality to allow libvirt to configure the 'dot1q-tunnel'
> modes(802.1ad double-tagged) on openvswitch networks.
> For example:
>
>
>
>
>
>
>
>
On 2/8/19 2:52 AM, Nikolay Shirokovskiy wrote:
> Patches 1 and 2 are already Reviewed-by: John. Patch 3 needs Peter comments.
>
Right - feel free to add my :
Reviewed-by: John Ferlan
to the first 2 patches for sure.
To help push this along, Peter is again CC'd and of importance is the v1
r
[...]
>>
>> In testing with your patches, I did find I could only do at most one
>> attach/detach cycle - a second attach for a running guest results in:
>>
>> error: internal error: unable to execute QEMU command 'chardev-add':
>> attempt to add duplicate property 'charchannel0' to object (type
>
On Wed, 2019-02-13 at 11:01 -0500, Laine Stump wrote:
> commit 3bba4825 added the new function virFirewallDInterfaceSetZone()
> which calledsends virDBUSCallMethod a DBusMessage** for the reply
> message, but doesn't use the reply, and also doesn't free it. Since
> this arg is allowed to be NULL, t
On Wed, 2019-02-13 at 13:29 +0100, Ján Tomko wrote:
> On Wed, Feb 13, 2019 at 10:59:28AM +0100, Andrea Bolognani wrote:
> > On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote:
> > > Also, the device will be given an iobase by QEMU, we should represent
> > > that in the XML and fill in that default.
On 2/13/19 2:39 PM, John Ferlan wrote:
On 2/13/19 5:58 AM, Michal Privoznik wrote:
On 2/12/19 11:19 PM, John Ferlan wrote:
On 2/11/19 10:40 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1624204
The guestfwd channels are -netdevs really. Hotunplug them as
such. Al
commit 3bba4825 added the new function virFirewallDInterfaceSetZone()
which calledsends virDBUSCallMethod a DBusMessage** for the reply
message, but doesn't use the reply, and also doesn't free it. Since
this arg is allowed to be NULL, this patch simply sets it to NULL so
we don't have to deal with
On Wed, 2019-02-13 at 15:07 +0100, Ján Tomko wrote:
> On Wed, Feb 13, 2019 at 02:18:32PM +0100, Andrea Bolognani wrote:
> > Are the backslashes at the end of lines necessary?
>
> In this patch? Yes. The aim is to preserve the test coverage done before
> and after.
>
> > I've tried
> > removing a
On 2/13/19 7:38 AM, Marc Hartmayer wrote:
> Even if an error is reported by `udev_enumerate_scan_devices`,
> e.g. because a driver of a device has an bug, we can still enumerate
> all other devices. Additionally the documentation of
> udev_enumerate_scan_devices says that on success an integer >
On Wed, Feb 13, 2019 at 03:03 PM +0100, John Ferlan wrote:
> On 2/13/19 4:34 AM, Marc Hartmayer wrote:
>> On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan
>> wrote:
>>> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
(
On Wed, Feb 13, 2019 at 02:18:32PM +0100, Andrea Bolognani wrote:
On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote:
[...]
+{"return": [{"filename": \
+"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server",\
+"label": "charmonitor"}, {"filename": "pty:/dev/pts/158",\
+"label": "charserial0
On 2/13/19 4:34 AM, Marc Hartmayer wrote:
> On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan
> wrote:
>> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
>>> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
>>> (9f0ae0b18e3e620) has moved the heavy task of device enumeration i
On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote:
[...]
> +++ b/tests/virjsontest.c
> @@ -114,12 +114,24 @@ static int
> testJSONAddRemove(const void *data)
> {
> const struct testInfo *info = data;
> -virJSONValuePtr json;
> +virJSONValuePtr json = NULL;
> virJSONValuePtr nam
On 2/13/19 5:58 AM, Michal Privoznik wrote:
> On 2/12/19 11:19 PM, John Ferlan wrote:
>>
>>
>> On 2/11/19 10:40 AM, Michal Privoznik wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1624204
>>>
>>> The guestfwd channels are -netdevs really. Hotunplug them as
>>> such. Also, DEVICE_DELETED e
On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote:
[...]
> +{"return":[{"filename":\
> +"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server",\
> +"label":"charmonitor"},{"filename":"pty:/dev/pts/158",\
> +"label":"charserial0"}],"id":"libvirt-3"}
Same questions as the previous patch when it
On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote:
[...]
> +{"return": [{"filename": \
> +"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server",\
> +"label": "charmonitor"}, {"filename": "pty:/dev/pts/158",\
> +"label": "charserial0"}], "id": "libvirt-3"}
Are the backslashes at the end of li
Even if an error is reported by `udev_enumerate_scan_devices`,
e.g. because a driver of a device has an bug, we can still enumerate
all other devices. Additionally the documentation of
udev_enumerate_scan_devices says that on success an integer >= 0 is
returned (see man udev_enumerate_scan_devices(
On Wed, Feb 13, 2019 at 10:59:28AM +0100, Andrea Bolognani wrote:
On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote:
On Tue, Feb 12, 2019 at 05:21:56PM +0100, Andrea Bolognani wrote:
> On Tue, 2019-02-12 at 16:07 +0100, Ján Tomko wrote:
> > > > There should be no pressure to maintain the 1:1 ma
The newline was pretty arbitrary, and we're better off
without it.
Signed-off-by: Andrea Bolognani
---
src/util/iohelper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/iohelper.c b/src/util/iohelper.c
index 1ff4a7b314..aed7ef3184 100644
--- a/src/util/iohelper.c
+
Logging the error is fine and all, but getting the information
to the user directly is even better.
https://bugzilla.redhat.com/show_bug.cgi?id=1578741
Signed-off-by: Andrea Bolognani
---
src/util/virfile.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/util/virfile
The memory allocated by VIR_REALLOC_N() is uninitialized,
which means it's not possible to figure out whether any
output was produced at all after the fact.
Since we don't care about the previous contents of buffers,
if any, use VIR_FREE() followed by VIR_ALLOC_N() instead.
Signed-off-by: Andrea
Changes from [v1]:
* Use VIR_FREE() followed by VIR_ALLOC_N() instead of manually
setting the last (and only) byte of the array returned by
VIR_REALLOC_N() to zero.
[v1] https://www.redhat.com/archives/libvir-list/2019-February/msg00156.html
Andrea Bolognani (3):
vircommand: Ensure buffer
On 2/12/19 11:08 PM, John Ferlan wrote:
$SUBJ:
s/qemuL:/qemu:/
On 2/11/19 10:40 AM, Michal Privoznik wrote:
Introduced by d86c876a66e3.
There is no real need to have "user-" prefix for chardev.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c
On 2/12/19 11:19 PM, John Ferlan wrote:
On 2/11/19 10:40 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1624204
The guestfwd channels are -netdevs really. Hotunplug them as
such. Also, DEVICE_DELETED event is not triggered (surprisingly,
since we're not issuing device
On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote:
> On Tue, Feb 12, 2019 at 05:21:56PM +0100, Andrea Bolognani wrote:
> > On Tue, 2019-02-12 at 16:07 +0100, Ján Tomko wrote:
> > > > > There should be no pressure to maintain the 1:1 mapping.
> > > > > For QEMU, the devices need to be represented i
On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan wrote:
> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
>> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
>> (9f0ae0b18e3e620) has moved the heavy task of device enumeration into
>> a separate thread. The problem with this comm
On Tue, Feb 12, 2019 at 05:21:56PM +0100, Andrea Bolognani wrote:
On Tue, 2019-02-12 at 16:07 +0100, Ján Tomko wrote:
On Tue, Feb 12, 2019 at 02:44:05PM +, Nikolay Shirokovskiy wrote:
> On 12.02.2019 17:37, Ján Tomko wrote:
> > On Thu, Feb 07, 2019 at 02:31:47PM +0300, Nikolay Shirokovskiy w
On Tue, 2019-02-12 at 17:40 +0100, Ján Tomko wrote:
> Instead of using EMPTY_?STR with various meanings,
> use a family of NULLSTR_.+ macros
I didn't check particularly well, but you seem to have missed a few:
src/util/viriptables.c:portRangeStr ?
portRangeStr : "")
On Tue, 2019-02-12 at 17:40 +0100, Ján Tomko wrote:
> This time even in places that would possibly better be served by
> a more complex macro.
>
> Can be squashed into the previous patch if requested.
I agree that the level of repetition might call for a local macro,
but you can do that in a foll
On Tue, 2019-02-12 at 17:40 +0100, Ján Tomko wrote:
> Instead of repetitive:
> s ? s : ""
> use NULLSTR_EMPTY.
>
> Signed-off-by: Ján Tomko
> ---
> src/datatypes.c | 2 +-
> src/libvirt-admin.c | 2 +-
> src/libvirt.c| 2 +-
> src/lxc/lxc_co
On Tue, 2019-02-12 at 17:40 +0100, Ján Tomko wrote:
> Another misleadingly named macro.
> Deprecate in favor of NULLSTR_STAR.
>
> Signed-off-by: Ján Tomko
> ---
> src/util/virlease.c | 15 ---
> 1 file changed, 4 insertions(+), 11 deletions(-)
Reviewed-by: Andrea Bolognani
--
And
On Tue, 2019-02-12 at 17:40 +0100, Ján Tomko wrote:
> This macro neither takes nor produces an empty string.
> Remove it in favor of NULLSTR_MINUS.
>
> Signed-off-by: Ján Tomko
> ---
> src/internal.h| 5 -
> tools/virsh-network.c | 10 +-
> 2 files changed, 5 insertions(+),
On Tue, 2019-02-12 at 17:40 +0100, Ján Tomko wrote:
> Use the newly introduced macro in the few places that open-code it.
>
> Signed-off-by: Ján Tomko
> ---
> tools/virsh-domain-monitor.c | 4 ++--
> tools/virsh-snapshot.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewe
On Tue, 2019-02-12 at 17:40 +0100, Ján Tomko wrote:
> NULLSTR_EMPTY, the quiet child,
> NULLSTR_STAR, the famous one and
> NULLSTR_MINUS, the grumpy one.
>
> Signed-off-by: Ján Tomko
> ---
> src/internal.h | 15 +++
> 1 file changed, 15 insertions(+)
10/10 commit message, would
R
On Fri, 2019-02-08 at 17:11 -0500, Cole Robinson wrote:
> v2 libvirt patches:
> https://www.redhat.com/archives/libvir-list/2019-January/msg00877.html
> v1 libvirt patches:
> https://www.redhat.com/archives/libvir-list/2019-January/msg00593.html
> Previous incomplete RFC here:
> https://www.redhat.
67 matches
Mail list logo
