Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

At 2019-08-16 23:10:31, "Laine Stump" wrote: >The fact that you are modifying this code implies that you are using it, >and that implies that you are still using legacy KVM device assignment >(i.e. the pcistub driver) instead of VFIO device assignment. (I say this >because the function that

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: virt-manager-check » libvirt-fedora-30 #1020

On 8/19/19 3:44 PM, c...@centos.org wrote: > See > > > -- > Started by upstream project "virt-manager-check" build number 1020 > originally caused by: > Started

Re: [libvirt] [PATCHv2 00/11] util/resctrl cleanups and refactors

On 7/31/19 8:37 AM, Michal Privoznik wrote: > On 6/11/19 5:31 AM, Wang Huaqiang wrote: >> Patches submitted for purpose of refactoring existing 'resctrl' related >> source code, including some code cleanups as well as some fixes. This is >> also a preparation for memory bandwidth monitor codes. >>

Re: [libvirt] [PATCH] ci: Comment tweaks in Makefile.ci

On 8/8/19 9:34 AM, Eric Blake wrote: > Fix some typos and grammar (calling something safer and error-prone is > odd, and 'ther eneeds' is an obvious typo), and reflow some long > lines. > > Signed-off-by: Eric Blake > --- > Makefile.ci | 38 +- > 1 file

Re: [libvirt] [PATCH 1/1] qemuxml2xmltest.c: mock /etc/qemu/firmware path

Hey Cole, On 8/19/19 6:49 PM, Cole Robinson wrote: On 8/12/19 11:06 AM, Daniel Henrique Barboza wrote: Since commit 'b66ca0220a' the 'tpm-emulator' tests in qemuxml2xmltest started to fail unless 'make check' is either executed as root or with an user with access to /etc/qemu/firmware file.

Re: [libvirt] [PATCH 1/1] qemuxml2xmltest.c: mock /etc/qemu/firmware path

On 8/12/19 11:06 AM, Daniel Henrique Barboza wrote: > Since commit 'b66ca0220a' the 'tpm-emulator' tests in qemuxml2xmltest > started to fail unless 'make check' is either executed as root > or with an user with access to /etc/qemu/firmware file. This is the > error that happens in a regular 'make

[libvirt] [PATCH] mdev: point user to mdevctl for missing devices

When a host is rebooted, any mediated devices that were previously configured will disappear. There have been requests for libvirt to handle persisting these mediated devices across reboots, but the decision was made that this should be handled at a lower level. mdevctl is a new tool that handles

Re: [libvirt] [PATCH] src: Don't check lxc_monitor_protocol-struct when LXC is disabled

On 8/14/19 10:13 AM, Michal Privoznik wrote: If LXC is disabled at build time then there is no libvirt_driver_lxc_impl_la-*.lo to run the 'check-protocol' against. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza src/Makefile.am | 2 ++ 1 file changed, 2

[libvirt] [jenkins-ci PATCH] guests: remove obsolete install of intltool

libvirt-glib, libvirt-sandbox and virt-viewer have all ditched usage of intltool, so this no longer needs to be installed. Signed-off-by: Daniel P. Berrangé --- guests/vars/projects/libvirt-glib.yml| 1 - guests/vars/projects/libvirt-sandbox.yml | 1 - guests/vars/projects/virt-viewer.yml

Re: [libvirt] [PATCH v3 2/2] snapshot: Store both config and live XML in the snapshot domain

On 8/14/19 11:47 AM, Maxiwell S. Garcia wrote: The snapshot-create operation of running guests saves the live XML and uses it to replace the active and inactive domain in case of revert. So, the config XML is ignored by the snapshot process. This commit changes it and adds the config XML in

Re: [libvirt] [PATCH v3 1/2] qemu: formatting XML from domain def choosing the root name

On 8/14/19 11:47 AM, Maxiwell S. Garcia wrote: The function virDomainDefFormatInternal() has the predefined root name "domain" to format the XML. But to save both active and inactive domain in the snapshot XML, the new root name "inactiveDomain" was created. So, this function was modified to

Re: [libvirt] [PATCH] qemu: alias: Generate 'qomName' of disk with useraliases

On Fri, Aug 16, 2019 at 05:18:14PM +0200, Peter Krempa wrote: Commit fb64e176f4f forgot to delete the check that short-circuits the disk alias creation if the alias is already present. The side efect effect of this is that the creation qomName which is necessary to be able to refer to disk

Re: [libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

On 5/24/19 10:35 AM, Michal Privoznik wrote: > Separate storage pool definition assignment into a function. > > Signed-off-by: Michal Privoznik > --- > src/conf/virstorageobj.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

On 8/19/19 7:22 AM, Michal Privoznik wrote: > On 8/16/19 5:10 PM, Laine Stump wrote: > > > > To extend this question - there's also xen's pciback, but I don't know enough > about Xen to tell if it's still in use. Yes, it is still in use. > Might be worth dropping that too, > becasue it looks

Re: [libvirt] [PATCH] util: mdev: support persistent devices with mdevctl

On 8/19/19 4:48 PM, Jonathon Jongsma wrote: On Wed, 2019-08-14 at 16:14 +0200, Boris Fiuczynski wrote: On 8/14/19 12:02 AM, Jonathon Jongsma wrote: When a host is rebooted, mediated devices disappear from sysfs. mdevctl (https://github.com/mdevctl/mdevctl) is a utility for managing and

Re: [libvirt] [glib PATCH 0/2] Fix build failures on Fedora rawhide due to new glib

On 8/19/19 3:47 PM, Daniel P. Berrangé wrote: Daniel P. Berrangé (2): gobject: remove use of G_PARAM_PRIVATE Set desired glib min/max API versions configure.ac | 2 ++ libvirt-gconfig/Makefile.am | 2 ++

Re: [libvirt] [PATCH v2] maint: Improve use of configmake.h on mingw

On Thu, Aug 08, 2019 at 09:17:19AM -0500, Eric Blake wrote: Gnulib has added a patch that allows configmake.h to be included without causing build failures on mingw if is later included (whether directly, or indirectly such as through gnulib's ). This reverts commit

Re: [libvirt] [PATCH] util: mdev: support persistent devices with mdevctl

On Wed, 2019-08-14 at 16:14 +0200, Boris Fiuczynski wrote: > On 8/14/19 12:02 AM, Jonathon Jongsma wrote: > > When a host is rebooted, mediated devices disappear from > > sysfs. mdevctl > > (https://github.com/mdevctl/mdevctl) is a utility for managing and > > persisting these devices. It

Re: [libvirt] [PATCH v1 09/11] storagePoolCreateXML: Don't lose persistent storage on failed create

On Fri, May 24, 2019 at 04:35:45PM +0200, Michal Privoznik wrote: If there's a persistent storage and user tries to start a new one with the same name and UUID (e.g. to test new configuration) it may happen that upon failure we lose the persistent defintion. Fortunately, we don't remove it from

Re: [libvirt] [PATCH v1 08/11] virstorageobj: Introduce VIR_STORAGE_POOL_OBJ_LIST_ADD_LIVE flag

On Fri, May 24, 2019 at 04:35:44PM +0200, Michal Privoznik wrote: This flag can be used to denote that the definition we're trying to assign to a pool object is live definition and thus the inactive definition should be saved into ->newDef. Signed-off-by: Michal Privoznik ---

Re: [libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

On Fri, May 24, 2019 at 04:35:43PM +0200, Michal Privoznik wrote: Separate storage pool definition assignment into a function. Signed-off-by: Michal Privoznik --- src/conf/virstorageobj.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) Reviewed-by: Ján Tomko

Re: [libvirt] [PATCH v1 06/11] virStoragePoolObjListAdd: Turn boolean arg into flags

On Fri, May 24, 2019 at 04:35:42PM +0200, Michal Privoznik wrote: There will be more boolean information that we want to pass to this function. Instead of having them in separate arguments per each one, use @flags. Signed-off-by: Michal Privoznik --- src/conf/virstorageobj.c | 16

Re: [libvirt] [PATCH v1 05/11] virstorageobj: Rename virStoragePoolObjAssignDef

On Fri, May 24, 2019 at 04:35:41PM +0200, Michal Privoznik wrote: This function is doing much more than plain assigning pool definition to a pool object. Rename it. Signed-off-by: Michal Privoznik --- src/conf/virstorageobj.c | 12 ++-- src/conf/virstorageobj.h | 6 +++---

Re: [libvirt] [PATCH v1 04/11] virStoragePoolUpdateInactive: Don't call virStoragePoolObjEndAPI

On Fri, May 24, 2019 at 04:35:40PM +0200, Michal Privoznik wrote: There is no need for this function to call virStoragePoolObjEndAPI(). The object is perfectly usable after return from this function. In fact, all callers will call virStoragePoolObjEndAPI() eventually. Signed-off-by: Michal

Re: [libvirt] [PATCH v1 03/11] storagePoolRefreshImpl: Fix variable name in comment

The commit summary mistakenly refers to 'storagePoolRefreshImpl' when in fact the function is named 'virStoragePoolUpdateInactive'. On Fri, May 24, 2019 at 04:35:39PM +0200, Michal Privoznik wrote: The function comment mistakenly refers to 'poolptr' when in fact the variable is named 'objptr'.

Re: [libvirt] [PATCH v1 02/11] virStoragePoolObjListForEach: Grab a reference for pool object

On Fri, May 24, 2019 at 04:35:38PM +0200, Michal Privoznik wrote: Turns out there's one callback that might remove a storage pool during its run: storagePoolUpdateAllState() call storagePoolUpdateStateCallback() which may call virStoragePoolUpdateInactive() which in turn may call

Re: [libvirt] [PATCH v1 01/11] virStoragePoolObjRemove: Don't unlock pool object upon return

On Fri, May 24, 2019 at 04:35:37PM +0200, Michal Privoznik wrote: The fact that we're removing a pool object from the list of pools doesn't mean we want to unlock it. It violates locking policy too as object locking and unlocking is not done on the same level. Signed-off-by: Michal Privoznik

[libvirt] [glib PATCH 0/2] Fix build failures on Fedora rawhide due to new glib

Daniel P. Berrangé (2): gobject: remove use of G_PARAM_PRIVATE Set desired glib min/max API versions configure.ac | 2 ++ libvirt-gconfig/Makefile.am | 2 ++ libvirt-glib/Makefile.am | 2 ++

[libvirt] [glib PATCH 1/2] gobject: remove use of G_PARAM_PRIVATE

This enum field is a deprecated synonym for G_PARAM_STATIC_NAME which is already set by G_PARAM_STATIC_STRINGS. Signed-off-by: Daniel P. Berrangé --- libvirt-gobject/libvirt-gobject-network-dhcp-lease.c | 1 - 1 file changed, 1 deletion(-) diff --git

[libvirt] [glib PATCH 2/2] Set desired glib min/max API versions

Setting GLIB_VERSION_MAX_ALLOWED ensures we get warnings if we use APIs that are newer than our declared minimum glib version. Setting GLIB_VERSION_MIN_REQUIRED ensures that we get warnings if we use APIs deprecated in versions preceeding this. If the latter is omitted then we get warnings for

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

On 8/16/19 5:10 PM, Laine Stump wrote: > To extend this question - there's also xen's pciback, but I don't know enough about Xen to tell if it's still in use. Might be worth dropping that too, becasue it looks a lot like pci-stub (used for KVM assignment). And because of that I can't really

Re: [libvirt] [PATCH 2/3] virt-aa-helper: Call virCommandRawStatus()

On Mon, Aug 19, 2019 at 12:01:41PM +0200, Andrea Bolognani wrote: The way we're processing the return status, using WIFEXITED() and friends, only works when we have the raw return status; however, virCommand defaults to processing the return status for us. Call virCommandRawStatus() before

Re: [libvirt] [PATCH 1/3] virt-aa-helper: Use virCommand APIs directly

On Mon, Aug 19, 2019 at 12:01:40PM +0200, Andrea Bolognani wrote: Right now we're using the virRun() convenience API, but that doesn't allow the kind of control we want. Use the virCommand APIs directly instead. Signed-off-by: Andrea Bolognani --- src/security/virt-aa-helper.c | 4 +++- 1 file

Re: [libvirt] [PATCH 3/3] virt-aa-helper: Fix AppArmor profile

On Mon, Aug 19, 2019 at 12:01:42PM +0200, Andrea Bolognani wrote: Since commit 432faf259b696043ee5d7e8f657d855419a9a3fa Author: Michal Privoznik Date: Tue Jul 2 19:49:51 2019 +0200 virCommand: use procfs to learn opened FDs When spawning a child process, between fork() and exec()

Re: [libvirt] 5.6.0 regression: "Some activation file descriptors are unclaimed"

On Mon, Aug 19, 2019 at 01:30:06PM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 19, 2019 at 12:15:48PM +, Allen, John wrote: > > On Mon, Aug 19, 2019 at 12:24:43PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Aug 14, 2019 at 01:30:26PM +, Allen, John wrote: > > > > After upgrading to

Re: [libvirt] 5.6.0 regression: "Some activation file descriptors are unclaimed"

On Mon, Aug 19, 2019 at 12:15:48PM +, Allen, John wrote: > On Mon, Aug 19, 2019 at 12:24:43PM +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 14, 2019 at 01:30:26PM +, Allen, John wrote: > > > After upgrading to v5.6.0, starting libvirtd fails with the following > > > message > > > in

Re: [libvirt] [PATCH 2/1] gitlab: Adapt to container name changes

On Mon, Aug 19, 2019 at 12:48 PM Andrea Bolognani wrote: > > GitLab CI unfortunately doesn't use the standard Makefile.ci > machinery, so its configuration needs to be updated separately. > > Signed-off-by: Andrea Bolognani Reviewed-by: Fabiano Fidêncio -- libvir-list mailing list

Re: [libvirt] 5.6.0 regression: "Some activation file descriptors are unclaimed"

On Mon, Aug 19, 2019 at 12:24:43PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 01:30:26PM +, Allen, John wrote: > > After upgrading to v5.6.0, starting libvirtd fails with the following > > message > > in journalctl -xe: > > > > libvirtd[186338]: internal error: Some

Re: [libvirt] 5.6.0 regression: "Some activation file descriptors are unclaimed"

On Wed, Aug 14, 2019 at 01:30:26PM +, Allen, John wrote: > After upgrading to v5.6.0, starting libvirtd fails with the following message > in journalctl -xe: > > libvirtd[186338]: internal error: Some activation file descriptors are > unclaimed > > 5b8569dd6e284b9159c701e8bffafb196983fc4a

Re: [libvirt] [dockerfiles PATCH 2/2] Refresh archived Dockerfiles

On Fri, 2019-08-16 at 17:10 +0200, Fabiano Fidêncio wrote: > Let's refresh the archived Dockerfiles in order to have the fedora-30 > containers performing the MinGW builds (instead of the fedora-rawhide > ones). s/fedora-30/Fedora 30/ s/fedora-rawhide/Fedora Rawhide/ [...] >

Re: [libvirt] [dockerfiles PATCH 1/2] refresh: Use fedora-30 to perform MinGW builds

On Fri, 2019-08-16 at 17:10 +0200, Fabiano Fidêncio wrote: > refresh: Use fedora-30 to perform MinGW builds s/fedora-30/Fedora 30/ > This is a workaround needed as a set of MinGW packages got removed from > Fedora Rawhide. We have to keep this workaround till the packages are > not

[libvirt] [PATCH 2/1] gitlab: Adapt to container name changes

GitLab CI unfortunately doesn't use the standard Makefile.ci machinery, so its configuration needs to be updated separately. Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml

Re: [libvirt] [jenkins-ci PATCH 3/3] jenkins: Set fedora-30 as the MinGW machine.

On Fri, 2019-08-16 at 17:10 +0200, Fabiano Fidêncio wrote: > +++ b/jenkins/jobs/defaults.yaml > @@ -17,7 +17,7 @@ >- libvirt-fedora-30 >- libvirt-fedora-rawhide > mingw_machines: > - - libvirt-fedora-rawhide > + - libvirt-fedora-30 We need to apply the same change

Re: [libvirt] [jenkins-ci PATCH 2/3] guests: Move MinGW builds to fedora-30

On Fri, 2019-08-16 at 17:10 +0200, Fabiano Fidêncio wrote: > As a set of MinGW packages ended up removed from Fedora Rawhide, let's > move the MinGW builds to Fedora 30 till the packages are back to > Rawhide. > > Signed-off-by: Fabiano Fidêncio > --- >

Re: [libvirt] [jenkins-ci PATCH 1/3] mappings: MinGW packages are not Fedora Rawhide specific

On Fri, 2019-08-16 at 17:09 +0200, Fabiano Fidêncio wrote: > MinGW packages are available in all Fedora releases, not only in > Rawhide. > > Signed-off-by: Fabiano Fidêncio > --- > guests/vars/mappings.yml | 108 +++ > 1 file changed, 54 insertions(+), 54

Re: [libvirt] [PATCH v1 1/3] adding unplug_timeout QEMU conf

Hi, On 8/19/19 6:16 AM, Ján Tomko wrote: On Sun, Aug 18, 2019 at 06:45:29PM -0300, Daniel Henrique Barboza wrote: For some architectures and setups, device removal can take longer than the default 5 seconds. This results in commands such as 'virsh setvcpus' to fire timeout messages even if the

[libvirt] [PATCH 1/3] virt-aa-helper: Use virCommand APIs directly

Right now we're using the virRun() convenience API, but that doesn't allow the kind of control we want. Use the virCommand APIs directly instead. Signed-off-by: Andrea Bolognani --- src/security/virt-aa-helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 3/3] virt-aa-helper: Fix AppArmor profile

Since commit 432faf259b696043ee5d7e8f657d855419a9a3fa Author: Michal Privoznik Date: Tue Jul 2 19:49:51 2019 +0200 virCommand: use procfs to learn opened FDs When spawning a child process, between fork() and exec() we close all file descriptors and keep only those the

[libvirt] [PATCH 2/3] virt-aa-helper: Call virCommandRawStatus()

The way we're processing the return status, using WIFEXITED() and friends, only works when we have the raw return status; however, virCommand defaults to processing the return status for us. Call virCommandRawStatus() before virCommandRun() so that we get the raw return status and the logic can

[libvirt] [PATCH 0/3] virt-aa-helper: A few fixes

Found while updating libvirt in Debian to 5.6.0. More background available at https://salsa.debian.org/libvirt-team/libvirt/merge_requests/30 Andrea Bolognani (3): virt-aa-helper: Use virCommand APIs directly virt-aa-helper: Call virCommandRawStatus() virt-aa-helper: Fix AppArmor profile

Re: [libvirt] [PATCH v4 1/4] tests: qemuxml2argv: switch to DO_TEST_CAPS_LATEST for Hyper-V tests

On Fri, Aug 09, 2019 at 04:31:38PM +0200, Vitaly Kuznetsov wrote: In particular, switch to using canonical 'hv-feature' syntax instead of 'hv_feature' aliases. We should keep the coverage for the old syntax too. Suggested-by: Ján Tomko ~ Signed-off-by: Vitaly Kuznetsov ---

Re: [libvirt] [PATCH v4 3/4] qemu: add support for Direct Mode for Hyper-V Synthetic timers

On Fri, Aug 09, 2019 at 04:31:40PM +0200, Vitaly Kuznetsov wrote: QEMU-4.1 supports 'Direct Mode' for Hyper-V synthetic timers (hv-stimer-direct CPU flag): Windows guests can request that timer expiration notifications are delivered as normal interrupts (and not VMBus messages). This is used by

[libvirt] [PATCH] tests: virpcimock: remove unused variable 'devid'

virpcimock.c:685:26: error: unused variable 'devid' [-Werror,-Wunused-variable] VIR_AUTOFREE(char *) devid = NULL; ^ Fixes: 76b42294380d40282ed29560e4ae4a7491b9df05 Signed-off-by: Ján Tomko --- Pushed as a trivial build fix. tests/virpcimock.c | 1 - 1 file

Re: [libvirt] [PATCH v1 1/3] adding unplug_timeout QEMU conf

On Sun, Aug 18, 2019 at 06:45:29PM -0300, Daniel Henrique Barboza wrote: For some architectures and setups, device removal can take longer than the default 5 seconds. This results in commands such as 'virsh setvcpus' to fire timeout messages even if the actual operation happened in the guest,

[libvirt] [PATCH 0/3] qemu: support -overcommit cpu-pm=on|off

QEMU introduced a CPU power management feature with commit 6f131f13e68d ("kvm: support -overcommit cpu-pm=on|off"). With this flag, kvm allows guest to control host CPU power state. This increases latency for other processes using same host CPU in an unpredictable way, but if decreases idle

[libvirt] [PATCH 3/3] tests: add tests for cpu-pm feature

Update the KVM feature tests for the cpu-pm feature Signed-off-by: Menno Lageman --- tests/qemuxml2argvdata/kvm-features-off.args | 2 +- tests/qemuxml2argvdata/kvm-features-off.xml | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1

[libvirt] [PATCH 2/3] qemu: add hypervisor feature cpu-pm support for kvm

From: Wim ten Have QEMU introduced a CPU power management feature with commit 6f131f13e68d ("kvm: support -overcommit cpu-pm=on|off"). This patch series adds support for controlling QEMU's "-overcommit" command line switch: "-overcommit cpu-pm=[on|off]". By default "cpu-pm" is off. To turn the

[libvirt] [PATCH 1/3] qemu: introduce qemuBuildOvercommitCommandLine()

In preparation for adding support for '-overcommit cpu-pm=[on|off]', add qemuBuildOvercommitCommandLine() to generate the '-overcommit' commandline. Move the existing '-overcommit mem-lock=[on|off]' generation code from qemuBuildMemCommandline() to this function. Signed-off-by: Menno Lageman ---