[libvirt] [PATCH] qemu: fix hang in p2p + xbzrle compression + parallel migration

2020-04-15 Thread Lin Ma
When we do parallel migration, The multifd-channels migration parameter needs to be set on the destination side as well before incoming migration URI, unless we accept the default number of connections(2). Usually, This can be correctly handled by libvirtd. But in this case if we use p2p + xbzrle

Re: [libvirt PATCH] docs: kbase: add a page about debugging

2020-04-15 Thread Han Han
On Wed, Apr 15, 2020 at 11:13 PM Ján Tomko wrote: > Migrate the following wiki articles: > https://wiki.libvirt.org/page/DebugLogs > https://wiki.libvirt.org/page/Debugging > > With the syntax changed to rST and rewrapped. > > Signed-off-by: Ján Tomko > --- > I might've changed an article or

Re: [libvirt PATCH 4/4] docs: Remove one example from pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 19:31:36 +0200 Andrea Bolognani wrote: > The idea behind this document is to show, with actual examples, > that users should not expect PCI addresses in the domain XML and > in the guest OS to match. > > The first zPCI example already serves this purpose perfectly, so > in

Re: [libvirt PATCH 3/4] docs: Remove MAC addresses from pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 19:31:35 +0200 Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/pci-addresses.rst | 2 -- > 1 file changed, 2 deletions(-) Yeah, not that useful. Reviewed-by: Cornelia Huck

Re: [libvirt PATCH 1/4] docs: Use consistent style in pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 19:31:33 +0200 Andrea Bolognani wrote: > Indent all code snippets by the same number of spaces, and don't > embed the :: marker in the line preceding a code block. > > This commit is best viewed with 'git show -w'. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt PATCH 2/4] docs: Move sections around in pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 19:31:34 +0200 Andrea Bolognani wrote: > The section about VFIO devices is kept separate from the rest > because it's less about domain XML and guest OS disagreeing on the > PCI address of a device, and more about which of the two PCI > addresses in the domain XML is even

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
On Wed, 2020-04-15 at 12:51 +0200, Cornelia Huck wrote: > Add some information on how pci address work on s390x. > > Signed-off-by: Cornelia Huck > --- > docs/pci-addresses.rst | 63 ++ > 1 file changed, 63 insertions(+) There are a few comments that I

[libvirt PATCH 3/4] docs: Remove MAC addresses from pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/pci-addresses.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index 566c81d957..86a41df6ce 100644 --- a/docs/pci-addresses.rst +++ b/docs/pci-addresses.rst @@ -177,7 +177,6 @@ In the simplest case,

[libvirt PATCH 4/4] docs: Remove one example from pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
The idea behind this document is to show, with actual examples, that users should not expect PCI addresses in the domain XML and in the guest OS to match. The first zPCI example already serves this purpose perfectly, so in the interest of keeping the page as brief and easy to digest as possible

[libvirt PATCH 2/4] docs: Move sections around in pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
The section about VFIO devices is kept separate from the rest because it's less about domain XML and guest OS disagreeing on the PCI address of a device, and more about which of the two PCI addresses in the domain XML is even relevant to the guest OS. The section on zPCI addresses, on the other

[libvirt PATCH 1/4] docs: Use consistent style in pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
Indent all code snippets by the same number of spaces, and don't embed the :: marker in the line preceding a code block. This commit is best viewed with 'git show -w'. Signed-off-by: Andrea Bolognani --- docs/pci-addresses.rst | 60 ++ 1 file changed, 32

[libvirt PATCH 0/4] docs: A few adjustments to pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
Andrea Bolognani (4): docs: Use consistent style in pci-addresses.rst docs: Move sections around in pci-addresses.rst docs: Remove MAC addresses from pci-addresses.rst docs: Remove one example from pci-addresses.rst docs/pci-addresses.rst | 102 +

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 18:38:06 +0200 Andrea Bolognani wrote: > On Wed, 2020-04-15 at 16:45 +0200, Cornelia Huck wrote: > > On Wed, 15 Apr 2020 16:23:46 +0200 > > Boris Fiuczynski wrote: > > > Once I understand you confusion above I will provide a patch... > > > > I'd say just go ahead. >

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
On Wed, 2020-04-15 at 16:45 +0200, Cornelia Huck wrote: > On Wed, 15 Apr 2020 16:23:46 +0200 > Boris Fiuczynski wrote: > > Once I understand you confusion above I will provide a patch... > > I'd say just go ahead. While I appreciate the sentiment, I would rather not have an excessive amount of

Re: [PATCH 0/2] Include lease time option into DHCP settings

2020-04-15 Thread Julio Faracco
I resubmitted this series because our team needs to hack dnsmasq settings to change lease time. This feature would be so important to us to avoid workarounds. It is based on Alberto's patch from 2017. But personally I don't like this approach. IMHO, it would be nice to have specific attributes to

[PATCH 2/2] tests: Add tests for to cover dnsmasq settings

2020-04-15 Thread Julio Faracco
New tests are required to cover some new XML syntax entry for option. This includes schema testing and other features like unit attribute and leasetime value. Signed-off-by: Julio Faracco --- tests/networkxml2confdata/leasetime-hours.conf | 16

[PATCH 1/2] conf: Add option for settings

2020-04-15 Thread Julio Faracco
If an user is trying to configure a dhcp neetwork settings, it is not possible to change the leasetime of a range or a host entry. This is available using dnsmasq extra options, but they are associated with dhcp-range or dhcp-hosts fields. This patch implements a default leasetime for both. If

[PATCH 0/2] Include lease time option into DHCP settings

2020-04-15 Thread Julio Faracco
This series is based on latest series from Alberto. It includes a new entry called under scope to add a default lease time for range and host options for dnsmasq. There is no point to configure both separately. If they are defined (range and/or host), they should have the same lease time value.

Re: [libvirt PATCH 2/3] travis: Reduce test matrix

2020-04-15 Thread Andrea Bolognani
On Wed, 2020-04-15 at 13:52 +0100, Daniel P. Berrangé wrote: > On Tue, Apr 14, 2020 at 12:42:26PM +0200, Andrea Bolognani wrote: > > Considering that almost nobody in the libvirt community is actually > > focused on macOS support, trying to chase after two SDKs instead of > > a single one doesn't

Re: [libvirt PATCH 2/2] gitlab: Enable improved ccache usage

2020-04-15 Thread Andrea Bolognani
On Wed, 2020-04-15 at 13:38 +0100, Daniel P. Berrangé wrote: > On Mon, Mar 30, 2020 at 07:31:03PM +0200, Andrea Bolognani wrote: > > Since we're touching this anyway, we make a few more changes: > > $CCACHE_DIR is no longer created manually, because ccache will > > take care of creating it for us

Re: [PATCH] qemu: Revoke access to mirror on failed blockcopy

2020-04-15 Thread Michal Privoznik
On 4/15/20 2:09 PM, Pavel Mores wrote: On Tue, Apr 14, 2020 at 11:32:08AM +0200, Michal Privoznik wrote: When preparing to do a blockcopy, the mirror image is modified so that QEMU can access it. For instance, the mirror has seclabels set, if it is a NVMe disk it is detached from the host and

[libvirt PATCH] docs: kbase: add a page about debugging

2020-04-15 Thread Ján Tomko
Migrate the following wiki articles: https://wiki.libvirt.org/page/DebugLogs https://wiki.libvirt.org/page/Debugging With the syntax changed to rST and rewrapped. Signed-off-by: Ján Tomko --- I might've changed an article or two, too. Or rather: the article 'the'. docs/kbase.html.in |

Re: [PATCH 01/43] admin: convert virMutex to GMutex

2020-04-15 Thread Pavel Mores
On Wed, Apr 15, 2020 at 03:58:55PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 15, 2020 at 04:11:30PM +0200, Pavel Mores wrote: > > On Wed, Apr 15, 2020 at 01:55:34PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Apr 14, 2020 at 05:24:50PM +0200, Pavel Mores wrote: > > > > On Fri, Apr 10, 2020

Re: [PATCH 01/43] admin: convert virMutex to GMutex

2020-04-15 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 04:11:30PM +0200, Pavel Mores wrote: > On Wed, Apr 15, 2020 at 01:55:34PM +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 14, 2020 at 05:24:50PM +0200, Pavel Mores wrote: > > > On Fri, Apr 10, 2020 at 03:54:28PM +0200, Rafael Fonseca wrote: > > > > Signed-off-by: Rafael

Re: Wiki page audit - possible page deleteion

2020-04-15 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 04:08:05PM +0200, Ján Tomko wrote: > On a Wednesday in 2020, Daniel P. Berrangé wrote: > > Ideally I would like to decomission the current wiki.libvirt.org > > site. It is based on mediawiki running on openshift and has myself > > as a single point of failure. > > > >

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 16:23:46 +0200 Boris Fiuczynski wrote: > On 4/15/20 3:42 PM, Cornelia Huck wrote: > > On Tue, 14 Apr 2020 23:06:47 +0200 > > Boris Fiuczynski wrote: > > > >> On 4/15/20 12:51 PM, Cornelia Huck wrote: > >>> +In the simplest case, the following XML snippet > >>> + > >>>

Re: [PATCH 03/43] conf: nwfilter_ipaddrmap: convert virMutex to GMutex

2020-04-15 Thread Laine Stump
On 4/15/20 8:43 AM, Pavel Mores wrote: On Sat, Apr 11, 2020 at 08:15:15PM +0200, Rafael Fonseca wrote: On Fri, Apr 10, 2020 at 7:06 PM Laine Stump wrote: Beyond that, why not just use the G_*() macros for *all* locks in libvirt instead of only using them in cases of static locks? It seems

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Boris Fiuczynski
On 4/15/20 3:42 PM, Cornelia Huck wrote: On Tue, 14 Apr 2020 23:06:47 +0200 Boris Fiuczynski wrote: On 4/15/20 12:51 PM, Cornelia Huck wrote: +zPCI addresses +== + +For s390x machines, PCI addresses are handled yet differently. No +topology information is relayed in the PCI

Re: [PATCH 01/43] admin: convert virMutex to GMutex

2020-04-15 Thread Pavel Mores
On Wed, Apr 15, 2020 at 01:55:34PM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 14, 2020 at 05:24:50PM +0200, Pavel Mores wrote: > > On Fri, Apr 10, 2020 at 03:54:28PM +0200, Rafael Fonseca wrote: > > > Signed-off-by: Rafael Fonseca > > > --- > > > src/admin/admin_server_dispatch.c | 13

Re: Wiki page audit - possible page deleteion

2020-04-15 Thread Ján Tomko
On a Wednesday in 2020, Daniel P. Berrangé wrote: Ideally I would like to decomission the current wiki.libvirt.org site. It is based on mediawiki running on openshift and has myself as a single point of failure. GitLab provides a wiki, but I don't think we need to use that either, as I think

Re: [PATCH 02/43] bhyve: convert virMutex to GMutex

2020-04-15 Thread Pavel Mores
On Wed, Apr 15, 2020 at 01:59:46PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 15, 2020 at 02:15:35PM +0200, Pavel Mores wrote: > > On Tue, Apr 14, 2020 at 07:05:03PM +0200, Rafael Fonseca wrote: > > > On Tue, Apr 14, 2020 at 6:06 PM Pavel Mores wrote: > > > > > > > > By the way, the approach

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Tue, 14 Apr 2020 23:06:47 +0200 Boris Fiuczynski wrote: > On 4/15/20 12:51 PM, Cornelia Huck wrote: > > +zPCI addresses > > +== > > + > > +For s390x machines, PCI addresses are handled yet differently. No > > +topology information is relayed in the PCI addresses; instead, the > >

Re: [RFC] Adding docker driver to libvirt

2020-04-15 Thread Daniel P . Berrangé
On Tue, Apr 14, 2020 at 09:56:24AM +0300, nshirokovskiy wrote: > > > On 12.04.2020 12:39, Martin Kletzander wrote: > > On Thu, Apr 09, 2020 at 03:30:11PM +0300, nshirokovskiy wrote: > >> Hi, all. > >> > >> Does it make sense to add such a driver? I can't say I have a big picture > >> of docker

Re: [PATCH 02/43] bhyve: convert virMutex to GMutex

2020-04-15 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 02:15:35PM +0200, Pavel Mores wrote: > On Tue, Apr 14, 2020 at 07:05:03PM +0200, Rafael Fonseca wrote: > > On Tue, Apr 14, 2020 at 6:06 PM Pavel Mores wrote: > > > > > > By the way, the approach taken here with bhyveDriver{Lock,Unlock}() might > > > make > > > sense with

Re: [PATCH 01/43] admin: convert virMutex to GMutex

2020-04-15 Thread Daniel P . Berrangé
On Tue, Apr 14, 2020 at 05:24:50PM +0200, Pavel Mores wrote: > On Fri, Apr 10, 2020 at 03:54:28PM +0200, Rafael Fonseca wrote: > > Signed-off-by: Rafael Fonseca > > --- > > src/admin/admin_server_dispatch.c | 13 - > > 1 file changed, 4 insertions(+), 9 deletions(-) > > > > diff

Re: [libvirt PATCH 2/3] travis: Reduce test matrix

2020-04-15 Thread Daniel P . Berrangé
On Tue, Apr 14, 2020 at 12:42:26PM +0200, Andrea Bolognani wrote: > On Tue, 2020-04-14 at 10:54 +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 10, 2020 at 11:10:33AM +0200, Andrea Bolognani wrote: > > > The xcode10.3 build has recently started failing because of issues > > > that are not in

Re: [PATCH 03/43] conf: nwfilter_ipaddrmap: convert virMutex to GMutex

2020-04-15 Thread Pavel Mores
On Sat, Apr 11, 2020 at 08:15:15PM +0200, Rafael Fonseca wrote: > On Fri, Apr 10, 2020 at 7:06 PM Laine Stump wrote: > > > Beyond that, why not just use the G_*() macros for *all* locks in > > > libvirt instead of only using them in cases of static locks? It seems > > > strange to use the

Re: [libvirt PATCH 2/2] gitlab: Enable improved ccache usage

2020-04-15 Thread Daniel P . Berrangé
On Mon, Mar 30, 2020 at 07:31:03PM +0200, Andrea Bolognani wrote: > Setting CC="ccache cc" works in most cases, but sometimes it will > break the build: in particular, we have experienced issues in the > past with that approach when using cgo to build our Go bindings. > > A more robust approach

Re: [libvirt PATCH 1/2] gitlab: Don't define $MAKE

2020-04-15 Thread Daniel P . Berrangé
On Mon, Mar 30, 2020 at 07:31:02PM +0200, Andrea Bolognani wrote: > Since libvirt-jenkins-ci commit 27cfddee8835, paths to build tools > such as ninja and make are exported in the container's environment > and can be used directly. > > Signed-off-by: Andrea Bolognani > --- > .gitlab-ci.yml | 1

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Boris Fiuczynski
Sorry about the time travel. I will try to give up that super power... :( On 4/14/20 11:06 PM, Boris Fiuczynski wrote: On 4/15/20 12:51 PM, Cornelia Huck wrote: Add some information on how pci address work on s390x. Signed-off-by: Cornelia Huck Conny, thanks for catching this "wacky

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Boris Fiuczynski
On 4/15/20 12:51 PM, Cornelia Huck wrote: Add some information on how pci address work on s390x. Signed-off-by: Cornelia Huck Conny, thanks for catching this "wacky case"... :) I took the liberty to remove "completely" because there needs to be room for pci multifunction support... :D ---

Re: [PATCH 02/43] bhyve: convert virMutex to GMutex

2020-04-15 Thread Pavel Mores
On Tue, Apr 14, 2020 at 07:05:03PM +0200, Rafael Fonseca wrote: > On Tue, Apr 14, 2020 at 6:06 PM Pavel Mores wrote: > > > > By the way, the approach taken here with bhyveDriver{Lock,Unlock}() might > > make > > sense with the whole series - implement e.g. virMutexInit() in terms of > >

Re: [PATCH] qemu: Revoke access to mirror on failed blockcopy

2020-04-15 Thread Pavel Mores
On Tue, Apr 14, 2020 at 11:32:08AM +0200, Michal Privoznik wrote: > When preparing to do a blockcopy, the mirror image is modified so > that QEMU can access it. For instance, the mirror has seclabels > set, if it is a NVMe disk it is detached from the host and so on. > And usually, the restore is

[PATCH 1/3] Improve blockpull man entry

2020-04-15 Thread Sebastian Mitterle
1. Mention usage of `--base` and `--bandwidth` and fix cmd syntax. 2. Explain valid arguments for `base`. 3. Move explanation for `--keep-relative` to end considering it less frequent use case because libvirt doesn't create relative backing chain names. 4. Add reference to documentation for

[PATCH 0/3] doc: minor improvements

2020-04-15 Thread Sebastian Mitterle
Minor man/doc improvements related to blockpull. Sebastian Mitterle (3): Improve blockpull man entry Improve Disk image chains documentation Add version info on domaincaps doc docs/formatdomaincaps.html.in | 3 ++- docs/kbase/backing_chains.rst | 36 +--

[PATCH 2/3] Improve Disk image chains documentation

2020-04-15 Thread Sebastian Mitterle
1. Use 'setup' consistently as noun, 'set up' as verb 2. Use path variables like '$IMAGE_PATH' consistently like in Troubleshooting to improve readability 3. Remove ':' from field names 4. Change phrasing in sentences I stumbled upon several times to improve readability. 5. Minor

[PATCH 3/3] Add version info on domaincaps doc

2020-04-15 Thread Sebastian Mitterle
1. Add 'since 5.10' as commonly used in formatdomain to avoid misunderstandings if element is not present (Is it not supported because of my version or because of my environment?) Signed-off-by: Sebastian Mitterle --- docs/formatdomaincaps.html.in | 3 ++- 1 file changed, 2 insertions(+),

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Ján Tomko
On a Wednesday in 2020, Cornelia Huck wrote: Add some information on how pci address work on s390x. Signed-off-by: Cornelia Huck --- docs/pci-addresses.rst | 63 ++ 1 file changed, 63 insertions(+) diff --git a/docs/pci-addresses.rst

[PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
Add some information on how pci address work on s390x. Signed-off-by: Cornelia Huck --- docs/pci-addresses.rst | 63 ++ 1 file changed, 63 insertions(+) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index 923783a151b0..9e241a24fcfb 100644

Re: [PATCH] qemu: Revoke access to mirror on failed blockcopy

2020-04-15 Thread Daniel Henrique Barboza
On 4/14/20 6:32 AM, Michal Privoznik wrote: When preparing to do a blockcopy, the mirror image is modified so that QEMU can access it. For instance, the mirror has seclabels set, if it is a NVMe disk it is detached from the host and so on. And usually, the restore is done upon successful

Re: [libvirt PATCH] docs: Add pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
On Wed, 2020-04-15 at 10:46 +0200, Christian Ehrhardt wrote: > Hi Andrea, > I saw this change committed and a latter push of mine has reported the > following while running the pipelines: > > ../docs/pci-addresses.rst:7:the the > build-aux/syntax-check.mk: doubled words > make: ***

Re: [PATCH v5 3/4] vfio/mdev: add migration_version attribute for mdev (under mdev device node)

2020-04-15 Thread Yan Zhao
On Wed, Apr 15, 2020 at 03:42:58PM +0800, Erik Skultety wrote: > On Mon, Apr 13, 2020 at 01:55:04AM -0400, Yan Zhao wrote: > > migration_version attribute is used to check migration compatibility > > between two mdev devices of the same mdev type. > > The key is that it's rw and its data is opaque

Re: [PATCH v5 1/4] vfio/mdev: add migration_version attribute for mdev (under mdev_type node)

2020-04-15 Thread Yan Zhao
On Wed, Apr 15, 2020 at 03:28:51PM +0800, Erik Skultety wrote: > On Mon, Apr 13, 2020 at 01:54:03AM -0400, Yan Zhao wrote: > > migration_version attribute is used to check migration compatibility > > between two mdev devices of the same mdev type. > > The key is that it's rw and its data is opaque

[libvirt PATCH] docs: Fix word repetition in pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
Fixes: 2923e7a3dd984c46202703d390dce3ff4ea4048c Reported-by: Ján Tomko Signed-off-by: Andrea Bolognani --- Pushed under the build fix rule. docs/pci-addresses.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index

Re: [libvirt PATCH] docs: Add pci-addresses.rst

2020-04-15 Thread Christian Ehrhardt
Hi Andrea, I saw this change committed and a latter push of mine has reported the following while running the pipelines: ../docs/pci-addresses.rst:7:the the build-aux/syntax-check.mk: doubled words make: *** [../build-aux/syntax-check.mk:1727: sc_prohibit_doubled_word] Error 1 This is due to:

Re: [PATCH v2] apparmor: avoid denials on libpmem initialization

2020-04-15 Thread Christian Ehrhardt
On Thu, Apr 9, 2020 at 6:57 PM Jamie Strandboge wrote: > > On Thu, 09 Apr 2020, Christian Ehrhardt wrote: > > > With libpmem support compiled into qemu it will trigger the following > > denials on every startup. > > apparmor="DENIED" operation="open" name="/" > > apparmor="DENIED"

Re: [libvirt PATCH] docs: Add pci-addresses.rst

2020-04-15 Thread Andrea Bolognani
On Wed, 2020-04-15 at 08:47 +0200, Cornelia Huck wrote: > On Tue, 14 Apr 2020 19:53:05 +0200 > Andrea Bolognani wrote: > > +More complex cases > > +== > > (...) > > I'm wondering whether it is worth mentioning zPCI under 'More complex > cases', or maybe under 'Completely wacky

Re: [PATCH v5 3/4] vfio/mdev: add migration_version attribute for mdev (under mdev device node)

2020-04-15 Thread Erik Skultety
On Mon, Apr 13, 2020 at 01:55:04AM -0400, Yan Zhao wrote: > migration_version attribute is used to check migration compatibility > between two mdev devices of the same mdev type. > The key is that it's rw and its data is opaque to userspace. > > Userspace reads migration_version of mdev device at

Re: [PATCH v5 1/4] vfio/mdev: add migration_version attribute for mdev (under mdev_type node)

2020-04-15 Thread Erik Skultety
On Mon, Apr 13, 2020 at 01:54:03AM -0400, Yan Zhao wrote: > migration_version attribute is used to check migration compatibility > between two mdev devices of the same mdev type. > The key is that it's rw and its data is opaque to userspace. > > Userspace reads migration_version of mdev device at

Re: [libvirt PATCH] docs: Add pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Tue, 14 Apr 2020 19:53:05 +0200 Andrea Bolognani wrote: > This document describes the relationship between PCI addresses as > seen in the domain XML and by the guest OS, which is a topic that > people get confused by time and time again. > > Signed-off-by: Andrea Bolognani > --- >