[libvirt] sVirt shouldn't let Nova do stupid things

. Is there any way we could define a sane set of operations independent of Nova? Matt -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libguestfs] Options for hotplugging

passing in the root device. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] xenapi: Improve error message on session failure

XenAPI session login can fail for a number of reasons, but currently no specific reason is displayed to the user, e.g.: virsh -c XenAPI://citrix-xen.example.com/ Enter username for citrix-xen.example.com: root Enter root's password for citrix-xen.example.com: error: authentication failed: (null)

[libvirt] [PATCH] storage: fix volDelete return when volume still being allocated

volDelete used to return VIR_ERR_INTERNAL_ERROR when attempting to delete a volume which was still being allocated. It should return VIR_ERR_OPERATION_INVALID. * src/storage/storage_driver.c: Fix return of volDelete. --- src/storage/storage_driver.c |2 +- 1 files changed, 1 insertions(+), 1

[libvirt] Changing the default for qcow2 creation

it into F14 yet. It's definitely not in F13. -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 write-test.pl Description: Perl program -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH] Remove unused nwfilter field from struct remote_error

Change 965466c1 added a new field to struct remote_error, which broke the RPC protocol. Fortunately the new field is unused, so this change simply removes it again. * src/remote/remote_protocol.(c|h|x): Remove remote_nwfilter from struct remote_error ---

[libvirt] Fwd: Re: need your help about virito vmchannel

FYI for the list. I haven't looked at this yet. Matt Original Message Subject: Re: need your help about virito vmchannel Date: Tue, 4 May 2010 18:00:02 +0530 From: Amit Shah amit.s...@redhat.com To: Matthew Booth mbo...@redhat.com CC: Jianlin Liu jia...@redhat.com On (Tue) May

[libvirt] [PATCH] Don't build nwfilter examples when not building libvirtd

* Makefile.am: Make examples/xml/nwfilter conditional on WITH_LIBVIRTD --- Makefile.am |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index dd334b5..40352c4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,8 +5,11 @@ GENHTML = genhtml

Re: [libvirt] Problems accessing ESX using libvirt

to a libvirtd on the server and uses TLS (default libvirt port 16514) for that. That's what you see in the tcpdump there. Thanks, Matthias. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458

Re: [libvirt] virtio serial config

At this point, both virtio-serial devices in each guest should be full-duplex. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -- libvir-list mailing list libvir-list

Re: [libvirt] libvirt XML format.

='bridge' source bridge='br0'/ /interface For more info have a look here: http://libvirt.org/formatdomain.html#elementsNIC Note the sections 'Virtual network' and 'Bridge to LAN'. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID

Re: [libvirt] [PATCH 1/2] Add domain support for virtio channel

On 18/02/10 12:34, Daniel P. Berrange wrote: On Wed, Feb 17, 2010 at 05:11:00PM +, Matthew Booth wrote: Add support for virtio-serial by defining a new 'virtio' channel target type and a virtio-serial controller. Allows the following to be specified in a domain: controller type='virtio

Re: [libvirt] [PATCH 2/2] Add QEMU support for virtio channel

On 18/02/10 12:39, Daniel P. Berrange wrote: On Wed, Feb 17, 2010 at 05:11:01PM +, Matthew Booth wrote: Support virtio-serial controller and virtio channel in QEMU backend. Will output the following for virtio-serial controller: -device virtio-serial-pci,id=virtio-serial0,bus=pci.0

Re: [libvirt] [PATCH 2/2] Add QEMU support for virtio channel

On 18/02/10 14:11, Daniel P. Berrange wrote: On Thu, Feb 18, 2010 at 01:23:57PM +, Matthew Booth wrote: On 18/02/10 12:39, Daniel P. Berrange wrote: On Wed, Feb 17, 2010 at 05:11:01PM +, Matthew Booth wrote: Support virtio-serial controller and virtio channel in QEMU backend

Re: [libvirt] [PATCH 1/2] Add domain support for virtio channel

On 18/02/10 14:09, Daniel P. Berrange wrote: On Thu, Feb 18, 2010 at 01:16:02PM +, Matthew Booth wrote: On 18/02/10 12:34, Daniel P. Berrange wrote: On Wed, Feb 17, 2010 at 05:11:00PM +, Matthew Booth wrote: Add support for virtio-serial by defining a new 'virtio' channel target type

[libvirt] [PATCH] Remove unused functions from domain_conf

Remove virDomainDevicePCIAddressEqual and virDomainDeviceDriveAddressEqual, which are defined but not used anywhere. * src/conf/domain_conf.[ch]: Remove virDomainDevicePCIAddressEqual and virDomainDeviceDriveAddressEqual. --- src/conf/domain_conf.c | 24

Re: [libvirt] libvirt XML format.

in an XML document. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir

[libvirt] [PATCH] Fix typo in comment

* src/qemu/qemu_driver.c: Fix typo in comment --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 8766ca2..b4728e5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2724,7

[libvirt] [PATCH] Fix whitespace in domain.rng

* src/schemas/domain.rng: Replace tabs with 8 spaces --- docs/schemas/domain.rng | 52 +++--- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index a834705..1ac5943 100644 ---

[libvirt] [PATCH] Fix whitespace in domain.rng

* src/schemas/domain.rng: Replace tabs with 8 spaces --- docs/schemas/domain.rng | 52 +++--- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 1ff0944..53b82ce 100644 ---

[libvirt] virtio-serial support

These patches rebase my previously posted virtio-serial patches, add support for max_ports and vectors, and allow multiple virtio-serial devices to be used. I wasn't going to bother with the latter, however it turns out this can be useful if the user wants more than 31 virtserialports. N.B. These

[libvirt] [PATCH 2/2] Add QEMU support for virtio channel

Support virtio-serial controller and virtio channel in QEMU backend. Will output the following for virtio-serial controller: -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x4,max_ports=16,vectors=4 and the following for a virtio channel: -chardev pty,id=channel0 \ -device

[libvirt] [PATCH 1/2] Add domain support for virtio channel

Add support for virtio-serial by defining a new 'virtio' channel target type and a virtio-serial controller. Allows the following to be specified in a domain: controller type='virtio-serial' index='0' max_ports='16' vectors='4'/ channel type='pty' target type='virtio'

Re: [libvirt] [PATCH] Remove unused functions from domain_conf

src/libvirt_private.syms. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 From 5612c7c7a5969a84cc97f50ad2bdf9070ef95210 Mon Sep 17 00:00:00 2001 From: Matthew Booth

[libvirt] [PATCH] Clarify lack of generated IDE -device string in QEMU driver

The QEMU driver contained code to generate a -device string for piix4-ide, but wasn't using it. This was intentional. This change removes the string generation and adds a comment explaining why no -device is necessary. * src/qemu/qemu_conf.c: Remove VIR_DOMAIN_CONTROLLER_TYPE_IDE handler in

Re: [libvirt] [PATCH] Clarify lack of generated IDE -device string in QEMU driver

On 28/01/10 10:57, Daniel P. Berrange wrote: On Thu, Jan 28, 2010 at 10:35:48AM +, Matthew Booth wrote: The QEMU driver contained code to generate a -device string for piix4-ide, but wasn't using it. This was intentional. This change removes the string generation and adds a comment

[libvirt] [PATCH] Clarify why some controllers don't generate -device string in QEMU driver

The QEMU driver contained code to generate a -device string for piix4-ide, but wasn't using it. This change removes this string generation. It also adds a comment explaining why IDE and FDC controllers don't generate -device strings. The change also generates an error if a sata controller is

[libvirt] [PATCH] Clarify why some controllers don't generate -device string in QEMU driver

The QEMU driver contained code to generate a -device string for piix4-ide, but wasn't using it. This change removes this string generation. It also adds a comment explaining why IDE and FDC controllers don't generate -device strings. The change also generates an error if a sata controller is

[libvirt] [PATCH 3/3] Add QEMU support for virtio channel

Support virtio-serial controller and virtio channel in QEMU backend. Will output the following for virtio-serial controller: -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x4 and the following for a virtio channel: -chardev pty,id=channel0 \ -device

[libvirt] [PATCH 1/3] Clarify why some controllers don't generate -device string in QEMU driver

The QEMU driver contained code to generate a -device string for piix4-ide, but wasn't using it. This change removes this string generation. It also adds a comment explaining why IDE and FDC controllers don't generate -device strings. The change also generates an error if a sata controller is

[libvirt] [PATCH 2/3] Add domain support for virtio channel

Add support for virtio-serial by defining a new 'virtio' channel target type and a virtio-serial controller. Allows the following to be specified in a domain: controller type='virtio-serial' index='0'/ channel type='pty' target type='virtio' name='org.linux-kvm.port.0'/ /channel *

[libvirt] [PATCH 2/2] Add QEMU support for virtio channel

Support virtio-serial controller and virtio channel in QEMU backend. Will output the following for virtio-serial controller: -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x4 and the following for a virtio channel: -chardev pty,id=channel0 \ -device

[libvirt] [PATCH UPDATE] Add support for virtio channel

Amit pointed out that byte_limit, guest_byte_limit and cache_buffers are now gone. They are removed in these updated patches. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] Add domain support for virtio channel

Add support for virtio-serial by defining a new 'virtio' channel target type and a virtio-serial controller. Allows the following to be specified in a domain: controller type='virtio-serial' index='0'/ channel type='pty' target type='virtio' name='org.linux-kvm.port.0'/ /channel *

[libvirt] [PATCH] Add missing sata controller type to domain.rng

* docs/schemas/domain.rng: Add sata controller type --- docs/schemas/domain.rng |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 49b57eb..827ff6f 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@

Re: [libvirt] Cannot use console with 0.7.5, error: internal error no assigned pty for device serial0

please post the full domain XML, and the QEMU command line it generated? You can get the latter from /var/log/libvirt/qemu/domain.log. Can you also post the versions of qemu and libvirt? This should let me see where it's going wrong. Thanks, Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering

[libvirt] Using ESX domain XML for V2V

. Is this intentional? Should I be assuming some of the above because it's ESX, or is this an omission? Thanks, Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490

[libvirt] [PATCH] Cleanup temporary #define after use

* src/qemu/qemu_driver.c: #undef LOOKUP_PTYS after use --- src/qemu/qemu_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7e55c23..4567a66 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@

[libvirt] [PATCH] Fix parsing of 'info chardev' line endings

This change makes the 'info chardev' parser ignore any trailing whitespace on a line. This fixes a specific problem handling a '\r\n' line ending. * src/qemu/qemu_monitor_text.c: Ignore trailing whitespace in 'info chardev' output. --- src/qemu/qemu_monitor_text.c | 26

[libvirt] Out of band channels

.IDE error: Cannot connect to a remote console device [3] What would you call it? -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -- Libvir-list mailing list Libvir-list

[libvirt] [PATCH] Fix owner and group in example volume XML

The owner and group in the documentation examples were confusingly given as '0744'. They should be numeric uid and gid. Changed the examples to use the default uid and gid assigned to qemu in F12. * docs/formatstorage.html.in: Change example owner and group in volume XML ---

[libvirt] [PATCH 1/3] Make QEMU driver use -chardev everywhere when it's available

Change -monitor, -serial and -parallel output to use -chardev if it is available. * src/qemu/qemu_conf.c: Update qemudBuildCommandLine to use -chardev where available. * tests/qemuxml2argvtest.c tests/qemuxml2argvdata/: Add -chardev equivalents for all current serial and parallel tests. ---

[libvirt] [PATCH 2/3] Extract the assigned pty device for channels

* src/qemu/qemu_driver.c: Parse pty devices for channels --- src/qemu/qemu_driver.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2fb059d..c1feb0f 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 3/3] Get QEMU pty paths from the monitor

This change makes the QEMU driver get pty paths from the output of the monitor 'info chardev' command. This output is structured, and contains both the name of the device and the path on the same line. This is considerably more reliable than parsing the startup log output, which requires the

Re: [libvirt] [PATCH] Add test for legacy console ... tty= syntax

On 25/11/09 11:25, Daniel P. Berrange wrote: On Mon, Nov 23, 2009 at 01:48:30PM +, Matthew Booth wrote: * tests/qemuxml2argvtest.c: Test legacy syntax for QEMU argument generation * tests/qemuxml2argvdata/qemuxml2argv-console-legacy.(xml|args): Add test data This test doesn't seem to test

[libvirt] Improve the reliability of pty path parsing

The following are improve the reliability of libvirt's mapping of character devices to pty paths. When qemu starts up it will output one or more lines of the form: char device redirected to /dev/pts/5 Note that the character device this refers to is not indicated, so the only way to match this

[libvirt] [PATCH 1/3] Make QEMU driver use -chardev everywhere when it's available

Change -monitor, -serial and -parallel output to use -chardev if it is available. * src/qemu/qemu_conf.c: Update qemudBuildCommandLine to use -chardev where available. * tests/qemuxml2argvtest.c tests/qemuxml2argvdata/: Add -chardev equivalents for all current serial and parallel tests. ---

[libvirt] [PATCH 2/3] Extract the assigned pty device for channels

* src/qemu/qemu_driver.c: Parse pty devices for channels --- src/qemu/qemu_driver.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2c5086b..ebf44b0 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 3/3] Get QEMU pty paths from the monitor

This change makes the QEMU driver get pty paths from the output of the monitor 'info chardev' command. This output is structured, and contains both the name of the device and the path on the same line. This is considerably more reliable than parsing the startup log output, which requires the

[libvirt] [PATCH] Add test for legacy console ... tty= syntax

* tests/qemuxml2argvtest.c: Test legacy syntax for QEMU argument generation * tests/qemuxml2argvdata/qemuxml2argv-console-legacy.(xml|args): Add test data --- .../qemuxml2argv-console-legacy.args |1 + .../qemuxml2argv-console-legacy.xml| 29

Re: [libvirt] [PATCH] Make QEMU driver use -chardev everywhere when it's available

to be merged immediately, so I'll keep the fix locally for the moment. Thanks, Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -- Libvir-list mailing list Libvir-list

[libvirt] [PATCH] Fix typo in error message

* src/qemu/qemu_monitor_text.c: Fix typo * po/*.po: Update typo in translations --- po/af.po |2 +- po/am.po |2 +- po/ar.po |2 +- po/as.po |2 +- po/be.po |2 +- po/bg.po

Re: [libvirt] [PATCH] Fix typo in error message

On 17/11/09 11:19, Daniel Veillard wrote: On Tue, Nov 17, 2009 at 11:04:40AM +, Matthew Booth wrote: * src/qemu/qemu_monitor_text.c: Fix typo * po/*.po: Update typo in translations Please keep the po separate from patches :-) Sure. Do you want a separate patch from me, or did you

[libvirt] [PATCH 1/2] Fix guestfwdTarget indentation in domain.rng

* docs/schemas/domain.rng: Fix up some 4 space indentation --- docs/schemas/domain.rng | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index b75f17e..1bf44fd 100644 --- a/docs/schemas/domain.rng +++

[libvirt] [PATCH 2/2] guestfwd code tidy up

This patch removes qemudBuildCommandLineChrDevTargetStr and inlines its single use. It was intended to be generic, but on reflection this can't work. Instead it just makes the code slightly harder to read. * src/qemu/qemu_conf.c: Remove and inline qemudBuildCommandLineChrDevTargetStr ---

[libvirt] [PATCH] Make QEMU driver use -chardev everywhere when it's available

Change -monitor, -serial and -parallel output to use -chardev if it is available. * src/qemu/qemu_conf.c: Update qemudBuildCommandLine to use -chardev where available. * tests/qemuxml2argvtest.c tests/qemuxml2argvdata/: Add -chardev equivalents for all current serial and parallel tests. ---

[libvirt] Rebased -vmchannel support

Updated patches are rebased on top of merged channel support. They additionally move some definitions around to hopefully reduce the chances of future merge conflicts. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] Detect availability of legacy QEMU -vmchannel command line option

* src/qemu/qemu_conf.[ch]: Detect -vmchannel command line option --- src/qemu/qemu_conf.c |2 ++ src/qemu/qemu_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index e1e24c3..fa54974 100644 --- a/src/qemu/qemu_conf.c

[libvirt] [PATCH 2/2] Add channel support for legacy QEMU's -vmchannel CLI option

This patch allows the following to be specified in a QEmu domain: channel type='unix' source mode='bind' path='/tmp/vmchannel'/ target type='vmchannel' deviceid='0200'/ /channel * docs/schemas/domain.rng src/conf/domain_conf.[ch]: extend the domain schema and parsing/serialization for the

[libvirt] [PATCH] network utilities: Properly convert port numbers to/from network byte order

* src/util/network.c: Add htons and ntohs in virSocket(Get|Set)Port --- src/util/network.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/util/network.c b/src/util/network.c index d67340a..56426e7 100644 --- a/src/util/network.c +++ b/src/util/network.c @@

[libvirt] [PATCH] network utilities: Allocate space for terminating NUL in virSocketFormatAddr

* src/util/network.c: Allocate an additional byte for virSocketFormatAddr's return buffer --- src/util/network.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/network.c b/src/util/network.c index 56426e7..f6588c7 100644 --- a/src/util/network.c +++

Re: [libvirt] [PATCH] network utilities: Allocate space for terminating NUL in virSocketFormatAddr

address[1], I'll withdraw this patch. Thanks, Matt [1] INET_ADDRSTRLEN == 16. I forgot there's only 3 dots, so I didn't think it was leaving space. -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458

Re: [libvirt] [PATCH 2/2] Add support for legacy QEMU's -vmchannel command line option

On 04/11/09 11:30, Richard W.M. Jones wrote: On Tue, Nov 03, 2009 at 04:11:48PM +, Matthew Booth wrote: This patch allows the following to be specified in a qemu domain: The patch looks sensible. What would be the problem with merging this functionality into libvirt? It seems it could

Re: [libvirt] [PATCH 3/4] chardev: Add function to output -chardev options

Agree virBuffer is nicer here, although it's not used anywhere else in qemu_conf.c. Here's an updated patch which uses a virBuffer instead. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] chardev: Add function to output -chardev options

Note that, on its own, this patch will generate a warning about an unused static function. --- src/qemu/qemu_conf.c | 68 ++ 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt] Guestfwd support (round 3)

This is substantially the same as the last set. I don't think I changed patches 1 and 2 at all. Patch 3 is updated to use a virBuffer as Rich Jones recommended. Patch 4 is updated slightly for the above change, and there are a couple of other trivial tidy ups in there. Patch 5 is new. QEMU's

[libvirt] [PATCH 1/5] character device: Allow character devices to have different target types

Currently a character device's target (it's interface in the guest) has only a single property: port. This patch is in preparation for adding targets which require other properties. Target properties are moved into a union in virDomainChrDef, and a targetType field is added to identify which

[libvirt] [PATCH 2/5] Detect availability of QEMU -chardev command line option

--- src/qemu/qemu_conf.c |2 ++ src/qemu/qemu_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 19b2d36..2981b51 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -894,6 +894,8 @@ static unsigned int

[libvirt] [PATCH 3/5] chardev: Add function to output -chardev options

Note that, on its own, this patch will generate a warning about an unused static function. --- src/qemu/qemu_conf.c | 68 ++ 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt] [PATCH 5/5] guestfwd: Ensure guestfwd address is IPv4

* src/conf/domain_conf.c: Throw an error if guestfwd address isn't IPv4 --- src/conf/domain_conf.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 94bce1e..ec2a1bc 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH 4/5] Add support for qemu's guestfwd

This patch allows the following to be specified in a qemu domain: channel type='pipe' source path='/tmp/guestfwd'/ target type='guestfwd' address='10.0.2.1' port='4600'/ /channel This will output the following on the qemu command line: -chardev pipe,id=channel0,path=/tmp/guestfwd \ -net

[libvirt] [PATCH] Use virBuffer when constructing QEMU character device command line

This patch updates qemudBuildCommandLineChrDevStr to use a virBuffer instead of a char[]. This is slightly tidier, and it makes it cleaner to (ap|pre)pend the output in other command lines. * src/qemu/qemu_conf.c: Update qemudBuildCommandLineChrDevStr to use a virBuffer --- src/qemu/qemu_conf.c

[libvirt] Add support for qemu's guestfwd

This is an update of the patchset I posted yesterday. There have been a few changes in the 4th patch, which actually adds guestfwd support: Firstly, after discussion on IRC, it was agreed that 'vmchannel' is a poor name for the collection of implementations of private host-guest channels, because

[libvirt] [PATCH 1/4] character device: Allow character devices to have different target types

Currently a character device's target (it's interface in the guest) has only a single property: port. This patch is in preparation for adding targets which require other properties. Target properties are moved into a union in virDomainChrDef, and a targetType field is added to identify which

[libvirt] [PATCH 2/4] Detect availability of QEMU -chardev command line option

--- src/qemu/qemu_conf.c |2 ++ src/qemu/qemu_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 4fd158c..e5d19ef 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -875,6 +875,8 @@ static unsigned int

[libvirt] [PATCH 1/2] Detect availability of legacy QEMU -vmchannel command line option

* src/qemu/qemu_conf.[ch]: Detect -vmchannel command line option --- src/qemu/qemu_conf.c |2 ++ src/qemu/qemu_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 0fbc190..33a55d7 100644 --- a/src/qemu/qemu_conf.c

[libvirt] [PATCH 2/2] Add support for legacy QEMU's -vmchannel command line option

This patch allows the following to be specified in a qemu domain: channel type='unix' source mode='bind' path='/tmp/vmchannel'/ target type='vmchannel' deviceid='0200'/ /channel This will output the following on the qemu command line: -vmchannel di:0200,unix:/tmp/vmchannel,server,nowait *

[libvirt] [PATCH] network utilities: Add functions for address-text and get/set port number

--- src/libvirt_private.syms |3 ++ src/util/network.c | 88 +- src/util/network.h |6 +++ 3 files changed, 96 insertions(+), 1 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 8525dbd..15d75fd

[libvirt] [PATCH] network utilities: Add functions for address-text and get/set port number

--- src/libvirt_private.syms |3 + src/util/network.c | 97 +- src/util/network.h |6 +++ 3 files changed, 105 insertions(+), 1 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 8525dbd..15d75fd

[libvirt] Add support for qemu's guestfwd

This series adds support for a vmchannel using qemu's guestfwd. I'll be following up with support for virtio-serial and RHEL5's vmchannel. A vmchannel is specified as: vmchannel type='pipe' source path='/tmp/vmchannel'/ target type='guestfwd' address='10.0.2.1' port='4600'/ /vmchannel There

[libvirt] [PATCH 1/4] character device: Allow character devices to have different target types

Currently a character device's target (it's interface in the guest) has only a single property: port. This patch is in preparation for adding targets which require other properties. Target properties are moved into a union in virDomainChrDef, and a targetType field is added to identify which

[libvirt] [PATCH 2/4] Detect availability of QEMU -chardev command line option

--- src/qemu/qemu_conf.c |2 ++ src/qemu/qemu_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 767965c..c4690b2 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -875,6 +875,8 @@ static unsigned int

[libvirt] [PATCH 3/4] chardev: Add function to output -chardev options

Note that, on its own, this patch will generate a warning about an unused static function. --- src/qemu/qemu_conf.c | 87 ++ 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt] [PATCH 4/4] Add support for qemu's guestfwd

This patch allows the following to be specified in a qemu domain: vmchannel type='pipe' source path='/tmp/vmchannel'/ target type='guestfwd' address='10.0.2.1' port='4600'/ /vmchannel This will output the following on the qemu command line: -chardev pipe,id=vmchannel0,path=/tmp/vmchannel \

[libvirt] [REPOST] Fix --with-init-script configure option

Looks like this one might have dropped off the radar. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Fix --with-init-script configure option

The --with-init-script configure option was broken, and always defaulted based on the existence of /etc/redhat-release. This was a systematic typo based on mixed use of init-script and init-scripts. --- configure.in | 14 +++--- daemon/Makefile.am |4 ++-- 2 files changed, 9

[libvirt] [PATCH 1/2] Add internal symbols for util/network.c

* src/libvirt_private.syms: Add symbols added in 24c8fc5d --- src/libvirt_private.syms | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 3997704..96c2b3b 100644 --- a/src/libvirt_private.syms +++

[libvirt] [PATCH 2/2] src/util/network.c: Fix typos in comments

--- src/util/network.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/network.c b/src/util/network.c index 8581cdc..abd866c 100644 --- a/src/util/network.c +++ b/src/util/network.c @@ -91,11 +91,11 @@ virSocketParseAddr(const char *val, virSocketAddrPtr

[libvirt] [PATCH] Fix --with-init-script configure option

The --with-init-script configure option was broken, and always defaulted based on the existence of /etc/redhat-release. This was a systematic typo based on mixed use of init-script and init-scripts. --- configure.in | 14 +++--- daemon/Makefile.am |4 ++-- 2 files changed, 9