Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Michal Privoznik
On 25.09.2012 19:08, Doug Goldstein wrote: On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik

[libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Dmitry Fleytman
This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard To QEMU emulator version 1.0,1 (qemu-kvm-1.0.1), Copyright (c) 2003-2008 Fabrice Bellard Comma in version

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Michal Privoznik
On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard To QEMU emulator version 1.0,1 (qemu-kvm-1.0.1), Copyright

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Dmitry Fleytman
Hi, Michal, This is qemu 1.0.1 rpm from fc17. Sent from my iPad On Sep 25, 2012, at 2:49 PM, Michal Privoznik mpriv...@redhat.com wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Michal Privoznik
On 25.09.2012 15:01, Dmitry Fleytman wrote: Hi, Michal, This is qemu 1.0.1 rpm from fc17. Yup, it's a bug. A typo to be exact. Here is the build: http://koji.fedoraproject.org/koji/buildinfo?buildID=344872 and if you'd download and unpack .src.rpm and subsequently qemu-kvm-1.0.1.tar.gz

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Dmitry Fleytman
Since this rpm released already, should fix be made anyway? Should it just treat that comma as a dot (current fix is a little bit more sophisticated)? On Tue, Sep 25, 2012 at 3:45 PM, Michal Privoznik mpriv...@redhat.comwrote: On 25.09.2012 15:01, Dmitry Fleytman wrote: Hi, Michal, This

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 04:03:35PM +0200, Dmitry Fleytman wrote: Since this rpm released already, should fix be made anyway? No, the QEMU update should be unpushed, or obsoleted by a new one that works. Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Eric Blake
On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2012 at 7:49 AM, Michal Privoznik mpriv...@redhat.com wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Eric Blake
On 09/25/2012 11:01 AM, Daniel P. Berrange wrote: I agree, it smells very much like a QEMU/distro bug to me. It is an upstream bug: https://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02527.html Distros should probably be backporting that particular patch, but there's still the