Re: [Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-16 Thread Indrajit Raychaudhuri
Wonderful, and thanks for the credits! Cheers, Indrajit On 15/12/09 11:49 PM, Timothy Perrett wrote: Awesome Dave! Thanks for the acknowledgement. Cheers, Tim On 15 Dec 2009, at 18:07, Dave Briccetti wrote: Thanks again for the help. Here are tho talk slides:

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-16 Thread Alex Black
Hey Dave, great site, beautiful photography. If you had time you might add some URL rewriting, so that galleries had nice urls like: http://briccettiphoto.com/show/galleries/kenya - Alex On Dec 13, 1:44 am, Dave Briccetti da...@davebsoft.com wrote: For a lightning talk at Bay Area Scala

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-15 Thread Dave Briccetti
Thanks again for the help. Here are tho talk slides: http://www.slideshare.net/dcbriccetti/birdshow-a-lift-app-for-showing-flickr-photos-2720594 -- You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to

Re: [Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-15 Thread Timothy Perrett
Awesome Dave! Thanks for the acknowledgement. Cheers, Tim On 15 Dec 2009, at 18:07, Dave Briccetti wrote: Thanks again for the help. Here are tho talk slides: http://www.slideshare.net/dcbriccetti/birdshow-a-lift-app-for-showing-flickr-photos-2720594 -- You received this message because

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Timothy Perrett
On the whole, looks quite tidy. However, what made you go for the Loggable trait? Why dont you use lift's backed in logging utilities? The only other thing possibly to consider would be parallel executing snippets - im not sure if its 100% applicable for your use case, but maybe it could work for

Re: [Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Indrajit Raychaudhuri
Very tidy indeed! I like the style and formatting :) Some more points in addition to what Tim mentioned: 1. The application is based on Lift 1.0 and Scala 2.7.3. Moving to Lift 1.1 (with Scala 2.7.7) would be recommended. Lift 1.1-SNAPSHOT should be fine or wait for the Lift 1.1-M8

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Timothy Perrett
The point about snippets is a subjective one - it depends what Dave is trying to show in his presentation my thought would be to leave them as they are because it makes lift appear simpler (that is, there is auto-wire-up). However, for production, stateless snippets should be objects with

Re: [Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Indrajit Raychaudhuri
On 14/12/09 12:06 AM, Timothy Perrett wrote: The point about snippets is a subjective one - it depends what Dave is trying to show in his presentation my thought would be to leave them as they are because it makes lift appear simpler (that is, there is auto-wire-up). Point taken.

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Indrajit Raychaudhuri
Dave, I have updated your application to Lift 1.1-SNAPSHOT on my github fork [1] and sent you a pull request. This basically covers #1 thru' #4 in my list. Feel free to merge if it interests you. [1] http://github.com/indrajitr/bird-show Cheers, Indrajit On Dec 14, 12:25 am, Indrajit

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Dave Briccetti
Thank you, Tim and Indrajit! I changed the logging, pulled and pushed Indrajit’s changes, and I’m now studying the rest of the suggestions. I set LiftRules.enableLiftGC = false, simply to avoid the client- server interactions that from the point of view of a user don’t seem necessary, and, in

Re: [Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Indrajit Raychaudhuri
Cool Dave! Superb pictures, btw. On 14/12/09 1:34 AM, Dave Briccetti wrote: Thank you, Tim and Indrajit! I changed the logging, pulled and pushed Indrajit’s changes, and I’m now studying the rest of the suggestions. I set LiftRules.enableLiftGC = false, simply to avoid the client- server

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Dave Briccetti
I discovered I need a way to perodically reload certain cached data from Flickr. What sort of timer/actor/thread should I use. Every hour or so I want to call a method from Flickr.scala on each FlickrUser object. -- You received this message because you are subscribed to the Google Groups Lift

Re: [Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Alex Boisvert
One comment I would make about Parallelizer is that it creates a new thread pool every time it's invoked. This isn't very efficient but more importantly, it's somewhat reckless. Imagine if your home page or your search function are invoked simultaneously by 10 users (or more). The application

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Dave Briccetti
Very helpful suggestions. Thanks. How can I hook into Web app shutdown/undeployment so I can shut down the thread pool? -- You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to lift...@googlegroups.com. To unsubscribe from

Re: [Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Alex Boisvert
Use LiftRules.unloadHooks.append(myShutdownHook) From LiftRules.scala: /** * Hooks to be run when LiftServlet.destroy is called. */ val unloadHooks = RulesSeq[() = Unit] alex On Sun, Dec 13, 2009 at 6:45 PM, Dave Briccetti da...@davebsoft.com wrote: Very helpful suggestions. Thanks.

[Lift] Re: Please review a simple app for displaying Flickr pictures

2009-12-13 Thread Dave Briccetti
Great. Changes made to Parallelizer to use a single thread pool. Thanks, and hope to see you Monday. -- You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to lift...@googlegroups.com. To unsubscribe from this group, send email