Re: CG: describe new C++ formatting (GOP-PROP 3) (issue4760056)

On 2011/07/18 23:19:44, Graham Percival wrote: here's a series of patches for the C++ formatting. - final (?) set of changes to fixcc.py - changes to CG Now that we do not want tabs in indents, it would be nice to add (setq indent-tabs-mode nil) to emacs' suggested setup of C++ and Python ho

Re: Fixes error for tuplet bracket direction calculation when tuplets contain rests. (issue4668045)

On Jul 18, 2011, at 11:45 PM, n.putt...@gmail.com wrote: > Hi Mike, > > This looks fine apart from the following change: > > \relative c'' { > \voiceTwo > \times 2/3 { r r r } > } > > -> bracket still above stave > > The simplest fix is probably to add TupletBracket to > direction-polyphonic-

Re: PATCH: 48-hour countdown

On 7/18/11 9:48 PM, "Graham Percival" wrote: > On Mon, Jul 18, 2011 at 08:44:13PM -0600, Colin Campbell wrote: >> Countdown done, but still open/not fixed: > > All those should be marked "patch-needs_work". When a new version > of the patch is available, James will check that it passes the >

Re: PATCH: 48-hour countdown

On Mon, Jul 18, 2011 at 08:44:13PM -0600, Colin Campbell wrote: > Countdown done, but still open/not fixed: All those should be marked "patch-needs_work". When a new version of the patch is available, James will check that it passes the regtests, and then they are simply "patch-review" items. Th

Re: PATCH: 48-hour countdown

On 7/18/11 8:44 PM, "Colin Campbell" wrote: > Countdown done, but still open/not fixed: > > 21:00 MST Monday July 18 >     Issue 1695 : > Clef change placed outside score - Rietveld - 4683043 >

Re: PATCH: 48-hour countdown

On 7/18/11 8:44 PM, "Colin Campbell" wrote: >New today, for 21:00 MST Wednesday July 20 (Where were you 42 years ago > that day?) I was watching Neil Armstrong step on the moon in my living room, IIRC. >     Issue 1752 : > redesigni

PATCH: 48-hour countdown

New today, for 21:00 MST Wednesday July 20 (Where were you 42 years ago that day?) Issue 1678 : Midi gives false warnings - Rietveld issue4757043 : MIDI: reset channel counters when done

Re: a starting point to 1301

2011/7/18 Janek Warchoł : > My friend and I, having some spare time, wanted to fix a bug > http://code.google.com/p/lilypond/issues/detail?id=1301.  It's related > to planning distribution of music notes and other signs, so we need > some overview how the whole process works.  Comments in the sourc

CG: describe new C++ formatting (GOP-PROP 3) (issue4760056)

Reviewers: , Message: here's a series of patches for the C++ formatting. - final (?) set of changes to fixcc.py - changes to CG Description: CG: describe new C++ formatting (GOP-PROP 3) Adapt fixcc.py to use Astyle Please review this at http://codereview.appspot.com/4760056/ Affected files:

Re: modifying default behaviour of tremolo slashes (issue4636081)

2011/7/18 Neil Puttock : > 2011/7/18 Janek Warchoł : > >> Btw, >> >>> [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm] >>> Writing "internals.texi"...ERROR: In procedure procedure-name: >>> ERROR: Wrong type argument in position 1: #f >>> make[1]: *** [out/interna

Re: a starting point to 1301

2011/7/18 Janek Warchoł : > My friend and I, having some spare time, wanted to fix a bug > http://code.google.com/p/lilypond/issues/detail?id=1301.  It's related > to planning distribution of music notes and other signs, so we need > some overview how the whole process works.  Comments in the sour

Re: modifying default behaviour of tremolo slashes (issue4636081)

2011/7/18 Janek Warchoł : > Btw, > >> [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm] >> Writing "internals.texi"...ERROR: In procedure procedure-name: >> ERROR: Wrong type argument in position 1: #f >> make[1]: *** [out/internals.texi] Error 1 >> rm out/weblink

Re: modifying default behaviour of tremolo slashes (issue4636081)

2011/7/18 : > Hello, can someone else verify? > > I get a make fail: I get it too... Strange, it compiled some time ago. Btw, > [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm] > Writing "internals.texi"...ERROR: In procedure procedure-name: > ERROR: Wrong type

Re: Fixes error for tuplet bracket direction calculation when tuplets contain rests. (issue4668045)

Hi Mike, This looks fine apart from the following change: \relative c'' { \voiceTwo \times 2/3 { r r r } } -> bracket still above stave The simplest fix is probably to add TupletBracket to direction-polyphonic-grobs. Cheers, Neil http://codereview.appspot.com/4668045/ ___

Re: Doc: NR Added new Node for Footnotes (issue4751045)

On 18 July 2011 22:00, wrote: > Ok I tried > > \relative c' { >  > >> 1 } for myself and it works but I get two indicators and two footnotes > > on each note inside the chord. So is this a special case? If so then I > can add a snippet or another @lilypond to illustrate this. See the documentat

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

On 2011/07/18 20:01:00, J_lowe wrote: Make works fine but I get a seg fault when I do a make check after a test-baseline for the reg test comparison. Same here. stem-tremolo.ly segfaults inside rhythmic-column.cc; the acknowledged StemTremolo doesn't have an X-parent. http://codereview.appspo

Re: Doc: NR Added new Node for Footnotes (issue4751045)

Thanks for the input, I have some questions about three of the corrections/suggestions. http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/inpu

Re: Fix 1563: System start bars interpreted collapse-height as absolute length. (issue4693043)

http://codereview.appspot.com/4693043/diff/1/lily/system-start-delimiter.cc File lily/system-start-delimiter.cc (right): http://codereview.appspot.com/4693043/diff/1/lily/system-start-delimiter.cc#newcode117 lily/system-start-delimiter.cc:117: staffspace = Staff_symbol_referencer::staff_space (s

Re: modifying default behaviour of tremolo slashes (issue4636081)

Hello, can someone else verify? I get a make fail: --snip-- [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm] Writing "internals.texi"...ERROR: In procedure procedure-name: ERROR: Wrong type argument in position 1: #f make[1]: *** [out/internals.texi] Error 1 r

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

Make works fine but I get a seg fault when I do a make check after a test-baseline for the reg test comparison. http://codereview.appspot.com/4754054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypon

a starting point to 1301

Hi, My friend and I, having some spare time, wanted to fix a bug http://code.google.com/p/lilypond/issues/detail?id=1301. It's related to planning distribution of music notes and other signs, so we need some overview how the whole process works. Comments in the source code are rare and in the do

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

On 2011/07/18 19:47:53, Neil Puttock wrote: On 2011/07/18 19:28:51, MikeSol wrote: > How would pure height affect the calculation of horizontal skylines? It should ensure the skylines are correct, assuming there's an entry for Stem_tremolo::height in pure-conversions-alist. It looks li

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

On 2011/07/18 19:28:51, MikeSol wrote: How would pure height affect the calculation of horizontal skylines? It should ensure the skylines are correct, assuming there's an entry for Stem_tremolo::height in pure-conversions-alist. It looks like the existing height function is pure since it does

Re: where X-extent of noteheads is set?

2011/7/18 Neil Puttock : > No, the problem is that the code doesn't account for differences in > font-size between heads; all the hard-coded shifts it calculates > (split equally between heads; heads move away from each other by the > same amount) are based on the assumption that meshing notes hav

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

On 2011/07/18 19:24:26, Neil Puttock wrote: Hi Mike, I think this is too complicated; you can probably achieve the same result via a Stem_tremolo::pure_height function. Cheers, Neil Thanks for the feedback! How would pure height affect the calculation of horizontal skylines? The issue

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

Hi Mike, I think this is too complicated; you can probably achieve the same result via a Stem_tremolo::pure_height function. Cheers, Neil http://codereview.appspot.com/4754054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.

Re: where X-extent of noteheads is set?

On Jul 18, 2011, at 8:00 PM, Janek Warchoł wrote: > 2011/7/18 Joe Neeman : >> 2011/7/17 Janek Warchoł : >>> I've searched in note-head.cc, note-column.cc, note-heads-engraver.cc >>> but found nothing... >> >> I believe it defaults to ly:grob::stencil-width (probably in grob.cc). > > 2011/7/17 Ne

Re: where X-extent of noteheads is set?

2011/7/18 Janek Warchoł : > i don't see anything called "stencil-width" in grob.cc... 78 if (get_property_data ("X-extent") == SCM_EOL) 79 set_property ("X-extent", Grob::stencil_width_proc); The C++ name is Grob::stencil_width; the addition of _proc uses the exported scheme version. > I

Re: Creates callback for stem-begin-position. (issue4752048)

My "review" will be a bit non-standard (as i'm still a rookie programmer): i understand what's going on here, so it's probably good :) http://codereview.appspot.com/4752048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/m

Re: where X-extent of noteheads is set?

2011/7/18 Joe Neeman : > 2011/7/17 Janek Warchoł : >> I've searched in note-head.cc, note-column.cc, note-heads-engraver.cc >> but found nothing... > > I believe it defaults to ly:grob::stencil-width (probably in grob.cc). 2011/7/17 Neil Puttock : > 2011/7/17 Janek Warchoł : >> I've searched in no

Re: Creates callback for stem-begin-position. (issue4752048)

On 2011/07/18 00:53:01, hanwenn wrote: LGTM There is some code that adjusts for the shape of the notehead as well (look for calls to Note_head::stem_attachment_coordinate). Can you have a look if you can work that into your code too? Done. New patch set uploaded. http://codereview.apps

Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

Reviewers: , Message: This fixes issue 1768. Description: Fixes note column skylines by adding stem tremolo to axis group. Please review this at http://codereview.appspot.com/4754054/ Affected files: A input/regression/stem-tremolo-note-column.ly M lily/include/note-column.hh M lily/note

Amend load order and add ability to compile & load compiled scheme files for Guile V2 (issue4760049)

Reviewers: Patrick McCarty, carl.d.sorensen_gmail.com, Description: Amend load order and add ability to compile & load compiled scheme files for Guile V2. This is very much work-in-progress and will eventually be two patches. One for the load order (T1349) and another for the scheme compile faci

Re: Ties colliding in single-staff polyphony

On Jul 18, 2011, at 11:43 AM, Bertrand Bordage wrote: > I was referring to issues 1606, This should be fixed in the beam-collision-engraver such that it avoids ties. A simple implementation would avoid the rectangular bounding box around tie, whereas a more robust implementation would use the

Re: Ties colliding in single-staff polyphony

I was referring to issues 1606, 590, 582, 570, 480, 409, 397. These could be fixed with a Tie_collision_engraver. I would like to try to implement this engraver if you are disposed to help me. Regards, Bertrand ___ lilypond-devel mailing list lilypond-de

Re: Ties colliding in single-staff polyphony

On Jul 18, 2011, at 11:00 AM, Bertrand Bordage wrote: > Thanks Dmytro ! > > I looked at what Mike said. > Could not there be more code in common between ties and slurs? > A tie isn't so different from a slur, is it ? > By doing so, we could get rid of TieColumn and many bugs. [moving to devel]