Re: merging regtests

On Tue, Aug 30, 2011 at 06:25:44AM +0100, Graham Percival wrote: > As a temporary workaround, I will now reduce the number of > regression tests. In particular, I will merge the segfault > regtests -- we don't care about the output of those; we just want > to make sure that lilypond doesn't crash.

merging regtests

We haven't had a release in a month. More to the point, we haven't had a regtest comparison in a month. But we've had lots of patches go in. I will bet money that we have at least 3 regressions. I will also bet money that at least 1 of them is from a developer who is going on vacation soon. (n

PATCH: 48-hour countdown to 20110831

For 23:00 MDT Wednesday, August 31 Issue 1849 : Fix memleak: temporary skyline objects for systems were never deleted - R Issue 4923048 Issue 1847

summarizing patches for review (was: Gets rid of length in the docs. (issue 4965053))

On Mon, Aug 29, 2011 at 11:32:16PM +0100, Trevor Daniels wrote: > > Indeed. Perhaps we could make a clearer distinction > between patches that must be reviewed, like those > which cause syntax changes, those which add new > features and those by relative newcomers, and those > that should simply

Re: Gets rid of length in the docs. (issue 4965053)

Graham Percival wrote Monday, August 29, 2011 9:55 AM On Mon, Aug 29, 2011 at 09:15:54AM +0100, Trevor Daniels wrote: If you force patches through at the present rate they're not going to be carefully reviewed. I'm open to suggestions. The development team is producing approximately 20 pa

Re: Fixes missing images in big website page (issue 4963046)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; ; Sent: Monday, August 29, 2011 2:29 PM Subject: Re: Fixes missing images in big website page (issue 4963046) On Mon, Aug 29, 2011 at 02:00:51PM +0100, Phil Holmes wrote: - Original Message - From: To

Re: Lets auto numbering of footnotes kick in from commands alone. (issue 4837047)

On Aug 28, 2011, at 12:44 PM, pkx1...@gmail.com wrote: > passes make and reg tests. > > http://codereview.appspot.com/4837047/ Pushed as 181366ec566a338c265ff4960724202d0d55ef79. Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org http

Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

Reviewers: Graham Percival, Message: As requested - please review. Description: This demonstrates how to import a library into a python file where the path is not already in the pathlist. It half-fixes the issue where languages are defined in many places in make website - the other needs change

Re: Uses Y-offset for stem tremolos instead of translated stencil. (issue 4867043)

On Aug 28, 2011, at 12:51 PM, pkx1...@gmail.com wrote: > Mike I get a failed patch apply here on the current tre (28 Aug) > > --snip-- > You were applying an old patch that conflicted with current master. I rebased and pushed as 7623fef74bf21fc726a8c60b535e7794f9776700. > Also we have a numb

Re: Adds a site search to website and improves docsearch(issue4894053)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Monday, August 29, 2011 12:32 PM Subject: Re: Adds a site search to website and improves docsearch(issue4894053) On Mon, Aug 29, 2011 at 11:34:46AM +0100, Phil Holmes wrote: There's a gotcha over the website

Re: Fixes missing images in big website page (issue 4963046)

On Mon, Aug 29, 2011 at 02:00:51PM +0100, Phil Holmes wrote: > - Original Message - From: > To: > Cc: ; > Sent: Monday, August 29, 2011 1:58 PM > Subject: Re: Fixes missing images in big website page (issue 4963046) > > > >I see images, but not ly-examples. Are you sure you see ly-exa

Re: Fixes missing images in big website page (issue 4963046)

- Original Message - From: To: Cc: ; Sent: Monday, August 29, 2011 1:58 PM Subject: Re: Fixes missing images in big website page (issue 4963046) I see images, but not ly-examples. Are you sure you see ly-examples on your system? http://codereview.appspot.com/4963046/ Is this aft

Re: Fixes missing images in big website page (issue 4963046)

I see images, but not ly-examples. Are you sure you see ly-examples on your system? http://codereview.appspot.com/4963046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

Updated. Bertrand http://codereview.appspot.com/4387046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve language handling (was Re: Fixes missing images in big website page (issue 4964041))

On Mon, Aug 29, 2011 at 12:48:59PM +0100, Phil Holmes wrote: > - Original Message - From: > > >I'd rather keep this list separate. I suppose that technically it could > >still be put into langdefs.py and define a list of "all translations" > >and another list of "website-approved transla

Improve language handling (was Re: Fixes missing images in big website page (issue 4964041))

- Original Message - From: I don't mind having broken translations in the main documentation (IIRC every language is broken in some respect), but I don't want the main public website having a significantly broken translation. I'd rather keep this list separate. I suppose that technic

don't use "fix xyz" in git commit messages

For more visibility: saying "fix 123" only means something to people who have memorized all 600+ open bugs. - please give a short description of the actual code change, like "foo grob now avoids collisions with baz (123)". I think it's still useful to add the issue number, but that should on

Re: Adds a site search to website and improves docsearch(issue4894053)

On Mon, Aug 29, 2011 at 11:34:46AM +0100, Phil Holmes wrote: > There's a gotcha over the website created like this. The images in > examples are only created in the make doc and require lilypond to be > present to create them, so without substantial other work they won't > be there. Yes. I want

Re: Prevents nested tuplets from colliding. (issue 4808082)

Hey all, Sorry to not have pushed this yet, but I recently rebased this against current master and it looks like my stem work actually fixed a good deal of what some of this patch was fixing. I've gotten rid of about half the code from this patch and posted a new version. For now, this is just

Re: Gets rid of length in the docs. (issue 4965053)

Am Montag, 29. August 2011, 11:56:17 schrieb Janek Warchoł: > From my point of view, commit messages, descriptions in tracker and on > Rietveld are essential. Some patches have no description and i cannot > say anything about them. +1. Also, Rietveld descriptions like "Fix 1234" are NOT useful a

Re: Adds a site search to website and improves docsearch(issue4894053)

- Original Message - From: "Graham Percival" It's the VERSION in the base git repository. TOP_SRC_DIR just tells make where to find your git directory. So what happens when you adjust the command-line accordingly? Hey. It's magic. It works! For the record: make -f ../lilypond

Re: fixing website translations

2011/8/29 Francisco Vila : > I'll take a look at it. Thank you Done. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: fixing website translations

2011/8/29 Federico Bruni : > Il giorno lun, 22/08/2011 alle 13.53 +0200, Federico Bruni ha scritto: >> Il giorno lun, 22/08/2011 alle 00.57 -0700, Graham Percival ha scritto: >> > There is NO SUCH @node called {Text editor support}.  You have >> > named that @node "LilyPond e gli editor di testo".

Re: fixing website translations

Il giorno lun, 22/08/2011 alle 13.53 +0200, Federico Bruni ha scritto: > Il giorno lun, 22/08/2011 alle 00.57 -0700, Graham Percival ha scritto: > > There is NO SUCH @node called {Text editor support}. You have > > named that @node "LilyPond e gli editor di testo". So fix your > > Documentation/i

Fixes missing images in big website page (issue 4963046)

Reviewers: Graham Percival, Message: As requested, an updated code review. Please review. Description: This is an updated patch to put the missing image files back into http://lilypond.org/doc/v2.15/Documentation/web-big-page.html#examples. It adds an extra element to the path to ly-examples (

Re: Gets rid of length in the docs. (issue 4965053)

2011/8/29 Graham Percival : > On Mon, Aug 29, 2011 at 09:15:54AM +0100, Trevor Daniels wrote: >> >> I've given up looking at code-change patch count-downs. > ... >> If you force patches through at the present rate >> they're not going to be carefully reviewed. > > I'm open to suggestions.  The deve

Re: beam-slope-stemlet.ly

On Aug 29, 2011, at 11:54 AM, Graham Percival wrote: > On Mon, Aug 29, 2011 at 11:18:27AM +0200, m...@apollinemike.com wrote: >> In general, for small things like this that come in over the >> next few days and that are a result of the recent changes in >> flags and stems, I will make the correcti

Re: beam-slope-stemlet.ly

On Mon, Aug 29, 2011 at 11:18:27AM +0200, m...@apollinemike.com wrote: > In general, for small things like this that come in over the > next few days and that are a result of the recent changes in > flags and stems, I will make the correction on git master if it > passes regtests. It would be good

Re: Adds a site search to website and improves docsearch(issue4894053)

On Mon, Aug 29, 2011 at 10:10:35AM +0100, Phil Holmes wrote: > - Original Message - From: "Graham Percival" > > >On Sun, Aug 28, 2011 at 04:03:10PM +0100, Phil Holmes wrote: > >>>6. run > >>> make -f ../make/website.make WEBSITE_ONLY_BUILD=1 \ > >>> TOP_SRC_DIR=$HOME/src/lilypond/ \ > >>

Re: beam-slope-stemlet.ly

On Aug 28, 2011, at 7:26 PM, Mike Solomon wrote: > Hey all, > > Just a note to say that the intermittent inconsistencies that I was getting > in the regtests for beam-slope-stemlet.ly (check out my first e-mail about > the stem patch under "The Ugly") have come up again in a regtest I recently

Re: Adds a site search to website and improves docsearch(issue4894053)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Monday, August 29, 2011 1:30 AM Subject: Re: Adds a site search to website and improves docsearch(issue4894053) On Sun, Aug 28, 2011 at 04:03:10PM +0100, Phil Holmes wrote: >6. run > make -f ../make/website.

Re: Gets rid of length in the docs. (issue 4965053)

On Aug 29, 2011, at 10:55 AM, Graham Percival wrote: > On Mon, Aug 29, 2011 at 09:15:54AM +0100, Trevor Daniels wrote: >> >> Graham Percival wrote Monday, August 29, 2011 8:53 AM >> >>> Moral of the story? pay more attention to patch countdowns, I >> >> I've given up looking at code-change pa

Re: Gets rid of length in the docs. (issue 4965053)

On Mon, Aug 29, 2011 at 09:15:54AM +0100, Trevor Daniels wrote: > > Graham Percival wrote Monday, August 29, 2011 8:53 AM > > >Moral of the story? pay more attention to patch countdowns, I > > I've given up looking at code-change patch count-downs. ... > If you force patches through at the pres

Re: Gets rid of length in the docs. (issue 4965053)

Graham Percival wrote Monday, August 29, 2011 8:53 AM Moral of the story? pay more attention to patch countdowns, I I've given up looking at code-change patch count-downs. There's no way I can spare the time required. Each one requires the time to understand the area of code, analyse the pa

Re: Gets rid of length in the docs. (issue 4965053)

On Aug 29, 2011, at 9:53 AM, Graham Percival wrote: > On Mon, Aug 29, 2011 at 07:45:04AM +, tdanielsmu...@googlemail.com wrote: >> I can't say I like this change: it makes a complex user >> interface more complex. Shouldn't we be moving in the >> opposite direction? > I disagree. There used

Re: Gets rid of length in the docs. (issue 4965053)

On Mon, Aug 29, 2011 at 07:45:04AM +, tdanielsmu...@googlemail.com wrote: > I can't say I like this change: it makes a complex user > interface more complex. Shouldn't we be moving in the > opposite direction? On general principle I agree, but I believe that this patch simply brings the docs

Re: Gets rid of length in the docs. (issue 4965053)

I can't say I like this change: it makes a complex user interface more complex. Shouldn't we be moving in the opposite direction? http://codereview.appspot.com/4965053/diff/4001/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/