Hello list,
while trying to get more insight into the engraver stuff, I encountered a
problem. I hope I can explain it:
I need some kind of a array of vectors:
vectorStream_event* slot_[max];
where I can store events later on by calling
slot_[i].push_back (event);
The index i lies in a
Am 16.09.2011 10:43, schrieb David Kastrup:
Marc Hohlm...@hohlart.de writes:
[...]
Unnecessary copying. Better do
Pitch *current_pitch = unsmob_pitch (event-get_property (pitch));
string pitchstring = current_pitch-to_string ();
Perfect. Thanks!
Marc
On Di., 20. Sep. 2011 05:29:32 CEST, Colin Campbell c...@shaw.ca wrote:
Issue 1890:
Compiler warnings in make on 64-bit systems - R 5039043
Cancel that patch countdown. The patch introduces more warnings than it fixes...
Cheers,
Reinhold
___
LGTM.
http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm
File scm/output-lib.scm (right):
http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm#newcode626
scm/output-lib.scm:626: (foo (display calculating pure y extent))
¿Qué es?
Joe Neeman joenee...@gmail.com writes:
On Mon, Sep 19, 2011 at 9:35 PM, David Kastrup d...@gnu.org wrote:
Colin Campbell c...@shaw.ca writes:
Issue 935: Enhancement: optional arguments in music functions - R
5023044
Cancel countdown. I am still fuzzing with avoiding O(n^2) rules for n
On Di., 20. Sep. 2011 05:29:32 CEST, Colin Campbell c...@shaw.ca wrote:
Issue 1890:
Compiler warnings in make on 64-bit systems - R 5039043
Cancel that patch countdown. The patch introduces more warnings than it fixes...
Cheers,
Reinhold
___
passes make and reg tests
http://codereview.appspot.com/5038045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Graham Percival wrote Tuesday, September 20, 2011 12:09 AM
1. Find a different patch management tool
2. Find a different patch and issue management tool
3. Write a few python scripts to make our lives better
I favor the last option.
So do I
* 1-5 hours: automatically switch any
- Original Message -
From: Bernardo Barros bernardobarr...@gmail.com
To: Phil Holmes m...@philholmes.net
Cc: lilypond-user lilypond-u...@gnu.org
Sent: Monday, September 19, 2011 6:48 PM
Subject: Re: building faillure
Here it is, thanks
(Copying to devel. Problem is a build failure
Hey!
I'm currently writing a doc entry that explains how to use replacements.
I have a few questions:
Where do you think I should put it? In NR 1.8.1 or 1.8.2?
Do you think I have to move the table from the regtest to the Appendix A
(and keep the rest of the regtest as a regtest)?
Bertrand
Thanks for applying these!
Sorry to bother you again with indentation, but you don't have to
replace spaces with tabulators in scripts/musicxml2ly.ly .
We decided that the rule for Python is 4 spaces per indentation level.
For more infos, see:
On 2011/09/20 10:18:41, Bertrand Bordage wrote:
Hey!
I'm currently writing a doc entry that explains how to use
replacements. I have
a few questions:
Where do you think I should put it? In NR 1.8.1 or 1.8.2?
Hmm.. I'd say 3.3.3 actually
On 2011/09/20 12:07:31, J_lowe wrote:
Where do you think I should put it? In NR 1.8.1 or 1.8.2?
Hmm.. I'd say 3.3.3 actually
Oh, yes! This is better.
Do you think I have to move the table from the regtest to the
Appendix A (and
keep the rest of the regtest as a regtest)?
I am not
On 11-09-20 02:32 AM, Trevor Daniels wrote:
Graham Percival wrote Tuesday, September 20, 2011 12:09 AM
1. Find a different patch management tool
2. Find a different patch and issue management tool
3. Write a few python scripts to make our lives better
I favor the last option.
So do I
On 2011/09/20 10:49:28, Bertrand Bordage wrote:
Thanks for applying these!
Sorry to bother you again with indentation, but you don't have to
replace spaces
don't have to == don't need to, I assume you mean you shouldn't
with tabulators in scripts/musicxml2ly.ly .
We decided that the rule
LGTM.
On 2011/09/20 14:15:53, Ian Hulin (gmail) wrote:
don't have to == don't need to, I assume you mean you shouldn't
with tabulators in scripts/musicxml2ly.ly .
Yes, this was a subtle DON'T DO IT! :)
http://codereview.appspot.com/4974078/
___
Phil: I can confirm your solution avoided the problem, thanks a bunch!
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New patch set including some documentation work.
http://codereview.appspot.com/4553056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
- Original Message -
From: Bernardo Barros bernardobarr...@gmail.com
To: Phil Holmes m...@philholmes.net
Cc: lilypond-user lilypond-u...@gnu.org; Devel
lilypond-devel@gnu.org
Sent: Tuesday, September 20, 2011 5:11 PM
Subject: Re: building faillure
Phil: I can confirm your solution
A few comments following a quick look at the doc changes
Trevor
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
Hmm, I don't understand one comment, but I agree with the others.
Thanks,
Bertrand
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
- Original Message -
From: Phil Holmes m...@philholmes.net
To: Bernardo Barros bernardobarr...@gmail.com
Cc: Devel lilypond-devel@gnu.org; lilypond-user
lilypond-u...@gnu.org
Sent: Tuesday, September 20, 2011 5:32 PM
Subject: Re: building faillure
- Original Message -
From:
Hi Neil,
2011/9/14 n.putt...@gmail.com:
http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly
File input/regression/kievan-notes.ly (right):
http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly#newcode11
2011/9/20 Graham Percival gra...@percival-music.ca:
On Tue, Sep 20, 2011 at 02:08:42AM +0200, Reinhold Kainhofer wrote:
Am Tuesday, 20. September 2011, 01:09:20 schrieb Graham Percival:
** Different patch and issue managment tools
* 1-3 hours: write a script that checks that every
Hi Reinhold all,
2011/9/12 Reinhold Kainhofer reinh...@kainhofer.com:
Am Monday, 12. September 2011, 12:01:25 schrieb Janek Warchoł:
I'm going to fix an issue where a note is misplaced by about 0.07
staffspace. I'll add a regtest for this, but how will we make sure
that it won't be
2011/9/19 bordage.bertr...@gmail.com:
On 2011/09/18 21:47:04, janek wrote:
I think LGTM, but it would be great if you'd add a regtest to
demonstrate what
this patch is fixing.
I don't think so. mensural-ligatures.ly contains every case fixed by
this patch.
True. However, your changes
Hi David (and Graham too),
2011/9/13 David Kastrup d...@gnu.org:
Graham Percival gra...@percival-music.ca writes:
On Tue, Sep 13, 2011 at 01:23:19AM +0200, David Kastrup wrote:
It's tutorial-speak at its best. I don't understand either your
unhappiness nor your displeasure.
The tutorial
2011/9/20 Janek Warchoł janek.lilyp...@gmail.com:
I'm not sure what is your opinion on this patch currently. Do you
agree to push it if it doesn't break make, make doc and regtests? Do
you agree with my comment no.7
http://code.google.com/p/lilypond/issues/detail?id=1873#c7 ?
Yes.
I'm
On Mon, Sep 19, 2011 at 09:29:32PM -0600, Colin Campbell wrote:
For 22:00 MDT Wednesday September 21, and *far* too early for an Autumnal
equinox!
As an experiment, I have changed all (hopefully?) of these issues
from Patch-review to Patch-countdown. You can see the complete
list here:
hi David,
LilyPond barfs at
\book
{
\bookOutputName foo
{ a' }
}
git bisect gave me commit
24fdf0d37cec73564162324ab74ed5e3a6824e8c
to blame.
I don't know what to do, could you help me?
p
___
lilypond-devel mailing list
lilypond-devel@gnu.org
2011/9/20 Neil Puttock n.putt...@gmail.com:
I'm running make doc with the patch applied at the moment. Will
report any problems.
There's nothing wrong with the patch as far as I can tell. Make doc
completes successfully here.
The only thing that's missing is an entry in
2011/9/13 Werner LEMBERG w...@gnu.org:
I think the solution is to create a shorter variaton of accidental
glyphs; an example in the attachment. How do you like this idea?
Do you think all accidentals should have shorter versions, or would
it be overkill to create for example a shorter
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1636
Documentation/notation/input.itely:1636: @end lilypond
On
Janek Warchoł janek.lilyp...@gmail.com writes:
Hi David (and Graham too),
I am not going to put up a patch on Rietveld and am not writing any
more documentation for this. I don't have the resources to put up a
fight for user appeal. It is enough of a chore to make Lilypond
useful for
On 20 September 2011 21:50, Benkő Pál benko@gmail.com wrote:
I don't know what to do, could you help me?
The attached patch works for me (haven't run make check on it though).
Cheers,
Neil
From f6f1ad62263b4dfb5f518da71891d3a0b30c89a3 Mon Sep 17 00:00:00 2001
From: Neil Puttock
2011/9/11 Graham Percival gra...@percival-music.ca:
Does anybody here feel like organizing tasks? We have a lot of
delayed maintenance stuff that is going to come back and bite us
in an unpleasant manner.
3) a full regression test examination: it's been about 5 years
since anybody actually
Benkő Pál benko@gmail.com writes:
hi David,
LilyPond barfs at
\book
{
\bookOutputName foo
{ a' }
}
git bisect gave me commit
24fdf0d37cec73564162324ab74ed5e3a6824e8c
to blame.
I don't know what to do, could you help me?
The easiest thing to do is to revert the patch.
Neil Puttock n.putt...@gmail.com writes:
On 20 September 2011 21:50, Benkő Pál benko@gmail.com wrote:
I don't know what to do, could you help me?
The attached patch works for me (haven't run make check on it though).
That would pretty much be what I would consider a proper fix and
bordage.bertr...@gmail.com
Tuesday, September 20, 2011 11:18 AM
Do you think I have to move the table from the regtest to the
Appendix A
(and keep the rest of the regtest as a regtest)?
Yes. Between the current A10 and A11 looks a good place.
Trevor
-
No virus found in this
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1636
Documentation/notation/input.itely:1636: @end lilypond
Yes,
On Tue, Sep 20, 2011 at 10:33:51PM +0200, Janek Warchoł wrote:
Hi David (and Graham too),
2011/9/13 David Kastrup d...@gnu.org:
Graham Percival gra...@percival-music.ca writes:
This tip should go in @ref{Suggestions for writing files}, and of
course in the Notation reference. If you
On Tue, Sep 20, 2011 at 10:08:26AM +0100, Phil Holmes wrote:
$(outdir)/general-scheme.o: $(outdir)/version.hh
$(outdir)/lily-guile.o: $(outdir)/version.hh
$(outdir)/lily-version.o: $(outdir)/version.hh
...
Graham: git grep version.hh gives:
lily/general-scheme.cc:#include version.hh
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):
http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/notation-appendices.itely#newcode909
LGTM
http://codereview.appspot.com/5030044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Next round. Getting past shift/reduce conflicts required adding
precendences to every terminal token that can start the last
non-optional argument.
But the resulting grammar is O(n): adding more elements to it is quite
straightforward.
http://codereview.appspot.com/5023044/
I'd be lying if I said I understood everything going on here, but I
think I get the gist.
I like moving this way!
I like the approach of simplifying things.
I like having optional predicates, and optional predicates with
defaults.
I will trust you that it is O(n) and that all the shift-reduce
On 11-09-20 02:38 PM, Graham Percival wrote:
On Mon, Sep 19, 2011 at 09:29:32PM -0600, Colin Campbell wrote:
For 22:00 MDT Wednesday September 21, and *far* too early for an Autumnal
equinox!
As an experiment, I have changed all (hopefully?) of these issues
from Patch-review to
Unfortunately, I cannot get my documentation to build. As was
suggested earlier, I nuked my build folder and redid everything from
the beginning (configure.sh, make all, touch, make doc). However, make
doc errors out with the following message:
Calculating line breaks... Segmentation fault
On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote:
/home/sasha/lilypond-git/build/out/lybook-db/snippet-names-5304161007275961614.ly
Does anyone have any idea what could be going on?
What's in the above file? It'll probably contain 5-10 other
filenames; one of those is the
LGTM. A quick test showed no problems in make doc. I didn't get
pictures in make website, but then I tried make website without the
patch applied, and I still didn't get pictures... evidently I don't have
my desktop set up to create the full website any more. So that's not a
reason to distrust
Hello,
This is really just an experiment to see if it worked as I wanted but
also if it is something that is useful?
I couldn't workout the git command to rewind it all the way back to
the 'merge branch release/unstable' for 2.15.11-1 so I used gitk and
found that commit and simply right-click
On Sep 21, 2011, at 6:45 AM, Peekay Ex wrote:
Hello,
This is really just an experiment to see if it worked as I wanted but
also if it is something that is useful?
I couldn't workout the git command to rewind it all the way back to
the 'merge branch release/unstable' for 2.15.11-1 so I
http://codereview.appspot.com/5081048/
This is for Tracker 1905
Added sentence to add --disable-optimising for ./autogen.sh or ../configure
when doing regression testing
--
--
James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
53 matches
Mail list logo
