- Original Message -
From: gra...@percival-music.ca
To: philehol...@googlemail.com; perciv...@gmail.com;
pkx1...@gmail.com; tdanielsmu...@googlemail.com; m...@philholmes.net
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Thursday, December 29, 2011 6:01 PM
I'm sorry to throw my hat in the ring so late, but I prefer something
explicit like non-negative-integer?
I mean, the name tells it all. What is this function doing? It's
checking whether something is a non-negative integer. If it's called
count? then somebody might need to look up the
On 2011/12/30 19:15:57, Graham Percival wrote:
I'm sorry to throw my hat in the ring so late, but I prefer something
explicit
like non-negative-integer?
I mean, the name tells it all. What is this function doing? It's
checking
whether something is a non-negative integer. If it's called
LGTM apart from one detail
http://codereview.appspot.com/5504092/diff/5001/scripts/auxiliar/lily-git.tcl
File scripts/auxiliar/lily-git.tcl (right):
http://codereview.appspot.com/5504092/diff/5001/scripts/auxiliar/lily-git.tcl#newcode295
scripts/auxiliar/lily-git.tcl:295: git push origin
LGTM, please push directly to staging.
oh -- was the bar numbers patch included in 2.15.23 ? if so, then
technically the version string should be that, not .24. Doesn't really
matter either way, though.
http://codereview.appspot.com/5501088/
___
On 2011/12/30 20:57:02, Graham Percival wrote:
Patchy will not question any
ridiculous git history that arises due to any kind of weird series of
commands
in git.
Maybe it would make sense if Patchy refused fast forwarding over a
history involving a merge _from_ staging. I think that merges
2011/12/23 Colin Campbell c...@shaw.ca:
For 22:00 MST Saturday The Night Before Christmas
Enhancement:
Issue 2109: do not tinker with the position of a pitched rest - R
5434061
could someone with push rights push this?
thanks,
p
___
On 2011/12/30 20:57:02, Graham Percival wrote:
LGTM apart from one detail
http://codereview.appspot.com/5504092/diff/5001/scripts/auxiliar/lily-git.tcl#newcode295
scripts/auxiliar/lily-git.tcl:295: git push origin HEAD:$pushHead
I'm still concerned about this type of automatic pushing. The
Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2
*** FAILED STEP ***
merge from staging
maybe somebody pushed a commit directly to master?
___
lilypond-devel mailing list
lilypond-devel@gnu.org
From: lilypond-devel-bounces+c_sorensen=byu@gnu.org [lilypond-devel-
bounces+c_sorensen=byu@gnu.org] on behalf of
lilypond.patchy.gra...@gmail.com
[lilypond.patchy.gra...@gmail.com]
Sent: Friday, December 30, 2011 5:21 PM
To:
On Sat, Dec 31, 2011 at 12:10:14AM +, carl.d.soren...@gmail.com wrote:
On 2011/12/30 20:57:02, Graham Percival wrote:
I'm still concerned about this type of automatic pushing. The revised
CG
material on branches
http://codereview.appspot.com/5484043/
makes a bit deal about always
On 11-12-30 12:22 AM, Graham Percival wrote:
On Fri, Dec 30, 2011 at 06:12:58AM +, Carl Sorensen wrote:
More information: When I ran the command by hand, I got this message:
carl@carl-lilydev:~/gub/target/darwin-ppc/build/cross/gcc-4.1.1$ make
tooldir='/usr/powerpc-apple-darwin7'
2011/12/31 Carl Sorensen c_soren...@byu.edu:
Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2
*** FAILED STEP ***
merge from staging
maybe somebody pushed a commit directly to master?
Francisco merged translation with staging, and apparently also
On Fri, Dec 30, 2011 at 01:12:30PM -, Phil Holmes wrote:
I'm not too fussed about that, but the second line should be indented by
two spaces to indicate that it's a continuation of the previous line
(i.e. not starting its own bar). I certainly wouldn't object to having
an explicit
On Thu, Dec 29, 2011 at 12:22:17PM +0100, Federico Bruni wrote:
I have a final draft (see files attached):
I'm quite happy with this version.
Given my time constraints, I am happy to trust you. I fully
expect that you'll get complaints whenever this makes its way into
the actual docs, but
On 12/30/11 6:40 PM, Francisco Vila paconet@gmail.com wrote:
2011/12/31 Carl Sorensen c_soren...@byu.edu:
Begin LilyPond compile, commit:
2f25894efd8ad242b233d5a1d07afcfa087ebab2
*** FAILED STEP ***
merge from staging
maybe somebody pushed a commit directly to master?
2011/12/31 Carl Sorensen c_soren...@byu.edu:
I suspect that we gave you commands that set it so your local staging
branch is tracking origin/master, rather than origin/staging. So *for
you*, staging is the same branch as origin/master. And I'm trying to
figure out how to diagnose this.
For
17 matches
Mail list logo
