- Original Message -
From: "Julien Rioux"
To: "Phil Holmes"
>
> It seems just not worth it. We _never_ want to check warnings as part of
> make doc. That's what regression tests are for.
>
> --
> Phil Holmes
I disagree, make -s doc is useful to identify warning messages that
need fixi
LGTM
http://codereview.appspot.com/5811043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Insofar as I don't fully follow this, LGTM. Have you tested by changing
an input file and confirming that the regtest checker picks it up?
http://codereview.appspot.com/5815043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.
LGTM
http://codereview.appspot.com/5812043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Wed, Mar 14, 2012 at 9:56 AM, Phil Holmes wrote:
> - Original Message - From: "Julien Rioux"
> To: "Phil Holmes"
>
>> >
>> > It seems just not worth it. We _never_ want to check warnings as part of
>> > make doc. That's what regression tests are for.
>> >
>> > --
>> > Phil Holmes
>>
>
On Tue, Mar 13, 2012 at 11:59 PM, Jean-Alexis Montignies
wrote:
> The documentation is usually well written but I find myself browsing many
> pages before finding something, even if it's something I know it exists and I
> already used.
>
> For instance for sizes. May be a graphic annotated with
Should this patch (and the other articulation patch) be put on
Rietveld or pushed directly?
Janek
On Wed, Mar 14, 2012 at 6:11 AM, Peter Chubb wrote:
>
> Mordents should be on-beat, not grace notes. And pralltrillers
> (half-shakes) are always either 4 alternating notes, or an inverted
> mordent
Julien Rioux wrote Wednesday, March 14, 2012 10:37 AM
On Wed, Mar 14, 2012 at 9:56 AM, Phil Holmes wrote:
- Original Message - From: "Julien Rioux"
To: "Phil Holmes"
The problem with this one is that Lilypond (like Sibelius...) only
provides
4 voices to allow notes to avoid co
Mordents should be on-beat, not grace notes. And pralltrillers
(half-shakes) are always either 4 alternating notes, or an inverted
mordent.
There is of course a general problem here in that the way ornaments
are realised has changed through the centuries. Even Bach and
Clementi disagree! I'm fo
Hello,
2012/3/14 Janek Warchoł :
> Should this patch (and the other articulation patch) be put on
> Rietveld or pushed directly?
> Janek
Does it break 'make'?
:P
I think this needs to be reviewed just like any other patch should be,
why *would* we just push this?
Also I saw that a new doc comm
On Wed, Mar 14, 2012 at 01:39:11PM +, James wrote:
> I think this needs to be reviewed just like any other patch should be,
> why *would* we just push this?
Well, I think this one is simple enough to push directly.
> http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commitdiff;h=d11dbf2777
Phil Holmes wrote Wednesday, March 14, 2012 12:00 PM
From: "Trevor Daniels"
To: "Julien Rioux" ; "Phil Holmes"
Cc: ;
Sent: Wednesday, March 14, 2012 11:41 AM
Subject: Re: Various updates to reduce make doc output (issue 5727055)
Julien Rioux wrote Wednesday, March 14, 2012 10:37 AM
- Original Message -
From: "Trevor Daniels"
To: "Phil Holmes"
Cc: "Lily-Devel List"
Sent: Wednesday, March 14, 2012 4:28 PM
Subject: Re: Various updates to reduce make doc output (issue 5727055)
Phil Holmes wrote Wednesday, March 14, 2012 12:00 PM
From: "Trevor Daniels"
To: "Ju
On 3/14/12 11:48 AM, "Phil Holmes" wrote:
>- Original Message -
>From: "Trevor Daniels"
>To: "Phil Holmes"
>Cc: "Lily-Devel List"
>Sent: Wednesday, March 14, 2012 4:28 PM
>Subject: Re: Various updates to reduce make doc output (issue 5727055)
>
>> Didn't you see what I wrote before?
I am not at home but Patchy complained just now.
-- Forwarded message --
From:
Date: 14 March 2012 18:34
Subject: Patchy email
Merged staging, now at: c6a925ecd742196979038804b02846faad7f2cc9
Success: ./autogen.sh --noconfigure
Success:
James writes:
> I am not at home but Patchy complained just now.
>
>
> -- Forwarded message --
> From:
> Date: 14 March 2012 18:34
> Subject: Patchy email
>
>
>
> Merged staging, now at: c6a925ecd742196979038804b02846faad7f2cc9
>
> Success: ./autogen.sh --n
On Wed, Mar 14, 2012 at 08:16:17PM +0100, David Kastrup wrote:
> commit 65c8ce914c62117fb61a21237f7dcf80ebb0cc6e
>
> Make Score an initial Timing alias to allow for context mods
>
>
> But then I am pretty certain that I actually ran "make info" on that one
> to make reasonably sure it did no
Graham Percival writes:
> On Wed, Mar 14, 2012 at 08:16:17PM +0100, David Kastrup wrote:
>> commit 65c8ce914c62117fb61a21237f7dcf80ebb0cc6e
>>
>> Make Score an initial Timing alias to allow for context mods
>>
>>
>> But then I am pretty certain that I actually ran "make info" on that one
>
On Wed, Mar 14, 2012 at 07:45:39PM +, Graham Percival wrote:
> info will check if you can generate the internals reference, i.e.
> with scm/documentation-generate.scm. It won't call the lilypond
> binary to produce any output at all.
No wait, I'm completely wrong. Sorry, I was thinking of ma
Has anybody else seen a huge slow-down in building fonts? They
used to whiz by on my screen in a minute or so, but now it takes
about 10 minutes, and more to the point, it involves a massive
amount of disk activity. My core2quad desktop couldn't play an
mp3 file while building fonts with -j3 !
M
- Original Message -
From: "David Kastrup"
To:
Sent: Wednesday, March 14, 2012 7:16 PM
Subject: Re: Failed make doc for Patchy
James writes:
I am not at home but Patchy complained just now.
Shall I run patchy and check the logfiles?
--
Phil Holmes
___
- Original Message -
From: "Graham Percival"
To:
Sent: Wednesday, March 14, 2012 7:59 PM
Subject: font regression build regression
Has anybody else seen a huge slow-down in building fonts? They
used to whiz by on my screen in a minute or so, but now it takes
about 10 minutes, and mo
For 20:00 MST Thursday March 15
Sent at Pi, or as near as I can make it on a 12-hour clock!
Enhancement:
Issue 2395:
Patch: Update roadmap, make and make doc info. - R5811043 Issue 2396:
Patch: Build: Better error handling from build scripts - R 5812043
Patch:Issue 2378:
Pat
"Phil Holmes" writes:
> - Original Message -
> From: "David Kastrup"
> To:
> Sent: Wednesday, March 14, 2012 7:16 PM
> Subject: Re: Failed make doc for Patchy
>
>
> James writes:
>
>> I am not at home but Patchy complained just now.
>
>
> Shall I run patchy and check the logfiles?
I
David Kastrup writes:
> "Phil Holmes" writes:
>
>> - Original Message -
>> From: "David Kastrup"
>> To:
>> Sent: Wednesday, March 14, 2012 7:16 PM
>> Subject: Re: Failed make doc for Patchy
>>
>>
>> James writes:
>>
>>> I am not at home but Patchy complained just now.
>>
>>
>> Shall
Hello,
On 14 March 2012 20:04, David Kastrup wrote:
> "Phil Holmes" writes:
>
>> - Original Message -
>> From: "David Kastrup"
>> To:
>> Sent: Wednesday, March 14, 2012 7:16 PM
>> Subject: Re: Failed make doc for Patchy
>>
>>
>> James writes:
>>
>>> I am not at home but Patchy complai
Hello,
On 14 March 2012 20:00, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
>
> To:
> Sent: Wednesday, March 14, 2012 7:59 PM
> Subject: font regression build regression
>
>
>
>> Has anybody else seen a huge slow-down in building fonts? They
>> used to whiz by on m
On Wed, Mar 14, 2012 at 08:00:44PM -, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
>
> To:
> Sent: Wednesday, March 14, 2012 7:59 PM
> Subject: font regression build regression
>
> >Has anybody else seen a huge slow-down in building fonts? They
> >used to whiz b
Reviewers: ,
Message:
Meh...not my best work, but it is a first step towards fixing this
problem. A full solution would do tuplet avoidance for scripts in the
same way they're done for slurs. Takers?
Description:
Turns off TupletBracket collision avoidance if Script avoids slur
Please review
James writes:
> Hello,
>
> On 14 March 2012 20:04, David Kastrup wrote:
>> "Phil Holmes" writes:
>>
>>> - Original Message -
>>> From: "David Kastrup"
>>> To:
>>> Sent: Wednesday, March 14, 2012 7:16 PM
>>> Subject: Re: Failed make doc for Patchy
>>>
>>>
>>> James writes:
>>>
I
David Kastrup writes:
> James writes:
>
>> Hello,
>>
>> On 14 March 2012 20:04, David Kastrup wrote:
>>> "Phil Holmes" writes:
>>>
- Original Message -
From: "David Kastrup"
To:
Sent: Wednesday, March 14, 2012 7:16 PM
Subject: Re: Failed make doc for Patchy
>
On 3/14/12 3:12 PM, "David Kastrup" wrote:
>
>I backed it out of staging. Try again.
Thanks, David. I guess if I figure out another fix, I'll have to try it
on lilydev to make sure it works there as well as here.
Carl
___
lilypond-devel mailing li
On Wed, Mar 14, 2012 at 4:39 PM, Graham Percival
wrote:
> On Wed, Mar 14, 2012 at 01:39:11PM +, James wrote:
>> I think this needs to be reviewed just like any other patch should be,
>> why *would* we just push this?
>
> Well, I think this one is simple enough to push directly.
Shall i do thi
Carl Sorensen writes:
> On 3/14/12 3:12 PM, "David Kastrup" wrote:
>
>>
>>I backed it out of staging. Try again.
>
> Thanks, David. I guess if I figure out another fix, I'll have to try it
> on lilydev to make sure it works there as well as here.
Afraid so. bash has no problem with echo '\v'
Janek Warchoł writes:
> On Wed, Mar 14, 2012 at 4:39 PM, Graham Percival
> wrote:
>> On Wed, Mar 14, 2012 at 01:39:11PM +, James wrote:
>>> I think this needs to be reviewed just like any other patch should be,
>>> why *would* we just push this?
>>
>> Well, I think this one is simple enough
On Wed, Mar 14, 2012 at 9:28 PM, Graham Percival
wrote:
> On Wed, Mar 14, 2012 at 08:00:44PM -, Phil Holmes wrote:
>> Is this with a straight "make" ? I ran it yesterday and didn't see
>> a slowdown, and I always check the time it takes.
>
> Yes, a straight make, after completely removing the
On Wed, Mar 14, 2012 at 10:27:52PM +0100, David Kastrup wrote:
> And the MacOSX /bin/sh is the first shell I heard of that does not grok
> echo -n.
...
> If this may not be true, `printf' is in general safer and easier
> to use than `echo' and `echo -n'.
This matches the open group spec
On Wed, Mar 14, 2012 at 10:25:40PM +0100, Janek Warchoł wrote:
> On Wed, Mar 14, 2012 at 4:39 PM, Graham Percival
> wrote:
> > Well, I think this one is simple enough to push directly.
>
> Shall i do this?
> And shall i not ask next time? ;)
If you are certain that it will cause no problems, and
On Wed, Mar 14, 2012 at 10:33 PM, David Kastrup wrote:
> Janek Warchoł writes:
>
>> On Wed, Mar 14, 2012 at 4:39 PM, Graham Percival
>> wrote:
>>> On Wed, Mar 14, 2012 at 01:39:11PM +, James wrote:
I think this needs to be reviewed just like any other patch should be,
why *would* w
On Wed, Mar 14, 2012 at 10:41 PM, Graham Percival
wrote:
> On Wed, Mar 14, 2012 at 10:25:40PM +0100, Janek Warchoł wrote:
>> On Wed, Mar 14, 2012 at 4:39 PM, Graham Percival
>> wrote:
>> > Well, I think this one is simple enough to push directly.
>>
>> Shall i do this?
>> And shall i not ask next
- Original Message -
From: "Graham Percival"
To: "Janek Warchoł"
Cc:
Sent: Wednesday, March 14, 2012 9:41 PM
Subject: Re: [patch] Fix mordents and pralltriller in articulate.ly
On Wed, Mar 14, 2012 at 10:25:40PM +0100, Janek Warchoł wrote:
On Wed, Mar 14, 2012 at 4:39 PM, Graham Pe
Graham Percival writes:
> On Wed, Mar 14, 2012 at 10:27:52PM +0100, David Kastrup wrote:
>> And the MacOSX /bin/sh is the first shell I heard of that does not grok
>> echo -n.
>
> ...
>> If this may not be true, `printf' is in general safer and easier
>> to use than `echo' and `echo -n'
Carl Sorensen wrote Wednesday, March 14, 2012 6:01 PM
On 3/14/12 11:48 AM, "Phil Holmes" wrote:
I've looked at midi2ly and it uses explicit instantiation of voices,
which
is what we normally advise. My understanding is that there are only 4
explicit voices - voiceFive does not exist, AFAIK.
looks basically good, but two minor points.
Make that three minor points: please CC to -devel, not -devl.
http://codereview.appspot.com/5829043/diff/1/ly/articulate.ly
File ly/articulate.ly (right):
http://codereview.appspot.com/5829043/diff/1/ly/articulate.ly#newcode482
ly/articulate.ly:482:
Reviewers: Graham Percival,
Message:
On 2012/03/15 00:49:01, Graham Percival wrote:
looks basically good, but two minor points.
One big issue -- the patch is reversed.
My bad in attempting to use git-cl.
I'm currently trying to work out how to delete this issue and create a
new one with the p
ok. In the future, when updating a patch, please point git-cl at your
existing issue (which was orginally 2404, but I'm going to close 2404
and 2405 and leave 2406).
At a rough analogy, the code.google issue number is a pointer, while the
rietveld is a piece of memory. We don't care how often y
On Thu, Mar 15, 2012 at 02:49:29PM +1100, Peter Chubb wrote:
> > "graham" == graham writes:
>
> graham> ok. In the future, when updating a patch, please point git-cl
> graham> at your existing issue (which was orginally 2404, but I'm
> graham> going to close 2404 and 2405 and leave 2406).
>
47 matches
Mail list logo
