On Thu, Jan 17, 2013 at 7:04 AM, Fan Ziye fanzi...@gmail.com wrote:
Dear Mike,
Thank you for your rapid reply! It’s very useful for me. I will continue
reading the CG and then go to the issue list.
http://lilypond.org/help-us.html is also worth reading for starting
points. Thanks very much
http://lilypond.org/doc/v2.17/Documentation/contributor/patch-handling
does not match with the CG source:
http://git.savannah.gnu.org/cgit/lilypond.git/tree/Documentation/contributor/issues.itexi#n824
The source code has four @subheadings, but none of them are visible
online. Additionally the
Whilst the procedure of marking an issue as fixed, with an additional
Fixed_mm_MM_ss label, is briefly mentioned at the end of the Issue
classification section in the Contributor's Guide:
http://lilypond.org/doc/v2.17/Documentation/contributor/issue-classification
it is slightly misleading,
On Sun, Jan 13, 2013 at 11:57 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
On Sun, Jan 13, 2013 at 11:09 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
On Sun, Jan 13, 2013 at 10:55 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
Resurrecting an old thread, because I had
On Sat, Jan 12, 2013 at 12:52 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
[thread moved from lilypond-user]
On Tue, Jan 8, 2013 at 5:59 PM, Adam Spiers
lilypond-u...@adamspiers.org wrote:
On Tue, Jan 8, 2013 at 5:41 PM, Eluze elu...@gmail.com wrote:
I've added an issue
On Sun, Jan 13, 2013 at 4:40 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
On Sat, Jan 12, 2013 at 12:52 PM, Adam Spiers lilypond-de...@adamspiers.org
wrote:
On Tue, Jan 8, 2013 at 5:59 PM, Adam Spiers lilypond-u...@adamspiers.org
wrote:
On Tue, Jan 8, 2013 at 5:41 PM, Eluze elu
On Sun, Jan 13, 2013 at 5:35 PM, James pkx1...@gmail.com wrote:
On 13 January 2013 17:27, Adam Spiers lilypond-de...@adamspiers.org wrote:
On Sun, Jan 13, 2013 at 4:40 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
On Sat, Jan 12, 2013 at 12:52 PM, Adam Spiers
lilypond-de
Resurrecting an old thread, because I had the same questions due to
the gaps in the contributor's guide ...
On Tue, May 15, 2012 at 3:51 PM, Łukasz Czerwiński milimet...@gmail.com wrote:
On 15 May 2012 16:35, Graham Percival gra...@percival-music.ca wrote:
On Tue, May 15, 2012 at 02:19:34PM
On Sun, Jan 13, 2013 at 10:55 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
Resurrecting an old thread, because I had the same questions due to
the gaps in the contributor's guide ...
*sigh*
Just discovered that I already asked this about 13 months ago:
http://thread.gmane.org
On Sun, Jan 13, 2013 at 11:09 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
On Sun, Jan 13, 2013 at 10:55 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
Resurrecting an old thread, because I had the same questions due to
the gaps in the contributor's guide ...
*sigh*
Just
On Sun, Jan 13, 2013 at 05:37:17PM +, Adam Spiers wrote:
On Sun, Jan 13, 2013 at 5:35 PM, James pkx1...@gmail.com wrote:
On 13 January 2013 17:27, Adam Spiers lilypond-de...@adamspiers.org wrote:
On Sun, Jan 13, 2013 at 4:40 PM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
On Sat
[thread moved from lilypond-user]
On Tue, Jan 8, 2013 at 5:59 PM, Adam Spiers
lilypond-u...@adamspiers.org wrote:
On Tue, Jan 8, 2013 at 5:41 PM, Eluze elu...@gmail.com wrote:
I've added an issue to the tracker:
https://code.google.com/p/lilypond/issues/detail?id=3091thanks=3091ts=1357666391
the scheme indentation.
This isn't a theoretical concern; Adam Spiers' first patch
required hours of extra work because of misunderstandings about
our desired indentation. This strikes me as a fairly juicy piece
of low-hanging fruit.
I would be happy to tackle this and *hope* to have a spare
This would be fun to code ;-)
http://lostinthecloudblog.com/2010/03/13/john-stump-composer-of-faeries-aire-and-death-waltz/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Wed, Nov 30, 2011 at 7:28 AM, Keith OHara k-ohara5...@oco.net wrote:
Adam Spiers lilypond-devel at adamspiers.org writes:
Fixed patch series is now in staging.
I am now seeing trouble with 'chord-name-exceptions.ly' and similar.
The slash missing in the markup for the \chordmode { c:7sus4
ARGH. My bad :-( Really sorry guys. It's very simple what happened,
and in fact you already know most of it:
- There was a long period of time in between the completion of the
review and pushing to staging, due to my misunderstanding of the
development process (which I will partially
On Tue, Nov 29, 2011 at 11:10 AM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
I'm building a fixed version
of the patch series as I type this, and will push as soon as I'm
convinced it's good, in order to minimise the risk of someone else
accidentally pushing the old series back
Pushed to staging as f955789f..0fa48c98
http://codereview.appspot.com/5343050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Pushed to staging as 1294535b
http://codereview.appspot.com/5342042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Pushed to staging as 46081ce4
http://codereview.appspot.com/5361042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: carl.d.sorensen_gmail.com,
Message:
Pushed to staging as f955789f
Description:
Usability improvements to {doc,cg}-section.sh and corresponding section
of CG.
- Now honor LILYPOND_GIT, LILYPOND_BUILD_DIR, and LILYPOND_TEMPDOCS
environment variables (all optional).
- Provide usage
On Sun, Nov 27, 2011 at 1:21 AM, carl.d.soren...@gmail.com wrote:
As far as I can see, this patch is approved for pushing, but hasn't been
pushed yet.
Are you going to push it, Adam, or should I push the one that I have?
I will do it now. I guess I have to rebase each branch off staging
and
Hi all,
Sorry - it only recently dawned on me that I'm probably responsible
for pushing my patches which I think have now already been reviewed
and approved.
I've read the CG and tried to understand the exact process, but as
previously noted on this list, the CG is not entirely complete and
On Tue, Nov 8, 2011 at 1:10 AM, Colin Campbell c...@shaw.ca wrote:
On 11-11-07 12:08 PM, adam.spi...@gmail.com wrote:
Please close this issue as it's now superceded by
http://codereview.appspot.com/5343050/ - thanks!
http://codereview.appspot.com/5320074/
Adam, you are the creator of the
On 2011/11/07 09:15:04, dak wrote:
Uh, yes? See line 1313: the argument list consists of an arbitrary
number of _pairs_.
Right - it's comparing (baseline, check) pairs. I didn't introduce the
modulo, I just made it explicit which is more legible than relying on
Python's interpretation of 0
On 2011/11/07 00:15:48, Graham Percival wrote:
On Sun, Nov 06, 2011 at 03:52:15PM +, mailto:adam.spi...@gmail.com
wrote:
I've done a corresponding patch for changes.tely but I don't have
permissions to upload it to this issue
that's because Janek uploaded the original issue. Could
Thanks Carl, I've made these changes, and I've also made a corresponding
patch for changes.tely, but I don't think I have permission to upload
new patch sets for either to this issue since it says Can't Edit at
the top-left - can you give me permission? (If not, this is yet another
reason
On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 11:56:42AM +, adam.spi...@gmail.com wrote:
Thanks Carl, I've made these changes, and I've also made a corresponding
patch for changes.tely, but I don't think I have permission to upload
On Mon, Nov 7, 2011 at 2:11 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 12:34:15PM +, Adam Spiers wrote:
On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
gra...@percival-music.ca wrote:
I doubt it. Just upload a new issue.
So then we would have *three
On Mon, Nov 7, 2011 at 2:13 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 12:44:42PM +, Carl Sorensen wrote:
I'll get the update posted today. For this patch, I'm serving as
adam's frog meister since last Thursday.
Adam is a very experienced developer, and he
The below error was caused by 'make -j2 doc' on a fresh build tree -
any ideas?
/home/adam/.GIT/3rd-party/lilypond/build/scripts/build/out/extract_texi_filenames
-I ./out-www -I /home/adam/music/software/lilypond.git/Documentation
-I /home/adam/music/software/lilypond.git/Documentation -o
Please close this issue as it's now superceded by
http://codereview.appspot.com/5343050/ - thanks!
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New version attached.
http://codereview.appspot.com/5361042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Mon, Nov 7, 2011 at 7:34 PM, Neil Puttock n.putt...@gmail.com wrote:
On 7 November 2011 19:32, Graham Percival gra...@percival-music.ca wrote:
Failing either of these, I guess we're into git bisect time, which
of course sucks for doc-building if you're not Phil or James. I
know that Phil
On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote:
I am not in favor of the tab-to-space change in
scm/chord-ignatzek-names.scm, since we don't yet have agreement on
removing tabs from .scm
On Mon, Nov 7, 2011 at 10:11 PM, David Kastrup d...@gnu.org wrote:
In this case, the damage is already done, so there seems little point in
investing the effort for trying to get back again.
Especially considering my first patch submission did *not* have
gratuitous whitespace changes, and I
I uploaded two more patches last night using git-cl, but due to my use
of google's 2-step authentication, both times I screwed up before
realising that I needed to create an application-specific password.
I created the issues manually, which may have resulted in labelling
issues. This also
I've done a corresponding patch for changes.tely but I don't have
permissions to upload it to this issue so you'll have to get it from
here:
https://github.com/aspiers/lilypond/commit/3f02826bf5e8854f7da06b2f822d3a65cf63e487
http://codereview.appspot.com/4981052/
I just got a bunch of rejections like the one below. I guess they
were because when I click 'Publish+Mail Draft Comments' in Rietveld,
it sends the mail to lilypond-devel using my google account e-mail
address, which is not the address I am subscribed to this list with.
Unfortunately the
On Sun, Nov 6, 2011 at 11:16 PM, David Kastrup d...@gnu.org wrote:
Adam Spiers lilypond-de...@adamspiers.org writes:
I just got a bunch of rejections like the one below. I guess they
were because when I click 'Publish+Mail Draft Comments' in Rietveld,
it sends the mail to lilypond-devel using
Given that LilyPond is part of the GNU project, presumably all contributors
have to sign a form assigning copyright of all contributions to the FSF?
http://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html
I couldn't find any reference to this in the CG though.
On Thu, Nov 03, 2011 at 06:28:55PM +, Carl Sorensen wrote:
On 11/3/11 10:50 AM, Adam Spiers lilypond-de...@adamspiers.org wrote:
I originally avoided any pure-whitespace commits, but at the
review of my initial patches, I was told to replace tabs with spaces
in the files I was modifying
On Fri, Nov 04, 2011 at 11:55:42AM +, Carl Sorensen wrote:
On 11/4/11 5:35 AM, Adam Spiers lilypond-de...@adamspiers.org wrote:
On Thu, Nov 03, 2011 at 06:28:55PM +, Carl Sorensen wrote:
I can't find the suggestion to replace tabs with spaces in this review
string, so I can't comment
On Fri, Nov 04, 2011 at 01:14:00PM +, Graham Percival wrote:
On Fri, Nov 04, 2011 at 12:10:20PM +, Adam Spiers wrote:
Sure, understood - but I still don't see why each commit within a
single issue couldn't be checked accumulatively, rather than just
applying all three together
What should I provide as the Tree status and ViewVC URLs to git cl
config? The CG says If you do not understand any question, just
answer with a newline (CR) but presumably if I leave these blank then
I'll miss out on some functionality?
$ git cl config
Rietveld server (host[:port])
On Fri, Nov 4, 2011 at 3:05 PM, Graham Percival
gra...@percival-music.ca wrote:
On Fri, Nov 04, 2011 at 02:56:19PM +, Adam Spiers wrote:
What should I provide as the Tree status and ViewVC URLs to git cl
config? The CG says If you do not understand any question, just
answer with a newline
On Fri, Nov 4, 2011 at 3:13 PM, Graham Percival
gra...@percival-music.ca wrote:
On Fri, Nov 04, 2011 at 02:52:32PM +, Adam Spiers wrote:
Hey, give yourselves some credit - at least you're not using CVS;
*that's* what I would label as dark ages :-) git is still relatively
new for many many
On Fri, Nov 4, 2011 at 3:18 PM, Graham Percival
gra...@percival-music.ca wrote:
On Fri, Nov 04, 2011 at 03:08:40PM +, Adam Spiers wrote:
OK, thanks. Next question - any ideas what's going on here?
$ git cl upload origin/dev/staging
scripts/build/output-distance.py | 65
On Fri, Nov 04, 2011 at 03:41:55PM +, Graham Percival wrote:
On Fri, Nov 04, 2011 at 03:35:53PM +, Adam Spiers wrote:
On Fri, Nov 4, 2011 at 3:18 PM, Graham Percival
gra...@percival-music.ca wrote:
On Fri, Nov 04, 2011 at 03:08:40PM +, Adam Spiers wrote:
OK, thanks. Next
On Fri, Aug 5, 2011 at 11:39 PM, Graham Percival
gra...@percival-music.ca wrote:
Doesn't look too bad. If there was no (hidden) mechanism in the
build system to do this, I'd be happy to adopt the script.
I only just found this thread, after a significant effort trying to
solve the same
On Fri, Nov 4, 2011 at 4:53 PM, Phil Holmes m...@philholmes.net wrote:
We decided that the make syntax served equally well, so I dropped it.
I thought the make syntax didn't build the included images?
___
lilypond-devel mailing list
On Thu, Nov 03, 2011 at 11:13:28AM +, Peekay Ex wrote:
Adam,
On Wed, Nov 2, 2011 at 5:58 PM, adam.spi...@gmail.com wrote:
I think I am now finished. The new patch series is available at
https://github.com/aspiers/lilypond/commits/jazz
IMHO there are now too many patches in
On Thu, Nov 03, 2011 at 04:28:53PM +, Graham Percival wrote:
On Thu, Nov 03, 2011 at 04:00:41PM +, Adam Spiers wrote:
On Thu, Nov 03, 2011 at 11:13:28AM +, Peekay Ex wrote:
One patch per tracker item?
I can do that if noone objects to tracker items for patches as trivial
On Thu, Nov 3, 2011 at 4:28 PM, Graham Percival
gra...@percival-music.ca wrote:
We're not comfortable with git. Other than 4 or 5 people, each
person who's started pushing to dev/staging has required between 3
and 10 emails to get them able to reliably push to a branch
without screwing stuff
On Wed, Nov 2, 2011 at 8:29 AM, Graham Percival
gra...@percival-music.ca wrote:
On Tue, Nov 01, 2011 at 05:34:01PM +, Adam Spiers wrote:
I just invented a Javascript hack which I'm sharing in case there
isn't a better way; whilst viewing out/test-results/index.html, type
this into your
On Wed, Nov 2, 2011 at 5:25 AM, Graham Percival
gra...@percival-music.ca wrote:
On Wed, Nov 02, 2011 at 02:14:13AM +, Carl Sorensen wrote:
On 11/1/11 5:44 PM, Adam Spiers lilypond-de...@adamspiers.org wrote:
`make doc' works, but takes too long to be of practical use except as
a final
I think I am now finished. The new patch series is available at
https://github.com/aspiers/lilypond/commits/jazz
IMHO there are now too many patches in the series to combine into a
single commit for review. To do so would lose a lot of clarity in the
git history. So I am not sure how
On Thu, Nov 3, 2011 at 12:38 AM, Adam Spiers
lilypond-de...@adamspiers.org wrote:
On Wed, Nov 2, 2011 at 1:02 PM, Graham Percival
gra...@percival-music.ca wrote:
On Wed, Nov 02, 2011 at 12:03:08PM +, Adam Spiers wrote:
I might have time to take a bash at adding Javascript buttons
I noticed that we already have \hideNotes and \unHideNotes, but that
is rather clumsy when you only want to hide a single note. So I wrote
a patch to add \hideNote, and as a newbie to Lilypond development I
wanted to check that this was a sensible idea. The patch is here,
although I haven't
On Tue, Nov 1, 2011 at 3:15 PM, Peekay Ex pkx1...@gmail.com wrote:
On Tue, Nov 1, 2011 at 2:28 PM, Adam Spiers lilypond-de...@adamspiers.org
wrote:
Thanks James. I'm a little confused regarding snippets: I was aware
that files in Documentation/snippets are autogenerated from files
I have finally figured out how to reproduce these regressions,
and am working on a fix.
http://codereview.appspot.com/4981052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I'm starting to get the hang of regression tests, but my
build/out/test-results/index.html shows a very large number of entries
referring to *.profile files. I assume this is something to do with
performance, but for once the Contributor's Guide isn't much help;
is not in .gitignore.
Here is a patch which fixes all the issues in this email:
From 3bb0571c8322d6da8e546955966952427f2ee6c2 Mon Sep 17 00:00:00 2001
From: Adam Spiers lilypond-fr...@adamspiers.org
Date: Tue, 1 Nov 2011 23:35:00 +
Subject: [PATCH] Fix several issues regarding scripts/auxiliar/doc
2011/10/31 Carl Sorensen c_soren...@byu.edu:
On 10/30/11 6:26 PM, Adam Spiers lilypond-de...@adamspiers.org wrote:
OK, I've gotten stuck whilst running regression tests against my
feature branch. 'make test-redo' yields the following error, but I
don't see how any of my patches could affect MIDI
Hi Janek,
Just a quick note to say that I've started work on this again.
I'll be in touch again when I've made some progress.
2011/9/10 Janek Warchoł janek.lilyp...@gmail.com:
Hi Adam,
2011/9/10 Adam Spiers lilypond-de...@adamspiers.org:
Sorry Janek, I did receive the email but I've been
Sorry Janek, I did receive the email but I've been away travelling for
3 months and only just got back. I would be glad to work with you on
getting these patches finalised and submitted, although please bear
with me over the next few days as I have some other pressing issues to
attend to first.
66 matches
Mail list logo
