Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-08-02 Thread Janek WarchoĊ‚
2014-08-01 12:04 GMT+02:00 : > The user interface is simply an optional argument (default 1) in the > font-spec-list. [...] Ah, so it's up to the user to provide scaling factors. I thought that there is some code measuring height of the x letter and scaling the font accordingly :) Ok, now i see

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-08-01 Thread perpeduumimmobile
On 2014/07/31 20:40:40, janek wrote: from description: > Furthermore, it implements per-font scaling (e.g., to match the x-heights > of different fonts used in the document). This is very nice! Please pardon a stupid question, but i failed to find which place in the code is responsible fo

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-31 Thread janek . lilypond
from description: Furthermore, it implements per-font scaling (e.g., to match the x-heights of different fonts used in the document). This is very nice! Please pardon a stupid question, but i failed to find which place in the code is responsible for this. Could you give me a pointer? No a

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-31 Thread janek . lilypond
https://codereview.appspot.com/108700043/diff/80001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/80001/scm/font.scm#newcode285 scm/font.scm:285: (let ((n (make-font-tree-node 'font-encoding 'fetaMusic))) On 2014/07/24 20:55:54, Mark Polesky wrote: I'd fi

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-31 Thread markpolesky
https://codereview.appspot.com/108700043/diff/80001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/80001/scm/font.scm#newcode241 scm/font.scm:241: "Construct a font tree consisting of the default Feta music font and I think an explanation and clear example

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-25 Thread Alexander Kobel
On 07/25/2014 05:55 AM, markpole...@gmail.com wrote: https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly Mark, thanks for the comments. James, give this at least one more cycle, please. I'll incorporate the changes as soon as I can find the time, an

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-24 Thread markpolesky
https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly File input/regression/font-expert-selection.ly (right): https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode33 input/regression/font-expert-selection.ly:

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-17 Thread perpeduumimmobile
On 2014/07/17 09:13:54, dak wrote: mailto:perpeduumimmob...@gmail.com writes: > That leaves me with only one more question: Is there any reason to use > Texinfo markup in those docstrings, given that all more-or-less obvious > ways of accessing it do not seem to use it? Or should I rather

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-17 Thread David Kastrup
perpeduumimmob...@gmail.com writes: > That leaves me with only one more question: Is there any reason to use > Texinfo markup in those docstrings, given that all more-or-less obvious > ways of accessing it do not seem to use it? Or should I rather give a > well-formatted uncluttered raw text descr

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-17 Thread perpeduumimmobile
On 2014/07/17 08:28:36, dak wrote: mailto:perpeduumimmob...@gmail.com writes: > Two follow-up questions: > 1.) Is there a way to list all Lily scheme functions and/or all their > docstrings? If you know what function or variable you are looking for, > the docstrings are obviously great.

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-17 Thread David Kastrup
perpeduumimmob...@gmail.com writes: > Two follow-up questions: > 1.) Is there a way to list all Lily scheme functions and/or all their > docstrings? If you know what function or variable you are looking for, > the docstrings are obviously great. But if I look for something which > matches your f

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-17 Thread perpeduumimmobile
On 2014/07/17 06:36:20, dak wrote: mailto:perpeduumimmob...@gmail.com writes: > On 2014/07/16 17:13:27, J_lowe wrote: >> > On 2014/07/16 09:20:45, dak wrote: >> >> There is no doc string here or other documentation. >> > >> > I wrote one now; didn't do it because I started with a copy of >> >>

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-16 Thread David Kastrup
perpeduumimmob...@gmail.com writes: > On 2014/07/16 17:13:27, J_lowe wrote: >> > On 2014/07/16 09:20:45, dak wrote: >> >> There is no doc string here or other documentation. >> > >> > I wrote one now; didn't do it because I started with a copy of >> >> > It is not built into the docs, right? > >>

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-16 Thread perpeduumimmobile
On 2014/07/16 17:13:27, J_lowe wrote: > On 2014/07/16 09:20:45, dak wrote: >> There is no doc string here or other documentation. > > I wrote one now; didn't do it because I started with a copy of > make-pango-font-tree, and it does not have one as well (I know, not the > best reason). > Is the

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-16 Thread James
On 16/07/14 14:04, perpeduumimmob...@gmail.com wrote: https://codereview.appspot.com/108700043/diff/20001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/20001/scm/font.scm#newcode240 scm/font.scm:240: (define-public (make-expert-font-tree fonts-alist fa

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-16 Thread perpeduumimmobile
https://codereview.appspot.com/108700043/diff/20001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/20001/scm/font.scm#newcode240 scm/font.scm:240: (define-public (make-expert-font-tree fonts-alist factor) On 2014/07/16 09:20:45, dak wrote: There is no doc

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-16 Thread dak
https://codereview.appspot.com/108700043/diff/20001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/20001/scm/font.scm#newcode240 scm/font.scm:240: (define-public (make-expert-font-tree fonts-alist factor) There is no doc string here or other documentation.

Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-15 Thread pkx166h
Fails make check --snip-- regression/font-expert-selection.ly --snip-- Processing `/tmp/build-lilypond-autobuild/out/lybook-testdb/73/lily-16d682d4.ly' Parsing... Renaming input to: `/tmp/lilypond-autobuild/input/regression/font-expert-selection.ly' /tmp/lilypond-autobuild/input/regression/fon