Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-18 Thread John Mandereau
AFAICT after a few hours of fiddling this issue is fixed, let's wait for release to verify it (and not hopefully reopen it :-P). Let me know how is current master. I've built and have checked both online and offline targets, both split and big-page manuals, both docs in English and Italian (so I'

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread Graham Percival
On Mon, Oct 18, 2010 at 01:21:09AM +0200, John Mandereau wrote: > Il giorno dom, 17/10/2010 alle 23.45 +0100, Graham Percival ha scritto: > > If the patch breaks offline docs, then something is /really/ > > messed up. Did my 819365f311a832c5cc57f086016069efdbee91fa break > > the offline docs? > >

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread John Mandereau
Il giorno dom, 17/10/2010 alle 23.45 +0100, Graham Percival ha scritto: > Eh? The patch only does stuff for the online target. That's what > line 349 is supposed to do: > if target == 'online': Indeed, I'm really puzzled. I'm sure I looked at offline docs with your second patch, but

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread Graham Percival
On Sun, Oct 17, 2010 at 10:40:05PM +, john.mander...@gmail.com wrote: > On 2010/10/17 21:14:11, Graham Percival wrote: > >Along the way, I've found that firefox is profoundly unhappy with > "..//..". > >That may have prompted me to add the extra ../ to translations > initially. Or > >maybe the

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread john . mandereau
On 2010/10/17 21:14:11, Graham Percival wrote: Here's another version. Note that the "extra depth" thing is now added to the *non*-translated version. I have no clue why. I've spent 3 hours bashing against the build process, and that's enough for me. CG 5.3 Debugging website and docs

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread percival . music . ca
Here's another version. Note that the "extra depth" thing is now added to the *non*-translated version. I have no clue why. I've spent 3 hours bashing against the build process, and that's enough for me. CG 5.3 Debugging website and docs locally has what I know about trying to solve this stuf

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread John Mandereau
Il giorno dom, 17/10/2010 alle 20.38 +0100, Graham Percival ha scritto: > The extra "../" is present in the docs, in the output of > postprocess.html, if no attempt is made to rewrite the "return to doc > index". I don't know if these exist in the docs previously (I suspect > this is the case, tho

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread Graham Percival
On Sun, Oct 17, 2010 at 8:22 PM, John Mandereau wrote: > Il giorno dom, 17/10/2010 alle 18.28 +, percival.music...@gmail.com > ha scritto: >> Are you sure about that?  After disabling the >> (make the "return to doc index" work) stuff > > Do you mean your patch? I mean, change line 349: -

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread John Mandereau
Il giorno dom, 17/10/2010 alle 21.22 +0200, John Mandereau ha scritto: > BTW it should also be > "manuals.it.html", not "development...". I'm commenting this in on > Rietveld. Please ignore this, I just didn't know what I wrote at that moment. Sorry :-P John signature.asc Description: This i

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread John Mandereau
Il giorno dom, 17/10/2010 alle 18.28 +, percival.music...@gmail.com ha scritto: > On 2010/10/17 16:52:03, John Mandereau wrote: > > python/auxiliar/postprocess_html.py:357: extra_depth = '../' > > '../' is is not needed for translations, as output web pages are at > the same > > depth as the pa

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread percival . music . ca
On 2010/10/17 16:52:03, John Mandereau wrote: python/auxiliar/postprocess_html.py:357: extra_depth = '../' '../' is is not needed for translations, as output web pages are at the same depth as the pages in English, and may cause errors in case server configuration doesn't redirect /.. to /. I

Re: Build: another hack for translations (fix 1323). (issue2520041)

2010-10-17 Thread john . mandereau
Besides the niptick, it looks good to me. I tested by building both offline and online targets. http://codereview.appspot.com/2520041/diff/1/python/auxiliar/postprocess_html.py File python/auxiliar/postprocess_html.py (right): http://codereview.appspot.com/2520041/diff/1/python/auxiliar/postpr

Build: another hack for translations (fix 1323). (issue2520041)

2010-10-14 Thread percival . music . ca
Reviewers: , Description: Build: another hack for translations (fix 1323). Please review this at http://codereview.appspot.com/2520041/ Affected files: M python/auxiliar/postprocess_html.py Index: python/auxiliar/postprocess_html.py diff --git a/python/auxiliar/postprocess_html.py b/pytho