http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1555
Documentation/notation/rhythms.itely:1555: shown durations
Draft 5 - removed all translation docs with this snippet in it too (for
when it is removed from LSR).
have at it.
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
LGTM
Although I'm not sure about editing the other language files. Best wait
for Francisco to comment.
http://codereview.appspot.com/4837050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sat, Aug 06, 2011 at 11:17:24AM +0100, Phil Holmes wrote:
- Original Message - From: Graham Percival
On Thu, Aug 04, 2011 at 03:05:42PM +0100, Phil Holmes wrote:
I don't run LSR update: I'm an authoriser, but that's all.
Yes, it's almost as though there's no amour for LSR.
Not
On 2011/08/05 10:07:46, Janek Warchol wrote:
2011/8/4 reinhold.kainho...@gmail.com:
I would definitely mention here that the automatic beaming
and the beam subdivisions are automatically derived from nbsp;the
\compound
meter.
Are the subdivisions really used?
...
I have removed the
New Draft.
Thanks
James
http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely#newcode1554
overall LGTM
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1643
Documentation/notation/rhythms.itely:1643:
Almost there - a couple of comments ...
http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):
http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely#newcode2114
New Draft.
Before I push this (and as Neil has just done an LSR update) do I still
need to run makelsr.py before applying this patch once it has been
approved?
I have removed one snippet from both dirs (snippets/new and snippets).
I'll get someone to remove the snippet from the LSR too.
On 7 August 2011 21:33, pkx1...@gmail.com wrote:
Before I push this (and as Neil has just done an LSR update) do I still
need to run makelsr.py before applying this patch once it has been
approved?
Nope.
I have removed one snippet from both dirs (snippets/new and snippets).
Don't forget
LGTM
http://codereview.appspot.com/4837050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
...@gmail.com
Sent: Saturday, August 06, 2011 12:13 AM
Subject: no love for LSR (was: Doc: Added \compoundMeter function to NR
(issue4837050))
On Thu, Aug 04, 2011 at 03:05:42PM +0100, Phil Holmes wrote:
I don't run LSR update: I'm an authoriser, but that's all.
Yes, it's almost as though there's
2011/8/4 reinhold.kainho...@gmail.com:
I would definitely mention here that the automatic beaming
and the beam subdivisions are automatically derived from the \compound
meter.
Are the subdivisions really used? When i compile
{ \compoundMeter #'((2 3 4)) \repeat unfold 20 c'16 }
I get 8
http://codereview.appspot.com/4837050/diff/9001/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):
http://codereview.appspot.com/4837050/diff/9001/Documentation/music-glossary.tely#newcode2114
Documentation/music-glossary.tely:2114: \compoundMeter #'((3 8) (2 8)
On Thu, Aug 04, 2011 at 02:46:25PM +0100, Trevor Daniels wrote:
You could just delete the snippets from the LSR, and ask Phil to run
LSR update at the same time as your doc change was committed, but
doing it in sync is going to be tricky. Better to edit
snippets-list in the same commit as
On Thu, Aug 04, 2011 at 03:05:42PM +0100, Phil Holmes wrote:
I don't run LSR update: I'm an authoriser, but that's all.
Yes, it's almost as though there's no amour for LSR.
Cheers,
- Graham
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Hi James
Needs a bit more work along the lines suggested by Janek. This is quite
a tricky concept, and a little more explanation would help here
(although maybe not quite as verbose as Janek's helpful explanation -
leave out the musical bits :)
Also, you can't just delete the unwanted snippets
http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1638
Documentation/notation/rhythms.itely:1638: \compoundMeter
James, you wrote Thursday, August 04, 2011 11:55 AM
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of tdanielsmu...@googlemail.com
)Sent: 04 August 2011 09:32
)Also, you can't just delete the unwanted snippets from the git
tree -
)they'll reappear at the next LSR
- Original Message -
From: Trevor Daniels t.dani...@treda.co.uk
To: James Lowe james.l...@datacore.com; tdanielsmu...@googlemail.com
Cc: Lily-Devel List lilypond-devel@gnu.org
Sent: Thursday, August 04, 2011 2:46 PM
Subject: Re: Doc: Added \compoundMeter function to NR (issue4837050
Second Draft. Hopefully I've covered everything without being too
verbose or talking through the code.
I also found some old 'scheme' code in the glossary and so updated that
with the new \compoundMeter function instead also removed another
reference to the snippet found in world.itely.
I think the \compoundMeter description should be more detailed.
http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1555
Reviewers: ,
Message:
Patch ready for review.
But also see
http://code.google.com/p/lilypond/issues/detail?id=1776#c6
as there are still some points I am not clear on on this function that
may need more doc additions.
Description:
Doc: Added \compoundMeter function to NR
Tracker 1776.
23 matches
Mail list logo
