Re: [Line6linux-devel] Impulse response test

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 9:48 PM, Markus Grabner wrote: > Am Donnerstag, 29. November 2012, 21:18:11 schrieb Stefan Hajnoczi: >> The Kconfig entry notes that doing the impulse response test inside >> the kernel avoids buffering/latency issues but it's not clear to me >> that this code really needs

Re: [Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

2012-11-29 Thread Dan Carpenter
On Thu, Nov 29, 2012 at 09:03:38PM +0100, Laurent Navet [Mali] wrote: > From: "Laurent Navet [Mali]" > > staging: line6: pcm.c > call to obsolete simple_strtoul() function is replaced > by kstrtoint() in pcm_set_impulse_period(). > Also check the return code. > > Signed-off-b

Re: [Line6linux-devel] line6 out of staging

2012-11-29 Thread Markus Grabner
Am Donnerstag, 29. November 2012, 21:09:35 schrieb Stefan Hajnoczi: > On Thu, Nov 29, 2012 at 8:55 PM, Markus Grabner wrote: > > Am Donnerstag, 22. November 2012, 21:05:31 schrieb Stefan Hajnoczi: > >> On Thu, Nov 22, 2012 at 10:49 AM, Stefan Hajnoczi > > > > wrote: > >> If you'd like to help c

Re: [Line6linux-devel] Impulse response test

2012-11-29 Thread Markus Grabner
Am Donnerstag, 29. November 2012, 21:18:11 schrieb Stefan Hajnoczi: > I noticed the qtbased svn branch has a userspace signal generator > tool. Does this mean we can drop the impulse response test in the > driver? No, the signal generator is not related to the impulse response feature. > The Kcon

[Line6linux-devel] Impulse response test

2012-11-29 Thread Stefan Hajnoczi
I noticed the qtbased svn branch has a userspace signal generator tool. Does this mean we can drop the impulse response test in the driver? The Kconfig entry notes that doing the impulse response test inside the kernel avoids buffering/latency issues but it's not clear to me that this code really

Re: [Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 9:03 PM, Laurent Navet [Mali] wrote: > From: "Laurent Navet [Mali]" > > staging: line6: pcm.c > call to obsolete simple_strtoul() function is replaced > by kstrtoint() in pcm_set_impulse_period(). > Also check the return code. > > Signed-off-by: Lau

Re: [Line6linux-devel] line6 out of staging

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 8:55 PM, Markus Grabner wrote: > Am Donnerstag, 22. November 2012, 21:05:31 schrieb Stefan Hajnoczi: >> On Thu, Nov 22, 2012 at 10:49 AM, Stefan Hajnoczi > wrote: >> If you'd like to help clean up the staging driver, I suggest starting >> with my line6-drop-sysfs-attrs bra

[Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

2012-11-29 Thread Laurent Navet [Mali]
From: "Laurent Navet [Mali]" staging: line6: pcm.c call to obsolete simple_strtoul() function is replaced by kstrtoint() in pcm_set_impulse_period(). Also check the return code. Signed-off-by: Laurent Navet [Mali] --- drivers/staging/line6/pcm.c |8 +++- 1 file

Re: [Line6linux-devel] line6 out of staging

2012-11-29 Thread Markus Grabner
Am Donnerstag, 22. November 2012, 21:05:31 schrieb Stefan Hajnoczi: > On Thu, Nov 22, 2012 at 10:49 AM, Stefan Hajnoczi wrote: > If you'd like to help clean up the staging driver, I suggest starting > with my line6-drop-sysfs-attrs branch (saves you from applying the > patch emails yourself): > h

Re: [Line6linux-devel] Opened a support ticket with Line6

2012-11-29 Thread L. Alberto Giménez
El 28/11/2012 21:33, L. Alberto Giménez escribió: > Hi, > > I've just opened a support request with Line6. I'm trying to convince the to > help us > to support their hardware on Linux. Well, this is sad. After adding a message this morning to clarify the 'reverse engineering stuff' as asked by M

Re: [Line6linux-devel] line6 out of staging

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 9:40 AM, "L. Alberto Giménez" wrote: > El 29/11/2012 7:54, Stefan Hajnoczi escribió: > >> >> Is the device plugged into a USB 2.0 port? >> > > It's connected to an external hub. I don't know if that's the reason of > lsusb not showing endpoints, but when I connect the devic

Re: [Line6linux-devel] line6 out of staging

2012-11-29 Thread L. Alberto Giménez
El 29/11/2012 7:54, Stefan Hajnoczi escribió: > > Is the device plugged into a USB 2.0 port? > It's connected to an external hub. I don't know if that's the reason of lsusb not showing endpoints, but when I connect the device I get this message: [ 333.697431] usb 1-2.4: new full-speed USB devi

Re: [Line6linux-devel] Opened a support ticket with Line6

2012-11-29 Thread L. Alberto Giménez
El 28/11/2012 23:30, Markus Grabner escribió: > One thing he was curious about is how I found out the protocol by which host > and device communicate with each other. He told me that it's ok for them if we > use USB analyzing tools to observe the traffic (which is what I did), but > reverse enginee