As we would add more ways to list and manage the subvols
and snapshots, its better if we have struct root_info
defined in the header file.
Signed-off-by: Anand Jain
---
btrfs-list.c | 47 ---
btrfs-list.h | 47 ++
We need a function which can get the root_info of a given
subvol. This is in preparation to add support for the show
sub-cli.
Signed-off-by: Anand Jain
---
btrfs-list.c | 38 ++
btrfs-list.h | 1 +
2 files changed, 39 insertions(+)
diff --git a/btrfs-list.c
This patch adds the flags row which as of now will show if the
subvol/snapshot is readonly.
Signed-off-by: Anand Jain
---
cmds-subvolume.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/cmds-subvolume.c b/cmds-subvolume.c
index 5e51a26..c14e878 100644
--- a/cmds-subvolume.c
+++ b/cmds-
Signed-off-by: Anand Jain
---
btrfs-list.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/btrfs-list.c b/btrfs-list.c
index 69ee3e7..eadfba4 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -1503,19 +1503,24 @@ int btrfs_list_subvols_print(int fd, struct
btrfs_lis
Currently you can print subvol in a list or table format.
This patch will provide a way to extend this to other formats
like the upcoming raw format.
Signed-off-by: Anand Jain
---
btrfs-list.c | 26 +++---
btrfs-list.h | 3 +++
cmds-subvolume.c | 23 +
get_subvol_name can be used other than the just with in cmds-send.c
so this patch will make it possible with out changing the original
intentions.
Signed-off-by: Anand Jain
---
cmds-send.c | 12 ++--
commands.h | 1 +
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/cmds-
Signed-off-by: Anand Jain
---
cmds-subvolume.c | 57 +++-
1 file changed, 40 insertions(+), 17 deletions(-)
diff --git a/cmds-subvolume.c b/cmds-subvolume.c
index 9f1d2a4..5e51a26 100644
--- a/cmds-subvolume.c
+++ b/cmds-subvolume.c
@@ -303,9 +
From: Wang Shilong
btrfs snapshot list command will stop by the deleted subvolumes.
The problem may happen by two ways:
1. a subvolume deletion is not commited, that is ROOT_BACKREF has been deleted,
but ROOT_ITEM still exists. The command will fail to fill the path of
the deleted subvolum
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Signed-off-by: Anand Jain
---
btrfs-list.c | 25 +++--
btrfs-list.h | 3 +-
cmds-subvolume.c | 155 +--
man/btrfs
A useful function need to define it in a header file.
Signed-off-by: Anand Jain
---
commands.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/commands.h b/commands.h
index 61d74d7..1dd6180 100644
--- a/commands.h
+++ b/commands.h
@@ -105,3 +105,6 @@ int cmd_replace(int argc, char **argv)
Signed-off-by: Anand Jain
---
btrfs-list.c | 6 ++
btrfs-list.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/btrfs-list.c b/btrfs-list.c
index 0e4b3eb..93d167e 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -1143,6 +1143,11 @@ static int filter_topid_equal(struct root_info *ri, u64
Signed-off-by: Anand Jain
---
btrfs-list.c | 34 --
btrfs-list.h | 1 +
cmds-subvolume.c | 6 +-
3 files changed, 34 insertions(+), 7 deletions(-)
diff --git a/btrfs-list.c b/btrfs-list.c
index ab42a33..03a0d02 100644
--- a/btrfs-list.c
+++ b/btrfs-l
To improve the code reuse its better to have btrfs_list_subvols
just return list of subvols witout printing
Signed-off-by: Anand Jain
---
btrfs-list.c | 28 ++--
btrfs-list.h | 2 +-
cmds-subvolume.c | 4 ++--
3 files changed, 21 insertions(+), 13 deletions(-)
David,
Please find this v6 show patch-set for your integration-20130130 branch.
v5->v6:
added
[PATCH 13/13] Btrfs-progs: add subvol flags to print
Anand Jain (12):
Btrfs-progs: move printing subvol list outside of btrfs_list_subvols
Btrfs-progs: add parent uuid for snapshots
On fri, 01 Feb 2013 12:08:25 +0800, Miao Xie wrote:
> Onfri, 1 Feb 2013 10:53:30 +0800, Liu Bo wrote:
>> On Thu, Jan 31, 2013 at 05:39:03PM +0800, Miao Xie wrote:
>>> This idea is from ext4. By this patch, we can make the dio write parallel,
>>> and improve the performance.
>>
>> Interesti
On Thu, 31 Jan 2013 11:40:41 -0500, Josef Bacik wrote:
> On Thu, Jan 31, 2013 at 02:23:19AM -0700, Miao Xie wrote:
>> Currently, we can do unlocked dio reads, but the following race
>> is possible:
>>
>> dio_read_tasktruncate_task
>> ->btrfs_seta
On 2013/02/01 12:49, Miao Xie wrote:
> On Fri, 01 Feb 2013 09:31:33 +0900, Tsutomu Itoh wrote:
>> Hi,
>>
>> On 2013/01/31 16:58, Miao Xie wrote:
>>> On wed, 30 Jan 2013 23:55:34 -0600, Eric Sandeen wrote:
if you move the fail_block_groups: target above the comment, does that fix
it?
On fri, 1 Feb 2013 10:53:30 +0800, Liu Bo wrote:
> On Thu, Jan 31, 2013 at 05:39:03PM +0800, Miao Xie wrote:
>> This idea is from ext4. By this patch, we can make the dio write parallel,
>> and improve the performance.
>
> Interesting, AFAIK, ext4 can only do nolock dio write on some
> condit
On Fri, 01 Feb 2013 09:31:33 +0900, Tsutomu Itoh wrote:
> Hi,
>
> On 2013/01/31 16:58, Miao Xie wrote:
>> On wed, 30 Jan 2013 23:55:34 -0600, Eric Sandeen wrote:
>>> if you move the fail_block_groups: target above the comment, does that fix
>>> it?
>>> (although I don't know yet what started IO .
> On Thu, Jan 31, 2013 at 04:21:24PM +0800, Chen Yang wrote:
>> In cmd_send_start(), there is a check to make sure dump_fd is not a tty
>> before parsing command options. So if we use the option "-f file",
>> it doesn't work for the dump_fd has not been created. So fix it.
>
> Good catch, thanks.
On Thu, Jan 31, 2013 at 05:39:03PM +0800, Miao Xie wrote:
> This idea is from ext4. By this patch, we can make the dio write parallel,
> and improve the performance.
Interesting, AFAIK, ext4 can only do nolock dio write on some
conditions(should be a overwrite, file size remains unchanged,
no alig
Hi,
On 2013/01/31 16:58, Miao Xie wrote:
> On wed, 30 Jan 2013 23:55:34 -0600, Eric Sandeen wrote:
>> if you move the fail_block_groups: target above the comment, does that fix
>> it?
>> (although I don't know yet what started IO . . . )
>>
>> like this:
>>
>> From: Eric Sandeen
>>
>> Make sure
On Thu, Jan 31, 2013 at 11:00 PM, Hugo Mills wrote:
> On Thu, Jan 31, 2013 at 04:39:52PM +0100, Christopher Thorjussen wrote:
>> I've created a large btrfs volume out of two large raid-60 devices. On
>> there I've created three subvolumes. When I do a list of those the 2nd
>> isn't displayed. If I
On Thu, Jan 31, 2013 at 04:39:52PM +0100, Christopher Thorjussen wrote:
> I've created a large btrfs volume out of two large raid-60 devices. On
> there I've created three subvolumes. When I do a list of those the 2nd
> isn't displayed. If I however add a fouth subvol they all gets listed.
This
On Thu, Jan 31, 2013 at 02:44:12PM +0100, Martin Steigerwald wrote:
> Hi!
>
> Today I converted my /home from Ext4 to BTRFS by reformatting and copying
> all over again.
>
> I created the filesystem with -l 16384 -n 16384 -d single -m single on an
> logical volume Intel SSD 320 and mount with com
On Jan 31, 2013, at 12:17 PM, Adam Ryczkowski
wrote:
>>>
>> When you create a btrfs file system, by default the data profile is single,
>> and metadata profile is dup. When you add another device to the volume, it
>> stays this way. The single data profile behaves similar to LVM linear,
>> e
> V1->V2: don't duplicate the freeing stuff, just unlock if we have a head.
Nice, that's what I was picturing if we needed the freeing stuff to be
covered by the mutex. Thanks for cleaning it up.
- z
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a messa
On Thu, Jan 31, 2013 at 12:58:08PM -0700, Zach Brown wrote:
> > - struct list_head splice;
> > struct btrfs_ordered_extent *ordered;
>
> > struct inode *inode;
>
> Remove this too?
>
> > + /*
> > +* This will just short circuit the ordered completion stuff which will
> > +* m
> - struct list_head splice;
> struct btrfs_ordered_extent *ordered;
> struct inode *inode;
Remove this too?
> + /*
> + * This will just short circuit the ordered completion stuff which will
> + * make sure the ordered extent gets properly cleaned up.
> + */
>
When we abort we've been just free'ing up all the ordered extents and
hoping for the best. This results in lots of warnings from various places,
warnings from btrfs_destroy_inode() because it's ENOSPC accounting isn't
fixed. It will also screw up lots of pages who have been set private but
never
Hi Jan,
attached are bash scripts to repro the issue.
Some instructions on how to run them:
- create 2 btrfs filesystems with "mkfs.btrfs /dev/sdXXX". I don't
think that size matters.
- mount them in /mnt/src and /mnt/dst
- mount options: noatime,nodatasum,nodatacow,nospace_cache
- put the 3 scrip
On Jan 31, 2013, at 6:44 AM, Martin Steigerwald wrote:
> Works well so far and I see no issues.
A fragmented ssd doesn't come with the penalty of head seek latency or
rotational latency, both of which increase with fragmentation on rotating
media. I'm not sure what the equivalent is for SSD. D
On 2013-01-31 20:08, Chris Murphy wrote:
On Jan 31, 2013, at 2:45 AM, Adam Ryczkowski
wrote:
Yes, you are right. It is important contributing factor, why relatime mount
option killed my performance so badly.
So is this what was causing the problem?
Yes.
Can you tell me more? Because I have
Am Mittwoch, 30. Januar 2013 schrieb David Sterba:
> Hi,
Hi,
> a few build warning fixes, unaligned access fix #2 and finally support
> for the 'device stats' and device 'replace' commands!
>
> Please test, worked for me here, but not tested extensively. If
> everything goes well I'll send a pul
On Jan 31, 2013, at 2:45 AM, Adam Ryczkowski
wrote:
>>
> Yes, you are right. It is important contributing factor, why relatime mount
> option killed my performance so badly.
So is this what was causing the problem?
>>
> The dedup chunk size isn't clearly stated, but from the README I infer
Hi,
> After mounting the system with noatime the problem disappeared, like in
> magic.
Incidentally, the current version of bedup uses a private mountpoint with
noatime whenever you don't give it the path to a mounted volume. You can
use it with no arguments or designate a filesystem by its u
On Wed, Jan 30, 2013 at 02:59:05PM -0700, Ilya Dryomov wrote:
> On Wed, Jan 30, 2013 at 10:11:44PM +0100, Ian Kumlien wrote:
> > On Wed, Jan 30, 2013 at 12:33:42PM -0800, Filipe Brandenburger wrote:
> > > Hi Ian,
> > >
> > > On Tue, Jan 29, 2013 at 3:03 PM, Ian Kumlien wrote:
> > > > This patch i
On Thu, Jan 31, 2013 at 06:34:04PM +0100, David Sterba wrote:
> Otherwise, Mark's patches add the incompat bit unconditionally, we need
> a way how to make it tunable in the same way as other mkfs do. I'd say
> to take them as-is now and extend mkfs later.
Well I guess its more of a job for btrfst
The entry point at the defrag ioctl always sets "cache only" to 0;
the codepaths haven't run for a long time as far as I can
tell. Chris says they're dead code, so remove them.
Signed-off-by: Eric Sandeen
---
Compile-tested only, FWIW.
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index ac4
On Thu, Jan 31, 2013 at 01:35:30PM +0800, Anand Jain wrote:
>Kindly accept this patch for your Btrfs-progs
>integration-20130130 branch. This patch updates
>only man btrfs and is a very low risk category.
Very low risk indeed, added thanks.
david
--
To unsubscribe from this list: send
On Thu, Jan 31, 2013 at 10:33:37AM -0500, Norbert Veber wrote:
> I looked at Mark Fasheh's patch, and from my rudimentary udnerstanding
> it seems like I need to set BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF in the
> superblock.
>
> Is there any way to edit the superblock of an existing filesystem to
>
On 01/31/2013 08:33 AM, Josef Bacik wrote:
> On Wed, Jan 30, 2013 at 02:37:40PM -0700, Jim Schutt wrote:
>> On 01/30/2013 09:38 AM, Josef Bacik wrote:
>>> On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote:
> On 01/29/2013 01:04 PM, Josef Bacik wrote:
>>> On Tue, Jan 29, 2013 at 11:
On Thu, Jan 31, 2013 at 04:21:24PM +0800, Chen Yang wrote:
> In cmd_send_start(), there is a check to make sure dump_fd is not a tty
> before parsing command options. So if we use the option "-f file",
> it doesn't work for the dump_fd has not been created. So fix it.
Good catch, thanks. I see tha
On Thu, Jan 31, 2013 at 02:39:03AM -0700, Miao Xie wrote:
> This idea is from ext4. By this patch, we can make the dio write parallel,
> and improve the performance.
>
> We needn't worry about the race between dio write and truncate, because the
> truncate need wait untill all the dio write end.
>
On Thu, Jan 31, 2013 at 02:23:19AM -0700, Miao Xie wrote:
> Currently, we can do unlocked dio reads, but the following race
> is possible:
>
> dio_read_task truncate_task
> ->btrfs_setattr()
> ->btrfs_direct_IO
> ->__blockdev_direct_IO
> ->bt
I hit this error when reproducing a bug that would end in a transaction
abort. We take the delayed ref head's mutex to keep anybody from processing
it while we're destroying it, but we fail to drop the mutex before we carry
on and free the damned thing. Fix this by doing the remove logic for the
On Wed, Jan 30, 2013 at 03:16:35PM -0700, Zach Brown wrote:
> On Wed, Jan 30, 2013 at 04:06:18PM -0500, Josef Bacik wrote:
> > I hit this error when reproducing a bug that would end in a transaction
> > abort. We take the delayed ref head's mutex to keep anybody from processing
> > it while we're
On Thu, Jan 31, 2013 at 09:54:32AM +0100, Lukáš Czerner wrote:
> Just to be sure sure I have to ask. Which is the btrfs-progs repository/branch
> I should base my work on ? Currently I am using repostitory
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git
>
> and master bran
Hi,
I am trying to switch my BackupPC filesystem to btrfs, so I upgraded to
kernel 3.7.5 as I understand it has support for more hard links.
However I still get the 'too many hard links error'.
I looked at Mark Fasheh's patch, and from my rudimentary udnerstanding
it seems like I need to set BTR
On 1/31/13 1:58 AM, Miao Xie wrote:
> On wed, 30 Jan 2013 23:55:34 -0600, Eric Sandeen wrote:
>> if you move the fail_block_groups: target above the comment, does that fix
>> it?
>> (although I don't know yet what started IO . . . )
>>
>> like this:
>>
>> From: Eric Sandeen
>>
>> Make sure that w
On Wed, Jan 30, 2013 at 02:37:40PM -0700, Jim Schutt wrote:
> On 01/30/2013 09:38 AM, Josef Bacik wrote:
> > On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote:
> >> > On 01/29/2013 01:04 PM, Josef Bacik wrote:
> >>> > > On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote:
> > >
On 1/31/13 6:50 AM, David Sterba wrote:
> Parallel build may fail due to late creation of version.h, fix the rule name
> that does not match the filename.
>
> Signed-off-by: David Sterba
Look good, thanks. surprised I didn't run into this.
Reviewed-by: Eri Sandeen
> ---
> Makefile | 4 ++--
>
I got a double free error when unmounting a file system that failed to add a
chunk during its operation. This is because we will kfree the mapping that
we created but leave the extent_map in the em_tree for chunks. So to fix
this just remove the extent_map when we error out so we don't run into t
Hi!
Today I converted my /home from Ext4 to BTRFS by reformatting and copying
all over again.
I created the filesystem with -l 16384 -n 16384 -d single -m single on an
logical volume Intel SSD 320 and mount with compress=lzo,spacecache. Current
state:
merkaba:~> btrfs filesystem show
failed to
Hi,
followup to http://article.gmane.org/gmane.comp.file-systems.btrfs/22561
where I saw a crash inside btrfs_set_item_key_safe. After reboot, mount
crashed with the messages below. Next reboot and mount was fine. Scrub does not
report any errors.
It may be an unhandled error case after 'failed t
Thanks for your comments, Miao.
On Thu, Jan 31, 2013 at 4:42 AM, Miao Xie wrote:
> On Wed, 30 Jan 2013 20:23:22 +0200, Alex Lyakas wrote:
>> Hi Miao,
>> I was following this thread in the past, but I did not understand it
>> fully, maybe you can explain?
>>
>> # mkfs.btrfs
>> # mount
Hi,
I want to check if any of the below issues are worth/should be fixed:
# btrfs_ioctl_snap_destroy() does not commit a transaction. As a
result, user can ask to delete a subvol, he receives "ok" back. Even
if user does "btrfs sub list",
he will not see the deleted subvol (even though the transa
Parallel build may fail due to late creation of version.h, fix the rule name
that does not match the filename.
Signed-off-by: David Sterba
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 6df402c..bef1e13 100644
--- a/Makefile
+++ b/M
With RAID-0, you'd get data striped equally across all (in this case,
both) the devices, up to the size of the second-largest one, at which
point it'll stop allocating space.
By "stop allocating space" I assume you mean it will return out of space
errors, even though there is technically 250GB
On Wed, Jan 30, 2013 at 01:26:58AM +0100, David Sterba wrote:
> Stefan Behrens (3):
> Btrfs-progs: add command to get/reset device stats via ioctl
JFI, pointed out on IRC:
--- a/print-tree.c
+++ b/print-tree.c
@@ -454,6 +454,8 @@ static void print_key_type(u64 objectid, u8 type)
My original problem got solved, but you answer has a set of interesting
performance hints, and I am very grateful for you input. Here are my
answers and further questions if you are willing to continue this topic.
On 2013-01-31 02:50, Chris Murphy wrote:
On Jan 30, 2013, at 6:02 PM, Adam Rycz
On 2013-01-31 04:33, Andrew Wade wrote:
Hi Adam,
Is btrfs mounted relatime? I'm wondering if you're seeing metadata
writes from atime updates. I've got my filesystem mounted noatime to
avoid breaking metadata sharing between subvolumes.
Apologies for the broken threading - I'm not subscribed to
This idea is from ext4. By this patch, we can make the dio write parallel,
and improve the performance.
We needn't worry about the race between dio write and truncate, because the
truncate need wait untill all the dio write end.
And we also needn't worry about the race between dio write and punch
Currently, we can do unlocked dio reads, but the following race
is possible:
dio_read_task truncate_task
->btrfs_setattr()
->btrfs_direct_IO
->__blockdev_direct_IO
->btrfs_get_block
->btrfs_truncate()
On Thu, 31 Jan 2013, Lukáš Czerner wrote:
> Date: Thu, 31 Jan 2013 07:40:37 +0100 (CET)
> From: Lukáš Czerner
> To: Gene Czarcinski
> Cc: Lukáš Czerner ,
> linux-btrfs
> Subject: Re: [PATCH 1/3] Btrfs-progs: move path modification to filters
>
> On Wed, 30 Jan 2013, Gene Czarcinski wrote:
In cmd_send_start(), there is a check to make sure dump_fd is not a tty
before parsing command options. So if we use the option "-f file",
it doesn't work for the dump_fd has not been created. So fix it.
Signed-off-by: Cheng Yang
---
cmds-send.c | 12 +++-
1 files changed, 7 insertions
66 matches
Mail list logo
