Re: [PATCH 31/35] block, fs: remove old REQ definitions.

2016-02-24 Thread kbuild test robot
Hi Mike, [auto build test WARNING on next-20160224] [cannot apply to dm/for-next v4.5-rc5 v4.5-rc4 v4.5-rc3 v4.5-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/mchristi-redhat-com

Re: [PATCH 5/5] btrfs-progs: misc-test: Add regression test for find-root gives empty result

2016-02-24 Thread Qu Wenruo
David Sterba wrote on 2016/02/24 13:10 +0100: On Mon, Feb 22, 2016 at 02:59:57PM +0800, Qu Wenruo wrote: zA}GrL`3QeIdg)w^i(C5r-$jn2OSESOZGFpc5^m2cCgLRjc8Y@6PxG

Re: [PATCH 0/5] btrfs-find-root enhancement for chunk tree corrupted fs

2016-02-24 Thread Qu Wenruo
David Sterba wrote on 2016/02/24 13:38 +0100: On Mon, Feb 22, 2016 at 02:59:52PM +0800, Qu Wenruo wrote: Before this patchset, btrfs-find-root needs valid chunk tree from the fs. However for chunk root corrupted case, btrfs-find-root is of no use due to above limitation. This patchset will

Re: Major HDD performance degradation on btrfs receive

2016-02-24 Thread Nazar Mokrynskyi
Here is btrfs-show-super output: nazar-pc@nazar-pc ~> sudo btrfs-show-super /dev/sda1 superblock: bytenr=65536, device=/dev/sda1 - csum0x1e3c6fb8 [match] bytenr65536 flags0x1 ( WRITTEN )

Re: Major HDD performance degradation on btrfs receive

2016-02-24 Thread Henk Slager
On Tue, Feb 23, 2016 at 6:44 PM, Nazar Mokrynskyi wrote: > Looks like btrfstune -x did nothing, probably, it was already used at > creation time, I'm using rcX versions of kernel all the time and rolling > version of Ubuntu, so this is very likely to be the case. The

Re: [PATCH 26/35] block: set op to REQ_OP

2016-02-24 Thread kbuild test robot
Hi Mike, [auto build test WARNING on next-20160224] [cannot apply to dm/for-next v4.5-rc5 v4.5-rc4 v4.5-rc3 v4.5-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/mchristi-redhat-com

[PATCH 15/35] mpage: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has the mpage.c code set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. I have run xfstest with xfs, but I am not sure if I have stressed these code paths well. Signed-off-by: Mike Christie --- fs/mpage.c | 41

[PATCH 28/35] blktrace: get op from req->op/bio->bi_op

2016-02-24 Thread mchristi
From: Mike Christie The bio and request struct now store the operation in bio->bi_op/request->op. This patch has blktrace not check bi_rw/cmd_flags. This patch is only compile tested. Signed-off-by: Mike Christie --- include/linux/blktrace_api.h |

[PATCH 25/35] target: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has the target modules set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie Acked-by: Nicholas Bellinger ---

[PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio

2016-02-24 Thread mchristi
From: Mike Christie This has callers of submit_bio/submit_bio_wait set the bio->bi_rw instead of passing it in. This makes that use the same as generic_make_request and how we set the other bio fields. v2. 1. Set bi_rw instead of ORing it. For cloned bios, I still OR it to

[PATCH 03/35] block, fs, mm, drivers: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch converts the simple bi_rw use cases in the block, drivers, mm and fs code to use bi_op for a REQ_OP and bi_rw for rq_flag_bits. These should be simple one liner cases, so I just did them in one patch. The next patches handle the more

[PATCH 05/35] fs: have ll_rw_block users pass in op and flags separately

2016-02-24 Thread mchristi
From: Mike Christie This has ll_rw_block users pass in the operation and flags separately, so we can setup the bio->bi_op and bio-bi_rw flags. v2: 1. Fix for kbuild error in ll_rw_block comments. Signed-off-by: Mike Christie --- fs/buffer.c

[PATCH 04/35] fs: have submit_bh users pass in op and flags separately

2016-02-24 Thread mchristi
From: Mike Christie This has submit_bh users pass in the operation and flags separately, so we can setup the bio->bi_op and bio-bi_rw flags. Signed-off-by: Mike Christie --- drivers/md/bitmap.c | 4 ++-- fs/btrfs/check-integrity.c | 24

[PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields

2016-02-24 Thread mchristi
From: Mike Christie The following patches separate the operation (write, read, discard, etc) from the flags in bi_rw/cmd_flags. This patch adds definitions for request/bio operations, adds fields to the request/bio to set them, and some temporary compat code so the

[PATCH 00/35 v4] separate operations from flags in the bio/request structs

2016-02-24 Thread mchristi
point, we abused them so much we just made cmd_flags 64 bits, so we could add more. The following patches seperate the operation (read, write discard, flush, etc) from cmd_flags/bi_rw. This patchset was made against linux-next from today Feb 24 2016 (git tag next-20160224). I put a git tre

[PATCH 14/35] hfsplus: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has hfsplus set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie --- fs/hfsplus/hfsplus_fs.h | 2 +- fs/hfsplus/part_tbl.c | 5 +++--

[PATCH 12/35] gfs2: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has gfs2 set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. v2: Bob, I did not add your signed off, because there was the gfs2_submit_bhs changes since last time you reviewed it. Signed-off-by: Mike

[PATCH 18/35] pm: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has the pm swap code set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie --- kernel/power/swap.c | 31 +++ 1 file

[PATCH 24/35] xen: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has xen set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie --- drivers/block/xen-blkback/blkback.c | 29 + 1 file

[PATCH 13/35] xfs: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has xfs set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. Signed-off-by: Mike Christie Acked-by: Dave Chinner --- fs/xfs/xfs_aops.c | 3 ++- fs/xfs/xfs_buf.c | 27

[PATCH 21/35] bcache: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has bcache set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only Signed-off-by: Mike Christie --- drivers/md/bcache/btree.c | 2 ++ drivers/md/bcache/debug.c | 2 ++

[PATCH 22/35] drbd: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has drbd set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. Lars and Philip, I might have split this patch up a little weird. Thisi patch handles setting up the bio, and then patch 30

[PATCH 11/35] f2fs: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has f2fs set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie --- fs/f2fs/checkpoint.c| 10 ++ fs/f2fs/data.c | 33

[PATCH 10/35] btrfs: don't pass rq_flag_bits if there is a bio

2016-02-24 Thread mchristi
From: Mike Christie The bio bi_op and bi_rw is now setup, so there is no need to pass around the rq_flag_bits bits too. v2: 1. Fix merge_bio issue where instead of removing rw/op argument I passed it in again to the merge_bio related functions. Signed-off-by: Mike

[PATCH 20/35] dm: pass dm stats data dir instead of bi_rw

2016-02-24 Thread mchristi
From: Mike Christie It looks like dm stats cares about the data direction (READ vs WRITE) and does not need the bio/request flags. Commands like REQ_FLUSH, REQ_DISCARD and REQ_WRITE_SAME are currently always set with REQ_WRITE, so the extra check for REQ_DISCARD in

[PATCH 23/35] md/raid: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has md/raid set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie --- drivers/md/bitmap.c | 2 +- drivers/md/dm-raid.c | 5 +++--

[PATCH 07/35] btrfs: have submit_one_bio users setup bio bi_op

2016-02-24 Thread mchristi
From: Mike Christie This patch has btrfs's submit_one_bio callers set the bio->bi_op to a REQ_OP and the bi_rw to rq_flag_bits. The next patches will continue to convert btrfs, so submit_bio_hook and merge_bio_hook related code will be modified to take only the bio. I did

[PATCH 17/35] ocfs2: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has ocfs2 set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie --- fs/ocfs2/cluster/heartbeat.c | 11 +++ 1 file changed, 7 insertions(+), 4

[PATCH 26/35] block: set op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch converts the request related block layer code to set request->op to a REQ_OP and cmd_flags to rq_flag_bits. There is some tmp compat code when setting up cmd_flags so it still carries both the op and flags. It will be removed in in later

[PATCH 08/35] btrfs: set bi_op tp REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has btrfs set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. Signed-off-by: Mike Christie --- fs/btrfs/check-integrity.c | 19 +-- fs/btrfs/compression.c | 4 fs/btrfs/disk-io.c |

[PATCH 29/35] ide cd: do not set REQ_WRITE on requests.

2016-02-24 Thread mchristi
From: Mike Christie The block layer will set the correct READ/WRITE operation flags/fields when creating a request, so there is not need for drivers to set the REQ_WRITE flag. This patch is compile tested only. Signed-off-by: Mike Christie ---

[PATCH 16/35] nilfs: set bi_op to REQ_OP

2016-02-24 Thread mchristi
From: Mike Christie This patch has nilfs set the bio bi_op to a REQ_OP, and rq_flag_bits to bi_rw. This patch is compile tested only. Signed-off-by: Mike Christie --- fs/nilfs2/segbuf.c | 18 ++ 1 file changed, 10 insertions(+), 8

[PATCH 35/35] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH

2016-02-24 Thread mchristi
From: Mike Christie To avoid confusion between REQ_OP_FLUSH, which is handled by request_fn drivers, and upper layers requesting the block layer perform a flush sequence along with possibly a WRITE, this patch renames REQ_FLUSH to REQ_PREFLUSH. Signed-off-by: Mike Christie

[PATCH 34/35] block: add QUEUE_FLAGs for flush and fua

2016-02-24 Thread mchristi
From: Mike Christie The last patch added a REQ_OP_FLUSH for request_fn drivers and the next patch renames REQ_FLUSH to REQ_PREFLUSH which will be used by file systems and make_request_fn drivers. This leaves REQ_FLUSH/REQ_FUA defined for drivers to tell the block layer if

[PATCH 32/35] block: shrink bi_rw and bi_op

2016-02-24 Thread mchristi
From: Mike Christie There is no need for bi_op/op and bi_rw to be so large now, so this patch shrinks them. Signed-off-by: Mike Christie --- block/blk-core.c | 2 +- drivers/md/dm-flakey.c | 2 +- drivers/md/raid5.c | 13

[PATCH 31/35] block, fs: remove old REQ definitions.

2016-02-24 Thread mchristi
From: Mike Christie We no longer use REQ_WRITE. REQ_WRITE_SAME and REQ_DISCARD, so this patch removes them. Signed-off-by: Mike Christie --- include/linux/blk_types.h | 21 ++--- include/linux/fs.h | 21 +++--

[PATCH 30/35] block, fs, drivers: do not test bi_rw for REQ_OPs

2016-02-24 Thread mchristi
From: Mike Christie We no longer use the bio->bi_rw field for REQ_OPs: REQ_WRITE, REQ_DISCARD, REQ_WRITE_SAME, so this patch stops checking for them in bi_rw and also removes the related compat code. v2: 1. Remove compat code in __get_request. Signed-off-by: Mike Christie

[PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation

2016-02-24 Thread mchristi
From: Mike Christie This adds a REQ_OP_FLUSH operation that is sent to request_fn based drivers by the block layer's flush code, instead of sending requests with the request->cmd_flags REQ_FLUSH bit set. For the following 3 flush related patches, I have not tested every

Re: Input/Output errors

2016-02-24 Thread Kenny MacDermid
On Wed, Feb 24, 2016 at 09:58:08AM +0100, Szalma László wrote: > - echo 3 > /proc/sys/vm/drop_cachessometimes fixes the problem, but not > every time Interesting. I just had the issue happen with one of my files, tried this, and it's now readable again. -- To unsubscribe from this list: send

Re: Input/Output errors

2016-02-24 Thread Kenny MacDermid
On Tue, Feb 23, 2016 at 09:37:03PM -0700, Chris Murphy wrote: > On Tue, Feb 23, 2016 at 8:02 PM, Kenny MacDermid > wrote: > > > > > rw,noatime,compress=lzo,ssd,discard,space_cache,autodefrag,inode_cache > > It sounds like an ssd trim bug. I'd check the firmware for

Re: [PATCH v2] Btrfs: fix listxattrs not listing all xattrs packed in the same item

2016-02-24 Thread Holger Hoffstätte
On 02/24/16 16:53, fdman...@kernel.org wrote: > From: Filipe Manana > > In the listxattrs handler, we were not listing all the xattrs that are > packed in the same btree item, which happens when multiple xattrs have > a name that when crc32c hashed produce the same checksum

[PATCH] Btrfs: fix race when checking if we can skip fsync'ing an inode

2016-02-24 Thread fdmanana
From: Filipe Manana If we're about to do a fast fsync for an inode and btrfs_inode_in_log() returns false, it's possible that we had an ordered extent in progress (btrfs_finish_ordered_io() not run yet) when we noticed that the inode's last_trans field was not greater than the

Re: [PATCH] btrfs-progs: add 'du' command

2016-02-24 Thread David Sterba
On Tue, Feb 02, 2016 at 12:09:21PM -0800, Mark Fasheh wrote: > > Otherwise code looks ok, I saw use of uint64_t, the units help can be > > extended to the full units set, and maybe other minor things that would > > be good to fix. I'll do a more fine grained review when applying the > > patches. >

Re: [PATCH 2/2] btrfs-progs: update docs for inspect-internal dump-super

2016-02-24 Thread David Sterba
On Wed, Feb 24, 2016 at 11:52:34AM +0100, Alexander Fougner wrote: > --- a/Documentation/btrfs-inspect-internal.asciidoc > +++ b/Documentation/btrfs-inspect-internal.asciidoc > @@ -92,6 +92,44 @@ Print info of the specified block only. > -t > Print only the tree with the specified ID. > >

Re: [PATCH 1/2] btrfs-progs: introduce inspect-internal dump-super

2016-02-24 Thread David Sterba
On Wed, Feb 24, 2016 at 11:52:33AM +0100, Alexander Fougner wrote: > The long-term plan is to merge the features of standalone tools > into the btrfs binary, reducing the number of shipped binaries. Applied, thanks. > --- a/Makefile.in > +++ b/Makefile.in > @@ -70,7 +70,8 @@ objects = ctree.o

Re: [PATCH] btrfs-progs: restore: make btrfs restore able to read a file which lists files to restore

2016-02-24 Thread Henrik Asp
On onsdag 24 februari 2016 kl. 12:51:37 CET David Sterba wrote: > Is it supposed to match only full path or also substrings? The way > it's implemented it can match just part of the path but I'm not sure > if this is intended or not. > > Paths in path-from-file: > > /a/b/c/d > > In

Re: [PATCH 1/2] fstests: btrfs/011 use replace_options

2016-02-24 Thread David Sterba
On Fri, Feb 19, 2016 at 09:25:28PM +0800, Anand Jain wrote: > This patch fixes test btrfs/011 which intended to use -r option > but was never used since its associated args 'replace_options' > didn't make it to the cli. After this patch the tests fails due to extra output. I've tested several

Re: [PATCH 0/5] btrfs-find-root enhancement for chunk tree corrupted fs

2016-02-24 Thread David Sterba
On Mon, Feb 22, 2016 at 02:59:52PM +0800, Qu Wenruo wrote: > Before this patchset, btrfs-find-root needs valid chunk tree from the > fs. > However for chunk root corrupted case, btrfs-find-root is of no use due > to above limitation. > > This patchset will allow open_ctree_fs_info() to return a

Re: [PATCH 5/5] btrfs-progs: misc-test: Add regression test for find-root gives empty result

2016-02-24 Thread David Sterba
On Mon, Feb 22, 2016 at 02:59:57PM +0800, Qu Wenruo wrote: > zA}GrL`3QeIdg)w^i(C5r-$jn2OSESOZGFpc5^m2cCgLRjc8Y@6PxG Mne-=t|1Sdn0?V+~RR910 > > literal 0 > HcmV?d1 > > diff --git a/tests/misc-tests/012-find-root-no-result/test.sh > b/tests/misc-tests/012-find-root-no-result/test.sh

Re: [PATCH] btrfs-progs: restore: make btrfs restore able to read a file which lists files to restore

2016-02-24 Thread David Sterba
On Mon, Feb 22, 2016 at 06:53:23PM +0100, Henrik Asp wrote: > --path-regex' syntax does not map well to restoring specific files. > this patch introduces --path-from-file which takes a file listing > files to restore. > that file is memory mapped, and for every leaf, memmem is used to > check if

Re: [PATCH] Btrfs: fix listxattrs not listing all xattrs packed in the same item

2016-02-24 Thread Holger Hoffstätte
On Wed, Feb 24, 2016 at 12:29 AM, Satoru Takeuchi wrote: > On 2016/02/23 2:52, fdman...@kernel.org wrote: >> >> From: Filipe Manana >> >> In the listxattrs handler, we were not listing all the xattrs that are >> packed in the same btree item,

Hi linux

2016-02-24 Thread Hendra Soetjahja
Hi linux http://iwerk.com/parallel.php?temperature=dn124wpegp6y1w hend...@yahoo.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] btrfs-progs: update docs for inspect-internal dump-super

2016-02-24 Thread Alexander Fougner
Signed-off-by: Alexander Fougner --- Documentation/btrfs-inspect-internal.asciidoc | 38 +++ btrfs-completion | 2 +- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] btrfs-progs: introduce inspect-internal dump-super

2016-02-24 Thread Alexander Fougner
The long-term plan is to merge the features of standalone tools into the btrfs binary, reducing the number of shipped binaries. Signed-off-by: Alexander Fougner --- Makefile.in | 3 +- btrfs-show-super.c| 520

Re: Major HDD performance degradation on btrfs receive

2016-02-24 Thread Patrik Lundquist
On 23 February 2016 at 18:26, Marc MERLIN wrote: > > I'm currently doing a very slow defrag to see if it'll help (looks like > it's going to take days). > I'm doing this: > for i in dir1 dir2 debian32 debian64 ubuntu dir4 ; do echo $i; time btrfs fi > defragment -v -r $i; done

Re: Input/Output errors

2016-02-24 Thread Szalma László
2016-02-24 05:37 keltezéssel, Chris Murphy írta: On Tue, Feb 23, 2016 at 8:02 PM, Kenny MacDermid wrote: rw,noatime,compress=lzo,ssd,discard,space_cache,autodefrag,inode_cache It sounds like an ssd trim bug. I'd check the firmware for updates. If it's up to date,

[PATCH v2 RESEND 5/5] fstests: btrfs: Test inband dedup with balance.

2016-02-24 Thread Qu Wenruo
Btrfs balance will reloate date extent, but its hash is removed too late at run_delayed_ref() time, which will cause extent ref increased increased during balance, cause either find_data_references() gives WARN_ON() or even run_delayed_refs() fails and cause transaction abort. Add such

[PATCH v2 RESEND 4/5] fstests: btrfs: Add per inode dedup flag test

2016-02-24 Thread Qu Wenruo
This test will check per inode dedup flag. Signed-off-by: Qu Wenruo --- tests/btrfs/202 | 116 tests/btrfs/202.out | 15 +++ tests/btrfs/group | 1 + 3 files changed, 132 insertions(+) create mode 100755

[PATCH v2 RESEND 2/5] fstests: btrfs: Add basic test for btrfs in-band de-duplication

2016-02-24 Thread Qu Wenruo
Add basic test for btrfs in-band de-duplication, including: 1) Enable 2) Re-enable 3) On disk extents are refering to same bytenr 4) Disable Signed-off-by: Qu Wenruo --- common/defrag | 8 tests/btrfs/200 | 125

[PATCH v2 RESEND 3/5] fstests: btrfs: Add testcase for btrfs dedup enable disable race test

2016-02-24 Thread Qu Wenruo
Add test case to check btrfs dedup enable/disable race. Signed-off-by: Qu Wenruo --- tests/btrfs/201 | 100 tests/btrfs/201.out | 1 + tests/btrfs/group | 1 + 3 files changed, 102 insertions(+) create mode

[PATCH v2 RESEND 0/5] Btrfs in-band de-duplication tests cases

2016-02-24 Thread Qu Wenruo
Since we are push btrfs in-band de-duplication for v4.6, it's better to add test cases for this new feature. Except the first basic function test, the rest are all regression test which we found during the development. We also found some bugs from the generic test, but we need some xfstests