Change seen_fsid to hold fd and DIR* in order to keep access to each fs.
This will be used for 'subvol delete --commit-after'.
Signed-off-by: Tomohiro Misono
---
cmds-filesystem.c | 4 ++--
utils.c | 6 +-
utils.h | 5 -
3 files changed, 11 insertions(+), 4 deletions(
Fix subvol del --commit-after to work properly:
- SYNC ioctl will be issued even when last delete is failed
- SYNC ioctl will be issued on each file system only once in the end
To achieve this, get_fsid() and add_seen_fsid() is called after each delete
to keep only one fd for each fs.
In the en
Make is_seen_fsid()/add_seen_fsid()/free_seen_fsid() to common functions.
This will be used for 'subvol delete --commit-after'.
Signed-off-by: Tomohiro Misono
---
cmds-filesystem.c | 88 ---
utils.c | 70 ++
Make get_fsid() to a common function.
This will be used for 'subvol delete --commit-after'.
Signed-off-by: Tomohiro Misono
---
cmds-property.c | 30 --
utils.c | 31 +++
utils.h | 1 +
3 files changed, 32 insertions(+), 30
Fix subvol del --commit-after to work properly:
- SYNC ioctl will be issued even when last delete is failed
- SYNC ioctl will be issued on each file system only once in the end
To achieve this, each deleted subvol's (parent's) fsid is checked each
time. If the fsid is seen for the first time, it
On 2017年09月26日 11:01, Su Yue wrote:
Hi
During writing patches about check, I found something confusing
about btrfs-progs original check.
Setup:
Version: Btrfs progs v4.13.1
$ make TEST=006\* test-fsck
[TEST] fsck-tests.sh
[TEST/fsck] 006-bad-root-items
$ cat tests/fsck-tests-results.txt
On 2017年09月26日 11:01, Su Yue wrote:
Hi
During writing patches about check, I found something confusing
about btrfs-progs original check.
Setup:
Version: Btrfs progs v4.13.1
$ make TEST=006\* test-fsck
[TEST] fsck-tests.sh
[TEST/fsck] 006-bad-root-items
$ cat tests/fsck-tests-results.txt
Hi
During writing patches about check, I found something confusing
about btrfs-progs original check.
Setup:
Version: Btrfs progs v4.13.1
$ make TEST=006\* test-fsck
[TEST] fsck-tests.sh
[TEST/fsck] 006-bad-root-items
$ cat tests/fsck-tests-results.txt | tail -n 25
### .../btrf
On Mon, Sep 25, 2017 at 04:00:09PM +0200, David Sterba wrote:
>On Thu, Aug 24, 2017 at 05:31:15PM +0800, Lu Fengqi wrote:
>> On Thu, Aug 17, 2017 at 01:01:29PM -0400, jo...@toxicpanda.com wrote:
>> >From: Josef Bacik
>> >
>> >Right now we do a lot of weird hoops around outstanding_extents in order
On 2017年09月26日 08:28, Qu Wenruo wrote:
On 2017年09月25日 23:45, David Sterba wrote:
On Wed, Aug 23, 2017 at 04:57:58PM +0900, Qu Wenruo wrote:
Add extra checker for item with EXTENT_DATA type.
This checks the following thing:
0) Key offset
All key offset must be aligned to sectorsize.
On 2017年09月25日 23:45, David Sterba wrote:
On Wed, Aug 23, 2017 at 04:57:58PM +0900, Qu Wenruo wrote:
Add extra checker for item with EXTENT_DATA type.
This checks the following thing:
0) Key offset
All key offset must be aligned to sectorsize.
Inline extent must have 0 for key offset.
From: Goffredo Baroncelli
Add a new ioctl to get info about chunk without requiring the root privileges.
This allow to a non root user to know how the space of the filesystem is
allocated.
Signed-off-by: Goffredo Baroncelli
---
fs/btrfs/ioctl.c | 215 +
The aim of this patch is to replace the BTRFS_IOC_TREE_SEARCH ioctl when
it is used to obtain information about the chunks/block groups.
The problems in using the BTRFS_IOC_TREE_SEARCH is that it access
the very low data structure of BTRFS. This means:
1) this would be complicated a possible cha
From: Goffredo Baroncelli
Use the new ioctl BTRFS_IOC_GET_CHUNK_INFO in load_chunk_info() instead of the
BTRFS_IOC_TREE_SEARCH. The old method is still present as fallback for
compatibility reason.
The goal is to avoid BTRFS_IOC_GET_CHUNK_INFO because it requires root
privileges.
Signed-off-by:
Hi all,
this patches set uses the new ioctl BTRFS_IOC_GET_CHUNK_INFO to get
information about the chunk (see my other emails).
The first patch change the function get_partition_size() to avoid
ioctl which would require root privileges (BLKGETSIZE64).
Instead it obtain the information via the sy
From: Goffredo Baroncelli
Allow the get_partition_size() to be called without
root privileges.
Signed-off-by: Goffredo baroncelli
---
utils.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/utils.c b/utils.c
index 7a2710fe..ee3ed544 100644
--- a
Hi Satoru,
I'm so sorry for the late reply! I rewrote the test programs to invoke
syscalls in the conventional way and added a few comments. Please find
attached the revised report.
As to your questions on "mmap", you are totally right that the first
mmap in the original 1/min.cpp is irrelevant.
On Fri, Sep 01, 2017 at 03:09:30AM -0400, jo...@toxicpanda.com wrote:
> From: Josef Bacik
>
> We were having corruption issues that were tied back to problems with the
> extent
> tree. In order to track them down I built this tool to try and find the
> culprit, which was pretty successful. If
Hi,
I have 15 x 6 TB disks in md-raid (Because btrfs's raid6 was marked as
not-for-real-use when I first time installed this machine)
Now I have got both problem twice.
At this last time I have 233 subvolums, and millions of files (all
together)
Then filesystem went to read only with this
Hi,
btrfs-progs version 4.13.1 have been released.
The ZSTD support has been added, the kernel code will land in 4.14. Now
configure will detect if libzstd is available and will use it. In the future
this will become a mandatory dependency. Please check your distro for libzstd
and ask them to add
On Fri, Sep 15, 2017 at 05:34:57PM +0200, Adam Borowski wrote:
> Hi!
> Here's a patch set that allows changing the compression level for zstd,
> currently at mount time only. I've played with it for a month, so despite
> being a quick hack, it's reasonably well tested. Tested on 4.13 +
> btrfs-fo
On Wed, Aug 23, 2017 at 04:57:58PM +0900, Qu Wenruo wrote:
> Add extra checker for item with EXTENT_DATA type.
> This checks the following thing:
> 0) Key offset
>All key offset must be aligned to sectorsize.
>Inline extent must have 0 for key offset.
>
> 1) Item size
>Plain text inlin
Hi guys,
It seems that btrfs v4.12.1 allows:
(1) btrfs send -p
but disallows
(2) btrfs send -p
Code-wise it assumes that is always found at optind == 1. I was
about to patch this but I'm not sure which way we'd like to go with this:
Actually only allow (1) and block (2) p
On Wed, Aug 23, 2017 at 04:57:55PM +0900, Qu Wenruo wrote:
> The patchset introduce a new framework to do more comprehensive (if not
> the most) sanity check when reading out a leaf.
>
> The new sanity checker will include:
>
> 1) Key order
>Existing code
>
> 2) Item boundary
>Existing c
On 25/09/17 17:33, Qu Wenruo wrote:
(Any in this case, anyone in the maillist can help review messages)
If this is a question, I can help with assigning levels to messages.
Although I think many levels are only required for complex daemons or
network tools, while btrfs utils mostly perform atom
On Mon, Sep 25, 2017 at 08:31:03PM +0800, Anand Jain wrote:
> Moves btrfs_abort_transaction() to the error goto and renames
> error_trans to error_sysfs. This is a preparatory patch to
> remove the BUG_ON() in btrfs_init_new_device().
Please keep all transaction abort exactly at the place where th
On Mon, Sep 25, 2017 at 08:31:02PM +0800, Anand Jain wrote:
> Signed-off-by: Anand Jain
This does not look like change trivial enough to just leave out the
description. Please explain in more detail.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a messag
On Fri, Aug 25, 2017 at 11:32:21AM +0300, Nikolay Borisov wrote:
>
>
> On 24.08.2017 17:43, Nikolay Borisov wrote:
> >
> >
> > On 22.08.2017 23:00, jo...@toxicpanda.com wrote:
> >> From: Josef Bacik
> >>
> >> Nikolay reported that generic/273 was failing currently with ENOSPC.
> >> Turns out t
On 2017年09月25日 22:19, Hugo Mills wrote:
On Mon, Sep 25, 2017 at 04:04:03PM +0800, Qu Wenruo wrote:
On 2017年09月25日 15:52, Hugo Mills wrote:
On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote:
On 2017年09月25日 15:42, Marat Khalili wrote:
On 25/09/17 10:30, Nikolay Borisov wrote:
On
On Mon, Sep 25, 2017 at 04:04:03PM +0800, Qu Wenruo wrote:
>
>
> On 2017年09月25日 15:52, Hugo Mills wrote:
> >On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote:
> >>
> >>
> >>On 2017年09月25日 15:42, Marat Khalili wrote:
> >>>On 25/09/17 10:30, Nikolay Borisov wrote:
> On 19.09.2017 10:41,
On Wed, Aug 30, 2017 at 07:35:42PM +0300, Nikolay Borisov wrote:
> This memory barrier was introduced in 817d52f8dba2 ("Btrfs: async block group
> caching"), but even at that time it's usage was broken since it didn't pair
> with anything. There was one situation where the cached member was set to
On Mon, Aug 21, 2017 at 10:11:20AM -0400, Josef Bacik wrote:
> Ignore this, I git format-patch'ed the wrong patch.
So if you're going to send another version, please split the tracepoints
to another patch and update the format strings to the preferred format
https://btrfs.wiki.kernel.org/index.ph
On Thu, Aug 24, 2017 at 05:31:15PM +0800, Lu Fengqi wrote:
> On Thu, Aug 17, 2017 at 01:01:29PM -0400, jo...@toxicpanda.com wrote:
> >From: Josef Bacik
> >
> >Right now we do a lot of weird hoops around outstanding_extents in order
> >to keep the extent count consistent. This is because we logica
On Mon, Sep 25, 2017 at 03:18:31PM +0300, Nikolay Borisov wrote:
> On 21.08.2017 12:43, Nikolay Borisov wrote:
> > The delalloc_end parameter was only passed to extent_clear_unlock_delalloc,
> > but
> > since its usage was removed form that function let's also remove it from the
> > caller's param
On 2017年09月25日 20:18, Nikolay Borisov wrote:
On 21.08.2017 12:43, Nikolay Borisov wrote:
The delalloc_end parameter was only passed to extent_clear_unlock_delalloc, but
since its usage was removed form that function let's also remove it from the
caller's parameter list.
Signed-off-by: Nikol
On 2017年09月25日 20:31, Anand Jain wrote:
Moves btrfs_abort_transaction() to the error goto and renames
error_trans to error_sysfs. This is a preparatory patch to
remove the BUG_ON() in btrfs_init_new_device().
Signed-off-by: Anand Jain
---
fs/btrfs/volumes.c | 23 +--
1
On 25.09.2017 16:07, Nikolay Borisov wrote:
>
>
> On 25.09.2017 15:31, Anand Jain wrote:
>> Moves btrfs_abort_transaction() to the error goto and renames
>> error_trans to error_sysfs. This is a preparatory patch to
>> remove the BUG_ON() in btrfs_init_new_device().
>>
>> Signed-off-by: Anand J
On 25.09.2017 15:31, Anand Jain wrote:
> Moves btrfs_abort_transaction() to the error goto and renames
> error_trans to error_sysfs. This is a preparatory patch to
> remove the BUG_ON() in btrfs_init_new_device().
>
> Signed-off-by: Anand Jain
> ---
> fs/btrfs/volumes.c | 23 +-
On 2017年09月25日 20:31, Anand Jain wrote:
Signed-off-by: Anand Jain
The error_trans tag needs to revert the RDONLY flag without doubt.
But just a small question.
Just lines before error_trans tag, we're committing transaction and then
relocating system chunks.
In which we don't use goto e
Hi,
I've updated the Status page and synced the manual pages from
btrfs-progs git.
The status of various features is split to one more column, Performance.
There's a section for each 'mostly OK' status below the table and linked
from the note. This will hopefully be more understandable than just
Moves btrfs_abort_transaction() to the error goto and renames
error_trans to error_sysfs. This is a preparatory patch to
remove the BUG_ON() in btrfs_init_new_device().
Signed-off-by: Anand Jain
---
fs/btrfs/volumes.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
Here we will simply return the error to the caller. And handle the
fail condition by calling the abort transaction through the error
path.
Signed-off-by: Anand Jain
---
fs/btrfs/volumes.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes
1/3 fixes a bug which failed to reset writable when sprouting failed
2/3 is cleanup and preparatory to fix 3/3
3/3 fixes BUG_ON in btrfs_init_new_device()
Anand Jain (3):
btrfs: undo writable when sprouting fails
btrfs: cleanup btrfs_init_new_device()
btrfs: fix BUG_ON in btrfs_init_new_devi
Signed-off-by: Anand Jain
---
fs/btrfs/volumes.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 0e8f16c305df..9d64700cc9b6 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2501,6 +2501,8 @@ int btrfs_init_new_device(struct btrfs_fs_
On 21.08.2017 12:43, Nikolay Borisov wrote:
> The delalloc_end parameter was only passed to extent_clear_unlock_delalloc,
> but
> since its usage was removed form that function let's also remove it from the
> caller's parameter list.
>
> Signed-off-by: Nikolay Borisov
ping, since most of the
On 15.09.2017 11:47, peterh wrote:
> From: Kuanling Huang
>
> By analyzing the perf on btrfs send, we found it take large
> amount of cpu time on page_cache_sync_readahead. This effort
> can be reduced after switching to asynchronous one. Overall
> performance gain on HDD and SSD were 9 and 15
On 2017-09-22 11:07, Qu Wenruo wrote:
On 2017年09月22日 21:33, Austin S. Hemmelgarn wrote:
On 2017-09-22 08:32, Qu Wenruo wrote:
On 2017年09月22日 19:38, Austin S. Hemmelgarn wrote:
On 2017-09-22 06:39, Qu Wenruo wrote:
As I already stated in an other thread, if you want to shrink, do
it in anoth
On 2017-09-24 10:08, Goffredo Baroncelli wrote:
On 09/24/2017 12:10 PM, Anand Jain wrote:
All my points are clear for this patchset:
I know I removed one function, and my reason is:
1) No or little usage
And it's anti intuition.
2) Dead code (not tested nor well documented)
3) Possible w
On 2017年09月25日 17:50, Lukas Pirl wrote:
Dear all,
I experience reproducible OS crashes when scrubbing a btrfs file system.
Apart from that, the file system mounts rw and is usable without any
problems (including modifying snapshots and all that).
When the system crashes (i.e., freezes), there
Dear all,
I experience reproducible OS crashes when scrubbing a btrfs file system.
Apart from that, the file system mounts rw and is usable without any
problems (including modifying snapshots and all that).
When the system crashes (i.e., freezes), there are no errors printed to
the system logs or
On 09/24/2017 10:17 PM, Nikolay Borisov wrote:
On 19.09.2017 13:00, Qu Wenruo wrote:
On 2017年09月19日 17:48, Su Yue wrote:
On 09/19/2017 04:48 PM, Qu Wenruo wrote:
On 2017年09月19日 16:32, Su Yue wrote:
Lowmem check does not skip invalid type in extent_inline_ref then
calls btrfs_extent_
On 25/09/17 11:08, Qu Wenruo wrote:
What about redirecting stdout to /dev/null and redirecting stderr to
mail if return value is not 0?
s/if return value is not 0/if return value is 0/.
The main point is, if btrfs returns 0, then nothing to worry about.
(Unless there is a bug, even in that case
On 25/09/17 10:52, Hugo Mills wrote:
Isn't the correct way to catch the return value instead of grepping
the output?
It is, but if, for example, you're using the command in a cron
script which is expected to work, you don't want it producing output
because then you get a mail every time the
Am Mon, 25 Sep 2017 07:04:14 +
schrieb "Fuhrmann, Carsten" :
> Well the correct translation for "Laufzeit" is runtime and not
> latency. But thank you for that hint, I'll change it to "gesamt
> Laufzeit" to make it more clear.
How about better translating it to English in the first place as y
On 2017年09月25日 16:04, Qu Wenruo wrote:
On 2017年09月25日 15:52, Hugo Mills wrote:
On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote:
On 2017年09月25日 15:42, Marat Khalili wrote:
On 25/09/17 10:30, Nikolay Borisov wrote:
On 19.09.2017 10:41, Misono, Tomohiro wrote:
"btrfs subvolume c
On 2017年09月25日 15:52, Hugo Mills wrote:
On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote:
On 2017年09月25日 15:42, Marat Khalili wrote:
On 25/09/17 10:30, Nikolay Borisov wrote:
On 19.09.2017 10:41, Misono, Tomohiro wrote:
"btrfs subvolume create/delete" outputs the message of "Crea
On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote:
>
>
> On 2017年09月25日 15:42, Marat Khalili wrote:
> >On 25/09/17 10:30, Nikolay Borisov wrote:
> >>On 19.09.2017 10:41, Misono, Tomohiro wrote:
> >>>"btrfs subvolume create/delete" outputs the message of "Create/Delete
> >>>subvolume ..."
On 2017年09月25日 15:42, Marat Khalili wrote:
On 25/09/17 10:30, Nikolay Borisov wrote:
On 19.09.2017 10:41, Misono, Tomohiro wrote:
"btrfs subvolume create/delete" outputs the message of "Create/Delete
subvolume ..." even when an operation fails.
Since it is confusing, let's outputs the message
On Mon, Sep 25, 2017 at 10:42:06AM +0300, Marat Khalili wrote:
> On 25/09/17 10:30, Nikolay Borisov wrote:
> >On 19.09.2017 10:41, Misono, Tomohiro wrote:
> >>"btrfs subvolume create/delete" outputs the message of "Create/Delete
> >>subvolume ..." even when an operation fails.
> >>Since it is confu
On 25/09/17 10:30, Nikolay Borisov wrote:
On 19.09.2017 10:41, Misono, Tomohiro wrote:
"btrfs subvolume create/delete" outputs the message of "Create/Delete
subvolume ..." even when an operation fails.
Since it is confusing, let's outputs the message only when an operation
succeeds.
Please cha
On 19.09.2017 10:41, Misono, Tomohiro wrote:
> "btrfs subvolume create/delete" outputs the message of "Create/Delete
> subvolume ..." even when an operation fails.
> Since it is confusing, let's outputs the message only when an operation
> succeeds.
>
> Signed-off-by: Tomohiro Misono
> ---
>
Since setup_root_args() is not used anymore, just remove it.
Signed-off-by: Tomohiro Misono
---
fs/btrfs/super.c | 35 ---
1 file changed, 35 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 7edd74d..f589c5b 100644
--- a/fs/btrfs/super.c
+++ b/
Now parse_early_options() is used by both btrfs_mount() and mount_root().
However, the former only needs subvol related part and the latter needs
the others.
Therefore extract the subvol related parts from parse_early_options() and
move it to new parse function (parse_subvol_options()).
Signed-of
Cleanups btrfs_mount() by using mount_root(). This avoids getting
btrfs_mount() called twice in mount path.
Old btrfs_mount() will do:
0. VFS layer calls vfs_kern_mount() with registered file_system_type
(for btrfs, btrfs_fs_type). btrfs_mount() is called on the way.
1. btrfs_parse_early_option
Add mount_root() and new file_system_type for preparation of cleanup of
btrfs_mount(). Code path is not changed yet.
mount_root() is almost the same as current btrfs_mount(), but doesn't
have subvolume related part.
Signed-off-by: Tomohiro Misono
---
fs/btrfs/super.c | 116 +
Summary:
Cleanup mount path by avoiding calling btrfs_mount() twice.
No functional change. See below for longer explanation.
Changelog:
v3:
Reorganized patches again into four and added comments to the source.
Each patch can be applied and compiled while maintaining functionality.
The first
Well the correct translation for "Laufzeit" is runtime and not latency. But
thank you for that hint, I'll change it to "gesamt Laufzeit" to make it more
clear.
Best regards
Carsten
-Ursprüngliche Nachricht-
Von: Andrei Borzenkov [mailto:arvidj...@gmail.com]
Gesendet: Sonntag, 24. Sep
67 matches
Mail list logo
