Re: [PATCH] Btrfs: remove redundant btrfs_trans_release_metadata"

On Wed, Sep 5, 2018 at 10:45 PM, Liu Bo wrote: > Somehow this ends up with crash in btrfs/124, I'm trying to figure out > what went wrong. > It revealed the problem addressed in Josef's patch[1], so with it, this patch works just fine. [1] btrfs: make sure we create all new bgs thanks, liubo >

Re: [PATCH 22/35] btrfs: make sure we create all new bgs

On Fri, Aug 31, 2018 at 7:03 AM, Josef Bacik wrote: > On Fri, Aug 31, 2018 at 10:31:49AM +0300, Nikolay Borisov wrote: >> >> >> On 30.08.2018 20:42, Josef Bacik wrote: >> > We can actually allocate new chunks while we're creating our bg's, so >> > instead of doing list_for_each_safe, just do while

Re: [PATCH] Btrfs: remove redundant btrfs_trans_release_metadata"

Somehow this ends up with crash in btrfs/124, I'm trying to figure out what went wrong. thanks, liubo On Tue, Sep 4, 2018 at 6:14 PM, Liu Bo wrote: > __btrfs_end_transaction() has done the metadata release twice, > probably because it used to process delayed refs in between, but now > that we d

Re: [PATCH] btrfs: qgroup: Don't trace subtree if we're dropping tree reloc tree

On 2018/9/5 下午9:11, David Sterba wrote: > On Wed, Sep 05, 2018 at 01:03:39PM +0800, Qu Wenruo wrote: >> Tree reloc tree doesn't contribute to qgroup numbers, as we have > > I think you can call it just 'reloc tree', I'm fixing that in all > changelogs and comments anyway. But there is another t

Re: dduper - Offline btrfs deduplication tool

пт, 24 авг. 2018 г. в 7:41, Lakshmipathi.G : > > Hi - > > dduper is an offline dedupe tool. Instead of reading whole file blocks and > computing checksum, It works by fetching checksum from BTRFS csum tree. This > hugely improves the performance. > > dduper works like: > - Read csum for giv

Re: nbdkit as a flexible alternative to loopback mounts

On Tue, Sep 04, 2018 at 07:55:00PM -0600, Chris Murphy wrote: > https://rwmj.wordpress.com/2018/09/04/nbdkit-as-a-flexible-alternative-to-loopback-mounts/ > > This is a pretty cool writeup. I can vouch Btrfs will format mount, > write to, scrub, and btrfs check works on an 8EiB (virtual) disk. > >

Re: [PATCH] btrfs: qgroup: Don't trace subtree if we're dropping tree reloc tree

On Wed, Sep 05, 2018 at 01:03:39PM +0800, Qu Wenruo wrote: > Tree reloc tree doesn't contribute to qgroup numbers, as we have I think you can call it just 'reloc tree', I'm fixing that in all changelogs and comments anyway. > accounted them at balance time (check replace_path()). > > Skip such u

Re: [PATCH 0/3] btrfs: qgroup: Deprecate unused features for btrfs_qgroup_inherit()

On Fri, Aug 31, 2018 at 10:29:27AM +0800, Qu Wenruo wrote: > This patchset can be fetched from github: > https://github.com/adam900710/linux/tree/qgroup_inherit_check > Which is based on v4.19-rc1 tag. > > This patchset will first set btrfs_qgroup_inherit structure size limit > from PAGE_SIZE to f

Re: [PATCH 4/4] btrfs-progs: print-tree: Use breadth-first search for btrfs_print_tree()

On 5.09.2018 09:29, Qu Wenruo wrote: > btrfs_print_tree() uses depth-first search to print a subtree, it works > fine until we have 3 level tree. > > In that case, leaves and nodes will be printed in a depth-first order, > making it pretty hard to locate level 1 nodes. > > This patch will use

Re: fsck lowmem mode only: ERROR: errors found in fs roots

On 2018/9/5 8:33 PM, Christoph Anton Mitterer wrote: On Wed, 2018-09-05 at 15:04 +0800, Su Yue wrote: Agreed with Qu, btrfs-check shall not try to do any write. Well.. it could have been just some coincidence :-) I found the errors should blame to something about inode_extref check in lo

Re: fsck lowmem mode only: ERROR: errors found in fs roots

On Wed, 2018-09-05 at 15:04 +0800, Su Yue wrote: > Agreed with Qu, btrfs-check shall not try to do any write. Well.. it could have been just some coincidence :-) > I found the errors should blame to something about inode_extref check > in lowmem mode. So you mean errors in btrfs-check... and it

Re: [PATCH 3/4] btrfs-progs: Introduce function to find next sibling tree block

On 5.09.2018 09:29, Qu Wenruo wrote: > Introduce a new function, btrfs_next_sibling_tree_block(), which could > find any sibling tree blocks at path->lowest_level, unlike level 0 > limited btrfs_next_leaf(). > > Since this function is more generic than btrfs_next_leaf(), also make > btrfs_next

Re: [PATCH 5/8] btrfs-progs: Wire up delayed refs

On 5.09.2018 10:46, Qu Wenruo wrote: > > > On 2018/9/5 下午3:41, Nikolay Borisov wrote: >> >> >> On 5.09.2018 08:53, Qu Wenruo wrote: >>> >>> >>> On 2018/9/5 下午1:42, Nikolay Borisov wrote: On 5.09.2018 05:10, Qu Wenruo wrote: > > > On 2018/8/16 下午9:10, Nikolay Boris

Re: [PATCH 5/8] btrfs-progs: Wire up delayed refs

On 2018/9/5 下午3:41, Nikolay Borisov wrote: > > > On 5.09.2018 08:53, Qu Wenruo wrote: >> >> >> On 2018/9/5 下午1:42, Nikolay Borisov wrote: >>> >>> >>> On 5.09.2018 05:10, Qu Wenruo wrote: On 2018/8/16 下午9:10, Nikolay Borisov wrote: > This commit enables the delayed refs inf

Re: [PATCH 1/4] btrfs-progs: print-tree: Skip deprecated blockptr / nodesize output

On 5.09.2018 09:29, Qu Wenruo wrote: > When printing tree nodes, we output slots like: > key (EXTENT_TREE ROOT_ITEM 0) block 73625600 (17975) gen 16 > > The number in the parentheses is blockptr / nodesize. > > However this number doesn't really do any thing useful. > And in fact for unaligne

Re: [PATCH 2/4] btrfs-progs: Replace root parameter using fs_info for reada_for_search()

On 5.09.2018 09:29, Qu Wenruo wrote: > As the @root parameter is only used to get @fs_info, use fs_info > directly instead. > > Signed-off-by: Qu Wenruo Reviewed-by: Nikolay Borisov > --- > cmds-restore.c | 4 ++-- > ctree.c| 11 +-- > ctree.h| 4 ++-- > 3 files

Re: [PATCH 5/8] btrfs-progs: Wire up delayed refs

On 5.09.2018 08:53, Qu Wenruo wrote: > > > On 2018/9/5 下午1:42, Nikolay Borisov wrote: >> >> >> On 5.09.2018 05:10, Qu Wenruo wrote: >>> >>> >>> On 2018/8/16 下午9:10, Nikolay Borisov wrote: This commit enables the delayed refs infrastructures. This entails doing the following: >