Re: [PATCH] btrfs/124: add balance --full-balance option

2017-12-05 Thread Eryu Guan
On Tue, Dec 05, 2017 at 04:30:33PM +0800, Qu Wenruo wrote: > > > On 2017年12月05日 16:26, Anand Jain wrote: > > btrfs balance needs --full-balance option since 4.6, so check the > > version and then use it. > > > > As this may be useful for other btrfs tests as well, so this patch > > adds _btrfs_f

Re: [PATCH v2] btrfs/154: test for device dynamic rescan

2017-11-14 Thread Eryu Guan
On Wed, Nov 15, 2017 at 11:05:15AM +0800, Anand Jain wrote: > Make sure missing device is included in the alloc list when it is > scanned on a mounted FS. > > This test case needs btrfs kernel patch which is in the ML > [PATCH] btrfs: handle dynamically reappearing missing device > Without the k

Re: [PATCH] btrfs/154: test for device dynamic rescan

2017-11-14 Thread Eryu Guan
On Mon, Nov 13, 2017 at 10:25:41AM +0800, Anand Jain wrote: > Make sure missing device is included in the alloc list when it is > scanned on a mounted FS. > > This test case needs btrfs kernel patch which is in the ML > [PATCH] btrfs: handle dynamically reappearing missing device > Without the k

Re: [PATCH] fstests: btrfs: add test case for raid6 reconstruction bug

2017-11-02 Thread Eryu Guan
On Wed, Nov 01, 2017 at 06:01:23PM -0600, Liu Bo wrote: > This is to reproduce a raid6 reconstruction bug after two drives > getting offline and online via hotplug. > > Signed-off-by: James Alandt > Signed-off-by: Liu Bo I don't have 5 deletable pool devices to actually test this patch, but jus

Re: [PATCH] xfstests: Add message indicating btrfs-progs support FST in read-only mode

2017-10-26 Thread Eryu Guan
On Thu, Oct 26, 2017 at 07:16:02AM +, Gu, Jinxiang wrote: > Hi, > > > -Original Message- > > From: Eryu Guan [mailto:eg...@redhat.com] > > Sent: Thursday, October 26, 2017 2:52 PM > > To: Gu, Jinxiang/顾 金香 > > Cc: fste...@vger.kernel.org; linux-b

Re: [PATCH] xfstests: Add message indicating btrfs-progs support FST in read-only mode

2017-10-25 Thread Eryu Guan
On Thu, Oct 26, 2017 at 01:57:46PM +0800, Gu Jinxiang wrote: > From: Gu JinXiang > > btrfs-progs now support FST in read-only mode, so when space_cache=v2 > enabled, this test case will fail. > Add message to help user to understand this status. Sorry, I don't quite understand the new 'FST' feat

Re: [PATCH v2] Fstest: btrfs/151: test if device delete ends up with losing raid profile

2017-10-13 Thread Eryu Guan
On Fri, Oct 13, 2017 at 01:40:05PM -0600, Liu Bo wrote: > Currently running 'btrfs device delete' can end up with losing data > raid profile (if any), this test is to reproduce the problem. > > The fix is > "Btrfs: avoid losing data raid profile when deleting a device" > > Signed-off-by: Liu

Re: [PATCH] Fstest: btrfs/151: test if device delete ends up with losing raid profile

2017-10-12 Thread Eryu Guan
On Mon, Oct 09, 2017 at 11:39:21AM -0600, Liu Bo wrote: > Currently running 'btrfs device delete' can end up with losing data raid > profile (if any), this test is to reproduce the problem. > > The fix is > "Btrfs: avoid losing data raid profile when deleting a device" > > Signed-off-by: Liu

Re: [ANNOUNCE] fsperf: a simple fs/block performance testing framework

2017-10-08 Thread Eryu Guan
On Mon, Oct 09, 2017 at 04:17:31PM +1100, Dave Chinner wrote: > On Sun, Oct 08, 2017 at 10:25:10PM -0400, Josef Bacik wrote: > > On Mon, Oct 09, 2017 at 11:51:37AM +1100, Dave Chinner wrote: > > > On Fri, Oct 06, 2017 at 05:09:57PM -0400, Josef Bacik wrote: > > > > Hello, > > > > > > > > One thing

Re: [PATCH v2] fstests: btrfs/150 regression test for reading compressed data

2017-09-27 Thread Eryu Guan
On Tue, Sep 26, 2017 at 05:18:51PM -0700, Liu Bo wrote: > On Tue, Sep 26, 2017 at 04:37:52PM -0700, Liu Bo wrote: > > On Tue, Sep 26, 2017 at 05:02:36PM +0800, Eryu Guan wrote: > > > On Fri, Sep 22, 2017 at 05:21:27PM -0600, Liu Bo wrote: > > > > We had a bug in btrf

Re: [PATCH v2] fstests: btrfs/150 regression test for reading compressed data

2017-09-26 Thread Eryu Guan
On Fri, Sep 22, 2017 at 05:21:27PM -0600, Liu Bo wrote: > We had a bug in btrfs compression code which could end up with a > kernel panic. > > This is adding a regression test for the bug and I've also sent a > kernel patch to fix the bug. > > The patch is "Btrfs: fix kernel oops while reading co

Re: [PATCH 1/2] xfstests: Split MOUNT_OPTIONS to TEST_FS_MOUNT_OPTS and MOUNT_OPTIONS

2017-09-22 Thread Eryu Guan
On Mon, Sep 18, 2017 at 04:11:09PM +0800, Gu Jinxiang wrote: > Resovle the inconsistent of mount option. > Btrfs use MOUNT_OPTIONS for both scrath_dev and test_dev. Change to > MOUNT_OPTIONS for scratch mount, and TEST_FS_MOUNT_OPTS for test dev > mount. > > Signed-off-by: Gu Jinxiang > --- > As

Re: [PATCH 1/2] Add new common filter function

2017-09-01 Thread Eryu Guan
On Fri, Sep 01, 2017 at 10:14:41AM +0300, Amir Goldstein wrote: > On Fri, Sep 1, 2017 at 10:04 AM, Eryu Guan wrote: > > On Fri, Sep 01, 2017 at 02:39:44PM +0900, Misono, Tomohiro wrote: > >> Several tests uses both _filter_test_dir and _filter_scratch > >> concatenated

Re: [PATCH 1/2] Add new common filter function

2017-09-01 Thread Eryu Guan
On Fri, Sep 01, 2017 at 02:39:44PM +0900, Misono, Tomohiro wrote: > Several tests uses both _filter_test_dir and _filter_scratch > concatenated by pipe to filter $TEST_DIR and $SCRATCH_MNT. However, this > would fail if the shorter string is a substring of the other (like > "/mnt" and "/mnt2"). >

Re: [PATCH] btrfs/029: fix wrong usage of name filter

2017-08-31 Thread Eryu Guan
On Fri, Sep 01, 2017 at 09:44:59AM +0900, Misono, Tomohiro wrote: > Ok. I will do that if you won't, though I'm not sure other combination of > filters would pose the similar problem. Thanks! Then I'll test :) Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the

Re: [PATCH] btrfs/029: fix wrong usage of name filter

2017-08-31 Thread Eryu Guan
On Thu, Aug 31, 2017 at 08:53:09AM +0900, Misono, Tomohiro wrote: > On 2017/08/30 20:09, Eryu Guan wrote: > > On Wed, Aug 30, 2017 at 04:38:16PM +0900, Misono, Tomohiro wrote: > >> btrfs/029 uses _filter_testdirs() to filter the name of $TEST_DIR and > >> $SCRATCH_MNT d

Re: [PATCH] btrfs/029: fix wrong usage of name filter

2017-08-30 Thread Eryu Guan
On Wed, Aug 30, 2017 at 04:38:16PM +0900, Misono, Tomohiro wrote: > btrfs/029 uses _filter_testdirs() to filter the name of $TEST_DIR and > $SCRATCH_MNT directory. > > In this function, it calls both _filter_test_dir and _filter_scratch > concatenated by pipe. Therefore if $TEST_DIR is a prefix of

Re: [PATCH] fstests: btrfs: enhance regression test for nocsum dio read's repair

2017-08-15 Thread Eryu Guan
On Mon, Aug 14, 2017 at 03:03:13PM +0800, Lu Fengqi wrote: > I catch this following error from dmesg when this testcase fails. > > [17446.661127] Buffer I/O error on dev sdb1, logical block 64, async page read > > We expect to inject disk IO errors on the device when xfs_io reads the > specific f

Re: [PATCH] btrfs: test if receive with qgroups corrupts metadata

2017-07-20 Thread Eryu Guan
On Thu, Jul 20, 2017 at 04:03:33PM -0700, Justin Maggard wrote: > This test case does some concurrent send/receives with qgroups enabled. > Currently (4.13-rc1) this usually results in btrfs check errors, and > often also results in a WARN_ON in record_root_in_trans(). > > Bisecting points to 6426

Re: [PATCH] btrfs: test direct IO write against raid5/6 filesystems

2017-07-13 Thread Eryu Guan
On Thu, Jul 13, 2017 at 03:10:40PM +0100, fdman...@kernel.org wrote: > From: Filipe Manana > > Test that a direct IO write works against raid5/6 filesystems and that > after the write operation we are able to read back the correct data > and scrub operations don't find any errors. > > This test

Re: [PATCH v2] btrfs/146: Test various btrfs operations rounding behavior

2017-07-06 Thread Eryu Guan
On Fri, Jun 23, 2017 at 04:25:43PM +0800, Eryu Guan wrote: > On Wed, Jun 21, 2017 at 10:50:35AM +0300, Nikolay Borisov wrote: > > When changing the size of disks/filesystem we should always be > > rounding down to a multiple of sectorsize > > > > Signed-off-by: Nikol

Re: [PATCH v2] btrfs/146: Test various btrfs operations rounding behavior

2017-06-23 Thread Eryu Guan
On Wed, Jun 21, 2017 at 10:50:35AM +0300, Nikolay Borisov wrote: > When changing the size of disks/filesystem we should always be > rounding down to a multiple of sectorsize > > Signed-off-by: Nikolay Borisov Thanks for the update! But I still need some reviews from btrfs list to see if this is

Re: [PATCH] btrfs/145: Test various btrfs operations rounding behavior

2017-06-15 Thread Eryu Guan
On Thu, Jun 15, 2017 at 04:45:38PM +0300, Nikolay Borisov wrote: > When changing the size of disks/filesystem we should always be > rounding down to a multiple of sectorsize. This is a test for the following > btrfs patche: > > btrfs: Round up values which are written for total_bytes_size > > Si

Re: [xfstests PATCH v4 5/5] btrfs: make a btrfs version of writeback error reporting test

2017-06-14 Thread Eryu Guan
On Wed, Jun 14, 2017 at 07:55:17AM -0400, Jeff Layton wrote: > On Tue, 2017-06-13 at 16:40 +0800, Eryu Guan wrote: > > On Mon, Jun 12, 2017 at 08:42:13AM -0400, Jeff Layton wrote: > > > Make a new btrfs/999 test that works the way Chris Mason suggested: > > > >

Re: [xfstests PATCH v4 5/5] btrfs: make a btrfs version of writeback error reporting test

2017-06-13 Thread Eryu Guan
On Mon, Jun 12, 2017 at 08:42:13AM -0400, Jeff Layton wrote: > Make a new btrfs/999 test that works the way Chris Mason suggested: > > Build a filesystem with 2 devices that stripes the data across > both devices, but mirrors metadata across both. Then, make one > of the devices fail and see how f

Re: [xfstests PATCH v4 2/5] ext4: allow ext4 to use $SCRATCH_LOGDEV

2017-06-13 Thread Eryu Guan
On Mon, Jun 12, 2017 at 08:42:10AM -0400, Jeff Layton wrote: > The writeback error handling test requires that you put the journal on a > separate device. This allows us to use dmerror to simulate data > writeback failure, without affecting the journal. > > xfs already has infrastructure for this

Re: [xfstests PATCH v4 1/5] generic: add a writeback error handling test

2017-06-13 Thread Eryu Guan
On Mon, Jun 12, 2017 at 08:42:09AM -0400, Jeff Layton wrote: > I'm working on a set of kernel patches to change how writeback errors > are handled and reported in the kernel. Instead of reporting a > writeback error to only the first fsync caller on the file, I aim > to make the kernel report them

Re: [xfstests PATCH v4 0/5] new tests for writeback error reporting behavior

2017-06-13 Thread Eryu Guan
On Mon, Jun 12, 2017 at 08:42:08AM -0400, Jeff Layton wrote: > v4: respin set based on Eryu's comments > > These tests are companion tests to the patchset I recently posted with > the cover letter: > > [PATCH v6 00/20] fs: enhanced writeback error reporting with errseq_t > (pile #1) > > Thi

Re: [PATCH] btrfs: test Btrfs delalloc accounting overflow

2017-06-07 Thread Eryu Guan
On Wed, Jun 07, 2017 at 10:34:13AM -0700, Omar Sandoval wrote: > On Wed, Jun 07, 2017 at 05:36:45PM +0800, Eryu Guan wrote: > > On Tue, Jun 06, 2017 at 11:57:10PM -0700, Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > This is a regression t

Re: [PATCH] btrfs: test Btrfs delalloc accounting overflow

2017-06-07 Thread Eryu Guan
On Tue, Jun 06, 2017 at 11:57:10PM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > This is a regression test for "[PATCH] Btrfs: fix delalloc accounting > leak caused by u32 overflow". It creates a bunch of delalloc extents and > merges them together to make sure the accounting is done righ

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-06 Thread Eryu Guan
On Tue, Jun 06, 2017 at 05:03:05PM -0700, Omar Sandoval wrote: > On Sat, Jun 03, 2017 at 12:37:00AM -0700, Christoph Hellwig wrote: > > This looks like a btrfs-specific test, and not like a generic one > > to me. > > Nothing about the workload itself is btrfs-specific, we just have the > extra che

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-03 Thread Eryu Guan
On Fri, Jun 02, 2017 at 02:46:52PM +0200, David Sterba wrote: > On Fri, Jun 02, 2017 at 12:07:37PM +0300, Nikolay Borisov wrote: > > > +# Make sure that we didn't leak any metadata space. > > > +if [[ $FSTYP = btrfs ]]; then > > > + uuid="$(findmnt -n -o UUID "$TEST_DIR")" > > > > if we are on btr

Re: [PATCH] fstests: common: Make _test_mount to include MOUNT_OPTIONS to allow consistent _test_cycle_mount

2017-05-24 Thread Eryu Guan
On Wed, May 24, 2017 at 05:27:24PM +0800, Qu Wenruo wrote: > > > At 05/24/2017 05:22 PM, Eryu Guan wrote: > > On Wed, May 24, 2017 at 03:58:11PM +0800, Qu Wenruo wrote: > > > > > > > > > At 05/24/2017 01:16 PM, Qu Wenruo wrote: > > > > &g

Re: [PATCH] fstests: common: Make _test_mount to include MOUNT_OPTIONS to allow consistent _test_cycle_mount

2017-05-24 Thread Eryu Guan
On Wed, May 24, 2017 at 03:58:11PM +0800, Qu Wenruo wrote: > > > At 05/24/2017 01:16 PM, Qu Wenruo wrote: > > > > > > At 05/24/2017 01:08 PM, Eryu Guan wrote: > > > On Wed, May 24, 2017 at 12:28:34PM +0800, Qu Wenruo wrote: > > > > > >

Re: [PATCH] fstests: common: Make _test_mount to include MOUNT_OPTIONS to allow consistent _test_cycle_mount

2017-05-23 Thread Eryu Guan
On Wed, May 24, 2017 at 12:28:34PM +0800, Qu Wenruo wrote: > > > At 05/24/2017 12:24 PM, Eryu Guan wrote: > > On Wed, May 24, 2017 at 08:22:25AM +0800, Qu Wenruo wrote: > > > > > > > > > At 05/23/2017 07:13 PM, Eryu Guan wrote: > > > > On

Re: [PATCH] fstests: common: Make _test_mount to include MOUNT_OPTIONS to allow consistent _test_cycle_mount

2017-05-23 Thread Eryu Guan
On Wed, May 24, 2017 at 08:22:25AM +0800, Qu Wenruo wrote: > > > At 05/23/2017 07:13 PM, Eryu Guan wrote: > > On Tue, May 23, 2017 at 04:02:05PM +0800, Qu Wenruo wrote: > > > [BUG] > > > If using MOUNT_OPTIONS="-o nodatasum" and btrfs to run genierc/142

Re: [PATCH] fstests: common: Make _test_mount to include MOUNT_OPTIONS to allow consistent _test_cycle_mount

2017-05-23 Thread Eryu Guan
On Tue, May 23, 2017 at 04:02:05PM +0800, Qu Wenruo wrote: > [BUG] > If using MOUNT_OPTIONS="-o nodatasum" and btrfs to run genierc/142 > generic/143 and generic/154, it will cause false alert like: > cp: failed to clone '/mnt/test/test-154/file2' from > '/mnt/test/test-154/file1': Invalid argumen

Re: [PATCH 6/6] fstests: regression test for nocsum buffered read's repair

2017-05-10 Thread Eryu Guan
On Tue, May 09, 2017 at 11:56:11AM -0600, Liu Bo wrote: > This is to test whether buffered read retry-repair code is able to work in > raid1 case as expected. > > Please note that without checksum, btrfs doesn't know if the data used to > repair is correct, so repair is more of resync which makes

Re: [PATCH 3/6] fstests: regression test for btrfs dio read repair

2017-05-10 Thread Eryu Guan
On Tue, May 09, 2017 at 11:56:08AM -0600, Liu Bo wrote: > This case tests whether dio read can repair the bad copy if we have > a good copy. > > Commit 2dabb3248453 ("Btrfs: Direct I/O read: Work on sectorsized blocks") > introduced the regression. > > The upstream fix is > Btrfs: fix inval

Re: [PATCH 2/6] fstests: add _get_current_dmesg

2017-05-10 Thread Eryu Guan
On Tue, May 09, 2017 at 11:56:07AM -0600, Liu Bo wrote: > _get_current_dmesg can be used to grep customized pattern. > > Signed-off-by: Liu Bo I can't apply this patch on top of current master, perhaps it needs a rebase :) > --- > common/rc | 9 +++-- > 1 file changed, 7 insertions(+), 2 d

Re: [PATCH v3] fstests: regression test for btrfs dio read repair

2017-05-03 Thread Eryu Guan
On Fri, Apr 28, 2017 at 11:25:52AM -0600, Liu Bo wrote: > This case tests whether dio read can repair the bad copy if we have > a good copy. > > Commit 2dabb3248453 ("Btrfs: Direct I/O read: Work on sectorsized blocks") > introduced the regression. > > The upstream fix is > Btrfs: fix inval

Re: [PATCH] fstests: introduce btrfs-map-logical

2017-04-12 Thread Eryu Guan
On Wed, Apr 12, 2017 at 02:52:23PM +0200, David Sterba wrote: > > > I understand that we need to do corruption so that we can test if the > > > repair works, but I'm not sure if the output format will change, or if > > > the program will get replace by "btrfs inspect-internal" group. > > > > In

Re: Does btrfs get nlink on directories wrong? -- was Re: [PATCH 2/4] xfstests: Add first statx test [ver #5]

2017-04-08 Thread Eryu Guan
On Wed, Apr 05, 2017 at 03:32:30PM +0300, Amir Goldstein wrote: > On Wed, Apr 5, 2017 at 3:30 PM, David Sterba wrote: > > On Wed, Apr 05, 2017 at 11:53:41AM +0100, David Howells wrote: > >> I've added a test to xfstests that exercises the new statx syscall. > >> However, > >> it fails on btrfs:

Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags

2017-04-07 Thread Eryu Guan
On Fri, Apr 07, 2017 at 10:13:09AM +0100, Filipe Manana wrote: > On Fri, Apr 7, 2017 at 9:51 AM, Eryu Guan wrote: > > On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdman...@kernel.org wrote: > >> From: Filipe Manana > >> > >> For example NFS 4.2 supports f

Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags

2017-04-07 Thread Eryu Guan
t. > > Suggested-by: Eryu Guan > Signed-off-by: Filipe Manana > --- > common/rc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/rc b/common/rc > index e1ab2c6..3d0f089 100644 > --- a/common/rc > +++ b/common/rc > @@ -202

Re: [PATCH] fstests: generic: Check if cycle mount and sleep can affect fiemap result

2017-04-06 Thread Eryu Guan
On Thu, Apr 06, 2017 at 11:28:01AM -0500, Eric Sandeen wrote: > On 4/6/17 11:26 AM, Theodore Ts'o wrote: > > On Wed, Apr 05, 2017 at 10:35:26AM +0800, Eryu Guan wrote: > >> > >> Test fails with ext3/2 when driving with ext4 driver, fiemap changed > >> after

Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags

2017-04-06 Thread Eryu Guan
t. > > Suggested-by: Eryu Guan > Signed-off-by: Filipe Manana > --- > common/rc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/rc b/common/rc > index e1ab2c6..3d0f089 100644 > --- a/common/rc > +++ b/common/rc > @@ -202

Re: [PATCH] generic: test for number of bytes used by files after buffered writes

2017-04-05 Thread Eryu Guan
On Wed, Apr 05, 2017 at 11:13:56AM +0100, Filipe Manana wrote: > On Wed, Apr 5, 2017 at 10:46 AM, Eryu Guan wrote: > > On Tue, Apr 04, 2017 at 03:23:35AM +0100, fdman...@kernel.org wrote: > >> From: Filipe Manana > >> > >> Test that a filesystem's

Re: [PATCH] generic: test for number of bytes used by files after buffered writes

2017-04-05 Thread Eryu Guan
On Tue, Apr 04, 2017 at 03:23:35AM +0100, fdman...@kernel.org wrote: > From: Filipe Manana > > Test that a filesystem's implementation of the stat(2) system call > reports correct values for the number of blocks allocated for a file > when there are delayed allocations. > > This test is motivate

Re: [PATCH] fstests: generic: Check if cycle mount and sleep can affect fiemap result

2017-04-04 Thread Eryu Guan
On Mon, Apr 03, 2017 at 03:09:23PM +0800, Qu Wenruo wrote: > As long as we don't modify the on-disk data, fiemap result should always > be constant. > > Operation like cycle mount and sleep should not affect fiemap result. > While unfortunately, btrfs doesn't follow that behavior. > > Btrfs fiema

Re: [PATCH] fstests: btrfs: Check if btrfs will create inline-then-regular file extents

2017-04-04 Thread Eryu Guan
On Mon, Apr 03, 2017 at 11:01:39AM +0800, Qu Wenruo wrote: > Btrfs allows inline file extent if and only if > 1) It's at offset 0 > 2) It's smaller than min(max_inline, page_size) >Although we don't specify if the size is before compression or after >compression. >At least according to

Re: [PATCH v2 3/3] fstests: btrfs: Test inband dedupe with data balance.

2017-03-21 Thread Eryu Guan
On Thu, Mar 16, 2017 at 05:08:51PM +0800, Qu Wenruo wrote: > Btrfs balance will reloate date extent, but its hash is removed too late ^^^ relocate > at run_delayed_ref() time, which will cause extent ref increased > during balance, cause either find_data_references() gives

Re: [PATCH 0/3] Btrfs in-band de-duplication test cases

2017-03-21 Thread Eryu Guan
On Tue, Mar 21, 2017 at 03:36:54PM +0800, Qu Wenruo wrote: > > > At 03/21/2017 03:23 PM, Eryu Guan wrote: > > On Thu, Mar 16, 2017 at 09:50:24AM +0800, Qu Wenruo wrote: > > > Btrfs in-band de-duplication test cases for in-memory backend, which > > > covers

Re: [PATCH 0/3] Btrfs in-band de-duplication test cases

2017-03-21 Thread Eryu Guan
On Thu, Mar 16, 2017 at 09:50:24AM +0800, Qu Wenruo wrote: > Btrfs in-band de-duplication test cases for in-memory backend, which covers > the bugs exposed during the development. Sorry, I'm having trouble enabling inband dedupe in tests, I always get ioctl failure, $seqres.full shows: btrfs-prog

Re: [PATCH v2 0/3] Btrfs in-band de-duplication test cases

2017-03-20 Thread Eryu Guan
On Tue, Mar 21, 2017 at 01:22:33PM +0800, Qu Wenruo wrote: > > > At 03/21/2017 12:51 PM, Eryu Guan wrote: > > Hi Qu, > > > > On Thu, Mar 16, 2017 at 05:08:48PM +0800, Qu Wenruo wrote: > > > Btrfs in-band de-duplication test cases for in-memory backend, which

Re: [PATCH v2 0/3] Btrfs in-band de-duplication test cases

2017-03-20 Thread Eryu Guan
Hi Qu, On Thu, Mar 16, 2017 at 05:08:48PM +0800, Qu Wenruo wrote: > Btrfs in-band de-duplication test cases for in-memory backend, which covers > the bugs exposed during the development. Do you have a kernel tree that contains the in-band patches so that I and others could try and run these tests

Re: [PATCH 2/3] fstests: btrfs: Add testcase for btrfs dedupe and metadata balance race test

2017-03-16 Thread Eryu Guan
On Thu, Mar 16, 2017 at 09:50:27AM +0800, Qu Wenruo wrote: > Btrfs balance with inband dedupe enable/disable will expose a lot of > hidden dedupe bug: > > 1) Enable/disable race bug > 2) Btrfs dedupe tree balance corrupted delayed_ref > 3) Btrfs disable and balance will cause balance BUG_ON > > R

Re: [PATCH 1/3] fstests: btrfs: Add basic test for btrfs in-band de-duplication

2017-03-16 Thread Eryu Guan
On Thu, Mar 16, 2017 at 09:50:25AM +0800, Qu Wenruo wrote: > Add basic test for btrfs in-band de-duplication(inmemory backend), including: > 1) Enable > 3) Dedup rate > 4) File correctness > 5) Disable > > Signed-off-by: Qu Wenruo I haven't looked into this patchset closely, this may need more h

Re: [PATCH] fstests: generic: Test space allocation when there is only fragmented space

2017-03-14 Thread Eryu Guan
On Wed, Mar 15, 2017 at 11:01:05AM +0800, Qu Wenruo wrote: > Any comment on this patch? It's already committed, see commit 726726d. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] btrfs/139: creation/deletion within qgroup limits

2017-03-13 Thread Eryu Guan
[please cc linux-btrfs@vger.kernel.org for btrfs specific tests] On Mon, Mar 13, 2017 at 04:37:16PM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > If we create and delete files within the qgroup limits, qg->reserved > (allocations before commits) over-inflates and causes -EDQUOT t

Re: [PATCH 3/4] reflink: test adjacency of reflinked blocks

2017-02-28 Thread Eryu Guan
On Tue, Feb 28, 2017 at 08:31:50AM -0800, Darrick J. Wong wrote: > On Tue, Feb 28, 2017 at 04:15:02PM +0800, Eryu Guan wrote: > > On Fri, Feb 24, 2017 at 05:12:57PM -0800, Darrick J. Wong wrote: > > > From: Darrick J. Wong > > > > > > If we reflink a file wit

Re: [PATCH 3/4] reflink: test adjacency of reflinked blocks

2017-02-28 Thread Eryu Guan
On Fri, Feb 24, 2017 at 05:12:57PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > If we reflink a file with N blocks to another file one block at a time, > does the destination file end up with the same number of extents as the > source file? In other words, does the filesystem succee

Re: [PATCH 2/2] btrfs: test decompression in the middle of large extents

2017-02-16 Thread Eryu Guan
On Thu, Feb 16, 2017 at 06:32:49PM -0800, Omar Sandoval wrote: > From: Omar Sandoval > > This is a regression test for "Btrfs: fix btrfs_decompress_buf2page()". > It fails for zlib on v4.10-rc[1-7]. > > Signed-off-by: Omar Sandoval > --- > This runs in <60 seconds on my test VM, which I think q

Re: [PATCH] fstests: btrfs: Use compressible data

2017-02-05 Thread Eryu Guan
On Wed, Feb 01, 2017 at 09:50:28PM +0800, Anand Jain wrote: > /dev/urandom is incompressible and, /dev/zero is highly compressible, > so both are less effective in testing the compress code logic in btrfs. > > This patch introduces a text data generator > cat /dev/urandom | od I noticed that the

Re: [PATCH] btrfs: add regression test for setxattr on subvolume directory

2017-01-25 Thread Eryu Guan
On Wed, Jan 25, 2017 at 05:30:32PM +0800, Qu Wenruo wrote: > > > At 01/25/2017 05:20 PM, Eryu Guan wrote: > > On Tue, Jan 24, 2017 at 10:50:29PM -0800, Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > This is a regression test for "Btr

Re: [PATCH] btrfs: add regression test for setxattr on subvolume directory

2017-01-25 Thread Eryu Guan
On Tue, Jan 24, 2017 at 10:50:29PM -0800, Omar Sandoval wrote: > From: Omar Sandoval > > This is a regression test for "Btrfs: disable xattr operations on > subvolume directories". On v4.9, it will result in an aborted > transaction. > > Signed-off-by: Omar Sandoval Looks good to me overall, t

Re: [PATCH v4 2/3] fstests: test btrfs incremental send after moving a directory

2017-01-19 Thread Eryu Guan
On Thu, Jan 12, 2017 at 03:13:37AM +, fdman...@kernel.org wrote: > From: Filipe Manana > > Test that an incremental send operation works after moving a directory > into a new parent directory, deleting its previous parent directory and > creating a new inode that has the same inode number as

Re: [PATCH] xfstests: btrfs/047: check btrfs-convert with extent and non-extent source

2017-01-17 Thread Eryu Guan
On Wed, Jan 18, 2017 at 07:17:02AM +0530, Lakshmipathi.G wrote: > Signed-off-by: Lakshmipathi.G Need detailed test description in commit log too. > --- > tests/btrfs/047 | 108 > > tests/btrfs/047.out | 1 + > tests/btrfs/group | 1

Re: [PATCH] fstests: generic: splitted large dio write could trigger assertion on btrfs

2017-01-15 Thread Eryu Guan
On Thu, Jan 12, 2017 at 02:22:06PM -0800, Liu Bo wrote: > On btrfs, if a large dio write (>=128MB) got splitted, the outstanding_extents > assertion would complain. Note that CONFIG_BTRFS_ASSERT is required. > > Regression test for > Btrfs: adjust outstanding_extents counter properly when dio w

Re: [PATCH] fstests: Fix inconsistent xfs_io error report caused false alert

2017-01-04 Thread Eryu Guan
On Wed, Jan 04, 2017 at 04:37:08PM +0800, Qu Wenruo wrote: > Test case like generic/304 and generic/158 can cause false alert due to > the error output change of xfs_io. > > For error case, xfs_io mostly reports error like "dedupe: ERROR STRING" > while under certain case, it reports error like "X

Re: [PATCH v2] fstests: btrfs/006: Fix false alert due to output change

2017-01-02 Thread Eryu Guan
On Mon, Jan 02, 2017 at 10:16:17PM -0500, Su Yue wrote: > Btrfs-progs v4.9 changed "device status" output by adding one more > space, which differs from golden output. > Fix it by using filter '_filter_spaces' to convert multi space into one. You missed your SOB line. I added Signed-off-by: Su Yu

Re: [PATCH 2/2] fstests: btrfs/006: Fix false alert due to output change

2016-12-29 Thread Eryu Guan
On Thu, Dec 29, 2016 at 11:14:10PM -0500, Su Yue wrote: > Btrfs-progs v4.9 changed "device status" output by adding one more > space, which differs from golden output. > > Fix it by introducing new filter to convert multi space into one. > > Signed-off-by: Su Yue > --- > common/filter |

Re: [PATCH] fstests: btrfs: Test scrub and replace race for RAID56

2016-12-24 Thread Eryu Guan
On Thu, Dec 22, 2016 at 10:02:51AM +0800, Qu Wenruo wrote: > Although by design, btrfs scrub and replace share the same code path, so > they are exclusive to each other. > > But the fact is, there is still some critical region not protected well, > so we can have the following kernel panic, especi

Re: [PATCH] fstests: btrfs: Remove btrfs/047 since upstream don't accept stream-version

2016-12-20 Thread Eryu Guan
On Tue, Dec 20, 2016 at 09:24:56AM +0800, Qu Wenruo wrote: > Btrfs upstream doesn't accept stream-version, so the test is never ran > on upstream kernel nor btrfs-progs. > > Just remove it. > > Signed-off-by: Qu Wenruo Looks fine to me, but I'd like to see an ack or review from btrfs developers

Re: [PATCH v2 2/2] fstests: btrfs: Use _require_btrfs_qgroup_report to replace open code

2016-12-08 Thread Eryu Guan
On Thu, Dec 08, 2016 at 05:20:49PM +0800, Qu Wenruo wrote: > > > At 12/08/2016 04:47 PM, Eryu Guan wrote: > > On Thu, Dec 08, 2016 at 04:12:13PM +0800, Qu Wenruo wrote: > > > Introduce new _require_btrfs_qgroup_report function, which will check > > > the acces

Re: [PATCH v2 2/2] fstests: btrfs: Use _require_btrfs_qgroup_report to replace open code

2016-12-08 Thread Eryu Guan
On Thu, Dec 08, 2016 at 04:12:13PM +0800, Qu Wenruo wrote: > Introduce new _require_btrfs_qgroup_report function, which will check > the accessibility to "btrfs check --qgroup-report", then set a global > flag to info _check_scratch_fs() to do extra qgroup check. > > Signed-off-by: Qu Wenruo > --

Re: [PATCH 2/2] fstests: btrfs: Use _require_btrfs_qgroup_report to replace open code

2016-12-07 Thread Eryu Guan
On Thu, Dec 08, 2016 at 10:04:56AM +0800, Qu Wenruo wrote: > Introduce new _require_btrfs_qgroup_report function, which will check > the accessibility to "btrfs check --qgroup-report", then set a global > flag to info _check_scratch_fs() to do extra qgroup check. > > Signed-off-by: Qu Wenruo > --

Re: [PATCH 1/2] fstests: common: rename and enhance _require_btrfs to _require_btrfs_subcommand

2016-12-07 Thread Eryu Guan
On Thu, Dec 08, 2016 at 10:04:55AM +0800, Qu Wenruo wrote: > Rename _require_btrfs() to _require_btrfs_subcommand() to avoid > confusion, as all other _require_btrfs_* has a quite clear suffix, like > _require_btrfs_mkfs_feature() or _require_btrfs_fs_feature(). > > Also enhance _require_btrfs_sub

Re: [RFC PATCH 0/3] Add testcase for fundamental scrub recovery

2016-12-04 Thread Eryu Guan
On Tue, Nov 22, 2016 at 04:38:08PM +0800, Qu Wenruo wrote: > Despite the scrub test cases in fstests, there is not even one test case > which really checked if scrub can recover data. > > In fact, btrfs scrub for RAID56 will even corrupt correct data stripes. > > So let's start from the needed fa

Re: [RFC PATCH 1/3] fstests: common: rename _require_btrfs to _require_btrfs_subcommand

2016-12-04 Thread Eryu Guan
On Tue, Nov 22, 2016 at 04:38:09PM +0800, Qu Wenruo wrote: > Rename _require_btrfs() to _require_btrfs_subcommand() to avoid > confusion, as all other _require_btrfs_* has a quite clear suffix, like > _require_btrfs_mkfs_feature() or _require_btrfs_fs_feature(). > > Signed-off-by: Qu Wenruo > ---

Re: [PATCH 01/10] fstests: common: Introduce function to check qgroup correctness

2016-11-29 Thread Eryu Guan
On Tue, Nov 29, 2016 at 03:32:54PM +0800, Qu Wenruo wrote: > Old btrfs qgroup test cases uses fix golden output numbers, which limits > the coverage since they can't handle mount options like compress or > inode_map, and cause false alert. > > Introduce _btrfs_check_scratch_qgroup() function to ch

Re: [RFC PATCH 0/3] Add testcase for fundamental scrub recovery

2016-11-27 Thread Eryu Guan
On Mon, Nov 28, 2016 at 10:50:30AM +0800, Qu Wenruo wrote: > Any comment? Sorry for the late review, I'm planning to look at them this week. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] fstests: Introduce check for explicit SHARED extent flag reporting

2016-11-17 Thread Eryu Guan
On Thu, Nov 17, 2016 at 10:06:48AM +0800, Qu Wenruo wrote: > For fs support reflink, some of them (OK, btrfs again) doesn't split > SHARED flag for extent fiemap reporting. > > For example: > 0 4K 8K >/ File1: Extent 0 \ > /\ > |<- On disk Extent-->|

Re: [PATCH] generic: test concurrent non-overlapping direct I/O on the same extents

2016-11-17 Thread Eryu Guan
On Thu, Nov 17, 2016 at 10:14:12AM -0800, Omar Sandoval wrote: > On Thu, Nov 17, 2016 at 01:26:11PM +0800, Eryu Guan wrote: > > On Wed, Nov 16, 2016 at 04:29:34PM -0800, Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > There have been a coupl

Re: [PATCH] generic: test concurrent non-overlapping direct I/O on the same extents

2016-11-16 Thread Eryu Guan
On Wed, Nov 16, 2016 at 04:29:34PM -0800, Omar Sandoval wrote: > From: Omar Sandoval > > There have been a couple of logic bugs in `btrfs_get_extent()` which > could lead to spurious -EEXIST errors from read or write. This test > exercises those conditions by having two threads race to add an ext

Re: [PATCH] fstests: generic/098 update test for truncating a file into the middle of a hole

2016-11-14 Thread Eryu Guan
On Fri, Nov 11, 2016 at 02:30:04PM -0800, Liu Bo wrote: > This updates generic/098 by adding a sync option, i.e. 'sync' after the second > write, and with btrfs's NO_HOLES, we could still get wrong isize after > remount. > > This gets fixed by the patch > > 'Btrfs: fix truncate down when no_hole

Re: [PATCH] fstests: btrfs: Check false ENOSPC bug caused by incorrect metadata reserve

2016-11-09 Thread Eryu Guan
On Thu, Nov 10, 2016 at 10:42:36AM +0800, Qu Wenruo wrote: > > > At 11/10/2016 10:19 AM, Dave Chinner wrote: > > On Thu, Nov 10, 2016 at 08:34:20AM +0800, Qu Wenruo wrote: > > > At 11/09/2016 05:43 PM, Eryu Guan wrote: > > > > On Wed, Nov 09, 2016

Re: [PATCH] fstests: btrfs: Check false ENOSPC bug caused by incorrect metadata reserve

2016-11-09 Thread Eryu Guan
On Wed, Nov 09, 2016 at 08:24:38AM +0800, Qu Wenruo wrote: > > > At 11/08/2016 06:58 PM, Eryu Guan wrote: > > On Tue, Nov 08, 2016 at 05:15:15PM +0800, Qu Wenruo wrote: > > > Due to the fact that btrfs uses different max extent size for > > > compressed and no

Re: [PATCH] fstests: btrfs: Check false ENOSPC bug caused by incorrect metadata reserve

2016-11-08 Thread Eryu Guan
On Tue, Nov 08, 2016 at 05:15:15PM +0800, Qu Wenruo wrote: > Due to the fact that btrfs uses different max extent size for > compressed and non-compressed write, it calculates metadata reservation > incorrectly. > > This can leads to false ENOSPC alert for compressed write. > > This test case wil

Re: [PATCH v5 1/2] common/populate: use _require_xfs_io_command() in right place

2016-11-05 Thread Eryu Guan
On Wed, Nov 02, 2016 at 12:07:26PM +0800, Wang Xiaoguang wrote: > In original common/populate codes, we put _require_xfs_io_command "falloc" and > _require_xfs_io_command "fpunch" in the begin of common/populate, but it's > not appropriate, for fs, which does not support falloc and punch, will not

Re: [PATCH] generic: create and delete files repeatedly to exercise ENOSPC behaviour

2016-11-02 Thread Eryu Guan
On Wed, Nov 02, 2016 at 06:22:58PM +0800, Wang Xiaoguang wrote: > hi Eryu, > > There has already be a generic/102 doing this test... > Thanks for you kindly review and sorry for wasting your time. I had impression yesterday that we have a case that does exactly the same test, and I searched but d

Re: [PATCH] generic: create and delete files repeatedly to exercise ENOSPC behaviour

2016-11-01 Thread Eryu Guan
On Tue, Nov 01, 2016 at 07:19:30PM +0800, Wang Xiaoguang wrote: > In btrfs, sometimes though the number of created files' consumed disk space > are not larger than fs's free space, we can still get some ENOSPC error, it > may be that btrfs does not try hard to reclaim disk space(I have sent kernel

Re: [PATCH v2 4/4] xfstests: btrfs/134: add test for incremental send which renames a directory already being deleted

2016-11-01 Thread Eryu Guan
On Fri, Oct 28, 2016 at 09:44:06AM +0800, robbieko wrote: > From: Robbie Ko > > Test that an incremental send operation dosen't work because > it tries to rename a directory which is already deleted. > > This test exercises scenarios used to fail in btrfs and are fixed by > the following patch f

Re: [PATCH v2 1/4] xfstests: btrfs/131: add test for an incremental send with name collision

2016-11-01 Thread Eryu Guan
On Fri, Oct 28, 2016 at 09:44:03AM +0800, robbieko wrote: > From: Robbie Ko > > Test that an incremental send operation doesn't work because > there's a name collision in the destination and it's not checked > corretly before the rename operation applies. > > This test exercises scenarios used t

Re: [PATCH v3] generic: make 17[1-4] work well when btrfs compression is enabled

2016-10-28 Thread Eryu Guan
On Fri, Oct 28, 2016 at 03:05:55PM +0800, Wang Xiaoguang wrote: > hi, > > On 10/27/2016 07:25 PM, Eryu Guan wrote: > > On Wed, Oct 26, 2016 at 05:52:11PM +0800, Wang Xiaoguang wrote: > > > When enabling btrfs compression, original codes can not fill fs > > > corr

Re: [PATCH v3] generic: make 17[1-4] work well when btrfs compression is enabled

2016-10-28 Thread Eryu Guan
On Fri, Oct 28, 2016 at 03:00:29PM +0800, Wang Xiaoguang wrote: > hi, > > On 10/28/2016 01:13 AM, Darrick J. Wong wrote: > > On Wed, Oct 26, 2016 at 05:52:11PM +0800, Wang Xiaoguang wrote: > > > When enabling btrfs compression, original codes can not fill fs > > > correctly, here we introduce _fil

Re: [PATCH v3] generic: make 17[1-4] work well when btrfs compression is enabled

2016-10-27 Thread Eryu Guan
On Wed, Oct 26, 2016 at 05:52:11PM +0800, Wang Xiaoguang wrote: > When enabling btrfs compression, original codes can not fill fs > correctly, here we introduce _fill_fs() in common/rc, which'll keep > creating and writing files until enospc error occurs. Note _fill_fs > is copied from tests/generi

Re: [PATCH] btrfs: test free space tree mount options

2016-09-22 Thread Eryu Guan
On Thu, Sep 22, 2016 at 12:37:53PM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > The behavior of different combinations of space_cache mount options > wasn't well defined, which led to a regression between my initial > patches adding the free space tree and the 4.5 release. Add a test to

Re: [PATCH] tests/btrfs: test snapshot/subvol create/destroy ioctls with a regular file

2016-09-22 Thread Eryu Guan
On Wed, Sep 21, 2016 at 08:32:33AM -0400, je...@suse.com wrote: > From: Jeff Mahoney > > There was a bug where the btrfs snapshot/subvol creation ioctls > would accept a regular file and then Oops when it tried to use > the file inode operations to do a lookup. > > This also adds an ioctl-helper

Re: [PATCH v3] generic: check whether we can truncate heavily reflinked file

2016-09-22 Thread Eryu Guan
On Fri, Sep 23, 2016 at 11:12:07AM +0800, Wang Xiaoguang wrote: > In btrfs, there is a bug about btrfs' truncate codes, it'll leak > some fs space as the truncate operation proceeds. If this truncate > operation is very large, later metadata request in this truncate > operation may fail for enospc

<    1   2   3   4   5   >