Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-12 Thread Martin Steigerwald
Hi Goffredo, Bart, Hugo, Am Dienstag, 9. Oktober 2012 schrieb Goffredo Baroncelli: On 10/09/2012 02:51 PM, Bart Noordervliet wrote: On Tue, Oct 9, 2012 at 1:38 PM, Goffredo Baroncellikreij...@gmail.com wrote: Hi Bart, I replayed in another email to Hugo about that. Basically I am not

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-12 Thread Martin Steigerwald
Am Mittwoch, 3. Oktober 2012 schrieb Ilya Dryomov: $ ./btrfs filesystem df / Path: / Summary: Disk_size: 72.57GB Disk_allocated:25.10GB Disk_unallocated: 47.48GB Logical_size: 23.06GB Used: 11.01GB

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-12 Thread Martin Steigerwald
Am Mittwoch, 3. Oktober 2012 schrieb Ilya Dryomov: On Wed, Oct 03, 2012 at 06:46:00PM +0200, Goffredo Baroncelli wrote: On 10/03/2012 05:01 PM, Ilya Dryomov wrote: Type for the first column is probably enough. Why is the third column called Chunk-size? If my understanding is correct,

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-09 Thread Bart Noordervliet
Hi Goffredo, thank you very much for your work on making the btrfs filesystem df output that much more understandable. It is a real improvement already. I would however like to bring this comment from Hugo to your attention once again: On Wed, Oct 3, 2012 at 1:56 PM, Hugo Mills

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-09 Thread Goffredo Baroncelli
Hi Bart, On Tue, Oct 9, 2012 at 11:43 AM, Bart Noordervliet b...@noordervliet.net wrote: Hi Goffredo, thank you very much for your work on making the btrfs filesystem df output that much more understandable. It is a real improvement already. I would however like to bring this comment from

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-09 Thread Bart Noordervliet
On Tue, Oct 9, 2012 at 1:38 PM, Goffredo Baroncelli kreij...@gmail.com wrote: Hi Bart, I replayed in another email to Hugo about that. Basically I am not contrary to the change, only it is unrelated to my patches. In may patches I use the function pretty_sizes() which adds the suffix KB, MB,

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-09 Thread Goffredo Baroncelli
On 10/09/2012 02:51 PM, Bart Noordervliet wrote: On Tue, Oct 9, 2012 at 1:38 PM, Goffredo Baroncellikreij...@gmail.com wrote: Hi Bart, I replayed in another email to Hugo about that. Basically I am not contrary to the change, only it is unrelated to my patches. In may patches I use the

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Hugo Mills
Looks good. Only a few comments, inline. On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: $ ./btrfs filesystem df --help usage: btrfs filesystem disk-usage [-d][-s][-k] path [path..] Show space usage information for a mount point(s). -k Set KB (1024 bytes)

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: This serie of patches updated the command btrfs filesystem df. I update this command because it is not so easy to get the information about the disk usage from the command fi df and fi show. From the man page (see 2nd

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 01:56 PM, Hugo Mills wrote: Looks good. Only a few comments, inline. On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: $ ./btrfs filesystem df --help usage: btrfs filesystem disk-usage [-d][-s][-k]path [path..] Show space usage information for a

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Hugo Mills
On Wed, Oct 03, 2012 at 06:17:53PM +0200, Goffredo Baroncelli wrote: On 10/03/2012 01:56 PM, Hugo Mills wrote: Looks good. Only a few comments, inline. On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: [snip] Also, use kB, MB, GB, TB for powers-of-ten based units,

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 05:01 PM, Ilya Dryomov wrote: Type for the first column is probably enough. Why is the third column called Chunk-size? If my understanding is correct, it's just a break down of Disk_allocated from the summary section. If so, why not call it Disk_allocated to avoid confusion?

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 06:46:00PM +0200, Goffredo Baroncelli wrote: On 10/03/2012 05:01 PM, Ilya Dryomov wrote: Type for the first column is probably enough. Why is the third column called Chunk-size? If my understanding is correct, it's just a break down of Disk_allocated from the summary

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Goffredo Baroncelli
On 10/03/2012 07:46 PM, Ilya Dryomov wrote: On Wed, Oct 03, 2012 at 06:46:00PM +0200, Goffredo Baroncelli wrote: On 10/03/2012 05:01 PM, Ilya Dryomov wrote: Type for the first column is probably enough. Why is the third column called Chunk-size? If my understanding is correct, it's just a

Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

2012-10-03 Thread Ilya Dryomov
On Wed, Oct 03, 2012 at 10:01:00PM +0200, Goffredo Baroncelli wrote: On 10/03/2012 07:46 PM, Ilya Dryomov wrote: On Wed, Oct 03, 2012 at 06:46:00PM +0200, Goffredo Baroncelli wrote: On 10/03/2012 05:01 PM, Ilya Dryomov wrote: Type for the first column is probably enough. Why is the third