Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-08 Thread Austin S Hemmelgarn
On 2015-12-08 14:20, Christoph Anton Mitterer wrote: On Tue, 2015-12-08 at 07:15 -0500, Austin S Hemmelgarn wrote: Despite this, it really isn't a widely known or well documented behavior outside of developers, forensic specialists, and people who have had to deal with the implications it has on

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-08 Thread Christoph Anton Mitterer
On Tue, 2015-12-08 at 07:15 -0500, Austin S Hemmelgarn wrote: > Despite this, it really isn't a widely known or well documented > behavior > outside of developers, forensic specialists, and people who have had > to > deal with the implications it has on data recovery.  There really > isn't > any

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-08 Thread Austin S Hemmelgarn
On 2015-12-08 01:08, Qu Wenruo wrote: Austin S Hemmelgarn wrote on 2015/12/07 11:36 -0500: On 2015-12-07 01:06, Qu Wenruo wrote: Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-08 Thread Austin S Hemmelgarn
On 2015-12-07 18:06, Eric Sandeen wrote: On 12/7/15 2:54 PM, Christoph Anton Mitterer wrote: ... 2) a section that describes "ro" in btrfs-mount(5) which describes that normal "ro" alone may cause changes on the device and which then refers to hard-ro and/or the list of options (currently nolo

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Qu Wenruo
Austin S Hemmelgarn wrote on 2015/12/07 11:36 -0500: On 2015-12-07 01:06, Qu Wenruo wrote: Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_options() need to check new flags at re

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Christoph Anton Mitterer
On Mon, 2015-12-07 at 17:06 -0600, Eric Sandeen wrote: > Yeah, I don't know that this is true.  It hasn't been true for over a > decade (2?), with the most widely-used filesystem in linux history, > i.e. > ext3. Based on what? I'd now many sysadmins who don't expect that e.g. the journal is replaye

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Qu Wenruo
On 12/07/2015 11:38 PM, Chandan Rajendra wrote: On Monday 07 Dec 2015 14:06:42 Qu Wenruo wrote: Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_options() need to check new flags

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Eric Sandeen
On 12/7/15 2:54 PM, Christoph Anton Mitterer wrote: ... > 2) a section that describes "ro" in btrfs-mount(5) which describes that > normal "ro" alone may cause changes on the device and which then refers > to hard-ro and/or the list of options (currently nologreplay) which are > required right n

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Christoph Anton Mitterer
On Mon, 2015-12-07 at 11:29 -0600, Eric Sandeen wrote: > FWIW, new mount options and their descriptions should be added to > BTRFS-MOUNT(5) > as well. Also, from the end-user perspective, there should be: 1) another option like (hard-ro) which is defined to imply any other options that are require

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Eric Sandeen
On 12/7/15 10:52 AM, Chandan Rajendra wrote: > On Monday 07 Dec 2015 10:27:05 Eric Sandeen wrote: >> On 12/7/15 12:06 AM, Qu Wenruo wrote: >>> Introduce a new mount option "nologreplay" to co-operate with "ro" mount >>> option to get real readonly mount, like "norecovery" in ext* and xfs. >>> >>> S

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Chandan Rajendra
On Monday 07 Dec 2015 10:27:05 Eric Sandeen wrote: > On 12/7/15 12:06 AM, Qu Wenruo wrote: > > Introduce a new mount option "nologreplay" to co-operate with "ro" mount > > option to get real readonly mount, like "norecovery" in ext* and xfs. > > > > Since the new parse_options() need to check new

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Austin S Hemmelgarn
On 2015-12-07 01:06, Qu Wenruo wrote: Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_options() need to check new flags at remount time, so add a new parameter for parse_options().

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Eric Sandeen
On 12/7/15 12:06 AM, Qu Wenruo wrote: > Introduce a new mount option "nologreplay" to co-operate with "ro" mount > option to get real readonly mount, like "norecovery" in ext* and xfs. > > Since the new parse_options() need to check new flags at remount time, > so add a new parameter for parse_opt

Re: [PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-07 Thread Chandan Rajendra
On Monday 07 Dec 2015 14:06:42 Qu Wenruo wrote: > Introduce a new mount option "nologreplay" to co-operate with "ro" mount > option to get real readonly mount, like "norecovery" in ext* and xfs. > > Since the new parse_options() need to check new flags at remount time, > so add a new parameter for

[PATCH] btrfs: Introduce new mount option to disable tree log replay

2015-12-06 Thread Qu Wenruo
Introduce a new mount option "nologreplay" to co-operate with "ro" mount option to get real readonly mount, like "norecovery" in ext* and xfs. Since the new parse_options() need to check new flags at remount time, so add a new parameter for parse_options(). Signed-off-by: Qu Wenruo --- Document