Re: 4.11.0: kernel BUG at fs/btrfs/ctree.h:1779!

2017-05-19 Thread Hugo Mills
On Fri, May 19, 2017 at 06:25:22PM -0700, Marc MERLIN wrote: > On Sat, May 20, 2017 at 12:57:09AM +, Hugo Mills wrote: > >I think from the POV of removing these BUG_ONs, it doesn't matter > > which FS causes them. "All" you need to know is where the error > > happened. From there, you can

Re: 4.11.0: kernel BUG at fs/btrfs/ctree.h:1779!

2017-05-19 Thread Marc MERLIN
On Sat, May 20, 2017 at 12:57:09AM +, Hugo Mills wrote: >I think from the POV of removing these BUG_ONs, it doesn't matter > which FS causes them. "All" you need to know is where the error > happened. From there, you can (in theory) work out what was wrong and > handle it more elagantly

Re: 4.11.0: kernel BUG at fs/btrfs/ctree.h:1779!

2017-05-19 Thread Hugo Mills
On Fri, May 19, 2017 at 05:47:48PM -0700, Marc MERLIN wrote: > On Sat, May 20, 2017 at 12:37:47AM +, Hugo Mills wrote: > > > Can I make another plea for just removing all those BUG/BUG_ON? > > > They really have no place in production code, there is no excuse for a > > > filesystem to bring

Re: 4.11.0: kernel BUG at fs/btrfs/ctree.h:1779!

2017-05-19 Thread Marc MERLIN
On Sat, May 20, 2017 at 12:37:47AM +, Hugo Mills wrote: > > Can I make another plea for just removing all those BUG/BUG_ON? > > They really have no place in production code, there is no excuse for a > > filesystem to bring down the entire and in the process not even tell you > > which of your

Re: 4.11.0: kernel BUG at fs/btrfs/ctree.h:1779!

2017-05-19 Thread Hugo Mills
On Fri, May 19, 2017 at 05:11:34PM -0700, Marc MERLIN wrote: > On Fri, May 19, 2017 at 12:03:58PM -0700, Liu Bo wrote: > > Hi Marc, > > > > On Thu, May 18, 2017 at 09:16:38PM -0700, Marc MERLIN wrote: > > > Looks like all the unhelpful BUG() aren't gone yet :-/ > > > This one is really not

Re: 4.11.0: kernel BUG at fs/btrfs/ctree.h:1779!

2017-05-19 Thread Marc MERLIN
On Fri, May 19, 2017 at 12:03:58PM -0700, Liu Bo wrote: > Hi Marc, > > On Thu, May 18, 2017 at 09:16:38PM -0700, Marc MERLIN wrote: > > Looks like all the unhelpful BUG() aren't gone yet :-/ > > This one is really not helpful, I don't even know which one of my > > filesystems caused the crash :(

Re: 4.11.0: kernel BUG at fs/btrfs/ctree.h:1779!

2017-05-19 Thread Liu Bo
Hi Marc, On Thu, May 18, 2017 at 09:16:38PM -0700, Marc MERLIN wrote: > Looks like all the unhelpful BUG() aren't gone yet :-/ > This one is really not helpful, I don't even know which one of my filesystems > caused the crash :( > > Why is this not remounting the filesystem read only? > Really,