Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Josh Berry
On Wed, Sep 15, 2010 at 15:37, Chris Ball wrote: ... >   > Why not just do: >   > # btrfs subvolume delete /path/to/subvolume1 >   > # btrfs subvolume delete /path/to/subvolume2 >   > # sync > > Or even better, "btrfs filesystem sync ". > > I'm assuming that the caller wants to wait until the subv

Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Chris Ball
Hi Sage, > Actually, that was fixed in 2.6.34 (0bdb1db2). Creating a > snapshot syncs all dirty data and metadata to disk, so you get a > fully consistent point in time snapshot. No 'sync' is necessary > (and doing a 'sync' yourself would be racy any). Oh, thanks! Am happy to see t

Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Sage Weil
On Wed, 15 Sep 2010, Sage Weil wrote: > For subvolume removal, racing doesn't seem like an issue. Why not just > do > > # btrfs subvolume delete /path/to/subvolume1 > # btrfs subvolume delete /path/to/subvolume2 > # ... > # sync > > ? Nevermind, read the whole thread this time. I'll defer to

Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Sage Weil
On Wed, 15 Sep 2010, Chris Ball wrote: > Hi, > >> Or make --sync the default behavior. This is probably what most >> people are expecting anyway (similar to how standard filesystem >> commands like "rm" work). Add an --aysnc option for those that >> only care about knowing when t

Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Josh Berry
On Wed, Sep 15, 2010 at 14:52, Chris Ball wrote: > Hi, > >   > Or make --sync the default behavior.  This is probably what most >   > people are expecting anyway (similar to how standard filesystem >   > commands like "rm" work).  Add an --aysnc option for those that >   > only care about knowing

Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Chris Ball
Hi, > Or make --sync the default behavior. This is probably what most > people are expecting anyway (similar to how standard filesystem > commands like "rm" work). Add an --aysnc option for those that > only care about knowing when the subvolume is taken out of the > tree. Yeah.

Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Josh Berry
On Wed, Sep 15, 2010 at 14:07, Chris Ball wrote: > Hi, > >   > adding a --wait or --sync switch to the delete command is >   > certainly possible, you'd want to add it to the last in a series >   > of deletes. > > I think this (--sync) is a much better idea than the alternatives so far. Or make -

Re: Updating the wiki pages adding btrfs command

2010-09-15 Thread Chris Ball
Hi, > adding a --wait or --sync switch to the delete command is > certainly possible, you'd want to add it to the last in a series > of deletes. I think this (--sync) is a much better idea than the alternatives so far. Thanks, -- Chris Ball One Laptop Per Chi

Re: Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details]

2010-09-15 Thread David Nicol
On Wed, Sep 15, 2010 at 1:41 PM, Josh Berry wrote: > Personally, I like "gc" or "clean".  "wait-subvolume-deletion", > "garbage-collect" or similar is too verbose for my taste. > > -- Josh the question IMO is how much implementation details to saddle the user with. Anything with the word "garbage

Re: Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details]

2010-09-15 Thread Goffredo Baroncelli
On Wednesday, 15 September, 2010, David Nicol wrote: > btrfs s ... is imprecise, as the operation isn't on a subvolume, but > on the fi where the s used to be but isn't any more. ok > > With your approval I'll go with "filesystem garbage-collection" which > can be abbrevd to > >btrfs fi g /

Re: Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details]

2010-09-15 Thread Josh Berry
On Wed, Sep 15, 2010 at 07:10, David Nicol wrote: > Does the manpatch below describe an acceptable API for a hook to a > facility for waiting for the completion of deleted snapshot cleanup? ... > +\fBfilesystem GC\fR\fI [ms] \fR > +wait for completion of salvage of deleted subvolumes on > +the fi

Re: Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details]

2010-09-15 Thread David Nicol
btrfs s ... is imprecise, as the operation isn't on a subvolume, but on the fi where the s used to be but isn't any more. With your approval I'll go with "filesystem garbage-collection" which can be abbrevd to btrfs fi g /butter 3 || echo there should be some more space now \ but it wou

Re: Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details]

2010-09-15 Thread Goffredo Baroncelli
Hi David, the btrfs command is smart enough to accept short form of the sub-command if there is no ambiguity. For example "btrfs fi" is a synonymous of "btrfs filesystem". Because that the acronyms are discouraged. Instead a long form is preferred. So instead of CG (which means ? Garbage Collec

Re: Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details]

2010-09-15 Thread David Nicol
Does the manpatch below describe an acceptable API for a hook to a facility for waiting for the completion of deleted snapshot cleanup? diff --git a/man/btrfs.8.in b/man/btrfs.8.in index 26ef982..290d202 100644 --- a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -19,6 +19,8 @@ btrfs \- control a btrfs fi

Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details]

2010-09-14 Thread Goffredo Baroncelli
Hi all, On Monday, 13 September, 2010, David Nicol wrote: > https://btrfs.wiki.kernel.org/index.php/Category:Documentation does > not mention any btrfs command. [...] I updated the wiki, inserting the btrfs command. For now I left the old commands in the examples (some distros have the old vers