Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check

2014-04-18 Thread David Sterba
On Thu, Apr 17, 2014 at 08:47:28AM +0800, Qu Wenruo wrote: > >@@ -73,6 +74,7 @@ install: install-man > > install-man: man > > $(INSTALL) -d -m 755 $(DESTDIR)$(man8dir) > > $(INSTALL) -m 644 $(GZ_MAN8) $(DESTDIR)$(man8dir) > >+$(LNS) btrfs-check.txt $(DESTDIR)$(man8dir) > Shouldn't the

Solved, false alarm - Re: File changing in snapshot

2014-04-18 Thread Oliver O.
Am 17.04.2014 23:29, schrieb Oliver O.: Conclusions: The sequence of events seems to be: 1. The file was changed with generation 193090. 2. The snapshot for backup (@home-2014-04-16) was taken (generation 194551). 3. As the backup was reading from the snapshot, it was seeing stale data (MyFil

SSD TRIM on balance

2014-04-18 Thread Sergey E. Kolesnikov
Greetings everyone. I've recently rebalanced my btrfs (kernel 3.13) running on two SSD drives (raid-0) and a question arose. Does btrfs perform TRIM on SSD balance? Fs is mounted with 'ssd' option, but not 'discard'. It seems fstrim only trims free chunks in allocated space, so we possibly h

Re: Solved, false alarm - Re: File changing in snapshot

2014-04-18 Thread Chris Mason
On 04/18/2014 11:50 AM, Oliver O. wrote: Am 17.04.2014 23:29, schrieb Oliver O.: Result: False alarm - this is definitely not a Btrfs problem. In this case snapshot behavior was as expected: atomic and stable. Sorry for any irritation. But, mystery solved and documented for later generat

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-18 Thread David Sterba
On Tue, Apr 15, 2014 at 08:49:52PM +0100, Filipe David Manana wrote: > On Tue, Apr 15, 2014 at 8:35 PM, Mark Fasheh wrote: > > On Tue, Apr 15, 2014 at 07:30:51PM +0100, Filipe David Manana wrote: > >> On Tue, Apr 15, 2014 at 7:10 PM, Josef Bacik wrote: > >> > Just make a SUPPORTS_V2 flag that use

Re: [PATCH 3/4 v3] Btrfs-progs: send, implement fallocate command callback

2014-04-18 Thread David Sterba
On Wed, Apr 16, 2014 at 08:58:14PM +0100, Filipe David Borba Manana wrote: > The fallocate send stream command, added in stream version 2, is used to > pre-allocate space for files and punch file holes. This change implements > the callback for that new command, using the fallocate function from th

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-18 Thread Filipe David Manana
On Fri, Apr 18, 2014 at 6:18 PM, David Sterba wrote: > On Tue, Apr 15, 2014 at 08:49:52PM +0100, Filipe David Manana wrote: >> On Tue, Apr 15, 2014 at 8:35 PM, Mark Fasheh wrote: >> > On Tue, Apr 15, 2014 at 07:30:51PM +0100, Filipe David Manana wrote: >> >> On Tue, Apr 15, 2014 at 7:10 PM, Josef

Re: [PATCH 3/4 v3] Btrfs-progs: send, implement fallocate command callback

2014-04-18 Thread Filipe David Manana
On Fri, Apr 18, 2014 at 6:41 PM, David Sterba wrote: > On Wed, Apr 16, 2014 at 08:58:14PM +0100, Filipe David Borba Manana wrote: >> The fallocate send stream command, added in stream version 2, is used to >> pre-allocate space for files and punch file holes. This change implements >> the callback

[PATCH 1/2] Btrfs-progs: fsck: while checking root refs print readable errors

2014-04-18 Thread Rakesh Pandit
Lets use "errors" instead of "error" because more then one ref errors are possible. Also print error messages for unresolved refs in check_root_refs. Signed-off-by: Rakesh Pandit --- cmds-check.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmds-check.c b/cmds-check.c

[PATCH 2/2] Btrfs-progs: receive: remove return type of close_inode_for_write

2014-04-18 Thread Rakesh Pandit
"close_inode_for_write" always returns 0, so just remove its return value and remove dead checking in caller. Signed-off-by: Rakesh Pandit --- cmds-receive.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/cmds-receive.c b/cmds-receive.c index 7a23823..39309f2

[PATCH] Btrfs-progs: cmds-subvolume: use parameter str instead of optarg

2014-04-18 Thread Rakesh Pandit
Fix unused parameter str (commit e8cfa3c8): get_subvolid was called with optarg passed as str, but get_subvolid kept using optarg. Signed-off-by: Rakesh Pandit --- cmds-subvolume.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds-subvolume.c b/cmds-subvolume.c index b

Fixing a degraded RAID

2014-04-18 Thread Michael Welsh Duggan
I had a disk in my RAID0 die: root@maru2:~# /usr/local/src/btrfs-progs/btrfs fi show 8c530f6f-7592-4d57-854d-1fae33ae7cb6 Label: none uuid: 8c530f6f-7592-4d57-854d-1fae33ae7cb6 Total devices 3 FS bytes used 329.66GiB devid1 size 1.79TiB used 357.03GiB path /dev/sdd1

Re: Fixing a degraded RAID

2014-04-18 Thread Chris Murphy
On Apr 18, 2014, at 8:36 PM, Michael Welsh Duggan wrote: > I had a disk in my RAID0 die: > > root@maru2:~# /usr/local/src/btrfs-progs/btrfs fi show > 8c530f6f-7592-4d57-854d-1fae33ae7cb6 > Label: none uuid: 8c530f6f-7592-4d57-854d-1fae33ae7cb6 > Total devices 3 FS bytes used 329.66

Re: Fixing a degraded RAID

2014-04-18 Thread Michael Welsh Duggan
Michael Welsh Duggan writes: > I had a disk in my RAID0 die: My mistake. This was a stupid typo. The drives were in a RAID 1 configuration. Both data and metadata are DUP'd. root@maru2:~# /usr/local/src/btrfs-progs/btrfs fi df /mnt/ Data, RAID1: total=353.00GiB, used=328.24GiB System, single

Re: Fixing a degraded RAID

2014-04-18 Thread Michael Welsh Duggan
Chris Murphy writes: > On Apr 18, 2014, at 8:36 PM, Michael Welsh Duggan wrote: > >> I had a disk in my RAID0 die: >> >> root@maru2:~# /usr/local/src/btrfs-progs/btrfs fi show >> 8c530f6f-7592-4d57-854d-1fae33ae7cb6 >> Label: none uuid: 8c530f6f-7592-4d57-854d-1fae33ae7cb6 >> Total

Re: Fixing a degraded RAID

2014-04-18 Thread Chris Murphy
On Apr 18, 2014, at 9:23 PM, Michael Welsh Duggan wrote: > My mistake. This was a stupid typo. The drives were in a RAID 1 > configuration. Both data and metadata are DUP'd. > > root@maru2:~# /usr/local/src/btrfs-progs/btrfs fi df /mnt/ > Data, RAID1: total=353.00GiB, used=328.24GiB > System

Re: SSD TRIM on balance

2014-04-18 Thread Duncan
Sergey E. Kolesnikov posted on Fri, 18 Apr 2014 21:07:00 +0400 as excerpted: > I've recently rebalanced my btrfs (kernel 3.13) running on two SSD > drives (raid-0) and a question arose. > Does btrfs perform TRIM on SSD balance? Fs is mounted with 'ssd' option, > but not 'discard'. > > It seems fs