Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Marat Khalili
On 25/09/17 17:33, Qu Wenruo wrote: (Any in this case, anyone in the maillist can help review messages) If this is a question, I can help with assigning levels to messages. Although I think many levels are only required for complex daemons or network tools, while btrfs utils mostly perform

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Qu Wenruo
On 2017年09月25日 22:19, Hugo Mills wrote: On Mon, Sep 25, 2017 at 04:04:03PM +0800, Qu Wenruo wrote: On 2017年09月25日 15:52, Hugo Mills wrote: On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote: On 2017年09月25日 15:42, Marat Khalili wrote: On 25/09/17 10:30, Nikolay Borisov wrote: On

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Hugo Mills
On Mon, Sep 25, 2017 at 04:04:03PM +0800, Qu Wenruo wrote: > > > On 2017年09月25日 15:52, Hugo Mills wrote: > >On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote: > >> > >> > >>On 2017年09月25日 15:42, Marat Khalili wrote: > >>>On 25/09/17 10:30, Nikolay Borisov wrote: > On 19.09.2017

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Marat Khalili
On 25/09/17 11:08, Qu Wenruo wrote: What about redirecting stdout to /dev/null and redirecting stderr to mail if return value is not 0? s/if return value is not 0/if return value is 0/. The main point is, if btrfs returns 0, then nothing to worry about. (Unless there is a bug, even in that

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Marat Khalili
On 25/09/17 10:52, Hugo Mills wrote: Isn't the correct way to catch the return value instead of grepping the output? It is, but if, for example, you're using the command in a cron script which is expected to work, you don't want it producing output because then you get a mail every time the

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Qu Wenruo
On 2017年09月25日 16:04, Qu Wenruo wrote: On 2017年09月25日 15:52, Hugo Mills wrote: On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote: On 2017年09月25日 15:42, Marat Khalili wrote: On 25/09/17 10:30, Nikolay Borisov wrote: On 19.09.2017 10:41, Misono, Tomohiro wrote: "btrfs subvolume

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Qu Wenruo
On 2017年09月25日 15:52, Hugo Mills wrote: On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote: On 2017年09月25日 15:42, Marat Khalili wrote: On 25/09/17 10:30, Nikolay Borisov wrote: On 19.09.2017 10:41, Misono, Tomohiro wrote: "btrfs subvolume create/delete" outputs the message of

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Hugo Mills
On Mon, Sep 25, 2017 at 03:46:15PM +0800, Qu Wenruo wrote: > > > On 2017年09月25日 15:42, Marat Khalili wrote: > >On 25/09/17 10:30, Nikolay Borisov wrote: > >>On 19.09.2017 10:41, Misono, Tomohiro wrote: > >>>"btrfs subvolume create/delete" outputs the message of "Create/Delete > >>>subvolume ..."

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Qu Wenruo
On 2017年09月25日 15:42, Marat Khalili wrote: On 25/09/17 10:30, Nikolay Borisov wrote: On 19.09.2017 10:41, Misono, Tomohiro wrote: "btrfs subvolume create/delete" outputs the message of "Create/Delete subvolume ..." even when an operation fails. Since it is confusing, let's outputs the

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Hugo Mills
On Mon, Sep 25, 2017 at 10:42:06AM +0300, Marat Khalili wrote: > On 25/09/17 10:30, Nikolay Borisov wrote: > >On 19.09.2017 10:41, Misono, Tomohiro wrote: > >>"btrfs subvolume create/delete" outputs the message of "Create/Delete > >>subvolume ..." even when an operation fails. > >>Since it is

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Marat Khalili
On 25/09/17 10:30, Nikolay Borisov wrote: On 19.09.2017 10:41, Misono, Tomohiro wrote: "btrfs subvolume create/delete" outputs the message of "Create/Delete subvolume ..." even when an operation fails. Since it is confusing, let's outputs the message only when an operation succeeds. Please

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-25 Thread Nikolay Borisov
On 19.09.2017 10:41, Misono, Tomohiro wrote: > "btrfs subvolume create/delete" outputs the message of "Create/Delete > subvolume ..." even when an operation fails. > Since it is confusing, let's outputs the message only when an operation > succeeds. > > Signed-off-by: Tomohiro Misono

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-19 Thread Satoru Takeuchi
At Tue, 19 Sep 2017 16:41:52 +0900, Misono, Tomohiro wrote: > > "btrfs subvolume create/delete" outputs the message of "Create/Delete > subvolume ..." even when an operation fails. > Since it is confusing, let's outputs the message only when an operation > succeeds. > > Signed-off-by: Tomohiro

[PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-19 Thread Misono, Tomohiro
"btrfs subvolume create/delete" outputs the message of "Create/Delete subvolume ..." even when an operation fails. Since it is confusing, let's outputs the message only when an operation succeeds. Signed-off-by: Tomohiro Misono --- cmds-subvolume.c | 8