FLEX_BG support for the e2fsprogs interim branch.

2008-02-19 Thread Jose R. Santos
on the e2fsprogs-pu branch. -JRS From: Jose R. Santos [EMAIL PROTECTED] This patch add basic flex_bg support to the e2fsprogs-interim branch. --- e2fsck/super.c |7 +-- lib/e2p/feature.c |2 ++ lib/ext2fs/check_desc.c |9 ++--- lib/ext2fs/ext2_fs.h|1 + lib

[PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG v2

2008-02-13 Thread Jose R. Santos
New bitmap and inode table allocation for FLEX_BG From: Jose R. Santos [EMAIL PROTECTED] Change the way we allocate bitmaps and inode tables if the FLEX_BG feature is used at mke2fs time. It places calculates a new offset for bitmaps and inode table base on the number of groups that the user

Re: [PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-02-11 Thread Jose R. Santos
On Sun, 10 Feb 2008 23:33:51 -0500 Theodore Tso [EMAIL PROTECTED] wrote: On Fri, Feb 08, 2008 at 11:37:40AM -0600, Jose R. Santos wrote: #define EXT2_BG_INODE_UNINIT 0x0001 /* Inode table/bitmap not initialized */ #define EXT2_BG_BLOCK_UNINIT 0x0002 /* Block bitmap

Re: [PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-02-08 Thread Jose R. Santos
On Fri, 08 Feb 2008 00:11:16 -0500 Andreas Dilger [EMAIL PROTECTED] wrote: On Feb 07, 2008 11:09 -0600, Jose R. Santos wrote: +blk_t ext2fs_flexbg_offset(ext2_filsys fs, dgrp_t group, blk_t start_blk, + ext2fs_block_bitmap bmap, int offset, int size) +{ Can you add

[PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-02-07 Thread Jose R. Santos
New bitmap and inode table allocation for FLEX_BG From: Jose R. Santos [EMAIL PROTECTED] Change the way we allocate bitmaps and inode tables if the FLEX_BG feature is used at mke2fs time. It places calculates a new offset for bitmaps and inode table base on the number of groups that the user

[PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-01-11 Thread Jose R. Santos
commit 38a4134f29b06229843bfe838c23e28f8d323b86 Author: Jose R. Santos [EMAIL PROTECTED] Date: Fri Jan 11 11:03:03 2008 -0600 New bitmap and inode table allocation for FLEX_BG Change the way we allocate bitmaps and inode tables if the FLEX_BG feature is used at mke2fs time

[PATCH] New inode allocation for FLEX_BG meta-data groups.

2008-01-11 Thread Jose R. Santos
commit 8eef19455beb97319a78511b35b1da42a1d48eb2 Author: Jose R. Santos [EMAIL PROTECTED] Date: Fri Jan 11 11:04:25 2008 -0600 New inode allocation for FLEX_BG meta-data groups. This patch mostly controls the way inode are allocated in order to make ialloc aware of flex_bg block

Re: [PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-01-11 Thread Jose R. Santos
On Fri, 11 Jan 2008 14:01:04 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Jan 11, 2008 11:28 -0600, Jose R. Santos wrote: +blk_t ext2fs_flexbg_offset(ext2_filsys fs, dgrp_t group, int flexbg_size, + ext2fs_block_bitmap bmap, int offset, int size) OK. Could you

Re: [PATCH] New inode allocation for FLEX_BG meta-data groups.

2008-01-11 Thread Jose R. Santos
On Fri, 11 Jan 2008 14:46:58 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Jan 11, 2008 11:28 -0600, Jose R. Santos wrote: @@ -127,6 +127,8 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, mark_bitmap_end(group_blocks, sb-s_blocksize * 8

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-14 Thread Jose R. Santos
On Fri, 14 Dec 2007 10:01:06 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: Well, I can imagine in some cases that the flexbg will not be completely contiguous on disk (e.g. after a filesystem resize, if there are bad blocks, etc). As long as the group descriptors themselves are correct (i.e.

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-13 Thread Jose R. Santos
On Tue, 11 Dec 2007 16:15:28 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Dec 11, 2007 10:08 -0600, Jose R. Santos wrote: I'd think being able to avoid the divide for every inode allocation is more important than 8 bits in the superblock. We already avoid the divide since

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-11 Thread Jose R. Santos
On Tue, 11 Dec 2007 04:00:33 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Dec 07, 2007 09:52 -0600, Jose R. Santos wrote: Andreas Dilger [EMAIL PROTECTED] wrote: There is no particular reason that this ratio needs to be *100, it could just as easily be a fraction of 256 and make

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-07 Thread Jose R. Santos
On Fri, 7 Dec 2007 03:14:28 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Dec 06, 2007 16:10 -0600, Jose R. Santos wrote: @@ -600,6 +600,7 @@ void ext4_free_blocks_sb(handle_t *handle, struct super_block *sb, struct ext4_sb_info *sbi; int err = 0, ret; ext4_grpblk_t

[RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-06 Thread Jose R. Santos
. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index b102b0e..7ef9787 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c @@ -600,6 +600,7 @@ void ext4_free_blocks_sb(handle_t *handle, struct super_block *sb, struct ext4_sb_info *sbi

Re: [RFC] Flex_BG ialloc awareness.

2007-12-04 Thread Jose R. Santos
On Mon, 3 Dec 2007 13:42:47 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Dec 03, 2007 13:05 -0600, Jose R. Santos wrote: @@ -600,6 +600,7 @@ void ext4_free_blocks_sb(handle_t *handle, struct super_block *sb, ext4_grpblk_t group_freed; + ext4_group_t meta_group; Please do

[RFC] Flex_BG ialloc awareness.

2007-12-03 Thread Jose R. Santos
2.43 seconds (user 1.25s sys 0.90s) stat compiled tree total runs 1 avg 3.13 seconds (user 1.48s sys 1.03s) There are still a couple of things that need fixing in the patch but I would to get some opinions as well. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- diff --git a/fs/ext4/balloc.c

Re: [PATCH 3/4][e2fsprogs] Relax group descriptor checking.

2007-11-05 Thread Jose R. Santos
On Sat, 3 Nov 2007 19:36:09 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Mon, Aug 13, 2007 at 11:33:03PM -0500, Jose R. Santos wrote: From: Jose R. Santos [EMAIL PROTECTED] Relax group descriptor checking. This patch should really be before patch #2 in the series (add the ability

Re: [PATCH 4/4][e2fsprogs] New bitmap and inode table allocation for FLEX_BG

2007-11-05 Thread Jose R. Santos
On Sat, 3 Nov 2007 20:52:08 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Mon, Aug 13, 2007 at 11:33:14PM -0500, Jose R. Santos wrote: + if (EXT2_HAS_INCOMPAT_FEATURE (fs-super, + EXT4_FEATURE_INCOMPAT_FLEX_BG)) + ext2fs_allocate_flex_groups

Re: [PATCH 13/13][e2fsprogs] Add m_uninit test case.

2007-11-01 Thread Jose R. Santos
On Thu, 1 Nov 2007 06:03:00 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: It seems like a problem on your end since I got the patches from the mailing list after sending them. Here are the patches from the archives. [PATCH 01/13] http://lists.openwall.net/linux-ext4/2007/10/11/20 [PATCH 11

Re: compilebench numbers for ext4

2007-10-25 Thread Jose R. Santos
On Mon, 22 Oct 2007 19:31:04 -0400 Chris Mason [EMAIL PROTECTED] wrote: Hello everyone, I recently posted some performance numbers for Btrfs with different blocksizes, and to help establish a baseline I did comparisons with Ext3. The graphs, numbers and a basic description of

Re: compilebench numbers for ext4

2007-10-25 Thread Jose R. Santos
On Mon, 22 Oct 2007 19:31:04 -0400 Chris Mason [EMAIL PROTECTED] wrote: Hello everyone, I recently posted some performance numbers for Btrfs with different blocksizes, and to help establish a baseline I did comparisons with Ext3. The graphs, numbers and a basic description of

Re: compilebench numbers for ext4

2007-10-25 Thread Jose R. Santos
On Thu, 25 Oct 2007 14:43:55 -0400 Chris Mason [EMAIL PROTECTED] wrote: 2) You mentioned that one of the goals of the benchmark is to measure locality during directory aging, but the workloads seems too well order to truly age the filesystem. At least that's what I can gather from the

[PATCH 2 00/14][e2fsprogs] Uninit block group break down

2007-10-21 Thread Jose R. Santos
The Uninit block group patch is painful to review since it's quite a large patch. Since simple patches are easier to review, I decided to break down the patch into smaller logical pieces that should be easier to review, clean and fix. Aside from the breakdown, this is essentially the same

[PATCH 02/14] Add initial checksum support.

2007-10-21 Thread Jose R. Santos
Add initial checksum support. - Add support for computing CRC-16 value. - Add call to check/verify/set csum on block_groups. - Add a test program to verify csum operations. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- lib/ext2fs

[PATCH 04/14] Rename feature name from gdt_checksum to uninit_groups.

2007-10-21 Thread Jose R. Santos
Rename feature name from gdt_checksum to uninit_groups. This name is a more intuitive option when running mke2fs. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- lib/e2p/feature.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 05/14] Add support for creating filesystems using uninit block group.

2007-10-21 Thread Jose R. Santos
Add support for creating filesystems using uninit block group. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- misc/mke2fs.c | 44 1 files changed, 32 insertions(+), 12 deletions(-) diff --git

[PATCH 06/14] Make tune2fs uninit block group aware.

2007-10-21 Thread Jose R. Santos
Make tune2fs uninit block group aware. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- misc/tune2fs.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/misc/tune2fs.c b/misc/tune2fs.c index 833b994..e2ebc08

[PATCH 07/14] Make dumpe2fs uninit block group aware.

2007-10-21 Thread Jose R. Santos
Make dumpe2fs uninit block group aware. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- misc/dumpe2fs.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c index d4d95bb

[PATCH 11/14] Update uninit block group documetation for some of the utilities.

2007-10-21 Thread Jose R. Santos
Update uninit block group documetation for some of the utilities. Upadates documentation man pages for mke2fs(8) and tune2fs(8) Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- misc/mke2fs.8.in |9 - misc/tune2fs.8.in | 12

[PATCH 13/14] Add new mm_lazy test case.

2007-10-21 Thread Jose R. Santos
Add new mm_lazy test case. Add test case for lazy bg feature. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- tests/m_lazy/expect.1 | 166 + tests/m_lazy/script |4 + 2 files changed, 170

[PATCH 14/14] Add m_uninit test case.

2007-10-21 Thread Jose R. Santos
Add m_uninit test case. Add test case to test for uninit block groups. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-Off-By: Andreas Dilger [EMAIL PROTECTED] -- tests/m_uninit/expect.1 | 166 +++ tests/m_uninit/script |4 + 2 files

Re: [PATCH 01/13][e2fsprogs] Add initial checksum support.

2007-10-15 Thread Jose R. Santos
On Sun, 14 Oct 2007 22:46:05 -0400 Theodore Tso [EMAIL PROTECTED] wrote: In crc16.h, this patch assumes that linux/types.h defines uint16_t. There are a couple of problems with this. #1) linux/types.h is non-portable, not only does it not exist on non-Linux systems, apparently on

Re: question about patch queue and ext4-git

2007-10-15 Thread Jose R. Santos
On Mon, 15 Oct 2007 13:36:05 +0800 Coly Li [EMAIL PROTECTED] wrote: Now in my mind there are several words for ext4 patches, most frequently one are patch queue. I see the patches in patch queue from http://www2.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/LATEST/broken-out/ .

Re: question about patch queue and ext4-git

2007-10-15 Thread Jose R. Santos
On Mon, 15 Oct 2007 20:46:32 +0800 Coly Li [EMAIL PROTECTED] wrote: Thanks for the replying :-) Jose R. Santos wrote: On Mon, 15 Oct 2007 13:36:05 +0800 Coly Li [EMAIL PROTECTED] wrote: Now in my mind there are several words for ext4 patches, most frequently one are patch queue

[PATCH 09/13][e2fsprogs] Make e2fsck uninit block group aware.

2007-10-11 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Make e2fsck uninit block group aware. This patch has all the necesary pieces to open and fix filesystems created with the uninit block group feature. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- e2fsck/e2fsck.h |2 + e2fsck/journal.c |2

[PATCH 10/13][e2fsprogs] Update uninit block group documetation for some of the utilities.

2007-10-11 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Update uninit block group documetation for some of the utilities. Upadates documentation man pages for mke2fs(8) and tune2fs(8) Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- misc/mke2fs.8.in |9 - misc/tune2fs.8.in | 12

[PATCH 04/13][e2fsprogs] Add support for creating filesystems using uninit block group.

2007-10-11 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Add support for creating filesystems using uninit block group. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- misc/mke2fs.c | 44 1 files changed, 32 insertions(+), 12 deletions(-) diff --git a/misc

[PATCH 06/13][e2fsprogs] Make dumpe2fs uninit block group aware.

2007-10-11 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Make dumpe2fs uninit block group aware. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- misc/dumpe2fs.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c index d4d95bb..c08528a 100644

[PATCH 11/13][e2fsprogs] Fix test cases.

2007-10-11 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Fix test cases. Some of the tools outputs have changed, so this patch fixes what to expect from the outputs of the f_dupfsblks and m_raid_opt test cases. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- tests/f_dupfsblks/expect.1 |3 ++- tests

[PATCH] JBD2: debug code cleanup.

2007-09-27 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] JBD2: debug code cleanup. Mostly stolen from akpm's JBD cleanup patch. - use `#ifdef foo' instead of `#if defined(foo)' - Make journal_enable_debug __read_mostly just for the heck of it - Make jbd_debugfs_dir and jbd_debug static - debugfs_remove(NULL

Re: jbd : config_jbd_debug cannot create /proc entry

2007-09-26 Thread Jose R. Santos
On Wed, 26 Sep 2007 14:35:39 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 25 Sep 2007 16:36:08 +0200 Jan Kara [EMAIL PROTECTED] wrote: On Tue, 25 Sep 2007 07:49:38 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: On Tue, 25 Sep 2007 13:50:46 +0200 Jan Kara [EMAIL

Re: jbd : config_jbd_debug cannot create /proc entry

2007-09-25 Thread Jose R. Santos
On Tue, 25 Sep 2007 07:49:38 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: On Tue, 25 Sep 2007 13:50:46 +0200 Jan Kara [EMAIL PROTECTED] wrote: Jan Kara wrote: -#define create_jbd_proc_entry() do {} while (0) -#define remove_jbd_proc_entry() do {} while (0) +static ctl_table

[PATCH] JBD: Export jbd-debug via debugfs

2007-09-25 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] JBD: Export jbd-debug via debugfs The jbd-debug file used to be located in /proc/sys/fs/jbd-debug, but create_proc_entry() does not do lookups on file names that are more that one directory deep. This causes the entry creation to fail and hence, no proc

[PATCH] ext4: FLEX_BG Kernel support v2.

2007-09-21 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] ext4: FLEX_BG Kernel support v2. This feature relaxes check restrictions on where each block groups meta data is located within the storage media. This allows for the allocation of bitmaps or inode tables outside the block group boundaries in cases where

Ext4 devel interlock meeting minutes (Sep 10, 2007)

2007-09-13 Thread Jose R. Santos
Attendees: Dave Kleikamp, Andreas Dilger, Jose Santos, Aneesh Kumar, Eric Sandeen - Lack of e2fsprogs support for some of the features is viewed as the major roadblocks for declaring ext4 stable. There was talk about creating a forked version of the tools to only support ext4 while we wait for

Re: [PATCH] FLEX_BG Kernel support v2.

2007-09-12 Thread Jose R. Santos
On Wed, 12 Sep 2007 01:27:54 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On Sep 11, 2007 19:07 -0500, Jose R. Santos wrote: @@ -1248,13 +1248,17 @@ static int ext4_check_descriptors (struct super_block * sb) ext4_fsblk_t inode_table; struct ext4_group_desc * gdp = NULL

Re: [PATCH] FLEX_BG Kernel support.

2007-09-11 Thread Jose R. Santos
On Tue, 11 Sep 2007 00:04:43 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On 9/10/07, Jose R. Santos [EMAIL PROTECTED] wrote: @@ -1254,7 +1254,8 @@ static int ext4_check_descriptors (struct super_block * sb) for (i = 0; i sbi-s_groups_count; i

Re: ZFS, XFS, and EXT4 compared

2007-08-30 Thread Jose R. Santos
On Thu, 30 Aug 2007 11:52:10 -0700 Jeffrey W. Baker [EMAIL PROTECTED] wrote: On Thu, 2007-08-30 at 08:37 -0500, Jose R. Santos wrote: On Wed, 29 Aug 2007 23:16:51 -0700 Jeffrey W. Baker [EMAIL PROTECTED] wrote: http://tastic.brillig.org/~jwb/zfs-xfs-ext4.html FFSB: Could you

Adding META_BG/FLEX_BG awareness to inode allocator.

2007-08-21 Thread Jose R. Santos
Hi Andreas, Ted, I've been looking at the uninitialized block group patches to see how they overlap with the uninitialized inode tables that I was looking into for FLEX_BG and I think I can achieve the same thing using those patches. One of the things I wanted to achieve with uninitialized inode

[PATCH 0/4][e2fsprogs] Enable FLEX_BG support

2007-08-13 Thread Jose R. Santos
The following series of patches add support creating and checking filesystems with the FLEX_BG feature. This feature currently groups meta-data from a series of groups at the beginning of a flex group in order to improve performance during heavy meta-data operations. Changes from last time: -

[PATCH 1/4][e2fsprogs] Reserve the INCOMPAT feature number for FLEX_BG.

2007-08-13 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Reserve the INCOMPAT feature number for FLEX_BG. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- lib/ext2fs/ext2_fs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/ext2fs/ext2_fs.h b/lib/ext2fs/ext2_fs.h index a316665

[PATCH 2/4][e2fsprogs] Allow FLEX_BG to be use as a feature option at mke2fs time.

2007-08-13 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Allow FLEX_BG to be use as a feature option at mke2fs time. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- lib/e2p/feature.c |2 ++ lib/ext2fs/ext2fs.h |6 -- misc/mke2fs.c |7 ++- 3 files changed, 12 insertions(+), 3

[PATCH 4/4][e2fsprogs] New bitmap and inode table allocation for FLEX_BG

2007-08-13 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] New bitmap and inode table allocation for FLEX_BG Change the way we allocate bitmaps and inode tables if the FLEX_BG feature is used at mke2fs time. The block and inode bitmaps are allocated as a one contiguous set for each flex block group. Due

Re: seekwatcher IO visualization

2007-08-09 Thread Jose R. Santos
On Thu, 9 Aug 2007 14:53:55 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: I saw on #linuxfs today some graphs and movies by Chris Mason showing the poor IO locality for ext3 compared to btrfs and XFS. It would be interesting to run this with ext4+mballoc+delalloc, and a separate one with the

Re: E2fsprogs git tree

2007-08-07 Thread Jose R. Santos
On Tue, 7 Aug 2007 13:28:14 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Tue, Aug 07, 2007 at 06:23:46PM +0200, Valerie Clement wrote: Hi Ted, I tried to clone the source tree but it failed. The command git-clone http://www.kernel.org/pub/scm/fs/ext2/e2fsprogs.git; failed with :

[PATCH][e2fsprogs] Move ext2fs_struct_generic_bitmap back into ext2fs.h

2007-08-07 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Move ext2fs_struct_generic_bitmap back into ext2fs.h In Commit: f1f115a78f5ea599fc5f8815a741d43fedd5840d The ext2fs_struct_generic_bitmap structure is remove from ext2fs.h and put into gen_bitmap.c. This breaks big endian compiles since swapfs.c uses

[PATCH 2/4][e2fsprogs] Allow FLEX_BG to be use as a feature option at mke2fs time.

2007-08-02 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Allow FLEX_BG to be use as a feature option at mke2fs time. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- lib/e2p/feature.c |2 ++ lib/ext2fs/ext2fs.h |6 -- misc/mke2fs.c |3 ++- 3 files changed, 8 insertions(+), 3 deletions

[PATCH 1/4][e2fsprogs] Reserve the INCOMPAT feature number for FLEX_BG.

2007-08-02 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] Reserve the INCOMPAT feature number for FLEX_BG. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] -- lib/ext2fs/ext2_fs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/ext2fs/ext2_fs.h b/lib/ext2fs/ext2_fs.h index a316665

[PATCH 4/4][e2fsprogs] New bitmap and inode table allocation for FLEX_BG

2007-08-02 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] New bitmap and inode table allocation for FLEX_BG Change the way we allocate bitmaps and inode tables if the FLEX_BG feature is used at mke2fs time. The block and inode bitmaps are allocated as a one contiguous set for each flex block group. Due

New e2fsprog doc on the ext4 wiki page.

2007-07-24 Thread Jose R. Santos
Hi folks As discussed in the conference call, we are going to create a new doc on the ext4 wiki dedicated to track the development of some of the features needed in e2fsprogs. The page will consist of mostly changes needed in order to keep e2fsprogs up to date with mainline ext4 kernel code. I

Re: New e2fsprog doc on the ext4 wiki page.

2007-07-24 Thread Jose R. Santos
On Tue, 24 Jul 2007 21:48:58 +0530 Aneesh Kumar K.V [EMAIL PROTECTED] wrote: Jose R. Santos wrote: Hi folks ext4migrate: - Patches submited to the mailing list by Aneesh Kumar http://thread.gmane.org/gmane.comp.file-systems.ext4/1395 I guess what we are looking

Re: Initial results of FLEX_BG feature.

2007-07-16 Thread Jose R. Santos
On Mon, 16 Jul 2007 00:34:57 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On Jul 12, 2007 10:09 -0500, Jose R. Santos wrote: @@ -1271,6 +1271,9 @@ static int ext4_check_descriptors (struc ext4_debug (Checking group descriptors); + if (EXT4_HAS_INCOMPAT_FEATURE(sb

Re: Initial results of FLEX_BG feature.

2007-07-12 Thread Jose R. Santos
On Wed, 11 Jul 2007 18:14:25 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Wed, Jul 11, 2007 at 12:30:04AM -0500, Jose R. Santos wrote: Right now what I've done is allocate the bitmaps and inode tables at the beginning of each group of 64 BG. Still need to work on fsck since just

Re: [EXT4 set 2][PATCH 3/5] cleanups: set_jbd2_64bit_feature for 16TB ext4 fs

2007-07-11 Thread Jose R. Santos
Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing to the journal. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Mingming Cao

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Jose R. Santos
the jbd2-debug file to debugfs which would be the preferred location for this kind of tunable. The new location is now /sys/kernel/debug/jbd2/jbd2-debug. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] --- fs/Kconfig | 105 + 5 - 0 ! fs/jbd2/journal.c| 6727 +40

Initial results of FLEX_BG feature.

2007-07-10 Thread Jose R. Santos
Hi folks, I've started playing with the FLEX_BG feature (for now packing of block group metadata closer together) and started doing some preliminary benchmarking to see if the feature is worth pursuing. I chose an FFSB profile that does single threaded small creates and writes and then does an

block groups with no inode tables

2007-07-10 Thread Jose R. Santos
Hi folks, As I play with the allocation of the metadata for the FLEX_BG feature, it seems that we could benefit from having block groups with no inode tables. Right now we allocate one inode table per bg base on the inode_blocks_per_group. For FLEX_BG though, it would make more sense to have a

Re: [RFC] BIG_BG vs extended META_BG in ext4

2007-07-02 Thread Jose R. Santos
On Sun, 1 Jul 2007 12:31:53 -0400 Andreas Dilger [EMAIL PROTECTED] wrote: On Jun 30, 2007 23:40 -0500, Jose R. Santos wrote: Yes, I think bigger block groups will benefit extents a great deal since not only can we have larger extents, but I believe that as the filesystem ages the chances

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-01 Thread Jose R. Santos
On Sun, 01 Jul 2007 03:38:10 -0400 Mingming Cao [EMAIL PROTECTED] wrote: [PATCH] jbd2 stats through procfs The patch below updates the jbd stats patch to 2.6.20/jbd2. The initial patch was posted by Alex Tomas in December 2005 (http://marc.info/?l=linux-ext4m=113538565128617w=2). It

Re: [RFC] BIG_BG vs extended META_BG in ext4

2007-06-30 Thread Jose R. Santos
On Sat, 30 Jun 2007 01:51:25 -0400 Andreas Dilger [EMAIL PROTECTED] wrote: I don't think there is actually any fundamental difference between these proposals. The reality is that we cannot change the semantics of the META_BG flag at this point, since both e2fsprogs and ext3/ext4 in the kernel

Re: [RFC] BIG_BG vs extended META_BG in ext4

2007-06-30 Thread Jose R. Santos
On Sat, 30 Jun 2007 11:06:16 -0400 Laurent Vivier [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 29 juin 07 à 18:09, Jose R. Santos a écrit : Hi Jose, Hi Laurent, Seems like your emails are not making it to the mailing list. I got them fine though. Thank you

[RFC] BIG_BG vs extended META_BG in ext4

2007-06-29 Thread Jose R. Santos
Hi folks, I've been looking at getting around some of the limitations imposed by the block groups and was wondering what are peoples thoughts about implementing this using either bigger block groups or storing the bitmaps and inode tables outside of the block groups. I think the BIG_BG feature

Re: [RFC][PATCH 4/12] convert some block types in e2fsprogs

2007-06-12 Thread Jose R. Santos
On Mon, 11 Jun 2007 15:59:30 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: On Mon, 11 Jun 2007 18:42:28 +0200 Valerie Clement [EMAIL PROTECTED] wrote: This patch converts some int or unsigned int block number definitions to blk_t type. Most conversions are necessary for 64-bit porting

Re: Ext4 devel interlock meeting minutes (June 11, 2007)

2007-06-12 Thread Jose R. Santos
On Tue, 12 Jun 2007 09:56:34 -0700 Avantika Mathur [EMAIL PROTECTED] wrote: Ext4 Developer Interlock Call: Jun 11, 2007 Meeting Minutes Minutes can be accessed at: http://ext4.wiki.kernel.org/index.php/Ext4_Developer%27s_Conference_Call Attendees: Mingming Cao, Ted T'so, Dave Kleikamp,

Re: [RFC][PATCH 4/12] convert some block types in e2fsprogs

2007-06-11 Thread Jose R. Santos
On Mon, 11 Jun 2007 18:42:28 +0200 Valerie Clement [EMAIL PROTECTED] wrote: This patch converts some int or unsigned int block number definitions to blk_t type. Most conversions are necessary for 64-bit porting. What about unsigned long? There are various places where block is represented by

Re: [PATCH] JBD2: Change debug file path

2007-06-08 Thread Jose R. Santos
On Fri, 8 Jun 2007 01:08:12 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do lookups on file names with more that one directory deep

Re: [PATCH][RFC] JBD2: Use DebugFS for jbd2 debug config option.

2007-06-08 Thread Jose R. Santos
On Fri, 8 Jun 2007 01:08:12 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do lookups on file names with more that one directory deep

[PATCH] JBD2: Change debug file path

2007-06-07 Thread Jose R. Santos
could be move to /proc/fs/jbd2/jbd2-debug, but it would require some minor alterations to the jbd-stats patch. This is also broken on the original jbd code. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] --- Index: linux-2.6.22-rc3/fs/Kconfig

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Mon, 04 Jun 2007 16:01:45 -0700 Mingming Cao [EMAIL PROTECTED] wrote: On Mon, 2007-06-04 at 11:57 -0600, Andreas Dilger wrote: On Jun 04, 2007 11:32 -0500, Jose R. Santos wrote: Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Tue, 05 Jun 2007 15:26:53 +0200 Laurent Vivier [EMAIL PROTECTED] wrote: Dave Kleikamp wrote: Jose is right. The endian conversion is unnecessary. Shaggy But by using le32_to_cpu(es-s_blocks_count_hi) you explicitly mark the variable as a little-endian. So if someone reads the

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Tue, 05 Jun 2007 16:03:44 +0200 Laurent Vivier [EMAIL PROTECTED] wrote: Jose R. Santos wrote: Hi Laurent, In this particular case though, the value of s_blocks_count_hi should not be uses on its own. The correct way would be to use ext4_blocks_count() which already does the endian

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Tue, 05 Jun 2007 10:46:43 -0700 Mingming Cao [EMAIL PROTECTED] wrote: The better choice to me is using ext4_blocks_count() to hide the details of the little endian. It's fine to use s_blocks_count_hi directly, just to make it clear, this is on-disk superblock data and better to do little

[PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks

2007-06-05 Thread Jose R. Santos
Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing to the journal. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Mingming Cao

[RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks.

2007-06-01 Thread Jose R. Santos
Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing to the journal. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] --- .pc/ext4-set_64-bit_JBD_incompat.patch/fs/ext4/super.c 2007-05-31 22

Re: Creating a 32bit blocks filesystem.

2007-05-09 Thread Jose R. Santos
On Wed, 09 May 2007 14:16:55 +0200 Valerie Clement [EMAIL PROTECTED] wrote: Hi Jose, I'm sorry to reply so late, I had a day off yesterday. I only tested the tools on an x86_64 system. Could it be an endianess issue? On which platform do you run? Valérie Hi Valerie, I think this has

Re: Creating a 32bit blocks filesystem.

2007-05-09 Thread Jose R. Santos
On Wed, 09 May 2007 10:21:44 -0500 Eric Sandeen [EMAIL PROTECTED] wrote: Valerie Clement wrote: Jose R. Santos wrote: I think this has more to do with the fact that I'm on a 32bit architecture and there are still a couple places where blocks are represented using unsigned long. I'm

Re: Creating a 32bit blocks filesystem.

2007-05-07 Thread Jose R. Santos
On Mon, 7 May 2007 11:19:52 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: I tried the patches and while the tools such as mkfs and debugfs seem to work fine, I am still unable to mount a filesystem with block numbers exceeding 32 bits. Correction, I tested debugfs on a 32bit blocks filesystem

Re: Ext4 benchmarks

2007-03-28 Thread Jose R. Santos
Jean-Pierre Dion wrote: Hi Jose, thank you for the feedback. We took your remarks into account and we are doing some perfs with iozone (close to desktop activity, mono-thread) and ffsb (allows to run benchs in a multi-thread activity like a server does, different blocks sizes...). We

Re: Ext4 benchmarks

2007-03-20 Thread Jose R. Santos
Jean-Pierre Dion wrote: Hi all, we already discussed during the conf calls what benchmarks should be ran on ext4. As we have OLS paper on the table we were thinking here at Bull what bench t run and on which kernel. If we want trying to compare ext3 and ext4, I guess we should at least show