Hello,
Thanks for the report.
On 2021/5/11 13:41, kernel test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git
dev-test
head: 55b45e3a3bbcbc02828c32e3ba3f413634046fd2
commit: 55b45e3a3bbcbc02828c32e3ba3f413634046fd2 [12/12] f2fs: compress: add
compress_i
>On 2021/5/11 13:09, Jaegeuk Kim wrote:
>> On 05/11, Chao Yu wrote:
>>> On 2021/5/10 22:47, Jaegeuk Kim wrote:
On 05/06, Chao Yu wrote:
> On 2021/5/6 12:46, Jaegeuk Kim wrote:
>> On 05/06, Chao Yu wrote:
>>> On 2021/4/29 14:20, Daejun Park wrote:
In file defragmentation by
On 2021/5/11 13:09, Jaegeuk Kim wrote:
On 05/11, Chao Yu wrote:
On 2021/5/10 22:47, Jaegeuk Kim wrote:
On 05/06, Chao Yu wrote:
On 2021/5/6 12:46, Jaegeuk Kim wrote:
On 05/06, Chao Yu wrote:
On 2021/4/29 14:20, Daejun Park wrote:
In file defragmentation by ioctl, all data blocks in the file
On 2021/5/11 13:07, Jaegeuk Kim wrote:
On 05/11, Chao Yu wrote:
On 2021/5/10 22:28, Jaegeuk Kim wrote:
Unable to handle kernel NULL pointer dereference at virtual address
001a
pc : f2fs_inplace_write_data+0x144/0x208
lr : f2fs_inplace_write_data+0x134/0x208
Call trace:
On 05/11, Chao Yu wrote:
> On 2021/5/10 22:47, Jaegeuk Kim wrote:
> > On 05/06, Chao Yu wrote:
> > > On 2021/5/6 12:46, Jaegeuk Kim wrote:
> > > > On 05/06, Chao Yu wrote:
> > > > > On 2021/4/29 14:20, Daejun Park wrote:
> > > > > > In file defragmentation by ioctl, all data blocks in the file are
On 05/11, Chao Yu wrote:
> On 2021/5/10 22:28, Jaegeuk Kim wrote:
> > Unable to handle kernel NULL pointer dereference at virtual address
> > 001a
> > pc : f2fs_inplace_write_data+0x144/0x208
> > lr : f2fs_inplace_write_data+0x134/0x208
> > Call trace:
> >f2fs_inplace_write
On Tue, May 11, 2021 at 02:17:00AM +0530, Shreeya Patel wrote:
> Theodore / Christoph, since we haven't come up with any final decision with
> this discussion, how do you think we should proceed on this?
I think loading it as a firmware-like table is much preferable to
a module with all the static
On 2021/5/10 16:57, Seung-Woo Kim wrote:
Fix to free node_blk when nid is 0 from dump_node_blk().
Signed-off-by: Seung-Woo Kim
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.so
On 2021/5/10 16:57, Seung-Woo Kim wrote:
With invalid node info from fsck_chk_orphan_node(), orphan_blk
and new_blk are not freed. Fix memory leak in the path.
Signed-off-by: Seung-Woo Kim
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailin
On 2021/5/10 18:26, Mauro Carvalho Chehab wrote:
While UTF-8 characters can be used at the Linux documentation,
the best is to use them only when ASCII doesn't offer a good replacement.
So, replace the occurences of the following UTF-8 characters:
- U+2013 ('–'): EN DASH
- U+201c
On 2021/5/10 22:42, Jaegeuk Kim wrote:
In f2fs_fileattr_set(),
if (!fa->flags_valid)
mask &= FS_COMMON_FL;
In this case, we can set supported flags by mask only instead of BUG_ON.
/* Flags shared betwen flags/xflags */
(FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_F
On 2021/5/11 0:09, Jaegeuk Kim wrote:
On 05/10, Chao Yu wrote:
In f2fs_destroy_compress_ctx(), after f2fs_destroy_compress_ctx(),
cc.cluster_idx will be cleared w/ NULL_CLUSTER, f2fs_cluster_blocks()
may check wrong cluster metadata, fix it.
Fixes: 4c8ff7095bef ("f2fs: support data compression"
On 2021/5/10 23:51, Jaegeuk Kim wrote:
On 05/10, Chao Yu wrote:
f2fs_get_block() and f2fs_put_dnode() should be called as a pair,
add missing f2fs_put_dnode() in prepare_compress_overwrite().
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c
On 2021/5/10 23:36, Jaegeuk Kim wrote:
On 05/06, Chao Yu wrote:
On 2021/5/6 12:43, Jaegeuk Kim wrote:
On 05/06, Chao Yu wrote:
On 2021/5/4 22:36, Jaegeuk Kim wrote:
On 04/27, Chao Yu wrote:
On 2021/4/27 1:09, Jaegeuk Kim wrote:
On 04/25, Chao Yu wrote:
We may trigger high frequent checkpoi
On 2021/5/10 22:47, Jaegeuk Kim wrote:
On 05/06, Chao Yu wrote:
On 2021/5/6 12:46, Jaegeuk Kim wrote:
On 05/06, Chao Yu wrote:
On 2021/4/29 14:20, Daejun Park wrote:
In file defragmentation by ioctl, all data blocks in the file are
re-written out-of-place. File defragmentation implies user wi
On 2021/5/10 22:28, Jaegeuk Kim wrote:
Unable to handle kernel NULL pointer dereference at virtual address
001a
pc : f2fs_inplace_write_data+0x144/0x208
lr : f2fs_inplace_write_data+0x134/0x208
Call trace:
f2fs_inplace_write_data+0x144/0x208
f2fs_do_write_data_page+0x27
On 05/10, Eric Biggers wrote:
> On Mon, May 10, 2021 at 07:42:27AM -0700, Jaegeuk Kim wrote:
> > In f2fs_fileattr_set(),
> >
> > if (!fa->flags_valid)
> > mask &= FS_COMMON_FL;
> >
> > In this case, we can set supported flags by mask only instead of BUG_ON.
> >
> > /* Flags share
On Mon, May 10, 2021 at 12:26:12PM +0200, Mauro Carvalho Chehab wrote:
> There are several UTF-8 characters at the Kernel's documentation.
[...]
> Other UTF-8 characters were added along the time, but they're easily
> replaceable by ASCII chars.
>
> As Linux developers are all around the globe, an
On Mon, May 10, 2021 at 07:42:27AM -0700, Jaegeuk Kim wrote:
> In f2fs_fileattr_set(),
>
> if (!fa->flags_valid)
> mask &= FS_COMMON_FL;
>
> In this case, we can set supported flags by mask only instead of BUG_ON.
>
> /* Flags shared betwen flags/xflags */
> (FS_SYNC_FL
On Mon, May 10, 2021 at 02:49:44PM +0100, David Woodhouse wrote:
> On Mon, 2021-05-10 at 13:55 +0200, Mauro Carvalho Chehab wrote:
> > This patch series is doing conversion only when using ASCII makes
> > more sense than using UTF-8.
> >
> > See, a number of converted documents ended with weird c
On 05/10, Chao Yu wrote:
> In f2fs_destroy_compress_ctx(), after f2fs_destroy_compress_ctx(),
> cc.cluster_idx will be cleared w/ NULL_CLUSTER, f2fs_cluster_blocks()
> may check wrong cluster metadata, fix it.
>
> Fixes: 4c8ff7095bef ("f2fs: support data compression")
> Signed-off-by: Chao Yu
> -
On 05/10, Chao Yu wrote:
> f2fs_get_block() and f2fs_put_dnode() should be called as a pair,
> add missing f2fs_put_dnode() in prepare_compress_overwrite().
>
> Fixes: 4c8ff7095bef ("f2fs: support data compression")
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/compress.c | 1 +
> 1 file changed, 1 i
On 05/07, Fengnan Chang wrote:
> when write compressed file with O_TRUNC, there will be a lot of
> unnecessary check valid blocks in f2fs_prepare_compress_overwrite,
> especially when written in page size, remove it.
>
> This patch will not bring significant performance improvements, I test
> this
On 05/06, Chao Yu wrote:
> On 2021/5/6 12:43, Jaegeuk Kim wrote:
> > On 05/06, Chao Yu wrote:
> > > On 2021/5/4 22:36, Jaegeuk Kim wrote:
> > > > On 04/27, Chao Yu wrote:
> > > > > On 2021/4/27 1:09, Jaegeuk Kim wrote:
> > > > > > On 04/25, Chao Yu wrote:
> > > > > > > We may trigger high frequent
On 05/06, Chao Yu wrote:
> On 2021/5/6 12:46, Jaegeuk Kim wrote:
> > On 05/06, Chao Yu wrote:
> > > On 2021/4/29 14:20, Daejun Park wrote:
> > > > In file defragmentation by ioctl, all data blocks in the file are
> > > > re-written out-of-place. File defragmentation implies user will not
> > > > u
In f2fs_fileattr_set(),
if (!fa->flags_valid)
mask &= FS_COMMON_FL;
In this case, we can set supported flags by mask only instead of BUG_ON.
/* Flags shared betwen flags/xflags */
(FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
FS_NODUMP_FL | FS_NOATIME_
On 05/06, Eric Biggers wrote:
> On Thu, May 06, 2021 at 12:13:47PM -0700, Jaegeuk Kim wrote:
> > In f2fs_fileattr_set(),
> >
> > if (!fa->flags_valid)
> > mask &= FS_COMMON_FL;
> >
> > In this case, we should not allow to set FS_COMPR_FL, instead of BUG_ON.
> >
> > /* Flags share
On 05/10, Chao Yu wrote:
> On 2021/4/22 14:07, Chao Yu wrote:
> > On 2021/4/22 11:59, Jaegeuk Kim wrote:
> > > On 04/21, Chao Yu wrote:
> > > > On 2021/3/11 4:52, Jaegeuk Kim wrote:
> > > > > On 03/09, Chao Yu wrote:
> > > > > > On 2021/3/9 8:01, Jaegeuk Kim wrote:
> > > > > > > On 03/05, Chao Yu w
On 10/05/2021 14:59, Matthew Wilcox wrote:
> Most of these
> UTF-8 characters come from latex conversions and really aren't
> necessary (and are being used incorrectly).
I fully agree with fixing those.
The cover-letter, however, gave the impression that that was not the
main purpose of this serie
Unable to handle kernel NULL pointer dereference at virtual address
001a
pc : f2fs_inplace_write_data+0x144/0x208
lr : f2fs_inplace_write_data+0x134/0x208
Call trace:
f2fs_inplace_write_data+0x144/0x208
f2fs_do_write_data_page+0x270/0x770
f2fs_write_single_data_page+0x47c/0x8
On Mon, May 10, 2021 at 13:55:18 +0200, Mauro Carvalho Chehab wrote:
> $ git grep "CPU 0 has been" Documentation/RCU/
> Documentation/RCU/Design/Data-Structures/Data-Structures.rst:| #. CPU 0
> has been in dyntick-idle mode for quite some time. When it |
> Documentation/RCU/Desig
On Mon, May 10, 2021 at 02:16:16PM +0100, Edward Cree wrote:
> On 10/05/2021 12:55, Mauro Carvalho Chehab wrote:
> > The main point on this series is to replace just the occurrences
> > where ASCII represents the symbol equally well
>
> > - U+2014 ('—'): EM DASH
> Em dash is not the same thing
On 10/05/2021 14:38, Mauro Carvalho Chehab wrote:
> Em Mon, 10 May 2021 14:16:16 +0100
> Edward Cree escreveu:
>> But what kinds of things with × or — in are going to be grept for?
>
> Actually, on almost all places, those aren't used inside math formulae, but
> instead, they describe video some
Em Mon, 10 May 2021 14:16:16 +0100
Edward Cree escreveu:
> On 10/05/2021 12:55, Mauro Carvalho Chehab wrote:
> > The main point on this series is to replace just the occurrences
> > where ASCII represents the symbol equally well
>
> > - U+2014 ('—'): EM DASH
> Em dash is not the same thi
On 10/05/2021 12:55, Mauro Carvalho Chehab wrote:
> The main point on this series is to replace just the occurrences
> where ASCII represents the symbol equally well
> - U+2014 ('—'): EM DASH
Em dash is not the same thing as hyphen-minus, and the latter does not
serve 'equally well'. Peopl
On 10.05.21 14:55, Mauro Carvalho Chehab wrote:
The main point on this series is to replace just the occurrences
where ASCII represents the symbol equally well, e. g. it is limited
for those chars:
- U+2010 ('‐'): HYPHEN
- U+00ad (''): SOFT HYPHEN
- U+2013 ('–'): EN DASH
Em Mon, 10 May 2021 13:19:50 +0200
Mauro Carvalho Chehab escreveu:
> Em Mon, 10 May 2021 12:52:44 +0200
> Thorsten Leemhuis escreveu:
>
> > On 10.05.21 12:26, Mauro Carvalho Chehab wrote:
> > >
> > > As Linux developers are all around the globe, and not everybody has UTF-8
> > > as their defa
Hi David,
Em Mon, 10 May 2021 11:54:02 +0100
David Woodhouse escreveu:
> On Mon, 2021-05-10 at 12:26 +0200, Mauro Carvalho Chehab wrote:
> > There are several UTF-8 characters at the Kernel's documentation.
> >
> > Several of them were due to the process of converting files from
> > DocBook, La
On 2021/5/10 19:24, Shin'ichiro Kawasaki wrote:
The kernel writes to swap files on f2fs directly without the assistance
of the filesystem. This direct write by kernel can be non-sequential
even when the f2fs is in LFS mode. Such non-sequential write conflicts
with the LFS semantics. Especially wh
The kernel writes to swap files on f2fs directly without the assistance
of the filesystem. This direct write by kernel can be non-sequential
even when the f2fs is in LFS mode. Such non-sequential write conflicts
with the LFS semantics. Especially when f2fs is set up on zoned block
devices, the non-
On 10.05.21 12:26, Mauro Carvalho Chehab wrote:
>
> As Linux developers are all around the globe, and not everybody has UTF-8
> as their default charset, better to use UTF-8 only on cases where it is really
> needed.
> […]
> The remaining patches on series address such cases on *.rst files and
>
Em Mon, 10 May 2021 12:52:44 +0200
Thorsten Leemhuis escreveu:
> On 10.05.21 12:26, Mauro Carvalho Chehab wrote:
> >
> > As Linux developers are all around the globe, and not everybody has UTF-8
> > as their default charset, better to use UTF-8 only on cases where it is
> > really
> > needed.
>
On May 10, 2021 / 17:03, Chao Yu wrote:
> Hi Shinichiro,
>
> On 2021/5/10 16:46, Shinichiro Kawasaki wrote:
> > On May 10, 2021 / 15:03, Chao Yu wrote:
> > > On 2021/5/10 14:40, Shin'ichiro Kawasaki wrote:
> > > > When f2fs is set up on zoned block devices, swap files on the file-
> > > > system c
While UTF-8 characters can be used at the Linux documentation,
the best is to use them only when ASCII doesn't offer a good replacement.
So, replace the occurences of the following UTF-8 characters:
- U+2013 ('–'): EN DASH
- U+201c ('“'): LEFT DOUBLE QUOTATION MARK
- U+201d
There are several UTF-8 characters at the Kernel's documentation.
Several of them were due to the process of converting files from
DocBook, LaTeX, HTML and Markdown. They were probably introduced
by the conversion tools used on that time.
Other UTF-8 characters were added along the time, but they
pos_fsstress testcase complains a panic as belew:
[ cut here ]
kernel BUG at fs/f2fs/compress.c:1082!
invalid opcode: [#1] SMP PTI
CPU: 4 PID: 2753477 Comm: kworker/u16:2 Tainted: G OE
5.12.0-rc1-custom #1
Hardware name: QEMU Standard PC (i440FX + PIIX,
In f2fs_destroy_compress_ctx(), after f2fs_destroy_compress_ctx(),
cc.cluster_idx will be cleared w/ NULL_CLUSTER, f2fs_cluster_blocks()
may check wrong cluster metadata, fix it.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 2 ++
1 file c
f2fs_get_block() and f2fs_put_dnode() should be called as a pair,
add missing f2fs_put_dnode() in prepare_compress_overwrite().
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/compres
Support to use address space of inner inode to cache compressed block,
in order to improve cache hit ratio of random read.
Signed-off-by: Chao Yu
---
v5:
- adapt to new page.private layout
- truncate compress inode in advance during umount to avoid checking
and invalidating compress cache in per-
On May 10, 2021 / 15:03, Chao Yu wrote:
> On 2021/5/10 14:40, Shin'ichiro Kawasaki wrote:
> > When f2fs is set up on zoned block devices, swap files on the file-
> > system causes unaligned write command errors. The kernel writes to the
> > swap files directly without the assistance of the filesyst
On 2021/4/22 14:07, Chao Yu wrote:
On 2021/4/22 11:59, Jaegeuk Kim wrote:
On 04/21, Chao Yu wrote:
On 2021/3/11 4:52, Jaegeuk Kim wrote:
On 03/09, Chao Yu wrote:
On 2021/3/9 8:01, Jaegeuk Kim wrote:
On 03/05, Chao Yu wrote:
On 2021/3/5 4:20, Jaegeuk Kim wrote:
On 02/27, Jaegeuk Kim wrote:
Hi Shinichiro,
On 2021/5/10 16:46, Shinichiro Kawasaki wrote:
On May 10, 2021 / 15:03, Chao Yu wrote:
On 2021/5/10 14:40, Shin'ichiro Kawasaki wrote:
When f2fs is set up on zoned block devices, swap files on the file-
system causes unaligned write command errors. The kernel writes to the
swap
Fix to free node_blk when nid is 0 from dump_node_blk().
Signed-off-by: Seung-Woo Kim
---
fsck/dump.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index 055ce09bb1cf..042a2e52edca 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -278,7 +278,7 @@ st
With invalid node info from fsck_chk_orphan_node(), orphan_blk
and new_blk are not freed. Fix memory leak in the path.
Signed-off-by: Seung-Woo Kim
---
fsck/fsck.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index e52672032d2c..6019775dcb2d 1
On 08/05/2021 15:28, Chao Yu wrote:>>
>> +static int verify_sb_chksum(struct f2fs_super_block *sb)
+{
+ if (get_sb(checksum_offset) != SB_CHKSUM_OFFSET)
+ return -1;
+
+ if (f2fs_crc_valid(get_sb(crc), sb, get_sb(checksum_offset)))
+ return -1;
+
+ return 0;
+}
How about
On 2021/5/10 14:40, Shin'ichiro Kawasaki wrote:
When f2fs is set up on zoned block devices, swap files on the file-
system causes unaligned write command errors. The kernel writes to the
swap files directly without the assistance of the filesystem then
it can not fulfill sequential write requirem
56 matches
Mail list logo
