Re: [f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread gre...@linuxfoundation.org
On Thu, Feb 16, 2023 at 04:44:27PM +0900, Yonggil Song wrote: > When f2fs skipped a gc round during victim migration, there was a bug which > would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem > was not initialized. It fixes the bug by correctly initializing the > skipped_gc

[f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread Yonggil Song
When f2fs skipped a gc round during victim migration, there was a bug which would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem was not initialized. It fixes the bug by correctly initializing the skipped_gc_rwsem inside the gc loop. Fixes: 3db1de0e582c ("f2fs: change the cur

[f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread Yonggil Song
When f2fs skipped a gc round during victim migration, there was a bug which would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem was not initialized. It fixes the bug by correctly initializing the skipped_gc_rwsem inside the gc loop. Fixes: 3db1de0e582c ("f2fs: change the cur

[f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread Yonggil Song
When f2fs skipped a gc round during victim migration, there was a bug which would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem was not initialized. It fixes the bug by correctly initializing the skipped_gc_rwsem inside the gc loop. Fixes: 3db1de0e582c ("f2fs: change the cur

Re: [f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread Miko Larsson
On Thu, 2023-02-16 at 11:57 +0900, Yonggil Song wrote: > When f2fs skipped a gc round during victim migration, there was a bug > which > would skip all upcoming gc rounds unconditionally because > skipped_gc_rwsem > was not initialized. It fixes the bug by correctly initializing the > skipped_gc_rw

[f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread Yonggil Song
When f2fs skipped a gc round during victim migration, there was a bug which would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem was not initialized. It fixes the bug by correctly initializing the skipped_gc_rwsem inside the gc loop. Fixes: 3db1de0e582c ("f2fs: change the cur

Re: [f2fs-dev] (2) [PATCH v1] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread Yonggil Song
On 2023/2/15 10:48, Yonggil Song wrote: >> When f2fs skipped a gc round during victim migration, there was a bug which >> would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem >> was not initialized. It fixes the bug by correctly initializing the >> skipped_gc_rwsem inside the

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_abort_atomic_write

2023-02-15 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:e1c04510f521 Merge tag 'pm-6.2-rc9' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=172c657748 kernel config: https://syzkaller.appspot.com/x/.config?x=8d9381a

[f2fs-dev] Patchwork summary for: f2fs

2023-02-15 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev] f2fs: Revert "f2fs: truncate blocks in batch in __complete_revoke_list()" Submitter: Jaegeuk Kim Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/proj

Re: [f2fs-dev] [PATCH] f2fs: Revert "f2fs: truncate blocks in batch in __complete_revoke_list()"

2023-02-15 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 14 Feb 2023 15:57:19 -0800 you wrote: > We should not truncate replaced blocks, and were supposed to truncate the > first > part as well. > > This reverts commit 78a99fe6254cad4be310cd84af39f6c46b668c72. > > Cc: s

Re: [f2fs-dev] [PATCH] f2fs: drop unnecessary arg for f2fs_ioc_*()

2023-02-15 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 15 Feb 2023 14:17:01 +0800 you wrote: > They are not used, let's remove them. > > Signed-off-by: Yangtao Li > --- > fs/f2fs/file.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Here is

Re: [f2fs-dev] [PATCH] f2fs: make kobj_type structures constant

2023-02-15 Thread Jaegeuk Kim
On 02/15, Chao Yu wrote: > On 2023/2/15 2:07, Jaegeuk Kim wrote: > > On 02/14, Chao Yu wrote: > > > On 2023/2/14 1:51, Jaegeuk Kim wrote: > > > > On 02/13, Chao Yu wrote: > > > > > On 2023/2/9 11:20, Thomas Weißschuh wrote: > > > > > > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constan

Re: [f2fs-dev] f2fs: fix to release compress file for F2FS_IOC_RESERVE_COMPRESS_BLOCKS when has no space

2023-02-15 Thread Yangtao Li via Linux-f2fs-devel
Hi Chao, > Chao, any comment? ping.. Thx, Yangtao ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: drop unnecessary arg for f2fs_ioc_*()

2023-02-15 Thread Chao Yu
On 2023/2/15 14:17, Yangtao Li wrote: They are not used, let's remove them. Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listi

Re: [f2fs-dev] [PATCH v1] f2fs: fix uninitialized skipped_gc_rwsem

2023-02-15 Thread Chao Yu
On 2023/2/15 10:48, Yonggil Song wrote: When f2fs skipped a gc round during victim migration, there was a bug which would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem was not initialized. It fixes the bug by correctly initializing the skipped_gc_rwsem inside the gc loop.

Re: [f2fs-dev] [PATCH] f2fs: Revert "f2fs: truncate blocks in batch in __complete_revoke_list()"

2023-02-15 Thread Chao Yu
On 2023/2/15 7:57, Jaegeuk Kim wrote: We should not truncate replaced blocks, and were supposed to truncate the first part as well. This reverts commit 78a99fe6254cad4be310cd84af39f6c46b668c72. Cc: sta...@vger.kernel.org Signed-off-by: Jaegeuk Kim Oh, my bad, thanks for fixing this. Reviewe

Re: [f2fs-dev] [PATCH] f2fs: make kobj_type structures constant

2023-02-15 Thread Chao Yu
On 2023/2/15 2:07, Jaegeuk Kim wrote: On 02/14, Chao Yu wrote: On 2023/2/14 1:51, Jaegeuk Kim wrote: On 02/13, Chao Yu wrote: On 2023/2/9 11:20, Thomas Weißschuh wrote: Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_ty