Re: is wait_on_buffer needed after getblk?

1999-12-13 Thread Mikulas Patocka
Some times ago I found a race in buffer code - many filesystems do getblk();mark_buffer_uptodate(); and then write to buffer. If the buffer is under read i/o, written data are lost. Andrea certainly submitted me some 2.2.x patches for ext2fs for this that I merged. I don't know how it

is wait_on_buffer needed after getblk?

1999-12-13 Thread Mikulas Patocka
Hi Andrea. Some times ago I found a race in buffer code - many filesystems do getblk();mark_buffer_uptodate(); and then write to buffer. If the buffer is under read i/o, written data are lost. You created a patch for it, but I don't see it in kernel. What's the status of this bug? Did anyone

Re: [RFC] truncate() (generic stuff)

1999-10-11 Thread Mikulas Patocka
in inode pointer to directory data, but I'm too lazy to implement it. HPFS is not performance critical ] Mikulas Patocka

Re: [patch] [possible race in ext2] Re: how to write get_block?

1999-10-10 Thread Mikulas Patocka
On Sat, 9 Oct 1999, Andrea Arcangeli wrote: On Fri, 8 Oct 1999, Mikulas Patocka wrote: Here goes quick'n'dirty patch. It does bforget(). It should prevent file corruption. wrong patch. bforget give you no guarantee at all. bfoget always fallback to brelse if necessary. What I said

[patch] [possible race in ext2] Re: how to write get_block?

1999-10-08 Thread Mikulas Patocka
. If I'm not mistaken the same scenario applies here just fine. Here goes quick'n'dirty patch. It does bforget(). It should prevent file corruption. Mikulas Patocka --- linux-2.3.19.tar.gz#utar/linux/fs/ext2/truncate.c Tue Jun 29 18:22:08 1999 +++ linux/fs/ext2/truncate.cFri Oct 8 18:40:36 1999

Re: how to write get_block?

1999-10-08 Thread Mikulas Patocka
. Mikulas Patocka

how to write get_block?

1999-10-02 Thread Mikulas Patocka
to do the same (fat currently crashes when writing beyond file end, other filesystems aren't ported yet) Mikulas Patocka

Re: Race in buffer code (Was Re: move block #A to block #B on a given device.)

1999-01-03 Thread Mikulas Patocka
On Fri, 5 Nov 1999, Mikulas Patocka wrote: BTW. neither getblk nor mark_buffer_uptodate check for i/o completion. That was exactly what I wanted to point out :). Isn't it race? Many filesystem do it this way. All depends on the semantics you want I think. It doesn't seems black