Re: [PATCH v6 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx.

2015-04-28 Thread rajeev kumar
On Tue, Apr 28, 2015 at 2:01 PM, Eddie Huang wrote: > From: Xudong Chen > > Add devicetree bindings for Mediatek Soc I2C driver. > > Signed-off-by: Xudong Chen > Signed-off-by: Eddie Huang > --- > .../devicetree/bindings/i2c/i2c-mt6577.txt | 41 > ++ > 1 file chang

Re: [V2 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

2015-04-16 Thread rajeev kumar
On Fri, Apr 17, 2015 at 11:22 AM, rajeev kumar wrote: > On Thu, Apr 16, 2015 at 9:40 PM, Kamal Dasu wrote: >> Rajeev, >> >> Thanks for the review. >> Answers inline. >> >> Kamal >> >> On Wed, Apr 15, 2015 at 3:21 AM, rajeev kumar >> wro

Re: [V2 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

2015-04-16 Thread rajeev kumar
On Thu, Apr 16, 2015 at 9:40 PM, Kamal Dasu wrote: > Rajeev, > > Thanks for the review. > Answers inline. > > Kamal > > On Wed, Apr 15, 2015 at 3:21 AM, rajeev kumar > wrote: >> On Fri, Apr 3, 2015 at 1:31 AM, Kamal Dasu wrote: >>> Adding support for

Re: [V2 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

2015-04-15 Thread rajeev kumar
On Fri, Apr 3, 2015 at 1:31 AM, Kamal Dasu wrote: > Adding support for i2c controller driver for Broadcom settop > SoCs. > > Signed-off-by: Kamal Dasu > --- > V2 changes > - Separate commits for device tree bindings and >initial i2c-brcmstb driver code > --- > drivers/i2c/busses/Kconfig

Re: [PATCH v3 2/2] i2c: cadence: Check for errata condition involving master receive

2014-12-05 Thread rajeev kumar
-EOPNOTSUPP for such sequences. > > Signed-off-by: Harini Katakam > Signed-off-by: Vishnu Motghare > --- > > v3: > Add warning in case of unsupported transfer. > Reviewed-by: Rajeev Kumar > v2: > Dont defeteature repeated start. Just check for unsupported conditions in the

Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-04 Thread rajeev kumar
On Wed, Dec 3, 2014 at 6:05 PM, Harini Katakam wrote: > The I2C controller sends a NACK to the slave when transfer size register > reaches zero, irrespective of the hold bit. So, in order to handle transfers > greater than 252 bytes, the transfer size register has to be maintained at a > value >=

Re: [PATCH v4] i2c: stu300: use devm managed resources

2012-07-16 Thread Rajeev kumar
te: based on a clean v3.5-rc6, may need some patch -p1< patch to apply on the i2c tree, if you want me to rebase it, just tell me where to find the baseline. Reviewed By: Rajeev Kumar ~Rajeev -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the

Re: [PATCH v3 2/4] i2c: i2c-ocores: Use reg-shift property

2012-07-15 Thread Rajeev kumar
diff --git a/include/linux/i2c-ocores.h b/include/linux/i2c-ocores.h index 4d5e57f..5d95df2 100644 --- a/include/linux/i2c-ocores.h +++ b/include/linux/i2c-ocores.h @@ -12,7 +12,7 @@ #define _LINUX_I2C_OCORES_H struct ocores_i2c_platform_data { - u32 regstep; /* distance between registers *

Re: [PATCH v3 1/4] i2c: i2c-ocores - DT bindings and minor fixes.

2012-07-15 Thread Rajeev kumar
0; @@ -351,7 +320,7 @@ static int __devinit ocores_i2c_probe(struct platform_device *pdev) return 0; } -static int __devexit ocores_i2c_remove(struct platform_device* pdev) +static int __devexit ocores_i2c_remove(struct platform_device *pdev) { struct ocores_i2c *i2c = platform_get_drvdata(pdev); Reviewed By: Rajeev Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] i2c/designware: Provide optional i2c bus recovery function

2012-07-01 Thread Rajeev kumar
Hello Shubhrajyoti, On 7/2/2012 12:02 PM, Shubhrajyoti Datta wrote: On Mon, Jul 2, 2012 at 11:28 AM, Rajeev kumar wrote: Hi Shubhrajyoti, On 2/27/2012 3:40 PM, Rajeev kumar wrote: On 2/27/2012 2:42 PM, Shubhrajyoti Datta wrote: On Mon, Feb 27, 2012 at 12:57 PM, Laxman Dewangan wrote

Re: [PATCH 2/2] i2c/designware: Provide optional i2c bus recovery function

2012-07-01 Thread Rajeev kumar
Hi Shubhrajyoti, On 2/27/2012 3:40 PM, Rajeev kumar wrote: On 2/27/2012 2:42 PM, Shubhrajyoti Datta wrote: On Mon, Feb 27, 2012 at 12:57 PM, Laxman Dewangan wrote: On Monday 27 February 2012 12:51 PM, Shubhrajyoti Datta wrote: On Fri, Feb 24, 2012 at 5:01 PM, Viresh Kumarwrote: From

Re: [PATCH V3 0/2] I2C: Add bus recovery infrastructure

2012-04-17 Thread Rajeev kumar
Tested By: Rajeev Kumar Rgds Rajeev -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] i2c/designware: Provide optional i2c bus recovery function

2012-02-27 Thread Rajeev kumar
Hello Shubhrajyoti On 2/27/2012 2:42 PM, Shubhrajyoti Datta wrote: On Mon, Feb 27, 2012 at 12:57 PM, Laxman Dewangan wrote: On Monday 27 February 2012 12:51 PM, Shubhrajyoti Datta wrote: On Fri, Feb 24, 2012 at 5:01 PM, Viresh Kumarwrote: From: Vincenzo Frascino Add optional i2c_recov

Re: [PATCH 2/2] i2c/designware: Provide optional i2c bus recovery function

2012-02-27 Thread Rajeev kumar
On 2/27/2012 1:52 PM, Laxman Dewangan wrote: On Monday 27 February 2012 01:40 PM, Rajeev kumar wrote: On 2/27/2012 12:57 PM, Laxman Dewangan wrote: On Monday 27 February 2012 12:51 PM, Shubhrajyoti Datta wrote: On Fri, Feb 24, 2012 at 5:01 PM, Viresh Kumar wrote: From: Vincenzo Frascino

Re: [PATCH 2/2] i2c/designware: Provide optional i2c bus recovery function

2012-02-27 Thread Rajeev kumar
On 2/27/2012 12:57 PM, Laxman Dewangan wrote: On Monday 27 February 2012 12:51 PM, Shubhrajyoti Datta wrote: On Fri, Feb 24, 2012 at 5:01 PM, Viresh Kumar wrote: From: Vincenzo Frascino Add optional i2c_recover_bus() function to the Synopsys DesignWare I2C adapter driver that performs i2c bu

Re: [PATCH] i2c-eg20t: use i2c_add_numbered_adapter to get a fixed bus number

2012-01-12 Thread Rajeev kumar
if (ret) { pch_pci_err(pdev, "i2c_add_adapter[ch:%d] FAILED\n", i); goto err_add_adapter; Reviewd By: Rajeev Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord..

Re: About one i2c failure issue after system reset

2011-11-21 Thread Rajeev kumar
Hello Jason On 11/21/2011 1:05 PM, Jason Hui wrote: Hi, Ben, Jean, I have one issue about the i2c failure: there will be on-going i2c transfer while system get reset. At the time when the reset happens, the slave may pull the SDA to LOW.After reset, the i2c master may reset, but the slave may s

Re: [PATCH V2] i2c-designware: Change readl to readw and writel to writew

2011-10-26 Thread Rajeev kumar
Hello Baruch On 10/24/2011 5:53 PM, Baruch Siach wrote: Hi Rajeev, On Mon, Oct 24, 2011 at 04:38:26PM +0530, Rajeev kumar wrote: On 10/24/2011 4:03 PM, Baruch Siach wrote: On Mon, Oct 24, 2011 at 03:28:02PM +0530, Rajeev Kumar wrote: Since I2C designware registers are 16 bit wide and so we

Re: [PATCH V2] i2c-designware: Change readl to readw and writel to writew

2011-10-24 Thread Rajeev kumar
Hi Baruch On 10/24/2011 4:03 PM, Baruch Siach wrote: Hi Rajeev, On Mon, Oct 24, 2011 at 03:28:02PM +0530, Rajeev Kumar wrote: Since I2C designware registers are 16 bit wide and so we should use readw/writew. Signed-off-by: Rajeev Kumar --- drivers/i2c/busses/i2c-designware.c | 104

[PATCH V2] i2c-designware: Change readl to readw and writel to writew

2011-10-24 Thread Rajeev Kumar
Since I2C designware registers are 16 bit wide and so we should use readw/writew. Signed-off-by: Rajeev Kumar --- drivers/i2c/busses/i2c-designware.c | 104 +- 1 files changed, 52 insertions(+), 52 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware.c

Re: [PATCH] i2c-designware: Change readl to readw and writel to writew

2011-10-24 Thread Rajeev kumar
Hello Baruch On 10/24/2011 10:33 AM, Baruch Siach wrote: Hi Rajeev, On Mon, Oct 24, 2011 at 09:54:53AM +0530, Rajeev Kumar wrote: Since I2C designware registers are 16 bit wide and so we should use readw/writew. Signed-off-by: Rajeev Kumar --- For completeness I think you should also

Re: [PATCH ] i2c: omap: recover from Bus Busy condition

2011-10-24 Thread Rajeev kumar
machine. A WARN_ON() will be generated when a BB timeout happens. Signed-off-by: Vikram Pandita Signed-off-by: Shubhrajyoti D --- drivers/i2c/busses/i2c-omap.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) Reviewed-by: Rajeev Kumar ~Rajeev -- To unsubscribe

[PATCH] i2c-designware: Change readl to readw and writel to writew

2011-10-23 Thread Rajeev Kumar
Since I2C designware registers are 16 bit wide and so we should use readw/writew. Signed-off-by: Rajeev Kumar --- drivers/i2c/busses/i2c-designware.c | 84 +- 1 files changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware.c