SATAPI timing

2005-01-28 Thread gp
Jeff I think I may have found an issue in the ATAPI code in the function atapi_packet_task. From my testing with the sata_via driver, I have been getting a timeout when sending the first inquiry command. Here is the section of code of interest: /* make sure DRQ is set */ status = at

Re: SATAPI timing

2005-01-28 Thread Jeff Garzik
gp wrote: Jeff I think I may have found an issue in the ATAPI code in the function atapi_packet_task. From my testing with the sata_via driver, I have been getting a timeout when sending the first inquiry command. Here is the section of code of interest: /* make sure DRQ is set */ stat

Re: Marvell 88SX[56]0[48]1 libata progress?

2005-01-28 Thread Bogdan Costescu
On Thu, 27 Jan 2005, Jeff Garzik wrote: > After that, I'll do a round of driver writing for Marvell and several other > boards. Any tentative time-frame ? I'm also interested due to the presence of this controller disguised as Adaptec AIC-8110 on my Asus mainboard. Unfortunately Asus only prov

[RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
Howdy! Some IDE drives destined for use in server class or datacenter machines will come with "write cache" disabled. With the current code, the setting of the drive is effectively ignored, and the cache is always enabled if the drive has cache. It is hard to define or enable certain behaviors t

[RFC/PATCH 3/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
- Add documentation for the use of the Kbuild variable BLK_DEV_HDWC. drivers/ide/Kconfig | 11 +++ 1 files changed, 11 insertions(+) diff -X /home/dwm/lib/ide-excludes -Nwupar lk-2.6.11-rc2-bk5.a/drivers/ide/Kconfig lk-2.6.11-rc2-bk5.b/drivers/ide/Kconfig --- lk-2.6.11-rc2-

[RFC/PATCH 2/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
- add hook in ide-taskfile:ide_cmd_ioctl() to call the new function ide_write_cache(). drivers/ide/ide-taskfile.c | 10 ++ 1 files changed, 10 insertions(+) diff -X /home/dwm/lib/ide-excludes -Nwupar lk-2.6.11-rc2-bk5.a/drivers/ide/ide-taskfile.c lk-2.6.11-rc2-bk5.b/driver

[RFC/PATCH 4/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
- use new config variable BLK_DEV_HDWC in idedisk_setup code. include/linux/ide.h|5 + drivers/ide/ide-disk.c |4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff -X /home/dwm/lib/ide-excludes -Nwupar lk-2.6.11-rc2-bk5.a/include/linux/ide.h lk-2.6.11-rc2-bk5.b/inc

[RFC/PATCH 5/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
- remove (now obsolete) write_cache() from ide-disk.c. replace calls in ide-disk.c with calls to ide_write_cache(). drivers/ide/ide-disk.c | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) diff -X /home/dwm/lib/ide-excludes -Nwupar lk-2.6.11-rc2-b

[RFC/PATCH 6/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
- change the way that ide_write_cache controls the use of flushing via blk_queue_ordered() to match the setting of the drive's write cache setting. This patch leaves the idedisk_issue_flush in ide-disk.c, but the func could be moved to ide-io to complete the break of t

[RFC/PATCH 7/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
- move idedisk_issue_flush to ide-io.c supporting ide_write_cache() include/linux/ide.h|1 - drivers/ide/ide-disk.c | 38 -- drivers/ide/ide-io.c | 36 3 files changed, 36 insertions(+), 39 deletions

[RFC/PATCH 7/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
Howdy! Some IDE drives destined for use in server class or datacenter machines will come with "write cache" disabled. With the current code, the setting of the drive is effectively ignored, and the cache is always enabled if the drive has cache. It is hard to define or enable certain behaviors t

Re: Marvell 88SX[56]0[48]1 libata progress?

2005-01-28 Thread Jeff Garzik
Bogdan Costescu wrote: On Thu, 27 Jan 2005, Jeff Garzik wrote: After that, I'll do a round of driver writing for Marvell and several other boards. Any tentative time-frame ? I'm also interested due to the presence of this controller disguised as Adaptec AIC-8110 on my Asus mainboard. Unfortuna

Re: [RFC/PATCH 7/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
On Fri, 28 Jan 2005 12:17:24 CST, Doug Maxey wrote: >Howdy! > Whoops! looks like the script needs a little work. Disregard this one. :-/ And they all need a Signed-off-by line. sigh. ++doug - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EM

Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Bartlomiej Zolnierkiewicz
On Fri, 28 Jan 2005 12:16:01 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > Howdy! Hi, > Some IDE drives destined for use in server class or datacenter > machines will come with "write cache" disabled. With the current > code, the setting of the drive is effectively ignored, and the cache > is

Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
On Fri, 28 Jan 2005 20:11:37 +0100, Bartlomiej Zolnierkiewicz wrote: >On Fri, 28 Jan 2005 12:16:01 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > >We have too many config options already. > >Behavior should be simple: >* no cache flushes - wcache off by default >* cache flushes - wcache on by defa

Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Bartlomiej Zolnierkiewicz
On Fri, 28 Jan 2005 15:06:22 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > > On Fri, 28 Jan 2005 20:11:37 +0100, Bartlomiej Zolnierkiewicz wrote: > >On Fri, 28 Jan 2005 12:16:01 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > > > >We have too many config options already. > > > >Behavior should be

Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
On Fri, 28 Jan 2005 22:35:17 +0100, Bartlomiej Zolnierkiewicz wrote: >On Fri, 28 Jan 2005 15:06:22 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: >> >> On Fri, 28 Jan 2005 20:11:37 +0100, Bartlomiej Zolnierkiewicz wrote: >> >On Fri, 28 Jan 2005 12:16:01 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote:

Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Bartlomiej Zolnierkiewicz
On Fri, 28 Jan 2005 15:43:52 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > > On Fri, 28 Jan 2005 22:35:17 +0100, Bartlomiej Zolnierkiewicz wrote: > >On Fri, 28 Jan 2005 15:06:22 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > >> > >> On Fri, 28 Jan 2005 20:11:37 +0100, Bartlomiej Zolnierkiewicz wr

Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
On Fri, 28 Jan 2005 22:49:08 +0100, Bartlomiej Zolnierkiewicz wrote: >On Fri, 28 Jan 2005 15:43:52 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: >> >> On Fri, 28 Jan 2005 22:35:17 +0100, Bartlomiej Zolnierkiewicz wrote: >> >On Fri, 28 Jan 2005 15:06:22 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote:

Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Bartlomiej Zolnierkiewicz
On Fri, 28 Jan 2005 16:15:40 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > > On Fri, 28 Jan 2005 22:49:08 +0100, Bartlomiej Zolnierkiewicz wrote: > >On Fri, 28 Jan 2005 15:43:52 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > >> > >> On Fri, 28 Jan 2005 22:35:17 +0100, Bartlomiej Zolnierkiewicz wr

simple use wcache from drive (was)Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Doug Maxey
On Fri, 28 Jan 2005 23:32:53 +0100, Bartlomiej Zolnierkiewicz wrote: >> The datacenters/server folks that would be using these drives would >> expect them to remain as set. I have to check, but unless something >> has changed very recently in the kernel, setting with hdparm does not >> "stick" in

Re: simple use wcache from drive (was)Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Bartlomiej Zolnierkiewicz
On Fri, 28 Jan 2005 16:54:49 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > > On Fri, 28 Jan 2005 23:32:53 +0100, Bartlomiej Zolnierkiewicz wrote: > >> The datacenters/server folks that would be using these drives would > >> expect them to remain as set. I have to check, but unless something > >>

Re: simple use wcache from drive (was)Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Bartlomiej Zolnierkiewicz
On Fri, 28 Jan 2005 23:56:41 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Fri, 28 Jan 2005 16:54:49 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > > > > On Fri, 28 Jan 2005 23:32:53 +0100, Bartlomiej Zolnierkiewicz wrote: > > >> The datacenters/server folks that would be using t

Re: [RFC PATCH 2.4] ata_piix on ich6r in RAID mode

2005-01-28 Thread Jeff Garzik
Martins Krikis wrote: Without this patch, if the BIOS of an ICH6R box has IDE set to "RAID" mode then ata_piix will not find any SATA disks because it incorrectly tries the legacy mode. With the patch all 4 SATA drives become visible. I don't think it would break any other vendor's SATA, but you ca

Re: [RFC PATCH 2.4] ata_piix on ich6r in RAID mode

2005-01-28 Thread Martins Krikis
--- Jeff Garzik <[EMAIL PROTECTED]> wrote: > Martins Krikis wrote: > > Without this patch, if the BIOS of an ICH6R box has IDE set to > "RAID" > > mode then ata_piix will not find any SATA disks because it > incorrectly > > tries the legacy mode. With the patch all 4 SATA drives become > visible.

[BK PATCH] 2.6.x libata oops fix

2005-01-28 Thread Jeff Garzik
BK info and patch attached. Please do a bk pull bk://gkernel.bkbits.net/libata-2.6 This will update the following files: drivers/scsi/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) through these ChangeSets: <[EMAIL PROTECTED]> (05/01/28 1.1987) [PATCH] fi