Code intended to check DMA status was checking DMA command register.
Moreover firmware seems to forget to set DMA capable bit for the
slave device (at least in RAID mode but without ITE RAID volumes) so
check device ID for DMA capable bit when deciding whether to use DMA
and remove DMA status
I just wanted to have a look at the patch and see if it works for me -
looks like somethings not all straight, I get this while booting:
ahci :00:1f.2: version 2.2
ACPI: PCI Interrupt :00:1f.2[C] - GSI 19 (level, low) - IRQ 19
ahci :00:1f.2: nr_ports (3) and implemented port map
Problem Sata disks are connected to onboard sata ports of PowerEdge
1900 (ESB2 southbridge chipset). If one of the port is disabled in
the bios then they get enabled again by the ata_piix driver because
of a default port map being written to the Port control and status
This is very different from the patch I posted a while ago turning on
a few bits in the CMD register (ALPE and ASP) and which Intel is
we've not seen a patch that actually works in this area unfortunately.
We know Kristen's patch does work
apparently now trying. That only saves around
Peter Ganzhorn [EMAIL PROTECTED] writes:
I just wanted to have a look at the patch and see if it works for me -
looks like somethings not all straight, I get this while booting:
ahci :00:1f.2: version 2.2
ACPI: PCI Interrupt :00:1f.2[C] - GSI 19 (level, low) - IRQ 19
ahci
Hello,
[EMAIL PROTECTED] wrote:
What happens if the port is enabled by the kernel?
The BIOS tests for the device will not be performed for the port
since it is disabled by the BIOS, and there is a potential security
problem here if they get reenabled in the kernel.
You're trying to protect
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5 Watts. It has been tested by the kind folks at
This patch will modify the scsi and ata subsystem to allow
users to set a power management policy for the link.
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user sets up if the driver supports
it. This
This patch will set the correct bits to turn on Aggressive
Link Power Management (ALPM) for the ahci driver. This
will cause the controller and disk to negotiate a lower
power state for the link when there is no activity (see
the AHCI 1.x spec for details). This feature is mutually
exclusive
On Mon, 11 Jun 2007 07:05:38 -0700
Arjan van de Ven [EMAIL PROTECTED] wrote:
This is very different from the patch I posted a while ago turning on
a few bits in the CMD register (ALPE and ASP) and which Intel is
we've not seen a patch that actually works in this area unfortunately.
We
Kristen Carlson Accardi wrote:
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Seems OK, though a bit disappointing that this cannot
Kristen Carlson Accardi wrote:
This patch will set the correct bits to turn on Aggressive
Link Power Management (ALPM) for the ahci driver. This
will cause the controller and disk to negotiate a lower
power state for the link when there is no activity (see
the AHCI 1.x spec for details). This
On Thu, 24 May 2007 23:15:56 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Kristen Carlson Accardi wrote:
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
---
Andrew, I cleaned up the function
Mark Lord wrote:
Russell King wrote:
Before you do, it might help to build the ide-disk module and insert
that
as well?
ARrrggghh!! Of course, that would explain the utter lack
of disk partition check messages, now wouldn't it!
Thanks Russell !
Doh! yes that would obviously help.
With
Well actually I did not worry about the warning, this particular part
made me worry much more:
Call Trace:
[804a99ce] ata_eh_set_powersave+0x34e/0x370
[8048c7b0] scsi_error_handler+0x0/0x330
[804a9e27] ata_do_eh+0xb7/0x16f0
[80229f9d]
Robert de Rooy wrote:
(after applying the ide-polling experimental patch)
With this I can declare success!! I was able to read and write to the
card without any problems, although I did not try to stress it.
Jun 12 00:19:42 localhost kernel: pccard: PCMCIA card inserted into slot 0
Jun 12
Peter Ganzhorn [EMAIL PROTECTED] writes:
Well actually I did not worry about the warning, this particular part
made me worry much more:
This comes with the warning. The warning prints this stack trace.
Call Trace:
[804a99ce] ata_eh_set_powersave+0x34e/0x370
[8048c7b0]
Kristen Carlson Accardi [EMAIL PROTECTED] writes:
[...]
I've updated the hardware based patches and posted to the mailing list -
they do indeed save anywhere from .6-1.5 watts depending on the system,
on my X60 they save about a watt. I don't think that a hardware based
solution is
On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
Setting Effect
--
min_power ALPM is enabled, and link set to enter
lowest power state (SLUMBER) when idle
Hot plug not allowed.
Henrique de Moraes Holschuh wrote:
On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
Setting Effect
--
min_power ALPM is enabled, and link set to enter
lowest power state (SLUMBER) when idle
Hot plug not
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5 Watts. It has
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5
Arjan van de Ven [EMAIL PROTECTED] writes:
Henrique de Moraes Holschuh wrote:
On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
Setting Effect
--
min_power ALPM is enabled, and link set to enter lowest
power
Arjan van de Ven wrote:
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for
AHCI devices, as documented in the AHCI spec. On my laptop (a Lenovo
X60), this
saves me a full watt of power. On other systems, reported power
Jeff Garzik wrote:
Arjan van de Ven wrote:
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for
AHCI devices, as documented in the AHCI spec. On my laptop (a
Lenovo X60), this
saves me a full watt of power. On other
Arjan van de Ven wrote:
Jeff Garzik wrote:
SATA standard defines lower power phy states. So the same argument
you're using for AHCI applies there too -- just enabling an existing
hardware feature.
yes I'm not arguing against that. I was trying to find out (and
Mark Lord wrote:
Robert de Rooy wrote:
(after applying the ide-polling experimental patch)
With this I can declare success!! I was able to read and write to the
card without any problems, although I did not try to stress it.
Jun 12 00:19:42 localhost kernel: pccard: PCMCIA card inserted
On Mon, 11 Jun 2007, Jeff Garzik wrote:
on/off doesn't really make sense if the question is do you favor power
or do you favor performance...
Actually, it does if you think of it as do you need hotplug right now or
not?.
How about just making it a numeric scale with 0 meaning no power
Arjan van de Ven wrote:
I'm not sure about this. We need better PM framework to support
powersaving in other controllers and some ahcis don't save much
when only link power management is used,
do you have data to support this?
Yeah, it was some Lenovo notebook. Pavel is more familiar
Arjan van de Ven wrote:
The data we have from this patch is that it saves typically a Watt of
power (depends on the machine of course, but the range is 0.5W to
1.5W). If you want to also have an even more agressive thing where
you want to start disabling the entire controller... I don't see
We will do AHCI link PM -- presuming that I can be convinced that it
does not repeatedly park the hard drive heads, or something similarly
annoying on PATA-SATA bridges and similar setups.
IF it works as advertised -- a big if considering all the AHCI silicon
implementations out there -- we
32 matches
Mail list logo
