Re: [PATCH 2.6.22-rc5] libata: add HTS541616J9SA00 to NCQ blacklist

2007-07-02 Thread Tejun Heo
Tejun Heo wrote: > Another member of HTS5416* family doing spurious NCQ completion. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > Cc: Enrico Sardi <[EMAIL PROTECTED]> Jeff, ping. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EM

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Tejun Heo
Stefan Skotte wrote: > Hi, > > I was wondering what the odds are that my setup could be supported: > > * Stardom/Raidon SOHOTANK ST-6600 (5 disk SATA array) > (http://www.stardom.com.tw/sohotank%20st6600.htm) > * STLab Silicon Image 3531 NCQ/FIS PMP PCIe adapter with one eSATA port > (uses sata_s

Re: [PATCHBOMB] libata: Port Multiplier support

2007-07-02 Thread Robin H. Johnson
On Sun, Jul 01, 2007 at 06:30:15PM +0900, Tejun Heo wrote: > it took longer than I expected but it's complete now and looking good. > It's composed of the following four patchsets. These are looking great Tejun. My previous porting attempt got delayed partway through with other work stuff. I can'

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Tejun Heo
Stefan Skotte wrote: > drivers/scsi/ipr.c: In function __ipr_eh_dev_reset: > drivers/scsi/ipr.c:3955: warning: passing argument 4 of ata_do_eh from > incompatible pointer type > drivers/scsi/ipr.c: In function ipr_ata_phy_reset: > drivers/scsi/ipr.c:5049: error: struct ata_port has no membe

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Stefan Skotte
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tejun Heo wrote: > Stefan Skotte wrote: >> Hi, >> >> I was wondering what the odds are that my setup could be supported: >> >> * Stardom/Raidon SOHOTANK ST-6600 (5 disk SATA array) >> (http://www.stardom.com.tw/sohotank%20st6600.htm) >> * STLab Silicon

Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller

2007-07-02 Thread Thorsten Leemhuis
On 02.07.2007 07:02, Thorsten Leemhuis wrote: > On 28.06.2007 21:47, Chuck Ebbert wrote: >> On 06/28/2007 03:16 PM, Chuck Ebbert wrote: >> >> [Forgot to mark subj: as a patch; attached] >> >>> From: Christian Lamparter <[EMAIL PROTECTED]> >>> >>> ATA: add a PCI ID for Intel Santa Rosa PATA controll

Re: [PATCHBOMB] libata: Port Multiplier support

2007-07-02 Thread Tejun Heo
orting attempt got delayed partway through with other work > stuff. > > I can't change kernels on my PMP box right now, but I'll test a bit > later this week. Thanks. Patches against 2.6.22-rc6 are available too. http://home-tj.org/files/libata-tj-stable/libata-tj-2.6.22-rc

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Stefan Skotte
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Tejun, I've just compiled, and I'm now running the kernel with the patches applied. It seems to work, however I'm not sure why the SATA Link is 1.5gb/s ? Both my disks are SATA-II 300. Here's some system information related to the patch(es): ===

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Tejun Heo
Stefan Skotte wrote: > I've just compiled, and I'm now running the kernel with the patches applied. > > It seems to work, however I'm not sure why the SATA Link is 1.5gb/s ? > Both my disks are SATA-II 300. I dunno either. Does it come up as 3Gbps if you connect it directly to the controller? >

Re: CF flash PATA on libata failure to attach

2007-07-02 Thread Tejun Heo
Alan Cox wrote: > On Fri, Jun 29, 2007 at 05:34:36PM +1000, Andrew Hall wrote: >> Further to this the PATA to SATA bridge being used in this case is: >> >> http://www.jmicron.com/JM20330.html >> >> ..as you will see only PIO and UDMA modes are supported. > > In which case their microcontroller in

Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller

2007-07-02 Thread Chr
On Monday, 2. July 2007, you wrote: > On 02.07.2007 07:02, Thorsten Leemhuis wrote: > Hmmm. From looking at the ICH8-Datasheet ( > http://www.intel.com/design/chipsets/datashts/313056.htm > or http://download.intel.com/design/chipsets/datashts/31305603.pdf ) > page 189 and later it seems to me that

Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller

2007-07-02 Thread Thorsten Leemhuis
On 02.07.2007 13:24, Chr wrote: > On Monday, 2. July 2007, you wrote: >> On 02.07.2007 07:02, Thorsten Leemhuis wrote: >> Hmmm. From looking at the ICH8-Datasheet ( >> http://www.intel.com/design/chipsets/datashts/313056.htm >> or http://download.intel.com/design/chipsets/datashts/31305603.pdf ) >>

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Stefan Skotte
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey Tejun, Here's a few tries at testing the power on/off, unplugging disks: Here's the full log after a reboot, and me powering up the array manually afterwards: [ 9995.743400] ata1: exceptio

Re: [PATCH 2.6.22-rc6] add PCI-ID for Adaptec 1430SA 4-Port SATA Controller

2007-07-02 Thread Jeff Garzik
Florian Attenberger wrote: Hi, added this pci id to support my: lspci: 01:00.0 RAID bus controller: Adaptec Unknown device 0243 (rev 02) lspci -n: 01:00.0 0104: 9005:0243 (rev 02) seems to work fine. florian attenberger --- 2.6.22-rc6/drivers/ata/sata_mv.c2007-06-30 16:21:47.462020256 +0

Re: [PATCH 2.6.22-rc6] libata: remove reading alt_status from ata_hsm_qc_complete()

2007-07-02 Thread Jeff Garzik
Albert Lee wrote: In ata_hsm_qc_complete(): Calling ata_altstatus() after the qc is completed might race with next qc. Remove it. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- Jeff, (Sorry for re-submitting this patch so late.) The unneeded reading of alt_status might cause trouble when an

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-07-02 Thread Jeff Garzik
Albert Lee wrote: Recently the PLL input clock of pata_pdc2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). It seems sometimes the mdelay() function is not as precise as it used to be. Per Alan's advice, HT or power management might affect the precision of

Re: [PATCH] sata_inic162x: disable LBA48 devices

2007-07-02 Thread Jeff Garzik
Tejun Heo wrote: sata_inic162x can't do LBA48 properly yet and is likely to corrupt data on drives larger than LBA28 limit. Disable LBA48 devices during device configuration. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/sata_inic162x.c |7 +++ 1 file changed, 7 insertio

Re: [PATCH -mm] sata_nv: allow changing queue depth

2007-07-02 Thread Jeff Garzik
Robert Hancock wrote: The sata_nv driver was missing the change_queue_depth hook in the SCSI host template which the other NCQ-capable libata drivers had. This made it impossible to change the queue depth by user request. Add this in. Signed-off-by: Robert Hancock <[EMAIL PROTECTED]> --- linux-

Re: [PATCH 2.6.22-rc5] libata: add HTS541616J9SA00 to NCQ blacklist

2007-07-02 Thread Jeff Garzik
Tejun Heo wrote: Another member of HTS5416* family doing spurious NCQ completion. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Enrico Sardi <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata

Re: [PATCH 2.6.22-rc4]: libata: PATA-mode fixes for sis_sata

2007-07-02 Thread Jeff Garzik
Uwe Koziolek wrote: Changed PATA handler for PATA-ports used by sata_sis. This patch was originally submitted by Jeff Garzik. Added PCI-ID 1180 for SiS966 Controller in pata_sis. The 1180 mode is fully compatible to other SiS PATA-controller. The PCI-ID 1183 is SATA in PATA-emulation, but not f

Re: [PATCH 2.6.22-rc6+mboxjeff 2/3] pata_sis: new PCI ID

2007-07-02 Thread Jeff Garzik
Uwe Koziolek wrote: The SiS966 has an alternate PCI-ID 1180 for an IDE compatible controller The primaty channel acts as PATA-controller, the secondary channel acts as SATA-controller in PATA-emulation. Signed-off-by: Uwe Koziolek <[EMAIL PROTECTED]> --- a/drivers/ata/pata_sis.c2007-06-30 0

Re: [PATCH] ide: add ide_dev_has_iordy() helper (take 4)

2007-07-02 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add ide_dev_has_iordy() helper and use it sl82c105 host driver. * Remove no longer needed ide_pio_data_t.use_iordy field. v2/v3: * Fix issues noticed by Sergei: - correct patch description - fix comment in ide_get_best_pio_mode() v4: * Fix "

Re: PROBLEM: ata_piix.c for the ICH5 SATA Controller.

2007-07-02 Thread Johny Mail list
2007/6/29, Mark Lord <[EMAIL PROTECTED]>: Mark Lord wrote: > Johny Mail list wrote: >> 2007/6/28, Mark Lord <[EMAIL PROTECTED]>: >>> I have an ugly (but working) hack for the ICH5 ata_piix driver >>> to support hot insertion/removal of drives, but I don't know if/when >>> I'll be pushing it upstr

Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller

2007-07-02 Thread Chr
On Monday, 2. July 2007, Thorsten Leemhuis wrote: > > but Alan Cox wrote: > > http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg07417.html > >> Its ich_pata_133 - all the newer chips are. > > Intel afaik never supported Ultra ATA 133 officially in any of the > mainstream desktop or mobile

[git patches] libata fixes

2007-07-02 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/Kconfig |5 drivers/ata/libata-core.c |3 +- drivers/ata/pata_pdc2027x.c | 11 - drivers/

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Tejun Heo
Hello, Stefan Skotte wrote: > > Here's the full log after a reboot, and me powering up the array > manually afterwards: > > [ 9995.743400] ata1: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0xa > frozen > [ 9995.743409] ata1: irq_stat 0x00

[PATCH 2.6.22-rc6] sata_mv: PCI-ID for Adaptec 1430SA SATA Controller

2007-07-02 Thread Florian Attenberger
Signed-off-by: Florian Attenberger <[EMAIL PROTECTED]> --- 2.6.22-rc6/drivers/ata/sata_mv.c2007-06-30 16:21:47.462020256 +0200 +++ 2.6.22-rc6.mine/drivers/ata/sata_mv.c 2007-06-30 16:25:25.999165444 +0200 @@ -582,6 +582,9 @@ static const struct pci_device_id mv_pci { PCI_VDE

[info] What's in libata-dev.git?

2007-07-02 Thread Jeff Garzik
What follows are the changes contained in libata-dev.git, listed on a branch-by-branch basis. The double "" lines separate each branch's contents. Each branch is accompanied by a 'STATUS' line, indicating the upstream status of each branch. I have patches from Alan (pata_sis FIFO whack, pa

Re: [PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-07-02 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Check IORDY bit for PIO modes > 2. * Some devices claim maximum PIO mode > 2 in id->tPIO, they were punished too severly for this by being limited to PIO_SLOW. Limit them to PIO2 instead. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTE

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * ->speedproc, filter out invalid modes passed from user-space. * Add FIXME about DMA timings never being set. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Index: b/drivers/ide/pci/alim15x3.c =

Re: [info] What's in libata-dev.git?

2007-07-02 Thread Alan Cox
On Mon, 2 Jul 2007 11:16:39 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > What follows are the changes contained in libata-dev.git, listed on a > branch-by-branch basis. The double "" lines separate each branch's > contents. Each branch is accompanied by a 'STATUS' line, indicating th

[PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting

2007-07-02 Thread Tejun Heo
host->irq and host->irq2 should be set before ata_host_register() for IRQ reporting to work. Move up host->irq assignment in ata_host_activate() and add it to ata_pci_init_one() native path and pata_cs5520. The port info printing in ata_host_register() doesn't fit all the different controllers.

[info] What's in Jeff's libata-dev inbox?

2007-07-02 Thread Jeff Garzik
I have patches from Alan (pata_sis FIFO whack, pata_dma option), Tejun, Albert and Kristen still to be reviewed. Will get to those on Friday, after the July 4th US holiday.tions(-) Just to be more specific, my to-review inbox contains: Alan: pata_sis FIFO whack, pata_dma option Tejun: PMP pat

Re: [PATCH 7/15] ide: drop "PIO data" argument from ide_get_best_pio_mode()

2007-07-02 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Drop no longer needed "PIO data" argument from ide_get_best_pio_mode() and convert all users accordingly. * Remove no longer needed ide_pio_data_t. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL

Re: [PATCH] ide: add ide_dev_has_iordy() helper (take 4)

2007-07-02 Thread Bartlomiej Zolnierkiewicz
Hello, On Monday 02 July 2007, you wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > * Add ide_dev_has_iordy() helper and use it sl82c105 host driver. > > > * Remove no longer needed ide_pio_data_t.use_iordy field. > > > v2/v3: > > * Fix issues noticed by Sergei: > > - correct patch d

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > * ->speedproc, filter out invalid modes passed from user-space. > > > * Add FIXME about DMA timings never being set. > > > * Bump driver version. > > > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED

Re: [PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > * Check IORDY bit for PIO modes > 2. > > > * Some devices claim maximum PIO mode > 2 in id->tPIO, they were punished > > too > > severly for this by being limited to PIO_SLOW. Limit them to PIO2

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-07-02 Thread Bartlomiej Zolnierkiewicz
Hi, Could you also fix pdc202xx_new driver? "buggy" code should be very similar if not identical... On Tuesday 26 June 2007, Albert Lee wrote: > Recently the PLL input clock of pata_pdc2027x is sometimes detected > higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). > It seems sometim

Re: [PATCH] ide: add ide_pio_cycle_time() helper (take 2)

2007-07-02 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add ide_pio_cycle_time() helper. The side effect is that cycle time "clamping" for the pre ATA-2 drives is now done for the explicitly specified modes too. * Use it in ali14xx/ht6560b/qd65xx/cmd64{0,x}/sl82c105 and pmac host drivers (previous

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-07-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Hi, Could you also fix pdc202xx_new driver? "buggy" code should be very similar if not identical... I was going to do that but since I'm only working part-time in the last few days, this keeps being deferred. Also, I need to find the card... MBR, Ser

Re: [PATCH 7/15] ide: drop "PIO data" argument from ide_get_best_pio_mode()

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > * Drop no longer needed "PIO data" argument from ide_get_best_pio_mode() > > and convert all users accordingly. > > > * Remove no longer needed ide_pio_data_t. > > > Signed-off-by: Bartlomiej Zo

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: This would brake setups which currently work OK, i.e. BIOS set things up (reminds me about cmd64x vs broken MWDMA)... The RightThing(tm) to do is to fix alim15x3 driver to program DMA timings (especially given that pata_ali seems to already contain the needed cod

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Jeff Garzik wrote: > Bartlomiej Zolnierkiewicz wrote: > > This would brake setups which currently work OK, i.e. BIOS set things up > > (reminds me about cmd64x vs broken MWDMA)... > > > > The RightThing(tm) to do is to fix alim15x3 driver to program DMA timings > > (especia

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Monday 02 July 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: This would brake setups which currently work OK, i.e. BIOS set things up (reminds me about cmd64x vs broken MWDMA)... The RightThing(tm) to do is to fix alim15x3 driver to program DMA t

Re: [PATCH] ide: add ide_pio_cycle_time() helper (take 2)

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > * Add ide_pio_cycle_time() helper. > > The side effect is that cycle time "clamping" for the pre ATA-2 drives is > now done for the explicitly specified modes too. Yep. > > * Use it in ali14

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Jeff Garzik wrote: > Bartlomiej Zolnierkiewicz wrote: > > On Monday 02 July 2007, Jeff Garzik wrote: > >> Bartlomiej Zolnierkiewicz wrote: > >>> This would brake setups which currently work OK, i.e. BIOS set things up > >>> (reminds me about cmd64x vs broken MWDMA)... > >>>

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Bartlomiej Zolnierkiewicz wrote: > On Monday 02 July 2007, Jeff Garzik wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > On Monday 02 July 2007, Jeff Garzik wrote: > > >> Bartlomiej Zolnierkiewicz wrote: > > >>> This would brake setups which currently work OK, i.e. BIOS set

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Alan Cox
> I am not ready to trust that pata_ali works as well as alim15x3 in all > cases. Someone should test e.g. Alpha AXP systems with IDE (use > alim15x3) to make sure all is well. My pata_ali is reported to do so. I don't know if yours does because my libata tree has some changes to set the contro

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Add the new code inside #ifdef X86, marking alim15x3 X86-only would be on over-kill... Ugh. That's not how we do Linux development. It is better to convert the new code and wait for alpha/sparc users to scream, than add platform ifdefs. To do so creates div

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Jeff Garzik
Alan Cox wrote: I am not ready to trust that pata_ali works as well as alim15x3 in all cases. Someone should test e.g. Alpha AXP systems with IDE (use alim15x3) to make sure all is well. My pata_ali is reported to do so. I don't know if yours does because my Good to hear, thanks for the inf

Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Jeff Garzik wrote: > Bartlomiej Zolnierkiewicz wrote: > > Add the new code inside #ifdef X86, marking alim15x3 X86-only would be > > on over-kill... My reply is taken out of context. > Ugh. That's not how we do Linux development. It is better to convert > the new code a

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Stefan Skotte
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Here's the full log from trying to reproduce error in powering array on/off: = modprobe sata_sil24 (array is already on)... [27635.288848] sata_sil24 :01:00.0: version 1.0 [27635.288873] ACPI: PCI Interrupt :01:00.

Re: [PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting

2007-07-02 Thread Francois Romieu
Tejun Heo <[EMAIL PROTECTED]> : > host->irq and host->irq2 should be set before ata_host_register() for > IRQ reporting to work. Move up host->irq assignment in > ata_host_activate() and add it to ata_pci_init_one() native path and > pata_cs5520. > > The port info printing in ata_host_register()

[git patch] fix the libata fix

2007-07-02 Thread Jeff Garzik
(this pulls everything in 'upstream-linus', too) Please pull from the 'upstream-linus2' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus2 to receive the previously sent changes, and in addition, the following fix: commit 531e3a61f55261bf466d0415c48999

[PATCH] sata_promise: SATA hotplug support, take 2

2007-07-02 Thread Mikael Pettersson
This patch enables hotplugging of SATA devices in the sata_promise driver. It's been tested successfully on both first- and second-generation Promise SATA chips: SATA150 TX2plus, SATAII150 TX2plus, SATAII150 TX4, SATA300 TX2plus, and SATA300 TX4. The only quirk I've seen is that hotplugging (inser

[PATCH 2.6.22-rc7] sata_sil24: sil24_interrupt() micro-optimisation

2007-07-02 Thread Mikael Pettersson
sil24_interrupt() loads host->ports[i] into a local variable, validates it, and then loads the value again in the call to sil24_host_intr(). This patch replaces the second load by a reference to the local variable. This is safe since no side-effects have occurred since the initial load. It also im

[PATCH] amd74xx: resume fix

2007-07-02 Thread Bartlomiej Zolnierkiewicz
* Driver can't skip programming transfer mode on the device in amd_set_drive() (similar fix has been applied to via82cxxx driver ages ago). * While at it remove redundant warning (ide_config_drive_speed() already produces more valuable one). * Bump driver version. Signed-off-by: Bartlomiej

[PATCH] it821x: fix incorrect SWDMA mask

2007-07-02 Thread Bartlomiej Zolnierkiewicz
SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always fail (due to sanity check in ->speedproc) and result in PIO being tuned. * Fix incorrect SWDMA mask so core code won't try these modes and will just tune PIO if no other DMA modes are available. * Bump driver version.

Re: [PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting

2007-07-02 Thread Tejun Heo
Francois Romieu wrote: > Tejun Heo <[EMAIL PROTECTED]> : >> host->irq and host->irq2 should be set before ata_host_register() for >> IRQ reporting to work. Move up host->irq assignment in >> ata_host_activate() and add it to ata_pci_init_one() native path and >> pata_cs5520. >> >> The port info pr

Re: State of Port Multiplier Support in libata?

2007-07-02 Thread Tejun Heo
Stefan Skotte wrote: > Here's the full log from trying to reproduce error in powering array on/off: > > = > * power off array.. > [27685.211956] ata4.15: failed to read PMP product ID > [27685.211962] ata4.15: retrying hardreset > [27685.211969] ata4.15: hard resett

[PATCH 1/1] ide: pdc202xx_new PLL input clock fix

2007-07-02 Thread Albert Lee
Recently the PLL input clock of Promise 2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). It seems sometimes the mdelay() function is not as precise as it used to be. Per Alan's advice, HT or power management might affect the precision of mdelay(). This patc

Re: CF flash PATA on libata failure to attach

2007-07-02 Thread Albert Lee
Alan Cox wrote: > On Fri, Jun 29, 2007 at 05:34:36PM +1000, Andrew Hall wrote: > >>Further to this the PATA to SATA bridge being used in this case is: >> >>http://www.jmicron.com/JM20330.html >> >>..as you will see only PIO and UDMA modes are supported. > > > In which case their microcontroller

Re: sata_sil24 not configuring drive right?

2007-07-02 Thread Tejun Heo
Theo Baumgartner wrote: > Hello > > I've got a sil3124 card which doesn't seem to use the full speed of my drives. > > --- > ata1: SATA max UDMA/100 cmd 0xe085 ctl 0x bmdma

Re: ata1: soft resetting port

2007-07-02 Thread Tejun Heo
Soeren Sonnenburg wrote: > Dear List, > > since the switch to > > CONFIG_ATA=y > CONFIG_ATA_ACPI=y > CONFIG_ATA_PIIX=y, > > the ATA_PIIX driver manages both, internal sata disk aswell as cd/dvd > rom. However I am being flooded with the error messages below (well they > appear from time to time

Re: sata_promise error handling

2007-07-02 Thread Tejun Heo
Mark wrote: >> Can I ignore them (EH handled them) or do i have to worry that the dd images > are corrupted >> (don't wanna make an md5sum of a 250gb disk and image)? Yeah, data should be okay. All failed commands are retried. > I get the same errors with my Promise SATA300 TX4 with 3 Samsung S

sata_sil, writing bug with multiple cards?

2007-07-02 Thread 7091
Greetings, I have been troubleshooting a problem for over a year now, and to make a long story short, I think the sata_sil driver has a bug during writing when there are multiple cards that are using different models of SiI chips in the system. I will be watching the list, although cc'ing me

Re: [PATCH 2.6.22-rc5 2/2] sata_promise: SATA hotplug support

2007-07-02 Thread Tejun Heo
Mikael Pettersson wrote: > This patch enables hotplugging of SATA devices in the > sata_promise driver. It's been tested successfully on > both first- and second-generation Promise SATA chips: > SATA150 TX2plus, SATAII150 TX2plus, SATA300 TX2plus, > and SATA300 TX4. > > The only quirk I've seen is

Re: SiI 3124 bus reset issues

2007-07-02 Thread Tejun Heo
Jeff Gustafson wrote: > Hi all, > I found issue similar to the one I am having in the archive on this > list. I never found a resolution to the problem in the archive. > I have a 4-port Sil 3124 64-bit PCI-X card in a Dell PowerEdge 750. It > is connected to four SATA hard drives in a