[PATCH 1/6] alim15x3: fix CD_ROM DMA and PIO FIFO settings setup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
lso when "idex=ata66" kernel parameter is used. * While at it move also chip_is_1543c_e setup from ata66_ali15x3() to init_chipset_ali15x3() and check if isa_dev exists before accessing it. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> -

[PATCH 2/6] alim15x3: use ->host_flags and ->udma_mask fields from ide_pci_device_t

2007-09-17 Thread Bartlomiej Zolnierkiewicz
* Make a local copy of ali15x3_chipset in alim15x3_init_one() and set ->host_flags / ->udma_mask according to the controller capabilities. * Cleanup init_hwif_common_ali15x3(). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pc

[PATCH 6/6] ide: add ide_device_add()

2007-09-17 Thread Bartlomiej Zolnierkiewicz
hwif_init() and make it static. * Unexport ide_proc_register_port(). There should be no functionality changes caused by this patch (sgiioc4.c: ide_proc_register_port() requires hwif->present to be set and it won't be set if probe_hwif_init() fails). Signed-off-by: Bartlomiej Zoln

Re: [PATCH 7/10] ide: add ->chipset field to ide_pci_device_t

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 15 September 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > Add ->chipset field to ide_pci_device_t and use it in ide_hwif_configure() > > to set hwif->chipset. Convert cmd64x, cy82c693, rz1000 and trm290 host > > drivers to use

Re: [PATCH] ide: call udma_filter() before resorting to the UltraDMA mask

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 15 September 2007, Sergei Shtylyov wrote: > Give the udma_filter() method call taking precedence over using the mode > masks. > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied with s/taking// > --- > Posting this change separately as have been asked. Should apply to th

[git patches] IDE fixes

2007-09-17 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-disk.c |1 + drivers/ide/ppc/pmac.c |2 -- 2 files changed, 1 insertions(+), 2 deletions(-) Jorge Juan Chico (1): ide: ST320413A has the same proble

Re: [PATCH] [POWERPC] Remove unused variabls from drivers/ide/ppc/pmac.c

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Monday 17 September 2007, Stephen Rothwell wrote: > Removes these warnings: > > /home/sfr/kernels/linus/drivers/ide/ppc/pmac.c: In function > 'pmac_ide_dma_check': > /home/sfr/kernels/linus/drivers/ide/ppc/pmac.c:1807: warning: unused variable > 'map' > /home/sfr/kernels/linus/drivers/ide/ppc

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-14 Thread Bartlomiej Zolnierkiewicz
On Friday 14 September 2007, Chuck Ebbert wrote: > On 09/07/2007 06:47 PM, Jeff Garzik wrote: > >>> This is useful when debugging, handling problem systems, or for > >>> distributions just to get the system installed so it can be sorted > >>> out later. > >>> > >>> This is a bit smarter than the ol

Re: [PATCH 5/10] hpt366: remove ->init_setup

2007-09-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 14 September 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>>* Split off hpt{374,371,366}_init() helper from > >>>init_setup_hpt{374,371,366}(). > > >>>* Merge init_setup_{374,372n,371,372a,302

Re: libata not working for sis5533

2007-09-12 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 12 September 2007, Patrizio Bassi wrote: > Jan Engelhardt ha scritto: > > On Sep 11 2007 15:46, Andrew Morton wrote: > > > >> Patrizio Bassi <[EMAIL PROTECTED]> wrote: > >> > >>> Jan Engelhardt ha scritto: > >>> > On Sep 8 2007 11:38, Patrizio Bassi wrote: > >

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-11 Thread Bartlomiej Zolnierkiewicz
he compiler. > > The bulk of the changes are #2 and #3, which are interrelated. #1 could > have been a separate patch, but it was so small compared to the others, > it was easier to roll it into this changeset. > > Signed-off-by: Jeff Garzik <[

[PATCH 9/10] ide: add IDE_HFLAG_RQSIZE_256 host flag

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_RQSIZE_256 host flag to tell ide_pci_setup_ports() to set hwif->rqsize to 256 sectors. Convert pdc202xx_old host driver to use it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/pdc202xx_old.c | 18 ++ drivers/ide/se

[PATCH 10/10] ide: add IDE_HFLAG_{IO_32BIT,UNMASK_IRQS} host flags

2007-09-11 Thread Bartlomiej Zolnierkiewicz
ver). * Add IDE_HFLAGS_VIA define (via82cxxx host driver). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/amd74xx.c | 25 ++--- drivers/ide/pci/sl82c105.c | 12 drivers/ide/pci/via82cxxx

[PATCH 7/10] ide: add ->chipset field to ide_pci_device_t

2007-09-11 Thread Bartlomiej Zolnierkiewicz
tances. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/cmd64x.c |4 +--- drivers/ide/pci/cy82c693.c |2 +- drivers/ide/pci/rz1000.c |2 +- drivers/ide/pci/trm290.c |2 +- drivers/ide/setup-pci.c|2 +- include/linux/ide.h

[PATCH 8/10] ide: add IDE_HFLAG_FORCE_LEGACY_IRQS host flag

2007-09-11 Thread Bartlomiej Zolnierkiewicz
ded init_hwif_generic() (generic IDE PCI host driver). * Set d->udma_mask instead of hwif->ultra_mask (via82cxxx host driver). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/generic.c | 27 ++- drivers/ide/pci/via

[PATCH 6/10] ide: remove unused ->next field from ide_pci_device_t

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- include/linux/ide.h |1 - 1 file changed, 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -1283,7 +

[PATCH 5/10] ide: add hwif_register_devices() helper

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add hwif_register_devices() helper to fix code duplication between probe_hwif_init_with_fixup() and ideprobe_init(). Also remove stale comment while at it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c

[PATCH 4/10] serverworks: remove dead code from svwks_set_dma_mode()

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/serverworks.c |7 --- 1 file changed, 7 deletions(-) Index: b/drivers/ide/pci/serverworks.c === --- a/drivers/ide/pci/serverworks.c

[PATCH 3/10] rz1000: set serialized flag only if mate interface exists

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Setting hwif->serialized makes sense only if the mate interface exists. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/rz1000.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci

[PATCH 2/10] ide: fix disabled ports reporting for PCI controllers

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Report all disabled ports in ide_pci_setup_ports() (prevents the bogus warning when ide_hwif_configure()->ide_match_hwif() fails to find free ide_hwifs[] slots). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/setup-pci.c | 10 -- 1 file c

Re: [-mm patch] remove ide_get_error_location()

2007-09-11 Thread Bartlomiej Zolnierkiewicz
is no longer used. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Since git-block contains the patch which removes the only user of ide_get_error_location() I think that this patch should be also merged throu

[PATCH 1/10] cmd64x: always set hwif->chipset for CMD646

2007-09-11 Thread Bartlomiej Zolnierkiewicz
hwif->chipset should be set to ide_cmd646 also when DMA base is invalid. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/cmd64x.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 08 September 2007, Sergei Shtylyov wrote: > Once I quothed: > > > Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at > > it, > > make the udma_filter() method calls take precedence over using the mode > > masks. > > This one not looking to pretty --

Re: [PATCH 5/10] hpt366: remove ->init_setup

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 September 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > * Split off hpt{374,371,366}_init() helper from > > init_setup_hpt{374,371,366}(). > > > * Merge init_setup_{374,372n,371,372a,302,366}() into hpt366_init_one(). >

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 September 2007, Sergei Shtylyov wrote: > Hello, I wrote: > Sergei Shtylyov wrote: > > >The patch was 4/4 of course. :-< > > Probably I was too esctatic about the code. ;-) > > Or rarher me. :-) > > >> The Marvell bridge chips used on HighPoint SATA cards do not seem to

[git patches] IDE fixes for 2.6.23-rc6

2007-09-11 Thread Bartlomiej Zolnierkiewicz
files changed, 141 insertions(+), 97 deletions(-) Bartlomiej Zolnierkiewicz (1): via82cxxx: add Arima W730-K8 and other rebadgings to short cables list Daniel Exner (1): pata_ali/alim15x3: override 80-wire cable detection for Toshiba S1800-814 Kumar Gala (1): mpc8xx: Only build

[PATCH 13/13] ide: set drive->autotune in ide_pci_setup_ports()

2007-09-05 Thread Bartlomiej Zolnierkiewicz
in such case) piix.c: * MPIIX controller (no ->init_hwif method so also no ->set_pio_mode method) However if there is no ->set_pio_mode method there are no changes in behavior w.r.t. PIO tuning so always set drive->autotune in ide_pci_setup_ports(). Signed-off-by: Bartlomie

[PATCH 8/13] alim15x3: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/alim15x3.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: b/drivers/ide/pci/alim15x3.c === --- a/drivers/ide/pci/alim

[PATCH 11/13] opti621: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/opti621.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/opti621.c === --- a/drivers/ide/pci/opt

[PATCH 12/13] triflex: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/triflex.c |3 +++ 1 file changed, 3 insertions(+) Index: b/drivers/ide/pci/triflex.c === --- a/drivers/ide/pci/triflex.c +++ b/drivers/i

[PATCH 9/13] cs5520: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Since cs5520 uses VDMA best PIO mode was tuned anyway by ide_dma_check() but only if DMA was successfully initialized. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/cs5520.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: b/drive

[PATCH 10/13] cy82c693: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/cy82c693.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: b/drivers/ide/pci/cy82c693.c === --- a/drivers/ide/pci/cy82

[PATCH 7/13] ide: add IDE_HFLAG_LEGACY_IRQS host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
't use ->init_hwif for MPIIX. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/atiixp.c |8 +++- drivers/ide/pci/piix.c| 24 ++-- drivers/ide/pci/serverworks.c | 15 +++ drivers/ide/pci/sis5513.c |

[PATCH 6/13] ide: add IDE_HFLAG_SERIALIZE host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_SERIALIZE host flag to tell ide_pci_setup_ports() to set hwif/mate->serialized and convert aec62xx, cs5530 and sc1200 host drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/aec62xx.c | 10 +- drivers/ide/pci

[PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif->err_stops_fifo. As a side-effect this change fixes hwif->err_stops_fifo not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-io.c

[PATCH 3/13] pdc202xx_old: add DECLARE_PDC2026X_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/pdc202xx_old.c | 60 - 1 file changed, 19 insertions(+), 41 deletions(-) Index: b/drivers/ide/pci/pdc202xx

[PATCH 4/13] piix: add DECLARE_ICH_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add DECLARE_ICH_DEV() macro. While at it: * Add init_hwif_ich() (->init_hwif method) for ICH controllers. * Rename init_chipset_piix() to init_chipset_ich() and use it only for ICH controllers. * Remove no longer needed piix_is_ichx() helper. Signed-off-by: Bartlomiej Zolnierkiew

[PATCH 1/13] aec62xx: no need to disable UDMA in ->init_hwif method for ATP850UF

2007-09-05 Thread Bartlomiej Zolnierkiewicz
* No need to disable UDMA in ->init_hwif method for ATP850UF (and since we now always tune PIO it will be disabled by ->set_pio_mode calls anyway). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/aec62xx.c | 14 +-

[PATCH 2/13] pdc202xx_new: add DECLARE_PDCNEW_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/pdc202xx_new.c | 76 ++--- 1 file changed, 19 insertions(+), 57 deletions(-) Index: b/drivers/ide/pci/pdc202xx

Re: [PATCH 2/10] ide: use I/O ops directly part #2

2007-09-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 September 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > > Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> > > Strange I thought I've already replaced

[PATCH] via82cxxx: add Arima W730-K8 and other rebadgings to short cables list

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Port of Alan's patch for pata_via.c. Cc: Alan Cox <[EMAIL PROTECTED]> Cc: Mikael Pettersson <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/via82cxxx.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletio

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-03 Thread Bartlomiej Zolnierkiewicz
On Sunday 02 September 2007, Sergei Shtylyov wrote: > Hello, I wrote: > > The patch was 4/4 of course. :-< > Probably I was too esctatic about the code. ;-) > > > The Marvell bridge chips used on HighPoint SATA cards do not seem to support > > the MWDMA modes (at least that caould be see

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-03 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 02 September 2007, Sergei Shtylyov wrote: > Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, Hm, this seems to be already dealt with by: http://kernel.org/pub/linux/kernel/people/bart/pata-2.6/patches/ide-mode-limiting-fixes-for-user-requested-speed-ch

Re: [PATCH 1/10] ide: use pci_dev->revision

2007-08-29 Thread Bartlomiej Zolnierkiewicz
On Wednesday 29 August 2007, Kok, Auke wrote: > Bartlomiej Zolnierkiewicz wrote: > > Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so > > they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65. > > > that's actually anoth

[PATCH 9/10] serverworks: remove ->init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{svwks,csb6}() into svwks_init_one(). While at it: * Remove redundant dev->device checks. * Operate on a local copy of serverworks_chipsets[] entry. * Use pci_resource_start(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/serv

[PATCH 10/10] ide: remove .init_setup from ide_pci_device_t

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Now that all users were fixed we can safely remove it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- include/linux/ide.h |1 - 1 file changed, 1 deletion(-) Index: b/include/linux/ide.h === --- a/i

[PATCH 8/10] scc_pata: remove ->init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/scc_pata.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/pci/scc_pata.c === --- a/drivers/ide/pci/scc_pata.c

[PATCH 5/10] hpt366: remove ->init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
PCI device ID and fix .enablebits/.host_flags for HPT36x hpt366_chipsets[] entry. * Bump driver version. Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/hpt366.c | 306 +++-

[PATCH 7/10] pdc202xx_old: remove ->init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
* Split off pdc202ata4_fixup_irq() helper from init_setup_pdc202ata4(). * Merge init_setup_{pdc202ata4,pdc20265,pdc202xx}() into pdc202xx_init_one(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/pdc202xx_old.c

[PATCH 3/10] aec62xx: remove ->init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{aec62xx,aec6x80}() into aec62xx_init_one(). While at it: * Use id->driver_data instead of dev->device. * Use ATA_UDMA6 define. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/aec62xx.c | 39 ++-

[PATCH 4/10] cmd64x: remove ->init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{cmd64x,cmd646}() into cmd64x_init_one(). Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/cmd64x.c | 39 --- 1 file changed, 12 insertions(+), 27 deletio

[PATCH 6/10] pdc202xx_new: remove ->init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
* Split off pdc20270_get_dev2() helper from init_setup_pdc20270(). * Merge init_setup_{pdcnew,pdc20270,pdc20276}() into pdc202new_init_one(). While at it: * Change KERN_ level of interrupt fixup message from KERN_WARNING to KERN_INFO. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTEC

[PATCH 1/10] ide: use pci_dev->revision

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65. Cc: Auke Kok <[EMAIL PROTECTED]> Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTEC

[PATCH 2/10] ide: use I/O ops directly part #2

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/hpt366.c | 43 --- drivers/ide/pci/piix.c |4 ++-- drivers/ide/pci/tc86c001.c | 12 ++-- 3 files

[PATCH 10/8] ide: add ->mwdma_mask and ->swdma_mask to ide_pci_device_t

2007-08-27 Thread Bartlomiej Zolnierkiewicz
ice_t DMA masks. While at it: * Use ATA_{UDMA,MWDMA,SWDMA}* defines. * hpt34x.c: add separate ide_pci_device_t instances for HPT343 and HPT345. * serverworks.c: fix DMA masks being set before checking DMA base. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- Yes, yo

[PATCH 9/8] pdc202xx_old: remove broken SWDMA support

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Documentation doesn't mention SWDMA and moreover all timings used for SWDMA modes were over-clocked when compared to ATA spec. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/pdc202xx_old.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-

[PATCH 8/8] ata: add ATA_MWDMA* and ATA_SWDMA* defines

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- include/linux/ata.h | 13 + 1 file changed, 13 insertions(+) Index: b/include/linux/ata.h === --- a/i

[PATCH 5/8] ide: add IDE_HFLAG_NO_{DMA,AUTODMA} host flags

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_{DMA,AUTODMA} host flags. Convert all host drivers using ide_pci_device_t to use these flags instead of d->autodma and then remove no longer needed d->autodma. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/aec62xx.c

[PATCH 3/8] ide: add IDE_HFLAG_NO_ATAPI_DMA host flag

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_ATAPI_DMA host flag and set it in host drivers which don't support ATAPI DMA. Then remove no longer needed hwif->atapi_dma. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/arm/icside.c |1 - drivers/ide/cris/ide-cr

[PATCH 6/8] ide: remove ->init_setup_dma from ide_pci_device_t

2007-08-27 Thread Bartlomiej Zolnierkiewicz
) to find out which PCI BAR to use, remove no longer needed cs5520.c::cs5520_init_setup_dma() and ide_pci_device_t.init_setup_dma. This fixes PCI bus-mastering and DMA simplex mode not being checked for CS5510/CS5520 hosts. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> -

[PATCH 7/8] ide: add IDE_HFLAG_NO_LBA48 and IDE_HFLAG_NO_LBA48_DMA host flags

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_LBA48[_DMA] host flags, use it instead of hwif->no_lba48[_dma] and then remove no longer needed hwif->no_lba48[_dma]. As a side-effect this change fixes hwif->no_lba48_dma not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMA

[PATCH 2/8] amd74xx: remove /proc/ide/amd74xx

2007-08-27 Thread Bartlomiej Zolnierkiewicz
This belongs to user-space (and only if really needed). textdata bss dec hex filename 67232000 288751222f drivers/ide/pci/amd74xx.o.before 38332000 16584916d9 drivers/ide/pci/amd74xx.o.after Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 4/8] ide: add IDE_HFLAG_BOOTABLE host flag

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_BOOTABLE host flag and IDE_HFLAG_OFF_BOARD define. Convert all host drivers using ide_pci_device_t to use IDE_HFLAG_{BOOTABLE,OFF_BOARD} instead of d->bootable and then remove no longer needed d->bootable. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>

Re: [PATCH 1/2] pdc202xx_new: fix PCI refcounting

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Sunday 26 August 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>The driver erroneously "lets go" the mate IDE chip in init_setup_pdc20270() > >>when ide_setup_pci_devices() call succeeds -- fix this, and drop a couple of > >>us

[PATCH 1/8] amd74xx/via82cxxx: don't initialize drive->dn

2007-08-27 Thread Bartlomiej Zolnierkiewicz
drive->dn is initialized by ide-probe.c::probe_hwif() so no need to do it in ->init_hwif method. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/amd74xx.c |1 - drivers/ide/pci/via82cxxx.c |1 - 2 files changed, 2 deletions(-) Index: b/dri

Re: [PATCH 1/4] ide: add ide_dev_is_sata() helper (take 2)

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 25 August 2007, Sergei Shtylyov wrote: > Make the SATA drive detection code from eighty_ninty_three() into inline > ide_dev_is_sata() helper fixing it along the way to be more strict while > checking word 80 for the reserved values... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTE

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 25 August 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>The Marvell bridge chips used on HighPoint SATA cards do not seem to support > >>the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver > &

Re: [PATCH] mpc8xx: Only build mpc8xx on arch/ppc

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Thursday 23 August 2007, Kumar Gala wrote: > Currently the mpc8xx ide driver will only work on arch/ppc so only > allow it to be built there. Also, killed a minor include that isn't > actually used by the driver. > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> applied - To unsubscribe from

Re: [PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 3)

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Hello, On Saturday 25 August 2007, Sergei Shtylyov wrote: > The Marvell bridge chips used on HighPoint SATA cards do not seem to support > the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs > to account for this in the udma_filter() method. In order to achieve that, d

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-24 Thread Bartlomiej Zolnierkiewicz
On Friday 24 August 2007, Sergei Shtylyov wrote: > Hello. > > Albert Lee wrote: > > >>>b) puts more work [the enter test mode stuff] in between the start > >>> and and sampling points, reducing the precision of the PLL > >>> detection; I actually observed quite noticeable differences > >>>

Re: [PATCH 1/4] ide: add ide_dev_is_sata() helper

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 19 August 2007, Sergei Shtylyov wrote: > Make the SATA drive detection code from eighty_ninty_three() into inline > ide_dev_is_sata() helper fixing it along the way to be more strict while > checking word 80 for the reserved values... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]

Re: [PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 2)

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 19 August 2007, Sergei Shtylyov wrote: > The Marvell bridge chips used on HighPoint SATA cards do not seem to support > the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs > to account for this in the udma_filter() method. In order to achieve that, do > the fol

Re: [PATCH 2/2] pdc202xx_new: switch to using pci_get_slot() (take 2)

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 19 August 2007, Sergei Shtylyov wrote: > Switch to using pci_get_slot() in init_setup_pdc20270() to get to the mate > chip > behind DC21150 bridge as there's no need for the driver itself to walk the > list > of the PCI devices (and the driver didn't check the bus # of the found > devi

Re: [PATCH] hpt366: fix PCI clock detection for HPT374 (take 4)

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > HPT374 BIOS seems to only save f_CNT register value for the function #0 before > re-tuning DPLL (that causes the driver to report obviously distorted f_CNT for > the function #1) -- fix this by always reading the saved f_CNT register value > from

Re: [PATCH] ide: fix PCI refcounting

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Saturday 18 August 2007, Sergei Shtylyov wrote: > The IDE core never marked the PCI IDE devices as being in use after succesfull > driver probe call (the devices were marked in use only while being probed), > and > so was susceptible to issues caused by unsolicited PCI hotplug device removal. >

Re: [PATCH 1/2] pdc202xx_new: fix PCI refcounting

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Saturday 18 August 2007, Sergei Shtylyov wrote: > The driver erroneously "lets go" the mate IDE chip in init_setup_pdc20270() > when ide_setup_pci_devices() call succeeds -- fix this, and drop a couple of > useless assignments in this function while at it... > > Signed-off-by: Sergei Shtylyov <

[git patches] IDE fixes

2007-08-20 Thread Bartlomiej Zolnierkiewicz
|4 +- 15 files changed, 113 insertions(+), 74 deletions(-) Bartlomiej Zolnierkiewicz (12): ide: fix hidden dependencies on CONFIG_IDE_GENERIC ide-cris: fix ->set_pio_mode method to set transfer mode on the device ide: config_drive_for_dma() fixes ide-p

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > Hello, I wrote: > > >> 101 files changed, 1880 insertions(+), 2828 deletions(-) > > >> please look at -mm or IDE quilt tree instead. :) > > >Looking... > > When are you planning to push out to Linus the > ide-mode-limiting-fixes-fo

[PATCH 6/7] ide: remove CONFIG_IDEDMA_ONLYDISK

2007-08-18 Thread Bartlomiej Zolnierkiewicz
ATAPI devices with broken DMA support should be handled by DMA blacklist and for debugging purposes we have new shiny "hdx=nodma" kernel paremeter. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/Kconfig | 10 -- drivers/ide/ide-probe.c

Re: [PATCH 1/8] alim15x3: PIO fallback fix

2007-08-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 18 August 2007, you wrote: > Bartlomiej Zolnierkiewicz wrote: > > > [PATCH] alim15x3: PIO fallback fix > > > If DMA tuning fails always set the best PIO mode. > > > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > > A

[PATCH 5/7] ide: add "hdx=nodma" kernel parameter

2007-08-18 Thread Bartlomiej Zolnierkiewicz
* Add "hdx=nodma" option allowing user to disallow DMA for a given device. * Obsolete "ide=nodma" option. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- Documentation/ide.txt |4 ++-- drivers/ide/ide-dma.c |2 +- drivers/ide/ide.c |

[PATCH 3/7] ide: remove "idex=dma" kernel parameter

2007-08-18 Thread Bartlomiej Zolnierkiewicz
It has been obsoleted since 1 Nov 2004, is valid only when used together with "ide=nodma" kernel parameter (which makes no sense) and only for aec62xx, cmd64x, cs5220, generic, hpt366, sl82c105, tc86c001 and triflex host drivers. Signed-off-by: Bartlomiej Zolnierkiewicz <[EM

[PATCH 4/7] ide: remove hwif->autodma and drive->autodma

2007-08-18 Thread Bartlomiej Zolnierkiewicz
over-ridden by host drivers anyway) Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/arm/icside.c |8 drivers/ide/cris/ide-cris.c|3 --- drivers/ide/ide-dma.c |2 +- drivers/ide/ide-probe.c|9 - drivers/ide/id

[PATCH 7/7] ide: add DECLARE_GENERIC_PCI_DEV() macro to generic IDE PCI host driver

2007-08-18 Thread Bartlomiej Zolnierkiewicz
* Add DECLARE_GENERIC_PCI_DEV() macro to generic IDE PCI host driver and use it to cleanup generic_chipsets[]. * Remove dead/obsolete code while at it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/generic.c

[PATCH 2/7] ide: remove CONFIG_BLK_DEV_IDEDMA_FORCED

2007-08-18 Thread Bartlomiej Zolnierkiewicz
This code doesn't use pci_assign_resource() and ide_get_or_set_dma_base() uses pci_resource_start() to get DMA base address so it has no chance of working. Moreover this belongs to PCI quirks (in case somebody would like to fix it). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL P

[PATCH 1/7] ide: use PCI_VDEVICE() macro

2007-08-18 Thread Bartlomiej Zolnierkiewicz
While at it: - make struct pci_device_id tables const - use PCI_DEVICE_ID_ITE_8213 define in it8213.c - fix comment in generic.c Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/aec62xx.c | 12 - drivers/ide/pci/alim15x3.c |6 ++-- d

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > Hello. > > Alan Cox wrote: > > > Set the MWDMA timing by updating the correct registers. Split the PIO > > path as this is mostly shared code. Wants testing. > > Cool! So much simpler than my fix to the old IDE driver... > > > Signed-off-

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>>>>>>>>>+ if (chip_type == HPT374 && (PCI_FUNC(dev->devfn) & 1)) { > >>>>&g

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>Index: linux-2.6/drivers/ide/pci/hpt366.c > >>=== > >>--- linux-2.6.orig/drivers/ide/pci/hpt366.c > >

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, you wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>>> Good, that's what I lacked for hpt366.c! Were you planning to push it > >>>> to > >>>>Linus soon? > > >>>Not really but if needed I will

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>>>>>>>+ if (chip_type == HPT374 && (PCI_FUNC(dev->devfn) & 1)) { > >>>>>>

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>>>>>+ if (chip_type == HPT374 && (PCI_FUNC(dev->devfn) & 1)) { > >>>>>>+

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>>>Index: linux-2.6/drivers/ide/pci/hpt366.c > >>>>=== > >>>>--- li

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-10 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>Good, that's what I lacked for hpt366.c! Were you planning to push it > >> to > >>Linus soon? > > > Not really but if needed I will extract MWDMA fi

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-10 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Sergei Shtylyov wrote: > Alan Cox wrote: > > + if (chip_type == HPT374 && (PCI_FUNC(dev->devfn) & 1)) { > + struct pci_dev *dev1 = pci_get_slot(dev->bus, > + dev->devfn - 1); > > >>

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-10 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 10 August 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>The Marvell bridge chips used on HighPoint SATA cards do not seem to support > >>the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver > >>

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-09 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Alan Cox wrote: > > * This driver is heavily based upon: > > * > > * linux/drivers/ide/pci/hpt366.c Version 0.36April 25, > > 2003 > > * > > reference to hpt366 version should also be updated (or removed) > > > Disagree - its not based on the newer

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-09 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Alan Cox wrote: > On Thu, 9 Aug 2007 23:19:34 +0200 > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > > > Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) > > and for AEC6880[R] it is UDMA6 (not UDMA5): >

[PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-09 Thread Bartlomiej Zolnierkiewicz
ver present in IDE aec62xx driver. Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ata/pata_artop.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) Index: b/drivers/a

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-09 Thread Bartlomiej Zolnierkiewicz
While at it: On Sunday 05 August 2007, Sergei Shtylyov wrote: > Index: linux-2.6/drivers/ata/pata_hpt37x.c > === > --- linux-2.6.orig/drivers/ata/pata_hpt37x.c > +++ linux-2.6/drivers/ata/pata_hpt37x.c > @@ -8,12 +8,10 @@ this driv

<    4   5   6   7   8   9   10   11   12   13   >