Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: Some it821x RAID firmwares return 0 for the err return off both devices. A similar issue occurs with the slave returning 0 not 1 if you plug a gigabyte sata ramdisk into a controller that fakes two SATA ports as master/slave on an SFF channel. The patch does the following -

Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Alan Cox
The other IT821x change is a bit ugly, we slightly abuse the cable type hook to fiddle with the identify data for the devices. We could add a new hook for this but as we have only one offender and no more seeming likely it seems better to keep libata-core clean. Please let this sit in

Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: The other IT821x change is a bit ugly, we slightly abuse the cable type hook to fiddle with the identify data for the devices. We could add a new hook for this but as we have only one offender and no more seeming likely it seems better to keep libata-core clean. Please let this

Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Alan Cox
It sounds like such a hook would be more appropriate here... can you think of any other situation or driver that could make use of a pre-dev-config hook? No - which is why I didn't add one. Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations

2007-10-30 Thread Jeff Garzik
Alan Cox wrote: Some it821x RAID firmwares return 0 for the err return off both devices. A similar issue occurs with the slave returning 0 not 1 if you plug a gigabyte sata ramdisk into a controller that fakes two SATA ports as master/slave on an SFF channel. The patch does the following -