Benjamin Herrenschmidt wrote:
On Fri, 2007-05-25 at 00:26 -0400, Jeff Garzik wrote:
Just replace the ata_std_softreset() call with code that does MMIO
flushes on a safe register?
Yeah well... if just reading altstatus is enough, I don't see the point
of doing anything MMIO-dependant
Henry Su wrote:
Hi Jeff,
Thanks for your kindly help, I will fix the email next time.
Do you mean all the device IDs for ATI SB700 are added to the corresponding
files?
because I split this patch and resent four patches according to your last
suggestion,
if this patch is applied, another
Vasily Averin wrote:
Jeff, Tejun,
Our RHEL5-based OpenVZ linux kernel reports about SATA-related issues:
VIA VT6420 SATA RAID Controller on MSI motherboard, x86_64 kernel based on
latest RHEL5 kernel,
On booting hardware initialized properly and all works fine some time, but then
it detects
Uwe Koziolek wrote:
--- a/drivers/ata/sata_sis.c2007-05-22 11:05:38.0 +0200
+++ b/drivers/ata/sata_sis.c2007-05-23 00:24:28.0 +0200
@@ -255,7 +255,7 @@
{
static int printed_version;
struct ata_port_info pi = sis_port_info;
- const struct
() - the only
place where SETXFER can be issued.
Jeff Garzik suggests that, in the long term, it might be better to
modify libata HSM implementation such that we're more tolerant of
erratic ATAPI IRQ behavior - e.g. default to IRQ but falling back to
polling if the device doesn't seem ready
Henry Su wrote:
I check the latest kernel source code with git, and find out that the SMBus patch has not been applied yet,
Correct. When you don't see a patch in the upstream git tree
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
then the next step is consult the
Tejun Heo wrote:
So, I don't think the problem exists for SATA in the first place. At
least there hasn't been any report of it and doing SETXFER by polling
can handle all the existing cases. We can and probably should deal with
such SATA devices when and if they come up. How are we gonna
in the current -rc. This
will help me narrow down the source of the dmesg spam.
To answer one of dean's questions about NCQ, check out
http://linux-ata.org/faq.html#ncq
Thanks,
Jeff
Jeff Garzik (9):
[libata] sata_mv: first cut at new EH
[libata] sata_mv: move PCI
/sata_promise.c |2 +-
drivers/ata/sata_sis.c |2 +-
drivers/ata/sata_via.c |3 ++
10 files changed, 98 insertions(+), 45 deletions(-)
Alan Cox (2):
pata: Trivia
pata_hpt37x: Further improvements based on the IDE updates and vendor
drivers
Jeff Garzik (4
Lennert Buytenhek wrote:
(please CC on replies, I'm not subscribed to linux-ide@)
Hi,
sata_mv (driving two 8-port Supermicro AOC-SAT2-MV8 PCI-X adapters) in
2.6.18-1.2747.el5 (RHEL/CentOS 5 beta kernel) didn't respond too well
to one of the attached disks experiencing what seems to be a head
Already uncovered and fixed a few bugs in v3.
Here's v4 of the sata_mv new-EH patch.
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 705a020..4a75b48 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -192,8 +192,10 @@ enum {
EDMA_ERR_DEV_DCON = (1
dean gaudet wrote:
On Fri, 25 May 2007, Jeff Garzik wrote:
Already uncovered and fixed a few bugs in v3.
Here's v4 of the sata_mv new-EH patch.
you asked for test results with 2.6.21.3 ... that seems to boot fine,
and i've tested reading from the disks only and it seems to be working
fine
Dave Dillow wrote:
On Sat, 2007-05-26 at 16:56 -0400, Jeff Garzik wrote:
Dave, any chance you could try 2.6.22-rc3 + my v4 patch, on a different
hard drive? Preferably a non-Maxtor, or at least not another Maxtor
6L200S0. If that's a big deal, don't worry about it. I just want to
rule out
This patch is an attempt to convert pdc_adma over to new EH. It
compiles, but I have not tested it. If anyone is willing to give it an
it talks to the disks test that would be great.
This hardware is -mostly- compatible with the docs on
http://www.T13.org/ (look for d1510r1) according to Mark,
Here is a patch against 2.6.22-rc3 that adds support for both the PATA
and SATA portions of the Marvell AHCI-like chip.
The architecture for PATA is quite nice, mimicing AHCI very closely.
Basic port scanning, interrupt handling, freezing and thawing is the
same, and uses the same register
Gregor Jasny wrote:
Hi,
2007/5/26, Linus Torvalds [EMAIL PROTECTED]:
What more could you possibly want? Some ATA updates? USB suspend problem
22-rc3 broke the CDROM in my Dell notebook. After I've switched to
libata som time ago, I've got some delays/timeouts during boot [1].
But the drive
Alan Cox wrote:
Correct, but it is also extremely slow. No point discussing fast paths
for odd if() tests through the code when you burn 100nS unneccessarily
every time you issue a command via PIO is there.
BTW if you wanna start PIO speed tuning, ISTR the device-select code
does not cache
Yet another of the completely-untested conversions to new libata
EH, this time for sata_sx4. The handling of the ATA ports
freeze/thaw/error_handler is the same as sata_promise, save for a
few constants. The big question is HDMA EH, which is explained in
both the Theory of operation section
Tejun Heo wrote:
Fix various bugs in pio/mwdma mode programming.
* Control bits in the timing register wasn't cleared properly while
programming PIO mode.
* MWDMA mode programming cleared the wrong part of control bits.
* MWDMA mode programming cleared udma_mask even when the controller
Alan Cox wrote:
If you are using a SiS controller and the BIOS didn't set it up then the
FIFO may be left active when we try and set up the CD. Not convinced this
matters but I'd prefer to be safe
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from
I know it's probably a low priority, but could you rediff this against
the current libata?
I'm wondering where we are in terms of hooks that you need. Since you
posted this we added some hooks for the pata_scc driver, most notably
-irq_on() hooks. And other code you modify, such as the
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/libata-core.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Jeff Garzik (1):
[libata] Add drive
Mark Lord wrote:
Some cards may perform better when their memory interface is used
instead of the I/O interface, or vice-versa. I'm not sure which
of the two methods was selected by libata (probably the memory
interface).
I am very CF-ignorant. How does libata select a memory or I/O
Mark Lord wrote:
To maximize throughput, some kind of host-queuing would be needed,
or just have the driver sit in a tight loop, starting the next I/O
immediately when the previous one finishes. Linux isn't that quick (yet).
I was talking on IRC with Tejun just recently. There are several
Tejun Heo wrote:
Most BIOSen, Windows and old IDE driver don't reset at all during
probing. They first issue IDENTIFY unconditionally, if that fails,
IDENTIFY_PACKET. From the beginning, libata has issued reset during
Not true for BIOS. A large sub-section of BIOS (Phoenix and/or
Linus Torvalds wrote:
On Fri, 1 Jun 2007, Jeff Garzik wrote:
I'm about to dive into some heads-down RHEL backporting (whee), so I cannot
look at the code in depth this weekend, but here are my basic thoughts:
* We knew there would be fallout from the new reset-sequence code
Jeff Garzik wrote:
Upon quick review, it appears it should be 110ms. And actually the spec
says 3ms. But to answer your question anyway... :)
Actually the 3ms is the DRQ assertion delay.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Tomasz Chmielewski wrote:
Jeff Garzik schrieb:
Below is a refresh of my on-going effort to convert sata_mv to the new
exception handling framework. sata_mv is one of the last hold-outs, and
its old-EH implementation blocks new features like hotplug and NCQ.
It works for me on the one 50xx
Mikael Pettersson wrote:
Jeff Garzik writes:
+if ((pi-flags (PDC_FLAG_GEN_II|PDC_FLAG_4_PORTS)) ==
(PDC_FLAG_GEN_II|PDC_FLAG_4_PORTS)) {
+is_sataii_tx4 = 1;
+dev_printk(KERN_INFO, pdev-dev, applying SATAII TX4 port
numbering workaround\n
Tuncer Ayaz wrote:
I'm still seeing the libata warning that disks were not spun down
properly on the following two setups and am wondering whether I need
a new shutdown binary or the changeset mentioned below is not meant
to fix what I'm triggering by halt'ing.
If it's not a bug I will try to
Gregor Jasny wrote:
Hi,
2007/5/26, Linus Torvalds [EMAIL PROTECTED]:
What more could you possibly want? Some ATA updates? USB suspend problem
22-rc3 broke the CDROM in my Dell notebook. After I've switched to
libata som time ago, I've got some delays/timeouts during boot [1].
But the drive
FYI: I noticed this weekend that libata does not reserve the legacy
IDE control block I/O port region, like it does the command block
I/O region.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo
Nevermind, I did it myself:
This ensures that we can easily make changes specific to the PATA port
on the newer SATA chips, and also does what I've been requesting -- use
the standard ata_bmdma_error_handler(), rather than creating custom code
that achieves the same effect.
diff --git
On Wed, Jun 06, 2007 at 01:04:17AM +0200, Uwe Koziolek wrote:
the PATA-port of SiS180 controller does not support a drive present status
in the pci configspace like the other SiS PATA controllers, check skipped.
Signed-off-by: Uwe Koziolek [EMAIL PROTECTED]
--- a/drivers/ata/pata_sis.c
On Thu, Jun 07, 2007 at 01:56:11PM -0700, Linus Torvalds wrote:
On Thu, 7 Jun 2007, Tejun Heo wrote:
Ah.. okay. Now I see what's going on. Jeff, this is another device
which doesn't set nsect and lbal to 1 after reset. Gregor, please try
the attached patch.
Tejun, since Jeff is
On Fri, Jun 08, 2007 at 08:41:19PM +0900, Tejun Heo wrote:
libata used to claim only cmd ports for legacy SFF ports. Claim ctl
ports too.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
This has been this way as long as I can remember. It's almost
pleasant to see that it survived through
On Fri, Jun 08, 2007 at 11:12:01PM +0900, Tejun Heo wrote:
Jeff Garzik wrote:
On Fri, Jun 08, 2007 at 08:41:19PM +0900, Tejun Heo wrote:
libata used to claim only cmd ports for legacy SFF ports. Claim ctl
ports too.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
This has been
On Fri, Jun 08, 2007 at 12:40:58PM +0100, Alan Cox wrote:
Seems best to me - we know the current code breaks a load of systems and
the change should not break anything but fix them all. If we ship without
it being changed then a load of people are stuck with broken ATA.
So you have verified
On Fri, Jun 08, 2007 at 02:18:55PM +0200, Bartlomiej Zolnierkiewicz wrote:
On Monday 04 June 2007, Jiri Slaby wrote:
ide-generic, add another device exception
ide-generic is a generic ISA IDE driver, this one is drivers/ide/pci/generic
(a generic IDE PCI driver) - fixed patch description to
On Fri, Jun 08, 2007 at 05:02:24PM +0900, Tejun Heo wrote:
I don't think the first one is probable considering BSY is supposed to
set when SRST is received. This is pretty fundamental in the protocol
and necessary for the device to work properly as master, so I think this
is one of few things
I just confirmed that two PATA-era major BIOS brands do SRST. They do
check for the device signature in TF registers... but only for the ATA
device signature.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More
On Fri, Jun 08, 2007 at 04:46:30PM +0100, Alan Cox wrote:
Ah, I guess I misunderstood. I thought you were referring to Fedora
7 bug reports, since there are not a load of people with IT821x.
There are. Several vendors shipped it on the motherboard and there are
either quite a few users,
On Fri, Jun 08, 2007 at 04:38:04PM +0100, Alan Cox wrote:
See a URL I posted earlier in this thread. With dumb ATAPI devices we
actually have to wait a bit for BSY to be asserted. Not only at reset,
but also for every command
400nS and the current code correctly accounts for it.
No,
On Fri, Jun 08, 2007 at 04:36:15PM +0100, Alan Cox wrote:
On Fri, 8 Jun 2007 10:28:22 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
On Fri, Jun 08, 2007 at 12:40:58PM +0100, Alan Cox wrote:
Seems best to me - we know the current code breaks a load of systems and
the change should
On Fri, Jun 08, 2007 at 04:33:37PM +0100, Alan Cox wrote:
Allowing legacy to be used on non-PCI systems was your idea! Alright,
then we can drop a lot of junk from legacy SFF code. Will prep another
patch. Please ignore two patches in this thread.
Alan seems to be ignoring that
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Friday 08 June 2007, Jeff Garzik wrote:
On Fri, Jun 08, 2007 at 02:18:55PM +0200, Bartlomiej Zolnierkiewicz wrote:
On Monday 04 June 2007, Jiri Slaby wrote:
ide-generic, add another device exception
ide-generic is a generic ISA IDE driver, this one
Linus Torvalds wrote:
So what's the resolution? Right now this is apparently the reasong for
Based on the thread it sounded like Tejun was going to post a slightly
modified version of his patch?
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Yoichi Yuasa wrote:
Hi,
This patch has removed unused variable in pata_ispnp.
Yoichi
Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED]
applied
For the future, please put anything that should not be copied into the
permanent kernel changelog following a --- separator, as described in
Olof Johansson wrote:
Most drivers don't seem to fill out the host-irq field, resulting in the
wrong (no) irq being reported at probe time. For example, sil24 on my system:
ata1: SATA max UDMA/100 cmd 0xd8009001f000 ctl 0x bmdma
0x irq 0
ata2: SATA max
Albert Lee wrote:
For ATA/CFA devices, libata prints out the device model and firmware revision.
Do the same for ATAPI devices.
Signed-off-by: Albert Lee [EMAIL PROTECTED]
---
Sometimes the error happens after identify but before the
SCSI messages. Knowing the device model and firmware
Tejun Heo wrote:
hw_sata_spd_limit used to be incorrectly initialized to zero instead
of UINT_MAX if SPD is zero in SControl register. This breaks PHY
speed down. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |3 ++-
1 file changed, 2 insertions(+), 1
Alan Cox wrote:
The ata IRQ ack functions are only used when debugging. Unfortunately
almost every controller that calls them can cause crashes in some
configurations as there are missing checks for bmdma presence.
In addition ata_port_start insists of installing DMA buffers and pad
buffers for
Alan Cox wrote:
The controller is not reporting an unlawful type, it is reporting an
invalid type. Illegal specifically means prohibited by law [1]
Signed-off-by: Alan Cox [EMAIL PROTECTED]
[1] Microsoft BSOD excepted - and that has another mistake too - it says
your software meaning our
Albert Lee wrote:
Patch 1/6:
Update the ATA passthru protocol numbers according to the new spec.
Signed-off-by: Albert Lee [EMAIL PROTECTED]
---
diff -Nrup 00_libata-dev/drivers/ata/libata-scsi.c
01_protocol_update/drivers/ata/libata-scsi.c
--- 00_libata-dev/drivers/ata/libata-scsi.c
Albert Lee wrote:
Patch 1/6:
Update the ATA passthru protocol numbers according to the new spec.
Signed-off-by: Albert Lee [EMAIL PROTECTED]
applied 1-4, 6 to #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
As mentioned, will push Tejun's updated probe patch when received.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c| 24
Tejun Heo wrote:
After SRST, libata used to wait for nsect/lbal to be set to 1/1 for
the slave device. However, some ATAPI devices don't set nsect/lbal
after SRST and the wait itself isn't too useful as we're gonna wait
for !BSY right after that anyway.
Before reset-seq update, nsect/lbal wait
Bartlomiej Zolnierkiewicz wrote:
Code intended to check DMA status was checking DMA command register.
Moreover firmware seems to forget to set DMA capable bit for the
slave device (at least in RAID mode but without ITE RAID volumes) so
check device ID for DMA capable bit when deciding whether
The following is CUMULATIVE to the previous push, but in the same linear
history. IOW, pulling 'linus-plus-plus' also gets you 'upstream-linus'.
But if you have already pulled 'upstream-linus', you will only receive
these two changesets.
Please pull from branch 'linus-plus-plus' of
Tejun Heo wrote:
After SRST, libata used to wait for nsect/lbal to be set to 1/1 for
the slave device. However, some ATAPI devices don't set nsect/lbal
after SRST and the wait itself isn't too useful as we're gonna wait
for !BSY right after that anyway.
Before reset-seq update, nsect/lbal wait
Tejun Heo wrote:
IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if
asked to configure itself to MWDMA0. Force PIO.
This fixes bugzilla bug#8497.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Calvin Walton [EMAIL PROTECTED]
---
There was another proposed patch which lowers
Kristen Carlson Accardi wrote:
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Seems OK, though a bit disappointing that this cannot
Kristen Carlson Accardi wrote:
This patch will set the correct bits to turn on Aggressive
Link Power Management (ALPM) for the ahci driver. This
will cause the controller and disk to negotiate a lower
power state for the link when there is no activity (see
the AHCI 1.x spec for details). This
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5
Arjan van de Ven wrote:
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for
AHCI devices, as documented in the AHCI spec. On my laptop (a Lenovo
X60), this
saves me a full watt of power. On other systems, reported power
Arjan van de Ven wrote:
Jeff Garzik wrote:
SATA standard defines lower power phy states. So the same argument
you're using for AHCI applies there too -- just enabling an existing
hardware feature.
yes I'm not arguing against that. I was trying to find out (and
suggest-unless-proven
We will do AHCI link PM -- presuming that I can be convinced that it
does not repeatedly park the hard drive heads, or something similarly
annoying on PATA-SATA bridges and similar setups.
IF it works as advertised -- a big if considering all the AHCI silicon
implementations out there -- we
Alan Cox wrote:
+ if (multi_count != dev-multi_count)
+ ata_dev_printk(dev, KERN_WARNING,
+ invalid multi_count %u ignored\n,
+ multi_count);
+ }
What limits log spamming here ?
Matthew Garrett wrote:
On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote:
On Tue, 12 Jun 2007, Matthew Garrett wrote:
Laptop bays are designed to deal with hotplugging PATA - I don't think
this is too much of an issue :)
The new SATA ones use the SATA hardware
Matthew Garrett wrote:
Excluding the corner case of an Expresscard SATA controller (where I
suspect you'd want different policy), I doubt there are any cases where
you have a laptop with hotplug capabilities without it being implemented
as an ACPI bay.
Cardbus card.
Jeff
-
To
Sergei Shtylyov wrote:
This is generally a bad practice to guess protocol based on opcode.
What if the code will have to handle a vendor unique command (or some
other command not yet known to it but known to issuer)?
Agreed -- we simply cannot rely on guessing protocol from opcode, we
James Bottomley wrote:
To take the model I understand: SAS; the links are managed at the phy
level, so the power policy should be set there and thus should probably
be a property of the phy object, which doesn't even exist in the SCSI
model, it only exists in the transport class. It strikes me
Nigel Kukard wrote:
I'm stumped trying to track down the below intermittent problem.
I've confirmed this problem on 2.6.19, 2.6.20 and 2.6.21.
Jun 14 07:55:52 nigel-m2v kernel: ata2.00: exception Emask 0x0 SAct 0x0
SErr 0x0 action 0x2 frozen
Jun 14 07:55:52 nigel-m2v kernel: ata2.00: cmd
Kristen Carlson Accardi wrote:
Ok - sorry for my ignorance about SCSI - but my sources (i.e. Arjan) tell
me that the problem is that Link in ATA land means something different than
Link in SCSI land, and that what I really need to do is leave this code under
the Host class, but rename it to
Mark Lord wrote:
Jeff Garzik wrote:
Albert Lee wrote:
Patch 1/6:
Update the ATA passthru protocol numbers according to the new spec.
Signed-off-by: Albert Lee [EMAIL PROTECTED]
applied 1-4, 6 to #upstream-fixes
What about this one: [PATCH 5/6] libata: support ATAPI devices ??
I'm
Andrew Morton wrote:
So I revisited [...]
http://bugzilla.kernel.org/show_bug.cgi?id=8636
I don't see why it's not-a-bug. The second guy (Stephen Clark) had to toss
out the FC6 kernel and build his own kernel to fix this regression.
(I hope you don't mind me copying linux-ide)
The combined
Gaston, Jason D wrote:
I don't think we want to have the same DeviceID supported in more then one
driver. Would they not conflict with each other?
In Fedora 7, CONFIG_IDE is disabled. ata_piix drives all hardware at
that point.
Jeff
-
To unsubscribe from this list: send the
Bartlomiej Zolnierkiewicz wrote:
Code intended to check DMA status was checking DMA command register.
Moreover firmware seems to forget to set DMA capable bit for the
slave device (at least in RAID mode but without ITE RAID volumes) so
check device ID for DMA capable bit when deciding whether
Tejun Heo wrote:
More for the NCQ blacklist. One hitachi and one raptor. Other
members of these families of drives are already on the list, so no
surprises.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |2 ++
1 file changed, 2 insertions(+)
diff --git
Tejun Heo wrote:
If PORTS_IMPL register is zero, ahci initialize it to full mask
corresponding to nr_ports in the CAP register. hpriv-cap, which is
initialized at the end of the function, is incorrectly used as value
of CAP causing ahci to always override PORTS_IMPL to 0x1 if it's zero.
Fix it.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c|2 +-
drivers/ata/libata-core.c |4 +++-
drivers/ata/pata_amd.c|2 ++
Paul Mackerras wrote:
Alan Cox writes:
On Fri, 22 Jun 2007 11:39:45 +0800
David Woodhouse [EMAIL PROTECTED] wrote:
On Fri, 2007-06-22 at 01:52 +0200, Adrian Bunk wrote:
Users should use the libata based drivers for SATA drives.
NAK. Not all IDE drivers are converted yet. Not even all the
Matt Sealey wrote:
Just bringing this up again as it's about that time of year.
There's an issue with some Via southbridges (the only notable and confirmed
example I have being the VT8231 on the PegasosPPC) which can be configured
such that they report that they are in PCI Native Mode, but in
Carlo Wood wrote:
The dmesg output of 33480a0ede8dcc7e6483054279008f972bd56fd3 (thus
before) is:
[...]
And the dmesg output of 551c012d7eea3dc5ec063c7ff9c718d39e77634f (thus
after) is:
[...]
Your disk configurations are quite radically different between the two
kernels (see attached diff
Carlo Wood wrote:
Is it possible that the measurement with hdparm -tT returns a higher
value for some setting, but that the over-all real-life performance
drops?
IN THEORY, RAID performance should /increase/ due to additional queued
commands available to be sent to the drive. NCQ == command
Willy Tarreau wrote:
On Mon, Jun 25, 2007 at 10:06:47AM +0200, Vincent Bernat wrote:
OoO En ce début de soirée du vendredi 22 juin 2007, vers 21:13, Willy
Tarreau [EMAIL PROTECTED] disait:
This is a SATA CDROM. There is no PATA controller on the motherboard.
I've never tested any SATA
Tejun Heo wrote:
The infamous abnormal status message triggers on not so abnormal cases
including empty port and even when it's being triggered on actual
errors the info it provides is redundant and out of context - higher
level functions will print the info in better safe later anyway.
Also,
Tejun Heo wrote:
prereset() is now allowed to set flag for unsupported reset method.
EH layer is responsible for selecting the fallback. Remove non-sense
warning message.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c |2 --
1 file changed, 2 deletions(-)
diff
Tejun Heo wrote:
There's no reason to print out hpa related messages when HPA is not
active. Kill the unconditional message and add a warning message
which is printed if HPA size is smaller than the current size.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 11
Tejun Heo wrote:
Removed unused variable did_followup_srst from ata_eh_reset().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index
Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Fix section mismatch when CONFIG_HOTPLUG=n (but functions are used
for resume):
WARNING: drivers/ata/pata_it821x.o(.text+0x3f): Section mismatch: reference to
.init.text: (between 'it821x_reinit_one' and 'it821x_program_udma')
WARNING:
Tejun Heo wrote:
Fix silly condition check bug in ata_dev_disable().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index adfae9d..09ade2a
Tejun Heo wrote:
When EH gives up after repeated exceptions, it doesn't't clear the
PENDING bit on exit which leaves PENDING bit set without EH actually
scheduled. This makes ata_port_wait_eh() to wait forever makes rmmod
hang on such port. Fix it by clearing the flag.
Signed-off-by: Tejun
Tejun Heo wrote:
In atapi_xlat(), prepare qc better before calling
ata_check_atapi_dma() such that ata_check_atapi_dma() can use info
from qc. While at it, reformat weird looking if/else block in the
function.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-scsi.c | 20
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/libata-core.c | 56 +++-
drivers/ata/libata-eh.c |7 +
Andrew Morton wrote:
On Wed, 27 Jun 2007 03:35:26 -0400 Jeff Garzik [EMAIL PROTECTED] wrote:
+ /* Don't allow DMA if it isn't multiple of 16 bytes. Quite a
+* few ATAPI devices choke on such DMA requests.
+*/
+ if (unlikely(qc-nbytes 15))
+ return 1
Thomas Tsai wrote:
Does anyone familiar with SiliconImage 3132 SATA controller?
I'm running siliconimage 3132 as e-Sata controller on my ARM-based board.
My kernel version is 2.6.18.6. I built libata and sata_sil24 as kernel
module.
After I insert libata and sata_sil24 module, and plug
Mark Lord wrote:
Tejun Heo wrote:
sata_inic162x can't do LBA48 properly yet. Whine loudly about it to
reduce confusion.
Why not whine only when an affected device is actually present?
That's sorta that I think...
Jeff
-
To unsubscribe from this list: send the line unsubscribe
Tejun Heo wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Tejun Heo wrote:
sata_inic162x can't do LBA48 properly yet. Whine loudly about it to
reduce confusion.
Why not whine only when an affected device is actually present?
That's sorta that I think...
That was me being lazy. I'll just ban
Uwe Koziolek wrote:
Nevermind, I did it myself:
This ensures that we can easily make changes specific to the PATA port
on the newer SATA chips, and also does what I've been requesting -- use
the standard ata_bmdma_error_handler(), rather than creating custom code
that achieves the same effect.
701 - 800 of 1579 matches
Mail list logo
