Re: [PATCH]: libata-core: Add support for ATA_HORKAGE_DIAGNOSTIC

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: -if (print_info) { +if (print_info && !(ata_device_blacklisted(dev) & ATA_HORKAGE_DIAGNOSTIC)) { ata_dev_printk(dev, KERN_WARNING, "Drive reports diagnostics failure. This may indicate a drive\n"); a

Re: [PATCH] pata_pdc2027x: Restore various updates done on the driver

2007-03-09 Thread Jeff Garzik
Jeff Garzik wrote: Alan Cox wrote: - Use of cable_detect method - ata_pci_default_filter needed on PATA100 ops - Filter for UDMA 133 errata from vendor (not enabled in this diff but added ready) Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied I take that back. Tons of build pr

Re: [PATCH] pata_artop: Remove all the crud again and restore the cable method

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied, as part of a jumbo patch - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pata_cmd64x: Restore cable method

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied, as part of a jumbo patch. also applied in the jumbo patch: pata_cs5520, pata_cs5530, pata_hpt3x3, pata_isapnp, pata_ixp4xx_cf, pata_legacy, pata_oldpiix - To unsubscribe from this list: send the line "unsubscribe linux-ide

Re: [PATCH] pata_atiixp: Restore the cable method

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pata_efar: Switch back to cable methods

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pata_hpt366: Switch back to cable method again

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ahci: separate port number determination from host initialization

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: ahci used to reset controller then fetch cap value to be used for configuration. On some controller this misses some cap bits and ahci got modified to maintain cap and ports_impl values over reset, so there is no reason to reset the controller before fetching those register valu

Re: [PATCH] pata_hpt3x2n: Further updating based upon old IDE work

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: And it now supports the hpt371n so at some point needs a rename. Sigh Procedure for this: 1) Send me a diff of the /changed/ files (usually just Makefile, and NEVER send changes to the files being renamed) 2) Include in the patch email "Jeff, please run 'git mv OLD NEW' with

Re: [PATCH] pata_hpt37x: Updates from drivers/ide work

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Drag pata_hpt37x kicking and screaming in the direction of drivers/ide/pci/hpt366.c and all the work that Sergei has been doing there. Plenty left to be done but this is a good snapshot for folks to work on and to review Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - T

Re: [patch 03/30] pata: expose set_mode method so it can be wrapped

2007-03-09 Thread Jeff Garzik
OTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Tejun Heo <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c | 37 +--- include/linux/libata.h|1 2 files changed, 31 insertions(+)

Re: [PATCH] sata_sil: First step to removing ->post_set_mode

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Now that we have ata_do_set_mode() available for drivers to use we don't actually need ->post_set_mode() as the driver can wrap set_mode nicely and do stuff before or after (eg PCMCIA needs before), so we can kill off a method in all the structs While I was at it I added kernel-d

Re: [PATCH] libata-core: Fix the iordy methods

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: This alone isn't sufficient to save the universe from prehistoric disks and controllers but it is a first important step. Split off a separate function to provide a mode filter when controller iordy is not available. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied patch and

Re: [PATCH] libata: Change prototype of mode_filter to remove ata_port *

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: With Tejun having added adev->ap some time ago we can get rid of the almost unused port being passed to mode filters. And while we are doing filters, lets turn on the !IORDY filter as well. (Versus -mm tree and queued diffs so may not 100% match your tree Jeff but cc'd so you can

Re: [PATCH 01/12] libata: allocate ap separately from shost

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Don't embed ap inside shost. Allocate it separately and point it back from shosts's hostdata. This makes port allocation more flexible and allows regular ATA and SAS share host alloc/init paths. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c | 15

Re: [PATCH] libata: fix native mode disabled port handling

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Disabled port handling in ata_pci_init_native_mode() is slightly broken in that it may end up using the wrong port_info. This patch updates it such that disables ports are made dummy as done in the legacy and other cases. While at it, fix indentation in ata_resources_present().

Re: [PATCH 03/12] libata: separate out ata_host_alloc() and ata_host_attach()

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Reorganize ata_host_alloc() and its subroutines into the following three functions. * ata_host_alloc() : allocates host and its attached ports. shost is not attached automatically. * ata_scsi_add_hosts() : allocates and adds shosts associated with an ATA host. Used by ata

Re: [PATCH 06/12] libata: convert native PCI host handling to new init model

2007-03-09 Thread Jeff Garzik
This reminds me to kill combined mode handling. Just putting that in now... - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 5/7] [RFC] xenon: add SATA support

2007-03-09 Thread Jeff Garzik
Felix Domke wrote: This adds support for the HDD and DVD SATA controller on the xenon southbridge. It also disables ATA_TFLAG_POLLING in libata-core, which prevented the DVD drive from being detected. It needs to be investigated what exactly is wrong here. It sounds like everyone agrees this n

Re: [PATCH 04/12] libata: implement ata_host_alloc_pinfo() and ata_host_attach()

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Implement ata_host_alloc_pinfo() and ata_host_attach(). These helpers will be used in the following patches to adopt new init model. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c | 93 + include/linux/l

Re: [PATCH 05/12] libata: convert legacy PCI host handling to new init model

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Convert legacy PCI host handling to alloc-init-attach model. ata_init_legacy_host(), ata_request_legacy_irqs() and ata_pci_init_bmdma() are separated out and follow the new init model. The two legacy handling functions use separate ata_legacy_devres instead of generic devm_* res

Re: Marvell SATA AHCI 0x6141

2007-03-09 Thread Jeff Garzik
Davor wrote: HI I have onboard 02:00.0 SATA controller: Marvell Technology Group Ltd. Unknown device 6141 (rev 01) 02:00.0 0106: 11ab:6141 (rev 01) and it's an AHCI compatible device so a simple patch makes it work (patch agains linux-2.6.20.2) --- drivers/ata/ahci.c.orig 2007-03-09 21

Re: [PATCH] sata_nv: revert use of notifiers for now

2007-03-09 Thread Jeff Garzik
Robert Hancock wrote: Commit 721449bf0d51213fe3abf0ac3e3561ef9ea7827a added support for using the ADMA notifier bits to determine which commands to check for completion. However there have been reports that this causes command timeouts in certain cases. This is still being investigated. In addit

Re: [PATCH] devres: release resources on device_del()

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Some platform devices are driven without driver attached, so managed resources can be acquired without driver attached. Make sure such resources are released by calling devres_release_all() in device_del(). Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- This one fixes oops on

Re: [PATCH] pata_cmd640: Multiple updates

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Add suspend/resume support Write 0x5B to 0 not 0x5C The former is important as we must kill the FIFO on a resume Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROT

Re: [PATCH] iomap: implement pcim_iounmap_regions()

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Implement pcim_iounmap_regions() - the opposite of pcim_iomap_regions(). Signed-off-by: Tejun heo <[EMAIL PROTECTED]> --- This one is used by libata's new init model and generally useful for driver midlayers. Please push it through libata-dev#upstream. Thanks. include/linux/

[PATCH 2.6.22] remove Intel combined mode quirk

2007-03-09 Thread Jeff Garzik
PATA ports now, without having to pass a kernel command line parameter. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> arch/i386/defconfig |1 arch/parisc/configs/c3000_defconfig |1 arch/x86_64/defconfig |1 drivers/ata/K

Re: [PATCH 2.6.22] remove Intel combined mode quirk

2007-03-09 Thread Jeff Garzik
Jeff Garzik wrote: diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 066689c..0a19466 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -779,40 +779,16 @@ int ata_pci_init_one (struct pci_dev *pdev, struct ata_port_info **port_info

[git patches] libata (and devres) fixes

2007-03-09 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c| 11 +++ drivers/ata/libata-core.c | 19 --- drivers/ata/sata_nv.c |8 +

Re: [PATCH 2.6.22] remove Intel combined mode quirk

2007-03-09 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> and you can remove even more code as pci_request_resources() will now just do the right thing for all cases. pci_request_regions() you mean? Jeff - To unsubscri

Re: [git patches] libata (and devres) fixes

2007-03-09 Thread Jeff Garzik
Fabio Comolli wrote: Hi. This update gives a new warning: libata version 2.20 loaded. ata_piix :00:1f.1: version 2.10ac1 ata1: PATA max UDMA/100 cmd 0x000101f0 ctl 0x000103f6 bmdma 0x000118c0 irq 14 ata2: PATA max UDMA/100 cmd 0x00010170 ctl 0x00010376 bmdma 0x000118c8 irq 15 scsi0 : ata_

Re: libata-acpi: allow _GTF on SATA, but disable on PATA for now

2007-03-10 Thread Jeff Garzik
Linux Kernel Mailing List wrote: Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=df33c77e3981e71afc8727ee5c432ba1a1bba68c Commit: df33c77e3981e71afc8727ee5c432ba1a1bba68c Parent: 908e0a8a265fe8057604a9a30aec3f0be7bb5ebb Author: Kristen Acca

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Jeff Garzik
Alan Cox wrote: I would be interested to know what the disk vendors intend to use as their strategy when (with ATA) they have a 512 byte write from an older file system/setup into a 4K block. The case where errors magically appear Well, you have logical and physical sector size changes. First

Re: regression: ide-floppy doesn't work with IOMEGA IDE ZIP drive

2007-03-12 Thread Jeff Garzik
Tejun Heo wrote: [libata] And, as the device requires custom high level driver, libata fails miserably. Would it be worth to try support these devices? Or are they just too outdated to put the effort in? What SCSI peripheral device type does it report, when booted under libata? Jeff

Re: impact of 4k sector size on the IO & FS stack

2007-03-12 Thread Jeff Garzik
Alan Cox wrote: First generation of 1K sector drives will continue to use the same 512-byte ATA sector size you are familiar with. A single 512-byte write will cause the drive to perform a read-modify-write cycle. This configuration is physical 1K sector, logical 512b sector. The problem ca

Re: impact of 4k sector size on the IO & FS stack

2007-03-12 Thread Jeff Garzik
Jan Engelhardt wrote: On Mar 11 2007 18:51, Ric Wheeler wrote: During the recent IO/FS workshop, we spoke briefly about the coming change to a 4k sector size for disks on linux. If I recall correctly, the general feeling was that the impact was not significant since we already do most file syste

Re: impact of 4k sector size on the IO & FS stack

2007-03-12 Thread Jeff Garzik
Jan Engelhardt wrote: On Mar 11 2007 22:45, Ric Wheeler wrote: Jan Engelhardt wrote: On Mar 11 2007 18:51, Ric Wheeler wrote: During the recent IO/FS workshop, we spoke briefly about the coming change to a 4k sector size for disks on linux. If I recall correctly, the general feeling was that

Re: impact of 4k sector size on the IO & FS stack

2007-03-12 Thread Jeff Garzik
Christoph Hellwig wrote: the occasional 2k sector SCSI MO device aswell. It would be nice to get samples of large sector size ATA devices into the hands of developers to do real world testing of the whole stack. "hands of developers" meaning you specifically? :) I've had a 512b-logical/1K-ph

Re: impact of 4k sector size on the IO & FS stack

2007-03-12 Thread Jeff Garzik
Douglas Gilbert wrote: Bryan Henderson wrote: What is an odd-aligned disk? s/disk/partition/ ? Example: An odd-aligned disk in the 512-b logical / 1K-physical scenario is where odd LBAs indicate the start of a 1K physical sector. An even-aligned disk is where even LBAs indicate the start

Re: regarding ACPI support in 2.6.21

2007-03-12 Thread Jeff Garzik
Alan Cox wrote: I think it might be better to give up ACPI support in 2.6.21 and target 2.6.22. What do you think? I removed it from my tree already so that I can actually use libata and do real work. The "crash every non PCI controller" feature in the current ACPI hacks means PCMCIA and ISAPn

Re: Fwd: libata extension

2007-03-13 Thread Jeff Garzik
Vitaliyi wrote: Why is the access to Control register needed? To execute soft reset for example. > In the perfect case i would like to be able to execute vendor command > set (reverse engineered). Sounds interesting. :-) Could you give some more details on what are you going to implement?

Re: [PATCH libata#upstream] sata_promise: decode and report error reasons

2007-03-14 Thread Jeff Garzik
Mikael Pettersson wrote: This patch adds much needed error reason decoding and reporting to sata_promise. It's simplistic but should log all relevant error info the controller provides. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_promise.c | 64 ++

Re: [PATCH] libata: hardreset on SERR_INTERNAL

2007-03-14 Thread Jeff Garzik
Tejun Heo wrote: There was a rare report where SB600 reported SERR_INTERNAL and SRST couldn't get it out of the failure mode. Hardreset on SERR_INTERNAL. As the problem is intermittent, whether this fixes the problem or not hasn't been verified yet, but hardresetting the channel on internal erro

Re: regression: ide-floppy doesn't work with IOMEGA IDE ZIP drive

2007-03-14 Thread Jeff Garzik
Mark Lord wrote: Tejun wrote: If that's the case, libata should work too as long as the HSM problem is fixed. Really? I didn't notice when libata gained ATAPI-disk support. ATAPI just passes through to SCSI. There is no limitation on the peripheral device types supported, except in the SC

Re: PATA Sil680 Command Timeout on ARM XScale

2007-03-14 Thread Jeff Garzik
Fajun Chen wrote: Since primary channel and secondary channel share the same IRQ, the ISR could be called to service one or both channels. So I would think it's normal to see "irq trap" traces when both channels are in IO operation, correct? The irq trap code only occurs after a certain number

Re: [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access

2007-03-14 Thread Jeff Garzik
Russell King wrote: pci_enable_device() doesn't deal with this; in most PCI setups I've seen, there is no control at PCI level over whether a device generates an interrupt on the bus. Certainly the memory and io command enables PCI grew an interrupt enable while you weren't looking: PCI_COMMA

Re: [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access

2007-03-14 Thread Jeff Garzik
Russell King wrote: In any case, relying on such a new control bit to implement this kind of functionality would result in a very hit and miss result; Linux How does Tejun's patch or thesis rely on this new control bit? He explicitly mentions DISABLE_INTX variability... Jeff - To

Re: sata_inic162x driver for 2.6.19 timeouts etc

2007-03-15 Thread Jeff Garzik
Tejun Heo wrote: Hello, Bob Stewart wrote: Is there an easy way to tell whether the command was sent as LBA48, say, in the driver's bmdma_start function or even in the hardreset function after the fact? One of my tests was using a 64 sector limit, with pretty much the same results. I always

Re: sata_inic162x driver for 2.6.19 timeouts etc

2007-03-15 Thread Jeff Garzik
Alan Cox wrote: both the reading and writing are seriously broken. I can't tell whether they end up in the wrong sectors or garbage is transferred to/from the right sectors. Does this occur regardless of which interface you use (the register shadow or the DMA command engine ?) I'm curious of

Please pull for stable ATA

2007-07-26 Thread Jeff Garzik
Please pull commit fe36cb53cfd82f3c0796a0826e1c9caf198c8f97 Author: Petr Vandrovec <[EMAIL PROTECTED]> Date: Fri Jul 20 07:44:44 2007 -0400 [libata] Fix reported task file values in sense data into the 2.6.22 stable tree. - To unsubscribe from this list: s

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-27 Thread Jeff Garzik
Sergei Shtylyov wrote: Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that "sets" MWDMA timings is completely bogus -- I've a

Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-27 Thread Jeff Garzik
Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ide/Kconfig |4 ++-- 1 file changed, 2 insertio

Re: [PATCH 1/4] libata: ACPI checks for 80wire cable

2007-07-27 Thread Jeff Garzik
Alan Cox wrote: We can use the ACPI mode information with several drivers as a hint to cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then we know the BIOS thinks there are 80wire cables. If it doesn't set such a mode or it has no ACPI method then we get no further information

Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-28 Thread Jeff Garzik
Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Aye, aye. drivers/ide/Kconfig |3 +-- 1 file changed,

Re: [PATCH] fix IDE legacy mode resource

2007-07-28 Thread Jeff Garzik
Yoichi Yuasa wrote: Hi, I got the following error on MIPS Cobalt. MIPS Cobalt has the 0x1000 offset between resource and bus region. PCI: Unable to reserve I/O region #1:[EMAIL PROTECTED] for device :00:09.1 pata_via :00:09.1: failed to request/iomap BARs for port 0 (errno=-16) PC

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-30 Thread Jeff Garzik
Kristen Carlson Accardi wrote: @@ -42,6 +42,16 @@ enum scsi_eh_timer_return { EH_RESET_TIMER, }; +/* + * shost pm policy: If you alter this, you also need to alter scsi_sysfs.c + * (for the ascii descriptions) + */ +enum scsi_host_link_pm { + SHOST_NOT_AVAILABLE, + SHOST_M

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ... Signed-off-by: Alan Cox <[EMAIL PROTECTED]> --- drivers/ata/sata_mv.c~ 2007-07-09 13:19:57.003052904 +0100 +++ drivers/ata/sata_mv.c 2007-07-09 13:19:57.004052752 +010

Re: Early ATA devices

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: #1 We assume identify works. Early ATA actually lists this command as optional ITYM we assume identify command exists on the device? We certainly do not assume IDENTIFY command, if exists, succeeds. What is the proper probing method -- notice if command-aborted is return

Re: [PATCH] pata_sis: fix MWDMA for <= UDMA66 chipsets and UDMA for UDMA33 chipsets

2007-08-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Fix MWDMA timings setup in sis_old_set_dmamode() and sis_66_set_dmamode(). The old timings were overclocked (even worse behavior than sis5513 IDE driver which depends on BIOS to program correct timings), the new timings are taken from the datasheet (they

Re: [PATCH] libata: blacklist SAMSUNG HD401LJ / ZZ100-15 for NCQ

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: SAMSUNG HD401LJ / ZZ100-15 does spurious completion of NCQ commands. Disable NCQ. Reported by Ulrich in bugzilla #8805. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Ulrich <[EMAIL PROTECTED]> --- And, finally one from samsung. How come vendors got this right previously but

Re: [PATCH] pci: rename __pci_reenable_device() to pci_reenable_device()

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: Rename __pci_reenable_device() to pci_reenable_device(). Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Jeff, Greg wanted to drop the preceding underscores before exporting the function and the updated patch was posted but the earlier version was applied. This patch renames t

Re: [patch 1/4] Store interrupt value

2007-08-01 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> ACK. Regenerate against current kernel and I'll app

Re: [PATCH UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: From: Mark Lord <[EMAIL PROTECTED]> Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, "atapi_scmd85=1" can be used to globally disable this feature, if ever desired. tj:

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied to #upstream-fixes - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: [PATCH] libata-sff; Unbreak non DMA capable controllers again

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: Seems nobody else is checking/testing this case as it keeps getting horked. If we have no BAR4 mapping on an SFF controller this is *NOT* an error, it just means it isn't doing BMDMA. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied to #upstream-fixes - To unsubscribe fro

[git patches] libata fixes

2007-08-01 Thread Jeff Garzik
The only notable: GregKH wanted the pci_reenable_device() change associated with ata_piix to go in before the release, to avoiding release with an imperfect API. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to rece

[PATCH] pata_isapnp: use MODULE_DEVICE_TABLE()

2007-08-02 Thread Jeff Garzik
I found this while doing ISDN PCI API conversions... I presume this omission was not intentional? Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> diff --git a/drivers/ata/pata_isapnp.c b/drivers/ata/pata_isapnp.c index 5525518..91a396f 100644 --- a/drivers/ata/pata_isapnp.c +++ b/drive

Re: Libata Sil3124 hybrid drive failure

2007-08-02 Thread Jeff Garzik
Fajun Chen wrote: Does anyone know if libata supports hybrid drive on Sil3124? I tried to play with Seagate hybrid drive and got protocol mismatch error when adding LBAs to pinned set or querying pinned set? Sil24 driver code does not set Protocol Override field in PRB, just wonder if we need to

Re: [PATCH] sata_qstor, pdc_adma, sata_sx4: convert to new EH

2007-08-03 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: This is just a refresh of the existing libata-dev.git#new-eh patches that convert all remaining old-EH drivers to new EH, against 2.6.23-rc1. All three conversions are completely untested. pdc_adma and sata_qstor need reviewing by someone with docs, in

libata git tree, mbox queue status and contents

2007-08-03 Thread Jeff Garzik
This is a quick guide to current libata work that is queued or in progress in some way, shape or form. First, a guide to the branches currently in use in git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git ALL Everything that is exported for testing (and akpm's -mm tree).

Re: [PATCH] libata: implement BROKEN_HPA horkage and apply it to HDS724040KLSA80

2007-08-07 Thread Jeff Garzik
People should check out Ben C's HPA fixes and cleanups, too. (attached) I was hoping one of the original libata HPA authors would review that in depth and integrate. (it no longer applies cleanly) Jeff From: Ben Collins <[EMAIL PROTECTED]> The original HPA patch that Kyle worked

Re: [PATCH] libata: implement BROKEN_HPA horkage and apply it to HDS724040KLSA80

2007-08-07 Thread Jeff Garzik
Alan Cox wrote: On Tue, 07 Aug 2007 11:47:38 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: People should check out Ben C's HPA fixes and cleanups, too. (attached) I was hoping one of the original libata HPA authors would review that in depth and integrate. (it no longer appl

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Jeff Garzik
Kristoffer Nyborg Gregertsen wrote: On Tuesday 07 August 2007 17:54:09 Alan Cox wrote: +static int pata_at32_get_pio_mask(void) +{ + switch (max_pio) { + case 0: + return 0x01; + case 1: + return 0x03; + case 2: + return 0x07;

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-07 Thread Jeff Garzik
Alan Cox wrote: /* Compute DPLL */ - dpll = 2; - if (port->udma_mask & 0xE0) - dpll = 3; + dpll = (port->udma_mask & 0xC0) ? 3 : 2; Gak, I'd much rather people kept to the nice easy to read if() but fine is_author_

Re: [PATCH] ata_piix: update map 10b for ich8m

2007-08-07 Thread Jeff Garzik
Tejun Heo wrote: Fix map entry 10b for ich8. It's [P0 P2 IDE IDE] like ich6 / ich6m. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- Many users can be hit by this. Please consider for -stable. Thanks. drivers/ata/ata_piix.c |2 +- 1 file changed, 1 insertion(+),

[git patches] libata fixes

2007-08-07 Thread Jeff Garzik
+ drivers/ata/sata_mv.c |3 +++ 3 files changed, 6 insertions(+), 1 deletions(-) Alan Cox (1): sata_mv: PCI IDs for Hightpoint RocketRaid 1740/1742 Jeff Garzik (1): [libata] pata_isapnp: replace missing module device table Tejun Heo (1): ata_piix: update map 10b for i

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-07 Thread Jeff Garzik
Alan Cox wrote: On Tue, 07 Aug 2007 20:49:34 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Alan Cox wrote: /* Compute DPLL */ - dpll = 2; - if (port->udma_mask & 0xE0) - dpll = 3; + dpll = (port->

Re: libata git tree, mbox queue status and contents

2007-08-08 Thread Jeff Garzik
Mark Lord wrote: Jeff, This patch (below) is needed by WD drives that powerup-in-standby. drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after drivers/ata/libata-core.c --- a/drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after +++ a/drivers/ata/libata-core.

Re: [PATCH 01/14] libata-link: introduce ata_link

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Introduce ata_link. It abstracts PHY and sits between ata_port and ata_device. This new level of abstraction is necessary to support SATA Port Multiplier, which basically adds a bunch of links (PHYs) to a ATA host port. Fields related to command execution, spd_limit and EH are

Re: [PATCH] libata: Correct IORDY handling

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Debugging a report of a problem with an ancient solid state disk showed up some problems in the IORDY handling 1. We check the wrong bit to see if the device has IORDY 2. Even then some ancient creaking piles of crap don't support SETXFER at all. I think this s

Re: [PATCH 1/2] libata: move ata_altstatus() to pio data xfer functions

2007-08-15 Thread Jeff Garzik
Albert Lee wrote: Patch 1/2: Move ata_altstatus() out from ata_hsm_move() to the pio data xfer functions like ata_pio_sectors() and atapi_pio_bytes() where it makes more sense. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- atapi_send_cdb() already calls ata_altstatus() inside. This patch ma

Re: [PATCH RE-UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: From: Mark Lord <[EMAIL PROTECTED]> Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, "atapi_scmd85=1" can be used to globally disable this feature, if ever desired. tj:

Re: [PATCH] libata-core: Document some limits/assumptions about ID_ATA

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: Note that our cache flush code needs fixing up

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Remembered this while doing auditing and code review versus the specs Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [patch 24/25] pata_cmd64x: Set up MWDMA modes properly

2007-08-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Alan Cox <[EMAIL PROTECTED]> Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Tested-by: Mikael Pettersson <[EMAIL PROTECTED]> Signed-off-by: Andr

Re: [patch 1/4] libata: check for AN support

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-gi

Re: [patch 4/4] libata: send event when AN received

2007-08-15 Thread Jeff Garzik
applied the attached slightly modified patch. main changes: * SCSI stuff has not been applied yet, so libata's notify is a no-op for now * fixed endian bug in SDB FIS handling diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 757369e..c41bd2c 100644 --- a/drivers/ata/ahci.c +++ b/dri

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a new sysfs entry "media_change_notify", which will be 1 if it is supported, and 0 if not supported. Create a routine which allows scsi device

Re: [patch 1/4] Store interrupt value

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> applied, after adding "ahci: " prefix to subject lin

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-15 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) and for AEC6880[R] it is UDMA6 (not UDMA5): * Fix the problem by adding missing struct ata_port_info to artop_init_one(). * Use the right naming (s/626/628/). * Bump driver version. Fixes IDE->lib

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 with 50 MHz DPLL (take 2)

2007-08-15 Thread Jeff Garzik
Sergei Shtylyov wrote: The DPLL tuning code always set up it for 66 MHz due to wrong UltraDMA mask including mode 5 used to check for the necessity of 66 MHz clocking -- this caused 66 MHz clock to be used for HPT374 chip that does not tolerate it. While fixing this, also remove PLL mode from the

Re: [PATCH] ata_piix: add TECRA M7 to broken suspend list

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Add TECRA M7 to broken suspend list. Reported by Marie Koreen. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Marie Koreen <[EMAIL PROTECTED]> --- drivers/ata/ata_piix.c |7 +++ 1 file changed, 7 insertions(+) applied to #upstream-fixes - To unsubscribe from this

Re: [patch 25/25] ata_piix: disallow UDMA 133 on ICH5 & ICH7

2007-08-15 Thread Jeff Garzik
a133.patch - diff from 2.6.22) If there are any concerns about the safety of the patch patch: http://lkml.org/lkml/2007/7/6/292 (It was already tested by an Intel employee, but I guess a bit more user input is necessary here... ) This patch implements 1. Cc: Alan Cox <[EMAIL PROTEC

Re: [patch 04/25] libata-add-irq_flags-to-struct-pata_platform_info-fix

2007-08-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton <[EMAIL PROTECTED]> Remove unneeded, undesirable cast of void*. Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Sonic Zhang <[EMAIL PROTECTED]> Cc: Tejun Heo <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: A

Re: [PATCH libata-dev#upstream 3/3] libata: implement and use ata_port_desc() to report port configuration

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Currently, port configuration reporting has the following problems. * iomapped address is reported instead of raw address * report contains irrelevant fields or lacks necessary fields for non-SFF controllers. * host->irq/irq2 are there just for reporting and hacky. This patch

Re: [PATCH libata-dev#upstream 1/3] libata: use ata_port_printk() in ata_wait_idle()

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: ata_wait_idle() identified controller by printing out the address of the Status register. This is bogus because 1. it's iomapped address 2. some controllers don't have Status register and don't initialize the field. Use ata_port_printk() instead. Signed-off-by: Tejun Heo <[EMA

Re: [PATCH libata-dev#upstream 2/2] libata: move EH repeat reporting into ata_eh_report()

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: EH is sometimes repeated without any error or action. For example, this happens when probing IDENTIFY fails because of a phantom device. In these cases, all the repeated EH does is making sure there is no unhandled error or pending action and return. This repeation is necessary

[git patches] libata fixes

2007-08-15 Thread Jeff Garzik
RocketRaid 1740/1742 Bartlomiej Zolnierkiewicz (1): pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R] Jeff Garzik (1): [libata] pata_isapnp: replace missing module device table Ryan Power (1): libata: adjust libata to ignore errors after spinup Sergei S

Re: [PATCH 1/4] libata: ACPI checks for 80wire cable

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: We can use the ACPI mode information with several drivers as a hint to cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then we know the BIOS thinks there are 80wire cables. If it doesn't set such a mode or it has no ACPI method then we get no further information

Re: [PATCH 3/4] libata: ACPI checks for 80wire cable

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: We can make use of this on the pata_amd driver as many Nvidia devices don't have reliable cable detect. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied 3-4 - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED]

<    4   5   6   7   8   9   10   11   12   13   >