[PATCH] wistron_btns: Generate normal key code if bluetooth or wifi card not present

2008-05-06 Thread Éric Piel
Hello Dmitry, Here is a small patch for wistron_btns that allows laptops having bluetooth or wifi buttons without the bluetooth/wifi hardware to report the key press as a normal key (instead of doing nothing). It was successfully tested by Andrew Lutomirski on his Acer C300: two more keys working

Re: wistron_btns - Is polling always required?

2007-07-27 Thread Éric Piel
07/27/2007 01:20 PM, Carlos Corbacho wrote/a écrit: On Wednesday 25 July 2007 22:41:09 Éric Piel wrote: By removing the entries, we should keep in mind that with the vanilla kernel, there is still a small functionality loss: wireless and led activations are lost. True, but then again, this

Re: wistron_btns - Is polling always required?

2007-07-25 Thread Éric Piel
07/22/2007 04:14 PM, Carlos Corbacho wrote/a écrit: Dimitry, Éric, On Friday 20 July 2007 05:06:35 Dmitry Torokhov wrote: I was not aware that these models can deliver events for hotkeys via atkbd. I think option B is best since interrupt-driven mode is always better than polling. I am CC-ing E

Re: [PATCH] Make ati_remote button repeat sensitivity soft-configurable

2007-04-04 Thread Éric Piel
04/04/2007 02:34 AM, Karl Pickett wrote/a écrit: The ati_remote driver is a little too sensitive for my wife... if you do anything but barely tap the button you can get multiple events reported. We prefer a more conservative no-repeat setting. This is a pretty trivial patch which just makes one

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-19 Thread Éric Piel
19.03.2007 22:28, Dmitry Torokhov wrote/a écrit: On 3/15/07, Éric Piel <[EMAIL PROTECTED]> wrote: Ok, so let me summarize: There are two kinds of keys on those laptops (for which we are not sure about the keycode that it should generate): * Laptop screen on/off * Display output selectio

[PATCH 3/3] wistron_btns: Declare keymaps as initdata

2007-03-18 Thread Éric Piel
This patch declares keymaps as initdata, so they are discarded at runtime, saving about 1kb (10% of the module size). This idea to save memory comes from Dmitry Torokhov. Eric From: Eric Piel <[EMAIL PROTECTED]> wriston_btns: Declare keymaps as initdata As the number of keymaps increases and

[PATCH 2/3] wistron_btns: Generic keymap

2007-03-18 Thread Éric Piel
This patch adds a generic map. That is, a keymap that should output the correct keycodes for most laptops. This is simply based on the observation of all those keymaps already gathered, as most of the wistron codes are always mapped to the same keycode. Hopefully, this way users which have a n

[PATCH 1/3] wriston_btns: Add acerhk laptop database

2007-03-18 Thread Éric Piel
This patch adds all the "tm_new" laptops information that is in acerhk to wistron_btns. That's about 25 more laptops. Obviously, I couldn't try them all. I've just tried the Aspire 3020. For this reason, I've also added a printk which ask the users of those laptops to confirm me it works (or no

[PATCH 0/3] wistron_btns: More keymaps, take 2

2007-03-18 Thread Éric Piel
Hello, This is a new version of my patch to add support for more laptops to the wistron_btns driver. Modifications from the previous version: * sends lid close/open event as a switch event (not a key event) * Display on/off is KEY_SCREEN and Display selection is KEY_SWITCHVIDEOMODE, from the d

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-15 Thread Éric Piel
03/14/2007 08:02 PM, Vojtech Pavlik wrote/a écrit: On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote: 2. I also have a concern about using KEY_SCREEN to signal toggling display on and off. I am CCing Vojtech - he must know what the original intent of this key code was. BTW, when u

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Éric Piel
03/14/2007 08:02 PM, Dmitry Torokhov wrote/a écrit: On 3/14/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On 3/14/07, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: > > Hi Eric, > > > > 2. I also have a concern about using KEY_SCREEN

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Éric Piel
03/14/2007 02:54 PM, Dmitry Torokhov wrote/a écrit: Hi Eric, : I have couple of comments/requests: 1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the lid, they correspond to Accpication Control Open and Close keys from USB HID HUT spec: http://www.usb.org/developers/devc