Re: [PATCH v3 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-13 Thread Lee Jones
On Tue, 11 Nov 2014, R, Vignesh wrote: > On Tue, 11 Nov 2014, Vignesh R wrote: > > In one shot mode, sequencer automatically disables all enabled steps > > at the end of each cycle. (both ADC steps and TSC steps) Hence these > > steps need not be saved in reg_se_cache for clearing these steps at

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Alexander Stein
On Wednesday 12 November 2014 20:16:06, Arnd Bergmann wrote: > On Wednesday 12 November 2014 17:38:31 Alexander Stein wrote: > > On Wednesday 12 November 2014 17:04:57, Arnd Bergmann wrote: > > > On Wednesday 12 November 2014 17:02:56 Alexander Stein wrote: > > > > This features already exists for

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Arnd Bergmann
On Thursday 13 November 2014 11:35:42 Alexander Stein wrote: > On Wednesday 12 November 2014 20:16:06, Arnd Bergmann wrote: > > On Wednesday 12 November 2014 17:38:31 Alexander Stein wrote: > > > On Wednesday 12 November 2014 17:04:57, Arnd Bergmann wrote: > > > > On Wednesday 12 November 2014 17:0

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Alexander Stein
On Thursday 13 November 2014 11:47:13, Arnd Bergmann wrote: > Regarding your initial use case of testing interrupt polarity, would > you have been able to do the same thing by looking at the interrupt > count in /proc/interrupts? This is only possible if some driver actually requests this interrup

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Arnd Bergmann
On Thursday 13 November 2014 11:52:48 Alexander Stein wrote: > On Thursday 13 November 2014 11:47:13, Arnd Bergmann wrote: > > Regarding your initial use case of testing interrupt polarity, would > > you have been able to do the same thing by looking at the interrupt > > count in /proc/interrupts?

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Laxman Dewangan
On Thursday 13 November 2014 04:17 PM, Arnd Bergmann wrote: On Thursday 13 November 2014 11:35:42 Alexander Stein wrote: On Wednesday 12 November 2014 20:16:06, Arnd Bergmann wrote: On Wednesday 12 November 2014 17:38:31 Alexander Stein wrote: On Wednesday 12 November 2014 17:04:57, Arnd Bergm

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Arnd Bergmann
On Thursday 13 November 2014 16:29:02 Laxman Dewangan wrote: > On Thursday 13 November 2014 04:17 PM, Arnd Bergmann wrote: > > I notice that Laxman Dewangan initially added the feature as part of > > (I assume) work on Tegra, but these days Tegra is DT-only so it can't > > actually get used for tha

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Laxman Dewangan
On Thursday 13 November 2014 04:30 PM, Arnd Bergmann wrote: On Thursday 13 November 2014 11:52:48 Alexander Stein wrote: On Thursday 13 November 2014 11:47:13, Arnd Bergmann wrote: Regarding your initial use case of testing interrupt polarity, would you have been able to do the same thing by lo

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Laxman Dewangan
On Thursday 13 November 2014 04:35 PM, Arnd Bergmann wrote: On Thursday 13 November 2014 16:29:02 Laxman Dewangan wrote: Yes, I posted patch for interrupt key on context on key connected to PMIC-Onkey. On PMIC, there is onkey pin input which generates interrupt only when it toggles. So if we ha

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-13 Thread Vignesh R
Hi, On Wednesday 12 November 2014 06:30 PM, Johannes Pointner wrote: > Hello Vignesh, > > I tried your patch version 3 on a customized board and had some > behavior I couldn't explain. > If I only use the touchscreen it works fine but if I also read values > from the ADCs then I get a lot of pen_

Re: [PATCH v3] Input: evdev - add event-mask API

2014-11-13 Thread David Herrmann
Hi On Wed, Nov 12, 2014 at 1:41 PM, David Herrmann wrote: > Hi > > On Wed, Nov 12, 2014 at 8:40 AM, Dmitry Torokhov > wrote: >> Hi David, >> >> On Tue, Nov 04, 2014 at 06:12:23PM +0100, David Herrmann wrote: >>> +static int bits_from_user(unsigned long *bits, unsigned int maxbit, >>> +

[PATCH v2 2/4] input: touchscreen: of: Register multitouch axes

2014-11-13 Thread Maxime Ripard
So far, the DT parsing code was only setting up the regular input axes, completely ignoring their multitouch counter parts. Fill them with the same parameters than the regular axes. Signed-off-by: Maxime Ripard --- drivers/input/touchscreen/of_touchscreen.c | 22 +- 1 file c

[PATCH v2 4/4] input: edt-ft5x06: Remove EV_SYN event report

2014-11-13 Thread Maxime Ripard
input_register_device already sets the EV_SYN event since all devices can generate them. Remove the redundant affectation. Signed-off-by: Maxime Ripard --- drivers/input/touchscreen/edt-ft5x06.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers

[PATCH v2 0/4] input: ft5x06: Fix userspace reported maximum value

2014-11-13 Thread Maxime Ripard
Hi, The current ft5x06 reports to the user-space that its maximum coordinates are, on both X and Y, way higher than what could be actually usable on the screen (in my case, 5759x1151 instead of 480x800). This causes trouble on some userspace stacks that then try to re-scale these coordinates back

[PATCH v2 3/4] input: ft5x06: Allow to set the maximum axes value through the DT

2014-11-13 Thread Maxime Ripard
Currently the driver relies on some obscure and undocumented register to set the maximum axis value. The reported value is way too high to be meaningful, which confuses some userspace tools like QT's evdevtouch plugin which try to scale the reported events to the maximum values. Use the values fr

[PATCH v2 1/4] input: touchscreen: of: Use input_set_abs_params

2014-11-13 Thread Maxime Ripard
Drivers are still required to call input_set_abs_params for their axes, as if they only use the touchscreen_parse_of_params function, the axis bit in absbit won't be set. Switch to using input_set_abs_params to fully setup each and every available axis so that drivers will be able to solely use th

[PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-13 Thread Benson Leung
usbhid->intf->needs_remote_wakeup is set when a device is opened, and is cleared when a device is closed. When a usbhid device that does not support remote wake ( i.e. !device_can_wakeup() ) is closed, we fail out of autosuspend_check() because the autosuspend check is called before the flag is cl

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-13 Thread Alan Stern
On Thu, 13 Nov 2014, Benson Leung wrote: > usbhid->intf->needs_remote_wakeup is set when a device is > opened, and is cleared when a device is closed. > > When a usbhid device that does not support remote wake > ( i.e. !device_can_wakeup() ) is closed, we fail out of > autosuspend_check() because

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-13 Thread Benson Leung
On Thu, Nov 13, 2014 at 12:41 PM, Alan Stern wrote: > usbhid_stop probably doesn't need it. And it should be possible to fix > usbhid_close more easily just by interchanging the two lines: > > - usb_kill_urb(usbhid->urbin); > usbhid->intf->needs_remot

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-13 Thread Alan Stern
On Thu, 13 Nov 2014, Benson Leung wrote: > On Thu, Nov 13, 2014 at 12:41 PM, Alan Stern > wrote: > > usbhid_stop probably doesn't need it. And it should be possible to fix > > usbhid_close more easily just by interchanging the two lines: > > > > - usb_kill_urb(usbhid->urbi

[PATCH v2] HID: usbhid: clear needs_remote_wakeup before usb_kill_urb

2014-11-13 Thread Benson Leung
usbhid->intf->needs_remote_wakeup is set when a device is opened, and is cleared when a device is closed. When a usbhid device that does not support remote wake ( i.e. !device_can_wakeup() ) is closed, we fail out of autosuspend_check() because the autosuspend check is called before the flag is cl

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-13 Thread Benson Leung
On Thu, Nov 13, 2014 at 1:18 PM, Alan Stern wrote: > If you interchange the two lines then the flag _will_ be cleared before > usb_kill_urb() and autosuspend_check() can run. This means your patch > description is bogus. Gotcha. v2 posted. Thanks for the direction. -- Benson Leung Software Eng

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-13 Thread Alan Stern
On Thu, 13 Nov 2014, Benson Leung wrote: > On Thu, Nov 13, 2014 at 1:18 PM, Alan Stern wrote: > > If you interchange the two lines then the flag _will_ be cleared before > > usb_kill_urb() and autosuspend_check() can run. This means your patch > > description is bogus. > > Gotcha. v2 posted. Th

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-13 Thread Benson Leung
Hi Alan, On Thu, Nov 13, 2014 at 2:11 PM, Alan Stern wrote: > Wait a minute -- in your previous email you said this approach didn't > work. So does it work or doesn't it? Sorry for the confusion. The approach *does* work. That was actually my original idea to fix the problem, but I saw other p

Re: [PATCH v3] hid: sony: Use kernel allocated buffers for HID reports

2014-11-13 Thread Dmitry Torokhov
On Wed, Nov 12, 2014 at 02:10:09PM -0500, Frank Praznik wrote: > Replace stack buffers with kernel allocated buffers for sending > and receiving HID reports to prevent issues with DMA transfers > on certain hardware. > > Output report buffers are allocated at initialization time to avoid > excessi

[PATCH v4 0/6] Touchscreen performance related fixes

2014-11-13 Thread Vignesh R
This series of patches fix TSC defects related to lag in touchscreen performance and cursor jump at touch release. The lag was result of udelay in TSC interrupt handler. Cursor jump due to false pen-up event. The patches implement Advisory 1.0.31 in silicon errata of am335x-evm to avoid false pen-u

[PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC

2014-11-13 Thread Vignesh R
The charge delay value is by default 0x400. But it can be set to lower values on some boards, as long as false pen-ups are avoided. Lowering the value increases the sampling rate (though current sampling rate is sufficient for TSC operation). In some boards, the value has to be increased to avoid f

[PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-13 Thread Vignesh R
From: Brad Griffis TSC interrupt handler had udelay to avoid reporting of false pen-up interrupt to user space. This patch implements workaround suggesting in Advisory 1.0.31 of silicon errata for am335x, thus eliminating udelay and touchscreen lag. This also improves performance of touchscreen a

[PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-13 Thread Vignesh R
From: Brad Griffis This patch makes the initial changes required to workaround TSC-false pen-up interrupts. It is required to implement these changes in order to remove udelay in the TSC interrupt handler and false pen-up events. The charge step is to be executed immediately after sampling X+. He

[PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-13 Thread Vignesh R
In one shot mode, sequencer automatically disables all enabled steps at the end of each cycle. (both ADC steps and TSC steps) Hence these steps need not be saved in reg_se_cache for clearing these steps at a later stage. Also, when ADC wakes up Sequencer should not be busy executing any of the conf

[PATCH v4 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter

2014-11-13 Thread Vignesh R
This patch reads charge delay from tsc DT node and writes to REG_CHARGEDELAY register. If the charge delay is not specified in DT then default value of 0x400(CHARGEDLY_OPENDLY) is used. Signed-off-by: Vignesh R --- drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++- 1 file changed, 7 inserti

[PATCH v4 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering

2014-11-13 Thread Vignesh R
Previously, delta filtering was applied TSC co-ordinate readouts before reporting a single value to user space. This patch replaces delta filtering with median filtering. Median filtering sorts co-ordinate readouts, drops min and max values, and reports the average of remaining values. This method

[PATCH v10 00/18] input: cyapa: instruction of cyapa patches

2014-11-13 Thread Dudley Du
V10 patches have below main updates compared with v9 patches: 1) Modify code to following kernel code style. e.g.: correct to use error as return name when there is only error path, and fix the checkpatch.sh wanting in the driver. 2) Remove cyapa_remove method and use input open and close int

[PATCH v10 01/18] input: cyapa: add device resource management infrastructure support

2014-11-13 Thread Dudley Du
This patch modified the code to fix the patch check warning issue with latest checkpatch.sh tool, and also changed the return variable name from "ret" to "error" when there is only one error path to follow code style. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa.c | 151 +++

[PATCH v10 18/18] input: cyapa: add gen5 trackpad device read raw data function support

2014-11-13 Thread Dudley Du
Add read raw data function supported for gen5 trackpad device, it can be used through debugfs raw_data interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa_gen5.c | 138 +++ 1 file changed, 138 insertions(+) diff --git a

[PATCH v10 15/18] input: cyapa: add gen3 trackpad device read firmware image function support

2014-11-13 Thread Dudley Du
Add read firmware image function supported for gen3 trackpad device, it can be used through debugfs read_fw interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa_gen3.c | 67 1 file changed, 67 insertions(+) diff --g

[PATCH v10 16/18] input: cyapa: add gen5 trackpad device read firmware image function support

2014-11-13 Thread Dudley Du
Add read firmware image function supported for gen5 trackpad device, it can be used through debugfs read_fw interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa.h | 1 + drivers/input/mouse/cyapa_gen5.c | 155 +++

[PATCH v10 17/18] input: cyapa: add read sensors raw data debugfs interface support

2014-11-13 Thread Dudley Du
Add read sensors' raw data from trackpad device interface supported in cyapa driver through debugfs raw_data interface. Through this interface, user can read difference count map of each sensors directly from trackpad device (some customers want). And it's useful to help users to find out the root

[PATCH v10 14/18] input: cyapa: add read firmware image debugfs interface support

2014-11-13 Thread Dudley Du
Add read firmware image from trackpad device interface supported in cyapa driver through debugfs read_fw interface. Through this interface user can read out, check and backup the firmware image of the trackpad device before any firmware update, or can use the backed image to do firmware image recov

[PATCH v10 12/18] input: cyapa: add gen5 trackpad device read baseline function support

2014-11-13 Thread Dudley Du
Add read baseline function supported for gen5 trackpad device, it can be used through sysfs baseline interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa.h | 2 + drivers/input/mouse/cyapa_gen5.c | 621 +++ 2 files

[PATCH v10 13/18] input: cyapa: add gen5 trackpad device force re-calibrate function support

2014-11-13 Thread Dudley Du
Add force re-calibrate function supported for gen5 trackpad device, it can be used through sysfs calibrate interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa_gen5.c | 65 1 file changed, 65 insertions(+) diff --gi

[PATCH v10 11/18] input: cyapa: add gen5 trackpad device firmware update function support

2014-11-13 Thread Dudley Du
Add firmware image update function supported for gen5 trackpad device, it can be used through sysfs update_fw interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/Kconfig | 2 +- drivers/input/mouse/cyapa_gen5.c | 290 ++

[PATCH v10 07/18] input: cyapa: add sysfs interfaces supported in the cyapa driver

2014-11-13 Thread Dudley Du
Add device's basic control and features supported in cyapa driver through sysfs file system interfaces. These interfaces are commonly used in pre- and after production, for trackpad device state checking, managing and firmware image updating. These interfaces including mode, firmware_version and pr

[PATCH v10 08/18] input: cyapa: add gen3 trackpad device firmware update function support

2014-11-13 Thread Dudley Du
Add firmware image update function supported for gen3 trackpad device, it can be used through sysfs update_fw interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa_gen3.c | 284 +++ 1 file changed, 284 insertions(+) diff

[PATCH v10 06/18] input: cyapa: add runtime power management interfaces supported for the device

2014-11-13 Thread Dudley Du
Add runtime_suspend_scanrate_ms power management interfaces in device's power group, so users or applications can control the runtime power management strategy of trackpad device as their requirements. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa.c | 167 +

[PATCH v10 10/18] input: cyapa: add gen3 trackpad device force re-calibrate function support

2014-11-13 Thread Dudley Du
Add force re-calibrate function supported for gen3 trackpad device, it can be used through sysfs calibrate interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa_gen3.c | 58 1 file changed, 58 insertions(+) diff --gi

[PATCH v10 09/18] input: cyapa: add gen3 trackpad device read baseline function support

2014-11-13 Thread Dudley Du
Add read baseline function supported for gen3 trackpad device, it can be used through sysfs baseline interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa_gen3.c | 71 1 file changed, 71 insertions(+) diff --git a/dr

[PATCH v10 04/18] input: cyapa: add gen5 trackpad device basic functions support

2014-11-13 Thread Dudley Du
Based on the cyapa core, add the gen5 trackpad device's basic functions supported, so gen5 trackpad device can work with kernel input system. And also based on the state parse interface, the cyapa driver can automatically determine the attached is gen3 or gen5 protocol trackpad device, then set the

[PATCH v10 03/18] input: cyapa: re-design driver to support multi-trackpad in one driver

2014-11-13 Thread Dudley Du
In order to support multiple different chipsets and communication protocols trackpad devices in one cyapa driver, the new cyapa driver is re-designed with one cyapa driver core and multiple device specific functions component. The cyapa driver core is contained in this patch, it supplies basic func

[PATCH v10 05/18] input: cyapa: add power management interfaces supported for the device

2014-11-13 Thread Dudley Du
Add suspend_scanrate_ms power management interfaces in device's power group, so users or applications can control the power management strategy of trackpad device as their requirements. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa.c | 105 +

[PATCH v10 02/18] input: cyapa: add device resource management infrastructure support

2014-11-13 Thread Dudley Du
Remove cyapa_remove() method, add cyapa_open() and cyapa_close() methods for input interface, also modified together with driver's memory and IRQ resource allocations to support device resource management infrastructure to reduce the mistakes of resource management. TEST=test on Chromebooks. Signe

[PATCH] driver: input :touchscreen : add Raydium I2C touch driver

2014-11-13 Thread jeffrey.lin
From: "jeffrey.lin" this patch is porting Raydium I2C touch driver. Developer can enable Raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM31100" in config/base.config Change-Id: Idae54cc4bca17f321a1d0895a8b59680bf9af859 Signed-off-by: jeffrey@rad-ic.com chromeos: config: ad