> What would be the best way to solve this, is it ok to simply re add that line?
Not quite, but put an "else" in front and it is ok. A patch to that effect is
already on its way to Linus, so you will soon be able to cherry-pick it.
Thanks,
Henrik
--
To unsubscribe from this list: send the line "
>>> So I am not very happy with having a new
>>> tool. In the end, it may also disturb older clients which will not know
>>> what to do with HOVER.
>>> And the ABS_MT_DISTANCE approach used to be fully retro-compatible
>>> (assuming that the hovering distance is small enough for the user not to
>>>
>>> FWIW, hid-multitouch already support those devices.
>>> ABS_MT_DISTANCE is set with a min/max of 0/1 when we detect win8
>>> certified panels with hovering capability. By default the spec does not
>>> provide the distance IIRC, and you only have one byte: InRange.
>>
>> Hmm, I missed that and t
Hi Dmitry,
> OK, so should we then say that we will continue reporting binary hovering
> with ABS_MT_DISTANCE 0/1 and such devices must report resolution of 0;
> devices reporting wider ABS_MT_DISTANCE ranges should also report
> appropriate resolution, same as X/Y coordinates?
Yes, I think this
My ISP finally gave up on the old mail address, so I am moving things
over to bitmath.org instead. Also change the status fields to better
reflect reality.
Signed-off-by: Henrik Rydberg
---
MAINTAINERS | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS
Hi Benjamin,
> Henrik, I just used the get_maintainer to add you on CC to an input-mt
> patch series, and it ended up using the @euromail.se instead of your
> still valid one. I can resend to you the patch series if you want.
Thanks, that won't be necessary.
I looked through the the patchset, an
Hi Peter,
> it wasn't the first reaction. it was the third, after we hacked up
> synaptics [1], then libinput [2], both rather unsatisfactory. Not sure what
> chromeos does but they'll probably would need similar code. And any other
> users of the evdev API of course.
So if this approach did not
Hi Benjamin,
> - there is a fragmentation problem: we would have to fix the bug in
> xorg-synaptics (which is slowly waiting for its death), libinput,
> ChromeOS, Qt Embedded, Kivy (I think), etc...
Indeed, this is the problem I wanted to highlight. As the fragmentation problem
grows (graphics, i
Hi Peter,
> from the testing I've done, you cannot trigger this except by lifting a
> finger and raising a finger. There is no per-use-case requirement, it's a
> hardware deficiency that the hardware simply cannot detect this specific
> case of finger change.
This is a good selling point, but...
problem formulation for dmax > 0 cannot benefit from the
speedup for positive definite matrices, but since the convergence is
faster, the result is about the same. For a handful of contacts, the
latency difference is truly negligible.
Suggested-by: Benjamin Tissoires
Not-yet-signed-off-by: Hen
Hi Dmitry,
On 01/22/2015 09:02 PM, Dmitry Torokhov wrote:
> On Thu, Jan 22, 2015 at 08:52:25PM +0100, Henrik Rydberg wrote:
>> int input_mt_assign_slots(struct input_dev *dev, int *slots,
>> - const struct input_mt_pos *pos, int num_pos)
>> +
Hi Clinton,
> Use smoothed version of sensor array data to calculate movement and add weight
to prior values when calculating average. This gives more granular and more
predictable movement.
>
> Signed-off-by: Clinton Sprain
> ---
> drivers/input/mouse/appletouch.c | 60
> +++
;min(ATP_PRESSURE, x_z + y_z));
> - atp_report_fingers(dev->input, max(x_f, y_f));
> + atp_report_fingers(dev->input, fingers);
> }
> dev->x_old = x;
> dev-&g
Hi Clinton,
On 02/07/2014 01:40 AM, Clinton Sprain wrote:
> Dials back the default fuzz and threshold settings for most devices using
> this driver, based on user input from forums and bug reports, increasing
> sensitivity. These two settings can also now both be overridden as module
> paramete
Hi Roger,
the MT implementation seems mostly fine, just one curiosity:
> static irqreturn_t pixcir_ts_isr(int irq, void *dev_id)
> {
> struct pixcir_i2c_ts_data *tsdata = dev_id;
> const struct pixcir_ts_platform_data *pdata = tsdata->chip;
> + struct pixcir_report_data report;
Hi Clinton,
> Use smoothed version of sensor array data to calculate movement and add weight
> to prior values when calculating average. This gives more granular and more
> predictable movement.
Great patch, just one thing:
> + /* Handle other edge. */
> + smooth_tmp[nb_s
x = (dev->x_old * 3 + x) >> 2;
> - y = (dev->y_old * 3 + y) >> 2;
> + x = (dev->x_old * 7 + x) >> 3;
> + y = (dev->y_old * 7 + y) >> 3;
> dev->x_old = x;
>
> input: appletouch: fixes for jagged/uneven cursor movement
>
> The appletouch driver can make some touchpads feel insensitive, with movement
> that tends to jerk in steps. This is particularly evident when moving
> diagonally. There is also undesirable movement when additional fingers enter
>
ed for a better model of interrupted contacts in the core.
> + }
> break;
> + }
>
> msleep(20);
> }
> @@ -333,6 +389,13 @@ static int pixcir_i2c_ts_probe(struct i2c_client *client,
> input_set_abs
Ferruh,
> I understand this works for Dmitry ABS_X, ABS_Y,
> touchscreen reports between 0..A, screen resolution is 0..B, a mapping
> can be done 0..A -> 0..B
>
> But for ABS_MT_TOUCH_MAJOR how this scaling can be done,
> touchscreen reports between 0..A, do we know the min/max values for
> appli
ndrew de los Reyes
> Reviewed-by: Benson Leung
> Signed-off-by: Dmitry Torokhov
> ---
> drivers/input/input.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Oh my, that was a bad one.
Reviewed-by: Henrik Rydberg
Thanks,
Henrik
--
To unsubscribe from this list:
Hi Dmitry,
On 07/26/2014 02:27 AM, Dmitry Torokhov wrote:
> Semi-MT devices are pointers too, so let's tell that to
> input_mt_init_slots(), as well as let it set up the devices as semi-MT,
> instead of us doing it manually.
>
> Reviewed-by: Daniel Kurtz
> Reviewed-by: Benson Leung
> Signed-off
On Mon, Feb 25, 2013 at 01:29:40PM +0100, Jiri Kosina wrote:
> On Mon, 25 Feb 2013, Benjamin Tissoires wrote:
>
> > Hi guys,
> >
> > this is the v2 of the hid transport cleanup.
> >
> > Changes since v1:
> > - gathered reviewed/acked/etc..
> > - changed commit messages of patches 4-6
> > - add n
Hi Benson,
> From: Daniel Kurtz
>
> This same driver can be used by atmel based touchscreens and touchpads
> (buttonpads). Platform data may specify a device is a touchpad
> using the is_tp flag.
>
> This will cause the driver to perform some touchpad specific
> initializations, such as:
> *
Hi David,
> Occasionally the trackpad in my MacBookPro 8,3 stops working, spewing
> 'bcm5974: bad trackpad package, length: 8'
We have seen this on a few exemplars over the years. It could be a
hardware problem.
> I haven't been able to reproduce this on demand, but it's annoying when
> it does
Hi Benson,
> cyapa_check_is_operational and cyapa_create_input_dev are common to
> the probe and firmware update paths. Pull those out into
> cyapa_detect.
>
> Signed-off-by: Benson Leung
> ---
> drivers/input/mouse/cyapa.c | 57
> +++--
> 1 file changed
Hi Benson,
> From: Daniel Kurtz
>
> Use the kernel request_firmware API to allow a hotplug script to load new
> firmware into CYAPA device. When request_firmware is called by a driver,
> the kernel creates 'loading' and 'data' sysfs entries, and generates a
> firmware udev event containing the
Hi Benjamin,
> There is no need to register an input device containing no events.
> This allows drivers using the quirk MULTI_INPUT to register one input
> per report effectively used.
>
> For backward compatibility, we need to add a quirk to request
> this behavior.
>
> Signed-off-by: Benjamin
Hi Benjamin,
> Dual sensors devices reports pen and touch on two different reports.
> Using the quirk HID_QUIRK_MULTI_INPUT allows us to create a new input
> device to forward pen events.
>
> The quirk HID_QUIRK_NO_EMPTY_INPUT avoids the creation of input devices
> for the not used mouse emulatio
Hi Benjamin,
> This is not just cosmetics, it can help to write udev and X.org
> rules.
>
> Signed-off-by: Benjamin Tissoires
> ---
> drivers/hid/hid-multitouch.c | 24 +++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-multitouch.c b/dr
Hi Jiri, Benjamin,
> > So the solution consists in relying inconditionaly to the quirk MULTI_INPUT
> > for
> > hid-multitouch. Before registering the input device in hid-input, we can
> > test if
> > it has been populated, and if not, then we simply don't register it. In
> > order to
> > preven
Hi Benson,
> On Sat, Mar 16, 2013 at 1:00 PM, Henrik Rydberg wrote:
> >> Userspace can initiate the firmware update procedure by copying cyapa.bin
> >> to /lib/firmware, and then writing anything to the device sysfs attribute:
> >> /sys/bus/i2c/devices/7-0067/upd
Hi David,
> On Sat, 2013-03-16 at 20:31 +0100, Henrik Rydberg wrote:
> > What do you mean by "fix for this on suspend/resume"? The driver
> > always returns to normal mode at suspend, and sets wellspring mode at
> > resume.
>
> Yes, that's exactly w
Hi Ivan,
> Tested on Dell 7720. Works fine.
>
> Signed-off-by: Valyushkov Ivan
> ---
> drivers/input/mouse/alps.c | 464
> +---
> drivers/input/mouse/alps.h |2 +
> 2 files changed, 443 insertions(+), 23 deletions(-)
This patch does not seem to app
Hi Nick,
> The following patches are a large series of updates in functionality to the
> atmel_mxt_ts touch driver. They apply cleanly to input/next.
I guess this is no longer true.
> These changes address some of the same issues that appear in the patchsets
> submitted by Daniel Kurtz and Peter
Most semi-mt drivers use the slots in a manual way, but really only
need to treat the finger count manually. With this patch, a semi-mt
driver may use the input-mt core for everything else.
Signed-off-by: Henrik Rydberg
---
Hi Dmitry,
an earlier version of this patch came about as a test to
On Wed, Jun 12, 2013 at 10:51:56AM +0200, Benjamin Tissoires wrote:
> On Fri, May 31, 2013 at 8:29 AM, Peter Hutterer
> wrote:
> > This is effectively already in force through input_mt_init_slots, and uinput
> > too ignores the actual minimum.
> >
> > Since slots are a kernel-genenerated axis only
Hi Benjamin,
this looks pretty good to me, just a few nitpicks below.
> hid_scan_report() implements its own HID report descriptor parsing. It is
> going to be really bad with the detection of Win 8 certified touchscreen,
> as this detection relies on a special feature and on the report_size and
Hi Benjamin,
> Detecting Win 8 multitouch devices in core allows us to set quirks
> before the device is parsed through hid_hw_start().
> It also simplifies the detection of those devices in hid-multitouch and
> makes the handling of those devices cleaner.
>
> As Win 8 multitouch panels are in th
ll not impact this. Maybe just wait for Henrik to put his "Reviewed-by"
> before
> giving one last test.
Here goes:
Reviewed-by: Henrik Rydberg
Cheers,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@
On Sat, Aug 24, 2013 at 04:26:30PM -0700, Dmitry Torokhov wrote:
> Hi Ian,
>
> On Sun, Aug 25, 2013 at 12:17:52AM +1000, Ian Munsie wrote:
> > This patch adds a device ID found for mid-2013 Macbook Air 6,1 from
> > lsusb:
> >
> > Bus 001 Device 003: ID 05ac:0290 Apple, Inc.
> >
> > Since IDs alr
Hi Ian,
> This patch adds a device ID found for mid-2013 Macbook Air 6,1 from
> lsusb:
>
> Bus 001 Device 003: ID 05ac:0290 Apple, Inc.
>
> Since IDs already exist for this generation Macbook air as WELLSPRING8,
> name this one WELLSPRING8A. This only adds an ANSI version since it's
> device ID
Hi Heiko,
> This adds a driver for touchscreens using the zforce infrared
> technology from Neonode connected via i2c to the host system.
>
> It supports multitouch with up to two fingers and tracking of the
> contacts in hardware.
>
> Signed-off-by: Heiko Stuebner
Thanks for the driver. Pleas
On Mon, Aug 26, 2013 at 02:51:32PM +0200, Linus G Thiel wrote:
> I'm on an ISO layout, this is what makes sense to me and it also works fine
> on my laptop (6,2 with Swedish layout).
>
>
> On Mon, Aug 26, 2013 at 3:50 AM, Ian Munsie wrote:
>
> > > Brad, Linus, does the above patch work for you
: Dmitry Torokhov
Reported-and-tested-by: Ian Munsie
Tested-by: Linus G Thiel
Signed-off-by: Henrik Rydberg
---
Hi Jiri, Dmitry,
it looks like this change has been sufficiently tested now, in
addition to making perfect sense. Jiri, would you mind taking it, if
Dmitry approves?
The patch should
re Foundation; either version 2 of
> + the License, or (at your option) any later version.
> +
> + Copyright (c) 2013 by Florian 'floe' Echtler
> +
> + Derived from the USB Skeleton driver 1.1,
> + Copyright (c) 2003 Greg Kroah-Hartman (g...@kroah.com)
e mode 100644 drivers/input/touchscreen/sur40.c
The driver looks pretty good now, thanks for making the changes. There
might be one or two white space problems, but those can be fixed while
applying. Dmitry, I guess you want to take this through your tree, so
Reviewed-by: Henrik Rydberg
Thanks,
>> Also, does the patch below mess up or device or it still works?
> I'll test this tomorrow (no access to SUR40 today). If everything works,
> should I resubmit my patch with yours included or just tell you that
> it's fine?
No need to resubmit, a confirmation will do nicely. Thanks!
Henrik
--
Hi Florian,
> Looks like the sur40 driver didn't make it into the 3.13 pull request,
> anything still missing/broken? I was hoping this might still make it into
> Ubuntu 14.04...
Nothing is broken, don't worry. If you want to make sure to hit a
certain merge window, then everything should be set
Hi Friedrich,
> On wellspring3 devices ABS_MT_TOUCH_MINOR was sometimes reported bigger than
> ABS_MT_TOUCH_MAJOR. This is fixed by rescaling ABS_MT_TOUCH_MINOR by a factor
> of
> 0.85 instead of 2. Excessive tapping on the trackpad shows this to be the
> right
> value. Circular touches should n
Hi Friedrich,
> Previously ABS_PRESSURE and ABS_TOOL_WIDTH were calculated by looking at the
> size of the first touch in the list reported by the trackpad. This is not
> necessarily the same touch as the one used to perform pointer emulation in the
> input multitouch library (input-mt). By using
> On Wed, Nov 20, 2013 at 11:54:12PM +0100, Friedrich Schöller wrote:
>> Trackpads with integrated buttons are hard to use when the driver responds to
>> movements of the thumb that is resting or clicking on the surface of the
>> trackpad. This patch adds rudimentary support to filter out these tou
Hi Roger,
> It seems the controller the original driver was written for does not report
> touch ID and just reports 2 touch co-ordinates. I'm not sure how this fits
> into
> Type B reporting model.
Look in drivers/input/mouse/cypress_ps2.c for an example of how to deal with
anonymous touch coord
Hi Benjamin,
> The ANTEC Touch Pad is a device which can switch from a multitouch
> touchpad to a mouse. It thus presents several generic collections which
> are currently ignored by hid-multitouch. Enable them by using the generic
> protocol. Adding also a suffix for them depending on their appli
Hi Felipe,
> Adds a helper function to send end touch events for active tracking ids.
> And also implements it in egalax driver.
What problematic scenario is this supposed to solve?
The 'release on suspend' is only an approximation to the 'close laptop'
scenario,
it is certainly not correct in
Hi Dmitry,
>> What problematic scenario is this supposed to solve?
>>
>> The 'release on suspend' is only an approximation to the 'close
>> laptop' scenario, it is certainly not correct in the coffee table
>> case,
>
> Why would it not be correct for coffee table? Do we expect the touches
> to re
Hi Clinton,
> Dials back the default fuzz and threshold settings for
> most devices using this driver, based on values from
> user feedback from forums and bug reports. This
> increases smoothness and movement granularity. No
> changes were made for the older devices that use the
> driver, as I di
Hi Simon,
On Sun, Jul 08, 2012 at 06:05:22PM +0200, simon.bu...@kernelconcepts.de wrote:
> From: Simon Budig
>
> This is a driver for the EDT "Polytouch" family of touch controllers
> based on the FocalTech FT5x06 line of chips.
>
> Signed-off-by: Simon Budig
> ---
(The area below the '---' c
Hi Ryan,
Please keep the patch message clear of things you do not want to end
up in the git log. Also, if you could manage to get an Originally-by:
or Tested-by from the right person, that would be splendid.
Jiri, unless you already have this patch from elsewhere, it would be
great to see it in 3
nded mouse ignore lines]
Signed-off-by: Ryan Bourgeois
Signed-off-by: Henrik Rydberg
---
Hi Jiri, Ryan
Here is the retina patch, cleaned up and with the mouse ignore stuff
amended. The accompanying bcm5974 patch follows this one.
Simple enough for 3.5, me thinks, but 3.6 should be alright as wel
Add support for the 15'' MacBook Pro Retina model (MacBookPro10,1).
Patch originally written by clipcarl (forums.opensuse.org).
Signed-off-by: Henrik Rydberg
---
Hi Dmitry,
Here is a patch for the new retina I picked up from the anonymous
heroes on the linux forums. Looks simple enou
On Tue, Jul 10, 2012 at 11:48:00AM +0200, Jiri Kosina wrote:
> On Mon, 9 Jul 2012, Henrik Rydberg wrote:
>
> > Please keep the patch message clear of things you do not want to end
> > up in the git log. Also, if you could manage to get an Originally-by:
> > or Tested-
Hi Benson,
> This patch introduces a driver for Cypress All Points Addressable
> I2C Trackpad, including the one in the Samsung Series 5 550 Chromebook.
>
> This device is compatible with MT protocol type B, providing identifiable
> contacts.
>
> This driver also implements firmware updating cap
Hi David,
Perhaps one should make hid-core warn instead of bailing out instead?
Something may need to be done to make sure everything works smoothly,
but really, why would hid-core mind keeping a device on the bus with a
non-standard io driver?
Thanks,
Henrik
--
To unsubscribe from this list: sen
On Mon, Jul 16, 2012 at 09:08:47PM +0200, David Herrmann wrote:
> Hi Henrik
>
> On Mon, Jul 16, 2012 at 8:45 PM, Henrik Rydberg wrote:
> > Hi David,
> >
> > Perhaps one should make hid-core warn instead of bailing out instead?
> > Something may need to be d
> I am sorry, I misunderstood you. Yes, in fact, this is what wiimote
> currently does. Well, it uses HID_CONNECT_HIDRAW but this has no
> effect if CONFIG_HIDRAW is not set so this is equivalent to 0. My
> first attempt was to make this work, however, this means refactoring
> hid_connect() a lot a
> Yes, that works fine. I just want some nice comment there so people
> know we are using some heuristics. If you don't mind, I will wrap this
> up tomorrow and send a new version of the patch(set). Otherwise, feel
> free to send it yourself.
I don't mind at all, tomorrow it is.
Cheers,
Henrik
--
Hi David,
> hid-picolcd and hid-wiimote do not allow any of hidinput, hiddev or hidraw
> to claim the device but still want to remain on the bus. Hence, if a
> driver uses the raw_event callback but no listener claimed the device, we
> still leave it on the bus as the driver probably handles every
>Thanks for your great comments. You are right, it is impossible to get
> correct finger tracking if both fingers are moving. However, we think it
> still worth to have the firmware tracking of the fingers as they could
> perform well for most one-stationary-one-moving cases. This will be good
Hi Dmitry,
> OK, so the patch below should fix most of Henrik's comments and some of
> mine. Compile-tested only though. It would be nice to have it verified
> on real hardware so we could get it in in the next merge window.
Looking good, just a question for Simon: In the mt report function,
the
> I understand the usefulness of this functionality, but I also worry
> about proliferating the number of properties for devices (there are
> only 32 bits we can use, IIRC). I see four options off the top of my
> head:
>
> * Don't do anything, leave it as SEMI_MT. Obviously this would suck,
> but
On Fri, Jul 20, 2012 at 11:14:25AM +0800, Chung-Yih Wang (王崇懿) wrote:
> From our experiments, the assumption of "the slowest corner is the
> stationary finger" is not always true. That is the major reason we want to
> report the firmware data instead of semi-mt.
Oh, but that was precisely the poin
> > The HID subsystem was made a proper bus in 2008, but the config
> > options do not reflect this. Modify the HID and USB_HID entries
> > to better explain what they do.
> >
> > Signed-off-by: Henrik Rydberg
> > ---
> > Hi Jiri,
> >
> &
nger
> required.
>
> Signed-off-by: David Herrmann
> ---
> Sorry for the delay. I had two exams this week that got into my way. Anyway, I
> hope this time the patch looks ok.
>
> Thanks to Henrik for reviewing it the previous times.
Thanks, David, looking good now.
> > Propagating information about various sensor defects to userspace
> > sounds horrid to me. The sooner we can forget about these devices, the
> > better.
>
> Not providing the userspace driver with enough information to give
> users the best experience possible sounds horrid to me.
The questio
gt; Are you OK with the driver in the current form? I think it is in good
> shape and should be applied; any additional improvements could go on top
> a separate patches.
It looks all good to me,
Reviewed-by: Henrik Rydberg
Thanks, Simon, for all your work.
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan,
> This is a semi-automatic email about new static checker warnings.
>
> The patch 4fa3a5837b84: "HID: hid-multitouch: Switch to device
> groups" from May 1, 2012, leads to the following Smatch complaint:
>
> drivers/hid/hid-multitouch.c:735 mt_probe()
>error: we previously assum
On Wed, Aug 08, 2012 at 09:07:58PM +0300, Dan Carpenter wrote:
> On Wed, Aug 08, 2012 at 07:28:29PM +0200, Henrik Rydberg wrote:
> > Hi Dan,
> >
> > > This is a semi-automatic email about new static checker warnings.
> > >
> > > The patch 4fa3a5837b
convert bcm5974 to MT-B.
Patch 16 is janitory.
Patch 17 provides a substantial latency improvement on simple key
strokes.
Patches 18-19 are for hid-multitouch, reducing memory and simplifying
the driver.
Thanks,
Henrik
Henrik Rydberg (19):
Input: Break out MT data
Input: Improve the events-per
Move all MT-related things to a separate place. This saves some
bytes for non-mt input devices, and prepares for new MT features.
Signed-off-by: Henrik Rydberg
---
drivers/input/evdev.c| 10 ++
drivers/input/input-mt.c | 47 +++
drivers
Many MT devices send a number of keys along with the mt information.
This patch makes sure that there is room for them in the packet
buffer.
Signed-off-by: Henrik Rydberg
---
drivers/input/input.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/input
Use of the in-kernel tracking code to convert the driver to MT-B.
With ten fingers on the pad, the in-kernel tracking adds approximately
25 us to the maximum irqsoff latency. Under normal workloads, however,
the tracking has no measurable effect.
Signed-off-by: Henrik Rydberg
---
drivers/input
Preparing to move more repeated code into the mt core, and a flags
argument to the input_mt_slots_init() function.
Signed-off-by: Henrik Rydberg
---
drivers/hid/hid-magicmouse.c | 2 +-
drivers/hid/hid-multitouch.c | 2 +-
drivers/input/input-mt.c | 4
Rename touch properties to match established nomenclature, and define
the maximum number of fingers.
Signed-off-by: Henrik Rydberg
---
drivers/input/mouse/bcm5974.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/input/mouse/bcm5974.c b
The ABS_PRESSURE and ABS_WIDTH have special scales, and were initially
added solely for thumb and palm recognition in the synaptics driver.
This never really get used, however, and userspace quickly moved to
MT solutions instead. This patch drops the unused events.
Signed-off-by: Henrik Rydberg
ce data by removing the logical
scale altogether. While at it, the fake pressure range is replaced by the
orientation range, which will be used in a subsequent patch.
Signed-off-by: Henrik Rydberg
---
drivers/input/mouse/bcm5974.c | 193 --
1 file changed, 75
Going through the motions of printing the debug message information
takes a long time; using the keyboard can lead to a 160 us irqsoff
latency. This patch skips hid_dump_input() when there are no open
handles, which brings latency down to 100 us.
Signed-off-by: Henrik Rydberg
---
drivers/hid
A null test was left behind during the autoloading work;
the test was introduced by 8d179a9e, but was never completely
reverted.
Reported-by: Dan Carpenter
Signed-off-by: Henrik Rydberg
---
drivers/hid/hid-multitouch.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff
A hid device may create several input devices, and a driver may need
to prepare or finalize the configuration per input device. Currently,
there is no sane way for a driver to know when a device has been
configured. This patch adds a callback providing that information.
Signed-off-by: Henrik
Some drivers produce their own tracking ids, which needs to be mapped
to slots. This patch provides that function.
Signed-off-by: Henrik Rydberg
---
drivers/input/input-mt.c | 30 ++
include/linux/input/mt.h | 2 ++
2 files changed, 32 insertions(+)
diff --git a
Collect common frame synchronization tasks in a new function,
input_mt_sync_frame(). Depending on the flags set, it drops
unseen contacts and performs pointer emulation.
Signed-off-by: Henrik Rydberg
---
drivers/input/input-mt.c | 74 ++--
include
commonly occuring cases.
Signed-off-by: Henrik Rydberg
---
drivers/input/input-mt.c | 144 ++-
include/linux/input/mt.h | 21 +++
2 files changed, 163 insertions(+), 2 deletions(-)
diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c
By sending a full frame of events at the same time, the irqsoff
latency at heavy load is brought down from 200 us to 100 us.
Signed-off-by: Henrik Rydberg
---
drivers/input/evdev.c | 68 +++
1 file changed, 47 insertions(+), 21 deletions(-)
diff
Packet estimates are now better handled in the input core. Remove the
redundant estimates from those drivers.
Signed-off-by: Henrik Rydberg
---
drivers/hid/hid-input.c | 4
drivers/hid/hid-magicmouse.c | 2 --
drivers/input/input-mt.c | 1 -
drivers/input/mouse/bcm5974.c | 2
For some EV_KEY types, sending a larger-than-one value causes the
input state to oscillate. This patch makes sure this cannot happen,
clearing up the autorepeat bypass logic in the process.
Signed-off-by: Henrik Rydberg
---
drivers/input/input.c | 20 +---
1 file changed, 13
Preparing to split event filtering and event passing, move the
autorepeat function to the point where the event is actually passed.
Signed-off-by: Henrik Rydberg
---
drivers/input/input.c | 46 +-
1 file changed, 25 insertions(+), 21 deletions
patch adds the events() handler callback and uses it if it
exists. The latency is improved by 50 us even without the callback.
Signed-off-by: Henrik Rydberg
---
drivers/input/input-mt.c | 3 +-
drivers/input/input.c| 187 ---
include/linux
HID report has been seen.
Cc: Benjamin Tissoires
Signed-off-by: Henrik Rydberg
---
drivers/hid/hid-multitouch.c | 162 ++-
1 file changed, 66 insertions(+), 96 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index
Hi Russell,
> On Tue, Aug 14, 2012 at 12:54:00PM +0200, Jiri Kosina wrote:
> > Actually, Henrik (added to CC) has been doing some latency improvements
> > both for input core in general, and for HID devices as well lately. I
> > still have his patchset in my to-review queue, as I have just came
Hi Ping,
Long time no see. :-)
> > + /* Make room for KEY and MSC events */
> > + events += 7;
>
> It is nice to get rid of the redundant pieces and to incorporate
> common functions. Thank you.
>
> I have a question about the code above though. Why do we use 7
> instead of going t
1 - 100 of 315 matches
Mail list logo
