Hello,
in my Thinkpad T61 there is another Hitachi harddisk with NCQ problems
(spurious completions during NCQ...).
Model number: HITACHI HTS541612J9SA00
Serial number: SBDIC7JP
Adding the line
{ "HITACHI HTS541612J9SA00", "SBDIC7JP", ATA_HORKAGE_NONCQ, },
to the ata_device_blacklist in
J. Bruce Fields wrote:
> On Wed, Sep 19, 2007 at 06:26:05PM +0400, Pavel Emelyanov wrote:
>> This code is run under lock_kernel(), which is dropped during
>> sleeping operations, so the following race is possible:
>>
>> CPU1:CPU2:
>> vfs_setlease();
When a sysfs_node or one of its ancestors is renamed, automatically
rename symlinks pointing to it according to the name format together.
Note that as links created with kobject based sysfs_create_link()
aren't chained on its target, they aren't renamed automatically. This
is for backward
Batch error handling is to be used with plugged creation. It
accumulates any error condition which happens under a plugged node and
let the user handle error once right before unplugging. This easily
replaces attribute group creation.
Batch error handling works by the following two mechanisms.
Sysfs has gone through considerable amount of reimplementation. Add
copyrights. Any objections? :-)
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/bin.c|8 +++-
fs/sysfs/dir.c| 10 +-
fs/sysfs/file.c | 10 +-
Add sd->s_dir.links and sd->s_link.next and chain symlinks to their
targets. This will be used to implement auto-removal and auto-rename
of symlinks.
Symlinks created with kobject-based sysfs_create_symlink() won't be
chained to keep backward compatibility.
Signed-off-by: Tejun Heo <[EMAIL
This patch implements plugged creation of sysfs nodes. If
SYSFS_PLUGGED is specified to any of sysfs_add_*() functions, the
node, its children which get added under it and symlinks pointing to
it or its children won't be visible from userland - lookup and
directory listing won't show them, until
This patch implements sysfs name formatting. sysfs_add_link() is
passed @name_fmt instead of @fmt. In the format string only
"%[:alnum:]" and "%%" are handled specially. "%0" is substitued with
the name of @target, "%3" with the name of the third ancestor of
@target, "%[aA]" the 10th and
Notify file on deactivation so that the pollers get event when the
polled file dies, which is very easy to implement with sd based
interface.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/sysfs/dir.c
When a sysfs_node is removed, automatically remove all symlinks
pointing to it together.
Note that as links created with kobject based sysfs_create_link()
aren't chained on its target, they aren't removed automatically. This
is for backward compatibility.
Signed-off-by: Tejun Heo <[EMAIL
Hello, all.
This is the fourth patchset of four sysfs update patchset series[1]
and to be applied on top of the third patchset[2].
This patchset implements the following new features.
* Notify pollers on file deactivation.
* Name-formatting for symlinks. e.g. symlink pointing to
Satyam Sharma wrote:
>> [ cut here ]
>> Badness at arch/powerpc/kernel/smp.c:202
>>
>
> comes when smp_call_function_map() has been called with irqs disabled,
> which is illegal. However, there is a special case, the panic() codepath,
> when we do not want to warn
J. Bruce Fields wrote:
> On Wed, Sep 19, 2007 at 03:35:27PM +0400, Pavel Emelyanov wrote:
>> Currently /proc/locks is shown with a proc_read function, but
>> its behavior is rather complex as it has to manually handle
>> current offset and buffer length. On the other hand, files
>> that show
On Thu, Sep 20, 2007 at 09:25:38AM +0200, Philipp Marek wrote:
>
> >> > It doesn't handle O= directories...
> >> Sorry, I don't understand you. What are "0=" directories?
> >
> > When building a kernel you can specify an other output directory
> > so you do not mix up your source tree with
On Thu, Sep 20, 2007 at 09:28:21AM +0200, Jarek Poplawski wrote:
> On Thu, Sep 20, 2007 at 08:24:58AM +0200, Nadia Derbey wrote:
...
> > Before Calling msg_unlock() they call ipc_rcu_getref() that increments a
> > refcount in the rcu header for the msg structure. This guarantees that
> > the the
Andrew Morgan <[EMAIL PROTECTED]> wrote:
> OOC If we were to simply drop support for one process changing the
> capabilities of another, would we need this patch?
Well, the patch could be less, but there's still the possibility of a kernel
service wanting to override the capabilities mask.
On Thu, 2007-09-20 at 10:15 +0200, Pavel Machek wrote:
> > This patch adds writing support for /dev/oldmem. This is used to
> > restore the memory contents of hibernated system.
> >
> > Signed-off-by: Huang Ying <[EMAIL PROTECTED]>
>
> ACK. (And this can even go in before the patch #1, right?)
> This patch adds writing support for /dev/oldmem. This is used to
> restore the memory contents of hibernated system.
>
> Signed-off-by: Huang Ying <[EMAIL PROTECTED]>
ACK. (And this can even go in before the patch #1, right?)
> NAK. "keepinitrd" is what people expect on ARM.
>
> I'm frustrated that whoever invented "retain_initrd" didn't look
> around in the documentation to see if there was any existing
> implementation first. The generic implementation should be fixed
> IMHO, or at least the option string moved
sysfs_add_bin() creates a binary sysfs file which is equivalent to
binary attribute file of the original API. As with file, bin ops take
private data of both itself and parent to support kobject based API
and kobject based interface works by setting parent_data to kobj and
data to battr.
Other
On Thu, 2007-09-20 at 09:51 +0200, Ingo Molnar wrote:
> * Mike Galbraith <[EMAIL PROTECTED]> wrote:
>
> > [...] I modified the kernel to print task's actual tree key instead
> > of their current vruntime, [...]
>
> btw., that looks like a debug printout bug in sched-devel.git - could
> you
sysfs_add_file() creates a text sysfs file which is equivalent to
attribute file of the original API. Each sysfs file has its own ops
containing show and store, and can have arbitrary private data. Both
show and store methods are given two private data arguments - one for
its own, the other for
Rename sysfs_rename_mutex to sysfs_op_mutex and protect operations
which modify tree with it. ie.
sysfs_op_mutex : above i_mutexes in the lock hierarchy and
guarantees exclusion against all tree
modifications.
sysfs_mutex: under i_mutexes in the
sysfs_assoc_lock which protects kobj <-> sd association is now only
used in fs/sysfs/kobject.c. Move it there and make it static.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c |1 -
fs/sysfs/kobject.c |2 ++
fs/sysfs/sysfs.h |1 -
3 files changed, 2
Kill now unused sysfs_hash_and_remove().
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/inode.c | 22 --
fs/sysfs/sysfs.h |1 -
2 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
index 8df357e..0aeea4b 100644
Kill now unused __sysfs_add_file().
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/file.c | 23 ---
fs/sysfs/sysfs.h |2 --
2 files changed, 0 insertions(+), 25 deletions(-)
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 4c0e29f..1d93940 100644
---
sysfs_rename() takes target @sd, @new_parent and @new_name and rename
@sd to @new_name and move it under @new_parent. @new_parent and/or
@new_name can be NULL if the specific operation is not needed.
To handle both move and rename && prepare for multiple renames in one
shot for easier symlink
Reimplement group interface in terms of sd-based interface in
fs/sysfs/kobject.c.
This patch doesn't introduce any behavior change to the original API.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/Makefile |3 +-
fs/sysfs/group.c | 87
sysfs_add_link() takes parent sd, name, mode and the target sd and
creates a link accordingly. Currently, sysfs links can only point to
directories but this limitiation is artificial to avoid inflating the
sysfs_dirent structure by one pointer with future changes and can be
easily removed.
Implement __kobject_set_name() which takes pre-allocated @new_name and
renames the kobject without failing.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include/linux/kobject.h |1 +
lib/kobject.c | 13 +
2 files changed, 14 insertions(+), 0 deletions(-)
diff
Implement sysfs_find_child() which finds a child of a sysfs_dirent by
name. This function does not grab reference of the found child. The
caller is supposed to have reference if the child exists. This
function is useful for callers which own the sysfs_dirent to be looked
up but don't wanna keep
The function name sysfs_add_file() will be used for sd-based file
interface. Rename the internal function to __sysfs_add_file(). Note
that the internal function will be removed once the new interface is
in place, so double underscore prefix should do it for the time being.
Signed-off-by: Tejun
Currently, sysfs symlinks are either called symlinks or links. Rename
everything to link and drop attr and _sd postfix as new interface
won't be bound to kobj.
This patch doesn't introduce any logic change.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c |6 +++---
Currently, binary sysfs files are called (kobj) bin attrs. sd-based
interface won't be bound to bin_attribute. Use 'bin' as name and drop
all kobj and attr from symbol names.
This patch doesn't introduce any logic change.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/bin.c |
Currently, regular sysfs files are called (kobj) attrs or files. This
is a bit confusing and sd-based interface won't be bound to attribute.
Use 'file' consistently and drop all kobj and attr from symbol names.
This patch doesn't introduce any logic change.
Signed-off-by: Tejun Heo <[EMAIL
This patch implements new sysfs_remove(), which takes @sd as target
argument and can be used on any type of node. Also, it recurses into
sub directories.
* sysfs_remove_file(), sysfs_remove_file_from_group(),
sysfs_remove_bin_file() are reimplemented using sysfs_remove() in
Restruct addrm helpers such that it can remove nodes under different
parents at one go.
sysfs_addrm_start() now doesn't take @sd. It now only initializes
@acxt and lock sysfs_mutex. Parent inode lookup now lives in
sysfs_addrm_get_parent_inode() and sysfs_add/remove_one() call them
directly.
Convert sd->s_dir.kobj to sd->s_dir.data and make it void *, and
implement sd based directory creation function sysfs_add_dir(). Using
this function the caller can create directory node with arbitrary user
data. Also, name copying is not implicit. Name is copied iff
SYSFS_COPY_NAME should be
In the upcoming new sysfs interface, sysfs_root will be exported. To
ease usage and make dummy declaration easier, make sysfs_root a
pointer.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c |4 ++--
fs/sysfs/mount.c |8 +---
fs/sysfs/symlink.c |2 +-
Sysfs is about to get a new interface which is independent from the
driver model and kobject. Create include sysfs-kobject.h and move all
kobject based interface into it. Also, create fs/sysfs/kobject.c
which is currently empty but will host compatibility interface
functions based on the new
Currently name is implicitly copied for directory and symlink nodes.
Make the behavior flexible by making it a flag. If SYSFS_COPY_NAME
bit is specified in @mode when calling sysfs_new_dirent(), the name is
copied.
SYSFS_COPY_NAME is defined as S_IFMT so that it can be specified with
@mode bits.
Currently sysfs_new_dirent() takes @mode and @type. @mode contains
S_IF* mask which is also duplicately indicated by @type. This patch
sysfs_new_dirent() determine S_IF* mask and normalize @mode such that
only bits from S_IALLUGO is taken as @mode.
This is to allow later use of unused @mode
Subject: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model
Hello, all.
This is the third patchset of four sysfs update patchset series[1] and
to be applied on top of the second patchset[2].
Currently, sysfs interface is based on kobj. This made more sense
before because
--- Eric Dumazet <[EMAIL PROTECTED]> wrote:
> Nagendra Tomar a écrit :
> > --- Davide Libenzi <[EMAIL PROTECTED]> wrote:
> >
> >> On Wed, 19 Sep 2007, David Miller wrote:
> >>
> >>> From: Nagendra Tomar <[EMAIL PROTECTED]>
> >>> Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT)
> >>>
> With the
On Wed, Sep 19, 2007 at 02:36:04PM -0700, Christoph Lameter wrote:
> catting
>
> alloc_calls
>
> and
> free_calls
>
> will perform a global scan over all objects to determine the callers.
> Before we do that we have to flush the per cpu slabs. The trace shows that
> one of the
On 9/20/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Wed, 19 Sep 2007 21:43:14 -0700 David Brownell <[EMAIL PROTECTED]> wrote:
>
> > On Wednesday 19 September 2007, Andrew Morton wrote:
> > > On Wed, 19 Sep 2007 16:44:48 -0700
> > > David Brownell <[EMAIL PROTECTED]> wrote:
> > >
> > > > > >
* Mike Galbraith <[EMAIL PROTECTED]> wrote:
> [...] I modified the kernel to print task's actual tree key instead
> of their current vruntime, [...]
btw., that looks like a debug printout bug in sched-devel.git - could
you send me your fix? I've pushed out the latest sched-devel (ontop of
# free -m
total used free shared buffers cached
Mem: 7988 1120 6868 0 88 612
Now i need to rerun memory tests.
Thank you for helping me with this stuff.
Uff. Now full memtest takes less than 2 hours.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
On Wed, 19 Sep 2007 20:02:05 +0200,
Cornelia Huck <[EMAIL PROTECTED]> wrote:
> > kobject drivers: cleaning up
> > kobject '' does not have a release() function, if this is not a
> > directory kobject, it is broken and must be fixed.
>
> printing this debug message, it looks a bit odd :)>
On Wed, 19 Sep 2007 20:02:05 +0200,
Cornelia Huck <[EMAIL PROTECTED]> wrote:
> > kobject drivers: cleaning up
> > kobject '' does not have a release() function, if this is not a
> > directory kobject, it is broken and must be fixed.
>
> printing this debug message, it looks a bit odd :)>
From: David McCullough <[EMAIL PROTECTED]>
Date: Thu, 20 Sep 2007 11:55:25 +1000
>
> Jivin Robin Getz lays it down ...
> > On Tue 18 Sep 2007 04:09, Bryan Wu pondered:
> > > From: Bernd Schmidt <[EMAIL PROTECTED]>
> > >
> > > This just adds minimum support for the Blackfin relocations,
> > >
On Thu, Sep 20, 2007 at 03:23:19PM +1000, Paul Mackerras wrote:
> I could remove all the kgdb support from arch/powerpc as a first step,
> if that would make it easier to pull in the new stuff...
Given that the existing powerpc kgdb bits didn't seem to work at all when
I tried them that seems
> >> Fatal server error:
> >> Couldn't bind memory for front buffer
> >>
> >> I thought I'd seen a thread about this issue, but I can't find it now. Is
> >> it
> >> known or am I seeing ghosts yet, Andrew?
> >>
> >
> > Can you send me a complete Xorg log file?
>
> Maybe you are rather interested
Robin Getz <[EMAIL PROTECTED]> writes:
> BTW - does anyone know Miles Bader's current email address? There isn't one
> listed in MAINTAINERS - and he is still listed for the NEC V850?
[EMAIL PROTECTED]
-Miles
--
Everywhere is walking distance if you have the time. -- Steven Wright
-
To
Sysfs now allows direct suicide. Make suicidial sysfs nodes to use
it and remove now unncessary callback mechanism.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/base/core.c | 33 --
drivers/s390/cio/ccwgroup.c | 25 +++-
On Wed, Sep 19, 2007 at 02:07:13PM -0400, Trond Myklebust wrote:
> On Wed, 2007-09-19 at 12:53 +0200, NetArt - Grzegorz Nosek wrote:
> > [16249868.626066] [ cut here ]
> > [16249868.684345] kernel BUG at mm/readahead.c:314!
>
> That bug should have been fixed in
Life can be weary and some sysfs files choose to commit suicide (kills
itself when written to). This is troublesome because while a sysfs
file is being accessed, the accessing task holds active references to
the node and its parent. Removing a sysfs node waits for active
references to be
As its name suggests, module_inhibit_unload() inhibits all module
unloading till the matching module_allow_unload() is called. This
unload inhibition doesn't affect whether a module can be unloaded or
not. It just stalls the final module free till the inhibition is
lifted.
This sledgehammer
Hello, all.
This is the second patchset of four sysfs update patchset series[1]
and to be applied on top of the first patchset[1].
Currently, sysfs files which want to kill themselves should ask
someone else (workqueue) to kill it, which is so inhumane. This
patchset updates sysfs file
Add sysfs_addrm_cxt->removed_tail to make the ->removed list FIFO.
This will be used to implement care-free suicide.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c |7 +--
fs/sysfs/sysfs.h |2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git
On 20 Sep 2007 at 0:53, Chuck Ebbert wrote:
> Looks like process 2382 is stuck with the kernel trying to send
> SIGBUS to that bash process, here:
>
Wow, thanks for that hint, certainly I wouldn't be able to trace the
problem as far as this :-)
Does this mean that perhaps bash or glibc (my
On Thu, Sep 20, 2007 at 08:24:58AM +0200, Nadia Derbey wrote:
> Jarek Poplawski wrote:
> >On 18-09-2007 16:55, Nadia Derbey wrote:
> >...
> >
> >>Well, reviewing the code I found another place where the
> >>rcu_read_unlock() was missing.
> >>I'm so sorry for the inconvenience. It's true that I
[this, sans patch which was too big for netdev, was just sent upstream.
the patch can be recreated via 'git diff net-2.6.24..upstream']
NOTE that sky2 will also be going upstream for 2.6.23-rc, as just posted
on netdev.
Please pull from the 'upstream' branch of
On 09/20/2007 03:51 AM, Dave Airlie wrote:
> On 9/20/07, Jiri Slaby <[EMAIL PROTECTED]> wrote:
>> On 09/19/2007 09:54 PM, Andi Kleen wrote:
Yeah. (But X doesn't run -- this is maybe the known issue in this release).
>>> What do you mean with not run?
>> (II) intel(0): Initializing HW Cursor
>> > It doesn't handle O= directories...
>> Sorry, I don't understand you. What are "0=" directories?
>
> When building a kernel you can specify an other output directory
> so you do not mix up your source tree with generated files.
> To do so do like this:
>
> Prepare the stuff:
> mkdir ~/kernel
On Wed, Sep 19, 2007 at 11:31:10PM -0700, Andrew Morton wrote:
> On Tue, 18 Sep 2007 10:05:37 +0200 Andreas Herrmann <[EMAIL PROTECTED]> wrote:
>
> > Fix compile error if !CONFIG_SYSCTL:
> >
> > ...
> > LD .tmp_vmlinux1
> > net/built-in.o: In function `init_p9':
> > net/9p/mod.c:59:
On Wed, Sep 19, 2007 at 12:06:44PM -0400, Robert P. J. Day wrote:
> Given the equivalent "retain_initrd" boot-time paramater, "keepinitrd"
> appears to be entirely superfluous.
NAK. "keepinitrd" is what people expect on ARM.
I'm frustrated that whoever invented "retain_initrd" didn't look
On 09/20/2007 04:24 AM, Andrew Morton wrote:
> On Thu, 20 Sep 2007 11:42:29 +1000 "Dave Airlie" <[EMAIL PROTECTED]> wrote:
>
>> From 225696d75e7ec0bafbb47b935bd700e3fbeefbde Mon Sep 17 00:00:00 2001
>> From: Dave Airlie <[EMAIL PROTECTED]>
>> Date: Thu, 20 Sep 2007 11:30:41 +1000
>> Subject:
* Hiroshi Shimamoto <[EMAIL PROTECTED]> wrote:
> Dmitry Adamushko wrote:
> >>> Hi Ingo,
> >>>
> >>> I found an issue about the scheduler.
> >>> If you need a test case, please let me know.
> >>> Here is a patch.
> >>> [ ... ]
> >>> The new thread should be valid scheduler class before queuing.
>
On Thu, 2007-09-20 at 06:55 +0200, Mike Galbraith wrote:
> On Wed, 2007-09-19 at 10:06 -0700, Tong Li wrote:
>
> > Were the experiments run on a 2-CPU system?
>
> Yes.
>
> > When Xorg experiences large
> > wait time, is it on the same CPU that has the two pinned tasks? If this is
> > the
Children list head is only meaninful for directory nodes. Move it
into s_dir. This doesn't save any space currently but it will with
further changes.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c | 17 +
fs/sysfs/inode.c |2 +-
fs/sysfs/sysfs.h |3
Hi Valdis,
On Wed, 19 Sep 2007, [EMAIL PROTECTED] wrote:
>
> On Wed, 19 Sep 2007 01:16:28 EDT, Kyle Moffett said:
>
> > I am assuming that if the laptop has sufficiently important data on
> > it to warrant the above steps then I am also clueful enough to:
> >(A) Not carry the laptop
Implement sysfs_open_dirent which represents an open file (attribute)
sysfs_dirent. A file sysfs_dirent with one or more open files have
one sysfs_dirent and all sysfs_buffers (one for each open instance)
are linked to it.
sysfs_open_dirent doesn't actually do anything yet but will be used to
Sysfs file poll implementation is scattered over sysfs and kobject.
Event numbering is done in sysfs_dirent but wait itself is done on
kobject. This not only unecessarily bloats both kobject and
sysfs_dirent but is also buggy - if a sysfs_dirent is removed while
there still are pollers, the
Move s_mode downward such that it's side-by-side with s_iattr which is
used for the same thing.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/sysfs.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
index 63adbec..6cf61c8
sysfs_root is different from a regular directory dirent in that it's
of type SYSFS_ROOT and doesn't have a name. These differences aren't
used by anybody and only adds to complexity. Make sysfs_root a
regular directory dirent.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/inode.c |
Make s_elem an anonymous union. Prefixing with s_elem makes things
needlessly longer without any advantage.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/bin.c | 14 +++---
fs/sysfs/dir.c |4 ++--
fs/sysfs/file.c| 14 +++---
fs/sysfs/inode.c |
sysfs_attach_dentry() now has only one caller and isn't doing much
other than obfuscating the code. Open code and kill it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c | 20
1 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/fs/sysfs/dir.c
All bin attr operations require active references of itself and its
parent. There's no reason to allow open when its parent has been
deactivated and allowing it is inconsistent with regular sysfs file.
Use sysfs_get_active_two() in bin attribute open function.
Signed-off-by: Tejun Heo <[EMAIL
sysfs_update_file() depends on inode->i_mtime but sysfs iondes are now
reclaimable making the reported modification time unreliable. There's
only one user (pci hotplug) of this notification mechanism and it
reportedly isn't utilized from userland.
Kill sysfs_update_file().
Signed-off-by: Tejun
In sysfs_release(), sysfs_buffer pointed to by filp->private_data is
guaranteed to exist. Kill the unnecessary NULL check. This also
makes the code more consistent with the counterpart in fs/sysfs/bin.c.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/file.c |9 -
1 files
There's no reason to get an extra reference to sysfs_dirent for an
open file. Open file has a reference to the dentry which in turn has
a reference to sysfs_dirent. This is fairly obvious as otherwise open
itself won't be able to access the sysfs_dirent. Kill the extra
sysfs_get() and matching
sysfs is about to go through major overhaul making this a pretty good
opportunity to clean up (out-of-tree changes and pending patches will
need regeneration anyway). Clean up headers.
* Kill space between * and symbolname.
* Move SYSFS_* type constants and flags into fs/sysfs/sysfs.h.
of
drivers/sysfs-rewrite-sysfs_move_dir-in-terms-of-sysfs-dirents.patch
in gregkh-2.6 as of today (20070920, based on 2.6.23-rc6-git4) and
contains the following 15 patches.
0001-sysfs-kill-SYSFS_FLAG_REMOVED.patch
0002-sysfs-fix-comments-of-sysfs_add-remove_one.patch
0003-sysfs-fix
With sysfs_get_dentry() simplified, there's no user of
SYSFS_FLAG_REMOVED left. Kill it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
This patch reverts driver/sysfs-kill-sysfs_flag_removed.patch and thus
can be removed together with it.
fs/sysfs/dir.c|5 -
Hi,
I have the kview zoom function mapped to the scrollwheel
with ctrl.
Now my wife found out and watching our photos wanted
to zoom out a bit. Then she just rotated the scrollwheel a lot
and expected the zoom to happen. What did happen was that
as the there was no apparent response she tried
sysfs_chmod_file() looked and updated only inode of the target file.
Dentry and inode are reclaimable and the update mode data will go away
when the inode is reclaimed. This patch makes sysfs_chmod_file()
update sd->s_mode too such that the change is permanent.
Signed-off-by: Tejun Heo <[EMAIL
sysfs_add/remove_one() now link and unlink the target dirent into and
from the children list. Update comments accordingly.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/sysfs/dir.c
As David Brownell pointed out when reviewing my suspend patch to
gpio_keys, the original gpio_keys driver does not check gpio_to_irq
return code.
This patch adds the gpio_to_irq return code check to gpio_keys and
moves the IRQ edge type setting to request_irq flags to avoid changing
the irq
On Wed, 19 Sep 2007, J. Bruce Fields wrote:
>
> Uh, is there somebody else that feels they're being enlightened by this
> discussion?
Ok, probably I got a bit too harsh with Kyle there. But what I don't
understand is why is it so hard for someone to accept they're wrong
on this list, thank the
On Thu, Sep 20, 2007 at 07:44:49AM +0200, Ph. Marek wrote:
> Hello Jeff,
>
> > On Wed, Sep 19, 2007 at 06:17:51PM +0200, Philipp Marek wrote:
> >> How about that?
> >>readlink include/asm
> >> returns
> >>asm-um
> >> in my case, so I only have to strip the "asm-" part ...
> >
> > It
On Wed, 19 Sep 2007 08:43:42 -0400 (EDT)
"Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
>
> Given the existing "retain_initrd" boot-time parameter defined in
> init/initramfs.c, there appears to be no need for the equivalent
> "keepinitrd" parameter.
>
> Signed-off-by: Robert P. J. Day <[EMAIL
Jesse Barnes <[EMAIL PROTECTED]> writes:
>
> To do this in a nicer way (and be less vulnerable to similar BIOS
> funkiness) the kernel really needs full PAT support. That should allow
> WC over WB and WC over UC mappings to occur, at least if I'm
> remembering the docs right...
PAT only
On Thu, 2007-09-20 at 14:34 +0800, Bryan Wu wrote:
> On Thu, 2007-09-20 at 02:08 -0400, Robin Getz wrote:
> > On Wed 19 Sep 2007 23:54, Paul Mundt pondered:
> > > On Wed, Sep 19, 2007 at 11:42:53PM -0400, Mike Frysinger wrote:
> > > > On 9/19/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
> > > > > On
ben soo wrote:
[...]
This last might be an artifact caused by the firewall, i dunno.
[...]
Bill Davidsen <[EMAIL PROTECTED]> wrote:
Yes, I have found that I get far less problem in this area leaving the
MTU at 1500, then putting a larger MTU (usually 9000) into the routing
table for
On Tue, 18 Sep 2007 13:55:04 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote:
> include/asm-powerpc/elf.h has 6 entries in ARCH_DLINFO.
> fs/binfmt_elf.c has 14 unconditional NEW_AUX_ENT entries and 2
> conditional NEW_AUX_ENT entries.
> So in the worst case, saved_auxv does not get an AT_NULL entry
On Tue, 18 Sep 2007 15:17:37 +0400 Valentine Barshak <[EMAIL PROTECTED]> wrote:
> PCI memory space may have a 64-bit offset on some architectures
> (for example, PowerPC 440) and the actual PCI memory address
> has to fixed up (an offset to PCI mem space shuld be added)
> before remapping. So,
On Thu, 2007-09-20 at 02:08 -0400, Robin Getz wrote:
> On Wed 19 Sep 2007 23:54, Paul Mundt pondered:
> > On Wed, Sep 19, 2007 at 11:42:53PM -0400, Mike Frysinger wrote:
> > > On 9/19/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
> > > > On Thu, Sep 20, 2007 at 11:55:25AM +1000, David McCullough
On Tue, 18 Sep 2007 10:05:37 +0200 Andreas Herrmann <[EMAIL PROTECTED]> wrote:
> Fix compile error if !CONFIG_SYSCTL:
>
> ...
> LD .tmp_vmlinux1
> net/built-in.o: In function `init_p9':
> net/9p/mod.c:59: undefined reference to `p9_sysctl_register'
> net/built-in.o: In function
Antonino A. Daplas wrote:
On Tue, 2007-09-18 at 03:26 -0400, ben soo wrote:
i've 2 servers with old PCI VGA cards, one using X86_64 kernel
version 2.6.23-rc5 and one with i386 kernel version 2.6.23-rc6,
both wired into the same CRT via a KVM switch.
Is this new? If yes, what's the version of
401 - 500 of 1005 matches
Mail list logo