Re: [bug] xfrm_state_lock: possible circular locking dependency detected

2007-11-23 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, Nov 23, 2007 at 04:38:51PM +0100, Ingo Molnar wrote: > > > > DaveJ's Fedora 8 rpm for 2.6.24 works petty well, except for the > > neworking related lockdep assert attached below, which happened while > > starting up ipsec. Let me know if you ne

Re: [PATCHv5 4/5] Allow setting O_NONBLOCK flag for new sockets

2007-11-23 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Eric Dumazet wrote: > 1) Can the fd passing with recvmsg() on AF_UNIX also gets O_CLOEXEC > support ? Already there, see MSG_CMSG_CLOEXEC. > 2) Why this O_NONBLOCK ability is needed for sockets ? Is it a security > issue, and if yes could you remind

Re: [PATCHv5 4/5] Allow setting O_NONBLOCK flag for new sockets

2007-11-23 Thread Eric Dumazet
Ulrich Drepper a écrit : This patch adds support for setting the O_NONBLOCK flag of the file descriptors returned by socket, socketpair, and accept. Thanks Ulrich for this v5 series. I have two more questions. 1) Can the fd passing with recvmsg() on AF_UNIX also gets O_CLOEXEC support ? (

Re: [PATCH 1/1] [MTD/NAND]: Add Blackfin BF52x on-chip NAND Flash controller driver support in bf5xx_nand driver

2007-11-23 Thread Bryan Wu
On Nov 24, 2007 2:43 PM, David Woodhouse <[EMAIL PROTECTED]> wrote: > > On Fri, 2007-11-23 at 17:04 -0500, Robin Getz wrote: > > It could be a runtime if() but we don't currently have the is_mach() all set > > up properly today. > > > > This is because on most systems that Blackfin ships on - memor

Re: [PATCH 1/1] [MTD/NAND]: Add Blackfin BF52x on-chip NAND Flash controller driver support in bf5xx_nand driver

2007-11-23 Thread David Woodhouse
On Fri, 2007-11-23 at 17:04 -0500, Robin Getz wrote: > It could be a runtime if() but we don't currently have the is_mach() all set > up properly today. > > This is because on most systems that Blackfin ships on - memory is the > dominate cost of the system, and end users don't want to take the

Re: 2.6.24-rc3-mm1: I/O error, system hangs

2007-11-23 Thread James Bottomley
On Fri, 2007-11-23 at 18:52 +0100, Laurent Riffard wrote: > Le 23.11.2007 12:38, Hannes Reinecke a écrit : > > Hannes Reinecke wrote: > >> Laurent Riffard wrote: > >>> Le 21.11.2007 23:41, Andrew Morton a écrit : > On Wed, 21 Nov 2007 22:45:22 +0100 > Laurent Riffard <[EMAIL PROTECTED]>

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Herbert Xu
Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > Also io->pending may need better protection - atomic, but missing memory > barriers? (May be getting away without sometimes due to side-effects of > other function calls, but needs doing properly.) If it's using atomic_dec_and_test then that comes wi

Re: + smack-version-11c-simplified-mandatory-access-control-kernel.patch added to -mm tree

2007-11-23 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I believe it was you who once eloquently observed that, at its heart, the POSIX (sic) capabilities model was all about providing a mechanism for overriding the prevailing security policy (be it MAC or DAC or whatever) in a defined way. Casey Schaufler

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-23 Thread Herbert Xu
David Schwartz <[EMAIL PROTECTED]> wrote: > >> Regardless of whatever verifications your application is doing >> on the data, it is not checksumming the ports and that's what >> the pseudo-header is helping with. > > So what? We are in the case where the data has already gotten to him. If it > go

Re: [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v2)

2007-11-23 Thread Tejun Heo
Tejun Heo wrote: > Robert Hancock wrote: >> We need to run any DMA command with result taskfile requested in ADMA mode >> when the port is in ADMA mode, otherwise it may try to use the legacy DMA >> engine >> in ADMA mode which is not allowed. Enforce this with BUG_ON() since data >> corruption co

Re: [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v2)

2007-11-23 Thread Tejun Heo
Robert Hancock wrote: > We need to run any DMA command with result taskfile requested in ADMA mode > when the port is in ADMA mode, otherwise it may try to use the legacy DMA > engine > in ADMA mode which is not allowed. Enforce this with BUG_ON() since data > corruption could potentially result i

Re: [patch 2/4] Timerfd v2 - new timerfd API

2007-11-23 Thread Michael Kerrisk
Hi Davide, [...] > +asmlinkage long sys_timerfd_create(int clockid, int flags) > { > - int error; > + int error, ufd; > struct timerfd_ctx *ctx; > struct file *file; > struct inode *inode; > - struct itimerspec ktmr; > - > - if (copy_from_user(&ktmr, utmr, sizeo

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Tejun Heo
Robert Hancock wrote: > This fixes some problems with ATAPI devices on nForce4 controllers in ADMA > mode > on systems with memory located above 4GB. We need to delay setting the 64-bit > DMA mask until the PRD table and padding buffer are allocated so that they > don't > get allocated above 4GB

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Torsten Kaiser
On Nov 24, 2007 4:49 AM, Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote: > > ... or I just don't see the bug. > > See my earlier post in this thread: there's a race in the write loop > where a work struct could be used twice on the same

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-23 Thread Rusty Russell
On Saturday 24 November 2007 06:53:30 Andi Kleen wrote: > This serves as a documentation > on what is considered internal. And if some obscure module (in or > out of tree) wants to use an internal interface they first have > to send the module maintainer a patch and get some review this way. So,

Re: + smack-version-11c-simplified-mandatory-access-control-kernel.patch added to -mm tree

2007-11-23 Thread Casey Schaufler
--- Andrew Morgan <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Casey Schaufler wrote: > > In the end we can call it CAP_LATE_FOR_DINNER if that's the only way > > I can move forward. CAP_MAC_OVERRIDE is the obvious partner to > > CAP_DAC_OVERRIDE, so that's st

ipmi_watchdog can not reset the kernel panic machine

2007-11-23 Thread youquan_song
Build kernel-2.6.24-rc3. pmi_watchdog can not reset the kernel panic machine. The watchdog can never to record panic information to IPMI SEL. 1. I disable auto reset when kernel panic by echo "0" > /proc/sys/kernel/panic 2. modprobe ipmi_watchdog timeout=120 action=reset 3. Load a driver, th

Re: Laptop keyboard unusable when ACPI is active was Re: [2.6.22] i8042, ACPI, ipw2100 and issues reported by psmouse.c atkbd.c

2007-11-23 Thread Len Brown
On Sunday 21 October 2007 05:43, [EMAIL PROTECTED] wrote: > I have emerged lm_sensors but can't get it running - it keeps saying "No > sensors found!" and complaining about kernel drivers not properly setup. > I have attached the output of sensors-detect, from which it seems that > the kernel is O

Re: Laptop keyboard unusable when ACPI is active

2007-11-23 Thread Len Brown
On Thursday 22 November 2007 02:24, [EMAIL PROTECTED] wrote: > It is also important to note that this bug always comes with bug 8740 > http://bugzilla.kernel.org/show_bug.cgi?id=8740 (also confirmed and also > an ACPI issue). No, 8740 is not an ACPI issue. http://bugzilla.kernel.org/show_bug.cg

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Alasdair G Kergon
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote: > Before the cleanup *all* calls to crypt_dec_pending() was via crypt_endio(). > Now there is an additional call to crypt_dec_pending() to balance the > additional ref placed into crypt_write_io_process(). And that one is > not called

Re: Laptop keyboard unusable when ACPI is active

2007-11-23 Thread Len Brown
On Friday 23 November 2007 02:44, Mats Johannesson wrote: > The bad interaction between ACPI controlled EC (embedded controller) > and the i8042 interrupt handler is theorized about in detail at OLPCs > http://dev.laptop.org/ticket/2401 - almost at the end of that page. > Thanks to Daniele C for t

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Alasdair G Kergon
Also io->pending may need better protection - atomic, but missing memory barriers? (May be getting away without sometimes due to side-effects of other function calls, but needs doing properly.) [BTW Other device-mapper atomic_t usage also needs reviewing.] Alasdair -- [EMAIL PROTECTED] - To uns

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Alasdair G Kergon
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote: > ... or I just don't see the bug. See my earlier post in this thread: there's a race in the write loop where a work struct could be used twice on the same queue. (Needs data structure change to fix that, which nobody has attempted t

Re: [PATCH] NET: dmfe: don't access configuration space in D3 state

2007-11-23 Thread Maxim Levitsky
On Saturday 24 November 2007 05:10:37 Jeff Garzik wrote: > Maxim Levitsky wrote: > >>From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001 > > From: Maxim Levitsky <[EMAIL PROTECTED]> > > Date: Fri, 23 Nov 2007 01:15:36 +0200 > > Subject: [PATCH] NET: dmfe: don't access configurati

Re: + smack-version-11c-simplified-mandatory-access-control-kernel.patch added to -mm tree

2007-11-23 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Casey Schaufler wrote: > In the end we can call it CAP_LATE_FOR_DINNER if that's the only way > I can move forward. CAP_MAC_OVERRIDE is the obvious partner to > CAP_DAC_OVERRIDE, so that's still my preference. CAP_SMACK_OVERRIDE > unnecessarily ties it

Re: [PATCH 1/2] Blackfin SMC91x Driver: punt CONFIG_BFIN -- we already have CONFIG_BLACKFIN

2007-11-23 Thread Jeff Garzik
Bryan Wu wrote: From: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/net/Kconfig |2 +- drivers/net/smc91x.h |2 +- applied 1-2 to #upstream-fixes - To unsubscribe from this list: send the

Re: [PATCH] NET: dmfe: don't access configuration space in D3 state

2007-11-23 Thread Jeff Garzik
Maxim Levitsky wrote: From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001 From: Maxim Levitsky <[EMAIL PROTECTED]> Date: Fri, 23 Nov 2007 01:15:36 +0200 Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state Accidently I reversed the order of pci_save_state

Re: [PATCH 1/2][2.6.24] ehea: Improve tx packets counting

2007-11-23 Thread Jeff Garzik
Thomas Klein wrote: Using own tx_packets counter instead of firmware counters. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) applies 1-2 to #upstream-

Re: [PATCH 1/9] cxgb3 - fix MSI-X failure path

2007-11-23 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Return error code when msi-x settings fail. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) applied 1-9 to #upstream, then trimmed all trai

Re: [PATCH] e100: free IRQ to remove warning when rebooting

2007-11-23 Thread Jeff Garzik
Ian Wienand wrote: Hi, When rebooting today I got Will now restart. ACPI: PCI interrupt for device :00:03.0 disabled GSI 20 (level, low) -> CPU 1 (0x0100) vector 53 unregistered Destroying IRQ53 without calling free_irq WARNING: at /home/insecure/ianw/programs/git-kernel/linux-2.6/kernel/i

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Mark Lord
Jeff Garzik wrote: Robert Hancock wrote: Based on a quick look at sata_mv it appears it sets a 64-bit DMA mask unconditionally, but for non-ATA_PROT_DMA commands (which includes all ATAPI), it just falls back to ata_qc_issue_prot which issues via the legacy SFF interface and can only handle 32

Re: [bug] xfrm_state_lock: possible circular locking dependency detected

2007-11-23 Thread Herbert Xu
On Fri, Nov 23, 2007 at 04:38:51PM +0100, Ingo Molnar wrote: > > DaveJ's Fedora 8 rpm for 2.6.24 works petty well, except for the > neworking related lockdep assert attached below, which happened while > starting up ipsec. Let me know if you need any more info - it's a pretty > stock setup. Th

Re: [PATCH 29/59] drivers/net/chelsio: Add missing "space"

2007-11-23 Thread Jeff Garzik
Joe Perches wrote: Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) appied 29-36 to netdev#upstream - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

netdev-2.6 rebased

2007-11-23 Thread Jeff Garzik
I pulled all the patches collected by DaveM in davem/netdev-2.6.git a few days ago into jgarzik/netdev-2.6.git#upstream. As of a few minutes ago, jgarzik/netdev-2.6.git was rebased to the latest 2.6.24-rc (torvalds/linux-2.6.git). Jeff - To unsubscribe from this list: send the line

[PATCH] dmaengine: Correct invalid assumptions in the Kconfig text

2007-11-23 Thread Dan Williams
From: Haavard Skinnemoen <[EMAIL PROTECTED]> This patch corrects recently changed (and now invalid) Kconfig descriptions for the DMA engine framework: - Non-Intel(R) hardware also has DMA engines; - DMA is used for more than memcpy and RAID offloading. In fact, on most platforms memcpy and RAI

Re: radeonfb i2c regression post-2.6.18.

2007-11-23 Thread Benjamin Herrenschmidt
On Fri, 2007-11-23 at 23:29 +0100, Jean Delvare wrote: > On Fri, 23 Nov 2007 17:00:52 +0100, Michael Buesch wrote: > > This patch fixes my crash problem. > > Out of curiosity, what kind of crash was it? I admit that I can't see > how the code could crash. Really sneaky... apparently, keeping the

Re: 2.6.24-rc3-mm1 - Kernel Panic on IO-APIC

2007-11-23 Thread Alexey Dobriyan
On Tue, Nov 20, 2007 at 10:18:39PM -0800, Andrew Morton wrote: > On Wed, 21 Nov 2007 11:41:23 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > > Hi Andrew, > > > > Kernel panic's across different architectures like powerpc, x86_64, > > powerpc complains about IO-APICs?? > > > Dentry cache

Re: [PATCH] pata_isapnp: Polled devices

2007-11-23 Thread Jeff Garzik
Alan Cox wrote: If a card has no IRQ then pass no interrupt handler but allow polled usage. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_isapnp.c linux-2.6.24-rc2-mm1/drivers/ata/pata_i

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Robert Hancock
Jeff Garzik wrote: Robert Hancock wrote: Based on a quick look at sata_mv it appears it sets a 64-bit DMA mask unconditionally, but for non-ATA_PROT_DMA commands (which includes all ATAPI), it just falls back to ata_qc_issue_prot which issues via the legacy SFF interface and can only handle 32

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Jeff Garzik
Robert Hancock wrote: Based on a quick look at sata_mv it appears it sets a 64-bit DMA mask unconditionally, but for non-ATA_PROT_DMA commands (which includes all ATAPI), it just falls back to ata_qc_issue_prot which issues via the legacy SFF interface and can only handle 32-bit addressing. So

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Robert Hancock
Mark Lord wrote: Morrison, Tom wrote: I am hopeful that the sata_mv has this bug (I proved that the problem I was experiencing was due to the sata_mv driver with 3.75Gig or more of memory)... I am on vacation for a week or more ...or I'd tell you today if it did have this bug! .. Yeah, I k

No error when inotify_add_watch(/an/NFS/file)

2007-11-23 Thread Phil Endecott
Dear Experts, NFS doesn't work with inotify (and it looks like it can't, certainly not before NFS v4.1). However, if I give an NFS filename to inotify_add_watch(), I don't get an error. If it indicated an error in this case then I could easily fall back to some sort of polling. Without an

Re: sata NCQ blacklist entry

2007-11-23 Thread Jan-Simon Möller
Am Freitag 23 November 2007 08:21:09 schrieb Andrew Morton: > On Tue, 13 Nov 2007 21:55:15 +0100 Jan-Simon M__ller <[EMAIL PROTECTED]> > wrote: > > Hi! > > You removed from cc the guys who are most likely to fix this. Please > always do reply-to-all. Sri, will remember that. > > > Just using kern

Re: nfs failure causes bad page state

2007-11-23 Thread Trond Myklebust
On Fri, 2007-11-16 at 22:13 +, Russell King wrote: > While testing a kernel based upon > ecd744eec3aa8bbc949ec04ed3fbf7ecb2958a0e > (with wrong boot arguments), I got the following bad page state entry > while > NFS was trying to mount it's rootfs: > > IP-Config: Complete: > device=eth0

Re: freeze vs freezer

2007-11-23 Thread Rafael J. Wysocki
On Thursday, 22 of November 2007, Jeremy Fitzhardinge wrote: > It seems that a process blocked in a write to an xfs filesystem due to > xfs_freeze cannot be frozen by the freezer. The freezer doesn't handle tasks in TASK_UNINTERRUPTIBLE and I don't know how to make it handle them without at least

Re: OT: Re: System reboot triggered by just reading a device file....!?

2007-11-23 Thread devzero
Hi Clemens, > > Hi, Roland! > > Please don't top-post. sorry! > > > [was: it would be easy to disable the kernel watchdog] > > thanks, but i know i could do this. > > Good. I was also curious and just checked again. The watchdog subsystem > is by default _disabled_ in the kernel configurat

Re: [RFC] Documentation about unaligned memory access

2007-11-23 Thread Dmitri Vorobiev
Daniel Drake пишет: > Being spoilt by the luxuries of i386/x86_64 I've never really had a good > grasp on unaligned memory access problems on other architectures and decided > it was time to figure it out. As a result I've written this documentation > which I plan to submit for inclusion as > Docum

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Torsten Kaiser
On Nov 19, 2007 10:00 PM, Milan Broz <[EMAIL PROTECTED]> wrote: > Torsten Kaiser wrote: > > On Nov 19, 2007 8:56 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > >> * Torsten Kaiser <[EMAIL PROTECTED]> wrote: > ... > > Above this acquire/release sequence is the following comment: > > #ifdef CONFIG_LOCK

Re: radeonfb i2c regression post-2.6.18.

2007-11-23 Thread Jean Delvare
On Fri, 23 Nov 2007 17:00:52 +0100, Michael Buesch wrote: > This patch fixes my crash problem. Out of curiosity, what kind of crash was it? I admit that I can't see how the code could crash. -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 1/1] [MTD/NAND]: Add Blackfin BF52x on-chip NAND Flash controller driver support in bf5xx_nand driver

2007-11-23 Thread Robin Getz
On Fri 23 Nov 2007 16:52, Arjan van de Ven pondered: > On Fri, 23 Nov 2007 22:25:29 +0800 > "Bryan Wu" <[EMAIL PROTECTED]> wrote: > > > On Nov 23, 2007 6:19 PM, David Woodhouse <[EMAIL PROTECTED]> wrote: > > > > > > On Fri, 2007-11-23 at 18:14 +0800, Bryan Wu wrote: > > > > > > > > +#ifdef CONFIG_

Re: [RFC] Documentation about unaligned memory access

2007-11-23 Thread Vadim Lobanov
On Thursday 22 November 2007 04:15:53 pm Daniel Drake wrote: > Fortunately things are not too complex, as in most cases, the compiler > ensures that things will work for you. For example, take the following > structure: > > struct foo { > u16 field1; > u32 field2;

Re: [PATCH 1/1] [MTD/NAND]: Add Blackfin BF52x on-chip NAND Flash controller driver support in bf5xx_nand driver

2007-11-23 Thread Arjan van de Ven
On Fri, 23 Nov 2007 22:25:29 +0800 "Bryan Wu" <[EMAIL PROTECTED]> wrote: > On Nov 23, 2007 6:19 PM, David Woodhouse <[EMAIL PROTECTED]> wrote: > > > > On Fri, 2007-11-23 at 18:14 +0800, Bryan Wu wrote: > > > > > > +#ifdef CONFIG_BF54x > > > /* Setup DMAC1 channel mux for NFC which shared w

Re: Where is the interrupt going?

2007-11-23 Thread Benjamin Herrenschmidt
On Wed, 2007-11-21 at 17:08 -0800, Al Niessner wrote: > > p8620 = pci_get_device (APC8620_VENDOR_ID, APC8620_DEVICE_ID, p8620); > <... fail if p8620 is 0 ...> > apcsi[i].ret_val = register_chrdev (MAJOR_NUM, > > DEVICE_NAME, > > &apc8620_ops); > <... fail if ret_val < 0 ...> > apcsi[i].board_ir

[patch 4/4] Timerfd v2 - un-break CONFIG_TIMERFD

2007-11-23 Thread Davide Libenzi
Remove the broken status to CONFIG_TIMERFD. Signed-off-by: Davide Libenzi <[EMAIL PROTECTED]> - Davide --- init/Kconfig |1 - 1 file changed, 1 deletion(-) Index: linux-2.6.mod/init/Kconfig === --- linux-2.6.mod.orig/init/

[patch 3/4] Timerfd v2 - wire the new timerfd API to the x86 family

2007-11-23 Thread Davide Libenzi
Wires up the new timerfd API to the x86 family. Signed-off-by: Davide Libenzi <[EMAIL PROTECTED]> - Davide --- arch/x86/ia32/ia32entry.S |4 +++- arch/x86/kernel/syscall_table_32.S |4 +++- include/asm-x86/unistd_32.h|6 -- include/asm-x86/unistd_64.h

[patch 1/4] Timerfd v2 - introduce a new hrtimer_forward_now() function

2007-11-23 Thread Davide Libenzi
I think that advancing the timer against the timer's current "now" can be a pretty common usage, so, w/out exposing hrtimer's internals, we add a new hrtimer_forward_now() function. Signed-off-by: Davide Libenzi <[EMAIL PROTECTED]> - Davide --- include/linux/hrtimer.h |7 +++ 1 file

[patch 2/4] Timerfd v2 - new timerfd API

2007-11-23 Thread Davide Libenzi
This is the new timerfd API as it is implemented by the following patch: int timerfd_create(int clockid, int flags); int timerfd_settime(int ufd, int flags, const struct itimerspec *utmr, struct itimerspec *otmr); int timerfd_gettime(int ufd, struct itimersp

Re: unionfs: several more problems

2007-11-23 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Hugh Dickins writes: [...] > > I deceived myself for a while that the danger of shmem_writepage > > hitting its BUG_ON(entry->val) was dealt with too; but that's wrong, > > I must go back to working out an escape from that one (despite never > > seeing it). > > Once

Re: Where is the new timerfd?

2007-11-23 Thread Davide Libenzi
On Fri, 23 Nov 2007, Ulrich Drepper wrote: > On Nov 23, 2007 9:29 AM, Davide Libenzi <[EMAIL PROTECTED]> wrote: > > Yes, it's disabled, and yes, I'll repost today ... > > I haven't seen the patch and don't feel like searching. So I say it > here: please mak sure you add a flags parameter to the

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Mark Lord
Mark wrote: Yeah, I kind of had your reports in mind when I asked that. :) On a related note, I now have lots of Marvell (sata_mv) hardware here, and an Intel CPU/chipset box with physical RAM above the 4GB boundary. Morrison, Tom wrote: Yes, I believe that - otherwise, this problem would ha

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:54:11PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > Here's another thought: move all this logic into the networking core, > > unify it with current softirq zapper, then allow it to be called fro

Re: [PATCH 9/9] Clean up open coded inode dirty checks

2007-11-23 Thread Jan Engelhardt
On Nov 23 2007 11:47, Joe Perches wrote: >On Fri, 2007-11-23 at 19:16 +0100, Jan Engelhardt wrote: >> static inline bool xfs_inode_clean(const struct xfs_inode *ip) >> { >> if (ip->i_itemp == NULL) >> return true; >> if (!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL) &

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 10:54:10PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > Here's another thought: move all this logic into the networking core, > > unify it with current softirq zapper, then allo

[PATCH -mm 1/2] wait_task_stopped: remove unneeded delay_group_leader check

2007-11-23 Thread Oleg Nesterov
wait_task_stopped() doesn't need the "delay_group_leader" parameter. If the child is not traced it must be a group leader. With or without subthreads ->group_stop_count == 0 when the whole task is stopped. Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> --- PT/kernel/exit.c~5_ck_group_stop20

[PATCH -mm 2/2] do_wait: cleanup delay_group_leader() usage

2007-11-23 Thread Oleg Nesterov
eligible_child() == 2 means delay_group_leader(). With the previous patch this only matters for EXIT_ZOMBIE task, we can move that special check to the only place it is really needed. Also, with this patch we don't skip security_task_wait() for the group leaders in a non-empty thread group. I don'

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > Here's another thought: move all this logic into the networking core, > unify it with current softirq zapper, then allow it to be called from > various other places (like atomic allocators). Then it'll all be in >

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
This looks bad, though: include/linux/fsnotify.h:121: warning: passing argument 2 of 'audit_inode_child' from incompatible pointer type Missing "->d_inode"? M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo i

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-23 Thread Andi Kleen
On Fri, Nov 23, 2007 at 02:35:05PM +1100, Rusty Russell wrote: > On Friday 23 November 2007 12:36:22 Andi Kleen wrote: > > On Friday 23 November 2007 01:25, Rusty Russell wrote: > > > That's my point. If there's a whole class of modules which can use a > > > symbol, why are we ruling out external

Re: [PATCH 9/9] Clean up open coded inode dirty checks

2007-11-23 Thread Joe Perches
On Fri, 2007-11-23 at 19:16 +0100, Jan Engelhardt wrote: > static inline bool xfs_inode_clean(const struct xfs_inode *ip) > { > if (ip->i_itemp == NULL) > return true; > if (!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL) && > ip->i_update_core == NULL) >

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:32:22PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:11:20PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL >

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 01:11:20PM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgen

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:15:24PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:59:43PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > So I'd be surprised if that was a problem. But I can imagine having > > problems for skbs without destructors which run into one of these in >

[PATCH] utsns: Restore proper namespace handling.

2007-11-23 Thread Eric W. Biederman
When CONFIG_UTS_NS was removed it seems that we also deleted the code for handling sysctls in the other then the initial uts namespace. This patch restores that code. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- kernel/utsname_sysctl.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > Stop, we are trying to free skb without d

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 12:59:43PM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > So I'd be surprised if that was a problem. But I can imagine having > problems for skbs without destructors which run into one of these in > __kfree_skb: > > dst_release > secpath_put > nf_conntrack_put > nf_connt

Re: Where is the new timerfd?

2007-11-23 Thread Michael Kerrisk
On Nov 23, 2007 7:38 PM, Ulrich Drepper <[EMAIL PROTECTED]> wrote: > On Nov 23, 2007 9:29 AM, Davide Libenzi <[EMAIL PROTECTED]> wrote: > > Yes, it's disabled, and yes, I'll repost today ... > > I haven't seen the patch and don't feel like searching. So I say it > here: please mak sure you add a f

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 08:57:57PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 11:07:56AM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL > > >

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > Stop, we are trying to free skb without destructor and catch connection > > tracking, so it is not a solution. To fix

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > Stop, we are trying to free skb without destructor and catch connection > tracking, so it is not a solution. To fix the problem we need to check > if it is not netfilter related, kind of this (not tested), Simo

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 08:57:57PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > > My memory here is hazy, but I think this exists to rescue netconsole > > in low-memory situations. This bit originated with Ingo, so maybe he > > can recall. > > > > Netpoll can process an arbitrary number o

RE: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Morrison, Tom
Yes, I believe that - otherwise, this problem would have been a crisis a LONG time ago...:-) But I do have some more questions in relationship to how things are mapped in your environment. I have a flat memory map (i.e.: the full 0x0 -- 0x1__ is passed to the 32bit Linux kernel without

Re: Where is the new timerfd?

2007-11-23 Thread Ulrich Drepper
On Nov 23, 2007 9:29 AM, Davide Libenzi <[EMAIL PROTECTED]> wrote: > Yes, it's disabled, and yes, I'll repost today ... I haven't seen the patch and don't feel like searching. So I say it here: please mak sure you add a flags parameter to the system call itself (instead of adding it on as for eve

Re: 2.6.23.1: Random hangs during boot with "tsc" clocksource

2007-11-23 Thread Jordan Russell
Chuck Ebbert wrote: > On 11/20/2007 06:20 PM, Jordan Russell wrote: >> Same problem with 2.6.23.8. >> >> Are there any specific (TSC related?) patches I should try reverting? >> >> Would it help if I captured the dmesg/SysRq output from one of the >> hanging boots? >> >> Any other information that

Re: [PATCH 9/9] Clean up open coded inode dirty checks

2007-11-23 Thread Jan Engelhardt
On Nov 23 2007 18:02, Christoph Hellwig wrote: > >> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip) >> +{ >> +return (((ip->i_itemp == NULL) || >> +!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) && >> +(ip->i_update_core == 0)); >> +} > >Can we please get rid

Re: [PATCH 9/9] Clean up open coded inode dirty checks

2007-11-23 Thread Christoph Hellwig
> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip) > +{ > + return (((ip->i_itemp == NULL) || > + !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) && > + (ip->i_update_core == 0)); > +} Can we please get rid of this useless STATIC_INLINE junk? It's really hurti

Re: [PATCH 6/9] Remove xfs_icluster

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:39:52AM +1100, David Chinner wrote: > Remove the xfs_icluster structure and replace with a radix tree lookup. > > We don't need to keep a list of inodes in each cluster around anymore > as we can look them up quickly when we need to. The only time we need > to do this no

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 11:07:56AM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL PROTECTED]) > > wrote: > > > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT

Re: 2.6.24-rc3-mm1: I/O error, system hangs

2007-11-23 Thread Laurent Riffard
Le 23.11.2007 12:38, Hannes Reinecke a écrit : > Hannes Reinecke wrote: >> Laurent Riffard wrote: >>> Le 21.11.2007 23:41, Andrew Morton a écrit : On Wed, 21 Nov 2007 22:45:22 +0100 Laurent Riffard <[EMAIL PROTECTED]> wrote: > Le 21.11.2007 05:45, Andrew Morton a écrit : >> f

Re: [PATCH 5/9] Don't block pdflush when flushing inodes

2007-11-23 Thread Christoph Hellwig
> +++ 2.6.x-xfs-new/fs/xfs/xfs_inode.c 2007-11-22 10:33:51.037704348 +1100 > @@ -183,12 +183,20 @@ xfs_imap_to_bp( > int ni; > xfs_buf_t *bp; > > + if (buf_flags == 0) > + buf_flags = XFS_BUF_LOCK; There's just two caller and they never pass 0, so t

Re: [kvm-devel] [PATCH 3/3] virtio PCI device

2007-11-23 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: Anthony Liguori wrote: Well please propose the virtio API first and then I'll adjust the PCI ABI. I don't want to build things into the ABI that we never actually end up using in virtio :-) Move ->kick() to virtio_driver. Th

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Mark Lord
Morrison, Tom wrote: I am hopeful that the sata_mv has this bug (I proved that the problem I was experiencing was due to the sata_mv driver with 3.75Gig or more of memory)... I am on vacation for a week or more ...or I'd tell you today if it did have this bug! .. Yeah, I kind of had your re

Re: [PATCH 4/9] Factor common inode cluster buffer lookup code

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:36:42AM +1100, David Chinner wrote: > +STATIC int > +xfs_ino_to_imap( > + xfs_mount_t *mp, > + xfs_trans_t *tp, > + xfs_ino_t ino, > + xfs_imap_t *imap, > + uintimap_flags) > +{ > + int error; > + > +

Re: [PATCH 3/9] Use _META bio I/O types for metadata I/O

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:35:12AM +1100, David Chinner wrote: > Improve metadata I/O merging in the elevator > > Change all async metadata buffers to use [READ|WRITE]_META I/O types > so that the I/O doesn't get issued immediately. This allows merging > of adjacent metadata requests but still pri

RE: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Morrison, Tom
I am hopeful that the sata_mv has this bug (I proved that the problem I was experiencing was due to the sata_mv driver with 3.75Gig or more of memory)... I am on vacation for a week or more ...or I'd tell you today if it did have this bug! From: [EMAIL PROTECTE

Re: Where is the new timerfd?

2007-11-23 Thread Davide Libenzi
On Fri, 23 Nov 2007, Andrew Morton wrote: > > I suppose this means that timerfd will only go in for 2.6.25. I don't > > have a problem with that, but we better make sure that the existing > > timerfd in 2.6.24 is still disabled. (Andrew had a one liner for > > that, but I haven't checked if it's

Re: Where is the new timerfd?

2007-11-23 Thread Andrew Morton
On Fri, 23 Nov 2007 13:39:55 +0100 "Michael Kerrisk" <[EMAIL PROTECTED]> wrote: > On 11/23/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Thu, 22 Nov 2007 16:35:38 -0800 (PST) Davide Libenzi > > <[EMAIL PROTECTED]> wrote: > > > > > On Thu, 22 Nov 2007, Andrew Morton wrote: > [...] > > > > Las

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL PROTECTED]) > wrote: > > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT=ppp0 WARNING: at > > > kernel/softirq.c:139 local_bh_enable() > > > [2059664.620535] [<8

[PATCH 2.6.24-rc3-mm1] IPC: consolidate sem_exit_ns(), msg_exit_ns and shm_exit_ns()

2007-11-23 Thread Pierre Peiffer
sem_exit_ns(), msg_exit_ns() and shm_exit_ns() are all called when an ipc_namespace is released to free all ipcs of each type. But in fact, they do the same thing: they loop around all ipcs to free them individually by calling a specific routine. This patch proposes to consolidate this by introd

Re: [kvm-devel] [PATCH 3/3] virtio PCI device

2007-11-23 Thread Anthony Liguori
Avi Kivity wrote: Anthony Liguori wrote: Well please propose the virtio API first and then I'll adjust the PCI ABI. I don't want to build things into the ABI that we never actually end up using in virtio :-) Move ->kick() to virtio_driver. Then on each kick, all queues have to be chec

Re: [patch/backport] CFS scheduler, -v24, for v2.6.24-rc3, v2.6.23.8, v2.6.22.13, v2.6.21.7

2007-11-23 Thread Durand
Ingo, I downloaded the updated cfs-v24 patch and applied to 2.6.22.13. Compiled and ran fine. Suspend and hibernate are working on my nc6000 laptop now. Now I'm off to compile and run 2.6.22.14. -- Thanks, Durand --- Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Durand <[EMAIL PROTECTED]> wrot

  1   2   >