Re: + kthread-add-a-missing-memory-barrier-to-kthread_stop.patch added to -mm tree

2008-02-23 Thread Dmitry Adamushko
On 23/02/2008, Linus Torvalds [EMAIL PROTECTED] wrote: On Sat, 23 Feb 2008, Oleg Nesterov wrote: Yes, but still I suspect wmb() is not enough. Note that try_to_wake_up() first checks (reads) the task-state, if (!(old_state state)) goto out; without

Re: [PATCH 3/8] sched: rt-group: interface

2008-02-23 Thread Peter Zijlstra
On Sat, 2008-02-23 at 11:48 -0800, Paul Menage wrote: On Mon, Feb 4, 2008 at 1:03 PM, Peter Zijlstra [EMAIL PROTECTED] wrote: +static int cpu_rt_runtime_write(struct cgroup *cgrp, struct cftype *cft, + struct file *file, +

RE: [RFC PATCH 0/8]: uninline uninline

2008-02-23 Thread Hua Zhong
Is there any reason they couldn't just be merged to mainline? I think it's a useful facility. ummm, now why did we made that decision... I think we decided that it's the sort of thing which one person can run once per few months and that will deliver its full value. I can maintain it

Re: [PATCH 3/8] sched: rt-group: interface

2008-02-23 Thread Paul Menage
On Sat, Feb 23, 2008 at 11:57 AM, Peter Zijlstra [EMAIL PROTECTED] wrote: If so, could we avoid that problem by using 0 rather than -1 as the unlimited value? It looks from what I've read in the Documentation changes as though 0 isn't really a meaningful value. 0 means no time, quite

Re: + kthread-add-a-missing-memory-barrier-to-kthread_stop.patch added to -mm tree

2008-02-23 Thread Linus Torvalds
On Sat, 23 Feb 2008, Dmitry Adamushko wrote: No, wmb is not enough. I've provided an explanation in the original thread. Here, let me answer your explanation from this thread (lots snipped to keep it concise): First off: Actually, there seems to be _no_ problem at all, provided a task to

Re: + kthread-add-a-missing-memory-barrier-to-kthread_stop.patch added to -mm tree

2008-02-23 Thread Linus Torvalds
On Sat, 23 Feb 2008, Dmitry Adamushko wrote: it's not a LOAD that escapes *out* of the region. It's a MODIFY that gets *in*: Not with the smp_wmb(). That's the whole point. Ie the patch I'm suggesting is sufficient is appended, and the point is that any write before the critical region

Re: [PATCH] percpu: fix DEBUG_PREEMPT per_cpu checking

2008-02-23 Thread Linus Torvalds
On Sat, 23 Feb 2008, Andrew Morton wrote: Hopefully Linus will apply the patch from Hugh's email, but that isn't the general solution to this increasingly worse problem. Done. Linus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [RFC 03/11] slim down debugfs

2008-02-23 Thread Hugh Dickins
On Sat, 23 Feb 2008, Al Viro wrote: On Tue, Feb 19, 2008 at 05:04:38AM +0100, Arnd Bergmann wrote: With most of debugfs now copied to generic code in libfs, we can remove the original copy and replace it with thin wrappers around libfs. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED]

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-23 Thread Rafael J. Wysocki
On Saturday, 23 of February 2008, Alan Stern wrote: On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: Unfortunately, I missed your Bugzilla comment at http://bugzilla.kernel.org/show_bug.cgi?id=10030#c28 Strange... But obviously you did see it eventually. Well, in the face of it, I'm

[PATCH 2/4] sis5513: fail early for unsupported chipsets

2008-02-23 Thread Bartlomiej Zolnierkiewicz
* Factor out chipset family detection from init_chipset_sis5513() to sis_find_family(). * Use sis_find_family() in sis5513_init_one() to fail early if the chipset is unsupported. * Keep a local copy sis5513_chipset in sis5513_init_one() and set .udma_mask according to chipset family. *

[PATCH 3/4] ide: sanitize handling of IDE_HFLAG_NO_SET_MODE host flag

2008-02-23 Thread Bartlomiej Zolnierkiewicz
* Check for IDE_HFLAG_NO_SET_MODE host flag in ide_set_pio(), ide_set_[pio,dma]_mode(), ide_set_xfer_rate() and set_pio_mode(). * Remove no longer needed IDE_HFLAG_NO_SET_MODE host flag checking from ide_tune_dma(). * Remove superfluous -set_pio_mode checking from do_special(). This is a

Re: [PATCH] percpu: fix DEBUG_PREEMPT per_cpu checking

2008-02-23 Thread Andrew Morton
On Sat, 23 Feb 2008 19:40:17 + (GMT) Hugh Dickins [EMAIL PROTECTED] wrote: 2.6.25-rc1 percpu changes broke CONFIG_DEBUG_PREEMPT's per_cpu checking on several architectures. On s390, sparc64 and x86 it's been weakened to not checking at all; whereas on powerpc64 it's become too strict,

[PATCH 1/4] it821x: fix kzalloc() failure handling

2008-02-23 Thread Bartlomiej Zolnierkiewicz
Allocate 'struct it821x_dev' objects for both ports in it821x_init_one(). Fixes potential OOPS in it821x_quirkproc() (uses 'itdev' unconditionally) and other problems ('itdev' is needed for correct operation of the driver). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] ---

[PATCH] Use userland-like functions for reading the ACPI table

2008-02-23 Thread Éric Piel
21/02/08 19:46, Éric Piel wrote/a écrit: In the mean time, here is a patch which should get the situation already much cleaner. It has been tested on various configs (with and without DSDT). Let me know if you think it is acceptable. It seems the patch looks ok for people around so here is a

Re: Lump xxxinit together with init if possible (was Re: Solve section mismatch for free_area_init_core.)

2008-02-23 Thread Alexander van Heukelum
On Sat, 23 Feb 2008 18:53:06 +0100, Sam Ravnborg [EMAIL PROTECTED] said: Hi Alexander. I more than less expected people to scream ugly, ugly!. That was my first thought and the reason why it stayed in my inbox for so long. But I could not find a better way to do it. We could do it in

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Jeff Garzik
James Bottomley wrote: This is the latest crop of bug fixes plus one new driver: mvsas. We're [...] Jeff Garzik (1): mvsas: Add Marvell 6440 SAS/SATA driver [...] Ke Wei (1): mvsas: convert from rough draft to working driver I know I am probably shooting myself in the foot

Re: [PATCH 3/8] sched: rt-group: interface

2008-02-23 Thread Peter Zijlstra
On Sat, 2008-02-23 at 12:02 -0800, Paul Menage wrote: On Sat, Feb 23, 2008 at 11:57 AM, Peter Zijlstra [EMAIL PROTECTED] wrote: If so, could we avoid that problem by using 0 rather than -1 as the unlimited value? It looks from what I've read in the Documentation changes as though 0

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Jeff Garzik
Jeff Garzik wrote: On the net driver side of things, I have a few new net drivers that I have queued for 2.6.26, because they did not make the merge window. This is inconsistent with your apparently policy. s/apparently/apparent/ Sometimes my fingers don't type the words that come out of my

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Linus Torvalds
On Sat, 23 Feb 2008, Jeff Garzik wrote: I know I am probably shooting myself in the foot here, since I am the original author of mvsas, but... Should we be adding new drivers during -rc? I'm personally of the opinion that a new driver that doesn't add anything but itself (ie no

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-23 Thread Soeren Sandmann
John Levon [EMAIL PROTECTED] writes: Soren wrote sysprof when he tried an earlier version of oprofile and found it slightly non-obvious. Instead of doing any of these things: This is not accurate. Sysprof started by me adding a hierarchical call view to speedprof, a SIGPROF profiler which was

Re: [PATCH 3/8] sched: rt-group: interface

2008-02-23 Thread Paul Menage
On Sat, Feb 23, 2008 at 12:26 PM, Peter Zijlstra [EMAIL PROTECTED] wrote: In that case I guess I'll have to add signed versions of the read_uint/write_uint methods. Yes, I looked at that, I found the interface somewhat unfortunate, it would mean growing the struct with two more

Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.

2008-02-23 Thread Alexey Zaytsev
On Sat, Feb 23, 2008 at 7:20 PM, Michael Buesch [EMAIL PROTECTED] wrote: On Saturday 23 February 2008 14:17:55 Alexey Zaytsev wrote: diff --git a/drivers/net/wireless/bcm43xx/Kconfig b/drivers/net/wireless/bcm43xx/Kconfig index 0159701..afb8f43 100644 ---

Re: runqueue locks in schedule()

2008-02-23 Thread Peter Zijlstra
On Sat, 2008-02-23 at 15:50 +0100, stephane eranian wrote: Peter, On Wed, 2008-01-16 at 16:29 -0800, stephane eranian wrote: Hello, As suggested by people on this list, I have changed perfmon2 to use the high resolution timers as the interface to allow timeout-based

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-23 Thread Andrew Morton
On 23 Feb 2008 21:15:52 +0100 Soeren Sandmann [EMAIL PROTECTED] wrote: It was only later I tried oprofile and found it not only much more difficult to use, but also much less useful when I did get it to work. Could we please be very careful to not conflate oprofile's kernel support with

Re: Hang on suspend

2008-02-23 Thread Rafael J. Wysocki
On Thursday, 21 of February 2008, Julian Blake Kongslie wrote: I'm getting a hang at suspend on 2.6.25-rc2. Booting with no_console_suspend let me catch the error, which I photographed and transcribed (hopefully without error) below. This is a Lenovo Thinkpad T43p. I've attached my config

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Andrew Morton
On Sat, 23 Feb 2008 12:31:02 -0800 (PST) Linus Torvalds [EMAIL PROTECTED] wrote: On Sat, 23 Feb 2008, Jeff Garzik wrote: I know I am probably shooting myself in the foot here, since I am the original author of mvsas, but... Should we be adding new drivers during -rc? I'm

Re: [PATCH] Use userland-like functions for reading the ACPI table

2008-02-23 Thread Linus Torvalds
On Sat, 23 Feb 2008, Éric Piel wrote: As recommended by Christoph Hellwig, even if we can't rely on the userspace firmware loader so early at boot, at least use normal syscall (as in init/do_mounts_*.c). Similarly, use kfree() instead of ACPI_FREE(). So I'm missing a lot of the background

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread James Bottomley
On Sat, 2008-02-23 at 12:31 -0800, Linus Torvalds wrote: On Sat, 23 Feb 2008, Jeff Garzik wrote: I know I am probably shooting myself in the foot here, since I am the original author of mvsas, but... Should we be adding new drivers during -rc? I'm personally of the opinion

Re: [RFC PATCH 0/8]: uninline uninline

2008-02-23 Thread Andi Kleen
Is it possible to catch this automatically, like, by re-defining likely/unlikely to the raw form in specific file(s)? Sure it would be possible to define a IN_VDSO symbol in all vdso related files and then do that. Might be useful for other things too. vdso has some very specific requirements.

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-23 Thread Thomas Gleixner
On Sat, 23 Feb 2008, Andrew Morton wrote: On Thu, 21 Feb 2008 16:50:35 + David Howells [EMAIL PROTECTED] wrote: From: David Howells [EMAIL PROTECTED] The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make it instead hand 64-bit unsigned values. This gets

[PATCH, 3rd resend] documentation: atomic_add_unless() doesn't imply mb() on failure

2008-02-23 Thread Oleg Nesterov
(sorry for being offtpoic, but while experts are here...) A typical implementation of atomic_add_unless() can return 0 immediately after the first atomic_read() (before doing cmpxchg). In that case it doesn't provide any barrier semantics. See include/asm-ia64/atomic.h as an example. We should

[ANNOUNCE] GIT 1.5.4.3

2008-02-23 Thread Junio C Hamano
The latest maintenance release GIT 1.5.4.3 is available at the usual places: http://www.kernel.org/pub/software/scm/git/ git-1.5.4.3.tar.{gz,bz2} (tarball) git-htmldocs-1.5.4.3.tar.{gz,bz2} (preformatted docs) git-manpages-1.5.4.3.tar.{gz,bz2}

Re: + kthread-add-a-missing-memory-barrier-to-kthread_stop.patch added to -mm tree

2008-02-23 Thread Dmitry Adamushko
On 23/02/2008, Linus Torvalds [EMAIL PROTECTED] wrote: On Sat, 23 Feb 2008, Dmitry Adamushko wrote: it's not a LOAD that escapes *out* of the region. It's a MODIFY that gets *in*: Not with the smp_wmb(). That's the whole point. Ie the patch I'm suggesting is sufficient is

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-23 Thread Andrew Morton
On Sat, 23 Feb 2008 22:01:55 +0100 (CET) Thomas Gleixner [EMAIL PROTECTED] wrote: On Sat, 23 Feb 2008, Andrew Morton wrote: On Thu, 21 Feb 2008 16:50:35 + David Howells [EMAIL PROTECTED] wrote: From: David Howells [EMAIL PROTECTED] The kernel NTP code shouldn't hand 64-bit

[Fixed PATCH] hpt366: fix section mismatch warnings

2008-02-23 Thread Sam Ravnborg
hpt366: fix section mismatch warnings Fix following warnings: WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference from the variable hpt37x_info.0 to the variable .devinit.data:hpt370 WARNING: o-sparc64/vmlinux.o(.data+0x195a40): Section mismatch in reference from the

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-23 Thread Olof Johansson
On Fri, Feb 22, 2008 at 12:16:16PM +0100, Jochen Friedrich wrote: Fortunately, I2c no longer uses numeric device IDs but names. So what are the alternatives? 1. modify the I2c subsystem to accept OF names additionally to I2c names (proposed by Jon smirl). Sounds like Jean isn't very

Re: [PATCH] More accessible usage of custom flags

2008-02-23 Thread Nicholas Marquez
Does anyone else have any input on this? Tips, suggestions, ideas, comments, constructive criticism, anything at all. I am, however, trying to avoid a flame war. ~Nicholas (Alex) Marquez [EMAIL PROTECTED] On Sat, Feb 16, 2008 at 9:52 PM, Nicholas Marquez [EMAIL PROTECTED] wrote: I submitted

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Alexey Zaytsev
On Sat, Feb 23, 2008 at 7:27 PM, Michael Buesch [EMAIL PROTECTED] wrote: On Saturday 23 February 2008 12:07:51 Ingo Molnar wrote: I have to say, after having observed multiple incidents around b43 in the past few months you are one of the worst driver maintainers i've ever seen on lkml:

Re: 2.6.24 panics initializing ne2k in mips.

2008-02-23 Thread Rob Landley
On Saturday 23 February 2008 01:56:42 Samuel Masham wrote: On Sat, Feb 23, 2008 at 7:19 AM, Rob Landley [EMAIL PROTECTED] wrote: The patches that fixed it for me were: http://kernel.org/hg/index.cgi/linux-2.6/rev/85295 http://kernel.org/hg/index.cgi/linux-2.6/rev/85296 Which, as

Re: 2.6.25-rc2 hangs after Suspending console(s)

2008-02-23 Thread Rafael J. Wysocki
On Wednesday, 20 of February 2008, Tino Keitel wrote: On Tue, Feb 19, 2008 at 09:52:22 +0100, Tino Keitel wrote: On Mon, Feb 18, 2008 at 20:49:04 +0100, Pavel Machek wrote: On Mon 2008-02-18 01:28:15, Tino Keitel wrote: Hi folks, with 2.6.25-rc2, my Mac mini Core Duo hangs at

Re: [PATCH] More accessible usage of custom flags

2008-02-23 Thread Nick Andrew
On Sat, Feb 23, 2008 at 04:28:50PM -0500, Nicholas Marquez wrote: Does anyone else have any input on this? Tips, suggestions, ideas, comments, constructive criticism, anything at all. I am, however, trying to avoid a flame war. I missed it the first time you posted it, so thanks for

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-23 Thread Thomas Gleixner
On Sat, 23 Feb 2008, Andrew Morton wrote: Thomas, do you consider ntp to fall under git-hrt? I'll pick it up. OK. And this is still git+ssh://master.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-hrt.git#mm, yes? Yes Can we please define the scope of that tree? Primary

Re: 2.6.25-rc2 + smartd = hang

2008-02-23 Thread Anders Eriksson
[EMAIL PROTECTED] said: But at this point libata is working much better than the old IDE stuff, and it really is worth moving things over if you can. Ok, I'll take a stab at that tomorrow. Two things... Having switched to ata_piix i can confirm that smartd doesn't hand the system anymore.

Re: 2.6.25-rc2 + smartd = hang

2008-02-23 Thread Anders Eriksson
[EMAIL PROTECTED] said: the comment on the very top of drivers/ata says: tristate Serial ATA (prod) and Parallel ATA (experimental) drivers That's the one I was referring to. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Michael Buesch
On Saturday 23 February 2008 22:32:46 Alexey Zaytsev wrote: The insults being? A few quotes, please. If you really want to know, the Because the new driver works, if you just set it up right. for me was clearly a hint that I'm just an other imcompetent user, who can't even follow the

Re: [PATCH] More accessible usage of custom flags

2008-02-23 Thread Nicholas Marquez
First of all, thanks for the input! On Sat, Feb 23, 2008 at 5:04 PM, Nick Andrew [EMAIL PROTECTED] wrote: On Sat, Feb 23, 2008 at 04:28:50PM -0500, Nicholas Marquez wrote: Does anyone else have any input on this? Tips, suggestions, ideas, comments, constructive criticism, anything at all.

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Olof Johansson
Hi, On Sat, Feb 23, 2008 at 09:13:33AM -0600, James Bottomley wrote: Jeff Garzik (1): mvsas: Add Marvell 6440 SAS/SATA driver [...] drivers/scsi/mvsas.c| 2981 I just noticed that the file permissions on that file are 755 in

Re: 2.6.25-rc2 + smartd = hang

2008-02-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 23 February 2008, Anders Eriksson wrote: [EMAIL PROTECTED] said: But at this point libata is working much better than the old IDE stuff, and it really is worth moving things over if you can. Ok, I'll take a stab at that tomorrow. Two things... Having switched to

[PATCH try #1] Kconfig: cleanup block/Kconfig help descriptions

2008-02-23 Thread Nick Andrew
Modify the help descriptions of block/Kconfig for clarity, accuracy and consistency. Refactor the BLOCK description a bit. The wording This permits ... to be removed isn't quite right; the block layer is removed when the option is disabled, whereas most descriptions talk about what happens when

[PATCH] x86: fix build on non-C locales.

2008-02-23 Thread Priit Laes
x86: fix build on some non-C locales[1]. For some locales regex range [a-zA-Z] does not work as it is supposed to so we have to specify LANG=C to make it work as intended. [1] http://en.wikipedia.org/wiki/Estonian_alphabet Signed-off-by: Priit Laes [EMAIL PROTECTED] diff --git

[PATCH 06/10] CGroup API files: Add cgroup map data type

2008-02-23 Thread menage
Adds a new type of supported control file representation, a map from strings to u64 values. Each map entry is printed as a line in a similar format to /proc/vmstat, i.e. $key $value\n Signed-off-by: Paul Menage [EMAIL PROTECTED] --- include/linux/cgroup.h | 19 +

[PATCH 00/10] CGroup API files: Various cleanup to CGroup control files

2008-02-23 Thread menage
This patchset is a roll-up of the non-contraversial items of the various patches that I've sent out recently, fixed according to the feedback received. In summary they are: - general rename of read_uint/write_uint to read_u64/write_u64 - use these methods for cpusets and memory controller files

[PATCH 02/10] CGroup API files: Add res_counter_read_u64()

2008-02-23 Thread menage
Adds a function for returning the value of a resource counter member, in a form suitable for use in a cgroup read_u64 control file method. Signed-off-by: Paul Menage [EMAIL PROTECTED] --- include/linux/res_counter.h |5 - kernel/res_counter.c|5 + 2 files changed, 9

[PATCH 04/10] CGroup API files: Strip all trailing whitespace in cgroup_write_u64

2008-02-23 Thread menage
This removes the need for people to remember to pass the -n flag to echo when writing values to cgroup control files. Signed-off-by: Paul Menage [EMAIL PROTECTED] --- kernel/cgroup.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index: cgroup-2.6.25-rc2-mm1/kernel/cgroup.c

[PATCH 08/10] CGroup API files: Drop mem_cgroup_force_empty()

2008-02-23 Thread menage
This function isn't needed - a NULL pointer in the cftype read function will result in the same EINVAL response to userspace. Signed-off-by: Paul Menage [EMAIL PROTECTED] --- mm/memcontrol.c | 14 -- 1 file changed, 14 deletions(-) Index: cgroup-2.6.25-rc2-mm1/mm/memcontrol.c

[PATCH 07/10] CGroup API files: Use cgroup map for memcontrol stats file

2008-02-23 Thread menage
Remove the seq_file boilerplate used to construct the memcontrol stats map, and instead use the new map representation for cgroup control files Signed-off-by: Paul Menage [EMAIL PROTECTED] --- mm/memcontrol.c | 30 ++ 1 file changed, 6 insertions(+), 24

[PATCH 05/10] CGroup API files: Update cpusets to use cgroup structured file API

2008-02-23 Thread menage
Many of the cpusets control files are simple integer values, which don't require the overhead of memory allocations for reads and writes. Move the handlers for these control files into cpuset_read_u64() and cpuset_write_u64(). Signed-off-by: Paul Menage [EMAIL PROTECTED] --- kernel/cpuset.c |

[PATCH 09/10] CGroup API files: Move releasable to cgroup_debug subsystem

2008-02-23 Thread menage
The releasable control file provided by the cgroup framework exports the state of a per-cgroup flag that's related to the notify-on-release feature. This isn't really generally useful, unless you're trying to debug this particular feature of cgroups. This patch moves the releasable file to the

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-23 Thread Alan Stern
On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: Ultimately no, it's not. However, we are now late in the -rc2 time frame and the release of -rc3 seems to be imminent. At this point, IMO, that's the safest thing to do. BTW, appended is the patch I'd like to get applied. In the interest of

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Jeff Garzik
Olof Johansson wrote: Hi, On Sat, Feb 23, 2008 at 09:13:33AM -0600, James Bottomley wrote: Jeff Garzik (1): mvsas: Add Marvell 6440 SAS/SATA driver [...] drivers/scsi/mvsas.c| 2981 I just noticed that the file permissions on that

Re: [PATCH] More accessible usage of custom flags

2008-02-23 Thread Nick Andrew
On Sat, Feb 23, 2008 at 05:28:23PM -0500, Nicholas Marquez wrote: First of all, thanks for the input! On Sat, Feb 23, 2008 at 5:04 PM, Nick Andrew [EMAIL PROTECTED] wrote: On Sat, Feb 23, 2008 at 04:28:50PM -0500, Nicholas Marquez wrote: There are a few places in the Makefile where options

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Jeff Garzik
Andrew Morton wrote: On Sat, 23 Feb 2008 12:31:02 -0800 (PST) Linus Torvalds [EMAIL PROTECTED] wrote: On Sat, 23 Feb 2008, Jeff Garzik wrote: I know I am probably shooting myself in the foot here, since I am the original author of mvsas, but... Should we be adding new drivers during -rc?

jffs2: -ENOSPC when truncating file?!

2008-02-23 Thread Pavel Machek
Hi! I'm trying to free space by truncating big file, and I get: [EMAIL PROTECTED]:~# ls -al gps.nmea -rw-r--r--1 root root 2332070 Feb 19 22:13 gps.nmea [EMAIL PROTECTED]:~# gps.nmea -sh: cannot create gps.nmea: No space left on device [EMAIL PROTECTED]:~# rm gps.nmea [EMAIL

[PATCH 10/10] CGroup API files: Make CGROUP_DEBUG default to off

2008-02-23 Thread menage
The cgroup debug subsystem isn't generally useful for users. It should default to n. Signed-off-by: Paul Menage [EMAIL PROTECTED] --- init/Kconfig |1 + 1 file changed, 1 insertion(+) Index: cgroup-2.6.25-rc2-mm1/init/Kconfig

[PATCH 01/10] CGroup API files: Rename read/write_uint methods to read_write_u64

2008-02-23 Thread menage
Several people have justifiably complained that the _uint suffix is inappropriate for functions that handle u64 values, so this patch just renames all these functions and their users to have the suffic _u64. Signed-off-by: Paul Menage [EMAIL PROTECTED] --- include/linux/cgroup.h |8

[PATCH 03/10] CGroup API files: Use read_u64 in memory controller

2008-02-23 Thread menage
Update the memory controller to use read_u64 for its limit/usage/failcnt control files, calling the new res_counter_read_u64() function. Signed-off-by: Paul Menage [EMAIL PROTECTED] --- mm/memcontrol.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) Index:

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-23 Thread Rafael J. Wysocki
On Sunday, 24 of February 2008, Alan Stern wrote: On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: Ultimately no, it's not. However, we are now late in the -rc2 time frame and the release of -rc3 seems to be imminent. At this point, IMO, that's the safest thing to do. BTW, appended is

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread James Bottomley
On Sat, 2008-02-23 at 18:31 -0500, Jeff Garzik wrote: Olof Johansson wrote: Hi, On Sat, Feb 23, 2008 at 09:13:33AM -0600, James Bottomley wrote: Jeff Garzik (1): mvsas: Add Marvell 6440 SAS/SATA driver [...] drivers/scsi/mvsas.c| 2981

Re: jffs2: -ENOSPC when truncating file?!

2008-02-23 Thread David Woodhouse
On Sun, 2008-02-24 at 00:57 +0100, Pavel Machek wrote: Hi! I'm trying to free space by truncating big file, and I get: [EMAIL PROTECTED]:~# ls -al gps.nmea -rw-r--r--1 root root 2332070 Feb 19 22:13 gps.nmea [EMAIL PROTECTED]:~# gps.nmea -sh: cannot create gps.nmea: No

Re: 2.6.25-rc2-mm1: WARNING at arch/x86/mm/ioremap.c:129

2008-02-23 Thread Gabriel C
Laurent Riffard wrote: Le 16.02.2008 09:25, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ Got this in dmesg output: [ cut here ] WARNING: at arch/x86/mm/ioremap.c:129 __ioremap+0xc7/0x182() Modules

boot_delay broken ?

2008-02-23 Thread Dave Jones
The boot_delay switch seems to be behaving strangely in the current -git. Setting it to =10 makes the output 'bursty' it becomes slow for some printk's whilst others scroll by at regular speed. Setting it any higher than that seems to make it pause for a really long time before it outputs any

Tabs, spaces, indent and 80 character lines

2008-02-23 Thread Richard Knutsson
Good evening In the thread Merging of completely unreviewed drivers I got reminded of the use tabs not spaces-mentality. My question is: why? The tab-character serves us well as a indent-indicator, but for some reason there has been focus on its relation to spaces. On the question How long

Re: [PATCH] macb: Fix speed setting

2008-02-23 Thread Haavard Skinnemoen
On Sat, 23 Feb 2008 00:03:23 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 21 Feb 2008 17:41:05 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: From: Atsushi Nemoto [EMAIL PROTECTED] Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by conversion to generic PHY

Re: [BUG] snd-hda-intel

2008-02-23 Thread Dave Jones
On Wed, Feb 13, 2008 at 03:31:31PM +0100, Takashi Iwai wrote: At Wed, 13 Feb 2008 15:25:14 +0100, Peter Zijlstra wrote: lspci -vvv: 00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 02) Is this a regression, i.e. did you get similar

Re: [PATCH] atmel_spi: Fix clock polarity

2008-02-23 Thread Haavard Skinnemoen
On Sat, 23 Feb 2008 00:05:07 -0800 Andrew Morton [EMAIL PROTECTED] wrote: I had it queued for 2.6.26 which I guess was wrong. I'll bump it into 2.6.25. Thanks! Is it needed in 2.6.24.x? I think so. The last time that code was changed was before 2.6.23 AFAICT, so perhaps 2.6.23.x as well.

Re: [PATCH] Use userland-like functions for reading the ACPI table

2008-02-23 Thread Christoph Hellwig
On Sat, Feb 23, 2008 at 12:45:38PM -0800, Linus Torvalds wrote: As recommended by Christoph Hellwig, even if we can't rely on the userspace firmware loader so early at boot, at least use normal syscall (as in init/do_mounts_*.c). Similarly, use kfree() instead of ACPI_FREE(). So I'm

2.6.24.2: 4KSTACKS + PCA403CD IDE CD + pcdrw + mount + PREEMPT - stack overflow

2008-02-23 Thread Nix
A loop mount/umounting a pcdrw or iso9660 (through the pktcdvd device) sees a stack overflow in four or five tries. Doing the same thing with the same CD in a normal non-pktcdvd-mounted drive doesn't cause a crash. Here's a couple of oopses. config follows. (There are a wide variety. Some I

Re: dma engine drivers for 2.6.25?

2008-02-23 Thread Dan Williams
On Thu, Feb 14, 2008 at 10:29 PM, Dan Williams [EMAIL PROTECTED] wrote: On Thu, Feb 14, 2008 at 8:44 PM, Kumar Gala [EMAIL PROTECTED] wrote: On Feb 14, 2008, at 12:14 PM, Dan Williams wrote: On Wed, Feb 13, 2008 at 8:52 PM, Kumar Gala [EMAIL PROTECTED] wrote: Dan,

[patch 2/2] x86,fpu: lazy allocation of FPU area

2008-02-23 Thread Suresh Siddha
Only allocate the FPU area when the application actually uses FPU, i.e., in the first lazy FPU trap. This could save memory for non-fpu using apps. Signed-off-by: Suresh Siddha [EMAIL PROTECTED] Cc: Arjan van de Ven [EMAIL PROTECTED] --- Index: linux-2.6-x86/arch/x86/kernel/i387.c

[patch 1/2] x86,fpu: split FPU state from task struct

2008-02-23 Thread Suresh Siddha
Split the FPU save area from the task struct. This allows easy migration of FPU context, and it's generally cleaner. It also allows the following two optimizations: 1) only allocate when the application actually uses FPU, so in the first lazy FPU trap. This could save memory for non-fpu using

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-23 Thread Pekka Enberg
Hi Andrew, Andrew Morton wrote: I didn't need to write a new kernel module to enable that thirteen-character shell script, and I don't believe one needs to write a new kernel module to put a nice easy-to-use GUI around oprofile either. This is one of those

Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

2008-02-23 Thread Balbir Singh
Andrew Morton wrote: On Sat, 23 Feb 2008 06:33:34 -0800 Paul Menage [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 8:29 PM, Balbir Singh [EMAIL PROTECTED] wrote: Looks good, except for the name uint(), can we make it u64(). Integers are 32 bit on both ILP32 and LP64, but we really

Re: 2.6.25-rc2-mm1: WARNING at arch/x86/mm/ioremap.c:129

2008-02-23 Thread Arjan van de Ven
Gabriel C wrote: Laurent Riffard wrote: Le 16.02.2008 09:25, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ [..] I'm getting that in mainline now on one of my older laptops also. we fixed the cause of the machine you

Re: [patch 1/2] x86,fpu: split FPU state from task struct

2008-02-23 Thread Christoph Hellwig
On Sat, Feb 23, 2008 at 06:34:38PM -0800, Suresh Siddha wrote: Split the FPU save area from the task struct. This allows easy migration of FPU context, and it's generally cleaner. It also allows the following two optimizations: 1) only allocate when the application actually uses FPU, so in

Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

2008-02-23 Thread Paul Menage
On Sat, Feb 23, 2008 at 6:47 PM, Balbir Singh [EMAIL PROTECTED] wrote: res_counter_read_u64() I'd also want to rename all the other *read_uint functions/fields to *read_u64 too. Can I do that in a separate patch? Sounds sensible to me. Sure, fair enough. Actually, since

Please, put 64-bit counter per task and incr.by.one each ctxt switch.

2008-02-23 Thread J.C. Pizarro
Hello, We will need 64 bit counters of the slow context switches, one counter for each new created task (e.g. u64 ctxt_switch_counts;) We will only need them during the lifetime of the tasks. To increment by +1 the task's 64 bit counter (it's fast) each one slow context switch.

Re: [patch 2/2] x86,fpu: lazy allocation of FPU area

2008-02-23 Thread Christoph Hellwig
On Sat, Feb 23, 2008 at 06:34:39PM -0800, Suresh Siddha wrote: + if (!tsk-thread.cntxt) +tsk-thread.cntxt = alloc_cntxt_struct(); Please use tabs, not spaces for indentation. +union thread_cntxt *alloc_cntxt_struct(void) +{ + return

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-23 Thread Nicholas Miell
On Sun, 2008-02-24 at 04:49 +0200, Pekka Enberg wrote: Hi Andrew, Andrew Morton wrote: I didn't need to write a new kernel module to enable that thirteen-character shell script, and I don't believe one needs to write a new kernel module to put a nice easy-to-use GUI around oprofile

Re: Please, put 64-bit counter per task and incr.by.one each ctxt switch.

2008-02-23 Thread Rik van Riel
On Sun, 24 Feb 2008 04:08:38 +0100 J.C. Pizarro [EMAIL PROTECTED] wrote: We will need 64 bit counters of the slow context switches, one counter for each new created task (e.g. u64 ctxt_switch_counts;) Please send a patch ... I will explain your later why of it. ... and explain exactly why

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-23 Thread Alan Stern
On Sun, 24 Feb 2008, Rafael J. Wysocki wrote: On Sunday, 24 of February 2008, Alan Stern wrote: On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: Ultimately no, it's not. However, we are now late in the -rc2 time frame and the release of -rc3 seems to be imminent. At this point,

[2.6.25 patch] fix drivers/usb/host/u132-hcd.c compilation

2008-02-23 Thread Adrian Bunk
This patch fixes the following compile error caused by commit 3a2d5b700132f35401f1d9e22fe3c2cab02c2549: -- snip -- ... CC drivers/usb/host/u132-hcd.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/usb/host/u132-hcd.c: In function ‘u132_suspend’:

Re: Tiny cpusets -- cpusets for small systems?

2008-02-23 Thread Max Krasnyansky
Hi Paul, A couple of proposals have been made recently by people working Linux on smaller systems, for improving realtime isolation and memory pressure handling: (1) cpu isolation for hard(er) realtime http://lkml.org/lkml/2008/2/21/517 Max Krasnyanskiy [EMAIL PROTECTED]

Re: [PATCH 00/16] (Resend) Use get_personality()

2008-02-23 Thread WANG Cong
From: Andrew Morton [EMAIL PROTECTED] Subject: Re: [PATCH 00/16] (Resend) Use get_personality() Date: Sat, 23 Feb 2008 11:16:29 -0800 Message-ID: [EMAIL PROTECTED] On Sat, 23 Feb 2008 13:37:31 -0500 Christoph Hellwig [EMAIL PROTECTED] wrote: On Sat, Feb 23, 2008 at 12:27:10PM +0300, Alexey

Re: Please, put 64-bit counter per task and incr.by.one each ctxt switch.

2008-02-23 Thread J.C. Pizarro
On 2008/2/24, Rik van Riel [EMAIL PROTECTED] wrote: On Sun, 24 Feb 2008 04:08:38 +0100 J.C. Pizarro [EMAIL PROTECTED] wrote: We will need 64 bit counters of the slow context switches, one counter for each new created task (e.g. u64 ctxt_switch_counts;) Please send a patch ... diff

Re: [PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i915 hibernation patch (was: Re: 2.6.25-rc2 System no longer ...))

2008-02-23 Thread Mirco Tischler
On Sa, 2008-02-23 at 19:13 +0100, Rafael J. Wysocki wrote: Index: linux-2.6/drivers/usb/host/u132-hcd.c === --- linux-2.6.orig/drivers/usb/host/u132-hcd.c +++ linux-2.6/drivers/usb/host/u132-hcd.c @@ -3214,14 +3214,19 @@ static

Re: Merging of completely unreviewed drivers

2008-02-23 Thread David Newall
Pavel Machek wrote: On Sat 2008-02-23 23:08:58, David Newall wrote: Pavel Machek wrote: On Fri 2008-02-22 23:44:09, Krzysztof Halasa wrote: Pavel Machek [EMAIL PROTECTED] writes: Zaurus is one example, second is small screen where you need big font to

Re: [linux-pm] [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-23 Thread Alan Stern
On Sat, 23 Feb 2008, Alan Stern wrote: It happened in a workqueue. There could be lots of similar cases: Some interrupt-driven event causes a hotplug action. Since the action can't be carried out in interrupt context, the driver has no choice but to defer it to a workqueue or kernel

Re: Please, put 64-bit counter per task and incr.by.one each ctxt switch.

2008-02-23 Thread Rik van Riel
On Sun, 24 Feb 2008 05:08:46 +0100 J.C. Pizarro [EMAIL PROTECTED] wrote: OK, one last reply on the (overly optimistic?) assumption that you are not a troll. +++ linux-2.6_git-20080224/include/linux/sched.h2008-02-24 04:50:18.0 +0100 @@ -1007,6 +1007,12 @@ struct

[PATCH] scsi/mvsas.c needs to include linux/ctype.h fo isalnum

2008-02-23 Thread Stephen Rothwell
Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/scsi/mvsas.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Discovered while compiling Linus' tree in preparation for today's linux-next. diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c index 30e20e6..de762f4

Re: Merging of completely unreviewed drivers

2008-02-23 Thread David Newall
Jan Engelhardt wrote: static void blah(void) { if (foo) { bar; bar2; return; } if (this) { that; that2; return; } /* yay, got rid of two levels of indent! */ good

<    3   4   5   6   7   8   9   >