Re: [PATCH] cdc-phonet: Don't leak in usbpn_open

2012-08-08 Thread David Miller
From: "Rémi Denis-Courmont" Date: Wed, 8 Aug 2012 10:12:06 +0300 > Le mercredi 8 août 2012 00:56:26 Jesper Juhl, vous avez écrit : >> We allocate memory for 'req' with usb_alloc_urb() and then test >> 'if (!req || rx_submit(pnd, req, GFP_KERNEL | __GFP_COLD))'. >> If we enter that branch due to

Re: [PATCH] batman-adv: Fix mem leak in the batadv_tt_local_event() function

2012-08-08 Thread David Miller
From: Antonio Quartulli Date: Tue, 7 Aug 2012 20:50:36 +0200 > On Tue, Aug 07, 2012 at 08:32:34PM +0200, Jesper Juhl wrote: >> Memory is allocated for 'tt_change_node' with kmalloc(). >> 'tt_change_node' may go out of scope really being used for anything >> (except have a few members

Re: [PATCH RESEND] sched: add missing group change to qfq_change_class

2012-08-08 Thread David Miller
From: Paolo Valente Date: Tue, 7 Aug 2012 19:27:25 +0200 > [Resending again, as the text was corrupted by the email client] > > To speed up operations, QFQ internally divides classes into > groups. Which group a class belongs to depends on the ratio between > the maximum packet length and the

Re: [PATCH v5 08/12] block: Introduce new bio_split()

2012-08-08 Thread Tejun Heo
Hello, On Mon, Aug 06, 2012 at 03:08:37PM -0700, Kent Overstreet wrote: > /** > + * bio_split - split a bio > + * @bio: bio to split > + * @sectors: number of sectors to split from the front of @bio > + * @gfp: gfp mask > + * @bs: bio set to allocate from > + * > + *

[PATCH v6 2/3] virtio_balloon: introduce migration primitives to balloon pages

2012-08-08 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. Besides

[PATCH v6 0/3] make balloon pages movable by compaction

2012-08-08 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This

[PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-08 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This

[PATCH v6 3/3] mm: add vm event counters for balloon pages compaction

2012-08-08 Thread Rafael Aquini
This patch is only for testing report purposes and shall be dropped in case of the rest of this patchset getting accepted for merging. Signed-off-by: Rafael Aquini --- drivers/virtio/virtio_balloon.c | 1 + include/linux/vm_event_item.h | 2 ++ mm/compaction.c | 1 +

Re: [PATCH] netvm: check for page == NULL when propogating the skb->pfmemalloc flag

2012-08-08 Thread David Miller
From: Mel Gorman Date: Tue, 7 Aug 2012 09:55:55 +0100 > Commit [c48a11c7: netvm: propagate page->pfmemalloc to skb] is responsible > for the following bug triggered by a xen network driver ... > The problem is that the xenfront driver is passing a NULL page to > __skb_fill_page_desc() which was

Re: [RESEND][PATCH] drivers: net: irda: bfin_sir: fix compile error

2012-08-08 Thread David Miller
From: Bob Liu Date: Tue, 7 Aug 2012 10:08:36 +0800 > From: Sonic Zhang > > Bit IREN is replaced by UMOD_IRDA and UMOD_MASK since blackfin 60x added, but > this driver didn't update which will cause bfin_sir build error: > > drivers/net/irda/bfin_sir.c:161:9: error: 'IREN' undeclared (first

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Arun Sharma
On 8/8/12 12:16 PM, Arun Sharma wrote: and therefore breaks the invariant period == period_self in the default mode (no sort inclusive). hist_entry__decay() also needs an update to maintain the invariant. --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -138,6 +138,7 @@

Re: [tip:x86:fpu 2/2] arch/x86/kernel/signal.c:626:4: error: implicit declaration of function '__setup_frame'

2012-08-08 Thread H. Peter Anvin
On 07/26/2012 10:48 AM, Suresh Siddha wrote: Appended the patch for this. Thanks! --- From: Suresh Siddha Subject: x86, fpu: fix x86_64 build without CONFIG_IA32_EMULATION Fengguang's automated build reported some compilation failures: arch/x86/kernel/signal.c: In function 'setup_rt_frame':

Re: linux-next: removal of some trees

2012-08-08 Thread Stephen Rothwell
Hi, On Tue, 07 Aug 2012 17:08:18 +0900 Kukjin Kim wrote: > > I think, now, the 'samsung' can be removed from linux-next but I'm not sure > about 'bjdooks-i2c'. If so, please change the name of my tree 's5p' to > 'samsung'. > >

Re: [PATCH v5 06/12] block: Add an explicit bio flag for bios that own their bvec

2012-08-08 Thread Tejun Heo
On Mon, Aug 06, 2012 at 03:08:35PM -0700, Kent Overstreet wrote: > This is for the new bio splitting code. When we split a bio, if the > split occured on a bvec boundry we reuse the bvec for the new bio. But > that means bio_free() can't free it, hence the explicit flag. > > Signed-off-by: Kent

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-08 Thread David Rientjes
On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: > [media] radio-shark: New driver for the Griffin radioSHARK USB radio > receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined! ERROR:

Re: [PATCH v5 01/12] block: Generalized bio pool freeing

2012-08-08 Thread Tejun Heo
On Mon, Aug 06, 2012 at 03:08:30PM -0700, Kent Overstreet wrote: > @@ -422,7 +409,11 @@ void bio_put(struct bio *bio) > if (atomic_dec_and_test(>bi_cnt)) { > bio_disassociate_task(bio); > bio->bi_next = NULL; > - bio->bi_destructor(bio); > + > +

Re: [PATCH v5 05/12] block: Kill bi_destructor

2012-08-08 Thread Tejun Heo
Hello, On Mon, Aug 06, 2012 at 03:08:34PM -0700, Kent Overstreet wrote: > Now that we've got generic code for freeing bios allocated from bio > pools, this isn't needed anymore. > > This also changes the semantics of bio_free() a bit - it now also frees > bios allocated by bio_kmalloc(). It's

[PATCH] x86, pci: Fix all early PCI scans to check the vendor ID first

2012-08-08 Thread Andi Kleen
From: Andi Kleen According to the Intel PCI experts it's not safe to check any other field than vendor ID for 0x when doing PCI scans to see if the device exists. Several of the early PCI scans violated this. I changed them all to always check the vendor ID first. Signed-off-by: Andi Kleen

Re: [PATCH 18/41] TTY: pty, switch to tty_alloc_driver

2012-08-08 Thread Alan Cox
> this and 19/41. The merge with DEVPTS_MEM (the termios case) needs > devpts_kill_index to be moved from tty_release to > pty_driver->ops->cleanup/shutdown, but I don't feel comfortable to do it > now since it needs some testing. So I would add this to TODO and will > send it after the next merge

Re: [PATCH v5 04/12] pktcdvd: Switch to bio_kmalloc()

2012-08-08 Thread Tejun Heo
Hello, On Mon, Aug 06, 2012 at 03:08:33PM -0700, Kent Overstreet wrote: > This is prep work for killing bi_destructor - previously, pktcdvd had > its own pkt_bio_alloc which was basically duplication bio_kmalloc(), > necessitating its own bi_destructor implementation. > > v5: Un-reorder some

Re: [PATCH v5 03/12] block: Add bio_reset()

2012-08-08 Thread Tejun Heo
Hello, On Mon, Aug 06, 2012 at 03:08:32PM -0700, Kent Overstreet wrote: > Reusing bios is something that's been highly frowned upon in the past, > but driver code keeps doing it anyways. If it's going to happen anyways, > we should provide a generic method. > > This'll help with getting rid of

Re: UIO: missing resource mapping

2012-08-08 Thread Hans J. Koch
On Wed, Jul 18, 2012 at 12:40:47PM +0200, Dominic Eschweiler wrote: > Am Montag, den 16.07.2012, 23:58 +0200 schrieb Hans J. Koch: > > Try to hack up a patch to add generic BAR mapping to uio_pci_generic.c > > and post it for review. > > > > Here we go ... Thank you very much for your work. I'm

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-08 Thread Tejun Heo
Hello, On Mon, Aug 06, 2012 at 03:08:31PM -0700, Kent Overstreet wrote: > Previously, dm_rq_clone_bio_info needed to be freed by the bio's > destructor to avoid a memory leak in the blk_rq_prep_clone() error path. > This gets rid of a memory allocation and means we can kill >

Re: [PATCH] regulator: tps6586x: correct vin pin for sm0/sm1/sm2

2012-08-08 Thread Stephen Warren
On 07/24/2012 02:18 AM, Laxman Dewangan wrote: > As per datasheet, the vin pin for the regulator is named > as vin_sm0, vin_sm1, vin_sm2 for sm0, sm1 and sm2 respectively. > > Correcting the names in driver and documentation to match with > datasheet. Mark, This patch was in next-20120803, but

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 16:46 -0400, Paul Moore wrote: > On Wednesday, August 08, 2012 10:32:52 PM Eric Dumazet wrote: > > On Wed, 2012-08-08 at 22:09 +0200, Eric Dumazet wrote: > > > On Wed, 2012-08-08 at 15:59 -0400, Eric Paris wrote: > > > > Seems wrong. We shouldn't ever need ifdef

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
On Aug 8, 2012, at 1:56 PM, Milan Broz wrote: > On 08/08/2012 10:46 PM, Wesley Miaw wrote: > >> I did modify veritysetup on my own so the format and verify commands will >> work with regular files on disk instead of having to mount through loop >> devices. > > Which veritysetup? In upstream

[PATCH 2/7] workqueue: make deferrable delayed_work initializer names consistent

2012-08-08 Thread Tejun Heo
Initalizers for deferrable delayed_work are confused. * __DEFERRED_WORK_INITIALIZER() * DECLARE_DEFERRED_WORK() * INIT_DELAYED_WORK_DEFERRABLE() Rename them to * __DEFERRABLE_WORK_INITIALIZER() * DECLARE_DEFERRABLE_WORK() * INIT_DEFERRABLE_WORK() This patch doesn't cause any functional

[PATCH 4/7] workqueue: use irqsafe timer for delayed_work

2012-08-08 Thread Tejun Heo
Up to now, for delayed_works, try_to_grab_pending() couldn't be used from IRQ handlers because IRQs may happen while delayed_work_timer_fn() is in progress leading to indefinite -EAGAIN. This patch makes delayed_work use the new TIMER_IRQSAFE flag for delayed_work->timer. This makes

[PATCH 6/7] workqueue: reimplement cancel_delayed_work() using try_to_grab_pending()

2012-08-08 Thread Tejun Heo
cancel_delayed_work() can't be called from IRQ handlers due to its use of del_timer_sync() and can't cancel work items which are already transferred from timer to worklist. Also, unlike other flush and cancel functions, a canceled delayed_work would still point to the last associated

[PATCH 5/7] workqueue: use mod_delayed_work() instead of __cancel + queue

2012-08-08 Thread Tejun Heo
Now that mod_delayed_work() is safe to call from IRQ handlers, __cancel_delayed_work() followed by queue_delayed_work() can be replaced with mod_delayed_work(). Most conversions are straight-forward except for the following. * net/core/link_watch.c: linkwatch_schedule_work() was doing a quite

[PATCH 7/7] workqueue: deprecate __cancel_delayed_work()

2012-08-08 Thread Tejun Heo
Now that cancel_delayed_work() can be safely called from IRQ handlers, there's no reason to use __cancel_delayed_work(). Use cancel_delayed_work() instead of __cancel_delayed_work() and mark the latter deprecated. Signed-off-by: Tejun Heo Cc: Jens Axboe Cc: Jiri Kosina Cc: Roland Dreier Cc:

[PATCH 3/7] workqueue: clean up delayed_work initializers and add missing one

2012-08-08 Thread Tejun Heo
Reimplement delayed_work initializers using new timer initializers which take timer flags. This reduces code duplications and will ease further initializer changes. This patch also adds a missing initializer - INIT_DEFERRABLE_WORK_ONSTACK(). Signed-off-by: Tejun Heo ---

[PATCH 1/7] workqueue: cosmetic whitespace updates for macro definitions

2012-08-08 Thread Tejun Heo
Consistently use the last tab position for '\' line continuation in complex macro definitions. This is to help the following patches. This patch is cosmetic. Signed-off-by: Tejun Heo --- include/linux/workqueue.h | 126 ++-- 1 files changed, 63

[PATCHSET] workqueue: use irqsafe timer in delayed_work

2012-08-08 Thread Tejun Heo
Hello, Because IRQs can happen between delayed_work->timer being dispatched and delayed_work_timer_fn() actually queueing delayed_work->work, try_to_grab_pending() couldn't be used from IRQ handlers. If it hits the window, it will return -EAGAIN perpetually. This makes it impossible to steal

Re: [PATCH 18/19] sched, numa: Per task memory placement for big processes

2012-08-08 Thread Peter Zijlstra
On Tue, 2012-07-31 at 21:12 +0200, Peter Zijlstra wrote: > +#ifdef CONFIG_NUMA > + /* > +* XXX fold this into flags for 64bit or so... > +*/ > + int nid_last; > +#endif Something like the below? I still ought to update all the various comments about page flag layout

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-08-08 Thread David Miller
From: Yuchung Cheng Date: Wed, 8 Aug 2012 10:48:32 -0700 > On Wed, Aug 8, 2012 at 5:53 AM, Stanislav Kinsbursky > wrote: >> Hi, Dave. >> What about this patch? >> >> >> On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: >>> >>> This is a fix for bug, introduced in 3.4 kernel

Re: [PATCH v3] irq_remap: disable IRQ remapping if any IOAPIC lacks an IOMMU

2012-08-08 Thread Seth Forshee
On Wed, Aug 08, 2012 at 10:57:06AM -0700, Yinghai Lu wrote: > On Wed, Aug 8, 2012 at 6:27 AM, Seth Forshee > wrote: > > The ACPI tables in the Macbook Air 5,1 define a single IOAPIC with id 2, > > but the only remapping unit described in the DMAR table matches id 0. > > Interrupt remapping fails

[PATCH 02/10] ARM: ks8695: __arch_virt_to_dma type handling

2012-08-08 Thread Arnd Bergmann
__arch_virt_to_dma expects a virtual address pointer, but the ks8695 implementation of this macro treats it as an integer. Adding a type cast avoids hundreds of identical warning messages. Without this patch, building acs5k_defconfig results in: arch/arm/include/asm/dma-mapping.h: In function

[PATCH 01/10] ARM: footbridge: nw_gpio_lock is raw_spin_lock

2012-08-08 Thread Arnd Bergmann
bd31b85960a "locking, ARM: Annotate low level hw locks as raw" made nw_gpio_lock a raw spinlock, but did not change all the users in device drivers. This fixes the remaining ones. sound/oss/waveartist.c: In function 'vnc_mute_spkr': sound/oss/waveartist.c:1485:2: warning: passing argument 1 of

[PATCH 10/10] leds: renesas: fix error handling

2012-08-08 Thread Arnd Bergmann
bfe4c041 "leds: convert Renesas TPU LED driver to devm_kzalloc() and cleanup error exit path" introduced a possible case in which r_tpu_probe calls iounmap on a wild pointer. This changes the one case that was missed in the same way as the other error paths. Without this patch, building

[PATCH 05/10] asm-generic: xor: mark static functions as __maybe_unused

2012-08-08 Thread Arnd Bergmann
The asm-generic/xor.h header file is nasty and defines static functions that are not inline. The header file is include by the ARM version of asm/xor.h, which uses some but not all of the symbols defined there. Marking the extraneous functions as __maybe_unused lets gcc drop them without

[PATCH 04/10] ARM: pass -marm to gcc by default

2012-08-08 Thread Arnd Bergmann
The Linaro cross toolchain and probably others nowadays default to building in THUMB2 mode. When building a kernel for a CPU that does not support THUMB2, the compiler complains about incorrect flags. We can work around this by setting -marm for all non-T2 builds. Without this patch, building

[PATCH 00/10] ARM: interesting warnings from defconfig builds

2012-08-08 Thread Arnd Bergmann
Most of these have been around for quite a while, but I think we should fix them nonetheless. In some cases, I'm not very sure about my solution, so I'd appreciate any ACK or NAK I can get. Arnd Arnd Bergmann (10): ARM: footbridge: nw_gpio_lock is raw_spin_lock ARM: ks8695:

[PATCH 03/10] ARM: mv78xx0: fix win_cfg_base prototype

2012-08-08 Thread Arnd Bergmann
Patch b6d1c33a31 "ARM: Orion: Consolidate the address map setup" tried to merge the address map for the four orion platforms, but apparently got it wrong for mv78xx0. Admittedly I don't understand what this code actually does, but it's clear that the current version is wrong. Without this patch,

[PATCH 09/10] ARM: rpc: Fix building RiscPC

2012-08-08 Thread Arnd Bergmann
ARMv3 support was removed in 357c9c1f07 "ARM: Remove support for ARMv3 ARM610 and ARM710 CPUs", which explicitly left parts of the CPU32v3 support in place for building RiscPC. However, this does not actually build in my test setup. This is probably not the right solution, but maybe someone has a

[PATCH 07/10] ARM: rpc: check device_register return code in ecard_probe

2012-08-08 Thread Arnd Bergmann
device_register is marked __must_check, so we better propagate the error value by returning it from ecard_probe. Without this patch, building rpc_defconfig results in: arch/arm/mach-rpc/ecard.c: In function 'ecard_probe': arch/arm/mach-rpc/ecard.c:963:17: warning: ignoring return value of

[PATCH 08/10] ARM: s3c24xx: enable CONFIG_BUG for tct_hammer

2012-08-08 Thread Arnd Bergmann
Disabling CONFIG_BUG creates an insane amount of build warnings, which makes it useless to check for building defconfigs to see if new warnings show up. Without this patch, building tct_hammer_defconfig results in: net/packet/af_packet.c: In function 'tpacket_rcv':

[PATCH 06/10] ARM: davinci: don't use broken ntosd2_init_i2c

2012-08-08 Thread Arnd Bergmann
ntosd2_init_i2c walks the ntosd2_i2c_info array, which it expects to be populated with at least one member. gcc correctly warns about the out-of-bounds access here. Without this patch, building davinci_all_defconfig results in: arch/arm/mach-davinci/board-neuros-osd2.c: In function

[PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-08 Thread Stephen Warren
From: Gyungoh Yoo The MAX8907 is an I2C-based power-management IC containing voltage regulators, a reset controller, a real-time clock, and a touch-screen controller. The original driver was written by: * Gyungoh Yoo Various fixes and enhancements by: * Jin Park * Tom Cherry * Prashant

[PATCH V2 2/3] regulator: add regulator_get_voltage_fixed helper op

2012-08-08 Thread Stephen Warren
From: Stephen Warren Fixed regulators always output desc->min_uV. Add a helper get_voltage op to save duplicating this code in drivers. Signed-off-by: Stephen Warren --- v2: New patch drivers/regulator/core.c | 14 ++ include/linux/regulator/driver.h |1 + 2 files

[PATCH V2 1/3] regulator: add always set/clear masks to regulator_enable_regmap

2012-08-08 Thread Stephen Warren
From: Stephen Warren Some regulators need some register bits set or cleared in order to place them under software control. Add .en_dis_set_mask and .en_dis_clr_mask fields to struct regulator_desc. These can't be part of the existing .enable_mask field, whose bits are set when enabled and

[PATCH 3/3] tpm_tis / PM: Fix unused function warning for CONFIG_PM_SLEEP

2012-08-08 Thread Rafael J. Wysocki
According to a compiler warning, the tpm_tis_resume() function is not used for CONFIG_PM_SLEEP unset, so add a #ifdef to prevent it from being built in that case. Signed-off-by: Rafael J. Wysocki --- drivers/char/tpm/tpm_tis.c |2 ++ 1 file changed, 2 insertions(+) Index:

Re: [ 017/109] ASoC: dapm: Fix locking during codec shutdown

2012-08-08 Thread Herton Ronaldo Krzesinski
On Tue, Aug 07, 2012 at 03:34:36PM -0700, Greg Kroah-Hartman wrote: > From: Greg KH > > 3.4-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Liam Girdwood > > commit 01005a729a17ab419f61a366e22f3419e7a2c3fe upstream. > > Codec shutdown

[PATCH 2/3] platform / x86/ PM: Fix unused function warnings for CONFIG_PM_SLEEP

2012-08-08 Thread Rafael J. Wysocki
According to compiler warnings, quite some suspend/resume functions in platform x86 drivers are not used for CONFIG_PM_SLEEP unset, so add #ifdefs to prevent them from being built in that case. Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/classmate-laptop.c |4

[PATCH 1/3] ACPI / PM: Fix unused function warnings for CONFIG_PM_SLEEP

2012-08-08 Thread Rafael J. Wysocki
According to compiler warnings, several suspend/resume functions in ACPI drivers are not used for CONFIG_PM_SLEEP unset, so add #ifdefs to prevent them from being built in that case. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/ac.c |4 drivers/acpi/battery.c |2 ++

[PATCH 0/3] PM: Fix some unused function warnings for CONFIG_PM_SLEEP

2012-08-08 Thread Rafael J. Wysocki
Hi all, The recent conversion to the PM handling based on struct dev_pm_ops uncovered some code that is not used for CONFIG_PM_SLEEP unset, which results in a number of new copiler warning. Admittedly, I should have spotted those places before, but anyway patches fixing those for ACPI,

Re: [PATCH 1/1] proc: add /proc/pid/shmaps

2012-08-08 Thread David Rientjes
On Wed, 8 Aug 2012, Qiaowei Ren wrote: > Add a shmaps entry to /proc/pid: show information about shared memory in an > address space. > > People that use shared memory and want to perform an analyzing about it. For > example, judge whether any memory address is shared. This file just contains

Re: [RFC PATCH v2 00/16] ACPI based system device hotplug framework

2012-08-08 Thread Toshi Kani
On Wed, 2012-08-08 at 23:44 +0800, Jiang Liu wrote: > On 08/08/2012 07:38 AM, Toshi Kani wrote: > > On Sat, 2012-08-04 at 20:13 +0800, Jiang Liu wrote: > >> From: Jiang Liu > >> > >> The patchset is based on v3.5-rc6 and you may pull them from: > >> git://github.com/jiangliu/linux.git acpihp > >>

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Paris
On Wed, Aug 8, 2012 at 5:03 PM, Paul Moore wrote: > On Wednesday, August 08, 2012 04:51:56 PM Eric Paris wrote: >> Could we add a __init function which does the security_sk_alloc() in >> the same file where we declared them? > > Is it safe to call security_sk_alloc() from inside another __init

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Paul Moore
On Wednesday, August 08, 2012 04:51:56 PM Eric Paris wrote: > On Wed, Aug 8, 2012 at 4:35 PM, Paul Moore wrote: > > On Wednesday, August 08, 2012 10:09:38 PM Eric Dumazet wrote: > > > > Actually, the issue is that the shared socket doesn't have an init/alloc > > function to do the LSM allocation

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Milan Broz
On 08/08/2012 10:46 PM, Wesley Miaw wrote: > On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: > I did modify veritysetup on my own so the format and verify commands will > work with regular files on disk instead of having to mount through loop > devices. Which veritysetup? In upstream (cryptsetup

Re: PROBLEM: snd_hda_intel bug during boot

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Jesper Juhl wrote: > On Wed, 8 Aug 2012, Alexei Kornienko wrote: > > > Seems like I have a bug in audio driver on my laptop. Cause of this I > > don't have any sound card detected. > > Please find more details below: > > > > ** Version: > > Linux version 3.2.0-29-generic-pae

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Paris
On Wed, Aug 8, 2012 at 4:35 PM, Paul Moore wrote: > On Wednesday, August 08, 2012 10:09:38 PM Eric Dumazet wrote: > Actually, the issue is that the shared socket doesn't have an init/alloc > function to do the LSM allocation like we do with other sockets so Eric's > patch does it as part of

Re: PROBLEM: snd_hda_intel bug during boot

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Alexei Kornienko wrote: > Seems like I have a bug in audio driver on my laptop. Cause of this I > don't have any sound card detected. > Please find more details below: > > ** Version: > Linux version 3.2.0-29-generic-pae (buildd@roseapple) (gcc version > 4.6.3 (Ubuntu/Linaro

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Paul Moore
On Wednesday, August 08, 2012 10:32:52 PM Eric Dumazet wrote: > On Wed, 2012-08-08 at 22:09 +0200, Eric Dumazet wrote: > > On Wed, 2012-08-08 at 15:59 -0400, Eric Paris wrote: > > > Seems wrong. We shouldn't ever need ifdef CONFIG_SECURITY in core > > > code. > > > > Sure but it seems include

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: > On 08/08/2012 08:46 PM, Mikulas Patocka wrote: > >> The problem with the patch is that it changes interface to the userspace >> tool. The userspace tool veritysetup already exists in recent cryptsetup >> package, so we can't change the interface

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Paul Moore
On Wednesday, August 08, 2012 10:09:38 PM Eric Dumazet wrote: > On Wed, 2012-08-08 at 15:59 -0400, Eric Paris wrote: > > Seems wrong. We shouldn't ever need ifdef CONFIG_SECURITY in core > > code. > > Sure but it seems include file misses an accessor for this. > > We could add it on a future

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 22:09 +0200, Eric Dumazet wrote: > On Wed, 2012-08-08 at 15:59 -0400, Eric Paris wrote: > > > Seems wrong. We shouldn't ever need ifdef CONFIG_SECURITY in core > > code. > > Sure but it seems include file misses an accessor for this. > > We could add it on a future

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Milan Broz
On 08/08/2012 08:46 PM, Mikulas Patocka wrote: > The problem with the patch is that it changes interface to the userspace > tool. The userspace tool veritysetup already exists in recent cryptsetup > package, so we can't change the interface - you should change the patch so > that the starting

[PATCH v2 18/41] TTY: pty, switch to tty_alloc_driver

2012-08-08 Thread Jiri Slaby
Switch to the new driver allocation interface, as this is one of the special call-sites. Here, we need TTY_DRIVER_DYNAMIC_ALLOC to not allocate tty_driver->ports, cdevs and potentially other structures because we reserve too many lines in pty. Instead, it provides the tty_port<->tty_struct link in

[PATCH v2 21/41] TTY: move cdev_add to tty_register_device

2012-08-08 Thread Jiri Slaby
We need the /dev/ node not to be available before we call tty_register_device. Otherwise we might race with open and tty_struct->port might not be available at that time. This is not an issue now, but would be a problem after "TTY: use tty_port_register_device" is applied. Signed-off-by: Jiri

[PATCH v2 20/41] TTY: add support for unnumbered device nodes

2012-08-08 Thread Jiri Slaby
This allows drivers like ttyprintk to avoid hacks to create an unnumbered node in /dev. It used to set TTY_DRIVER_DYNAMIC_DEV in flags and call device_create on its own. That is incorrect, because TTY_DRIVER_DYNAMIC_DEV may be set only if tty_register_device is called explicitly. Signed-off-by:

[PATCH v2 19/41] TTY: move allocations to tty_alloc_driver

2012-08-08 Thread Jiri Slaby
So now, that we have flags and know everything needed, keep a promise and move all the tables and ports allocation from tty_register_driver to tty_alloc_driver. Not only that it makes sense, but we need this for tty_port_link_device which needs tty_driver->ports but is to be called before

Re: [PATCH] staging:ccg: Fix missing brackets for sizeof (found by sparse).

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Marek Belisko wrote: > Fix following: > WARNING: sizeof fsg should be sizeof(fsg) > + memset(, 0, sizeof fsg); > > Signed-off-by: Marek Belisko > --- > drivers/staging/ccg/ccg.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] staging:ccg: Fix missing brackets for sizeof (found by sparse).

2012-08-08 Thread Marek Belisko
Fix following: WARNING: sizeof fsg should be sizeof(fsg) + memset(, 0, sizeof fsg); Signed-off-by: Marek Belisko --- drivers/staging/ccg/ccg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c index

Re: [PATCH 18/41] TTY: pty, switch to tty_alloc_driver

2012-08-08 Thread Jiri Slaby
On 08/08/2012 05:37 PM, Alan Cox wrote: > On Tue, 7 Aug 2012 21:47:43 +0200 > Jiri Slaby wrote: > >> Switch to the new driver allocation interface, as this is one of the >> special call-sites. Here, we need TTY_DRIVER_EXCESSIVE_LINES to not >> allocate tty_driver->ports, cdevs and potentially

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 15:59 -0400, Eric Paris wrote: > Seems wrong. We shouldn't ever need ifdef CONFIG_SECURITY in core > code. Sure but it seems include file misses an accessor for this. We could add it on a future cleanup patch, as Paul mentioned. > Ifndef CONF_SECURITY then

Re: [PATCH] sched: fix divide by zero at {thread_group,task}_times

2012-08-08 Thread Peter Zijlstra
On Wed, 2012-08-08 at 21:50 +0200, Mike Galbraith wrote: > 32bit built do_div() > and div64_u64() both sucked equally compared to 64bit /me peeks at div64_u64 fallback implementation and sees why, it still does a single div, it does some neat fls tricks. Ok, no point in avoiding this then.. I

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 12:49 -0700, John Stultz wrote: > I can't comment on the patch itself, but I tested it against Linus' HEAD > and it seems to resolve the oops on shutdown for me. OK, thanks ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 15:50 -0400, Paul Moore wrote: > Yep. I was just trying to see if there was a way we could avoid having to > make it conditional on CONFIG_SECURITY, but I think this is a better approach > than the alternatives. > > I'm also looking into making sure we get a sane LSM

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Paris
On Wed, Aug 8, 2012 at 3:38 PM, Eric Dumazet wrote: > On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > index ba39a52..027a331 100644 > --- a/net/ipv4/ip_output.c > +++ b/net/ipv4/ip_output.c > @@ -1524,6 +1524,10 @@ void

Re: rcu stalls seen with numasched_v2 patches applied.

2012-08-08 Thread Peter Zijlstra
On Tue, 2012-08-07 at 22:49 +0530, Srikar Dronamraju wrote: > Are you referring to this the commit 158e1645e (trim task_work: get rid of > hlist) No, to something like the below.. > I am also able to reproduce this on another 8 node machine too. Ship me one ;-) > Just to update, I had to

Re: [PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-08 Thread Vivek Goyal
On Wed, Aug 08, 2012 at 03:24:53PM -0300, Herton Ronaldo Krzesinski wrote: > While looking at commit 3f9a5aa ("floppy: Cleanup disk->queue before > caling put_disk() if add_disk() was never called") I noticed some > problems with the error handling and cleanup: > > * missing cleanup (put_disk) if

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Dmitry Torokhov wrote: > On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote: > > On Wed, 8 Aug 2012, Sachin Kamat wrote: > > > On 7 August 2012 23:46, Jesper Juhl wrote: > > > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > > > omap4_keypad_probe() we

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

2012-08-08 Thread Ben Chan
Hi, Does patch v2 make sense? Thanks, Ben On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan wrote: > Hi Devendra, > > Thanks for cleaning up the driver. If I understand the code > correctly, the original author wanted to initialize wm_event once and > reuse it for multiple devices, and thus reference

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Paul Moore
On Wednesday, August 08, 2012 09:38:21 PM Eric Dumazet wrote: > On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: > > On Wednesday, August 08, 2012 12:14:42 PM John Stultz wrote: > > > So I bisected this down and it seems to be the following commit: > > > > > > commit

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread John Stultz
On 08/08/2012 12:38 PM, Eric Dumazet wrote: On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: It looks the like there is a bug in ip_send_unicast_reply() which uses a inet_sock/sock struct which does not have the LSM data properly initialized. I'll put together a patch shortly. Something

Re: [PATCH] sched: fix divide by zero at {thread_group,task}_times

2012-08-08 Thread Mike Galbraith
On Wed, 2012-08-08 at 11:27 +0200, Stanislaw Gruszka wrote: > On architectures where cputime_t is 64 bit type, is possible to trigger > divide by zero on do_div(temp, (__force u32) total) line, if total is a > non zero number but has lower 32 bit's zeroed. Removing casting is not > a good

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Dmitry Torokhov
On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote: > On Wed, 8 Aug 2012, Sachin Kamat wrote: > > On 7 August 2012 23:46, Jesper Juhl wrote: > > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > > omap4_keypad_probe() we will leak the memory we allocated for > > >

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: > On Wednesday, August 08, 2012 12:14:42 PM John Stultz wrote: > > So I bisected this down and it seems to be the following commit: > > > > commit be9f4a44e7d41cee50ddb5f038fc2391cbbb4046 > > Author: Eric Dumazet > > Date: Thu Jul 19

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Sachin Kamat wrote: > On 7 August 2012 23:46, Jesper Juhl wrote: > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > omap4_keypad_probe() we will leak the memory we allocated for > > 'keypad_data' with kzalloc() when we return and the variable goes out > > of

[PATCH] time: Improve sanity checking of timekeeping inputs

2012-08-08 Thread John Stultz
Thomas, Ingo, Here's a fix against tip/timers/urgent that addresses timekeeping edge cases detected by both a bad BIOS and system fuzzing w/ trinity. Thanks to Sasha Levin and CAI Qian for finding and reporting these! Let me know if you have any tweaks you want to see. thanks -john

PROBLEM: snd_hda_intel bug during boot

2012-08-08 Thread Alexei Kornienko
Seems like I have a bug in audio driver on my laptop. Cause of this I don't have any sound card detected. Please find more details below: ** Version: Linux version 3.2.0-29-generic-pae (buildd@roseapple) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #46-Ubuntu SMP Fri Jul 27 17:25:43 UTC

Re: [PATCH] rndis_wlan: Fix potential memory leak in update_pmkid()

2012-08-08 Thread Jussi Kivilinna
Quoting Alexey Khoroshilov : Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Thanks! Acked-by: Jussi Kivilinna --- drivers/net/wireless/rndis_wlan.c |

Re: [PATCH 02/41] TTY: 68328serial, fix compilation

2012-08-08 Thread Jiri Slaby
On 08/08/2012 05:24 PM, Alan Cox wrote: > On Tue, 7 Aug 2012 21:47:27 +0200 > Jiri Slaby wrote: > >> tty_struct->termios is no longer a pointer. This was changed recently >> by "tty: move the termios object into the tty". But 68328serial was >> not changed, so we now have a compilation error:

Re: [PATCH] pci: Account for virtual buses in pci_acs_path_enabled

2012-08-08 Thread Don Dutile
On 08/08/2012 11:24 AM, Alex Williamson wrote: On Tue, 2012-08-07 at 23:00 -0700, Bjorn Helgaas wrote: On Tue, Aug 7, 2012 at 2:50 PM, Don Dutile wrote: On 08/06/2012 04:47 PM, Bjorn Helgaas wrote: On Sun, Aug 5, 2012 at 11:55 PM, Alex Williamson wrote: On Sun, 2012-08-05 at 23:30

Re: [PATCH] PM QoS: Add a metric : Bus Throughput.

2012-08-08 Thread Rafael J. Wysocki
On Wednesday, August 08, 2012, Jonghwa Lee wrote: > Bus throughput metric is added to PM QoS in order to control the > frequency of memory interfaces and busses with PM QoS. > > Signed-off-by: Jonghwa Lee > Signed-off-by: Kyungmin Park I said some time ago I didn't want any new global PM QoS

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 12:14 -0700, John Stultz wrote: > On 08/07/2012 03:37 PM, John Stultz wrote: > > On 08/07/2012 03:17 PM, Serge E. Hallyn wrote: > >> Quoting Paul Moore (p...@paul-moore.com): > >>> On Tue, Aug 7, 2012 at 5:58 PM, John Stultz > >>> wrote: > On 08/07/2012 02:50 PM, Paul

Re: [PATCH 1/2] ARM: build ssi-fiq.S in ARM mode to prevent CONFIG_THUMB2_KERNEL build breakage

2012-08-08 Thread Sascha Hauer
On Wed, Aug 08, 2012 at 12:32:39PM -0500, Matt Sealey wrote: > On Wed, Aug 8, 2012 at 1:55 AM, Sascha Hauer wrote: > >> .text > >> + .arm > >> .global imx_ssi_fiq_start > >> .global imx_ssi_fiq_end > >> .global imx_ssi_fiq_base >

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Paul Moore
On Wednesday, August 08, 2012 12:14:42 PM John Stultz wrote: > So I bisected this down and it seems to be the following commit: > > commit be9f4a44e7d41cee50ddb5f038fc2391cbbb4046 > Author: Eric Dumazet > Date: Thu Jul 19 07:34:03 2012 + > > ipv4: tcp: remove per net tcp_sock > > >

<    1   2   3   4   5   6   7   8   9   10   >