Re: [PATCHv3 1/4] modem_shm: Add Modem Access Framework

2012-08-26 Thread Greg KH
On Mon, Aug 27, 2012 at 11:19:26AM +0530, Arun Murthy wrote: > +struct modem { > + struct device *dev; No, this needs to be: struct device dev; Please fix it up to be like that, otherwise you are not using the driver model properly at all. > +/** > + * modem_register - register a mod

Re: [RESEND BUGFIX PATCH 3/3] PCI: check whether pci device has been removed when remove a pci device by sysfs

2012-08-26 Thread Yijing Wang
On 2012/8/25 22:39, Jiang Liu wrote: > Hi Yijing, > The patch only patially fix the issue, there exists still small race > condition window because pdev->is_added isn't a reliable flag to depend on. > --Gerry > Hi Gerry, You are right, add pdev->is_added flag check here only fix t

Re: [PATCH 5/13] arch/arm: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Pankaj Jangra
Hi, On Sun, Aug 26, 2012 at 9:30 PM, Julia Lawall wrote: > From: Julia Lawall > > Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and > clk_enable, and clk_disable and clk_unprepare. They make the code more > concise, and ensure that clk_unprepare is called when clk_enable fail

[PATCHv3 0/4] modem_shm: U8500 SHaRed Memory driver(SHRM)

2012-08-26 Thread Arun Murthy
In u8500 platform the communication between the APE(Application Processor) and the modem subsystem(CMT) is by means of a shared DDR. The series of patches include a protocol called ShaRed Memory(SHRM) protocol for communicating between the APE and the CMT. Interrupt generation registers in CMT and

[PATCHv3 4/4] Doc: Add u8500_shrm document

2012-08-26 Thread Arun Murthy
Add document for u8500 shared memory(shrm)and kernel Docbook. Signed-off-by: Arun Murthy --- Documentation/DocBook/Makefile |2 +- Documentation/DocBook/shrm.tmpl| 125 Documentation/modem_shm/u8500_shrm.txt | 254 3 files c

[PATCHv3 1/4] modem_shm: Add Modem Access Framework

2012-08-26 Thread Arun Murthy
Adds Modem Access Framework, which allows for registering platform specific modem access mechanisms. The framework also exposes APIs for client drivers for getting and releasing access to modem, regardless of the underlying platform specific access mechanism. Signed-off-by: Arun Murthy --- drive

[PATCHv3 2/4] modem_shm: Register u8500 client for MAF

2012-08-26 Thread Arun Murthy
Register with Modem Access Framework(MAF) for u8500 platform. This will provide interface to enable and disable modem access and also provide the status. Signed-off-by: Arun Murthy --- drivers/modem_shm/Kconfig | 11 + drivers/modem_shm/Makefile |1 + drivers/modem_shm/modem

Re: [PATCH 2/4] Input: cyttsp4 - core driver for Cypress TMA4XX touchscreen devices

2012-08-26 Thread Ferruh Yigit
On 08/24/2012 05:21 PM, Michal Marek wrote: Dne 7.8.2012 15:09, Ferruh Yigit napsal(a): +static int __init cyttsp4_core_init(void) +{ + int rc = 0; + + rc = cyttsp4_register_core_driver(&cyttsp4_core_driver); + pr_info("%s: Cypress TTSP v4 core driver (Built %s @ %s) rc=%d\n",

RE: Shutdown problem in SMP system happened on Tegra20

2012-08-26 Thread Bill Huang
> On Sat, Aug 25, 2012 at 08:00:56AM +0800, Bill Huang wrote: > > nvpublic > > > So what you're asking for is a feature to do what > > > CONFIG_PM_SLEEP_SMP does, but without CONFIG_PM_SLEEP_SMP enabled? > > > > Yeah pretty much, I'm actually asking should we take care of this > > since maybe not a

RE: [PATCH v2 1/2] mfd: dt: tps6586x: Add power off control

2012-08-26 Thread Bill Huang
nvpublic > On 08/24/2012 06:36 PM, Bill Huang wrote: > >>> On Sun, Aug 19, 2012 at 06:07:55PM -0700, Bill Huang wrote: > Add DT property "ti,system-power-controller" telling whether or not > this pmic is in charge of controlling the system power, so the > power off routine can be hoo

Re: [BUG]: fsnotify oops on 3.5.2

2012-08-26 Thread Guo Chao
On Sun, Aug 26, 2012 at 03:44:54PM -0500, Andrew Watts wrote: > BUG: unable to handle kernel NULL pointer dereference at 0064 > IP: [] fsnotify+0x8b/0x270 > *pde = > Oops: [#1] > Pid: 14083, comm: firefox Tainted: G O 3.5.2 > EIP: 0060:[] EFLAGS: 00210246 CPU: 0 > EIP is at fsnoti

Re: [PATCH] x86: mce: Honour bios-set CMCI threshold

2012-08-26 Thread Naveen N. Rao
On 08/22/2012 06:16 PM, Borislav Petkov wrote: On Wed, Aug 22, 2012 at 06:00:54PM +0530, Naveen N. Rao wrote: The ACPI spec doesn't provide for a way for the bios to pass down recommended thresholds to the OS on a _per-bank_ basis. This patch adds a new boot option, which if passed, allows bios

Re: [ 08/32] drm/i915: correctly order the ring init sequence

2012-08-26 Thread Greg Kroah-Hartman
On Fri, Aug 24, 2012 at 08:03:14PM -0300, Herton Ronaldo Krzesinski wrote: > On Sun, Aug 19, 2012 at 08:57:04PM -0700, Greg Kroah-Hartman wrote: > > From: Greg KH > > > > 3.4-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Daniel

Re: INFO: suspicious RCU usage in rcu_torture_writer()

2012-08-26 Thread Fengguang Wu
On Sat, Aug 25, 2012 at 05:01:49PM -0700, Paul E. McKenney wrote: > On Sat, Aug 25, 2012 at 11:36:23AM +0800, Fengguang Wu wrote: > > Greetings, > > > > I got this warning on 3.6.0-rc2. Full dmesg/config attached. > > > > [3.051375] Initializing RT-Tester: OK > > [3.052491] rcu-torture:--

[PATCH] dmaengine: use kmem_cache_zalloc instead of kmem_cache_alloc/memset

2012-08-26 Thread Wei Yongjun
From: Wei Yongjun Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun --- drivers/dma/ioat/dma_v2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

Re: [PATCH v2 1/9] pinctrl: mvebu: pinctrl driver core

2012-08-26 Thread Stephen Warren
On 08/25/2012 08:53 AM, Sebastian Hesselbarth wrote: > On 08/24/2012 05:34 AM, Stephen Warren wrote: >> On 08/23/2012 05:01 PM, Sebastian Hesselbarth wrote: >>> So possible, valid combinations for uart1 would be: >>> (a) mpp_uart1; >>> (b) mpp_uart1, mpp2, mpp3; >>> (c) mpp_uart1, mpp21, mpp22; >>>

[PATCH] xen/blkback: use kmem_cache_zalloc instead of kmem_cache_alloc/memset

2012-08-26 Thread Wei Yongjun
From: Wei Yongjun Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun --- drivers/block/xen-blkback/xenbus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

Re: [PATCH] dma: tegra: add const to of_device_id.data's structure

2012-08-26 Thread Stephen Warren
On 08/26/2012 03:14 AM, Laxman Dewangan wrote: > The membe "data" of structure of_device_id is changed to const > pointer. Hence initializing this with const type data. > This will fix the compilation warning like > drivers/dma/tegra20-apb-dma.c:1217:9: warning: assignment discards 'const' > quali

Re: [PATCH 10/13] drivers/watchdog/sp805_wdt.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread viresh kumar
On Sun, Aug 26, 2012 at 9:31 PM, Julia Lawall wrote: > From: Julia Lawall > > Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and > clk_enable, and clk_disable and clk_unprepare. They make the code more > concise, and ensure that clk_unprepare is called when clk_enable fails. >

Re: [PATCH 1/13] drivers/staging/iio/adc/spear_adc.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread viresh kumar
On Sun, Aug 26, 2012 at 9:30 PM, Julia Lawall wrote: > From: Julia Lawall > > Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and > clk_enable, and clk_disable and clk_unprepare. They make the code more > concise, and ensure that clk_unprepare is called when clk_enable fails. >

[PATCH] af_unix: fix shutdown parameter checking

2012-08-26 Thread Xi Wang
Return -EINVAL rather than 0 given an invalid "mode" parameter. Signed-off-by: Xi Wang --- Another way to check "mode" is as in inet_shutdown(): mode++; if ((mode & ~SHUTDOWN_MASK) || !mode) return -EINVAL; This patch uses a simpler form, to check if "mode" is in

[PATCH] decnet: fix shutdown parameter checking

2012-08-26 Thread Xi Wang
The allowed value of "how" is SHUT_RD/SHUT_WR/SHUT_RDWR (0/1/2), rather than SHUTDOWN_MASK (3). Signed-off-by: Xi Wang --- net/decnet/af_decnet.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index 2ba1a28..307c322 1006

[PATCH V2] memory-hotplug: add build zonelists when offline pages

2012-08-26 Thread qiuxishi
From: Xishi Qiu online_pages() does build_all_zonelists() and zone_pcp_update(), I think offline_pages() should do it too. When the zone has no memory to allocate, remove it form other nodes' zonelists. zone_batchsize() depends on zone's present pages, if zone's present pages are changed, zone's

[PATCH RESEND] x86_dump_trace: avoiding endless " " is printed

2012-08-26 Thread Liu, Chuansheng
From: liu chuansheng Subject: [PATCH] x86_dump_trace: avoiding endless " " is printed Found the case that endless " " printing in dump_trace, and no real meaningful stack traces are output, so there should be one rare case that possibly context->previous_esp = context or other cases. The endle

Re: pci: question about the life cycle of pci_dev and its parent pci_bus

2012-08-26 Thread Liu ping fan
On Fri, Aug 24, 2012 at 10:30 PM, Jiang Liu wrote: > Hi Pingfan, > > We have realized the same when implementing lock mechanisms for PCI > hotplug > operations, and we are planning to holding a reference to parent bus for each > pci dev. Thanks! You save me from searching such codes. Re

Re: [PATCH 4/13] i2c: sirf: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Barry Song
2012/8/27 Julia Lawall : > From: Julia Lawall > > Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and > clk_enable, and clk_disable and clk_unprepare. They make the code more > concise, and ensure that clk_unprepare is called when clk_enable fails. > > A simplified version of the

Re: [PATCH v2] leds: triggers: send uevent when changing triggers

2012-08-26 Thread Bryan Wu
My bad. I apologize to the delay. I missed the v2 original patch email in this thread, but googled and found it. Applied to my for-next branch now. Thanks, -Bryan On Tue, Aug 14, 2012 at 7:34 PM, Bryan Wu wrote: > On Wed, Aug 8, 2012 at 10:16 AM, Bryan Wu wrote: >> On Wed, Aug 8, 2012 at 9:12 A

[PATCH 1/1] x86/oprofile: Fix the calltrace upon profiling some specified events with oprofile

2012-08-26 Thread Wei.Yang
From: Wei Yang Upon enabling the call-graph functionality of oprofile, A few minutes later the following calltrace will always occur. BUG: unable to handle kernel paging request at 656d6153 IP: [] print_context_stack+0x55/0x110 *pde = Oops: [#1] PREEMPT SMP Modules linked in: Pid:

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-08-26 Thread Shilimkar, Santosh
On Sun, Aug 26, 2012 at 3:53 PM, NeilBrown wrote: > > On Sun, 26 Aug 2012 09:47:50 +0530 "Shilimkar, Santosh" > wrote: > > > + Jon, > > > > On Sat, Aug 25, 2012 at 5:14 PM, NeilBrown wrote: > > > > > > > > > > > > Current kernel will wake from suspend on an event on any active > > > GPIO even if

Re: [PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

2012-08-26 Thread Namjae Jeon
2012/8/26, OGAWA Hirofumi : > Namjae Jeon writes: > >> #define FAT_ENT_EOF(EOF_FAT32) >> >> there is no need to reset value of 'new' for FAT32 as the values is >> already correct >> >> Signed-off-by: Namjae Jeon >> Signed-off-by: Amit Sahrawat >> --- >> fs/fat/fatent.c |2 -- >> 1 file chan

Re: [PATCH 1/2] fat: kill unused macros

2012-08-26 Thread Namjae Jeon
2012/8/26, OGAWA Hirofumi : > Namjae Jeon writes: > >> Remove unused macros. > > Those are for userland. Are you sure userland doesn't use those anymore? Hi. OGAWA. I missed this point. I will repost if I can be sure. Thanks a lot. > >> Signed-off-by: Namjae Jeon >> Signed-off-by: Amit Sahrawat

Re: [RESEND BUGFIX PATCH 1/3] PCI/AER: fix pci_ops return NULL when hotplug a pci bus which was doing aer error inject

2012-08-26 Thread Huang Ying
On Sat, 2012-08-25 at 17:59 +0800, Yijing Wang wrote: > When we inject aer errors to the target pci device by aer_inject module, the > pci_ops of pci > bus which the target device is on will be assign to pci_ops_aer.So if the > target pci device > is a bridge, once we hotplug the pci bus(child bu

Re: [PATCH V5 0/5] clk: mmp: add clock framework for mmp

2012-08-26 Thread Chao Xie
On Sat, Aug 25, 2012 at 8:21 AM, Mike Turquette wrote: > Quoting Chao Xie (2012-08-19 19:55:10) >> From: Chao Xie >> arch/arm/mach-mmp/Kconfig|3 + >> drivers/clk/Makefile |3 + >> drivers/clk/mmp/Makefile |9 + >> drivers/clk/mmp/clk-apbc.c | 152 ++ >>

Re: linux-next: build failure after merge of the gpio-lw tree

2012-08-26 Thread Kuninori Morimoto
Hi Linus W > > Now, these fixup patches were accepted. > > http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779 > > http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4 > > > > Could you please re-check this dropped patch ? > > Yes! I've applied it. Check that it

Re: [PATCH] kdump: remove unused including

2012-08-26 Thread Simon Horman
On Sat, Aug 25, 2012 at 10:18:20AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Reviewed-by: Simon Horman --- > kernel/kexec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c

Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe

2012-08-26 Thread Chanwoo Choi
On 08/27/2012 05:58 AM, Mark Brown wrote: > Signed-off-by: Mark Brown > --- > drivers/extcon/extcon-arizona.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index fa2114f..13eafcb 100644 > --- a/

Re: [PATCH -next] extcon: extcon-arizona depends on INPUT

2012-08-26 Thread Chanwoo Choi
On 08/25/2012 02:04 AM, Randy Dunlap wrote: > From: Randy Dunlap > > extcon-arizona uses input_*() functions so it should depend > on INPUT. > > ERROR: "input_event" [drivers/extcon/extcon-arizona.ko] undefined! > ERROR: "input_free_device" [drivers/extcon/extcon-arizona.ko] undefined! > ERROR:

Linux 3.4.10

2012-08-26 Thread Greg KH
I'm announcing the release of the 3.4.10 kernel. All users of the 3.4 kernel series must upgrade. Note, there is a reported problem with the Intel graphics driver in this release that might affect you, or not, please test. The updated 3.4.y git tree can be found at: git://git.kernel.org/

Re: Linux 3.0.42

2012-08-26 Thread Greg KH
diff --git a/Makefile b/Makefile index 2cbfd97..d863aa0 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ VERSION = 3 PATCHLEVEL = 0 -SUBLEVEL = 41 +SUBLEVEL = 42 EXTRAVERSION = NAME = Sneaky Weasel diff --git a/arch/s390/kernel/compat_linux.c b/arch/s390/kernel/compat_linux.c index 53acaa

Linux 3.0.42

2012-08-26 Thread Greg KH
I'm announcing the release of the 3.0.42 kernel. All users of the 3.0 kernel series must upgrade. Note, there is a reported problem with the Intel graphics driver in this release, a follow-on release might happen quite quickly to resolve this issue after it has been tested out. The updated 3.0.y

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-08-26 Thread NeilBrown
On Sun, 26 Aug 2012 09:47:50 +0530 "Shilimkar, Santosh" wrote: > + Jon, > > On Sat, Aug 25, 2012 at 5:14 PM, NeilBrown wrote: > > > > > > > > Current kernel will wake from suspend on an event on any active > > GPIO even if enable_irq_wake() wasn't called. > > > > There are two reasons that the

[PATCH] printk: Move to separate directory for easier modification

2012-08-26 Thread Joe Perches
Make it easier to break up printk into bite-sized chunks. Remove printk path/filename from comment. Signed-off-by: Joe Perches --- kernel/Makefile |3 ++- kernel/printk/Makefile |1 + kernel/{ => printk}/printk.c |2 -- 3 files changed, 3 insertions(+), 3 deletion

[PATCH 1/2] dw_dmac: make driver endianness configurable

2012-08-26 Thread Hein Tibosch
The dw_dmac was originally developed for avr32 to be used with the Synopsys DesignWare AHB DMA controller. After 2.6.38, device access was done with the little-endian readl/writel functions. This didn't work on the avr32 platform, because it needs native-endian (i.e. big-endian) accessors. This pat

[PATCH] avr32-linux: at32ap700x: set DMA slave properties for MCI dw_dmac

2012-08-26 Thread Hein Tibosch
@Andrew: could you please push the patch below? Hans-Christian doesn't have a GIT tree on kernel.org Thanks, Hein The MCI makes use of the dw_dmac driver when DMA is being used. Due to recent changes the driver was broken because: - the SMS field in the CTLL register received the wrong value 0 -

[PATCH 2/2] dw_dmac: max_mem_width limits value for SRC/DST_TR_WID register

2012-08-26 Thread Hein Tibosch
The dw_dmac driver was earlier adapted to do 64-bit transfers on the memory side (https://lkml.org/lkml/2012/1/18/52) This works on ARM platforms but for AVR32 (AP700x) the maximum allowed transfer size is 32-bits. This patch allows the arch to set a new slave property max_mem_width to limit the si

Re: [PATCH 3/3] HWPOISON: prevent inode cache removal to keep AS_HWPOISON sticky

2012-08-26 Thread Dave Chinner
On Fri, Aug 24, 2012 at 01:24:16PM -0400, Naoya Horiguchi wrote: > On Fri, Aug 24, 2012 at 02:39:17PM +1000, Dave Chinner wrote: > > On Thu, Aug 23, 2012 at 10:39:32PM -0400, Naoya Horiguchi wrote: > > > On Fri, Aug 24, 2012 at 11:31:18AM +1000, Dave Chinner wrote: > > > > On Wed, Aug 22, 2012 at 1

[PATCH 0/2] dw_dmac: repair driver for use with AVR32 (AP7000)

2012-08-26 Thread Hein Tibosch
After some recent changes to dw_dmac, the driver got broken for the AVR32 platform for two reasons: The accessors to i/o memory had become little-endian. The maximum transfer width on the memory side was increased from 32 to 64 bits. These patches repair the driver by: 1. making the endianness co

[PATCH,STAGING] speakup: lower default software speech rate

2012-08-26 Thread Samuel Thibault
Speech synthesis beginners need a low speech rate, and trained people want a high speech rate. A medium speech rate is thus actually not a good default for neither. Since trained people will typically know how to change the rate, better default for a low speech rate, which beginners can grasp and

[PATCH] extcon: arizona: Free MICDET IRQ on error during probe

2012-08-26 Thread Mark Brown
Signed-off-by: Mark Brown --- drivers/extcon/extcon-arizona.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index fa2114f..13eafcb 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon

[BUG]: fsnotify oops on 3.5.2

2012-08-26 Thread Andrew Watts
Hi. Last night I had a kernel oops in fsnotify (see attached). It happened when I clicked a hyperlink to a text file in Firefox (which normally opens an open-with/save-file dialog). I've not found a way to reproduce. The system runs kernel 3.5.2 with ext3. (note: kernel is patched with overlayfs

Re: [Ksummit-2012-discuss] Pubring and instructions for the KS 2012 keysigning

2012-08-26 Thread Konstantin Ryabitsev
On 26/08/12 09:42 AM, Ben Hutchings wrote: > You seem to have missed step 0: > > Verify your own key fingerprint in ks2012-pubring.gpg by comparing: > > gpg --fingerprint $KEY_ID > gpg --no-default-keyring --keyring ./ks2012-pubring.gpg --fingerprint > $REAL_NAME Yes, you are correct. I'll send

Re: [PATCH drm-next 2/3] drm/i915: Remove reference to drm_display_info raw_edid field

2012-08-26 Thread Sedat Dilek
On Sun, Aug 26, 2012 at 8:39 PM, Daniel Vetter wrote: > On Sat, Aug 25, 2012 at 12:16:23AM +0200, Sedat Dilek wrote: >> Reported-By: Stephen Rothwell >> Acked-by: Jani Nikula >> Acked-by: Dave Airlie >> Signed-off-by: Sedat Dilek > > This doesn't apply to my drm-intel-next tree any more - we'v

Re: [PATCH 00/19 v2] Improve IRQ remapping abstraction in x86 core code

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:55:46PM +0200, Joerg Roedel wrote: > Please review. Finally. Usually you don't add/change code but you just move common irq remapping pieces out of geric io-apic code and put them in once place. I think it would be good, if you would note this in the description of your

Re: [PATCH drm-next 3/3] drm/i915/contexts: Fixup merge with commit b6c7488df68a

2012-08-26 Thread Sedat Dilek
On Sun, Aug 26, 2012 at 8:42 PM, Daniel Vetter wrote: > On Sat, Aug 25, 2012 at 12:16:24AM +0200, Sedat Dilek wrote: >> This is a fixup patch for the merge of drm-next into linux-next caused >> by commit b6c7488df68a ("drm/i915/contexts: fix list corruption"). >> >> Reported-By: Stephen Rothwell

[PATCH 3/4] task_work: revert d35abdb2 "hold task_lock around checks in keyctl"

2012-08-26 Thread Oleg Nesterov
This reverts commit d35abdb28824cf74f0a106a0f9c6f3ff700a35bf. task_lock() was added to ensure exit_mm() and thus exit_task_work() is not possible before task_work_add(). This is wrong, task_lock() must not be nested with write_lock(tasklist). And this is no longer needed, task_work_add() fails if

[PATCH 2/4] task_work: task_work_add() should not succeed after exit_task_work()

2012-08-26 Thread Oleg Nesterov
ed3e694d "move exit_task_work() past exit_files() et.al" destroyed the add/exit synchronization we had, the caller itself should ensure task_work_add() can't race with the exiting task. However, this is not convenient/simple, and the only user which tries to do this is buggy (see the next patch).

[PATCH 4/4] task_work: simplify the usage in ptrace_notify() and get_signal_to_deliver()

2012-08-26 Thread Oleg Nesterov
ptrace_notify() and get_signal_to_deliver() do unnecessary things before task_work_run(). 1. smp_mb__after_clear_bit() is not needed, test_and_clear_bit() implies mb(). 2. And we do not need the barrier at all, in this case we only care about the "synchronous" works added by the task itself

[PATCH 1/4] task_work: make task_work_add() lockless

2012-08-26 Thread Oleg Nesterov
Change task_works to use llist-like code to avoid pi_lock in task_work_add(), this makes it useable under rq->lock. task_work_cancel() and task_work_run() still use pi_lock to synchronize with each other. Suggested-by: Peter Zijlstra Signed-off-by: Oleg Nesterov --- kernel/task_work.c | 95 +

[PATCH 0/4] (Was: lockdep trace from posix timers)

2012-08-26 Thread Oleg Nesterov
On 08/24, Oleg Nesterov wrote: > > Peter, if you think it can work for you and if you agree with > the implementation I will be happy to send the patch. I think I should try anyway ;) To simplify the review, I attached the resulting code below. Changes: - Comments. - Not sure t

Re: [PATCH 18/19] x86, io_apic: Introduce eoi_ioapic_pin call-back

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:56:04PM +0200, Joerg Roedel wrote: > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > index aac3f62..d4db390 100644 > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -557,19 +557,10 @@ static void unmask_ioapi

Re: [PATCH drm-next 2/3] drm/i915: Remove reference to drm_display_info raw_edid field

2012-08-26 Thread Daniel Vetter
On Sat, Aug 25, 2012 at 12:16:23AM +0200, Sedat Dilek wrote: > Reported-By: Stephen Rothwell > Acked-by: Jani Nikula > Acked-by: Dave Airlie > Signed-off-by: Sedat Dilek This doesn't apply to my drm-intel-next tree any more - we've moved around the assignement a bit. -Daniel > --- > drivers/

Re: [PATCH drm-next 3/3] drm/i915/contexts: Fixup merge with commit b6c7488df68a

2012-08-26 Thread Daniel Vetter
On Sat, Aug 25, 2012 at 12:16:24AM +0200, Sedat Dilek wrote: > This is a fixup patch for the merge of drm-next into linux-next caused > by commit b6c7488df68a ("drm/i915/contexts: fix list corruption"). > > Reported-By: Stephen Rothwell > Signed-off-by: Sedat Dilek This is wrong, switch_context

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > This call-back points to the right function for initializing > the msi_msg structure. So you pull out the compose_remapped_msi_msg() out of msi_compose_msg() and put this in a callback. Such information is good since you don't see thi

Re: [PATCH 16/19] x86, irq: Introduce setup_remapped_irq()

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:56:02PM +0200, Joerg Roedel wrote: > --- a/arch/x86/include/asm/irq_remapping.h > +++ b/arch/x86/include/asm/irq_remapping.h > @@ -44,6 +44,9 @@ extern void compose_remapped_msi_msg(struct pci_dev *pdev, >struct msi_msg *msg, u8 hpet_id

Re: [PATCH 15/19] x86, irq: Move irq_remapped() check into free_remapped_irq

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:56:01PM +0200, Joerg Roedel wrote: > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -2981,8 +2981,8 @@ void destroy_irq(unsigned int irq) > > irq_set_status_flags(irq, IRQ_NOREQUEST|IRQ_NOPROBE); > > - if (irq_remapped(cfg))

[PATCH 2/7] perf tool: handle errors in synthesized event functions

2012-08-26 Thread David Ahern
Handle error from process callback and propogate back to caller. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weisbecker Cc: Peter Zijlstra --- tools/perf/util/event.c | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/tools/p

[PATCH 4/7] perf stat: remove use of die/exit and handle errors

2012-08-26 Thread David Ahern
Allows perf to clean up properly on program termination. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weisbecker Cc: Peter Zijlstra --- tools/perf/builtin-stat.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/bui

Re: [PATCH 14/19] x86, io-apic: Remove !irq_remapped() check from __target_IO_APIC_irq()

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:56:00PM +0200, Joerg Roedel wrote: > This function is only called from default_ioapic_set_affinity() > which is only used when interrupt remapping is disabled. So > the check will always evaluate as true and can be removed. Since commit ("x86, io_apic: Introduce set_affi

[PATCH 5/7] perf help: remove remove use of die and handle errors

2012-08-26 Thread David Ahern
Allows perf to clean up properly on exit. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weisbecker Cc: Peter Zijlstra --- tools/perf/builtin-help.c | 48 - 1 file changed, 34 insertions(+), 14 deletions(-) diff --git a/tools/perf/builti

[PATCH 3/7] perf lock: remove use of die and handle errors

2012-08-26 Thread David Ahern
Allows perf to clean up properly on exit. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weisbecker Cc: Peter Zijlstra --- tools/perf/builtin-lock.c | 181 +++-- 1 file changed, 124 insertions(+), 57 deletions(-) diff --git a/tools/perf/built

[PATCH 1/7] perf tool: flush_sample_queue needs to handle errors from handlers

2012-08-26 Thread David Ahern
Allows errors to propogate through event processing code and back to commands. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weisbecker Cc: Peter Zijlstra --- tools/perf/util/session.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/to

[PATCH 7/7] perf record: remove use of die/exit

2012-08-26 Thread David Ahern
Allows perf to clean up properly on exit. If perf-record is exiting due to failure, the on_exit should not run as the session has been deleted. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weisbecker Cc: Peter Zijlstra --- tools/perf/builtin-record.c | 158

[PATCH 6/7] perf script: remove use of die/exit

2012-08-26 Thread David Ahern
Allows perf to clean up properly on exit. Only exits left are exec failures which are appropriate and usage callbacks that list available options. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weisbecker Cc: Peter Zijlstra --- tools/perf/builtin-script.c | 60 +

[PATCH 0/7] perf: cleanups related to die/exit and error handling

2012-08-26 Thread David Ahern
Round 1 removing the use of die() and exit(). It's rather slow and tedious to check all the error paths and make sure error propogation is properly done and handled, so submitting patches in phases as I have time to work on it. David Ahern (7): perf tool: flush_sample_queue needs to handle error

Re: [PATCH 13/19] x86, io-apic: Move CONFIG_IRQ_REMAP code out of x86 core

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:55:59PM +0200, Joerg Roedel wrote: > index fc89a2a..c84403e 100644 > --- a/arch/x86/include/asm/hw_irq.h > +++ b/arch/x86/include/asm/hw_irq.h > @@ -127,6 +127,7 @@ struct irq_cfg { > u8 vector; > u8 move_in_progress :

Re: [PATCH 12/19] x86, irq: Add data structure to keep AMD specific irq remapping information

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:55:58PM +0200, Joerg Roedel wrote: > --- a/arch/x86/include/asm/hw_irq.h > +++ b/arch/x86/include/asm/hw_irq.h > @@ -101,6 +101,7 @@ static inline void set_io_apic_irq_attr(struct > io_apic_irq_attr *irq_attr, > irq_attr->polarity = polarity; > } > > +/* In

Re: [PATCH 10/19] x86, io_apic: Introduce function pointer for setup_timer_IRQ0_pin

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:55:56PM +0200, Joerg Roedel wrote: > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 827f8a1..71824fc 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c > @@ -87,11 +87,18 @@ error: > return ret; >

Re: [PATCH 06/19] x86, msi: Use IRQ remapping specific setup_msi_irqs routine

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:55:52PM +0200, Joerg Roedel wrote: > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index f439151..984104b 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c > @@ -181,7 +232,7 @@ void compose_remapped_msi_msg(

Re: [PATCH 04/19] x86, io_apic: Introduce x86_io_apic_ops.print_entries for debugging

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:55:50PM +0200, Joerg Roedel wrote: > This call-back is used to dump IO-APIC entries for debugging > purposes into the kernel log. VT-d needs a special routine > for this and will overwrite the default. Okay, again: code basically does what it did, it has been shifted aro

Re: perf backtraces off-by-1

2012-08-26 Thread Arun Sharma
On 8/26/12 9:10 AM, Peter Zijlstra wrote: On Fri, 2012-08-24 at 15:13 -0700, Arun Sharma wrote: One option is to support this for user mode only, with code to detect signal frames. Any other ideas? I guess we'd need to see what that patch would look like... :-) It used to look like this

Re: [PATCH] hwmon/lm70: adding support for NS LM74 chip

2012-08-26 Thread Guenter Roeck
On Thu, Aug 23, 2012 at 11:13:17AM -0700, Guenter Roeck wrote: > On Thu, Aug 23, 2012 at 05:32:12PM +0200, Christophe Leroy wrote: > > Hello, > > > Hi Christophe, > Hi again, [ ... ] > > > > - /* 3-wire link (shared SI/SO) for LM70 */ > > - if (chip == LM70_CHIP_LM70 && !(spi->mode & SPI_

[GIT PULL] hwmon fixes for 3.6-rc4

2012-08-26 Thread Guenter Roeck
Hi Linus, Please pull hwmon fixes for Linux 3.6-rc4 from signed tag: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-linus Thanks, Guenter -- The following changes since commit fea7a08acb13524b47711625eebea40a0ede69a0: Linux 3.6-rc3 (2012-08-22 13:29

Re: [GIT PULL] logfs: some important bug fixes

2012-08-26 Thread Prasad Joshi
On Sun, Aug 26, 2012 at 4:56 PM, Prasad Joshi wrote: > Hello Linus, > > Could you please pull the following changes since commit > dd775ae2549217d3ae09363e3edb305d0fa19928: > > Linux 3.4-rc1 (2012-03-31 16:24:09 -0700) > > are available in the git repository at: > git://github.com/prasad-joshi

Re: [PATCH] Bluetooth: Add support for Apple vendor-specific devices

2012-08-26 Thread Marcel Holtmann
Hi Henrik, > As pointed out by Gustavo and Marcel, all Apple-specific Broadcom > devices seen so far have the same interface class, subclass and > protocol numbers. This patch adds an entry which matches all of them, > using the new USB_VENDOR_AND_INTERFACE_INFO() macro. > > In particular, this p

Re: [Ksummit-2012-discuss] Pubring and instructions for the KS 2012 keysigning

2012-08-26 Thread Ben Hutchings
On Fri, 2012-08-24 at 23:39 -0700, Konstantin Ryabitsev wrote: > Hello, all: > > I collected 46 keys from 40 people interested in keysigning at the > Kernel Summit. I have uploaded the fingerprints and the pubring to the > following locations: > > https://www.kernel.org/ks2012-fingerprints.txt >

Re: [PATCH] drivers/media/dvb-frontends/rtl2830.c: correct double assignment

2012-08-26 Thread Antti Palosaari
On 08/26/2012 07:15 PM, Julia Lawall wrote: From: Julia Lawall The double assignment is meant to be a bit-or to combine two values. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression i; @@ *i = ...; i = ...; //

[PATCH] drivers/media/dvb-frontends/rtl2830.c: correct double assignment

2012-08-26 Thread Julia Lawall
From: Julia Lawall The double assignment is meant to be a bit-or to combine two values. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression i; @@ *i = ...; i = ...; // Signed-off-by: Julia Lawall --- drivers/med

Re: perf backtraces off-by-1

2012-08-26 Thread Peter Zijlstra
On Fri, 2012-08-24 at 15:13 -0700, Arun Sharma wrote: > > Wondering if this has been discussed before. Not that I can recall. > One option is to support > this for user mode only, with code to detect signal frames. Any other > ideas? > I guess we'd need to see what that patch would look like.

[PATCH 1/1] Document:add Chinese translation of basic_profiling.txt

2012-08-26 Thread liang xie
This is a Chinese translated version of Documentation/basic_profiling.txt Signed-off-by: Liang Xie --- Documentation/zh_CN/basic_profiling.txt | 71 +++ 1 files changed, 71 insertions(+), 0 deletions(-) create mode 100755 Documentation/zh_CN/basic_profiling.txt diff --git a/Documentation

Re: udev 182: response timeout for request_firmware in module_probe path

2012-08-26 Thread Benjamin Herrenschmidt
On Thu, 2012-08-23 at 17:46 +0100, Alan Cox wrote: > > IMO, the driver probing path is allowed to sleep, so looks request > firmware > > should be allowed inside .probe(). > > I'm not convinced about that. It can sleep but its holding various > locks > in most cases, and it looks like that can end

[PATCH 1/13] drivers/staging/iio/adc/spear_adc.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 2/13] drivers/spi/spi-{orion,pl022}.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 5/13] arch/arm: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 8/13] i2c: mv64xxx: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 7/13] drivers/mmc/host/mmci.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 0/13] use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. The transformation is made using the following semantic patch (http://coccinelle.lip6

[PATCH 6/13] drivers/iio/adc/at91_adc.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 10/13] drivers/watchdog/sp805_wdt.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 11/13] arch/arm/mach-at91/gpio.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

[PATCH 13/13] drivers/rtc/rtc-coh901331.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-26 Thread Julia Lawall
From: Julia Lawall Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls

  1   2   >