Re: [PATCH -V1 09/22] vfs: Make acl_permission_check() work for richacls

2014-05-01 Thread Aneesh Kumar K.V
Dave Chinner writes: > On Sun, Apr 27, 2014 at 09:44:40PM +0530, Aneesh Kumar K.V wrote: >> From: Andreas Gruenbacher >> >> Signed-off-by: Andreas Gruenbacher >> Signed-off-by: Aneesh Kumar K.V >> --- >> fs/namei.c | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git

Re: [PATCH 11/17] mm: page_alloc: Use unsigned int for order in more places

2014-05-01 Thread Dave Hansen
On 05/01/2014 08:11 AM, Mel Gorman wrote: > On Thu, May 01, 2014 at 07:35:47AM -0700, Dave Hansen wrote: >> On 05/01/2014 01:44 AM, Mel Gorman wrote: >>> X86 prefers the use of unsigned types for iterators and there is a >>> tendency to mix whether a signed or unsigned type if used for page >>>

Re: [PATCH] random: Add "initialized" variable to proc

2014-05-01 Thread Andy Lutomirski
On Thu, May 1, 2014 at 8:05 AM, wrote: > On Wed, Apr 30, 2014 at 09:05:00PM -0700, H. Peter Anvin wrote: >> >> Giving the guest a seed would be highly useful, though. There are a >> number of ways to do that; changing the boot protocol is probably >> only useful if Qemu itself bouts the kernel

[PATCH 1/1] fanotify: check file flags passed in fanotify_init

2014-05-01 Thread Heinrich Schuchardt
Without this patch fanotify_init does not validate the value passed in event_f_flags. When a fanotify event is read from the fanotify file descriptor a new file descriptor is created where file.f_flags = event_f_flags. Internal and external open flags are stored together in field f_flags of

Re: [PATCH -V1 08/22] vfs: Add permission flags for setting file attributes

2014-05-01 Thread Aneesh Kumar K.V
Dave Chinner writes: > On Sun, Apr 27, 2014 at 09:44:39PM +0530, Aneesh Kumar K.V wrote: >> From: Andreas Gruenbacher >> >> Some permission models can allow processes to take ownership of a file, >> change the file permissions, and set the file timestamps. Introduce new >> permission mask

Re: [PATCH -V1 06/22] vfs: Add delete child and delete self permission flags

2014-05-01 Thread Aneesh Kumar K.V
Dave Chinner writes: > On Sun, Apr 27, 2014 at 09:44:37PM +0530, Aneesh Kumar K.V wrote: >> From: Andreas Gruenbacher >> >> Normally, deleting a file requires write access to the parent directory. >> Some permission models use a different permission on the parent >> directory to indicate

Re: [PATCH] block: null_blk: fix use after free

2014-05-01 Thread Jens Axboe
On 05/01/2014 01:12 AM, Ming Lei wrote: > entry(cmd->ll_list) may belong to new request once end_cmd() > returns, so fix the bug with the patch. > > Without the change, it is easy to observe oops when > doing null_blk(timer) test. > > Signed-off-by: Ming Lei > --- > drivers/block/null_blk.c |

Re: [PATCH -V1 05/22] vfs: Add new file and directory create permission flags

2014-05-01 Thread Aneesh Kumar K.V
Dave Chinner writes: > On Mon, Apr 28, 2014 at 07:23:01AM -0400, Jeff Layton wrote: >> On Sun, 27 Apr 2014 21:44:36 +0530 >> "Aneesh Kumar K.V" wrote: >> >> > From: Andreas Gruenbacher >> > >> > Some permission models distinguish between the permission to create a >> > non-directory and a

Re: [PATCH] usb: dwc3: gadget: fix burst size corruption

2014-05-01 Thread Felipe Balbi
Hi, On Thu, May 01, 2014 at 09:45:17AM -0400, Alan Stern wrote: > On Thu, 1 May 2014, Zhuang Jin Can wrote: > > > > again, you found a bug on the gadget driver. Fix that. composite.c > > > guarantees that for those functions which don't pass bMaxBurst, > > > gadget->maxburst will be set to *at

Re: [PATCH] usb: dwc3: gadget: giveback request if start transfer fail

2014-05-01 Thread Felipe Balbi
Hi, On Thu, May 01, 2014 at 04:44:52PM -0400, Zhuang Jin Can wrote: > On Wed, Apr 30, 2014 at 02:58:29PM -0500, Felipe Balbi wrote: > > On Thu, May 01, 2014 at 02:36:08AM -0400, Zhuang Jin Can wrote: > > > At least we should giveback the current request to the > > > gadget. Otherwise, the gadget

Re: [PATCH 1/4] workqueue: Create low-level unbound workqueues cpumask

2014-05-01 Thread Tejun Heo
On Thu, May 01, 2014 at 05:09:20PM +0200, Frederic Weisbecker wrote: > > > Not sure why you want that. It makes sense on directories grouping > > > file for different subsystem. But here? > > > > Worried about possible conflicts with workqueue names if we end up > > with more attributes. > > But

Re: [PATCH 11/17] mm: page_alloc: Use unsigned int for order in more places

2014-05-01 Thread Mel Gorman
On Thu, May 01, 2014 at 07:35:47AM -0700, Dave Hansen wrote: > On 05/01/2014 01:44 AM, Mel Gorman wrote: > > X86 prefers the use of unsigned types for iterators and there is a > > tendency to mix whether a signed or unsigned type if used for page > > order. This converts a number of sites in

Re: [PATCH 1/4] workqueue: Create low-level unbound workqueues cpumask

2014-05-01 Thread Frederic Weisbecker
On Thu, May 01, 2014 at 11:02:31AM -0400, Tejun Heo wrote: > Hello, > > On Thu, May 01, 2014 at 05:01:17PM +0200, Frederic Weisbecker wrote: > > > Another thing with naming is that I didn't anticipate having > > > attributes at the top directory so the workqueue directories aren't > > >

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Peter Zijlstra
On Thu, May 01, 2014 at 10:27:45AM -0400, Vince Weaver wrote: > On Thu, 1 May 2014, Vince Weaver wrote: > > > On Wed, 30 Apr 2014, Peter Zijlstra wrote: > > > > > Vince, could you add the below to whatever tracing muck you already > > > have? > > and this might be what you're looking for. This

Re: [PATCH] random: Add "initialized" variable to proc

2014-05-01 Thread tytso
On Wed, Apr 30, 2014 at 09:05:00PM -0700, H. Peter Anvin wrote: > > Giving the guest a seed would be highly useful, though. There are a > number of ways to do that; changing the boot protocol is probably > only useful if Qemu itself bouts the kernel as opposed to an in-VM > bootloader. So how

Re: [PATCH 1/4] workqueue: Create low-level unbound workqueues cpumask

2014-05-01 Thread Tejun Heo
Hello, On Thu, May 01, 2014 at 05:01:17PM +0200, Frederic Weisbecker wrote: > > Another thing with naming is that I didn't anticipate having > > attributes at the top directory so the workqueue directories aren't > > namespaced. Maybe we want to namespace top level knobs? > > "system_cpumask"

Re: [PATCH 1/4] workqueue: Create low-level unbound workqueues cpumask

2014-05-01 Thread Frederic Weisbecker
On Thu, Apr 24, 2014 at 11:37:16AM -0400, Tejun Heo wrote: > On Thu, Apr 24, 2014 at 04:37:33PM +0200, Frederic Weisbecker wrote: > > Create a cpumask that limit the affinity of all unbound workqueues. > > This cpumask is controlled though a file at the root of the workqueue > > sysfs directory. >

[PATCHv4] uprobes: simplify rip-relative handling

2014-05-01 Thread Denys Vlasenko
It is possible to replace rip-relative addressing mode with addressing mode of the same length: (reg+disp32). This eliminates the need to fix up immediate and correct for changing instruction length. v2: Rebased on top of Oleg's latest changes and run-tested. v3: Removed unnecessary cast.

Re: [PATCH 1/4] drivers/base: add managed token devres interfaces

2014-05-01 Thread Tejun Heo
Hello, On Tue, Apr 29, 2014 at 01:49:23PM -0600, Shuah Khan wrote: > +/* creates a token devres and marks it available */ > +int devm_token_create(struct device *dev, const char *id) > +{ > + struct token_devres *tkn; > + size_t tkn_size; > + > + tkn_size = sizeof(struct token_devres)

Re: [PATCH 4/4] workqueue: Handle ordered workqueues on cpumask_unbounds change

2014-05-01 Thread Frederic Weisbecker
On Thu, Apr 24, 2014 at 11:33:20AM -0400, Tejun Heo wrote: > On Thu, Apr 24, 2014 at 04:37:36PM +0200, Frederic Weisbecker wrote: > > Ordered unbound workqueues need some special care if we want to > > modify their CPU affinity. These can't be simply handled through > > apply_workqueue_attrs()

Re: [PATCH 3/4] workqueue: Allow modifying low level unbound workqueue cpumask

2014-05-01 Thread Frederic Weisbecker
On Thu, Apr 24, 2014 at 11:30:48AM -0400, Tejun Heo wrote: > On Thu, Apr 24, 2014 at 04:37:35PM +0200, Frederic Weisbecker wrote: > > +static int apply_workqueue_attrs_locked(struct workqueue_struct *wq, > > + const struct workqueue_attrs *attrs); > > Can't we

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

2014-05-01 Thread Geert Uytterhoeven
Hi Grant, On Thu, May 1, 2014 at 3:56 PM, Grant Likely wrote: > On Thu, May 1, 2014 at 2:41 PM, Geert Uytterhoeven > wrote: >> On Thu, May 1, 2014 at 10:03 AM, Grant Likely >> wrote: >>> On Wed, 30 Apr 2014 23:54:37 +0200, Geert Uytterhoeven >>> wrote: On Tue, Apr 29, 2014 at 3:16 PM,

RE: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-01 Thread suresh.gu...@freescale.com
Give me some time (actually some days), I will try this and update you. > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, May 01, 2014 1:42 AM > To: Paul Fertser > Cc: Felipe Balbi; Li Yang-Leo-R58472; linux-...@vger.kernel.org; linux- >

Re: [PATCH 2/4] workqueue: Split apply attrs code from its locking

2014-05-01 Thread Tejun Heo
On Thu, May 01, 2014 at 04:40:21PM +0200, Frederic Weisbecker wrote: > > lockdep_assert_held() > > Not sure... Only a small part of the function actually needs to be locked. > Namely > those doing the pwq allocations, which already have the lockdep_assert_held(). Ah, in that case, never mind.

Re: [PATCH 2/4] workqueue: Split apply attrs code from its locking

2014-05-01 Thread Frederic Weisbecker
On Thu, Apr 24, 2014 at 10:48:32AM -0400, Tejun Heo wrote: > On Thu, Apr 24, 2014 at 04:37:34PM +0200, Frederic Weisbecker wrote: > > +static int apply_workqueue_attrs_locked(struct workqueue_struct *wq, > > + const struct workqueue_attrs *attrs) > > { > >

Re: mm: hangs in collapse_huge_page

2014-05-01 Thread Hillf Danton
hi all On Wed, Apr 30, 2014 at 11:42 PM, Kirill A. Shutemov wrote: > On Tue, Apr 15, 2014 at 10:06:56PM -0400, Sasha Levin wrote: >> Hi all, >> >> I often see hung task triggering in khugepaged within collapse_huge_page(). >> >> I've initially assumed the case may be that the guests are too

Re: [PATCH 11/17] mm: page_alloc: Use unsigned int for order in more places

2014-05-01 Thread Dave Hansen
On 05/01/2014 01:44 AM, Mel Gorman wrote: > X86 prefers the use of unsigned types for iterators and there is a > tendency to mix whether a signed or unsigned type if used for page > order. This converts a number of sites in mm/page_alloc.c to use > unsigned int for order where possible. Does this

Re: dcache shrink list corruption?

2014-05-01 Thread Al Viro
On Thu, May 01, 2014 at 11:42:52AM +0200, Miklos Szeredi wrote: > Two points about latest version (dentry_kill-2): > > - Doing anything with dentry->d_parent in case of DCACHE_DENTRY_KILLED looks > seriously wrong. Parent has been dealt with, at that point, by the other > caller, no? In

[PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-01 Thread Marcel Apfelbaum
When a board is added, the shpchp driver checks if there is a mismatch between the bridge's adapter and the bus speed. If there is, it sets the subordinate speed (if there is no device on it). However, it takes the reference of the board speed from the primary bus and not from the subordinate. If

Re: [PATCH] spi: Fix hung task timeout when initialization fails

2014-05-01 Thread Geert Uytterhoeven
On Thu, May 1, 2014 at 4:11 PM, Mark Brown wrote: > On Thu, May 01, 2014 at 07:53:58AM +0200, Ricardo Ribalda Delgado wrote: > >> Thanks for your comments. This fix does not avoid the task being >> killed (which is not an error). What it does is that IF the task is >> killed or we are out of

Re: [PATCH] random: Add "initialized" variable to proc

2014-05-01 Thread Jason Cooper
On Wed, Apr 30, 2014 at 10:37:00PM -0700, H. Peter Anvin wrote: > > > On Apr 30, 2014, at 19:06, "Theodore Ts'o" wrote: > > > >> On Wed, Apr 30, 2014 at 01:52:35PM -0700, Andy Lutomirski wrote: > >> > >> 1. It simply doesn't work on my system. In particular, it never returns > >> entropy. It

Re: [PATCH v2 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-05-01 Thread Alan Stern
On Wed, 30 Apr 2014, Vivek Gautam wrote: > Change to use struct device instead of struct platform_device > for some static functions. > > Signed-off-by: Vivek Gautam > Cc: Alan Stern > Acked-by: Jingoo Han > --- For all four patches in this series: Acked-by: Alan Stern -- To unsubscribe

Re: [RFC 09/16] kgr: mark task_safe in some kthreads

2014-05-01 Thread Tejun Heo
On Wed, Apr 30, 2014 at 04:30:42PM +0200, Jiri Slaby wrote: > Some threads do not use kthread_should_stop. Before we enable a Haven't really following kgraft development but is it safe to assume that all kthread_should_stop() usages are clean side-effect-less boundaries? If so, why is that

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Vince Weaver
On Thu, 1 May 2014, Vince Weaver wrote: > On Wed, 30 Apr 2014, Peter Zijlstra wrote: > > > Vince, could you add the below to whatever tracing muck you already > > have? and this might be what you're looking for. This is with a different random seed than the one I've used for other traces,

Re: [PATCH v2 03/12] ARM: keystone: add MTD_SPI_NOR (new dependency for M25P80)

2014-05-01 Thread Santosh Shilimkar
On Thursday 01 May 2014 02:26 AM, Brian Norris wrote: > This defconfig contains the CONFIG_M25P80 symbol, which is now > dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to satisfy > the new dependency. > > Signed-off-by: Brian Norris > Cc: Santosh Shilimkar > Cc:

Re: [PATCH v12 30/31] ARM: dts: add System MMU nodes of exynos5250

2014-05-01 Thread Cho KyongHo
On Mon, 28 Apr 2014 16:13:19 -0700, Doug Anderson wrote: > Vikas, > > > On Sun, Apr 27, 2014 at 10:39 AM, Vikas Sajjan wrote: > > Hi shaik, > > > > +Doug, Abhilash, > > > > On Sun, Apr 27, 2014 at 1:08 PM, Shaik Ameer Basha > > wrote: > >> From: Cho KyongHo > >> > >> Signed-off-by: Cho

Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

2014-05-01 Thread Mark Brown
On Thu, May 01, 2014 at 04:59:08PM +0530, Tushar Behera wrote: > Okay, I will extend the existing clock driver to support XCLKOUT. It may make more sense to add another clock driver for this clock depending on how things are done, I don't know. > Of the many parents of XCLKOUT, we need to set

Re: [RFC PATCH RT] netconsole: enable netconsole on PREEMPT_RT

2014-05-01 Thread Paul Gortmaker
On 14-04-29 01:55 PM, Daniel Bristot de Oliveira wrote: > Dear RT Folks, > > This patch enables the netconsole on PREEMPT_RT_FULL, netconsole > was disabled on commit: > cb7cb77 kconfig-disable-a-few-options-rt.patch > > I tested the netconsole on three machines: > > - Intel Core i5 (4 cpus) -

Re: [PATCH] ptrace: Fix PTRACE_GETREGSET/PTRACE_SETREGSET in code documentation

2014-05-01 Thread Pedro Alves
On 04/28/2014 12:00 PM, Anshuman Khandual wrote: > The current documentation is bit misleading and does not explicitly > specify that iov.len need to be initialized failing which kernel > may just ignore the ptrace request and never read from/write into > the user specified buffer. This patch

Re: [PATCH] spi: Fix hung task timeout when initialization fails

2014-05-01 Thread Mark Brown
On Thu, May 01, 2014 at 07:53:58AM +0200, Ricardo Ribalda Delgado wrote: > Thanks for your comments. This fix does not avoid the task being > killed (which is not an error). What it does is that IF the task is > killed or we are out of memory we will exit with all the resources > properly

Re: [PATCH v12 18/31] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-05-01 Thread Cho KyongHo
On Mon, 28 Apr 2014 16:08:14 +0530, Tushar Behera wrote: > On 04/27/2014 01:07 PM, Shaik Ameer Basha wrote: > > From: Cho KyongHo > > > > Some master device descriptor like fimc-is which is an abstraction > > of very complex H/W may have multiple System MMUs. For those devices, > > the design of

Re: [PATCH v12 15/31] iommu/exynos: handle 'mmu-masters' property of DT and improve handling sysmmu

2014-05-01 Thread Cho KyongHo
On Sun, 27 Apr 2014 20:17:48 +0200, Arnd Bergmann wrote: > On Sunday 27 April 2014 13:07:47 Shaik Ameer Basha wrote: > > @@ -542,14 +592,41 @@ static int __init exynos_sysmmu_probe(struct > > platform_device *pdev) > > } > > } > > > > + /* Relation between master and System

Re: [PATCH] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t

2014-05-01 Thread James Bottomley
On Wed, 2014-04-30 at 14:33 -0600, Bjorn Helgaas wrote: > dma_declare_coherent_memory() takes two addresses for a region of memory: a > "bus_addr" and a "device_addr". I think the intent is that "bus_addr" is > the physical address a *CPU* would use to access the region, and > "device_addr" is

Re: [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent

2014-05-01 Thread Santosh Shilimkar
On Thursday 01 May 2014 09:25 AM, Russell King - ARM Linux wrote: > On Thu, May 01, 2014 at 09:19:18AM -0400, Santosh Shilimkar wrote: >> Rob, Russell, >> >> On Thursday 24 April 2014 11:30 AM, Santosh Shilimkar wrote: >>> Here is an updated v3 of the series. Series introduces support for setting

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-01 Thread John David Anglin
On 4/30/2014 5:26 PM, Helge Deller wrote: This patch makes the stack size configurable and uses 80MB as default value which has been in use during the last few years on parisc and which didn't showed any problems yet. Signed-off-by: Helge Deller Cc:linux-par...@vger.kernel.org

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Vince Weaver
On Wed, 30 Apr 2014, Peter Zijlstra wrote: > Vince, could you add the below to whatever tracing muck you already > have? OK, running with your patch, I get this messages a few times. No crashing or memory corruption messages, but as I've said before that only happens maybe 10% of the time,

[PATCH V3] bio: modify __bio_add_page() to accept pages that don't start a new segment

2014-05-01 Thread Maurizio Lombardi
The original behaviour is to refuse to add a new page if the maximum number of segments has been reached, regardless of the fact the page we are going to add can be merged into the last segment or not. Unfortunately, when the system runs under heavy memory fragmentation conditions, a driver may

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

2014-05-01 Thread Grant Likely
On Thu, May 1, 2014 at 2:41 PM, Geert Uytterhoeven wrote: > Hi Grant, > > On Thu, May 1, 2014 at 10:03 AM, Grant Likely > wrote: >> On Wed, 30 Apr 2014 23:54:37 +0200, Geert Uytterhoeven >> wrote: >>> On Tue, Apr 29, 2014 at 3:16 PM, Grant Likely >>> wrote: >>> > I also don't like that it

Re: [PATCH] DMA-API: Clarify physical/bus address distinction

2014-05-01 Thread Randy Dunlap
On 04/30/2014 12:42 PM, Bjorn Helgaas wrote: The DMA-API documentation sometimes refers to "physical addresses" when it really means "bus addresses." Historically these were often the same, but they may be different if the bridge leading to the bus performs address transaction. Update the

Re: [PATCH 14/17] mm: Do not use atomic operations when releasing pages

2014-05-01 Thread Johannes Weiner
On Thu, May 01, 2014 at 02:39:38PM +0100, Mel Gorman wrote: > On Thu, May 01, 2014 at 09:29:22AM -0400, Johannes Weiner wrote: > > On Thu, May 01, 2014 at 09:44:45AM +0100, Mel Gorman wrote: > > > There should be no references to it any more and a parallel mark should > > > not be reordered

Re: [PATCH] usb: dwc3: gadget: fix burst size corruption

2014-05-01 Thread Alan Stern
On Thu, 1 May 2014, Zhuang Jin Can wrote: > > again, you found a bug on the gadget driver. Fix that. composite.c > > guarantees that for those functions which don't pass bMaxBurst, > > gadget->maxburst will be set to *at least* 1. > > > I agree the real fix should be in the gadget driver. The

Re: [PATCH 2/3] powerpc, ptrace: Add new ptrace request macros for transactional memory

2014-05-01 Thread Pedro Alves
On 04/28/2014 11:30 AM, Anshuman Khandual wrote: > On 04/26/2014 05:12 AM, Pedro Alves wrote: >> On 04/02/2014 08:02 AM, Anshuman Khandual wrote: >>> This patch adds following new sets of ptrace request macros for >>> transactional >>> memory expanding the existing ptrace ABI on PowerPC. >>> >>>

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

2014-05-01 Thread Geert Uytterhoeven
Hi Grant, On Thu, May 1, 2014 at 10:03 AM, Grant Likely wrote: > On Wed, 30 Apr 2014 23:54:37 +0200, Geert Uytterhoeven > wrote: >> On Tue, Apr 29, 2014 at 3:16 PM, Grant Likely >> wrote: >> > I also don't like that it tries to set up every clock, but there is no >> > guarantee that the

Re: [PATCH 15/17] mm: Do not use unnecessary atomic operations when adding pages to the LRU

2014-05-01 Thread Mel Gorman
On Thu, May 01, 2014 at 09:33:40AM -0400, Johannes Weiner wrote: > On Thu, May 01, 2014 at 09:44:46AM +0100, Mel Gorman wrote: > > When adding pages to the LRU we clear the active bit unconditionally. As the > > page could be reachable from other paths we cannot use unlocked operations > > without

Re: [PATCH 14/17] mm: Do not use atomic operations when releasing pages

2014-05-01 Thread Mel Gorman
On Thu, May 01, 2014 at 09:29:22AM -0400, Johannes Weiner wrote: > On Thu, May 01, 2014 at 09:44:45AM +0100, Mel Gorman wrote: > > There should be no references to it any more and a parallel mark should > > not be reordered against us. Use non-locked varient to clear page active. > > > >

Re: [PATCH 2/2] mm/memcontrol.c: introduce helper mem_cgroup_zoneinfo_zone()

2014-05-01 Thread Johannes Weiner
[fix Andrew's email address] On Thu, May 01, 2014 at 08:54:50AM -0400, Johannes Weiner wrote: > On Mon, Apr 28, 2014 at 05:04:26PM +0200, Michal Hocko wrote: > > On Tue 22-04-14 11:59:23, Michal Hocko wrote: > > > On Sat 19-04-14 07:01:43, Jianyu Zhan wrote: > > > > introduce helper

Re: [PATCH 15/17] mm: Do not use unnecessary atomic operations when adding pages to the LRU

2014-05-01 Thread Johannes Weiner
On Thu, May 01, 2014 at 09:44:46AM +0100, Mel Gorman wrote: > When adding pages to the LRU we clear the active bit unconditionally. As the > page could be reachable from other paths we cannot use unlocked operations > without risk of corruption such as a parallel mark_page_accessed. This > patch

Re: [PATCH 14/17] mm: Do not use atomic operations when releasing pages

2014-05-01 Thread Johannes Weiner
On Thu, May 01, 2014 at 09:44:45AM +0100, Mel Gorman wrote: > There should be no references to it any more and a parallel mark should > not be reordered against us. Use non-locked varient to clear page active. > > Signed-off-by: Mel Gorman > --- > mm/swap.c | 2 +- > 1 file changed, 1

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Thomas Gleixner
On Thu, 1 May 2014, Thomas Gleixner wrote: > On Thu, 1 May 2014, Peter Zijlstra wrote: > > On Thu, May 01, 2014 at 12:26:02PM +0200, Peter Zijlstra wrote: > > > On Thu, May 01, 2014 at 12:51:33AM +0200, Thomas Gleixner wrote: > > > > And that's the issue which puzzles us. Let's look at what we

Re: [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent

2014-05-01 Thread Russell King - ARM Linux
On Thu, May 01, 2014 at 09:19:18AM -0400, Santosh Shilimkar wrote: > Rob, Russell, > > On Thursday 24 April 2014 11:30 AM, Santosh Shilimkar wrote: > > Here is an updated v3 of the series. Series introduces support for setting > > up > > dma parameters based on device tree properties like

Re: [PATCH 01/17] mm: page_alloc: Do not update zlc unless the zlc is active

2014-05-01 Thread Johannes Weiner
On Thu, May 01, 2014 at 09:44:32AM +0100, Mel Gorman wrote: > The zlc is used on NUMA machines to quickly skip over zones that are full. > However it is always updated, even for the first zone scanned when the > zlc might not even be active. As it's a write to a bitmap that potentially > bounces

Re: [PATCH 1/1] ARCH/M68K/AMIGA: convert printk to pr_foo()

2014-05-01 Thread Geert Uytterhoeven
CC linux-m68k Hi Fabian Thanks for your patch. A few comments below. On Thu, May 1, 2014 at 9:02 AM, Fabian Frederick wrote: > -no level printk converted to pr_warn/pr_info > -fixed a small identation problem > > This is untested > > Cc: Geert Uytterhoeven > Cc: Andrew Morton >

Re: [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent

2014-05-01 Thread Santosh Shilimkar
Rob, Russell, On Thursday 24 April 2014 11:30 AM, Santosh Shilimkar wrote: > Here is an updated v3 of the series. Series introduces support for setting up > dma parameters based on device tree properties like 'dma-ranges' and > 'dma-coherent' and also update to ARM 32 bit port. Earlier version of

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Vince Weaver
On Thu, 1 May 2014, Peter Zijlstra wrote: > On Thu, May 01, 2014 at 12:51:33AM +0200, Thomas Gleixner wrote: > > And that's the issue which puzzles us. Let's look at what we expect: > > > > Now the trace shows a different story: > > > > perf_fuzzer-4387 [001] 1802.628659: sys_enter:

Re: [PATCH v3 4/7] of: configure the platform device dma parameters

2014-05-01 Thread Santosh Shilimkar
On Thursday 01 May 2014 09:12 AM, Grant Likely wrote: > On Wed, 30 Apr 2014 10:19:15 -0400, Santosh Shilimkar > wrote: >> Hi Grant, >> >> On Tuesday 29 April 2014 10:41 AM, Grant Likely wrote: >>> On Thu, 24 Apr 2014 11:30:04 -0400, Santosh Shilimkar >>> wrote: Retrieve DMA configuration

Re: [PATCH] earlyprintk=efi,keep fix

2014-05-01 Thread Dave Young
On 05/01/14 at 11:12am, Matt Fleming wrote: > On Wed, 30 Apr, at 10:13:03AM, Dave Young wrote: > > > > earlyprintk=efi,keep will cause kernel hangs while freeing initmem like > > below: > > [2.826089] VFS: Mounted root (ext4 filesystem) readonly on device 254:2. > > [2.846592] devtmpfs:

Re: [RFC PATCH 2/3] of: mtd: add NAND randomizer mode retrieval

2014-05-01 Thread Grant Likely
On Thu, 1 May 2014 03:09:51 +0200, Boris BREZILLON wrote: > Signed-off-by: Boris BREZILLON > --- No commit message? Immediate NAK. Please, make sure you write a description for each and every patch. This is not optional. Future readers want to know what this patch solves and any other

[PATCH V2] earlyprintk=efi,keep fix

2014-05-01 Thread Dave Young
earlyprintk=efi,keep will cause kernel hangs while freeing initmem like below: [2.826089] VFS: Mounted root (ext4 filesystem) readonly on device 254:2. [2.846592] devtmpfs: mounted [2.856974] Freeing unused kernel memory: 880K (817d4000 - 818b) It is caused by

Re: [PATCH v3 4/7] of: configure the platform device dma parameters

2014-05-01 Thread Grant Likely
On Wed, 30 Apr 2014 10:19:15 -0400, Santosh Shilimkar wrote: > Hi Grant, > > On Tuesday 29 April 2014 10:41 AM, Grant Likely wrote: > > On Thu, 24 Apr 2014 11:30:04 -0400, Santosh Shilimkar > > wrote: > >> Retrieve DMA configuration from DT and setup platform device's DMA > >> parameters. The

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Peter Zijlstra
On Thu, May 01, 2014 at 02:35:02PM +0200, Thomas Gleixner wrote: > > grep ptr=0x880118fda000 bug.out | less > > > > We find lovely bits such as: > > > > perf_fuzzer-4387 [001] 1773.427175: kmalloc: > > (perf_event_alloc+0x5a) call_site=8113a8fa

Re: [PATCHv5 2/2] arm: Get rid of meminfo

2014-05-01 Thread Grant Likely
On Thu, 3 Apr 2014 10:04:58 -0700, Laura Abbott wrote: > memblock is now fully integrated into the kernel and is the prefered > method for tracking memory. Rather than reinvent the wheel with > meminfo, migrate to using memblock directly instead of meminfo as > an intermediate. > > Change-Id:

Re: [PATCH 1/1] mm/memcontrol.c: remove NULL assignment on static

2014-05-01 Thread Johannes Weiner
On Sat, Apr 26, 2014 at 10:50:31AM +0200, Fabian Frederick wrote: > static values are automatically initialized to NULL > > Cc: Johannes Weiner > Cc: Andrew Morton > Signed-off-by: Fabian Frederick > --- > mm/memcontrol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 2/2] mm/memcontrol.c: introduce helper mem_cgroup_zoneinfo_zone()

2014-05-01 Thread Johannes Weiner
On Mon, Apr 28, 2014 at 05:04:26PM +0200, Michal Hocko wrote: > On Tue 22-04-14 11:59:23, Michal Hocko wrote: > > On Sat 19-04-14 07:01:43, Jianyu Zhan wrote: > > > introduce helper mem_cgroup_zoneinfo_zone(). This will make > > > mem_cgroup_iter() code more compact. > > > > I dunno. Helpers are

Re: [alsa-devel] [PATCH 01/15] ASoC: CS42L51 and WM8962 codecs depend on INPUT

2014-05-01 Thread Austin, Brian
> On Apr 30, 2014, at 22:28, "Mark Brown" wrote: > >> On Thu, May 01, 2014 at 02:16:27AM +, Austin, Brian wrote: >> >> Apparently not. >> I would like to come up with a better solution than making INPUT a >> requirement. I just need some time. >> In the meantime I suppose it’s OK to

Re: [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-05-01 Thread Barry Song
2014-04-24 5:16 GMT+08:00 Linus Walleij : > Instead of referring to a global static variable for the sgpio > locking, use the state container to contain the lock. > > Signed-off-by: Linus Walleij hi Linus, thanks! this looks very good only if we fix the gpiochip_add_pin_range() failure in patch

Re: [PATCH] aio: fix potential leak in aio_run_iocb().

2014-05-01 Thread Benjamin LaHaise
On Thu, May 01, 2014 at 03:31:28AM +, Leon Yu wrote: > iovec should be reclaimed whenever caller of rw_copy_check_uvector() returns, > but it doesn't hold when failure happens right after aio_setup_vectored_rw(). > > Fix that in a such way to avoid hairy goto. Good catch -- applied.

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Thomas Gleixner
On Thu, 1 May 2014, Peter Zijlstra wrote: > On Thu, May 01, 2014 at 12:26:02PM +0200, Peter Zijlstra wrote: > > On Thu, May 01, 2014 at 12:51:33AM +0200, Thomas Gleixner wrote: > > > And that's the issue which puzzles us. Let's look at what we expect: > > > > > > Now the trace shows a different

Re: [Suggestion] unicore32: About toolchain issues and source code.

2014-05-01 Thread GUAN, Xuetao
Yes, please use 1.0.5 version. I'll check and fix these problems in this month. Thanks Chen & Guenter. Sent from my iPhone > On May 1, 2014, at 2:48 AM, Guenter Roeck wrote: > >> On Wed, Apr 30, 2014 at 09:14:42AM +0800, Chen Gang wrote: >> Hello Maintainers: >> >> - Toolchain information:

Re: [PATCH 1/2] RFT: pinctrl: sirf: switch to using allocated state container

2014-05-01 Thread Barry Song
2014-04-24 5:16 GMT+08:00 Linus Walleij : > This rewrites the SIRF pinctrl driver to allocate a state container > for the GPIO chip, just as is done for the pin controller, and > use the gpiochip_add_pin_range() to add the range from the gpiochip > side rather than adding the range from the

Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Mateusz Guzik
On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: > Fix a potential leak in the error path of function update_bcn_wps_ie(). > Make sure that allocated memory for 'pbackup_remainder_ie' is freed > upon return. Detected by Coverity - CID 1077718. > if (remainder_ielen >

Re: Hi

2014-05-01 Thread bvlfna
Dear Client Do you need a quick loan to establish, for estate license, to buy car, house, no problem we offer Personal loan, Business loan Student loan and General loan, Why not take off for a little while, get away and enjoy yourself we also offer loan for vacation. For more information

Re: Hi

2014-05-01 Thread bvlfna
Dear Client Do you need a quick loan to establish, for estate license, to buy car, house, no problem we offer Personal loan, Business loan Student loan and General loan, Why not take off for a little while, get away and enjoy yourself we also offer loan for vacation. For more information

[PATCH] staging: rtl8188eu: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Christian Engelmayer
Fix a potential leak in the error path of function update_bcn_wps_ie(). Make sure that allocated memory for 'pbackup_remainder_ie' is freed upon return. Detected by Coverity - CID 1077718. Signed-off-by: Christian Engelmayer --- Compile tested and applies against branch staging-next of tree

Re: [PATCH (for 3.15) 0/5] Fix cross rename race window for LSM.

2014-05-01 Thread Tetsuo Handa
James, would you send this patchset to Linus? This patchset is expected to go to 3.15 because this is a kind of regression fix. Tetsuo Handa wrote: > Miklos Szeredi wrote: > > On Sat, Apr 19, 2014 at 2:08 PM, Tetsuo Handa > > wrote: > > > Michael Kerrisk (man-pages) wrote: > > >> Now that

[PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Christian Engelmayer
Fix a potential leak in the error path of function update_bcn_wps_ie(). Make sure that allocated memory for 'pbackup_remainder_ie' is freed upon return. Detected by Coverity - CID 1077718. Signed-off-by: Christian Engelmayer --- Compile tested and applies against branch staging-next of tree

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Peter Zijlstra
On Thu, May 01, 2014 at 12:26:02PM +0200, Peter Zijlstra wrote: > On Thu, May 01, 2014 at 12:51:33AM +0200, Thomas Gleixner wrote: > > And that's the issue which puzzles us. Let's look at what we expect: > > > > Now the trace shows a different story: > > > > perf_fuzzer-4387 [001]

Re: linux-3.14 nfsd regression

2014-05-01 Thread Mark Lord
On 14-04-04 09:58 AM, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 07:21:46PM -0400, Jeff Layton wrote: >> So according to the RFC you have to encode both the mode bits and the >> ftype for v2. The type bits seem to be removed from the mode in NFSv3 >> though, so perhaps we should only be

Re: [PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit

2014-05-01 Thread Alexey Charkov
2014-05-01 13:30 GMT+04:00 David Laight : > From: Alexey Charkov [mailto:alch...@gmail.com] > ... >> This patch removes the cast altogether, and instead stores an actual >> pointer to u8 in match->data. All instances of 'revision' are also >> unified to u8 instead of an assortment of different

Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

2014-05-01 Thread Tushar Behera
On 04/30/2014 11:33 PM, Mark Brown wrote: > On Wed, Apr 30, 2014 at 05:30:39PM +0530, Tushar Behera wrote: > >> XCLKOUT mux register (0x10040a00) is not part of core clock SFR range, >> rather it is part of pmu-system-controller node. > >> One option would be to add a clock provider for XCLKOUT.

[RESEND PATCH 2/2] printk: report dropping of messages from logbuf

2014-05-01 Thread Will Deacon
If the log ring buffer becomes full, we silently overwrite old messages with new data. console_unlock will detect this case and fast-forward the console_* pointers to skip over the corrupted data, but nothing will be reported to the user. This patch hijacks the first valid log message after

[RESEND PATCH 1/2] printk: print initial logbuf contents before re-enabling interrupts

2014-05-01 Thread Will Deacon
When running on a hideously slow system (~10Mhz FPGA) with a bunch of debug printk invocations on the timer interrupt path, we end up filling the log buffer faster than we can drain it. The reason is that console_unlock (which is responsible for moving messages out of logbuf to hand over to the

[GIT PULL] hwmon fixes for 3.15-rc4

2014-05-01 Thread Guenter Roeck
Hi Linus, Please pull hwmon fixes for Linux 3.15-rc4 from signed tag: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-linus Thanks, Guenter -- The following changes since commit d1db0eea852497762cab43b905b879dfcd3b8987: Linux 3.15-rc3 (2014-04-27

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-01 Thread James Hogan
Hi Helge, On 30/04/14 22:26, Helge Deller wrote: > This patch affects only architectures where the stack grows upwards > (currently parisc and metag only). On those do not hardcode the maximum > initial stack size to 1GB, but make it configurable via a config option. > > The main problem with

Re: [PATCH 00/18] Cross-architecture definitions of relaxed MMIO accessors

2014-05-01 Thread Will Deacon
Hi Ben, On Thu, Apr 17, 2014 at 10:36:58PM +0100, Benjamin Herrenschmidt wrote: > On Thu, 2014-04-17 at 16:00 +0200, Peter Zijlstra wrote: > > > So the non-relaxed ops already imply the expensive I/O barrier (mmiowb?) > > and therefore, PPC can drop it from spin_unlock()? > > We play a trick.

Re: [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key()

2014-05-01 Thread Dan Carpenter
On Thu, May 01, 2014 at 12:30:57PM +0200, Christian Engelmayer wrote: > Fix a potential leak in the error path of rtw_set_key(). In case the requested > algorithm is not supported by the driver, the function returns without > enqueuing or freeing the already allocated command and parameter

[PATCH] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()

2014-05-01 Thread Christian Engelmayer
Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the requested algorithm is not supported by the driver, the function returns without freeing the already allocated 'param' struct. Move the input verification to the beginning of the function so that the direct return is

[PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key()

2014-05-01 Thread Christian Engelmayer
Fix a potential leak in the error path of rtw_set_key(). In case the requested algorithm is not supported by the driver, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed

Re: [perf] more perf_fuzzer memory corruption

2014-05-01 Thread Peter Zijlstra
On Thu, May 01, 2014 at 12:51:33AM +0200, Thomas Gleixner wrote: > And that's the issue which puzzles us. Let's look at what we expect: > > Now the trace shows a different story: > > perf_fuzzer-4387 [001] 1802.628659: sys_enter:NR 298 > (69bb58, 0, , 12, 0, 0)

Re: [PATCH] earlyprintk=efi,keep fix

2014-05-01 Thread Matt Fleming
On Wed, 30 Apr, at 10:13:03AM, Dave Young wrote: > > earlyprintk=efi,keep will cause kernel hangs while freeing initmem like below: > [2.826089] VFS: Mounted root (ext4 filesystem) readonly on device 254:2. > [2.846592] devtmpfs: mounted > [2.856974] Freeing unused kernel memory: 880K

[PATCH 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-05-01 Thread Lee Jones
MTD Folks, This driver is now at v1. Suggestions from the RFC patch-set have now been applied. None of the framework internals are now exported for use within the driver, as it now uses the 'ecc' call-backs provided. Hopefully the driver now conforms to what's expected and will be suitable to

<    1   2   3   4   5   6   7   8   9   10   >