This should fix a few sparse warnings like the following:
CHECK drivers/staging/rtl8723au/core/rtw_ap.c
drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect type in
argument 3 (different base types)
drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:expected int [signed] gfp
d
This patch moves data allocated using kzalloc to managed data allocated
using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
functions. Also, the unnecessary label out_free is removed.
The following Coccinelle semantic patch was used for making the change:
@platform@
identifie
Hi Davidlohr,
On 05/13/2014 10:27 PM, Davidlohr Bueso wrote:
The need for volatile is not obvious, document it.
Signed-off-by: Davidlohr Bueso
Signed-off-by: Manfred Spraul
In the long run, it would be great if the logic from sem.c would be
moved to one central place.
- wake_up_sem_queue_
On 05/13/2014 10:27 PM, Davidlohr Bueso wrote:
When specifying the MSG_NOERROR flag, receivers can avoid returning
error (E2BIG) and just truncate the message text, if it is too large.
Currently, this logic is only respected when there are already pending
messages in the queue.
Do you have a te
On Sun, May 18, 2014 at 06:22:34AM +0200, Mike Galbraith wrote:
> On Thu, 2014-05-15 at 05:18 +0200, Mike Galbraith wrote:
> > On Wed, 2014-05-14 at 08:44 -0700, Paul E. McKenney wrote:
> >
> > > In practice, not sure how much testing CONFIG_NO_HZ_FULL=y has received
> > > for -rt kernels in prod
Peter Senna Tschudin writes:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
This ret variable pattern is pretty standard in Linux, as it makes it
easier to add
On Sat, May 17, 2014 at 9:12 PM, Joe Perches wrote:
> On Sat, 2014-05-17 at 21:00 -0700, David Matlack wrote:
> []
>> diff --git a/drivers/staging/slicoss/slicoss.c
>> b/drivers/staging/slicoss/slicoss.c
> []
>> +static inline u16 __reduce(u32 checksum)
>> +{
>> + u16 lower_16 = checksum & 0x
On Thu, 2014-05-15 at 05:18 +0200, Mike Galbraith wrote:
> On Wed, 2014-05-14 at 08:44 -0700, Paul E. McKenney wrote:
>
> > In practice, not sure how much testing CONFIG_NO_HZ_FULL=y has received
> > for -rt kernels in production environments.
>
> I took 3.14-rt out for a quick spin on my 64 cor
On Sat, 2014-05-17 at 21:00 -0700, David Matlack wrote:
[]
> diff --git a/drivers/staging/slicoss/slicoss.c
> b/drivers/staging/slicoss/slicoss.c
[]
> +static inline u16 __reduce(u32 checksum)
> +{
> + u16 lower_16 = checksum & 0x;
> + u16 upper_16 = (checksum >> 16) & 0x;
> +
> +
I saw that remap_file_pages() was possibly going away to be replaced
by some emulation. I've used this call in several projects over the
years mostly as a way of mapping multiple virtual memory pages to
alias the same private or shared memory region (to do things like
circular buffers). mmap()
in t
Rewrite slic_eeprom_cksum() to fix bugs and make readable. The original
implementation had the following issues:
1. 2 of the 3 unrolled loops had the following bug:
while ((len -= 32) >= 0) {
[...]
sum += w[15];
w = (u16 *)((ulong) w + 16);
Remove uninitialized struct that is only used to regulate whether
incorrect eeprom checksums are ignored.
Signed-off-by: David Matlack
---
drivers/staging/slicoss/slic.h| 7 ---
drivers/staging/slicoss/slicoss.c | 3 +--
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drive
This patchset fixes a broken checksum function and removes a struct
that was being used to ignore bad checksum values.
David Matlack (2):
staging: slicoss: rewrite eeprom checksum code
staging: slicoss: remove slic_reg_params struct
drivers/staging/slicoss/slic.h| 7 --
drivers/staging
Hello,
On Sat, May 17, 2014 at 05:45:40PM -0500, Christoph Lameter wrote:
> On Fri, 16 May 2014, Tejun Heo wrote:
>
> > > Make the uevent stuff work on all of sysfs?
> >
> > I don't know. Maybe. Likely a lot more work involving user space
> > changes tho. Also, it runs contrary to what we've b
Quoting Seth Forshee (seth.fors...@canonical.com):
> On Fri, May 16, 2014 at 09:31:37PM -0700, Eric W. Biederman wrote:
> > Greg Kroah-Hartman writes:
> >
> > > On Fri, May 16, 2014 at 01:49:59AM +, Serge Hallyn wrote:
> > >> > I think having to pick and choose what device nodes you want in a
Quoting James Bottomley (james.bottom...@hansenpartnership.com):
> On Fri, 2014-05-16 at 11:57 -0700, Greg Kroah-Hartman wrote:
> > On Fri, May 16, 2014 at 09:06:07AM -0500, Seth Forshee wrote:
> > > On Thu, May 15, 2014 at 09:35:32PM -0700, Greg Kroah-Hartman wrote:
> > > > On Fri, May 16, 2014 at
Fixed several switch statements, curly braces, dereference operators
and keywords.
Signed-off-by: Robin Schroer
---
drivers/gpu/drm/i915/intel_display.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm
Hello Tony,
On 14 May 02:50 PM, Tony Lindgren wrote:
> * George Cherian [140508 23:34]:
> > Re arrange the USB dt for AM33xx to take it a bit closer
> > to the hardware configuration.
> >
[..]
>
> Is this just a cosmetic change or is this trying to workaround
> some edma related init order issu
Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 48 +--
drivers/staging/dgnc/dgnc_tty.c | 36 ++--
This is the modified patches of
[PATCH x/4] Fix coding style of if statment
The following pateches fix the errors and warnings below in
dgnc_neo.c and dgnc_tty.c to meet kernel coding style.
ERROR: else should follow close brace '}'
ERROR: that open brace { should be on the previous line
WARNING
Remove unnecessary curly braces of if statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 60 -
drivers/staging/dgnc/dgnc_tty.c | 110 ++-
2 files change
Fix line over 80 characters and indenting of condition part.
Also, remove unnecessary braces to meet coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b
On Saturday 17 May 2014 17:34:34 Guenter Roeck wrote:
> On 05/16/2014 12:23 PM, Pali Rohár wrote:
> > On Friday 16 May 2014 21:11:17 Jean Delvare wrote:
> >> Hi Pali,
> >>
> >> On Fri, 16 May 2014 20:37:41 +0200, Pali Rohár wrote:
> >>> Hello,
> >>>
> >>> on Dell Latitude E6440 driver i8k reporti
Hello Russell,
On Sat, May 17, 2014 at 11:35:55PM +0100, Russell King - ARM Linux wrote:
> On Sun, May 18, 2014 at 01:08:36AM +0300, Dan Carpenter wrote:
> > Let's look at that error handling again.
> >
> > err: <-- the name is not descriptive. the location is bad.
> > kfree(pdev->d
On Fri, 2014-05-16 at 14:32 -0700, Nicholas A. Bellinger wrote:
> Hello Linus,
>
> Here are the target-pending fixes for v3.15-rc6. Please go ahead and
> pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
>
> This series include:
>
> - Close race bet
On Sat, May 17, 2014 at 11:35:55PM +0100, Russell King - ARM Linux wrote:
> On Sun, May 18, 2014 at 01:08:36AM +0300, Dan Carpenter wrote:
> > Let's look at that error handling again.
> >
> > err: <-- the name is not descriptive. the location is bad.
> > kfree(pdev->dev.dma_mask); <
On Friday 16 May 2014 21:11:17 you wrote:
> Hi Pali,
>
> On Fri, 16 May 2014 20:37:41 +0200, Pali Rohár wrote:
> > Hello,
> >
> > on Dell Latitude E6440 driver i8k reporting total nonsense
> > values
>
> That's kind of excessive wording, the output isn't that bad.
>
> > $ sensors
> > i8k-virtua
On Sat, 2014-05-17 at 06:49 -0400, Mikulas Patocka wrote:
> On each processed XCOPY command, two "kmalloc-512" memory objects are
> leaked. These represent two allocations of struct xcopy_pt_cmd in
> target_core_xcopy.c.
>
> The reason for the memory leak is that the cmd_kref field is not
> initia
Hello Dan,
On Sun, May 18, 2014 at 01:08:36AM +0300, Dan Carpenter wrote:
> On Sat, May 17, 2014 at 09:18:21PM +0200, Uwe Kleine-König wrote:
> > diff --git a/arch/arm/mach-imx/devices/platform-ipu-core.c
> > b/arch/arm/mach-imx/devices/platform-ipu-core.c
> > index fc4dd7cedc11..6bd7c3f37ac0 100
On Sat, May 17, 2014 at 03:09:57AM +0900, Masami Hiramatsu wrote:
> (2014/05/17 1:27), Jiri Kosina wrote:
> > On Tue, 6 May 2014, Steven Rostedt wrote:
> >
> >>> However, I also think if users can accept such freezing wait-time,
> >>> it means they can also accept kexec based "checkpoint-restart"
On Fri, 16 May 2014, Tejun Heo wrote:
> > Make the uevent stuff work on all of sysfs?
>
> I don't know. Maybe. Likely a lot more work involving user space
> changes tho. Also, it runs contrary to what we've been doing to other
> top-level cgroup directories. Any reason not to do, say,
> /sys/d
On Sun, May 18, 2014 at 12:31:29AM +0200, Peter Senna Tschudin wrote:
> >
> > I am currently involved in a number of threads, not just yours, where I
> > am encouraging people to replace ambiguous returns with "return 0;".
> > This is my life now.
> So maybe you like this list of 160 places in whic
On Sun, May 18, 2014 at 01:08:36AM +0300, Dan Carpenter wrote:
> Let's look at that error handling again.
>
> err: <-- the name is not descriptive. the location is bad.
> kfree(pdev->dev.dma_mask); <- null dereference.
> platform_device_put(pdev); <- ok
>
From: Colin Ian King
Commit 297e0dad7 introduced a bug where is_mcast is now
no longer initiialised on the non-multicast condition and so
it can be any random value from the stack. This issue was
detected by cppcheck:
[drivers/infiniband/hw/mlx4/ah.c:103]: (error) Uninitialized
variable: is_m
On Sat, May 17, 2014 at 11:56 PM, Dan Carpenter
wrote:
> On Sat, May 17, 2014 at 11:34:46PM +0200, Peter Senna Tschudin wrote:
>> On Sat, May 17, 2014 at 10:22 PM, Dan Carpenter
>> wrote:
>> > On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote:
>> >> diff --git a/tools/power/cpu
Hello Uwe,
I was to quick to resend the patch, sorry.
On Sat, May 17, 2014 at 09:18:21PM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> On Sat, May 17, 2014 at 08:40:33PM +0200, Emil Goode wrote:
> > If we fail to allocate struct platform_device pdev we
> > dereference it after the goto label
On 05/17/2014 02:09 PM, Jean Delvare wrote:
On Sat, 17 May 2014 08:25:38 -0700, Guenter Roeck wrote:
On 05/16/2014 12:11 PM, Jean Delvare wrote:
Load the i8k driver with fan_mult=1.
Would it make sense to change the default multiplier to 1 ?
Lots of people have problems with it, and trying to
Remove double checks, and move the call to print_error to the
first check. Replace break by return, and return 0 on success.
The simplified version of the coccinelle semantic patch that
fixes this issue is as follows:
//
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
Hello Uwe,
On Sat, May 17, 2014 at 09:05:46PM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> On Sat, May 17, 2014 at 05:35:40PM +0200, Emil Goode wrote:
> > On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
> > > On Fri, May 16, 2014 at 01:49:10PM +0200, walter harms wrote:
> >
On Sat, May 17, 2014 at 09:18:21PM +0200, Uwe Kleine-König wrote:
> diff --git a/arch/arm/mach-imx/devices/platform-ipu-core.c
> b/arch/arm/mach-imx/devices/platform-ipu-core.c
> index fc4dd7cedc11..6bd7c3f37ac0 100644
> --- a/arch/arm/mach-imx/devices/platform-ipu-core.c
> +++ b/arch/arm/mach-imx
On Sat, May 17, 2014 at 11:34:46PM +0200, Peter Senna Tschudin wrote:
> On Sat, May 17, 2014 at 10:22 PM, Dan Carpenter
> wrote:
> > On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote:
> >> diff --git a/tools/power/cpupower/utils/cpufreq-set.c
> >> b/tools/power/cpupower/utils/c
Function mlx4_en_set_channels() stops running ports before performing the
requested action. In that case local variable 'port_up' is set so that the
port is restarted at the end of the function, however, in case the port was
not stopped, variable 'port_up' is left uninitialized and the behaviour is
Remove double checks, and move calls to pr_err and printk to the
first check. The simplified version of the coccinelle semantic
patch that fixes this issue is as follows:
//
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+
On Sat, May 17, 2014 at 10:22 PM, Dan Carpenter
wrote:
> On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote:
>> diff --git a/tools/power/cpupower/utils/cpufreq-set.c
>> b/tools/power/cpupower/utils/cpufreq-set.c
>> index a416de8..4e2f35a 100644
>> --- a/tools/power/cpupower/util
On Sat, May 17, 2014 at 10:38:30PM +0200, Pali Rohár wrote:
> On Saturday 17 May 2014 22:30:54 Dmitry Torokhov wrote:
> > Hi Pali,
> >
> > On Sat, May 17, 2014 at 04:43:36PM +0200, Pali Rohár wrote:
> > > There are already defined some Fn key combinations, but not
> > > all. This patch adds missin
On Sat, May 17, 2014 at 04:37:25PM +0200, Manuel Schölling wrote:
[...]
> diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c
> index 6545809..43eeb1b 100644
> --- a/drivers/pinctrl/pinctrl-tegra.c
> +++ b/drivers/pinctrl/pinctrl-tegra.c
> @@ -576,7 +576,7 @@ static void
On Sat, May 17, 2014 at 10:14:52PM +0100, Masaru Nomura wrote:
> > Also just fold this patch and [patch 2/4] together into one patch. We
> > don't need two patches to fix one if statement.
> >
> > The one thing per patch rule is a bit tricky. It means that you have to
> > say which one thing you
Hi Dan,
Thank you for your detailed explanation!
> This isn't the right way. Write it like this:
>
> if ((ch->ch_digi.digi_flags & CTSPACE) ||
> (ch->ch_digi.digi_flags & RTSPACE) ||
> (ch->ch_c_cflag & CRTSCTS) ||
> !(ch->ch_digi.digi_flags & DIGI_FOR
Remove double checks, and move the call to pr_devel. Remove the
initialization of the result variable, and return VMCI_SUCCESS on
success. Fix the condition of the for loop. Replace break with a
return. The simplified version of the coccinelle semantic patch
that find the redundant check issue is a
On Sat, 17 May 2014, Bart Van Assche wrote:
> On 05/17/14 14:38, Mikulas Patocka wrote:
> > I found a memory leak in iSCSI target that was caused by kref initialized
> > to zero (the memory object was allocated with kzalloc, kref_init was not
> > called and kref_put_spinlock_irqsave was called w
On Sat, 17 May 2014 08:25:38 -0700, Guenter Roeck wrote:
> On 05/16/2014 12:11 PM, Jean Delvare wrote:
> > Load the i8k driver with fan_mult=1.
>
> Would it make sense to change the default multiplier to 1 ?
> Lots of people have problems with it, and trying to figure out
> affected machines one b
On Fri, May 16, 2014 at 10:05:18AM -0600, Stephen Warren wrote:
> On 05/16/2014 08:31 AM, Thierry Reding wrote:
> > On Fri, May 16, 2014 at 04:50:20PM +0300, Tuomas Tynkkynen wrote:
> >> The value written to PLLE_AUX was incorrect due to a wrong variable
> >> being used.
> >>
> >> Signed-off-by: Tu
Linus,
please pull the latest timers-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
timers-urgent-for-linus
A single bug fix for a long standing issue:
* Updating the expiry value of a relative timer _after_ letting the
idle logic select a targ
On Tue, May 13, 2014 at 2:38 PM, Jiri Kosina wrote:
> On Sun, 11 May 2014, Or Gerlitz wrote:
>> This series is a refactored form of the one posted by Jiri Kosina
>> to LKML and netdev according to the discussion that followed
>> and the guidelines you provided here https://lkml.org/lkml/2014/3/5/
Linus,
please pull the latest irq-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
irq-urgent-for-linus
Two small updates from the irq departement:
* Provide missing inline stub for a SMP only function
* Add sub-maintainer for the drivers/irqchip/
On Sat, May 17, 2014 at 05:04:55PM +0900, Cho KyongHo wrote:
> On Fri, 16 May 2014 14:23:18 +0200, Thierry Reding wrote:
[...]
> > +Examples:
> > +=
> > +
> > +Single-master IOMMU:
> > +
> > +
> > + iommu {
> > + #iommu-cells = <0>;
> > + };
> > +
> > + m
On Saturday 17 May 2014 22:30:54 Dmitry Torokhov wrote:
> Hi Pali,
>
> On Sat, May 17, 2014 at 04:43:36PM +0200, Pali Rohár wrote:
> > There are already defined some Fn key combinations, but not
> > all. This patch adds missing combinations for support in
> > dell-wmi driver.
> >
> > Signed-off-b
Add a blank line after declarations to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/unisys/visorutil/charqueue.c |2 ++
drivers/staging/unisys/visorutil/easyproc.c |6 ++
drivers/staging/unisys/visorutil/periodic_work.c |1 +
drivers/stag
Hi Pali,
On Sat, May 17, 2014 at 04:43:36PM +0200, Pali Rohár wrote:
> There are already defined some Fn key combinations, but not all.
> This patch adds missing combinations for support in dell-wmi driver.
>
> Signed-off-by: Pali Rohár
> ---
> include/uapi/linux/input.h |6 ++
> 1 file
On Sat, May 17, 2014 at 08:23:00PM +0200, Peter Senna Tschudin wrote:
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c |6 +++---
> drivers/infiniband/ulp/srpt/ib_srpt.c|8
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma
On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote:
> diff --git a/tools/power/cpupower/utils/cpufreq-set.c
> b/tools/power/cpupower/utils/cpufreq-set.c
> index a416de8..4e2f35a 100644
> --- a/tools/power/cpupower/utils/cpufreq-set.c
> +++ b/tools/power/cpupower/utils/cpufreq-set
Hi,
I've upgraded kernel on my PC to 3.15-rc5 and I got today freeze
(recovery possibly only by power off/on) when waking from suspend.
There is only warning in log but system was completely dead (no keys
reaction ).
May 14 15:53:15 nb kernel: [30404.485085] PM: Syncing filesystems ... done.
On Sat, May 17, 2014 at 8:36 AM, David Miller wrote:
>
> From: Chen Gang
> Date: Sat, 17 May 2014 13:26:16 +0800
>
> > 'struct irq_affinity_notify' and the related functions are only defined
> > when SMP enabled, so at present, mlx4 has to only run under SMP.
> >
> > The related error (allmodconf
I like this. There is way too much code where it sets a variable and
then checks it again a couple lines down instead of just handling it
immediately so that every line is clear without having to keep track
so many variables.
But the automated patch doesn't really go far enough in cleaning up thi
I see a continuous flood of below messages on plugging in/using my USB
token. (The comp code wasn't in the original message - I added it.) From
what I can tell the device continues to work as expected.
Should the warning be disabled for COMP_SHORT_TX like it is for COMP_STOP
and COMP_STOP_INVAL
On Sat, May 17, 2014 at 05:30:53PM +0100, Masaru Nomura wrote:
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 8988346..c211f9f 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -838,9 +838,11 @@ static void neo_para
There's been a check for CONFIG_MEMHOLE in m32r's code ever since it was
added in v2.6.9. But there has never been a Kconfig symbol MEMHOLE.
(Neither have there been Kconfig symbols MEMHOLE_START and
MEMHOLE_SIZE, by the way.) Remove this check.
Signed-off-by: Paul Bolle
---
Untested.
arch/m32r
On Sat, May 17, 2014 at 08:56:35PM +0200, Christian Engelmayer wrote:
> On Sat, 17 May 2014 17:44:23 +0300, Dan Carpenter
> wrote:
> > On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote:
> > > Function rtw_drv_init() is written in a way that assumes 'status' !=
> > > _SUCCESS
>
This commit fixes the following sparse warning:
drivers/staging/rtl8821ae/rtl8821ae/sw.c:
- 449:14: warning: duplicate const
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8821ae/rtl8821ae/sw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8
On Sat, May 17, 2014 at 08:21:03PM +0300, Antti Palosaari wrote:
> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
> >don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
> >use the common kernel coding style.
> >
> >Signed-off-by: Martin Kepplinger
>
> Reviewed-by: Antti Palosaari
>
> >
This patch set fixes sparse warnings in sw.c file of rtl8821ae driver.
In particular it deals with:
1) double const definition
2) missing 'static' for a few local symbols
Konrad Zapalowicz (2):
staging: rtl8821ae: fix double const in sw.c
staging: rtl8821ae: fix not declared symbols sh
This commit fixes the following sparse warnings:
drivers/staging/rtl8821ae/rtl8821ae/sw.c:
- 48:6: warning: symbol 'rtl8821ae_init_aspm_vars' was not declared.
Should it be static?
- 228:5: warning: symbol 'rtl8812ae_rx_command_packet_handler' was
not declared. Should it be sta
Hello Emil,
On Sat, May 17, 2014 at 08:40:33PM +0200, Emil Goode wrote:
> If we fail to allocate struct platform_device pdev we
> dereference it after the goto label err.
>
> I have rearranged the error handling a bit to fix the issue
> and also make it more clear.
>
> Signed-off-by: Emil Goode
Hello Emil,
On Sat, May 17, 2014 at 05:35:40PM +0200, Emil Goode wrote:
> On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
> > On Fri, May 16, 2014 at 01:49:10PM +0200, walter harms wrote:
> > > Am 16.05.2014 13:16, schrieb Emil Goode:
> > > > Hello Walter,
> > > >
> > > > On Fri
I have this old dell inspiron 2600 laptop with dual boot XP and Fedora
12 running some version of the 2.6 kernel and the keyboard and the
mousepad are dead in linux. When I boot linux I get this error message:
Can't read CTR while initializing i8042
which is in i8042.c. Past that point, I can't i
tmp is no longer used in perf_event_exit_task_context since
3a497f48637e2a
"perf: Simplify perf_event_exit_task_context()"
Cc: Peter Zijlstra
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/e
On Sat, 17 May 2014 17:44:23 +0300, Dan Carpenter
wrote:
> On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote:
> > Function rtw_drv_init() is written in a way that assumes 'status' !=
> > _SUCCESS
> > as long as not explicitly set. Thus initialize 'status' to FAIL, in order to
On Sat, May 17, 2014 at 03:21:56PM +0200, Rickard Strandqvist wrote:
> Okay, everyone agrees with Dan..?
>
You can audit it yourself, there are only 4 callers. The
node_allocate() is total garbage so the second delete_node() is a bit
complicated to read but it's not that hard.
> I have made a n
On Thu, May 15, 2014 at 12:41:46PM -0600, Bjorn Helgaas wrote:
> On Thu, May 01, 2014 at 05:35:48PM +0300, Marcel Apfelbaum wrote:
> > When a board is added, the shpchp driver checks if there
> > is a mismatch between the bridge's adapter and the bus speed.
> > If there is, it sets the subordinate
Il 17/05/2014 19:52, Martin Kepplinger ha scritto:
> Am 2014-05-17 19:21, schrieb Antti Palosaari:
>> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
>>> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
>>> use the common kernel coding style.
>>>
>>> Signed-off-by: Martin Kepplinger
>>
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode
---
v3: Made subject line more specific.
v2: Changed to return -ENOMEM instead of ret
On Sat, May 17, 2014 at 2:13 PM, Damien Wyart wrote:
> Hi;
>
> After further tests, I can reproduce the problem on 3.14.4 also,
> mainly by visiting the following URL with Firefox (29.0.1) :
> http://lavieestmaloptimisee.blogspot.fr/
Amazing. I get the same thing in chrome on my setup (G96).
[23
Remove double checks, and move the call to printk to the
first check. Also adds KERN_WARNING to printk. The simplified version
of the coccinelle semantic patch that fixes this issue is as follows:
//
@@
expression E; identifier pr; expression list es;
@@
while(...){
...
- if (E) break;
+
Remove double checks, and move the call to pr_devel to the
first check. The simplified version of the coccinelle semantic
patch that fixes this issue is as follows:
//
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+
Remove double checks, and move the call to print_error to the
first check. The simplified version of the coccinelle semantic
patch that fixes this issue is as follows:
//
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+
Remove double checks, and move calls to pr_err and printk to the
first check. The simplified version of the coccinelle semantic
patch that fixes this issue is as follows:
//
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+
Hi;
After further tests, I can reproduce the problem on 3.14.4 also,
mainly by visiting the following URL with Firefox (29.0.1) :
http://lavieestmaloptimisee.blogspot.fr/
Firefox becomes unresponsive and I get some messages in the kernel log :
May 17 20:01:36 brouette kernel: BUG: unable to hand
On 05/13/2014 10:27 PM, Davidlohr Bueso wrote:
Nothing big and no logical changes, just get rid of some
redundant function declarations. Move msg_[init/exit]_ns
down the end of the file.
Signed-off-by: Davidlohr Bueso
Signed-off-by: Manfred Spraul
---
ipc/msg.c | 132 +
On Sat, May 17, 2014 at 06:21:09PM +0100, Al Viro wrote:
> On Sat, May 17, 2014 at 05:44:28PM +0200, Mateusz Guzik wrote:
> > This particular function would be better of with removing this variable
> > and replacing all pairs like:
> > sprintf(dp, ...);
> > dp += strlen(...)
> >
> > with:
> > dp +
On 05/13/2014 10:27 PM, Davidlohr Bueso wrote:
Call __set_current_state() instead of assigning
the new state directly.
Signed-off-by: Davidlohr Bueso
Signed-off-by: Manfred Spraul
---
ipc/msg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ipc/msg.c b/ipc/msg.c
This patch adds support for the Level-2 interrupt controller hardware
found in Broadcom Set Top Box System-on-a-Chip devices. This interrupt
controller is implemented using the generic IRQ chip driver with
separate enable and disable registers.
Signed-off-by: Brian Norris
Signed-off-by: Florian F
This patch adds the Device Tree binding document for the Broadcom
Set-top-box Level 2 interrupt controller hardware.
Signed-off-by: Brian Norris
Signed-off-by: Florian Fainelli
---
.../bindings/interrupt-controller/brcm,l2-intc.txt | 29 ++
1 file changed, 29 insertions(+)
Hi Thomas,
This patch set adds an irqchip driver for the Broadcom Set Top Box Level-2
interrupt controller hardware, as well as a corresponding Device Tree binding
document.
Thanks!
Florian Fainelli (2):
irqchip: add Broadcom Set Top Box Level-2 interrupt controller
Documentation: add Broadc
Am 2014-05-17 19:21, schrieb Antti Palosaari:
> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
>> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
>> use the common kernel coding style.
>>
>> Signed-off-by: Martin Kepplinger
>
> Reviewed-by: Antti Palosaari
>
>> ---
>> this applies
On Tue, Apr 29, 2014 at 11:16:09AM +0300, Mika Westerberg wrote:
> On Mon, Apr 28, 2014 at 10:27:48PM +0800, Lan Tianyu wrote:
> > This patch is to add CONFIG_I2C_ACPI. Current there is a race between
> > removing I2C ACPI operation region and ACPI AML code accessing.
> > So make i2c core built-in
This commit fixes the following checkpatch warning:
rtl8712/rtl871x_security.c
- 1178: WARNING: Avoid unnecessary line continuations
Signed-off-by: Marcus Farkas
---
drivers/staging/rtl8712/rtl871x_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagin
This commit fixes the following checkpatch warnings:
rtl8712/rtl871x_security.c
- 1167: WARNING: Unnecessary parentheses - maybe == should be = ?
- 1374: WARNING: Unnecessary parentheses - maybe == should be = ?
Signed-off-by: Marcus Farkas
---
drivers/staging/rtl8712/rtl871x_security.c
This commit fixes the following checkpatch warnings:
rtl8712/rtl871x_security.c
- 275: WARNING: Missing a blank line after declarations
- 768: WARNING: Missing a blank line after declarations
- 801: WARNING: Missing a blank line after declarations
Signed-off-by: Marcus Farkas
---
dr
3.15-rc2 seems to be good, 3.15-rc5 seems to be bad. Bisecting this the next
days.
Am 12.05.2014 18:54 schrieb Daniel Vetter :
>
> On Mon, May 12, 2014 at 10:09:54AM +0300, Jani Nikula wrote:
> > On Sun, 11 May 2014, Daniel Vetter wrote:
> > > On Sun, May 11, 2014 at 11:02 AM, Dave Airlie wro
Hi!
> And both these doesn't happen in this case. OPP tables can be used
> by any other framework and is more or less a core thing..
>
> Now, with this discussion I have another idea here..
>
> Why don't we build these tables automatically on boot from some core
> code, rather than asking driver
1 - 100 of 204 matches
Mail list logo
