Re: Dealing with the NMI mess

2015-07-23 Thread Willy Tarreau
On Thu, Jul 23, 2015 at 05:31:05PM -0400, Steven Rostedt wrote: > On Thu, 23 Jul 2015 14:08:59 -0700 > Linus Torvalds wrote: > > > On Thu, Jul 23, 2015 at 1:49 PM, Andy Lutomirski > > wrote: > > > > > > Issue A: to return with RF clear, we need to disarm the breakpoint. > > > If it's limited

Re: Dealing with the NMI mess

2015-07-23 Thread Andy Lutomirski
On Thu, Jul 23, 2015 at 2:46 PM, Willy Tarreau wrote: > On Thu, Jul 23, 2015 at 05:31:05PM -0400, Steven Rostedt wrote: >> On Thu, 23 Jul 2015 14:08:59 -0700 >> Linus Torvalds wrote: >> >> > On Thu, Jul 23, 2015 at 1:49 PM, Andy Lutomirski >> > wrote: >> > > >> > > Issue A: to return with RF

Re: Dealing with the NMI mess

2015-07-23 Thread Andy Lutomirski
On Thu, Jul 23, 2015 at 2:35 PM, Linus Torvalds wrote: > On Thu, Jul 23, 2015 at 2:20 PM, Peter Zijlstra wrote: >> >> So the NMI could trigger userspace debug register faults, and simply >> disabling them would make the whole debug register thing entirely >> unreliable. > > We could easily set

Re: [Xen-devel] [Patch V4 1/3] usb: Add Xen pvUSB protocol description

2015-07-23 Thread Pasi Kärkkäinen
On Thu, Jul 23, 2015 at 12:08:01PM -0700, Greg KH wrote: > > Somewhere that people can refer to that describes this public-facing API > that "must not ever be broken or changed". If you want to put it in a > documentation file, or a .h file, I don't care. > > > >>It is used e.g. in SUSE's xen

mmotm 2015-07-23-14-37 uploaded

2015-07-23 Thread akpm
The mm-of-the-moment snapshot 2015-07-23-14-37 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

Re: [PATCH] Input: LEDs - skip unnamed LEDs

2015-07-23 Thread Dmitry Torokhov
On Thu, Jul 23, 2015 at 11:22:54PM +0200, Pavel Machek wrote: > On Thu 2015-07-23 13:57:13, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 08:19:13AM +0200, Pavel Machek wrote: > > > On Wed 2015-07-22 15:02:02, Dmitry Torokhov wrote: > > > > Devices may declare more LEDs than what is known to

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Belisko Marek
On Thu, Jul 23, 2015 at 11:15 PM, Pali Rohár wrote: > On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: >> Hi Pali, >> >> On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár >> wrote: >> > On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: >> >> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C >> >> >>

Re: Dealing with the NMI mess

2015-07-23 Thread Linus Torvalds
On Thu, Jul 23, 2015 at 2:20 PM, Peter Zijlstra wrote: > > So the NMI could trigger userspace debug register faults, and simply > disabling them would make the whole debug register thing entirely > unreliable. We could easily set something to re-enable them for when we actually return to user

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 18:25:36 -0300 Arnaldo Carvalho de Melo wrote: > Like this? Yep, but some comments. > diff --git a/tools/lib/traceevent/event-parse.c > b/tools/lib/traceevent/event-parse.c > index cc25f059ab3d..7f9266225f11 100644 > --- a/tools/lib/traceevent/event-parse.c > +++

Re: Dealing with the NMI mess

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 14:08:59 -0700 Linus Torvalds wrote: > On Thu, Jul 23, 2015 at 1:49 PM, Andy Lutomirski wrote: > > > > Issue A: to return with RF clear, we need to disarm the breakpoint. > > If it's limited to the duration of the NMI, that's easy. If not, when > > do we re-arm? New

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 02:11:33PM -0400, Steven Rostedt escreveu: > On Thu, 23 Jul 2015 14:10:39 -0400 > Steven Rostedt wrote: > > > On Thu, 23 Jul 2015 14:25:54 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > diff --git a/tools/lib/traceevent/event-parse.c > > >

Re: [PATCH 4/5] ARM: dts: qcom: Add ks8851 node for wired ethernet

2015-07-23 Thread Andy Gross
On Tue, Jun 16, 2015 at 01:31:15PM -0700, Stephen Boyd wrote: > The micrel ks8851 device is present on MSM8960 CDP boards. It is > connected to two regulators, one controlled via a gpio and > another controlled via the RPM. Add the gsbi, spi, gpio > regulator, and micrel ks8851 nodes so that

Re: [PATCH 2/5] ARM: dts: qcom: Add MSM8960 RPM and RPM regulator nodes

2015-07-23 Thread Andy Gross
On Tue, Jun 16, 2015 at 01:31:13PM -0700, Stephen Boyd wrote: > Add the basic RPM and RPM regulator nodes that boards can fill in > with their board specific details. > > Signed-off-by: Stephen Boyd > --- Applied, thanks -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc.

Re: [PATCH] Input: LEDs - skip unnamed LEDs

2015-07-23 Thread Pavel Machek
On Thu 2015-07-23 13:57:13, Dmitry Torokhov wrote: > On Thu, Jul 23, 2015 at 08:19:13AM +0200, Pavel Machek wrote: > > On Wed 2015-07-22 15:02:02, Dmitry Torokhov wrote: > > > Devices may declare more LEDs than what is known to input-leds > > > (HID does this for some devices). Instead of showing

Re: Dealing with the NMI mess

2015-07-23 Thread Peter Zijlstra
On Thu, Jul 23, 2015 at 01:38:33PM -0700, Linus Torvalds wrote: > And the "take them and disable them" is really simple. No "am I in an > NMI contect" thing (because that leads to the whole question about > "what is NMI context"). That's not the real rule anyway. > > No, make it very simple and

[PATCH] noop-iosched: do not attempt to sort requests

2015-07-23 Thread Tahsin Erdogan
Noop scheduler currently dispatches a request by calling elv_dispatch_sort(). In practice, sorting does not occur because __elv_next_request() asks the io scheduler to dispatch a request only when elevator queue is empty. Also, not reordering requests seems more appropriate for noop. This change

Re: [RFC 1/4] mm, compaction: introduce kcompactd

2015-07-23 Thread David Rientjes
On Thu, 23 Jul 2015, Vlastimil Babka wrote: > > When a khugepaged allocation fails for a node, it could easily kick off > > background compaction on that node and revisit the range later, very > > similar to how we can kick off background compaction in the page allocator > > when async or

Re: Dealing with the NMI mess

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 13:21:16 -0700 Andy Lutomirski wrote: > 3. Forbid faults (other than MCE) inside NMI. > > Option 3 is almost easy. There are really only two kinds of faults > that can legitimately nest inside NMI: #PF and #DB. #DB is easy to > fix (e.g. with my patches or Peter's

Re: Dealing with the NMI mess

2015-07-23 Thread Willy Tarreau
On Thu, Jul 23, 2015 at 02:13:16PM -0700, Linus Torvalds wrote: > On Thu, Jul 23, 2015 at 1:52 PM, Willy Tarreau wrote: > > > > What's the worst case that can happen with RF cleared when returing > > to user space ? > > Not a good idea. We are fine breaking breakpoints on the kernel ("use > the

Re: Dealing with the NMI mess

2015-07-23 Thread Peter Zijlstra
On Thu, Jul 23, 2015 at 01:21:16PM -0700, Andy Lutomirski wrote: > 3. Forbid faults (other than MCE) inside NMI. > > Option 3 is almost easy. There are really only two kinds of faults > that can legitimately nest inside NMI: #PF and #DB. #DB is easy to > fix (e.g. with my patches or Peter's

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: > Hi Pali, > > On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár > wrote: > > On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: > >> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C > >> >> -MODULE_ALIAS("i2c:bq27000-battery"); > >> >> +#ifdef

Re: Dealing with the NMI mess

2015-07-23 Thread Linus Torvalds
On Thu, Jul 23, 2015 at 1:52 PM, Willy Tarreau wrote: > > What's the worst case that can happen with RF cleared when returing > to user space ? Not a good idea. We are fine breaking breakpoints on the kernel ("use the tracing infrastructure instead"). Breaking it in user space is not really an

Re: [PATCHv2 2/6] x86, mpx: do not set ->vm_ops on mpx VMAs

2015-07-23 Thread Kirill A. Shutemov
On Thu, Jul 23, 2015 at 01:59:11PM -0700, Andrew Morton wrote: > On Fri, 17 Jul 2015 14:53:09 +0300 "Kirill A. Shutemov" > wrote: > > > MPX setups private anonymous mapping, but uses vma->vm_ops too. > > This can confuse core VM, as it relies on vm->vm_ops to distinguish > > file VMAs from

Re: Dealing with the NMI mess

2015-07-23 Thread Linus Torvalds
On Thu, Jul 23, 2015 at 1:49 PM, Andy Lutomirski wrote: > > Issue A: to return with RF clear, we need to disarm the breakpoint. > If it's limited to the duration of the NMI, that's easy. If not, when > do we re-arm? New prepare_exit_to_usermode hook? Hmm, setting ti > flags during context

Re: Dealing with the NMI mess

2015-07-23 Thread Willy Tarreau
On Thu, Jul 23, 2015 at 01:53:34PM -0700, Andy Lutomirski wrote: > On Thu, Jul 23, 2015 at 1:52 PM, Willy Tarreau wrote: > > On Thu, Jul 23, 2015 at 01:38:33PM -0700, Linus Torvalds wrote: > >> On Thu, Jul 23, 2015 at 1:21 PM, Andy Lutomirski > >> wrote: > >> > > >> > 2. Forbid IRET inside

Re: [PATCH 3/5] ARM: dts: qcom: Add MSM8960 CDP RPM regulators

2015-07-23 Thread Andy Gross
On Tue, Jun 16, 2015 at 01:31:14PM -0700, Stephen Boyd wrote: > Add RPM regulators and configure their constraints on the MSM8960 > CDP so that we can control these supplies. > > Signed-off-by: Stephen Boyd > --- Applied, thanks -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation

Re: [PATCH 5/5] ARM: qcom_defconfig: Enable options for KS8851 ethernet

2015-07-23 Thread Andy Gross
On Tue, Jun 16, 2015 at 01:31:16PM -0700, Stephen Boyd wrote: > Enable the RPM and RPM regulator drivers as well as the KS8851 > ethernet driver so that ethernet works on MSM8960 CDP. > > Signed-off-by: Stephen Boyd > --- Applied, thanks! -- Qualcomm Innovation Center, Inc. The Qualcomm

Re: [PATCH 1/5] ARM: dts: qcom: Replace gpio node with pinctrl node

2015-07-23 Thread Andy Gross
On Tue, Jun 16, 2015 at 01:31:12PM -0700, Stephen Boyd wrote: > Now that we have a proper pinctrl driver for the gpio block we > can change the compatible field here and configure the pinmux on > msm8960 devices. > > Signed-off-by: Stephen Boyd > --- Applied, thanks -- Qualcomm Innovation

Re: [PATCHv2 2/6] x86, mpx: do not set ->vm_ops on mpx VMAs

2015-07-23 Thread Andrew Morton
On Fri, 17 Jul 2015 14:53:09 +0300 "Kirill A. Shutemov" wrote: > MPX setups private anonymous mapping, but uses vma->vm_ops too. > This can confuse core VM, as it relies on vm->vm_ops to distinguish > file VMAs from anonymous. > > As result we will get SIGBUS, because handle_pte_fault() thinks

Re: [RFC 1/4] mm, compaction: introduce kcompactd

2015-07-23 Thread David Rientjes
On Thu, 23 Jul 2015, Joonsoo Kim wrote: > > The slub allocator does try to allocate its high-order memory with > > __GFP_WAIT before falling back to lower orders if possible. I would think > > that this would be the greatest sign of on-demand memory compaction being > > a problem, especially

Re: [PATCH 3/3] ARM: dts: qcom: Replace gpio node with pinctrl node

2015-07-23 Thread Andy Gross
On Fri, Jun 05, 2015 at 03:52:25PM -0700, Bjorn Andersson wrote: > Replace the standalone gpio driver with pinctrl-msm as we now have > msm8660 support there. > > Signed-off-by: Bjorn Andersson > --- Applied, thanks! -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is

Re: [PATCH] Input: LEDs - skip unnamed LEDs

2015-07-23 Thread Dmitry Torokhov
On Thu, Jul 23, 2015 at 08:19:13AM +0200, Pavel Machek wrote: > On Wed 2015-07-22 15:02:02, Dmitry Torokhov wrote: > > Devices may declare more LEDs than what is known to input-leds > > (HID does this for some devices). Instead of showing ugly warnings > > on connect and, even worse, oopsing on

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Belisko Marek
Hi Pali, On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár wrote: > On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: >> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C >> >> -MODULE_ALIAS("i2c:bq27000-battery"); >> >> +#ifdef CONFIG_BATTERY_BQ27XXX_I2C >> >> +MODULE_ALIAS("i2c:bq27xxx-battery"); >> >>

Re: Dealing with the NMI mess

2015-07-23 Thread Andy Lutomirski
On Thu, Jul 23, 2015 at 1:52 PM, Willy Tarreau wrote: > On Thu, Jul 23, 2015 at 01:38:33PM -0700, Linus Torvalds wrote: >> On Thu, Jul 23, 2015 at 1:21 PM, Andy Lutomirski wrote: >> > >> > 2. Forbid IRET inside NMIs. Doable but maybe not that pretty. >> > >> > We haven't considered: >> > >> >

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-23 Thread Dmitry Torokhov
On Thu, Jul 23, 2015 at 10:38:34PM +0200, Marek Belisko wrote: > Fix following: > [8.862274] ERROR: Bad of_node_put() on /ocp/i2c@4807/twl@48/audio > [8.869293] CPU: 0 PID: 1003 Comm: modprobe Not tainted 4.2.0-rc2-letux+ > #1175 > [8.876922] Hardware name: Generic OMAP36xx

Re: [patch] mmap.2: document the munmap exception for underlying page size

2015-07-23 Thread David Rientjes
On Thu, 23 Jul 2015, Michael Kerrisk (man-pages) wrote: > >> Should we also add a similar comment for the mmap offset? Currently > >> the man page says: > >> > >> "offset must be a multiple of the page size as returned by > >> sysconf(_SC_PAGE_SIZE)." > >> > >> For hugetlbfs, I beieve the

Re: Dealing with the NMI mess

2015-07-23 Thread Willy Tarreau
On Thu, Jul 23, 2015 at 01:38:33PM -0700, Linus Torvalds wrote: > On Thu, Jul 23, 2015 at 1:21 PM, Andy Lutomirski wrote: > > > > 2. Forbid IRET inside NMIs. Doable but maybe not that pretty. > > > > We haven't considered: > > > > 3. Forbid faults (other than MCE) inside NMI. > > I'd really

Re: [PATCH v2 09/11] ARM: dts: msm8974: Add smem reservation and node

2015-07-23 Thread Andy Gross
On Fri, Jun 26, 2015 at 02:50:17PM -0700, bj...@kryo.se wrote: > From: Bjorn Andersson > > Signed-off-by: Bjorn Andersson > --- Applied, thanks. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative

[PATCH] merge_config.sh: Add the ability to perform make with an ARCH

2015-07-23 Thread Dan Murphy
The script does not allow building for different architectures. It may assume that the developer has set the ARCH as a global variable. Add a switch argument to pass in the desired architecture. Then verify that that architecture is supported in the arch directory. If not exit if it is supported

llvm bpf debug info. Re: [RFC PATCH v4 3/3] bpf: Introduce function for outputing data to perf event

2015-07-23 Thread Alexei Starovoitov
On 7/23/15 4:54 AM, He Kuang wrote: trimmed cc-list, since it's not related to kernel. Thank you for your guidence, and by referencing your last mail and other llvm backends, I found setting BPFMCAsmInfo::SupportsDebugInformation = true in BPFMCAsmInfo.h thanks! yes. it was missing. and

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Andy Shevchenko
On Thu, 2015-07-23 at 13:36 -0700, Kees Cook wrote: > On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko > wrote: > > On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: > > > Hi, > > > > > > I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? > > > > Space is a printable character. > >

Re: Dealing with the NMI mess

2015-07-23 Thread Andy Lutomirski
On Thu, Jul 23, 2015 at 1:38 PM, Linus Torvalds wrote: > On Thu, Jul 23, 2015 at 1:21 PM, Andy Lutomirski wrote: >> >> 2. Forbid IRET inside NMIs. Doable but maybe not that pretty. >> >> We haven't considered: >> >> 3. Forbid faults (other than MCE) inside NMI. > > I'd really prefer #2. #3

Re: [PATCH v2 01/11] soc: qcom: Add device tree binding for SMEM

2015-07-23 Thread Andy Gross
On Fri, Jun 26, 2015 at 02:50:09PM -0700, bj...@kryo.se wrote: > From: Bjorn Andersson > > Add device tree binding documentation for the Qualcom Shared Memory > Manager. > > Signed-off-by: Bjorn Andersson > + smem@fa0 { > + compatible = "qcom,smem"; > + > +

Re: [PATCH v2 02/11] soc: qcom: Add Shared Memory Manager driver

2015-07-23 Thread Andy Gross
On Fri, Jun 26, 2015 at 02:50:10PM -0700, bj...@kryo.se wrote: > From: Bjorn Andersson > > The Shared Memory Manager driver implements an interface for allocating > and accessing items in the memory area shared among all of the > processors in a Qualcomm platform. > > Signed-off-by: Bjorn

[PATCH] cpufreq: Avoid attempts to create duplicate symbolic links

2015-07-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki After commit 87549141d516 (cpufreq: Stop migrating sysfs files on hotplug) there is a problem with CPUs that share cpufreq policy objects with other CPUs and are initially offline. Say CPU1 shares a policy with CPU0 which is online and is registered first. As part of

Re: [PATCH] usb: ulpi: call put_device if device_register fails

2015-07-23 Thread Greg Kroah-Hartman
On Thu, Jul 23, 2015 at 03:08:08PM -0500, Felipe Balbi wrote: > > I don't like fixes like this because no one now has any pressure to fix > > it "properly". Are you doing that work? If not, who is? > > Heikki is author, I'd expect him to fix it up. We can also revert the > fix if you prefer,

Re: [PATCH v2 08/11] ARM: dts: msm8974: Add tcsr mutex node

2015-07-23 Thread Andy Gross
On Fri, Jun 26, 2015 at 02:50:16PM -0700, bj...@kryo.se wrote: > From: Bjorn Andersson > > Signed-off-by: Bjorn Andersson > --- > arch/arm/boot/dts/qcom-msm8974.dtsi | 12 > 1 file changed, 12 insertions(+) > Applied, thanks! -- Qualcomm Innovation Center, Inc. The Qualcomm

Re: [PATCH v1 4/4] mm/memory-failure: check __PG_HWPOISON separately from PAGE_FLAGS_CHECK_AT_*

2015-07-23 Thread Andrew Morton
On Thu, 16 Jul 2015 01:41:56 + Naoya Horiguchi wrote: > The race condition addressed in commit add05cecef80 ("mm: soft-offline: don't > free target page in successful page migration") was not closed completely, > because that can happen not only for soft-offline, but also for hard-offline.

Re: [PATCH] cpufreq: ia64: remove redundant freq_table of acpi_cpufreq_data

2015-07-23 Thread Rafael J. Wysocki
On Monday, July 20, 2015 03:22:45 PM Viresh Kumar wrote: > On 20-07-15, 14:22, Pan Xinhui wrote: > > From: Pan Xinhui > > > > freq_table is now stored as policy->freq_table, so drop the redundant > > freq_table from struct cpufreq_acpi_io. > > > > Signed-off-by: Pan Xinhui > > --- > >

[PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-23 Thread Marek Belisko
Fix following: [8.862274] ERROR: Bad of_node_put() on /ocp/i2c@4807/twl@48/audio [8.869293] CPU: 0 PID: 1003 Comm: modprobe Not tainted 4.2.0-rc2-letux+ #1175 [8.876922] Hardware name: Generic OMAP36xx (Flattened Device Tree) [8.883514] [] (unwind_backtrace) from []

Re: Dealing with the NMI mess

2015-07-23 Thread Linus Torvalds
On Thu, Jul 23, 2015 at 1:21 PM, Andy Lutomirski wrote: > > 2. Forbid IRET inside NMIs. Doable but maybe not that pretty. > > We haven't considered: > > 3. Forbid faults (other than MCE) inside NMI. I'd really prefer #2. #3 depends on us getting many things right, and never introducing new

Re: [PATCH] cpufreq: ia64: Fix a memory leak in acpi_cpufreq_cpu_exit

2015-07-23 Thread Rafael J. Wysocki
On Monday, July 20, 2015 02:24:36 PM Pan Xinhui wrote: > From: Pan Xinhui > > freq_table should be alloced in ->init and freed in ->exit. However it > does not be freed. Fix this memory leak in acpi_cpufreq_cpu_exit. > > Signed-off-by: Pan Xinhui Queued up for 4.3, thanks! -- I speak only

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko wrote: > On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: >> Hi, >> >> I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? > > Space is a printable character. > You perhaps wants something like ESCAPE_SPACE | ESCAPE_HEX. Yeah, I can get

Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing

2015-07-23 Thread Rafael J. Wysocki
On Tuesday, July 21, 2015 10:41:13 AM Lukasz Anaczkowski wrote: > Scaling for Knights Landing is same as the default scaling (10). > When Knigts Landing support was added to the pstate driver, this > parameter was omitted resulting in a kernel panic during boot. > > Reported-by: Yasuaki

Re: [PATCH v2] cpufreq: Remove cpufreq_rwsem

2015-07-23 Thread Rafael J. Wysocki
On Wednesday, July 22, 2015 05:59:11 PM Sebastian Andrzej Siewior wrote: > cpufreq_rwsem was introduced in commit 6eed9404ab3c4 ("cpufreq: Use > rwsem for protecting critical sections) in order to replace > try_module_get() on the cpu-freq driver. That try_module_get() worked > well until the

Re: [RESEND PATCH] cpupower: Do not change the frequency of offline cpu

2015-07-23 Thread Rafael J. Wysocki
On Thursday, July 23, 2015 12:20:27 PM Shilpasri G Bhat wrote: > Check if the cpu is online before changing the frequency/governor of > the cpu. > > Reported-by: Pavaman Subramaniyam > Signed-off-by: Shilpasri G Bhat > Reviewed-by: Gautham R. Shenoy > Acked-by: Thomas Renninger Queued up for

Re: [PATCH 2/2] cpufreq: Separate CPU device removal from CPU online

2015-07-23 Thread Rafael J. Wysocki
On Thursday, July 23, 2015 12:09:42 PM Viresh Kumar wrote: > On 23-07-15, 02:04, Rafael J. Wysocki wrote: > > +static int cpufreq_add_dev(struct device *dev, struct subsys_interface > > *sif) > > +{ > > + unsigned int cpu = dev->id; > > + struct cpufreq_policy *policy =

Re: [PATCH 0/4] Add support for Hyperlinks and Markup on kernel-doc

2015-07-23 Thread Jonathan Corbet
On Thu, 23 Jul 2015 15:16:23 -0300 Danilo Cesar Lemes de Paula wrote: > This series add supports for hyperlink cross-references on Docbooks and > an optional markup syntax for in-source Documentation. I like the idea; just be warned that it's likely to be a week or two and one more ocean

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Andy Shevchenko
On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: > Hi, > > I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? Space is a printable character. You perhaps wants something like ESCAPE_SPACE | ESCAPE_HEX. > That is > surprising to me, especially since things like isspace() include >

Re: [PATCH] mm: rename and document alloc_pages_exact_node

2015-07-23 Thread David Rientjes
On Thu, 23 Jul 2015, Christoph Lameter wrote: > > The only possible downside would be existing users of > > alloc_pages_node() that are calling it with an offline node. Since it's a > > VM_BUG_ON() that would catch that, I think it should be changed to a > > VM_WARN_ON() and eventually fixed up

Re: [PATCH 0/4] ACPI: Update method tracing facility.

2015-07-23 Thread Rafael J. Wysocki
On Thursday, July 23, 2015 01:06:37 PM Lv Zheng wrote: > This patch updates method tracing facility according to ACPICA 20150717 > release changes. Can you please explain this in a few more words. Why do we need to update the interface? Rafael -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] locktorture: Support rtmutex torturing

2015-07-23 Thread Davidlohr Bueso
On Wed, 2015-07-22 at 17:17 -0700, Paul E. McKenney wrote: > On Wed, Jul 22, 2015 at 02:07:27PM -0700, Davidlohr Bueso wrote: > > Real time mutexes is one of the few general primitives > > that we do not have in locktorture. Address this -- a few > > considerations: > > > > o To spice things up,

Dealing with the NMI mess

2015-07-23 Thread Andy Lutomirski
[moved to a new thread, cc list trimmed] Hi all- We've considered two approaches to dealing with NMIs: 1. Allow nesting. We know quite well how messy that is. 2. Forbid IRET inside NMIs. Doable but maybe not that pretty. We haven't considered: 3. Forbid faults (other than MCE) inside NMI.

Re: [PATCH] mm, page_isolation: make set/unset_migratetype_isolate() file-local

2015-07-23 Thread David Rientjes
On Thu, 23 Jul 2015, Naoya Horiguchi wrote: > Nowaday, set/unset_migratetype_isolate() is defined and used only in > mm/page_isolation, so let's limit the scope within the file. > > Signed-off-by: Naoya Horiguchi Acked-by: David Rientjes -- To unsubscribe from this list: send the line

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: > >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C > >> -MODULE_ALIAS("i2c:bq27000-battery"); > >> +#ifdef CONFIG_BATTERY_BQ27XXX_I2C > >> +MODULE_ALIAS("i2c:bq27xxx-battery"); > >> > >> #endif > > > > Why is this MODULE_ALIAS needed? Some lines

Re: [PATCH] usb: ulpi: call put_device if device_register fails

2015-07-23 Thread Felipe Balbi
Hi, On Thu, Jul 23, 2015 at 11:00:29AM -0700, Greg Kroah-Hartman wrote: > On Thu, Jul 23, 2015 at 12:02:40AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Wed, Jul 22, 2015 at 08:14:46PM -0700, Greg Kroah-Hartman wrote: > > > On Wed, Jul 22, 2015 at 09:04:40PM -0500, Felipe Balbi wrote: > > > >

Re: [PATCH] drivers: qcom: Select QCOM_SCM unconditionally for QCOM_PM

2015-07-23 Thread Andy Gross
On Tue, Jul 14, 2015 at 04:54:12PM -0500, Andy Gross wrote: > On Fri, Jul 10, 2015 at 02:18:00PM -0600, Lina Iyer wrote: > > Enable QCOM_SCM for QCOM power management driver > > > > Signed-off-by: Lina Iyer > > Acked-by: Andy Gross Applied. -- Qualcomm Innovation Center, Inc. The Qualcomm

string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
Hi, I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? That is surprising to me, especially since things like isspace() include 0x20. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[net-next PATCH v1 3/6] net: netcp: Fixes error in oversized memory allocation for statistics storage

2015-07-23 Thread WingMan Kwok
The CPSW driver keeps internally some, but not all, of the statistics available in the hw statistics modules. Furthermore, some of the locations in the hw statistics modules are reserved and contain no useful information. Prior to this patch, the driver allocates memory of the size of the the

[net-next PATCH v1 4/6] net: netcp: Consolidates statistics collection code

2015-07-23 Thread WingMan Kwok
Different Keystone2 platforms have different number and layouts of hw statistics modules. This patch consolidates the statistics processing of different Keystone2 platforms for easy maintenance. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 99

[net-next PATCH v1 6/6] net: netcp: Adds missing statistics for K2L and K2E

2015-07-23 Thread WingMan Kwok
This patch adds the missing statistics for the host and slave ports of the CPSW on K2L and K2E platforms. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 177 - 1 file changed, 174 insertions(+), 3 deletions(-) diff --git

[net-next PATCH v1 1/6] net: netcp: Fixes the use of spin_lock_bh in timer function

2015-07-23 Thread WingMan Kwok
This patch fixes a bug in which the timer routine synchronized against the ethtool-triggered statistics updates with spin_lock_bh(). A timer function is itself a bottom-half, so this should be spin_lock(). Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c |5 +++-- 1

[net-next PATCH v1 0/6] net: netcp: Bug fixes of CPSW statistics collection

2015-07-23 Thread WingMan Kwok
This patch set contains bug fixes and enhencements of hw ethernet statistics processing on TI's Keystone2 CPSW ethernet switches. v1: Removes unused defines in PATCH 3/6 based on reviewer's comment WingMan Kwok (6): net: netcp: Fixes the use of spin_lock_bh in timer function net: netcp:

[net-next PATCH v1 2/6] net: netcp: Fixes hw statistics module base setting error

2015-07-23 Thread WingMan Kwok
This patch fixes error in the setting of the hw statistics module base for K2HK platform. In K2HK although there are 4 hw statistics modules, but only 2 are visible at a time. Thus when setting up the pointers to the base of the corresponding hw statistics modules, modules 0 and 2 should point to

[net-next PATCH v1 5/6] net: netcp: Fixes to CPSW statistics collection

2015-07-23 Thread WingMan Kwok
In certain applications it's beneficial to allow the CPSW h/w stats counters to continue to increment even while the kernel polls them. This patch implements this behavior for both 1G and 10G ethernet subsystem modules. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c |

Re: [PATCH 2/2] locktorture: 'tis a slow death

2015-07-23 Thread Davidlohr Bueso
On Wed, 2015-07-22 at 17:13 -0700, Paul E. McKenney wrote: > I need to see something more than what I am seeing for me to be able > to accept this, cute though it unarguably is. heh I didn't consider copyright for this kind of stuff. And was naive to think that keeping his (what I assume to be)

[PATCH] backlight: pm8941-wled: Add default-brightness property

2015-07-23 Thread Bjorn Andersson
Add the possibility of specifying the default brightness in DT. Signed-off-by: Bjorn Andersson --- This depends on the patch moving pm8941-wled to backlight [1]. The dt property is used by several other backlight drivers, so I considered this to be a "common" property and it's hence not

Re: [PATCH v7 1/2] mfd: devicetree: add bindings for Atmel Flexcom

2015-07-23 Thread Boris Brezillon
On Thu, 23 Jul 2015 18:42:55 +0200 Cyrille Pitchen wrote: > This patch documents the DT bindings for the Atmel Flexcom which will be > introduced by sama5d2x SoCs. These bindings will be used by the actual > Flexcom driver to be sent in another patch. > > Signed-off-by: Cyrille Pitchen > --- >

Re: [PATCH block/for-linus] block: export bio_associate_*() and wbc_account_io()

2015-07-23 Thread Jens Axboe
On 07/23/2015 12:27 PM, Tejun Heo wrote: bio_associate_blkcg(), bio_associate_current() and wbc_account_io() are used to implement cgroup writeback support for filesystems and thus need to be exported. Export them. Signed-off-by: Tejun Heo Reported-by: Stephen Rothwell --- Hello, Jens.

Re: [RFC PATCH v4 1/3] tracing/events: Fix wrong sample output by storing array length instead of size

2015-07-23 Thread Alex Bennée
Steven Rostedt writes: > On Fri, 17 Jul 2015 10:32:15 -0400 > Steven Rostedt wrote: > > >> This change affects all callers of dymanic_array, not just bitmasks. >> >> >__data_size += __item_length; >> > >> > #undef __string >> >> BTW, if I revert commit ac01ce1410fc2 "tracing: Make >>

[PATCH] checkpatch: Always check block comment styles

2015-07-23 Thread Joe Perches
Some of the block comment tests that are used only for networking are appropriate for all patches. For example, these styles are not encouraged: /* block comment without introductory * */ and /* * block comment with line terminating */ Remove the

[PATCH] checkpatch: Report the right line # when using --emacs and --file

2015-07-23 Thread Joe Perches
commit 34d8815f9512 ("checkpatch: add --showfile to allow input via pipe to show filenames") broke the --emacs with --file option. Fix it. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl

Re: [PATCH V2] cpufreq: Fix double addition of sysfs links

2015-07-23 Thread Rafael J. Wysocki
On Thu, Jul 23, 2015 at 7:22 PM, Rafael J. Wysocki wrote: > Hi Viresh, > > On Thu, Jul 23, 2015 at 8:09 AM, Viresh Kumar wrote: >> On 22-07-15, 18:42, Rafael J. Wysocki wrote: >>> > 3. what happens when 'policy' is NULL at the point when the first (few) >>> > CPUs >>> >are added - how do

Re: [PATCH 2/3] cpufreq: Create links for offline CPUs that got added earlier

2015-07-23 Thread Rafael J. Wysocki
Hi Viresh, On Thu, Jul 23, 2015 at 10:13 AM, Viresh Kumar wrote: > If subsys callback ->add_dev() is called for an offline CPU, before its > policy is allocated, we will miss adding its sysfs symlink. > > Fix this by tracking such CPUs in a separate mask. > > Fixes: 9b07109f06a1 ("cpufreq: Fix

Re: [PATCH v3 1/2] iio: fix drivers that consider 0 as a valid IRQ in client->irq

2015-07-23 Thread Jonathan Cameron
On 23/07/15 15:38, Octavian Purdila wrote: > On Thu, Jul 23, 2015 at 5:05 PM, wrote: >> >> Octavian Purdila writes: >>> >>> On Fri, Jun 5, 2015 at 4:59 PM, Octavian Purdila >>> wrote: Since patch "i2c / ACPI: Use 0 to indicate that device does not have interrupt assigned" [1], 0

[PATCH v2] x86/entry/32: Remove duplicate initialization of tss.ss1

2015-07-23 Thread Andy Lutomirski
It's statically initialized, so we don't need to dynamically initialize it too. Reported-by: Brian Gerst Signed-off-by: Andy Lutomirski --- Changes since v1: Delete the code :) arch/x86/kernel/cpu/common.c | 8 1 file changed, 8 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c

Re: Kernel broken on processors without performance counters

2015-07-23 Thread Jason Baron
On 07/23/2015 10:49 AM, Peter Zijlstra wrote: > On Thu, Jul 23, 2015 at 04:33:08PM +0200, Peter Zijlstra wrote: >> Lemme finish this and I'll post it. > Compile tested on x86_64 only.. > > Please have a look, I think you said I got some of the logic wrong, I've > not double checked that. > > I'll

[PATCH v2] x86/asm/msr: Make wrmsrl() a function

2015-07-23 Thread Andy Lutomirski
As of cf991de2f614 ("x86/asm/msr: Make wrmsrl_safe() a function"), wrmsrl_safe is a function, but wrmsrl is still a macro. The wrmsrl macro performs invalid shifts if the value argument is 32 bits. This makes it unnecessarily awkward to write code that puts an unsigned long into an MSR. To make

Re: [PATCH] x86/entry/32: Initialize ss1 (SYSENTER_CS shadow) even on non-SEP CPUs

2015-07-23 Thread Andy Lutomirski
On Thu, Jul 23, 2015 at 12:03 PM, Brian Gerst wrote: > On Thu, Jul 23, 2015 at 2:56 PM, Andy Lutomirski wrote: >> native_load_sp0 relies on this. I'm not sure why we haven't seen >> reports of crashes. Maybe no one tests new kernels on non-SEP CPUs. > > It's already statically initialized in

Re: [PATCH 0/5] Freq/CPU%/CORE_BUSY% support

2015-07-23 Thread Stephane Eranian
On Thu, Jul 23, 2015 at 4:46 AM, Kan Liang wrote: > This patch set supports per-sample freq/CPU%/CORE_BUSY% print in perf > report -D and --stdio. > For printing these information, the perf.data file must have been obtained > by group read and using special events cycles, ref-cycles, msr/tsc/, >

Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description

2015-07-23 Thread Greg KH
On Thu, Jul 23, 2015 at 08:46:17AM +0200, Juergen Gross wrote: > On 07/23/2015 06:36 AM, Greg KH wrote: > >On Thu, Jul 23, 2015 at 06:04:39AM +0200, Juergen Gross wrote: > >>On 07/23/2015 01:46 AM, Greg KH wrote: > >>>On Tue, Jun 23, 2015 at 08:53:23AM +0200, Juergen Gross wrote: > Add the

[PATCH 2/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D

2015-07-23 Thread kan . liang
From: Kan Liang The group read results from cycles/ref-cycles/TSC/ASTATE/MSTATE event can be used to calculate the frequency, CPU Utilization and percent performance during each sampling period. This patch shows them in report -D. Here is an example: $ perf record -e

[PATCH 4/5] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat

2015-07-23 Thread kan . liang
From: Kan Liang Introduce a new hist_iter ops (hist_iter_freq_perf) to caculate the freq/CPU%/CORE_BUSY% freq when processing samples, and save them in hist_entry. Signed-off-by: Kan Liang --- tools/perf/builtin-annotate.c | 2 +- tools/perf/builtin-diff.c | 2 +-

[PATCH 1/5] perf,tools: introduce get_cpu_max_freq

2015-07-23 Thread kan . liang
From: Kan Liang Get cpu max frequency from the first online cpu, and save the MHz value in get_cpu_max_freq. Signed-off-by: Kan Liang --- tools/perf/builtin-report.c | 2 ++ tools/perf/util/cpumap.c| 32 tools/perf/util/cpumap.h| 2 ++ 3 files

[PATCH 5/5] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio

2015-07-23 Thread kan . liang
From: Kan Liang Show frequency, CPU Utilization and percent performance for each symbol in perf report by --stdio --show-freq-perf In sampling group, only group leader do sampling. So only need to print group leader's freq in --group. Here is an example. $ perf report --stdio --group

[PATCH 3/5] perf,tools: save misc sample read value in struct perf_sample

2015-07-23 Thread kan . liang
From: Kan Liang Save group read results from cycles/ref-cycles/TSC/ASTATE/MSTATE in struct perf_sample. The following sample process function can easily use them to caculate freq/CPU%/CORE_BUSY% and add them in hists. Signed-off-by: Kan Liang --- tools/perf/util/event.h | 11 +++

[PATCH 0/5] Freq/CPU%/CORE_BUSY% support

2015-07-23 Thread kan . liang
From: Kan Liang (Re-send. Missed "From: Kan Liang " in last mail) This patch set supports per-sample freq/CPU%/CORE_BUSY% print in perf report -D and --stdio. For printing these information, the perf.data file must have been obtained by group read and using special events cycles, ref-cycles,

[PATCH 0/5] Freq/CPU%/CORE_BUSY% support

2015-07-23 Thread Kan Liang
This patch set supports per-sample freq/CPU%/CORE_BUSY% print in perf report -D and --stdio. For printing these information, the perf.data file must have been obtained by group read and using special events cycles, ref-cycles, msr/tsc/, msr/aperf/ or msr/mperf/. - Freq (MHz): The frequency

[PATCH 2/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D

2015-07-23 Thread Kan Liang
The group read results from cycles/ref-cycles/TSC/ASTATE/MSTATE event can be used to calculate the frequency, CPU Utilization and percent performance during each sampling period. This patch shows them in report -D. Here is an example: $ perf record -e

[PATCH 4/5] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat

2015-07-23 Thread Kan Liang
Introduce a new hist_iter ops (hist_iter_freq_perf) to caculate the freq/CPU%/CORE_BUSY% freq when processing samples, and save them in hist_entry. Signed-off-by: Kan Liang --- tools/perf/builtin-annotate.c | 2 +- tools/perf/builtin-diff.c | 2 +- tools/perf/tests/hists_link.c | 4 ++--

<    1   2   3   4   5   6   7   8   9   10   >